[Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 53540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53540&action=edit
Bug 16949: Batch record deletion says success when no records have been passed
in

The reason this happens is because the page will say success when the total
number of records given equals the total number of successful deletions. If you
pass in no records, there are no successful deletions --> 0 = 0 --> it thinks
it has been successful. This patch adds a check that, firstly, there were
records to delete.

To test:
1) Go to Tools -> Batch record deletion
2) Put in a record number and click Continue
3) Deselect the record so that it doesn't actually delete and click Delete
selected records
4) Page says 'All records have been deleted successfully!'
5) Apply patch and refresh page. You may have to go back and resend the form
6) Page should now correctly say 'No record has been deleted. An error
occurred.'

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.