[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Mirko Tietgen from comment #20)
> > This Sereal module is a very thin wrapper around both Sereal::Encoder 
> > and Sereal::Decoder. It depends on both and loads both. So if you have
> > a user of both encoder and decoder, it is enough to depend on a particular 
> > version of Sereal and you'll get the most recent released versions of
> > Sereal::Encoder and Sereal::Decoder.
> 
> If that is all it does, it does not make much sense for Debian, IMHO. The
> real modules are there, just the wrapper isn't. I don't see a benefit of
> backporting this.

I have quickly tried this

diff --git a/Koha/Cache.pm b/Koha/Cache.pm
index 0f85ed1..fa4f136 100644
--- a/Koha/Cache.pm
+++ b/Koha/Cache.pm
@@ -40,7 +40,8 @@ use warnings;
 use Carp;
 use Module::Load::Conditional qw(can_load);
 use Koha::Cache::Object;
-use Sereal;
+use Sereal::Encoder;
+use Sereal::Decoder;

 use base qw(Class::Accessor);


And it seems to work correctly.
I can provide a patch if you need it.

-- 
You are receiving this mail because:
You are watching all bug changes.