[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #37 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 53536
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53536
Bug 12446 - Enable an adult to have a guarantor

Review of attachment 53536:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12446&attachment=53536)
-----------------------------------------------------------------

::: installer/data/mysql/kohastructure.sql
@@ -318,5 @@
>    `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no)
>    `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff)
>    `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions
> -  `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category
> -  `checkprevcheckout` varchar(7) NOT NULL default 'inherit', -- produce a warning for this patron category if this item has previously been checked out to this patron if 'yes', not if 'no', defer to syspref setting if 'inherit'.

Where did this go?

::: installer/data/mysql/sysprefs.sql
@@ +544,4 @@
>  ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists pages display on intranet','Free'),
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),

No to the comma!

::: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc
@@ +8,4 @@
>                      <label for="B_streetnumber">
>                  [% END %]
>                  Street Number: </label>
> +                <input type="text" id="B_streetnumber" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />

Potential cut and paste error. Nice catch.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +1019,4 @@
>                  <li data-category_code="[% patron_attribute.category_code %]">
>                      <label for="[% patron_attribute.form_id %]">[% patron_attribute.description %]: </label>
>                          <input type="hidden" id="[% patron_attribute.form_id %]_code" name="[% patron_attribute.form_id %]_code" value="[% patron_attribute.code |html %]" />
> +                        <input type="hidden" id="[% patron_attribute.form_id %]_desc" name="[% patron_attribute.form_id %]_desc" value="[% patron_attribute.description |html %]" />

If you have the code, why the description?

::: koha-tmpl/intranet-tmpl/prog/js/members.js
@@ -357,5 @@
> -        "bottom": "3%",
> -        "position": "fixed",
> -        "right": "1%",
> -        "width": "150px",
> -    } );

Why did you cut this?

::: members/memberentry.pl
@@ +236,5 @@
>      }
>  }
>  
> +#recover all data from guarantor address phone ,fax...
> +if ( $guarantorid and ( $category_type eq 'C' || $category_type eq 'P')) {

Why did you add category type? Should not any patron be able to be a guarantor
for another? If there is a guarantorid, that should be enough, right?

-- 
You are receiving this mail because:
You are watching all bug changes.