From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 00:39:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 May 2016 22:39:02 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:47:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 01:47:45 +0000 Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated word "please" in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- Same problem exists in OPAC. Maybe do it in one go? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:15:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 02:15:00 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 02:15:03 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51183|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic --- Created attachment 51938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51938&action=edit [SIGNED-OFF] Bug 16436 - Allow action logs to be logged to the koha log file Test Plan: 1) Ensure that your Koha::Logger configuration is in good working order 2) Apply this patch 3) Modify the first line of your log4perl.conf file from: log4perl.logger.intranet = WARN, INTRANET to log4perl.logger.intranet = INFO, INTRANET 4) Change a system preference setting 5) Note the new line in your log file! Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:21:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 02:21:50 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- I think this one needs rebasing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:30:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 02:30:17 +0000 Subject: [Koha-bugs] [Bug 16329] Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16329 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Ok, let's discuss. I would at least suggest prefixing with "SQL:" or similar for parsing/grepping purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:42:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 02:42:16 +0000 Subject: [Koha-bugs] [Bug 16303] Koha::Logger appenders for interfaces 'commandline' and 'sip2' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16303 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- The second file seems to be a repetition. Am I right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 06:33:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 04:33:04 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50715|0 |1 is obsolete| | --- Comment #42 from Srdjan Jankovic --- Created attachment 51939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51939&action=edit [SIGNED-OFF] bug_15562: Multi-host helper for plack installations Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context() and restore_context() are synched with database set_schema() and restore_schema(). Created run_within_context() that wraps set_context() and restore_context() around code. * Created Koha::Handler::Plack* to facilitate running same code within different (database) contexts. * This initial version does not run with memcached turned on. Next patch will correct that. https://bugs.koha-community.org/show_bug.cgi?id=15562 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 06:33:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 04:33:23 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50870|0 |1 is obsolete| | --- Comment #43 from Srdjan Jankovic --- Created attachment 51940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51940&action=edit bug_15562: Removed Koha::Cache->get_instance() There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context. Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 06:55:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 04:55:43 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|NEW |In Discussion --- Comment #1 from M. Tompsett --- This line in C4/Auth_with_cas.pm is the culprit of all those warns: my $context = C4::Context->new() or die 'C4::Context->new failed'; Comment it out and run 'prove t' and you are back to the basic mess that is expected. Sadly, I believe it is necessary, even though $context is not used. What do you think, Marcel? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 07:49:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 05:49:15 +0000 Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated word "please" in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 --- Comment #5 from Marc V?ron --- (In reply to Srdjan Jankovic from comment #4) > Same problem exists in OPAC. Maybe do it in one go? Ah, yes. opac-auth.tt lines 90 and following. This could go to Bug 16540: Translatability in opac-auth.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 07:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 05:49:55 +0000 Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated word "please" in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16540 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 07:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 05:49:55 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16620 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 07:53:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 05:53:20 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #7 from Marc V?ron --- There are more issues, opac-auth.tt lines 90 and following. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:04:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 06:04:31 +0000 Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:04:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 06:04:34 +0000 Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51914|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 51941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51941&action=edit Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available TEST PLAN --------- 1) prove t/Prices.t -- failure 2) apply patch 3) prove t/Prices.t -- nicely skipped when Test::DBIx::Class is not available. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:15:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 06:15:37 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 --- Comment #2 from Marcel de Rooy --- I think btw we could at least do: if( $cas ) { require C4::Auth_with_cas; # no import } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:32:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 06:32:43 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 --- Comment #3 from Marcel de Rooy --- (In reply to M. Tompsett from comment #1) > This line in C4/Auth_with_cas.pm is the culprit of all those warns: > > my $context = C4::Context->new() or die 'C4::Context->new failed'; > > Comment it out and run 'prove t' and you are back to the basic mess that is > expected. Sadly, I believe it is necessary, even though $context is not used. > > What do you think, Marcel? Just running Prices.t with this line changed to my $context; does not resolve my warnings with a missing KOHA_CONF. If I am adding a fake KOHA_CONF without db password, no warns. (Should be kind of equal to stopping the sql server.) So, more fundamental is: if we put a test in t and we do not want database access, should the test need existence of koha-conf (without database access info)? Of course, some tests may do completely without it. Should we mock it somehow in an early begin block? Making a distinction between tests with conf and without would be a bridge too far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:33:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 06:33:45 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 06:58:26 +0000 Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to Owen Leonard from comment #3) > We should consider looking for an upgrade or replacement which would fix Bug > 11827. Hi Owen, this one looks quite good... http://antenna.io/demo/jquery-bar-rating/examples/ I did spot this list too... https://www.sitepoint.com/10-jquery-rating-plugins/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:01:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 09:01:00 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #47 from Koha Team Lyon 3 --- work as descibe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:13:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 09:13:37 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #4 from Jacek Ablewicz --- (In reply to M. Tompsett from comment #1) > This line in C4/Auth_with_cas.pm is the culprit of all those warns: > > my $context = C4::Context->new() or die 'C4::Context->new failed'; > > Comment it out and run 'prove t' and you are back to the basic mess that is > expected. Sadly, I believe it is necessary, even though $context is not used. Hm, why do you think this call is necessary in C4/Auth_with_cas.pm? It caught my attention because I was planning to post a patch which eliminates C4::Context->new() calls in C4/Auth_with_cas.pm and in Koha/Database.pm (config file is being parsed 3 times for an average Koha script for no aparent reason, this is bad for performance). I've concluded that both those calls are 100% redundant, but maybe I overlooked something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:23:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 09:23:18 +0000 Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a field is mapped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 --- Comment #9 from Marcel de Rooy --- Just adding to the discussion, this is a specific context. We are looking at items. And only looking at default values to use when an item field would be empty. And maybe adding somewhat more weight, the default framework by standard does not even contain any other default value than NULL.. Since this patch theoretically does the right thing and its change of behavior may probably be quite limited (only impacting local defaults for items), I still would support to push it to master. We c/should add a dbrev with a warning about this change. Or even copy (in this dbrev) all item defaults from the current default framework to other frameworks (not overwriting not-null values), more or less ensuring unchanged behavior? Note that not-null items defaults currently are not used in this context, but it seems better not to overwrite them without consent. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 12:01:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 10:01:14 +0000 Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search results at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com --- Comment #3 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Jonathan Field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 12:01:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 10:01:26 +0000 Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search results at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 12:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 10:01:34 +0000 Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search results at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 51942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51942&action=edit Bug 16551: Display the name of lists to the search results at the OPAC This new enhancement will allow to add the name of lists containing a biblio to the search results at the OPAC. Test plan: 0/ Regenerate the css file to get the style change: % lessc --clean-css="--s0 --advanced --compatibility=ie7" koha-tmpl/opac-tmpl/bootstrap/less/opac.less > koha-tmpl/opac-tmpl/bootstrap/css/opac.css 1/ Create some lists and add items to them 2/ On the search results you should see the name of the lists which contains the record. Note that we could add a syspref to make this new behavior optional. Sponsored-by: University of the Arts London Signed-off-by: Owen Leonard Signed-off-by: Jonathan Field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 12:47:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 10:47:55 +0000 Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default holdings sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com --- Comment #5 from Jonathan Field --- (In reply to Jonathan Druart from comment #4) > (In reply to Owen Leonard from comment #2) > > When I have OPACHoldingsDefaultSortField set to "Home library" and > > OpacLocationBranchToDisplay set to "home library" the sorting is on the > > "Collection" column instead of the home library one. > > Indeed, the tests are a bit more complicated :) > Thanks for testing Owen! Unless I'm misunderstanding this, on my sandbox, it sorts correctly with OPACHoldingsDefaultSortField -> Home library - OpacLocationBranchToDisplay -> home library - Sorts on third column, "Collection" - OpacLocationBranchToDisplay -> holding library - (Not applicable) - OpacLocationBranchToDisplay -> home and holding library - Good That is, the Home Library column is selected and active. My column layout is Item type, Home Library, Collection, Call #, Status, Due Date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 13:50:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 11:50:15 +0000 Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default holdings sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #6 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 13:50:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 11:50:27 +0000 Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default holdings sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 13:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 11:50:35 +0000 Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default holdings sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 --- Comment #7 from PTFS Europe Sandboxes --- Created attachment 51943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51943&action=edit Bug 16552: Add the ability to change the default holdings sort This new enhancement will add the ability to change the default holdings sort on OPAC displays to be by library, instead of item type. This patch adds a new pref OPACHoldingsDefaultSortField with 3 different possible values: - Item type - Home library - Holding library Note that if OpacLocationBranchToDisplay is set not to display home libraries, unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to "Home library", same for "Holding library". Test plan: - Confirm that the default value for OPACHoldingsDefaultSortField is 'first column' after executing the DB entry and that there is no change in the behavior (first column is used to sort the holdings table on the detail page). - Set OpacLocationBranchToDisplay to both and play with the different values of OPACHoldingsDefaultSortField => Confrm that the default column used to sort the table is correctly changed - Set the pref SeparateHoldings on => Confirm that both tables (Holdings and other holdings) are sorted using the OPACHoldingsDefaultSortField value. Sponsored-by: University of the Arts London Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 14:21:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 12:21:55 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #0) > It won't be a big deal to hit the DBMS to get a valid letter when needed. Hm. Not sure. getletter is called by GetPreparedLetter, SendCirculationAlert, etc. In loops ? -# FIXME: using our here means that a Plack server will need to be -# restarted fairly regularly when working with this routine. -# A better option would be to use Koha::Cache and use a cache -# that actually works in a persistent environment, but as a -# short-term fix, our will work. Why not use this opportunity to add caching? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 15:19:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 13:19:52 +0000 Subject: [Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 15:19:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 13:19:54 +0000 Subject: [Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51811|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 51944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51944&action=edit Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: >From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 15:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 13:20:17 +0000 Subject: [Koha-bugs] [Bug 16565] additional_fields and additional_field_values are not dropped in kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 15:22:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 13:22:00 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Attachment #51879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 15:24:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 13:24:40 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > (In reply to Jonathan Druart from comment #0) > > It won't be a big deal to hit the DBMS to get a valid letter when needed. > > Hm. Not sure. getletter is called by GetPreparedLetter, > SendCirculationAlert, etc. In loops ? > > -# FIXME: using our here means that a Plack server will need to be > -# restarted fairly regularly when working with this routine. > -# A better option would be to use Koha::Cache and use a cache > -# that actually works in a persistent environment, but as a > -# short-term fix, our will work. > > Why not use this opportunity to add caching? Because I have not found anywhere it's called many times. As I wrote previously, I am not sure it'd be interesting to cache it, but I may be wrong. If we decide to cache it, we need to make sure the values in cache are deleted when letters are updated/deleted. Anyway it will be a much bigger patch and more an enhancement than a bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 16:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 14:44:02 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #8 from Marc V?ron --- I went through the file to locate more translation issues. The current indentation makes it difficult to read. That's why I'll try to clean up indentation as well. Otherwise it is difficult to be sure that changes do not have unwanted side effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 16:54:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 14:54:42 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 --- Comment #5 from M. Tompsett --- This is crazy. I do a fresh git install on Debian SID (yes, I know it's SID), and install the elastic search stuff, and cpan2deb missing (or ones with too low versions) koha perl deps. Everything seems to actually be working as expected. export unset KOHA_CONF drop database koha_library; sudo service mysql stop -- possibly be more aggressive in making sure there is no DB. :) prove t -- dies horribly in 00-load.t git bz apply 16618 prove t -- finished, but fails because of Price.t git bz apply 16582 prove t -- some noise as expected, but passes. The "Need Test::DBIx::Class" messages would make you think that they need the DB, but actually, they are only looking for the schema of the tables so they can mock test things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 16:56:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 14:56:58 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 --- Comment #9 from Marc V?ron --- Created attachment 51945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51945&action=edit Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 16:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 14:57:21 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 16:59:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 14:59:27 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 --- Comment #6 from M. Tompsett --- > (M. Tompsett from comment #1) > This line in C4/Auth_with_cas.pm is the culprit of all those warns: > my $context = C4::Context->new() or die 'C4::Context->new failed'; > Comment it out and run 'prove t' and you are back to the basic mess that is > expected. Sadly, I believe it is necessary, even though $context is not > used. > (Jacek Ablewicz from comment #4) > Hm, why do you think this call is necessary in C4/Auth_with_cas.pm? [SNIP] > I've concluded that both those calls are 100% redundant, but maybe > I overlooked something? While you are likely correct, I didn't trace it completely, my worry is the order in which things are run. There may be an accidental order dependency in terms of the caching, object creation, or whatever. We don't have full test coverage, so I don't know if something will break. I believe there "... be dragons". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 17:06:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 15:06:03 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 17:16:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 15:16:44 +0000 Subject: [Koha-bugs] [Bug 16631] New: Show groups/categories of reports to authorized staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 Bug ID: 16631 Summary: Show groups/categories of reports to authorized staff Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be helpful to have reports that are specific groups/categories to be authorized under the reports permissions in a patron account. Not everyone wants to see everyone else's reports, some are similar but are not. Some are for superlibrarians to test, and are not ready for use. It would be great if we could specify groups and even subgroups in the permissions that the staff could access, or specify all groups. All groups should be the norm for a superlibrarian. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 17:43:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 15:43:35 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 18:09:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 16:09:11 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 --- Comment #3 from Marcel de Rooy --- Created attachment 51946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51946&action=edit Bug 16610: [QA Follow-up] Add a test To verify the original patch, this test shows that before applying it the Patron Info request did not return CQ==N for an empty password. Note that the Patron Status did btw. After applying the original patch, the test passes for patron info as well as status. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 18:09:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 16:09:08 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 18:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 16:09:15 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 --- Comment #4 from Marcel de Rooy --- Created attachment 51947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51947&action=edit Bug 16610 - Regression in SIP2 user password handling Previous to bug 14507, SIP2 only did internal authentication. A change to the way we check empty passwords has caused any empty password to send back a CQ of Y. Previous to that patch set, a CQ of Y would only be sent back of the patron password column was NULL. Now, an empty AD field *always* returns a CQ of Y. Test Plan: 1) Send a patron information request with an empty AD field Note: You must send the AD field or you won't get back a CQ field 2) Note you get back a CQ of Y 3) Apply this patch 4) Repeat step 1 5) Note you now get back a CQ of N Signed-off-by: Trent Roby Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 18:09:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 16:09:45 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 18:10:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 16:10:07 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 19:43:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 17:43:30 +0000 Subject: [Koha-bugs] [Bug 16632] New: When placing hold in OPAC patron has to search, log in and then search again Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16632 Bug ID: 16632 Summary: When placing hold in OPAC patron has to search, log in and then search again Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: amy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org >From one of our partners: When a patron chooses to place a hold from the from the OPAC details screen for an item, the system does not display the bib record of the item but takes you to your account login, then your account. Then patron must search for the title again, and ask to place a hold again before it is confirmed. I have confirmed this behavior. I think the requested behavior is for the OPAC to retain the search after the patron logs in so that the search doesn't have to be repeated again to get to the item they want to place the hold on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:03:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:03:35 +0000 Subject: [Koha-bugs] [Bug 15507] New notice for patrons that owe money In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15507 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 16149 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:03:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:03:35 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #1 from Nicole C. Engard --- *** Bug 15507 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:10:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:10:46 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard --- I see one typo: "

If you have a CAS account, please please choose against which one you would like to authenticate:

" There is an extra "please." As long as we are making changes to this page, I have a couple of other suggestions: - "Logout and try again with a different user" should use "Log out" instead. - "If you have a Shibboleth account, please click here to login." should use "log in" instead of "login." - "

Please click here to login.

" Use "log in" instead. - "

If you have a CAS account, please click here to login.

" Use "log in" instead. I looked for guidance for this on the terminology page on the wiki (https://wiki.koha-community.org/wiki/Terminology) and could not find it, but in my opinion it is analogous to this rule: "Use 'checkout' as a noun, 'check out' as a verb." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:25:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:25:28 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51945|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 51950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51950&action=edit Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:29:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:29:48 +0000 Subject: [Koha-bugs] [Bug 16632] When placing hold in OPAC patron has to search, log in and then search again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16632 --- Comment #1 from Owen Leonard --- I think this is Bug 15816, and should already be resolved in all the latest releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:38:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:38:10 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 20:53:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 18:53:13 +0000 Subject: [Koha-bugs] [Bug 16632] When placing hold in OPAC patron has to search, log in and then search again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16632 --- Comment #2 from Amy Kearns --- Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 21:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 19:07:53 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 21:07:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 19:07:55 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51950|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 51951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51951&action=edit [SIGNED-OFF] Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 21:28:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 19:28:33 +0000 Subject: [Koha-bugs] [Bug 16633] New: Translatability: Issues in tags/review.tt (sentence splitting) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633 Bug ID: 16633 Summary: Translatability: Issues in tags/review.tt (sentence splitting) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Fix translation issues in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt (isolated words by sentence splitting). Example: Date from is not a legal value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 21:28:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 19:28:52 +0000 Subject: [Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 21:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 19:42:23 +0000 Subject: [Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633 --- Comment #1 from Marc V?ron --- Created attachment 51952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51952&action=edit Bug 16633: Translatability: Issues in tags/review.tt (sentence splitting) This patch fixes translatability issues in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt (isolated words by sentence splitting). To test: - Review code and verify that changes make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 21:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 19:44:14 +0000 Subject: [Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 22:30:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 20:30:06 +0000 Subject: [Koha-bugs] [Bug 16634] New: Translatability: Fix issue in memberentrygen.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634 Bug ID: 16634 Summary: Translatability: Fix issue in memberentrygen.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Fix a translatability issue in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt (sentence splitting). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 22:30:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 20:30:37 +0000 Subject: [Koha-bugs] [Bug 16634] Translatability: Fix issue in memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 22:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 20:41:38 +0000 Subject: [Koha-bugs] [Bug 16634] Translatability: Fix issue in memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634 --- Comment #1 from Marc V?ron --- Created attachment 51953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51953&action=edit Bug 16634: Translatability: Fix issue in memberentrygen.tt This patch fixes a small translatability issue in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt The sentence following sentence was splitted by HTML tags: "Attribute value xxxxx is already in use by another patron record." To test: - Review code - Apply patch - In Admin, create a unique patron attribute type and try to give two patrons the same value for this attribute type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 22:42:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 20:42:46 +0000 Subject: [Koha-bugs] [Bug 16634] Translatability: Fix issue in memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 22:51:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jun 2016 20:51:18 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #21 from Marc V?ron --- Patch does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging admin/patron-attr-types.pl Auto-merging C4/Members/AttributeTypes.pm CONFLICT (content): Merge conflict in C4/Members/AttributeTypes.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:40:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:40:58 +0000 Subject: [Koha-bugs] [Bug 16635] New: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 Bug ID: 16635 Summary: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com According to http://perldoc.perl.org/vars.html, "our" should be a reasonable substitute for the "use vars". By declaring as "our", and removing the INIT, prove t/00-load will no longer generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm module. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l hbyymmincr | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:43:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:43:07 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:43:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:43:10 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 --- Comment #1 from M. Tompsett --- Created attachment 51954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51954&action=edit Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm According to http://perldoc.perl.org/vars.html, "our" should be a reasonable substitute for the "use vars". By declaring as "our", and removing the INIT, prove t/00-load will no longer generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm module. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l hbyymmincr | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:46:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:46:06 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:46:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:46:09 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51954|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 51955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51955&action=edit Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm According to http://perldoc.perl.org/vars.html, "our" should be a reasonable substitute for the "use vars". By declaring as "our", and removing the INIT, prove t/00-load will no longer generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm module. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l hbyymmincr | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:46:23 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16635 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:46:23 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:46:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:46:41 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:58:42 +0000 Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated word "please" in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 02:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 00:58:45 +0000 Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated word "please" in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51922|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 51956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51956&action=edit [SIGNED-OFF] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:08:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:08:12 +0000 Subject: [Koha-bugs] [Bug 16636] New: t/00-load.t warning from C4/External/BakerTaylor.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Bug ID: 16636 Summary: t/00-load.t warning from C4/External/BakerTaylor.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:08:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:08:49 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:08:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:08:49 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16636 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:10:41 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:10:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:10:43 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 --- Comment #1 from M. Tompsett --- Created attachment 51957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51957&action=edit Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:29:53 +0000 Subject: [Koha-bugs] [Bug 16637] New: t/00-load.t warning from C4/Tags.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637 Bug ID: 16637 Summary: t/00-load.t warning from C4/Tags.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Added optional dependency, so as to explain why testing explodes when the Enhanced Content system preference TagsExternalDictionary is set. Since INIT runs after BEGIN, moved INIT logic into BEGIN in order to remove INIT and thus eliminate the warning. TEST PLAN --------- 1) prove t/00-load.t -- warning about INIT for C4::Tags 2) prove `git grep -l Tags | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:30:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:30:13 +0000 Subject: [Koha-bugs] [Bug 16637] t/00-load.t warning from C4/Tags.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:30:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:30:13 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16637 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:32:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:32:46 +0000 Subject: [Koha-bugs] [Bug 16637] t/00-load.t warning from C4/Tags.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:32:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:32:48 +0000 Subject: [Koha-bugs] [Bug 16637] t/00-load.t warning from C4/Tags.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637 --- Comment #1 from M. Tompsett --- Created attachment 51958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51958&action=edit Bug 16637: t/00-load.t warning from C4/Tags.pm Added optional dependency, so as to explain why testing explodes when the Enhanced Content system preference TagsExternalDictionary is set (/usr/bin/ispell). Since INIT runs after BEGIN, moved INIT logic into BEGIN in order to remove INIT and thus eliminate the warning. TEST PLAN --------- 1) prove t/00-load.t -- warning about INIT for C4::Tags 2) prove `git grep -l Tags | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 03:55:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 01:55:42 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 --- Comment #8 from M. Tompsett --- I think this bug is best suited for the DBIx Mock related warnings, as the INIT warnings currently in t/00-load.t have been dealt with in bug 16635, bug 16636, and bug 16637. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 04:42:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 02:42:57 +0000 Subject: [Koha-bugs] [Bug 16638] New: Business::ISBN versioning scheme says it needs upgrade, but doesn't Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16638 Bug ID: 16638 Summary: Business::ISBN versioning scheme says it needs upgrade, but doesn't Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: vanoudt at gmail.com QA Contact: testopia at bugs.koha-community.org Busy upgrading to 16.05 at the moment, and have noticed an issue with Business::ISBN. Here on Fedora (using my KohaExtra repository: dnf copr enable vanoudt/KOHAExtra ) Business::ISBN is at version 2.010. That's a 10 at the end, as opposed to a 5 which the required version (2.05) asks for. It's a weird numbering scheme, but the changelog shows that 2.010 is actually a later release than 2.05 . Naturally, koha_perl_deps.pl tells me that this module requires updating... but it doesn't. Not sure what the right fix here is... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 05:08:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 03:08:00 +0000 Subject: [Koha-bugs] [Bug 16303] Koha::Logger appenders for interfaces 'commandline' and 'sip2' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16303 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- (In reply to Srdjan Jankovic from comment #5) > The second file seems to be a repetition. Am I right? Yes, the smaller one seems like a partial duplicate of the larger one. Though, I think Kyle's comment #3 about bug 15253 seems like something that should be dealt with first in terms of interaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 05:13:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 03:13:29 +0000 Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Oops... duplicated effort, but for different reasons. See bug 16637. I think adding the PerlDependencies.pm for Lingua::Ispell might be an idea. Otherwise you may get an explosion when you fill it in with the default value /usr/bin/ispell, because Lingua::Ispell isn't guaranteed to be installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 07:41:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 05:41:25 +0000 Subject: [Koha-bugs] [Bug 16638] Business::ISBN versioning scheme says it needs upgrade, but doesn't In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16638 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5599 --- Comment #1 from Marc V?ron --- This is related to Bug 5599 - koha_perl_deps.pl and PerlDependencies.pm don't compare $VERSION numbers correctly. To get more information in such cases, I introduced Bug Bug 12790 - Perl modules: Display required version numbers on about page Bug 5599 got a temporary fix for Graphics::Magick - 'min_ver' => '1.3.5' + 'min_ver' => '1.3.05' This is a similar case (2.05 vs 2.010). There are other issues waiting, e.g. File::Path (2.07) 2.08_01 (compares correctly at the moment, but what about something like 2.08_01 vs 2.09 ?) Maybe the following helps to get a sustainable solution: http://stackoverflow.com/questions/19973852/perl-compare-version-numbers-5-1-5-10 Answer 6: print version->declare('5.1')->numify; # 5.00100 print version->declare('5.10')->numify; # 5.01000 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 07:41:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 05:41:25 +0000 Subject: [Koha-bugs] [Bug 5599] koha_perl_deps.pl and PerlDependencies.pm don't compare $VERSION numbers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5599 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16638 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 08:11:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 06:11:15 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 --- Comment #13 from Nicholas van Oudtshoorn --- Created attachment 51959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51959&action=edit Attempt to fix Hmmmm - got the same problem happening with the system upgraded to 16.05. If I search for something such as "worship", I get the first page. But the pager creates links of the form: https://library.pbc.wa.edu.au/cgi-bin/koha/opac-search.pl?q=worship%20%23relevance_asc&offset=20&sort_by=relevance_asc Clicking on such a link brings up a "No results found" page. Modifying this link to be of the form: https://library.pbc.wa.edu.au/cgi-bin/koha/opac-search.pl?q=worship&offset=20&sort_by=relevance_asc that is, removing the %20%23relevance_asc , allows the search to work. This also happens on Intranet searches. The attached fix seems to fix it, but I'm pretty sure it's just tidying over a problem elsewhere... Note: our site is currently live with this fix applied. But you can see the old behaviour by clicking on the first link above! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 08:35:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 06:35:15 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 08:42:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 06:42:45 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - activate cronjob by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Mason James --- Patch included in 3.22.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 08:49:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 06:49:02 +0000 Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:04:56 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51445|0 |1 is obsolete| | --- Comment #37 from Marc V?ron --- Created attachment 51960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51960&action=edit Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Re-tested together with followup, works as expected (2016-06-02) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:06:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:06:10 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51446|0 |1 is obsolete| | --- Comment #38 from Marc V?ron --- Created attachment 51961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51961&action=edit Bug 3534 - QA Followup - use floating save I am not sure if this is desired, it makes sense for consistency but floats in a wierd place for a short form. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:06:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:06:43 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:10:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:10:04 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:58:20 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 --- Comment #9 from Marc V?ron --- I suppose patch Bug 10472 - Receipt by line or invoice was attached to this bug 10440 by mistake. I obsolete it and reactivate the obsoleted patch "Flag holds against receipted items" for more testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:58:42 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38120|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 09:59:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 07:59:01 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19212|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 10:17:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 08:17:41 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 10:18:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 08:18:29 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38120|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 10:31:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 08:31:54 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #10 from Marc V?ron --- Findings: - The latest patch attached to this bug does the same as Bug 10472 - It does not do what is advertised in the test plan of the first commit: 1. Create a basket. 2. Create orders under basket and close the basket. 3. Click on Receive shipment button and give the invoice number and shipment date. 4. Click on Receive. If item is on hold one warning message will display "Holds on this title. Please order some more copies." - The first patch does no longer apply, and it seems to be similar to the second patch (does not do what is advertised). - There is a similar Bug 10436 - Identify Holds During receipting that was resolved as duplicate. I set this one to "In Discussion". Maybe the original intention (Warn about holds while receiving) could be go to a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 11:36:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 09:36:02 +0000 Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Maybe the error occurs when the cookie is created (line 479). Just a guess after reading: http://stackoverflow.com/questions/1384702/should-i-use-storable-or-freezethaw-to-serialize-perl-data-as-a-cookie-value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 11:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 09:39:03 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #10 from Magnus Enger --- I am trying to test this, but after applying the patches (and fixing some conflicts), I get this error when I try to do a search, both in the OPAC and the intranet: Can't locate object method "fields" via package "DBI::db" at /home/kohaadmin/kohaclone/C4/Biblio.pm line 2673. Line 2673 looks like this: MARCFIELD: foreach my $field ( $record->fields() ) { I'll try to figure out the problem, but if anyone got any hunches I'm all ears! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 11:43:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 09:43:52 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Circulation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 11:47:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 09:47:47 +0000 Subject: [Koha-bugs] [Bug 14843] Notifications and messages via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 12:05:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 10:05:49 +0000 Subject: [Koha-bugs] [Bug 16617] debian/control is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #6 from Benjamin Rokseth --- You seem to have missed a second EEK ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 12:13:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 10:13:34 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #11 from Magnus Enger --- Never mind me, I was applying the patches on the 3.22.x branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 12:40:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 10:40:57 +0000 Subject: [Koha-bugs] [Bug 16639] New: Split item data from description in Fines tab into separate columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639 Bug ID: 16639 Summary: Split item data from description in Fines tab into separate columns Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: theod at lib.auth.gr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As an alternative approach to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 , it would be far better if separate "Barcode", "Due Date" and "Branch" columns were created in the Fines->Account table and Fines->Pay Fines So, my proposal for the for the Fines->Account table would be something like: Date | Description of charges | Barcode | Due Date | Branch | Note | Amount | Outstanding | Print And accordingly for the Fines->Pay Fines table: Fines & charges | Description | Barcode | Due Date | Branch | Payment note | Account type | Notify id | Level | Amount | Amount outstanding (The new tables /seem/ to have many columns to fit into the screen, but the "Description" column doesn't have to be as long as it used to, so the result will fit) Be warned that this approach assumes also that separate columns should be created in the accountlines db table to hold (at least) the branchcode (and/or the item barcode). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 12:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 10:41:22 +0000 Subject: [Koha-bugs] [Bug 16639] Split item data from description in Fines tab into separate columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16461 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 12:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 10:41:22 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16639 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 12:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 10:50:44 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 --- Comment #4 from Theodoros Theodoropoulos --- Based on the case description, the proposed fix does the trick. However, in order to keep track of the 'more advanced' solution that we would like to have, I created separate RFE: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 13:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 11:04:05 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44317|0 |1 is obsolete| | Attachment #44318|0 |1 is obsolete| | CC| |ere.maijala at helsinki.fi --- Comment #15 from Ere Maijala --- Created attachment 51962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51962&action=edit Bug 15108 - OAI-PMH provider improvements This is an initial attempt at improving the OAI-PMH provider (on master branch). The following improvements are included: - Fixed date handling to use UTC as specs require. - Added support for deleted records. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in timestamp order (faster than biblionumber order with the new index). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 13:05:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 11:05:28 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #16 from Ere Maijala --- It would be great if others could try this out and see if it works for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 13:56:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 11:56:29 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #12 from Magnus Enger --- When you are on the "MARC field permissions" page, "MARC field permissions" is not shown in the left hand menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 16:05:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 14:05:47 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 16:05:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 14:05:51 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19472|0 |1 is obsolete| | Attachment #19473|0 |1 is obsolete| | Attachment #19474|0 |1 is obsolete| | Attachment #19475|0 |1 is obsolete| | --- Comment #71 from Kyle M Hall --- Created attachment 51963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51963&action=edit Bug 7441 - search results showing wrong branch? When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the CURRENT BRANCH in the holdings table which is very confusing to patrons. I don't know what's the right solution - home or holding branch, but they should be the same in both places for the patron's sake. If you do the same search in the staff client you see the right branch info on the search results and on the detail page. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Search the catalog, you search should include results with items that have different home and holding libraries. 4) The results should look the same as before the patch 5) Change the system preference OPACResultsLibrary to "current location" 6) Refresh your page of search results 7) The results show now show the holding library instead of the home library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 16:37:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 14:37:00 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 17:26:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 15:26:18 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #48 from Nicole C. Engard --- Does that mean you sign off on this patch? If so please go ahead and submit a sign off. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 17:26:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 15:26:32 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 18:19:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 16:19:18 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #49 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 18:19:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 16:19:36 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 18:19:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 16:19:45 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #50 from sandboxes at biblibre.com --- Created attachment 51964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51964&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 18:41:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 16:41:06 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 19:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 17:51:20 +0000 Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 [Bug 16640] Move actions on acquisitions receipt summary page into menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 19:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 17:51:20 +0000 Subject: [Koha-bugs] [Bug 16640] New: Move actions on acquisitions receipt summary page into menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Bug ID: 16640 Summary: Move actions on acquisitions receipt summary page into menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=x OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org, veron at veron.ch Depends on: 16592 Created attachment 51965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51965&action=edit Screenshot showing one part of the proposed change I propose to consolidate some links on the acquisitions receipt summary page into menus: - MARC and Card view - Receive, transfer, cancel etc. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 [Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 2 22:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jun 2016 20:08:36 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #28 from M. Tompsett --- There is no conflict. Applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:06:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:06:02 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:06:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:06:04 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 --- Comment #2 from Nick Clemens --- Created attachment 51966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51966&action=edit Bug 11606 - Add nvelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:24:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:24:31 +0000 Subject: [Koha-bugs] [Bug 16641] New: Update Novelist in opac to use updated call to fetch content Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Bug ID: 16641 Summary: Update Novelist in opac to use updated call to fetch content Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Moved from bug 11606: 3) Update the Koha OPAC code to use loadContentForQuery rather than the deprecated loadContentForISBN Additionally only display content if results are retrieved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:24:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:24:49 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 --- Comment #3 from Nick Clemens --- Opac update moved to bug 16641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:27:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:27:23 +0000 Subject: [Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:27:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:27:25 +0000 Subject: [Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 --- Comment #1 from Nick Clemens --- Created attachment 51967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51967&action=edit Bug 16641 - Update Novelist in opac to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:28:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:28:09 +0000 Subject: [Koha-bugs] [Bug 16641] Update Novelist in opac to use updated call to fetch content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 03:28:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 01:28:23 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 08:35:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 06:35:56 +0000 Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given code deleted if that attribute has branch limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 08:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 06:39:39 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 08:46:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 06:46:59 +0000 Subject: [Koha-bugs] [Bug 16638] Business::ISBN versioning scheme says it needs upgrade, but doesn't In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:24:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:24:26 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #56 from Brendan Gallagher --- This should be ready for QA - the created_on addition should be done in another bug - since that is a different issue than this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:29:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:29:00 +0000 Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 --- Comment #3 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > Oops... duplicated effort, but for different reasons. See bug 16637. I think > adding the PerlDependencies.pm for Lingua::Ispell might be an idea. > Otherwise you may get an explosion when you fill it in with the default > value /usr/bin/ispell, because Lingua::Ispell isn't guaranteed to be > installed. I'd prefer to keep this one (especially because I have already submitted other patches using the "does not work under plack" pattern in commit msg). And maybe create another one for the missing deps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:31:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:31:31 +0000 Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #20 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:40:04 +0000 Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation, first implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #9 from Magnus Enger --- 4 years... Could this be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:42:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:42:15 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:42:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:42:19 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51906|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 51968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51968&action=edit Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago Using a DateTime object with a timezone of America/Santiago was causing fatal errors for Koha::Calendar->is_holiday and Koha::Calendar->exception_holidays, when the objects were truncated to an invalid local time. Using a floating zone allows us to use the same day, month, year for comparison purposes without running into the possibility of creating an invalid local time and thus a fatal software error. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:42:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:42:49 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #30 from Alex Sassmannshausen --- The 'Frequency' authorized value category does not exist, so I cannot add an entry there. Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:49:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:49:05 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50547|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 51969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51969&action=edit Bug 16324: Move item search into header This patch makes the Search button in the header into a dropdown that holds the Advanced search and the Item search. This should be applied on top of Bug 16323 so that the dropdowns open on hover and don't require the extra click to open. To test: 1) Apply 16323 2) Hover over Search menu in header and confirm it opens 3) Confirm that Advanced search and Item search are there and both links work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:49:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:49:18 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 joachim.ganseman at ehb.be changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joachim.ganseman at ehb.be --- Comment #2 from joachim.ganseman at ehb.be --- I guess the easiest way, in order not to complicate the MARC framework even more, would be to add a two columns with default values (or just leave them empty to have no default) in the default MARC framework, then in the MARC Framework editing screen add a possibility to set a default value just as for the regular subfields. Checking for some impossible or incorrect combinations (like the previously mentioned indicator 7 if 650$2 exists), could maybe be moved to a general "consistency check" routine that happens after editing the record. Or to a plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:50:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:50:37 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely at arts.ac.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:55:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:55:54 +0000 Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:55:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:55:57 +0000 Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51247|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 51970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51970&action=edit Bug 16455: Remove the "Too late to run INIT block" from C4::Tags The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an other dictionary, different from the default one (/usr/bin/ispell). To do so we need to set $Lingua::Ispell::path to the expected path. It's currently done in the INIT block. If you try to use C4::Tags, you will get the famous "Too late to run INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to load functions at run time, when we are using C4::Tags when hitting a pl script, the compilation phase is finished and it's "too late to run INIT block" from C4::Tags. I do not really know if it has an impact on the behavior of Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT block is not executed when we want. Test plan: under Plack, - hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no longer appears - Use another dictionnary (??), fill TagsExternalDictionary with its path and confirm that it is used by the tags approval system Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 09:59:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 07:59:25 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 joachim.ganseman at ehb.be changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |joachim.ganseman at ehb.be -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:10:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:10:18 +0000 Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:11:28 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #11 from Fr?d?ric Demians --- ./translate update fr-FR raises this error: system call failed: /usr/bin/xgettext -L JavaScript -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:20:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:20:44 +0000 Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:21:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:21:53 +0000 Subject: [Koha-bugs] [Bug 16642] New: Fix capitalisation for upload patron image Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16642 Bug ID: 16642 Summary: Fix capitalisation for upload patron image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: c.gravely at arts.ac.uk QA Contact: testopia at bugs.koha-community.org When patronimages is turned on, capitalisation on staff interface is incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:22:02 +0000 Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and cancel operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:22:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:22:06 +0000 Subject: [Koha-bugs] [Bug 16642] Fix capitalisation for upload patron image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16642 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |c.gravely at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:36:16 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #9 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Eleftheria -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:36:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:36:32 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:36:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:36:36 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:36:44 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 51971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51971&action=edit Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches This patch alters C4::Utils::DataTables::Members::search to autodetect if the searchmember parameter is a date and search by DOB if so To test: 1 - Apply patch 2 - Search for members by DOB formatted as per dateformat syspref or mysql format 3 - Results should be returned as expected 4 - Search combined with other terms, results should be returned as expected 5 - Search for patrons without using dates, results should be as expected 6 - Search using search fields 'Date of birth' from expanded menu on patron search - results should be returned as before (Note dying on incorrect format is an existing bug) 7 - prove t/db_dependent/Utils/Datatables_Members.t Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/) Signed-off-by: Eleftheria -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:36:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:36:47 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 51972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51972&action=edit Bug 14874 - (followup) Refactor t/db_dependent/Utils/Datatables_Members.t to use TestBuilder To test: 1 - Apply other patches (not this one) 2 - Prove t/db_dependent/Utils/Datatables_Members.t 3 - SHould pass 4 - Apply this patch 5 - prove t/db_dependent/Utils/Datatables_Members.t 6 - All tests should continue to pass Signed-off-by: Eleftheria -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:46:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:46:54 +0000 Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:47:18 +0000 Subject: [Koha-bugs] [Bug 16643] New: Make debian/list-deps aware of Jessie folder structure Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16643 Bug ID: 16643 Summary: Make debian/list-deps aware of Jessie folder structure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz debian/list-deps does not work on Jessie because the folder structure has changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:47:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:47:44 +0000 Subject: [Koha-bugs] [Bug 16642] Fix capitalisation for upload patron image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16642 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:47:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:47:47 +0000 Subject: [Koha-bugs] [Bug 16642] Fix capitalisation for upload patron image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16642 --- Comment #1 from Claire Gravely --- Created attachment 51973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51973&action=edit Bug 16642 - Fix capitalisation for upload patron image To fix capitalisation on the staff interface when patronimages is turned on. Test plan: 1. In staff interface. Turn on patronimages sys preference. 2. Go to a patron without an image and check that the "Upload patron image" box heading now has correct capitalisation. 3. Go to a patron with an image already uploaded and check the "Manage patron image" box heading has correct capitalisation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 10:49:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 08:49:28 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #28 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:02:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:02:46 +0000 Subject: [Koha-bugs] [Bug 16226] Allow Plack workers and requests-before-restart to be configured per-instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16226 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:17:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:17:54 +0000 Subject: [Koha-bugs] [Bug 16469] Remove the use of "onclick" from some catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 Nikos Chatzakis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nchatzakis at datascouting.com --- Comment #2 from Nikos Chatzakis --- Select and Clear buttons seems to work at staff interface but not at the OPAC. Tested both at master and with this patch applied, so we will sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:19:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:19:55 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35798|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 51974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51974&action=edit Bug 13691: Remove existing selenium scripts They are not usable. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:20:17 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49593|0 |1 is obsolete| | --- Comment #20 from Chris Cormack --- Created attachment 51975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51975&action=edit Bug 13691: Add basic selenium script This script has been used to compare 3.16.x and 3.18.x performances on bug 13690. What it does: - Go on the mainpage and process a log in - Create a patron category - Create a patron - Add 3 items - check the 3 items out to the patron - check the 3 items in How to use it? $ wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar $ vim /etc/apt/sources.list.d/firefox.list deb http://packages.linuxmint.com debian import $ apt-get update $ apt-get install firefox $ sudo apt-get install xvfb $ SELENIUM_PATH=/home/koha/tools/selenium-server-standalone-2.53.0.jar $ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & $ DISPLAY=:1 java -jar $SELENIUM_PATH perl t/db_dependent/selenium/basic_workflow.t Signed-off-by: Chris Cormack Note the pages have changed so the tests will not all pass. Also you need Selenium::Remote::Driver installed and staffClientBaseURL must be set I will change the tests in a follow up patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:20:38 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49594|0 |1 is obsolete| | --- Comment #21 from Chris Cormack --- Created attachment 51976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51976&action=edit Bug 13691: Add changes for 3.22 To test: Run the tests t/db_dependent/selenium/basic_workflow.t After you have set up selenium following the tests in the previous patch Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:23:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:23:15 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at ptfs-europe.com --- Comment #5 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Filippos Kolovos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:23:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:23:29 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 3 11:23:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jun 2016 09:23:37 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #6 from PTFS Europe Sandboxes --- Created attachment 51977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51977&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" In your OpacUserJS, to fetch the list: $(document).ready(function() { $.getJSON("/cgi-bin/koha/advanced_search_types.json", function(data){ $.each(data.types, function (index, value) { var opt = $('

  • [% borrowerfirstname %] [% borrowersurname %]'s account has expired
    • -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:30:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:30:08 +0000 Subject: [Koha-bugs] [Bug 16698] New: UpdateItemLocationOnCheckin preference needs a gui editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16698 Bug ID: 16698 Summary: UpdateItemLocationOnCheckin preference needs a gui editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 14576 adds a new syspref that accepts YAML for determining how the rules are applied. While there are other prefs accepting values in the same way, we should not expect users to understand YAML text formatting and should offer an easier option for entering the data We should decide on a best practice here for adding these guis. One option is to add pages on admin, however, I think this could get overwhelming the more sysprefs that use this method. I would propose adding a popup editor that will allow for easy entry, this editor will populate the syspref value so that advanced users can still access directly. Welcome to hear other thoughts, will proceed as proposed until then. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:30:34 +0000 Subject: [Koha-bugs] [Bug 16698] UpdateItemLocationOnCheckin preference needs a gui editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16698 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |oleonard at myacpl.org Depends on| |14576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 [Bug 14576] Allow arbitrary automatic update of location on checkin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:30:34 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16698 [Bug 16698] UpdateItemLocationOnCheckin preference needs a gui editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:43:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:43:31 +0000 Subject: [Koha-bugs] [Bug 16697] Translatability: Fix problem with isolated "'s"in request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16697 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:43:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:43:45 +0000 Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 --- Comment #11 from Marc V?ron --- Created attachment 52193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52193&action=edit Bug 16697: Translatability: Fix problem with isolated "'s"in request.tt This patch fixes translation problems with tag-isolated 's in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt The patch fixes it at two places. In consequence, some other texts ares sigthly changed to make them look similar. To test: - Inspect code changes and verify that the new wording makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:45:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:45:32 +0000 Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #52193|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Comment on attachment 52193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52193 Bug 16697: Translatability: Fix problem with isolated "'s"in request.tt Sorry for the wrong attachment, I was distracted and mistaked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:46:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:46:01 +0000 Subject: [Koha-bugs] [Bug 16697] Translatability: Fix problem with isolated "'s"in request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16697 --- Comment #1 from Marc V?ron --- Created attachment 52194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52194&action=edit Bug 16697: Translatability: Fix problem with isolated "'s"in request.tt This patch fixes translation problems with tag-isolated 's in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt The patch fixes it at two places. In consequence, some other texts ares sigthly changed to make them look similar. To test: - Inspect code changes and verify that the new wording makes sense. https://bugs.koha-community.org/show_bug.cgi?id=16455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:46:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:46:31 +0000 Subject: [Koha-bugs] [Bug 16697] Translatability: Fix problem with isolated "'s"in request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16697 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:49:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:49:16 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50662|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 52195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52195&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:49:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:49:20 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50663|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 52196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52196&action=edit Bug 14576 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:49:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:49:25 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #12 from Nick Clemens --- Created attachment 52197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52197&action=edit Bug 14576 - (QA followup) Fix message for use of value not in authorized values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 15:59:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 13:59:37 +0000 Subject: [Koha-bugs] [Bug 16699] New: Swagger: Split parameters and paths, and specify required permissions for resource Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Bug ID: 16699 Summary: Swagger: Split parameters and paths, and specify required permissions for resource Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: larit at student.uef.fi QA Contact: testopia at bugs.koha-community.org It's great that Bug 15126 splits Swagger specification over multiple files. However, the problem of still exists as swagger.json grows larger with each new path. We should do the same split as Bug 15126 did, but for paths and parameters. I propose the following structure for paths: . ??? swagger.json ??? definitions ? ??? index.json ? ??? error.json ? ??? patron.json ??? parameters ? ??? index.json ? ??? patron.json ??? paths ??? index.json ??? patrons.json Also Swagger should specify the required permissions for each resource. We can do this by adding "x-koha-permission"-field for each path, and using this field when checking for the needed permissions. This way required permissions are well-documented and anyone can instantly find out which permissions they need. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 16:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 14:00:13 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 16:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 14:00:13 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST?API: Use newer version of Swagger2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 16:24:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 14:24:04 +0000 Subject: [Koha-bugs] [Bug 16700] New: Quick spine label creator: Make css configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Bug ID: 16700 Summary: Quick spine label creator: Make css configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Instead of editing pinelabel.css found in /intranet-tmpl/prog/css/ for customizations, there should be a system preference to edit or override css (near SpineLabelFormat system preference that defines fields and additional text / markup for Quick spine labels). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 16:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 14:41:42 +0000 Subject: [Koha-bugs] [Bug 16584] All SQL queries should be compatible to 'ONLY_FULL_GROUP_BY'. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 16:43:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 14:43:00 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Lisa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisa at hchlibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 16:59:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 14:59:58 +0000 Subject: [Koha-bugs] [Bug 16701] New: Translatability: Fix problem with isolated ' in currency.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 Bug ID: 16701 Summary: Translatability: Fix problem with isolated ' in currency.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In Pootle, we get a string '%sCurrencies %s The leading ' has nothing to do with the meaning, it belongs to the previous line in: koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt [% IF op == 'delete_confirm' %]Confirm deletion of currency '[% searchfield %]' [% ELSIF op == 'list' %]Currencies [% END %] Additionally, Pootle thinks that there should be a space char after Currencies, but that seems not to be intended. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:00:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:00:27 +0000 Subject: [Koha-bugs] [Bug 16702] New: Notice Triggers Issue: Delivery Mechanism Options Not Saving Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16702 Bug ID: 16702 Summary: Notice Triggers Issue: Delivery Mechanism Options Not Saving Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: bassplayer9 at hotmail.com QA Contact: testopia at bugs.koha-community.org Problem with Notice & Status Triggers (Tools ? Notice triggers) When attempting to save my notice trigger configuration after (1) setting a delay integer, (2) selecting an overdue notice template, and (3) then choosing a delivery type (Email, SMS, etc.), the configuration saves but without the any of the delivery method types saving/sticking - they reset to an unchecked status. I do get a "changes saved" confirmation overall, but my delivery mechanism selections disappear for Email, Print, and SMS after clicking the "Save Changes" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:02:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:02:37 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #246 from Juan Romay Sieira --- I can't reindex Authorities with rebuild_elastic_search.pl, as Nick Clemens said. I added C4::Charset and now I got this error: DBIx::Class::ResultSet::new_result(): Result object instantiation requires a hashref as argument at Koha/Object.pm line 59 When I edit an Authority and save it, it goes to ES indexed, but full reindex can not be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:11:56 +0000 Subject: [Koha-bugs] [Bug 12941] batch enable/disable courses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12941 mholt at bastyr.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaretbugzilla at gmail.com --- Comment #1 from mholt at bastyr.edu --- It would save a lot of staff time if there were a way to batch enable and disable courses instead of going into each course listing and using the check box. During the last break between academic quarters, I spent an entire day disabling the courses from the past quarter and enabling the courses for the next quarter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:25:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:25:50 +0000 Subject: [Koha-bugs] [Bug 16674] remove two broken test from t/Ris.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52108|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 52198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52198&action=edit [SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:26:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:26:07 +0000 Subject: [Koha-bugs] [Bug 16674] remove two broken test from t/Ris.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:31:21 +0000 Subject: [Koha-bugs] [Bug 16647] Update debian/control for 16.* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52105|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 52199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52199&action=edit [SIGNED-OFF]Bug 16647: update debian/control for 16.* This patch updates debian/control* to match what was used for building the 16.05.00 packages, and includes changes to: - specify a floor for the Swagger2 version - add dep on libio-socket-ip-perl, which is needed for the package to work on Debian Wheezy - suggest libwww-youtube-download-perl Signed-off-by: Galen Charlton Signed-off-by: Hector Castro -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:31:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:31:36 +0000 Subject: [Koha-bugs] [Bug 16647] Update debian/control for 16.* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:39:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:39:46 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- (In reply to Michal Dudzik from comment #5) > Problem still exist Indeed, still broken at the OPAC. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:41:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:41:46 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #27 from Aliki Pavlidou --- "Tag tool without clock in Select all pending option Hi Aliki Please re-test and tell me if is Ok, or, I need to improve something else" Hi Hector, to sum it up, you want me to re-test everything on comment no25, or just the "Tag tool"? Best regards Aliki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:42:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:42:54 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:42:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:42:58 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 --- Comment #7 from Jonathan Druart --- Created attachment 52200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52200&action=edit Bug 2735: Fix authority search pagination at the OPAC The authority search pagination displays only 15 pages, even when there are more. To fix that, this patch mimic the authorities-home.pl intranet script to manage the pagination. Test plan: Without this patch, do some authority search and click on different pages. Apply this patch, redo the same search and make sure the same records are displayed (i.e. confirm that the pagination still works as before). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:43:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:43:02 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 --- Comment #8 from Jonathan Druart --- Created attachment 52201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52201&action=edit Bug 2735: CSS changes -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:45:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:45:15 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |OPAC -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:47:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:47:40 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #28 from H?ctor Eduardo Castro Avalos --- (In reply to Aliki Pavlidou from comment #27) > "Tag tool without clock in Select all pending option Hi Aliki > to sum it up, you want me to re-test everything on comment no25, or just the > "Tag tool"? > Yes, just the Tag tool since it is the part that has more changes. But if you want to bear out that all work right, please test all. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 17:54:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 15:54:56 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #247 from Katrin Fischer --- Testing at the KohaCon hackfest I also couldn't reindex authorities - biblios worked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 18:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 16:11:37 +0000 Subject: [Koha-bugs] [Bug 16703] New: Home > Reports > Circulation statistics showing no circulation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16703 Bug ID: 16703 Summary: Home > Reports > Circulation statistics showing no circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org koha/reports/issues_stats.pl is giving incorrect results. Here are the parameters added: Period From: 01/01/2016 To : 06/07/2016 Type: Checkout group by: None Library: Takoma Park Maryland Library Home Library: Takoma Park Maryland Library Holding Library: Takoma Park Maryland Library The output is: Circulation statistics Filtered on: Period From 01/01/2016 Period To 06/07/2016 Library = TPML Home library = TPML Holding library = TPML Event issue / TOTAL TOTAL 0 Here are the actual circulation statistics: select count(*) from statistics where type = 'issue' and branch='TPML' and date(datetime) between '2016-01-01' and '2016-06-07'; +----------+ | count(*) | +----------+ | 33891 | +----------+ To re-create: 1/ Choose a koha instance that has circulation 2/ Go to Home > Reports > Circulation statistics 3/ Select the following: Period From: To : Type: Checkout group by: None Library: Home Library: Holding Library: Cell Value: Count total items Output: To screen into the browser 4/ Click submit You will see Event issue / TOTAL TOTAL 0 5/ select count(*) from statistics where type = 'issue' and branch='BRANCH' and date(datetime) between '' and '' (Replace BRANCH and dates with values corresponding to the report above). Assuming that your date range contains checkouts, the output from issues_stats.pl is clearly incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 18:48:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 16:48:28 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #15 from Kyle M Hall --- Created attachment 52202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52202&action=edit Bug 14048 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 20:39:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 18:39:12 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52202|0 |1 is obsolete| | --- Comment #16 from Tom?s Cohen Arazi --- Created attachment 52203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52203&action=edit Bug 14048: [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 21:17:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 19:17:07 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52195|0 |1 is obsolete| | --- Comment #13 from Nicole C. Engard --- Created attachment 52204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52204&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 21:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 19:17:04 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 21:17:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 19:17:15 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52196|0 |1 is obsolete| | --- Comment #14 from Nicole C. Engard --- Created attachment 52205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52205&action=edit Bug 14576 - Unit tests Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 21:24:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 19:24:25 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Aliki Pavlidou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Aliki Pavlidou --- Dear Hector, I've checked out as many things as I could. Here is what I've noted: "-Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove" "COMMENTS" tab was not enabled on the bib records, so I?ve changed the: ADMINISTRATION=>SYSTEM PREFERENCE=>OPAC=>reviewson to Allow After that I?ve noticed that the "UNAPPROVE" button is missing. "-Set syspref TagsModeration to Require This will show all pending tags to review." GLOBAL SYSTEM PREFERENCE=> ENHANCED CONTENT=>TAGGING I?ve chenged "TAGSENABLED" to Allow but the "TAGS" button was still missing. Next I?ve changed "TAGSINPUTONDETAIL" to Allow, but again there was no "TAGS" BUTTON on the OPAC bib record. In both cases there was a "Tag cloud" button at the top, next to the "Advanced search" button, but there were no results after clicking on it. "-Make some tags in bib records and goto Tools -> Tags." SEE ABOVE "-In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending." "Apply filter(s)", "Test" => Look the same (SUBMIT BUTTONS) "Approved","Reject" => ?Approved?, "Rejected? are colored blue, they both are in the "Terms summary" box, along with ?Pending? and ?Total? buttons. "-Play with filters; Check if terms exist or not in appoved/rejected lists" "-Play with Terms summary and see if DataTable is working as expected" "-Click in some term tag with multiple titles" "-A table with titles tagged with the term is presented" "-See the new button 'Remove'" "-Verify if you can remove tag from a selected title." NO DATA SEE ABOVE I hope that these are all understandable. Regards Aliki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 21:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 19:17:20 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52197|0 |1 is obsolete| | --- Comment #15 from Nicole C. Engard --- Created attachment 52206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52206&action=edit Bug 14576 - (QA followup) Fix message for use of value not in authorized values Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 9 21:32:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 19:32:11 +0000 Subject: [Koha-bugs] [Bug 16702] Notice Triggers Issue: Delivery Mechanism Options Not Saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16702 --- Comment #1 from Craig --- As follow-up to the initial bug report... >From intranet-error.log: =======BEGIN LOG ENTRY======= [Thu Jun 09 13:38:06.017496 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`overduerules_transport_types`, CONSTRAINT `overduerules_transport_types_ibfk_1` FOREIGN KEY (`overduerules_id`) REFERENCES `old_overduerules` (`overduerules_id`) ON DELETE CASC) [for Statement ", referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl [Thu Jun 09 13:38:06.017674 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: INSERT INTO overduerules_transport_types(, referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl [Thu Jun 09 13:38:06.017788 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: overduerules_id, letternumber, message_transport_type, referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl [Thu Jun 09 13:38:06.017854 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: ) VALUES (, referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl [Thu Jun 09 13:38:06.018004 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: (SELECT overduerules_id FROM overduerules WHERE branchcode = ? AND categorycode = ?), ?, ?, referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl [Thu Jun 09 13:38:06.018095 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: ), referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl [Thu Jun 09 13:38:06.018279 2016] [cgi:error] [pid 14102] [client 174.113.255.196:54329] AH01215: [Thu Jun 9 13:38:06 2016] overduerules.pl: " with ParamValues: 0="MAIN", 1='BOR', 2=1, 3="email"] at /usr/share/koha/intranet/cgi-bin/tools/overduerules.pl line 200., referer: https://library.craigbutosi.ca/cgi-bin/koha/tools/overduerules.pl =======END LOG ENTRY======= Haven't the foggiest what this means specifically. My gut tells me that sql is searching for data or a table that isn't currently there, and cannot write. Though I am very unsure. Have no idea why this would happen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 00:16:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 22:16:30 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 00:20:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 22:20:07 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 00:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 22:20:11 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51969|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 52207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52207&action=edit Bug 16324: Move item search into header This patch makes the Search button in the header into a dropdown that holds the Advanced search and the Item search. I have rewritten this patch to be independent of Bug 16323 since that patch is so controversial. To test: 1) Confirm that Advanced search and Item search are both under the 'Search' dropdown menu in the header and both links work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 00:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 22:20:38 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|16323 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323 [Bug 16323] Make dropdowns in header open on hover -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 00:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 22:20:38 +0000 Subject: [Koha-bugs] [Bug 16323] Make dropdowns in header open on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16324 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 [Bug 16324] Move item search into header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 00:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jun 2016 22:26:13 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 02:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 00:58:09 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #3 from Srdjan Jankovic --- Created attachment 52208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52208&action=edit Fix test data in issue.t and defaults for stats 'Null' iand '' are not really NULL values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 02:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 00:58:25 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #4 from Srdjan Jankovic --- Created attachment 52209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52209&action=edit Test rental charges properly * AddIssuingCharge() test was always returning pass - removed and replaced with: * Test rental charges properly for both checkout and renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 02:59:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 00:59:26 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 02:59:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 00:59:29 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #5 from Srdjan Jankovic --- Created attachment 52210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52210&action=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 03:03:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 01:03:49 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #6 from Srdjan Jankovic --- To test - Librarian interface - Circulation: Have an item with rental charges. Checkout. Renew. Checkouts table should reload with rental charges added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 03:44:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 01:44:08 +0000 Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574 Janice Chow changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 08:01:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 06:01:33 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- Hi Ere, status here is still Failed QA - so testers most likely won't see this. If you feel this is testable with current master, please switch to 'needs signoff' As others have pointed out, we already have support for deleted records. Could you take another look and maybe update your commit message? It would also be good to have a test plan. Ideally all those changes should be splitted into separate bugs to make them easier to manage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 09:04:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 07:04:02 +0000 Subject: [Koha-bugs] [Bug 16695] Exception::Class 1.39 is not packaged for Jessie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16695 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 09:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 07:04:05 +0000 Subject: [Koha-bugs] [Bug 16695] Exception::Class 1.39 is not packaged for Jessie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16695 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52191|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 52211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52211&action=edit Bug 16695: Require Exception::Class 1.38 instead of 1.39 Looking at http://cpansearch.perl.org/src/DROLSKY/Exception-Class-1.40/Changes there is no need to require 1.39 Signed-off-by: Jacek Ablewicz Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 09:04:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 07:04:23 +0000 Subject: [Koha-bugs] [Bug 16695] Exception::Class 1.39 is not packaged for Jessie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16695 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 09:44:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 07:44:30 +0000 Subject: [Koha-bugs] [Bug 16704] New: Sorting authority search result doesn't work properly after 50 page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16704 Bug ID: 16704 Summary: Sorting authority search result doesn't work properly after 50 page Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dudzikmichal at wp.pl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 52212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52212&action=edit screenshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 09:54:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 07:54:00 +0000 Subject: [Koha-bugs] [Bug 16704] Sorting authority search result doesn't work properly after 50 page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16704 --- Comment #1 from Michal Dudzik --- Problem exist in OPAC and Intranet when sorting Heading A-Z or Z-A. Regards Micha? Dudzik -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:12:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:12:12 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:44:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:44:40 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:44:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:44:44 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52104|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 52213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52213&action=edit Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for BakerTaylor 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan Signed-off-by: Florent Mara NOTE: Tweaked test plan based on comment #4, Added sign off based on comment #6. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:44:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:44:53 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 --- Comment #10 from Marcel de Rooy --- Created attachment 52214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52214&action=edit Bug 16636: [QA Follow-up] Make BakerTaylor plack safe Initialize file level lexicals each call. Do not call _initialize outside the module. Adjust test by mocking preferences. Test plan: Run t/db_dependent/External_BakerTaylor.t. Signed-off-by: Marcel de Rooy Tested module with trivial script under Plack/memcached by toggling the associated preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:44:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:44:57 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 --- Comment #11 from Marcel de Rooy --- Created attachment 52215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52215&action=edit Bug 16636: [QA Follow-up] Move External_BakerTaylor.t to t When we mock the preferences completely now, we do not need db access anymore. Test plan: Run the test without exporting KOHA_CONF. The test passes with some warns about koha-conf.xml. If you point KOHA_CONF to etc/koha-conf.xml, you have no warns. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:45:11 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:45:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:45:22 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:47:18 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #15 from Katrin Fischer --- This is quite annoying for circulation staff - marking as 'minor' in hope for it to get picked up by rmaints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:49:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:49:42 +0000 Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 --- Comment #1 from Marc V?ron --- Created attachment 52216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52216&action=edit Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:51:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:51:28 +0000 Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Text to go in the| |Fix translatability issues release notes| |due to sentence splitting | |in | |koha-tmpl/opac-tmpl/bootstr | |ap/en/modules/opac-user.tt Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 10:52:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 08:52:50 +0000 Subject: [Koha-bugs] [Bug 16704] Sorting authority search result doesn't work properly after 50 page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16704 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Zeno Tajoli --- Result of sort searches has a limits in zebra. Parmater 'sortmax'. See etc/zebradb/zebra-biblios-dom.cfg and etc/zebradb/zebra-authorities-dom.cfg: # Specifies the maximum number of records that will be sorted in a result set. # If the result set contains more than that limit, the records after the limit # will not be sorted. If omitted, the default value is 1,000. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 11:14:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 09:14:27 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 11:14:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 09:14:30 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 --- Comment #11 from Marcel de Rooy --- Created attachment 52217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52217&action=edit Bug 16441: Do not use a package variable to cache C4::Letters::getletter C4::Letters::getletter use a package variable (%letter) to cache letter returned by the subroutine. I have not found any direct issues caused by that but it is safer to remove it. It won't be a big deal to hit the DBMS to get a valid letter when needed. No test plan here, just confirm that the changes make sense. Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Confirm that performance loss is just a millisecond or so per subsequent call of getletter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 11:14:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 09:14:35 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52130|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 52218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52218&action=edit Bug 16441: Fix Letters.t These tests were wrong, but the package variable used to cache the letters hid the problem. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 11:15:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 09:15:31 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 12:04:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 10:04:30 +0000 Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443 --- Comment #5 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #4) > (In reply to Chris Cormack from comment #3) > > This works, I haven't tested if there is a performance hit, but even if > > there was we need to make the change anyway. But if there is, we may want to > > put some caching in get_fields > > Yes it is definitely slower. (You could speed up somewhat by returning to > dbh, but we chose for DBIx..) > Could we cache the item columns here instead of fetching them every time? > get_fields needs the item columns and the pref. Hm. Actually not too bad after all.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 12:05:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 10:05:40 +0000 Subject: [Koha-bugs] [Bug 16705] New: Status missing in Opac, serials subscription history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16705 Bug ID: 16705 Summary: Status missing in Opac, serials subscription history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: duytinh.nguyen at live.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Status like Missing (never received), Missing (sold out), Missing (damaged), Missing (lost) can be assigned in Intranet, but missing in Opac. Related to bug_10851. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 12:05:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 10:05:48 +0000 Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 12:05:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 10:05:51 +0000 Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51322|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 52219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52219&action=edit Bug 16443: Make C4::Members::Statistics plack safe If the prefs is updated, the fields won't be. To make sure we already fetch updated values, we should remove the package variable and define it in the subroutine. There is not test plan, just make sure the changes are consistent. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 12:05:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 10:05:55 +0000 Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443 --- Comment #7 from Marcel de Rooy --- Created attachment 52220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52220&action=edit Bug 16443: [QA Follow-up] Add two tests for get_fields Adds t/db_dependent/Members/Statistics.t. Test plan: Run the test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:13:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:13:38 +0000 Subject: [Koha-bugs] [Bug 16706] New: Add option to search in address fields to patron search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16706 Bug ID: 16706 Summary: Add option to search in address fields to patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if it was possible to search in address address2 and the other address related fields of the patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:23:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:23:39 +0000 Subject: [Koha-bugs] [Bug 16705] Status missing in Opac, serials subscription history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16705 --- Comment #1 from duy tinh --- Created attachment 52221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52221&action=edit Bug 16705 - Add missing status The bug is related to 10851. Due to add of status in 10851, status added were missing in opac-detail.tt and opac-full-serial-issues.tt. The patch just added these missing status. To test: 1) Create New subscription in Serials, in Intranet 2) Do a search of the new subscription by Title 3) Take Serial receive as Actions to edit the status to Missing () 4) Go to Opac and Search the subscription created, by its title and See missing status 5) Apply patch, status must be showed. 6) Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:29:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:29:17 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:29:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:29:17 +0000 Subject: [Koha-bugs] [Bug 15695] koha-plack script breaks installations set up before 3.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13791 CC| |mirko at abunchofthings.net Summary|koha-plack script does not |koha-plack script breaks |enable plack when plack has |installations set up before |never been enabled |3.22 --- Comment #1 from Mirko Tietgen --- koha-plack does not work for installations set up before 3.22, because the changes never got backported. That means everyone with a setup created before that will break their setup when using koha-plack. Changed the bug title and added more infos. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:41:03 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52204|0 |1 is obsolete| | Attachment #52205|0 |1 is obsolete| | Attachment #52206|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 52222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52222&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:41:11 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #17 from Kyle M Hall --- Created attachment 52223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52223&action=edit Bug 14576 - Unit tests Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 13:41:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 11:41:14 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #18 from Kyle M Hall --- Created attachment 52224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52224&action=edit Bug 14576 - (QA followup) Fix message for use of value not in authorized values Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 14:47:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 12:47:58 +0000 Subject: [Koha-bugs] [Bug 16707] New: Software Error in OPAC password recovery when leaving form fields empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Bug ID: 16707 Summary: Software Error in OPAC password recovery when leaving form fields empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: - Set syspref OpacResetPassword to "Allow" - Go to OPAC - Click link "Forgot your password? - On the following screen "Forgotten password recovery", do not fill in form fields, click "Submit" Result: Software error: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/opac/opac-password-recovery.pl line 66. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:07:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:07:33 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #248 from Jonathan Druart --- I am investigating the authority indexing issue. It seems to be caused by a bad merge fix conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:21:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:21:25 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 --- Comment #1 from Marc V?ron --- Created attachment 52225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52225&action=edit Bug 16707: Software Error in OPAC password recovery when leaving form fields empty This patch fixes a software Error in OPAC password recovery when leaving form fields empty To reproduce: - Set syspref OpacResetPassword to "Allow" - Go to OPAC - Click link "Forgot your password? - On the following screen "Forgotten password recovery", do not fill in form fields, click "Submit" Result: Software error: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/opac/opac-password-recovery.pl line 66. To test: - Apply patch - Verify that the error no longer occurs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:22:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:22:03 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:24:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:24:15 +0000 Subject: [Koha-bugs] [Bug 16708] New: ElasticSearch - Fix authority reindexing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708 Bug ID: 16708 Summary: ElasticSearch - Fix authority reindexing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:24:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:24:47 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16708 --- Comment #249 from Jonathan Druart --- (In reply to Jonathan Druart from comment #248) > I am investigating the authority indexing issue. > It seems to be caused by a bad merge fix conflict. See bug 16708. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708 [Bug 16708] ElasticSearch - Fix authority reindexing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:24:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:24:47 +0000 Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:27:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:27:05 +0000 Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:27:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:27:10 +0000 Subject: [Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708 --- Comment #1 from Jonathan Druart --- Created attachment 52226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52226&action=edit Bug 16708: Fix authority reindex for ElasticSearch The changes made to Koha::Authority has not been correctly fixed. The code of Koha::Authority has been moved bo Koha::MetadataRecord::Authority by bug 15380. Test plan: perl misc/search_tools/rebuild_elastic_search.pl -a -v should success -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:30:07 +0000 Subject: [Koha-bugs] [Bug 16668] Fix t/Ris.t (follow-up for 16442) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16668 --- Comment #7 from Jonathan Druart --- *** Bug 16674 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:30:07 +0000 Subject: [Koha-bugs] [Bug 16674] remove two broken test from t/Ris.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |RESOLVED --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 16668 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:32:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:32:27 +0000 Subject: [Koha-bugs] [Bug 16647] Update debian/control for 16.* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:32:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:32:30 +0000 Subject: [Koha-bugs] [Bug 16647] Update debian/control for 16.* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52199|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 52227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52227&action=edit Bug 16647: update debian/control for 16.* This patch updates debian/control* to match what was used for building the 16.05.00 packages, and includes changes to: - specify a floor for the Swagger2 version - add dep on libio-socket-ip-perl, which is needed for the package to work on Debian Wheezy - suggest libwww-youtube-download-perl Signed-off-by: Galen Charlton Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:43:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:43:28 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Not sure it will make the translation easier, but I don't have something else to suggest. Letting it here to get another QA point of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:46:38 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #4 from Jonathan Druart --- Why don't you just remove the i tag and surround the whole sentence with a span? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:48:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:48:37 +0000 Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- What about: The transaction (id [% id %]) for this payment is invalid. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:49:10 +0000 Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > What about: > The transaction (id [% id %]) for this payment is invalid. > ? Hum, forget that, it's not an id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:50:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:50:16 +0000 Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:50:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:50:20 +0000 Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51850|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 52228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52228&action=edit Bug 16563: Translatability: Issues in opac-account.tt (sentence splitting) This patch removes splitting by -tags from 2 sentences. Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 15:55:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 13:55:50 +0000 Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I don't think it's a good idea to hide these warnings. If they appear it means that the developer is doing something wrong. Giving him the ability not to think but just add a quiet flag is not helping him :) For instance, we should not specify the primary (or unique) key, but let TestBuilder generating it, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:13:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:13:02 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 --- Comment #6 from Jonathan Druart --- Created attachment 52229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52229&action=edit [COUNTER-PATCH] Bug 16500: Do not try to insert MPL if already exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:14:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:14:20 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > Created attachment 52229 [details] [review] > [COUNTER-PATCH] Bug 16500: Do not try to insert MPL if already exists Marcel, what about this patch to replace your second patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:25:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:25:14 +0000 Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment period" for Patron Categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Kyle, The change looks good but I do not recreate the issue. I have tried to add a new category and update an existing one, the date is saved in both cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:27:00 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > Not sure it will make the translation easier, but I don't have something > else to suggest. > Letting it here to get another QA point of view. I'll add a : to the text to make clear that a value will follow. It will read: Pending for next available item of type: Book (Book in italic) That is nicer because item types start with a capital letter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:29:09 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Jonathan Druart --- Too bad not to see another QAer taking a look at this one. I am going to push it anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:29:27 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #6 from Marc V?ron --- Created attachment 52230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52230&action=edit Bug 16562: (Follow-up) Add ':' to enhance readability and translatability The text will now read: Pending for next available item of type: Book (Book in italic) This is nicer because item types normally start with a capital letter and because it will be clearer in translation that a value will follow. See comments #5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:30:36 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:38:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:38:26 +0000 Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:38:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:38:30 +0000 Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51886|0 |1 is obsolete| | Attachment #51887|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 52231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52231&action=edit Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:38:34 +0000 Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 --- Comment #8 from Jonathan Druart --- Created attachment 52232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52232&action=edit Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space"   is not contained in XML syntax by default. So we add it in the file header : ]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel Works as described following test plan Tes pass, no errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:41:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:41:00 +0000 Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:41:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:41:04 +0000 Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51774|0 |1 is obsolete| | Attachment #51888|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 52233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52233&action=edit Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:41:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:41:09 +0000 Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 --- Comment #6 from Jonathan Druart --- Created attachment 52234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52234&action=edit Bug 16578: Same fix for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel Works as first patch No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:45:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:45:44 +0000 Subject: [Koha-bugs] [Bug 16709] New: [3.20.x] Bug 11038 is not applied correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Bug ID: 16709 Summary: [3.20.x] Bug 11038 is not applied correctly Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Staff Client Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 11038 It seems there was a problem during the application of bug 11038 on 3.20.x. The commit 32bc47f6d488f3f2d81a234c029219d5861cf338 add this line in C4/Auth.pm: + IntranetUserJS => C4::Context->preference("IntranetUserJS"), instead of: + IntranetUserCSS => C4::Context->preference("IntranetUserCSS"), And a line that had to be removed is still there in 3.20.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:45:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:45:44 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 [Bug 16709] [3.20.x] Bug 11038 is not applied correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:47:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:47:20 +0000 Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:47:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:47:24 +0000 Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51885|0 |1 is obsolete| | Attachment #51889|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 52235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52235&action=edit Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:47:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:47:30 +0000 Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:47:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:47:36 +0000 Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51749|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 52236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52236&action=edit Bug 16570: Do not tell all checked-in items are part of a rotating collection When an item is checked-in a message will tell you it's part of a rotating collection, even if it's not true. Test plan: Make sure the message appears only when needed. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:48:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:48:19 +0000 Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52235|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 52237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52237&action=edit Bug 16613: fix MARC 09X help links The 09X MARC fields, such as 099 local call number or 090 locally-assigned Library of Congress call number, all point to non-existent pages on the LC website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html Test plan: - enter the advanced cataloging editor - begin to input any MARC tag of form 09X - click the help link at the bottom of the browser window => Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag + '.html'` which is broken because the only documentation for these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html => With this patch applied, the link is correct Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:49:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:49:02 +0000 Subject: [Koha-bugs] [Bug 16709] [3.20.x] Bug 11038 is not applied correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 --- Comment #1 from Julian Maurice --- Created attachment 52238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52238&action=edit Bug 16709: Followup of bug 11038 for 3.20.x only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:49:10 +0000 Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|16.05 |unspecified --- Comment #6 from Jonathan Druart --- Hi Eric, Have a loot at our wiki page https://wiki.koha-community.org/wiki/SubmitingAPatch for your next patch :) Thanks for your fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:50:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:50:47 +0000 Subject: [Koha-bugs] [Bug 16709] [3.20.x] Bug 11038 is not applied correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice --- Test plan: 1. Modify IntranetUserCSS and check that changes are not applied to the staff login page 2. Apply patch 3. Check that your changes are now applied to the staff login page 4. Check in the DOM that the IntranetUserCSS code only appear once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:51:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:51:34 +0000 Subject: [Koha-bugs] [Bug 16709] [3.20.x] Bug 11038 is not applied correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16709 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:52:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:52:21 +0000 Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:52:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:52:27 +0000 Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51891|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52239&action=edit Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment." Strings appear as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:52:59 +0000 Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:55:56 +0000 Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:55:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:55:59 +0000 Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51711|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 52240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52240&action=edit Bug 16465: discharge - Add a title tag at the OPAC Test plan: Confirm that the opac-discharge.pl has now a title Signed-off-by: Srdjan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 16:56:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 14:56:05 +0000 Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51712|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 52241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52241&action=edit Bug 16465: Fix typo issues vs checkouts Test plan: Confirm the wording is correct Signed-off-by: Srdjan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:01:49 +0000 Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:01:52 +0000 Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51848|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 52242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52242&action=edit Bug 16596: Display library and patron category descriptions instead of their code Test plan: On circ/circulation-home.pl and reserve/request.pl, search for patrons The descriptions for the libraries and patron categories should be displayed. Signed-off-by: Bernardo Gonzalez Kriegel On top of Bug 13336 Works as described, now descriptions instead of codes. No errors Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=16455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:03:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:03:02 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from H?ctor Eduardo Castro Avalos --- Hi Aliki Thank you for testing I disagree with you, Aliki. I've set a sandbox and I could see all the changes even though I can see the button "unapprove" in "Comments tool" and all the data in "Tools->Tags" Note that you can see the data if you click in the link Total in section "Terms summary" In this bug I didn't change nothing that really exist in the Staff Interface. So I only added some Awesome Icons and some Bootstrap buttons. I accept that in Tag Tool, I've changed some JQuery to reflect a better functionality but that's all. Please take a look to the sandbox 1 in UNIMARC with user/password = test/test You can compare the old interface in sandbox2 with the same user and password Regards PS: I hope nobody change the sandbox1 at least in 24 hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:06:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:06:17 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Looks good but I cannot recreate the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:09:15 +0000 Subject: [Koha-bugs] [Bug 16710] New: Hide overflow of long words in lefthand navigation (e.g. "=?UTF-8?Q?Anschaffungsvorschl=C3=A4ge?=") Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16710 Bug ID: 16710 Summary: Hide overflow of long words in lefthand navigation (e.g. "Anschaffungsvorschl?ge") Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Created attachment 52243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52243&action=edit Screenshot with words overlapping the main area In the lefthand navigation of OPAC, long words can overlap the main area, e.g. translation of "purchase suggestions" -> German: "Anschaffungsvorschl?ge" See screenshot attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:09:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:09:37 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:10:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:10:31 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:10:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:10:35 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51894|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 52244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52244&action=edit Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. Signed-off-by: Fr?d?ric Demians Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this patch. Signed-off-by: Jonathan Druart Can't recreate on debian but the fix looks safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:12:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:12:44 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Why don't you just remove the i tag and surround the whole sentence with a > span? And what about this suggestion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:21:49 +0000 Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in opac-memberentry.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:21:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:21:52 +0000 Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in opac-memberentry.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51896|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52245&action=edit Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt This patch fixes two splitted sentences to avoid translation issues: The entered card number is the wrong length. The entered card number is already in use. To test: Apply patch and verify that html in the 2 that are changed is correct and that they are not splitted by a-tags. Note: I could not figure out under which conditions this code displays in the OPAC self registration form. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:22:51 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #8 from Marc V?ron --- It would read: Pending for next available item of type Book I like it better the way I did it, for the reason I explained in my comment. Pending for next available item of type: Book -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:35:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:35:24 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Same as Srdjan :) So please: 1/ apply the same fix for intranet 2/ remove the JS function 3/ remove the code related to the print param Additional comments: 4/ With your patch, the first column is now printed (checkbox) 5/ I only see 8 (out of 20) records printed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:35:44 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:36:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:36:34 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #31 from Aliki Pavlidou --- Hi Hector, Everything looks great! Nice job! Regards Aliki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:46:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:46:13 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 --- Comment #19 from Jesse Weaver --- Created attachment 52246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52246&action=edit Bug 16166: Proposed followup to use Sereal for serialization This manages to eke out a bit more performance on my machine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:47:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:47:22 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Small conflict in Items.pm Also, did you mean to use $another_barcode here: 660 $item = GetItem($item_itemnumber); 661 is ( $item->{barcode}, $a_barcode, 'items.barcode is not mapped anymore, so the DB column has not been updated' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:49:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:49:49 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52159|0 |1 is obsolete| | --- Comment #32 from H?ctor Eduardo Castro Avalos --- Created attachment 52247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52247&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module. Also correct a error dialog in JQuery functions To test: -Apply patch -Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all. -Add new patron list and add some patrons, notice about the trash icon. -Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove. -Set syspref TagsModeration to Require. This will show all pending tags to review. -Make some tags in bib records and goto Tools -> Tags. -Notice about the new look. -In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending. -Play with filters; Check if terms exist or not in appoved/rejected lists -Play with Terms summary and see if DataTable is working as expected -Click in some term tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tag from a selected title. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 Test plan amended for clarity Clock icon for "Select all pending" removed (QA comment 23). Fix some forbidden patterns (tab char) in review.tt according by IRC comment by Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 17:59:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 15:59:44 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #9 from Jonathan Druart --- (In reply to Marc V?ron from comment #8) > It would read: > Pending for next available item of type Book > > I like it better the way I did it, for the reason I explained in my comment. > Pending for next available item of type: Book I meant: Pending for next available Book item. i.e. same wording as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:06:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:06:48 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #10 from Marc V?ron --- (In reply to Jonathan Druart from comment #9) > (In reply to Marc V?ron from comment #8) > > It would read: > > Pending for next available item of type Book > > > > I like it better the way I did it, for the reason I explained in my comment. > > Pending for next available item of type: Book > > I meant: > Pending for next available Book item. > > i.e. same wording as before In Pootle, that would be: Pending for next available %s item. Translaters would have to find out what the %s stands for, that's why IMO my solution is better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:07:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:07:40 +0000 Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:07:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:07:43 +0000 Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51929|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 52248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52248&action=edit Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:08:03 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51329|0 |1 is obsolete| | Attachment #51330|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 52249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52249&action=edit Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:08:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:08:14 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #9 from Jonathan Druart --- Created attachment 52250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52250&action=edit Bug 13074: (followup) remove useless diag On running all Items-related tests some useless diag showed up. Removing it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:09:13 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Jonathan Druart --- (In reply to Nick Clemens from comment #7) > Small conflict in Items.pm > > Also, did you mean to use $another_barcode here: > 660 $item = GetItem($item_itemnumber); > 661 is ( $item->{barcode}, $a_barcode, 'items.barcode is not mapped > anymore, so the DB column has not been updated' ); No I don't think so. I don't remember exactly what I did, just remember that they were crazy tests to write... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:11:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:11:35 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > (In reply to Nick Clemens from comment #7) > > Small conflict in Items.pm > > > > Also, did you mean to use $another_barcode here: > > 660 $item = GetItem($item_itemnumber); > > 661 is ( $item->{barcode}, $a_barcode, 'items.barcode is not mapped > > anymore, so the DB column has not been updated' ); > > No I don't think so. > I don't remember exactly what I did, just remember that they were crazy > tests to write... Ok so actually we do not want to update the DB column because the marc field is not mapped. Just what the test description says :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:26:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:26:23 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52247|0 |1 is obsolete| | --- Comment #33 from Marc V?ron --- Created attachment 52251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52251&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module. Also correct a error dialog in JQuery functions To test: -Apply patch -Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all. -Add new patron list and add some patrons, notice about the trash icon. -Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove. -Set syspref TagsModeration to Require. This will show all pending tags to review. -Make some tags in bib records and goto Tools -> Tags. -Notice about the new look. -In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending. -Play with filters; Check if terms exist or not in appoved/rejected lists -Play with Terms summary and see if DataTable is working as expected -Click in some term tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tag from a selected title. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 Test plan amended for clarity Clock icon for "Select all pending" removed (QA comment 23). Fix some forbidden patterns (tab char) in review.tt according by IRC comment by Marc Veron Followed test plan, looks and works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:26:44 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:37:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:37:10 +0000 Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:38:34 +0000 Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:39:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:39:50 +0000 Subject: [Koha-bugs] [Bug 16678] updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16678 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:42:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:42:20 +0000 Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:44:41 +0000 Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a field is mapped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:46:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:46:03 +0000 Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:50:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:50:13 +0000 Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl when utf8 chosen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 16.11, thanks Tomas, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:51:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:51:57 +0000 Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed instead of their description on patron search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:57:47 +0000 Subject: [Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:58:31 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52225|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 52252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52252&action=edit [SIGNED-OFF]Bug 16707: Software Error in OPAC password recovery when leaving form fields empty This patch fixes a software Error in OPAC password recovery when leaving form fields empty To reproduce: - Set syspref OpacResetPassword to "Allow" - Go to OPAC - Click link "Forgot your password? - On the following screen "Forgotten password recovery", do not fill in form fields, click "Submit" Result: Software error: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/opac/opac-password-recovery.pl line 66. To test: - Apply patch - Verify that the error no longer occurs Signed-off-by: Hector Castro Work as expected. NO QA Test Tool errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 18:58:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 16:58:43 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:00:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:00:08 +0000 Subject: [Koha-bugs] [Bug 16668] Fix t/Ris.t (follow-up for 16442) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16668 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:03:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:03:40 +0000 Subject: [Koha-bugs] [Bug 16675] fix breakage of t/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:05:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:05:59 +0000 Subject: [Koha-bugs] [Bug 16649] OpenLibrarySearch.t fails when building packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16649 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:07:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:07:09 +0000 Subject: [Koha-bugs] [Bug 16647] Update debian/control for 16.* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16647 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Galen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:08:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:08:54 +0000 Subject: [Koha-bugs] [Bug 16695] Exception::Class 1.39 is not packaged for Jessie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:22:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:22:54 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #68 from Kyle M Hall --- Pushed to master for 16.11, thanks Marcel, Mark and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:32:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:32:54 +0000 Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other actions ) will use the patron home branch as the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall --- Pushed to master for 16.11, thanks for the followups Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:34:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:34:42 +0000 Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 16.11, thanks Philippe! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:36:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:36:07 +0000 Subject: [Koha-bugs] [Bug 14897] Header name mismatch in ./modules/catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Dimitris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:37:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:37:17 +0000 Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation actions are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:38:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:38:27 +0000 Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in opac-memberentry.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:39:29 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:41:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:41:14 +0000 Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 16.11, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:42:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:42:29 +0000 Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:43:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:43:26 +0000 Subject: [Koha-bugs] [Bug 16667] Unused variable and function call in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16667 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:45:26 +0000 Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt (tag-splitted sentences) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:47:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:47:08 +0000 Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:48:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:48:39 +0000 Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks phette! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:51:22 +0000 Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated word "please" in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:52:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:52:37 +0000 Subject: [Koha-bugs] [Bug 16633] Translatability: Issues in tags/review.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16633 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:57:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:57:24 +0000 Subject: [Koha-bugs] [Bug 16634] Translatability: Fix issue in memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 19:59:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 17:59:15 +0000 Subject: [Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Mark, Marcell! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:02:39 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 --- Comment #12 from Kyle M Hall --- Created attachment 52253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52253&action=edit Bug 16636 [QA Followup] - Move tests to t/External -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:03:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:03:25 +0000 Subject: [Koha-bugs] [Bug 16636] t/00-load.t warning from C4/External/BakerTaylor.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 16.11, thanks Mark, Marcell! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:05:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:05:34 +0000 Subject: [Koha-bugs] [Bug 16637] Dependency for C4::Tags not listed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16637 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:06:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:06:55 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:08:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:08:58 +0000 Subject: [Koha-bugs] [Bug 16165] Include link to ILS-DI documentation page in ILS-DI system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Claire! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:10:41 +0000 Subject: [Koha-bugs] [Bug 16289] Abbreviated formatting for numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Karl, Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:15:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:15:58 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #12 from Nick Clemens --- Yes, entirely, just read that backwards in my head. Tests pass, but I have to reset plack to see the change happen when testing in client. Will test again next week to see if it is me (In reply to Jonathan Druart from comment #11) > Ok so actually we do not want to update the DB column because the marc field > is not mapped. Just what the test description says :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:18:11 +0000 Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:35:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:35:51 +0000 Subject: [Koha-bugs] [Bug 16711] New: OPAC Password recovery: Handling if multiple accounts have the same mail address Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Bug ID: 16711 Summary: OPAC Password recovery: Handling if multiple accounts have the same mail address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org If multiple accounts have the same email address set as primary email and you ask for password recovery with only filling in the email address, a email is sent for one account only. Example: Create 3 Accounts, login names are test01, test02, test 03, Email is the same for all. Go to OPAC -> Password recovery and indicate E-Mail only You will get a mail for only one of the accounts above, something like: --------- This email has been sent in response to your password recovery request for the account test01 You can now create your new password using the following link: http://....... (...) --------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 20:50:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 18:50:38 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > (In reply to Jonathan Druart from comment #6) > > Created attachment 52229 [details] [review] [review] > > [COUNTER-PATCH] Bug 16500: Do not try to insert MPL if already exists > > Marcel, what about this patch to replace your second patch? That would obviously work fine too, but I'd rather replace it by one line in the dependent patch (16607). So I prefer to keep the original one.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 21:03:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 19:03:07 +0000 Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) Thx for looking into this. > I don't think it's a good idea to hide these warnings. I agree in general. But if you have a closer look, you will see that this is only a one-time, non-recursive hide for one build call. (Generated recursive build calls already are verbose again.) > If they appear it means that the developer is doing something wrong. Giving > him the ability not to think but just add a quiet flag is not helping him :) > For instance, we should not specify the primary (or unique) key, but let > TestBuilder generating it, don't you think? A developer could of course misuse this flag. He can do much more bad things :) This flag is intended to intelligently suppress one warning. As example: $builder->build( { source => 'Branch', value => { branchcode => 'CPL' }, quiet => 1 }); In this case the developer uses TestBuilder to INSERT IGNORE a CPL branch in just one line. He knows that TestBuilder will not insert it if it is already there and he does not want to see the warning. So he passes the quiet flag. Normally, we do not specify primary keys in TestBuilder, but I would not like to block this specific use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 10 21:06:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jun 2016 19:06:21 +0000 Subject: [Koha-bugs] [Bug 14434] OPAC should indicate to patrons that auto renewal will not work because hold has been placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu --- Comment #2 from Eric Phetteplace --- The bug that Marc links to does not address this issue, which specifically has to do with auto-renewal. Yes, if auto-renewal is turned off and a hold is placed on an item, there's a warning to the patron. This warning does not appear when auto-renewal is on however, instead it appears to the patron as if they can continue renewing. Christopher clearly outlined this in the original bug report and screenshot and it is not fixed on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 02:33:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 00:33:33 +0000 Subject: [Koha-bugs] [Bug 16712] New: Unknown Error Message from Item records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16712 Bug ID: 16712 Summary: Unknown Error Message from Item records Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: lauraerinmann at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, I'm running Koha 3.18.12.000 and I can this error when I try to update items for a record: :21: parser error : Opening and ending tag mismatch: record line 6 and datafield ^ :22: parser error : Opening and ending tag mismatch: collection line 2 and record ^ :23: parser error : Extra content at the end of the document the url pattern is something like this: ../cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=''&itemnumber=''#edititem When I edit one of the fields on this screen it throughs the error above. It seems like a xml error, but after some internet sleuthing I came up with nothing. I also posted to the boarded and waited at least a month for a response and found nothing. The error message doesn't tell me much about wha the error is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 02:33:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 00:33:52 +0000 Subject: [Koha-bugs] [Bug 16713] New: Unknown Error Message from Item records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16713 Bug ID: 16713 Summary: Unknown Error Message from Item records Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: lauraerinmann at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, I'm running Koha 3.18.12.000 and I can this error when I try to update items for a record: :21: parser error : Opening and ending tag mismatch: record line 6 and datafield ^ :22: parser error : Opening and ending tag mismatch: collection line 2 and record ^ :23: parser error : Extra content at the end of the document the url pattern is something like this: ../cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=''&itemnumber=''#edititem When I edit one of the fields on this screen it throughs the error above. It seems like a xml error, but after some internet sleuthing I came up with nothing. I also posted to the boarded and waited at least a month for a response and found nothing. The error message doesn't tell me much about wha the error is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 05:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 03:32:16 +0000 Subject: [Koha-bugs] [Bug 15695] koha-plack script breaks installations set up before 3.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 14:56:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 12:56:58 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 --- Comment #11 from Jonathan Druart --- I let this one for someone else, but I am pretty sure we could find something better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:17:11 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #13 from Jonathan Druart --- (In reply to Nick Clemens from comment #12) > Tests pass, but I have to reset plack to see the change happen when testing > in client. Will test again next week to see if it is me Yes, confirmed. This should be fixed by bug 16431. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:19:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:19:38 +0000 Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 --- Comment #5 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #4) > In this case the developer uses TestBuilder to INSERT IGNORE a CPL branch in > just one line. He knows that TestBuilder will not insert it if it is already > there and he does not want to see the warning. This assumption is wrong, tests should create the data they need to pass and not rely on existing data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:31:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:31:06 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:31:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:31:08 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52249|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 52254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52254&action=edit Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:31:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:31:14 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52250|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 52255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52255&action=edit Bug 13074: (followup) remove useless diag On running all Items-related tests some useless diag showed up. Removing it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:33:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:33:12 +0000 Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:33:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:33:16 +0000 Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51880|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 52256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52256&action=edit Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: [% INCLUDE 'datatables.inc' %] -> Must be: -> Missing in tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report Signed-off-by: Sinziana Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:33:19 +0000 Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 --- Comment #6 from Jonathan Druart --- Created attachment 52257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52257&action=edit Bug 16594: Fix obvious QA issues from bug 11371 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 15:35:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 13:35:39 +0000 Subject: [Koha-bugs] [Bug 16493] acq matching on title and author In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493 --- Comment #16 from Jonathan Druart --- Sonia, could you test it again with the follow-up please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:06:46 +0000 Subject: [Koha-bugs] [Bug 16714] New: Unexpected logout with "IP address change" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Bug ID: 16714 Summary: Unexpected logout with "IP address change" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org I get a new issue (not sure since when) under Plack: I am logged out with "IP address change" just after the first login. To reproduce: - logout - restart plack - login - click somewhere => You will be logged out I have tried to debug: diff --git a/C4/Auth.pm b/C4/Auth.pm index 985bd39..a494ddf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -818,6 +818,9 @@ sub checkauth { $userid = $s_userid; $sessiontype = $session->param('sessiontype') || ''; } + + warn $ip; + warn $ENV{REMOTE_ADDR}; if ( ( $query->param('koha_login_context') && ( $q_userid ne $s_userid ) ) || ( $cas && $query->param('ticket') && !C4::Context->userenv->{'id'} ) || ( $shib && $shib_login && !$logout && !C4::Context->userenv->{'id'} ) I get: After the login: $ip=undef, $ENV{REMOTE_ADDR}=192.168.254.1 After the click producing the logout: $ip=192.168.254.1, $ENV{REMOTE_ADDR}=127.0.0.1 After the second login: $ip=127.0.0.1, $ENV{REMOTE_ADDR}=127.0.0.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:07:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:07:11 +0000 Subject: [Koha-bugs] [Bug 16714] Unexpected logout with "IP address change" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Jonathan Druart --- Ha, you need to set SessionRestrictionByIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:07:27 +0000 Subject: [Koha-bugs] [Bug 16714] Unexpected logout with "IP address change" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |gmcharlt at gmail.com |ommunity.org | Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:14:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:14:03 +0000 Subject: [Koha-bugs] [Bug 16714] Unexpected logout with "IP address change" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 --- Comment #2 from Jonathan Druart --- Before the first login you need to hit /, not the mainpage with the logout.x param It seems that it exists on 3.22.x and 3.20.x as well. Not sure if this is important, maybe dependent to my config. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:19:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:19:47 +0000 Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about Plack::App::CGIBin instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:19:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:19:50 +0000 Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about Plack::App::CGIBin instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51979|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52258&action=edit Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance Using Plack with the debian psgi file, I get lots of warnings like: WARNING: Automatically converting Plack::App::CGIBin instance to a PSGI code reference. If you see this warning for each request, you probably need to explicitly call to_app() i.e. Plack::App::CGIBin->new(...)->to_app in your PSGI file. This patch is aimed to eliminate the warns. Test plan: Run Plack with plack.psgi or koha.psgi and verify if you do not see these warnings anymore. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:21:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:21:20 +0000 Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about Plack::App::CGIBin instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Who signed the| |Jonathan Druart patch off| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:30:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:30:22 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:30:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:30:26 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52252|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52259&action=edit Bug 16707: Fix software error in OPAC password recovery when leaving form fields empty The $search_results is considered as an arrayref but is not defined if no patron matches the recovery infos. Test plan: - Set syspref OpacResetPassword to "Allow" - Go to OPAC - Click link "Forgot your password? - On the following screen "Forgotten password recovery", do not fill in form fields, click "Submit" => Without this patch you got the software error => With this patch apply, you will get "No account was found with the provided information." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:31:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:31:34 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Marc, the eval is a bit weird here. Please have a look at my counter patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:32:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:32:29 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 [Bug 8753] Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 16:32:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 14:32:29 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:05:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:05:33 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart --- (In reply to David Cook from comment #13) > (In reply to Jonathan Druart from comment #11) > > Ok you will remove the software error, but I am not sure it's the way to go. > > > > I would certainly prefer a more thorough overhaul of Koha's DateTime > handling, but I think this is good enough for now. Chile can't use the > overdue functionality in Koha at all at this stage without this fix. > > > Currently the dates are stored in local time (so with the tz), if we want to > > switch to floating time zones (what we should do at some point!) I think we > > should recalculate all dates present in DB. > > An easy workaround would be to use Koha::DateUtils, which deals (at least > > try to) with invalid dates due du DST. > > Well, we calculate and interpret the dates using local time, but they're > stored without timezone in the database. > > So I'm not sure what you mean by "recalculate all dates present in DB". The > only difference between "local" and "floating" is the timezone. They're the > same numbers, so there would be no recalculation to do. Or do you mean we > should recalculate into UTC? If we plan to support several timezone, I think we will need to recalculate the existing dates into UTC, yes. > Even if it were stored in UTC, it would need to be converted to local, and > then to floating for the actual date handling, as we'd need the local > numbers before doing any datetime math/truncation for the holiday checks. Yes, floating times for calculation and tz to display/store the values. But let's have this discussion somewhere else :) > I have my reservations about Koha::DateUtils... I don't think enough thought > has been put into its implementation. Besides, it wouldn't work in this case. Well, look at the code before and after, we you will understand how it has been useful :) Looking at your patch again, it looks good. Please provide tests to highlight the issue you are trying to fix and to make sure this patch won't introduce regressions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:13:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:13:40 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:13:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:13:47 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 --- Comment #19 from Jonathan Druart --- Created attachment 52261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52261&action=edit Bug 16502: Add additional test to Plugins.t In order to verify if the delete now really works, we add one test in Plugins.t. Test plan: [1] Run the test. [2] Bonus: Comment line 63 in Plugins.t where delete is called. Run the test again. It should fail now. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:13:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:13:44 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51853|0 |1 is obsolete| | Attachment #51854|0 |1 is obsolete| | Attachment #51855|0 |1 is obsolete| | Attachment #51856|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 52260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52260&action=edit Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t If you run Plugin.t, the above table will still be present (when you did not enable UseKohaPlugins). This would trigger a warning when running the test a second time. Why? The uninstall call does its work not completely due to a small inconsistency in Koha::Plugins::Handler::delete when calling run without the enable_plugins parameter. This patch resolves that inconsistency and also removes an unneeded skip in Plugin.t in case the KitchenSink module already exists. Note: This is a small fix. But I wonder if the Handler routines run and delete should not have been implemented in Koha::Plugins::Base. Also note that plugins/plugins-uninstall.pl will not be affacted by this change, since it checks whether the pref is enabled before calling the delete method. Test plan: [1] Do not yet install this patch. [2] Verify that plugins are enabled in koha-conf.xml. [3] Disable UseKohaPlugins in System Preferences! [4] Run t/db_dependent/Plugins.t. [5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable still exists. (It should have been deleted.) Remove it manually. [6] Apply this patch. [7] Run the test again. [8] Verify that the table does not exist. [9] Run the test again (without warnings). Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:13:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:13:51 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 --- Comment #20 from Jonathan Druart --- Created attachment 52262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52262&action=edit Bug 16502: Adjust test for GetPlugins The current test assumes that GetPlugins will return the test plugin as the first one in the array. This is not correct. This patch adjusts the test to a grep. Test plan: Run the test. Bonus: Add additional plugins. Run the test again. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:13:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:13:56 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 --- Comment #21 from Jonathan Druart --- Created attachment 52263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52263&action=edit Bug 16502: Replace a few other ok-calls by is-calls Trivial changes that speak for themselves.. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:28:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:28:52 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #14 from Jonathan Druart --- (In reply to Nicholas van Oudtshoorn from comment #13) > Note: our site is currently live with this fix applied. But you can see the > old behaviour by clicking on the first link above! Which one? https://library.pbc.wa.edu.au/cgi-bin/koha/opac-search.pl?idx=&q=worship then click on second page, it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:29:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:29:00 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:38:34 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 --- Comment #15 from Nicholas van Oudtshoorn --- Hmmmm.... I think my patch might be masking the problem (needed a quick fix!) I'll see about rolling a version without the patch this Thursday when I'm back in at that job ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 11 17:38:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jun 2016 15:38:56 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |16.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 09:49:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 07:49:50 +0000 Subject: [Koha-bugs] [Bug 16715] New: Koha::Cache - Use Sereal for serialization Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Bug ID: 16715 Summary: Koha::Cache - Use Sereal for serialization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jweaver at bywatersolutions.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 [Bug 16166] Improve L1 cache performance and safety -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 09:49:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 07:49:50 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 [Bug 16715] Koha::Cache - Use Sereal for serialization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 09:50:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 07:50:09 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52246|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Comment on attachment 52246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52246 Bug 16166: Proposed followup to use Sereal for serialization Moved to bug 16715 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 09:50:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 07:50:41 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 09:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 07:50:44 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #1 from Jonathan Druart --- Created attachment 52264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52264&action=edit Bug 16166: Proposed followup to use Sereal for serialization This manages to eke out a bit more performance on my machine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:05:54 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:05:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:05:58 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51763|0 |1 is obsolete| | Attachment #51764|0 |1 is obsolete| | Attachment #51765|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 52265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52265&action=edit Bug 16166: Improve L1 cache performance and safety Bug 16044 introduced two-level caching mechanism to Koha::Cache. By default, get_from_cache() returns a deep copy of the data structures stored in L1 cache (aka "safe mode"). For extremely big and/or complex data structures (like MARC framework hash-of-hashes-of-hashes returned by GetMarcStructure() ), deep-cloning is currently sub-optimal; this patch addresses that particular issue. It also provides an ability to intermix "safe" and "unsafe" cache feches, in such way that they don't interfere with each other (i.e., eliminating the risk involved with "unsafe" calls possibly compromising further "safe" calls). Test plan: 1) apply patch 2) flush L2 cache if necessary (restart memcached daemon) 3) profile GetMarcStructure() calls before / after patch, e.g. by running some script which calls it often (like catalogue search w/ XSLT processing turned on, etc.) - GetMarcStructure() should be faster than before, in all possible circumstances (eg. 18 msec per call -> 10 msec p/call) 4) after testing, before returning to the master branch, flush L2 cache again (restart memcached daemon) - otherwise all system preferences returned from L2 cache would be suffixed with '-CF0' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:06:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:06:05 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 --- Comment #22 from Jonathan Druart --- Created attachment 52266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52266&action=edit Bug 16166: Fix t/Cache.t tests Thou shalt not forget to include changes made in the t/Cache.t in the patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:08:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:08:34 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 --- Comment #23 from Jonathan Druart --- See bug 16715 for more information about perfs gain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:10:15 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #2 from Jonathan Druart --- % more t.pl use Koha::Cache; my $t; for my $i ( 1 .. 3 ) { for my $j ( 1 .. 100000 ) { $t->{$i}{$j} = "$i$j"; } } for ( 1 .. 10 ) { my $cache = Koha::Cache->get_instance; $cache->set_in_cache( 'my_t', $t ); $cache->get_from_cache( $t ); } % git checkout master % time perl t.pl perl t.pl 4.76s user 0.11s system 100% cpu 4.875 total % git checkout bug_16166 ( Bug 16166: Improve L1 cache performance and safety + Bug 16166: Fix t/Cache.t tests ) % time perl t.pl perl t.pl 2.28s user 0.14s system 100% cpu 2.423 total % git checkout bug_16715 ( Bug 16166: Proposed followup to use Sereal for serialization ) % time perl t.pl perl t.pl 1.75s user 0.05s system 99% cpu 1.803 total Note that I did not manage to prove the gain using Koha, I have tried an intranet search with 100 results (xslt) and the execution time is always between 13s and 13.5s. I did not notice a significant gain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:11:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:11:12 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ablewicz at gmail.com --- Comment #3 from Jonathan Druart --- Jacek, could you have a loot at this patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:31:41 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #31 from Jonathan Druart --- Katrin, I may be a bit lost here, but with this patch, the behavior changes between package and non-package installs. (In reply to Katrin Fischer from comment #29) > Please note: This whole discussion is about the file for non-package setups. > I think the behaviour for packages is different anyway. As we are using > packages I am fine with any solution. We use debian/koha-common.cron.daily > as changed in this patch for several versions now. The discussion is for both setups, as we want to have the same behavior :) What I understand is that, using packages, the overdue notices will be generated even if the fines are not generated correctly. And it's not what you want apparently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:34:20 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #32 from Jonathan Druart --- As this is a major one, I'd suggest to move the automatic_renewals script before the fines calculation, and then open a new bug report for the error handling problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 10:55:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 08:55:46 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 --- Comment #3 from Jonathan Druart --- I am not in favor of adding 0.15s when we are fighting to gain ms everywhere in the code, so I'd vote for b. (In reply to Kyle M Hall from comment #0) > This can cause numerous issues and difficulties making sure memcached is > enabled for all cron scripts, for plack, etc. Could you detail the issues and difficulties? Why is it hard to set the env var? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:00:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:00:00 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 --- Comment #4 from Jonathan Druart --- But b is not ideal neither. You expect that memcached won't be use if the env var is not defined. We can imagine a sysop wanting to disable the cache (because a bug has been found). He does not necessarily want to stop memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:32 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50401|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 52267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52267&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:36 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50402|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 52268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52268&action=edit Bug 15707 - Add new modules Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:41 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50403|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 52269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52269&action=edit Bug 15707 - Add editor Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:45 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50404|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 52270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52270&action=edit Bug 15707 - Add and update schema files Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:50 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50405|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 52271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52271&action=edit Bug 15707 - Add TreeGrid library to about page Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:54 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50406|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart --- Created attachment 52272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52272&action=edit Bug 15707 - Unit Tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:17:58 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50407|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart --- Created attachment 52273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52273&action=edit Bug 15707: Fix conflict with bug 15446 (type vs _type) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:18:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:18:03 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50408|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart --- Created attachment 52274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52274&action=edit Bug 15707 [QA Followup] - Switch to treetable which Koha already uses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:18:08 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #58 from Jonathan Druart --- Created attachment 52275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52275&action=edit Bug 15707: QA follow-up - Drop table if exists 1/ DROP table if exists 2/ FAIL spelling decendents ==> descendants -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:21:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:21:54 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52259|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 52276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52276&action=edit Bug 16707: Fix software error in OPAC password recovery when leaving form fields empty The $search_results is considered as an arrayref but is not defined if no patron matches the recovery infos. Test plan: - Set syspref OpacResetPassword to "Allow" - Go to OPAC - Click link "Forgot your password? - On the following screen "Forgotten password recovery", do not fill in form fields, click "Submit" => Without this patch you got the software error => With this patch apply, you will get "No account was found with the provided information." Sign-off on counter patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:24:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:24:37 +0000 Subject: [Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:26:13 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #59 from Jonathan Druart --- (In reply to Kyle M Hall from comment #49) > (In reply to Jonathan Druart from comment #37) > > 2/ What's next for these library groups? What's the difference with our > > existing groups? Is there a plan to move the existing ones to this new table? > > Bug 15708 is my first enhancement that will take advantage of this. However, > I think there will be many other possible uses for this system in the > future. The existing groups function is not actually used anywhere in Koha > and should probably be removed. The search groups could go either way, but > are fine the way they are. > > What makes this far more powerful is the ability to define hierarchical > group structures. This will be a cornerstone for making Koha much more > usable in consortial library settings. It is weird to have 2 "library groups" features and I think the first step should be to replace the existing one. The existing feature is used in the advanced search form and should work. Moreover I'd like to get Owen opinion on the modal you use to create/update a new entry. I am going to ping him on IRC. There are also some inconsistencies on styles, the confirmation of add/update is a warning (orange) Keeping it in the Signed Off queue to get other opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:28:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:28:47 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #60 from Jonathan Druart --- Also it might be odd to have a new feature not doing anything (if pushed as it) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 11:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 09:32:06 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #61 from Jonathan Druart --- The following patch could be obsoleted: Bug 15707 - Add TreeGrid library to about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 12:10:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 10:10:09 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #27 from Jonathan Druart --- Created attachment 52277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52277&action=edit Bug 3669: Remove parameters passed to action of form Sounds weird to pass parameters to the action of a POST form. This patch adds a workaround. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 12:12:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 10:12:28 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #28 from Jonathan Druart --- It would be nicer to get a message to inform the librarian that the message has been added successfully. Actually it would have been better to ajaxify this script, to avoid the reload and the problematic of POST form. Owen, do you think this is an acceptable solution and then we should ajaxify this script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 12:44:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 10:44:10 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 12:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 10:44:16 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51378|0 |1 is obsolete| | Attachment #51393|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 52278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52278&action=edit Bug 6906 - show 'Borrower has previously issued... New feature: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their checkout history. - Global syspref ('CheckPrevCheckout'), set to 'hardno' by default, allows users to enable this feature library wide. - Per patron category pref allows libraries to create overrides per category, falling back on the global setting by default. - Per patron pref allows switching the functionality on at the level of patron. Fall-back to category settings by default. * Koha/Patron (wantsCheckPrevCheckout, doCheckPrevCheckout): New methods. * C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevCheckout check. * admin/categories.pl: Pass along checkprevcheckout. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose CheckPrevCheckout per category setting. * koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref: Expose CheckPrevCheckout syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVCHECKOUT' confirmation message. * installer/data/mysql/kohastructure.sql: Modify structure of 'categories', 'borrowers', 'oldborrowers'. * installer/data/mysql/sysprefs.sql: Add 'CheckPrevCheckout'. * installer/data/mysql/atomicupdate/checkPrevCheckout.sql: New file. * t/db_dependent/Patron/CheckPrevCheckout.t: New file with unit tests. Test plan: - Apply patch. - Run updatedatabase. - Regenerate Koha Schema files. - Run the unit tests. - Verify 'CheckPrevCheckout' is visible in Patrons sysprefs and can be switched to 'hardyes', 'softyes', 'softno' and 'hardno'. + Check out previously checked out items to a patron, checking the message appears as expected. - Verify no 'Check previous checkouts' setting appears on the borrower category pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting if that is set to a 'soft' option). - Verify no 'Check previous checkouts' setting appears on the individual borrower pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting if the latter is set to a 'soft' option). Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 12:44:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 10:44:21 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #46 from Jonathan Druart --- Created attachment 52279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52279&action=edit Bug 6906: Tests - Do not assume CPL exists Since bug 14878, tests must create the data they need to pass and not assume they exist. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 12:44:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 10:44:38 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #47 from Jonathan Druart --- Created attachment 52280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52280&action=edit Bug 6906: Add the warning message to the batch checkout Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:06:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:06:07 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Kyle, please provide tests. Your patch deletes 2 images, is it expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:12:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:12:22 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Needs Signoff --- Comment #5 from Jonathan Druart --- I'd like to get different opinions before QAing it. Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:14:11 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 --- Comment #6 from Jonathan Druart --- My main concern is that the sidebar takes lot of spaces and may annoy librarians using it all day long. For instance I don't think it's important for them to see the link to the offline circ tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:15:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:15:33 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #7 from Jonathan Druart --- Ccing Katrin and Owen. It would be great to get opinions from librarians using it daily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:17:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:17:08 +0000 Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:17:11 +0000 Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51872|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52281&action=edit Bug 16543 - Make edit and delete links styled buttons in patron attribute types administration This patch modifies the Patron attribute types page, converting edit and delete links to Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> Patron attribute types. The 'Edit' and 'Delete' buttons should look correct and work correctly. Signed-off-by: Jan Kissig Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:19:26 +0000 Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:19:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:19:29 +0000 Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51884|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52282&action=edit Bug 16541 - Make edit and delete links styled buttons in cities administration This patch modifies the cities administration page, converting edit and delete links to Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> Cities and towns. The 'Edit' and 'Delete' buttons should look correct and work correctly. Signed-off-by: rainer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:20:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:20:57 +0000 Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |13364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 [Bug 13364] Add a call number browser to add item page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:20:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:20:57 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 [Bug 16577] Improve call number browser plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:28:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:28:55 +0000 Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:29:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:29:00 +0000 Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51895|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52283&action=edit Bug 16577 - Improve call number browser plugin This patch makes several markup and style improvements to the call number browser plugin added by Bug 13364. Some of the changes: - The size of the pop-up window has been increased slightly for a less cramped display. - Page structure has been updated to match similar pop-up windows. - Page structure has been improved to further accommodate the option of viewing the call number browser as a full page rather than a pop-up window (although as far as I can tell it is not linked to in this mode anywhere). - Row highlighting has been updated so that page styles are not being passed explicitly by the script. Highlight colors have been changed to make things more readable. - DataTables-related markup has been removed because it was not being used. It doesn't make sense to re-order table rows when the purpose of the table is to display call number order. To test, apply the patch and edit a framework so that the item call number field uses the 'cn_browser.pl' plugin. - Create or edit an item in cataloging. - Enter an existing call number into the call number field. - Click the '...' link next to the call number. - In the call number browser pop-up, verify that items matching your call number are highlighted in red. - Verify that the new 'Close' button at the bottom of the page works correctly. - Enter a call number which doesn't exist in the call number field - Click the '...' link to trigger the browser. - Verify that there is a row highlighted in green marking the sort order of the call number you chose. - Navigate directly to /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl - The page should appear like a normal full page, with header search, breadcrumbs, etc. Performing a search for call numbers should work like it did in the pop-up context. Signed-off-by: Fr?d?ric Demians Works as described. Pleasing to the eye Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:29:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:29:05 +0000 Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 --- Comment #4 from Jonathan Druart --- Created attachment 52284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52284&action=edit Bug 16577: Minor improvement on else if statements Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:30:12 +0000 Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 --- Comment #5 from Jonathan Druart --- (In reply to Owen Leonard from comment #1) > - DataTables-related markup has been removed because it was not being > used. It doesn't make sense to re-order table rows when the purpose of > the table is to display call number order. But we could have kept the constructor anyway :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:33:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:33:45 +0000 Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:33:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:33:49 +0000 Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51932|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52285&action=edit Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:52:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:52:02 +0000 Subject: [Koha-bugs] [Bug 16123] Display budget hierarchy in the budget dropdown menu used when placing a new orde In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Philippe, Please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 13:56:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 11:56:40 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- How this can be useful for a library? Should not we use DEBUG instead of INFO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:29 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:32 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:35 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:38 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:40 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:43 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:46 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:50:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:50:49 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52020|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:51:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:51:47 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 52286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52286&action=edit Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:51:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:51:52 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 52287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52287&action=edit Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:51:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:51:58 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 52288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52288&action=edit Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:52:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:52:07 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 52289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52289&action=edit Bug 14048: Add a refund rules setting form in smart-rules This patch introduces the CRUD UI for managing the refund lost item fee rules on the general 'Circulation and fines rules' page. Verify that rules can be added and changed. Rules are correctly associated to the chosen branch (or the general default rule). To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:52:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:52:13 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 52290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52290&action=edit Bug 14048: Hook new rules into C4::Circulation This patch makes AddIssue and AddReturn use the new implementation The behaviour should respect the specification. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:52:19 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 52291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52291&action=edit Bug 14048: [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:52:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:52:25 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 52292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52292&action=edit Bug 14048: (QA followup) Fix for TooMany.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:55:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:55:36 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52288|0 |1 is obsolete| | --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 52293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52293&action=edit Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:56:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:56:46 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:56:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:56:57 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:57:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:57:16 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:58:23 +0000 Subject: [Koha-bugs] [Bug 15695] koha-plack script breaks installations set up before 3.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:58:36 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 14:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 12:59:36 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 15:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 13:53:55 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #69 from Tom?s Cohen Arazi --- Kyle, upgrade the DBIx schema! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 16:19:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 14:19:09 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #70 from Tom?s Cohen Arazi --- While I agree with the timestamp, I must say systems syncing borrowers should use borrowers.borrower_sync which links to the table borrower_sync, which is well engineered to be reused outside the limited scope of the NorwegianPatronDB thing. We should even extend plugins to allow for different sync implementations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 12 16:24:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 14:24:41 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #71 from Tom?s Cohen Arazi --- Created attachment 52294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52294&action=edit Bug 10459: (followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 01:13:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 23:13:29 +0000 Subject: [Koha-bugs] [Bug 5632] SIP improvements = Date formatting & debarrement management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5632 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 01:13:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jun 2016 23:13:30 +0000 Subject: [Koha-bugs] [Bug 5992] Biblibre various improvements for 3.4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5992 Bug 5992 depends on bug 5632, which changed state. Bug 5632 Summary: SIP improvements = Date formatting & debarrement management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5632 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:22:02 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52167|0 |1 is obsolete| | --- Comment #30 from Srdjan Jankovic --- Created attachment 52295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52295&action=edit [SIGNED-OFF] Bug 7703 - QA Followup Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:23:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:23:19 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52168|0 |1 is obsolete| | --- Comment #31 from Srdjan Jankovic --- Created attachment 52296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52296&action=edit [SIGNED-OFF] Bug 7703 - QA Followup 2 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:23:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:23:16 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:30:31 +0000 Subject: [Koha-bugs] [Bug 16716] New: Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Bug ID: 16716 Summary: Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:34:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:34:58 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #1 from Srdjan Jankovic --- MySQL used to tolerate it, but won't any more. A noop, places where GetborCatFromCatType() (member area, eg add/modify member) and GetAuthorisedValues() (all over the place, eg item edit for Lost status etc) are used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:35:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:35:19 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:40:42 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 05:40:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 03:40:45 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 --- Comment #2 from Srdjan Jankovic --- Created attachment 52297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52297&action=edit Bug 16716: Replaced wrong GROUP BY with DISTINCT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 08:48:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 06:48:58 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 08:49:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 06:49:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #308 from Marcel de Rooy --- Created attachment 52298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52298&action=edit Bug 7143: [QA Follow-up] Adjusting developer information For consistency we should not only add firstnames to the list of developers in about. Adding some surnames with the help of git log and Bugzilla. Also corrected a closing li tag. Note that I did not find one surname: Natasha of Catalyst Academy. Probably Chris could add that missing piece. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 08:49:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 06:49:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 08:50:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 06:50:22 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 08:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 06:55:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52298|0 |1 is obsolete| | --- Comment #309 from Marcel de Rooy --- Created attachment 52299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52299&action=edit Bug 7143: [QA Follow-up] Adjusting developer information For consistency we should not only add firstnames to the list of developers in about.tt and history.txt. Adding some surnames with the help of git log and Bugzilla. Also corrected a closing li tag. Note that I did not find one surname: Natasha of Catalyst Academy. Probably Chris could add that missing piece. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:11:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:11:35 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51851|0 |1 is obsolete| | Attachment #52229|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 52300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52300&action=edit Bug 16500: [QA Follow-up] Catch warning if branch MPL already exists The current test had no warnings, when you have no MPL branch, and only catches the warn from the second build on line 57. If you do have MPL, a warning comes from line 56. This patch fixes it by removing MPL from the test. A new branch is created first and then we try to create it again. Test plan: Run the test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:12:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:12:36 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #7) > > (In reply to Jonathan Druart from comment #6) > > > Created attachment 52229 [details] [review] [review] [review] > > > [COUNTER-PATCH] Bug 16500: Do not try to insert MPL if already exists > > > > Marcel, what about this patch to replace your second patch? > > That would obviously work fine too, but I'd rather replace it by one line in > the dependent patch (16607). So I prefer to keep the original one.. I finally decided to go for the third patch :) and remove MPL completely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:13:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:13:48 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16607 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 [Bug 16607] Add quiet flag to builder sub in TestBuilder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:13:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:13:48 +0000 Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|16500 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 [Bug 16500] Catch two warns in TestBuilder.t with warning_like -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:35:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:35:56 +0000 Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:41:37 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add quiet flag to builder |Remove CPL/MPL from two |sub in TestBuilder |unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:44:02 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > (In reply to Marcel de Rooy from comment #4) > > In this case the developer uses TestBuilder to INSERT IGNORE a CPL branch in > > just one line. He knows that TestBuilder will not insert it if it is already > > there and he does not want to see the warning. > > This assumption is wrong, tests should create the data they need to pass and > not rely on existing data. It was a nice flag, do not add it in the future ;) I adjusted the Accounts.t test now. Hilarious actually. Removed CPL/MPL from AutomaticItemModificationByAge.t. The Holds.t patch goes on another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:53:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:53:59 +0000 Subject: [Koha-bugs] [Bug 16717] New: Remove hardcoded category from Holds.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Bug ID: 16717 Summary: Remove hardcoded category from Holds.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com This patch comes from report 16607. With a limited scope it needed its own report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:56:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:56:22 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:56:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:56:25 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 --- Comment #1 from Marcel de Rooy --- Created attachment 52301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52301&action=edit Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:56:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:56:36 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:57:46 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:57:49 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51857|0 |1 is obsolete| | Attachment #51873|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 52302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52302&action=edit Bug 16607: Remove CPL/MPL from two unit tests Test t/db_dependent/Accounts.t: This test created a MPL branch, but did not use it any more. Test t/db_dependent/Items/AutomaticItemModificationByAge.t: This test still used CPL/MPL branches. Now it uses two new branches. Test plan: [1] Run t/db_dependent/Accounts.t. [2] Run t/db_dependent/Items/AutomaticItemModificationByAge.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 09:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 07:58:02 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 10:16:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 08:16:38 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52302|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 52303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52303&action=edit Bug 16607: Remove CPL/MPL from two unit tests Test t/db_dependent/Accounts.t: This test created a MPL branch, but did not use it any more. Test t/db_dependent/Items/AutomaticItemModificationByAge.t: This test still used CPL/MPL branches. Now it uses two new branches. Test plan: [1] Run t/db_dependent/Accounts.t. [2] Run t/db_dependent/Items/AutomaticItemModificationByAge.t. Signed-off-by: Marcel de Rooy Both tests pass OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 10:16:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 08:16:58 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 10:19:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 08:19:08 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52301|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 52304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52304&action=edit Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy Test passes OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 10:19:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 08:19:28 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 10:29:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 08:29:28 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #4 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #3) > Jacek, could you have a loot at this patch please? Sounds kinda Freudian, but hey - why not :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 11:01:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 09:01:48 +0000 Subject: [Koha-bugs] [Bug 16661] Plack: Enable and differentiate logging in misc/plack/plackup.sh In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16661 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52031|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 52305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52305&action=edit Bug 16661: Plack: Enable and differentiate logging in misc/plack/plackup.sh This is only about the plackup.sh script in misc. Currently logging is disabled by default. I would prefer to enable by default. Also logging does not differentiate between opac and intranet. It should. Amended to use different file names for the plack logs, separate from the apache logs. Apache probably listens too and uses the other logs. Test plan: Run plackup.sh for opac and intranet. Verify that logfiles are used as you would expect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 11:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 09:17:58 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #5 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > Note that I did not manage to prove the gain using Koha, I have tried an > intranet search with 100 results (xslt) and the execution time is always > between 13s and 13.5s. I did not notice a significant gain. httping -c 40 -i 0.01 'http://koha.wherever/cgi-bin/koha/opac-search.pl?q=unix' (OPACnumSearchResults = 100, XSLT enabled, CGI + memcached): - master: 40 connects, 40 ok, 0.00% failed round-trip min/avg/max = 5911.8/6032.2/6215.6 ms - master + Bug 16166 round-trip min/avg/max = 5535.5/5626.0/5846.7 ms (6.7% gain) - master + Bug 16166 + Bug 16715 round-trip min/avg/max = 5488.9/5521.9/5761.8 ms (8.5% gain) - master + Bug 16166 + Bug 16715 + Bug 16365 round-trip min/avg/max = 3572.2/3719.5/3780.2 ms (38.3% gain) httping -c 40 -i 0.01 'http://koha.wherever/cgi-bin/koha/opac-search.pl?q=asfasdffghj' (0 search results - same setup, i.e. CGI + memcached) - master round-trip min/avg/max = 879.2/912.8/1107.5 ms - master + Bug 16166 + Bug 16715 + Bug 16365 round-trip min/avg/max = 886.3/916.5/1009.8 ms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 11:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 09:32:06 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #250 from Juan Romay Sieira --- Thank you Jonathan, the patch in bug 16708 applies correctly and the authorities reindex fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 12:06:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 10:06:07 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #1 from Benjamin Rokseth --- (In reply to Lari Taskula from comment #0) > It's great that Bug 15126 splits Swagger specification over multiple files. > However, the problem of still exists as swagger.json grows larger with each > new path. We should do the same split as Bug 15126 did, but for paths and > parameters. I propose the following structure for paths: > > . > ??? swagger.json > ??? definitions > ? ??? index.json > ? ??? error.json > ? ??? patron.json > ??? parameters > ? ??? index.json > ? ??? patron.json > ??? paths > ??? index.json > ??? patrons.json > > Also Swagger should specify the required permissions for each resource. We > can do this by adding "x-koha-permission"-field for each path, and using > this field when checking for the needed permissions. This way required > permissions are well-documented and anyone can instantly find out which > permissions they need. Agree with this one, patching swagger.json for each api update/enhancement is cumbersome and prone for errors. As it seems you have already implemented this, please submit patch and I will review asap. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 13:15:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 11:15:51 +0000 Subject: [Koha-bugs] [Bug 16493] acq matching on title and author In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Koha Team Lyon 3 --- I have an error when I try to import the batch with the default option "Title and Author" Software error: Undefined subroutine &main::FindDuplicate called at /home/koha/src/acqui/addorderiso2709.pl line 163. For help, please send mail to the webmaster (webmaster at test4-sandbox), giving this error message and the time and date of the error. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 13:18:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 11:18:05 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #25 from Kyle M Hall --- Created attachment 52306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52306&action=edit Bug 14048 [QA Followup] - Delete only the removed system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 13:24:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 11:24:48 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #6 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > > for ( 1 .. 10 ) { > my $cache = Koha::Cache->get_instance; > $cache->set_in_cache( 'my_t', $t ); > $cache->get_from_cache( $t ); > } This test looks a bit flawed, a least in the ->get_from_cache() part, I replaced this part with my $cache = Koha::Cache->get_instance; $cache->set_in_cache( 'my_t', $t ); for ( 1 .. 100 ) { $cache->get_from_cache( 'my_t' ); } to make interpretation of the results somehow easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 13:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 11:49:32 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #7 from Jacek Ablewicz --- Sereal encoder is much better (2-3x) then freeze() - both speed- and sizewise (especially with "snappy" compression enabled), for all data structure types, big and small. Sereal decoder is also much faster (up to 2x) then thaw() for small and medium-sized data structures. For a very big structures, it's still faster then thaw(), but speed difference is less pronounced (e.g. for a MARC framework: sereal decode takes ~7 msec, and thaw - 8.5 msec). But it's hardly deserializers fault, most of that time is wasted in perl internals on hash keys and SVs creation. Note that destroing / garbage collection of all those hashes-of-hashes also takes significant time (3-4 msec for a MARC framework). The only drawback I see is the lack of packaged version for Wheezy.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 13:54:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 11:54:53 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 13:54:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 11:54:57 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52264|0 |1 is obsolete| | --- Comment #8 from Jacek Ablewicz --- Created attachment 52307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52307&action=edit Bug 16166: Proposed followup to use Sereal for serialization This manages to eke out a bit more performance on my machine. https://bugs.koha-community.org/show_bug.cgi?id=16715 Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:23:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:23:39 +0000 Subject: [Koha-bugs] [Bug 16718] New: Translatability: Fix problems with sentence splittinb by in about.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718 Bug ID: 16718 Summary: Translatability: Fix problems with sentence splittinb by in about.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr There are some sentences splitted by tags in koha-tmpl/intranet-tmpl/prog/en/modules/about leading to translatability problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:23:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:23:58 +0000 Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence splitting by in about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Fix |Translatability: Fix |problems with sentence |problems with sentence |splittinb by in |splitting by in |about.tt |about.tt Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:26:40 +0000 Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence splitting by in about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718 --- Comment #1 from Marc V?ron --- Created attachment 52308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52308&action=edit Bug 16718 - Translatability: Fix problems with sentence splitting by in about.tt This patch removes sentence splitting by tags in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt for better translatability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:27:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:27:01 +0000 Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence splitting by in about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:30:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:30:29 +0000 Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence splitting by in about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52308|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 52309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52309&action=edit Bug 16718 - Translatability: Fix problems with sentence splitting by in about.tt This patch removes sentence splitting by tags in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt for better translatability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:35:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:35:45 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #26 from Tom?s Cohen Arazi --- (In reply to Kyle M Hall from comment #25) > Created attachment 52306 [details] [review] > Bug 14048 [QA Followup] - Delete only the removed system preference Hehe, I don't know why I didn't notice the second line was removed, see the commented Perl code! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:41:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:41:27 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49700|0 |1 is obsolete| | Attachment #49822|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 52310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52310&action=edit Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold Right now, if a library automatically cancels expired waiting holds, a librarian must still re-checkin an item to trap the next available hold for that item. It would be better if the next hold was automatically trapped and the librarians receive an email notification so they can make any changes to the item if need be ( hold area, hold slip in item, etc ). Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with one item 4) Place two holds on that record 5) Check in the item and set it to waiting for the first patron 6) Set ReservesMaxPickUpDelay to 1 7) Enable ExpireReservesMaxPickUpDelay 8) Enable ExpireReservesAutoFill 9) Set an email address in ExpireReservesAutoFillEmail 10) Modify the holds waitingdate to be in the past 11) Run misc/cronjobs/holds/cancel_expired_holds.pl 12) Note the hold is now waiting for the next patron 12) Note a waiting hold notification email was sent to that patron 13) Note a hold changed notification email was sent to the library Signed-off-by: Gene Miller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:41:24 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:41:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:41:36 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #24 from Kyle M Hall --- Created attachment 52311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52311&action=edit Bug 14364: (QA followup) - Remove use of C4:Dates - Fix misnamed variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:41:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:41:40 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #25 from Kyle M Hall --- Created attachment 52312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52312&action=edit Bug 14364 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:44:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:44:08 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14107 --- Comment #5 from Marc V?ron --- I fixed it for patron cards, there could be a similar solution for labels, but there is som more work necessary. Bug 14107 - Patron cards: Make barcode width and height scaling editable See also comment #1 on Bug 14149 - Labels: Make barcode width and height scaling editable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:44:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:44:08 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10762 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:46:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:46:32 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:46:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:46:35 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52207|0 |1 is obsolete| | --- Comment #5 from Claire Gravely --- Created attachment 52313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52313&action=edit Bug 16324: Move item search into header This patch makes the Search button in the header into a dropdown that holds the Advanced search and the Item search. I have rewritten this patch to be independent of Bug 16323 since that patch is so controversial. To test: 1) Confirm that Advanced search and Item search are both under the 'Search' dropdown menu in the header and both links work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:57:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:57:02 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52175|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 52314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52314&action=edit Bug 15485: Introduce new sysprefs for lists XSLTs This patch introduces two new sysprefs, allowing the users to set custom XSLTs for lists display. This is done almost the usual way. If none is specified (value='') it defaults to the current behaviour: using the *Results.xsl file for the corresponding interface. Sponsored-by: Carnegie Stout Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:57:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:57:10 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52176|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 52315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52315&action=edit Bug 15485: Use lists-specific XSLT sysprefs This patch makes the shelves.pl (staff) and opac-shelves.pl scripts use the new sysprefs for specifying custom XSLTs for lists display. XSLT.pm is patched so it defaults to the corresponding *Results.xsl files if none is specified. To test: - Create a list - Open the list in the staff interface - On a new tab, open the list in the OPAC. - Apply this patches === default behaviour - Open the list (both opac and staff) on new tabs => SUCCESS: They look exactly the same (hint: the syspref is set to '' so it should fallback to using the one we were using. === using the new functionality - Create custom XSLTs for lists, for example: $ cd /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/xslt $ cp MARC21slim2OPACResults.xsl MARC21slim2OPACLists.xsl - Edit your sysprefs, setting OPACXSLTListsDisplay to: /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/MARC21slim2OPACLists.xsl - Reload the OPAC list view => SUCCESS: Looks exactly as before - Make some minor tweak (for example in line 423 replace for BLAH - Reload the list => SUCCESS: BLAH shows in several places on the title. - Repeat for the staff interface - Sign off :-D So we can now set custom XSLTs for lists. Sponsored-by: Carnegie Stout Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 14:58:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 12:58:15 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #62 from Owen Leonard --- > (In reply to Jonathan Druart from comment #59) > It is weird to have 2 "library groups" features and I think the first step > should be to replace the existing one. I agree. It is confusing to have two menu items on the administration page, "Libraries and groups" and "Library groups." I think we should think of a way to manage all this functionality in one section. Some other comments: - Nowhere else do we use the "fa-plus-circle" icon for "add." We always use "fa-plus." - Nowhere else in Koha do we use a modal to display an add form. We either display a form on a separate page or we use JS to show/hide the edit form on the page to mimic the display of a separate page. See admin/items_search_fields.pl for example. - Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always use "fa-pencil." - When displaying confirmation messages we use '
    ' not '
    ' - There is no reason to display an icon ("") next to each group. It doesn't serve any function. - There is no reason to display an icon ("") next to each library in a group. It doesn't serve any function. - Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It should be "fa-trash." - Nowhere else in Koha do we add an icon to the "actions" menu. - Nowhere else in Koha do we use a modal to display a delete confirmation message. I think I could be convinced that we should, but I'd like to hear the argument. If we do, we should use the space given to display more information about the deletion than this implementation does, e.g. what exactly am I deleting? - Instead of a "home" icon for "Add library" I think it should be the "plus" icon which is associated with adding or creating something. - The list of libraries in the "Add library" dropdown should be alphabetized by library name, not library code. - This patch adds five new instances of "onclick." I've been working very hard to eliminate the use of "onclick" and I don't think new patches should add them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:20:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:20:49 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11921 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:20:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:20:49 +0000 Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16579 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:36:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:36:39 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 --- Comment #5 from Jacek Ablewicz --- 140 miliseconds? Quite a lot - I know config file is currently parsed 3 times by an average script (for no apparent reason), but on my test setup, C4::Context->new() call only takes ~5.1 miliseconds. Memcache not enabled. And I have three Z39.50 servers defined in there. With Cache => 'memcopy' added to XMLin() in C4/Context.pm, its down to 92 microseconds per call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:45:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:45:43 +0000 Subject: [Koha-bugs] [Bug 16719] New: LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Bug ID: 16719 Summary: LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: oliver.bock at aei.mpg.de QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 52316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52316&action=edit Patch: proper NULL mapping LDAP attributes with empty values are currently mapped as empty strings, which is described as 'failsafe'. This defeats the existing database constraints (NULL and UNIQUE) without an apparent need. If some kind of empty default is required, it should be set in the mapping config itself, not the code. Please note that this is not just a semantic issue since mapping empty LDAP values as an empty string does indeed cause a constraint violation (read: database error, hence our severity) when such an attribute bears a UNIQUE constraint. This is due to the fact that an empty string is an actual value validated by the constraint (NULL isn't). I don't know the reasoning behind the empty-string mapping but should a NULL-mapping have been the original intention then please note that this behavior is database-dependent. The correct way to map NULL in a database-agnostic way is to use "undef" (see my patch). Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:47:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:47:09 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Oliver Bock changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:49:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:49:34 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 --- Comment #6 from Jacek Ablewicz --- Either way, I have a feeling that implementing it (fetching memcache settings from Koha config) is not going to be easy. Fastmmap caching system is still broken, because it wasn't easy in that case (see Bug 16067 & Bug 11998 comment #114 +). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:55:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:55:58 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #9 from Galen Charlton --- (In reply to Agnes Rivers-Moore from comment #4) > I would wish to have that associated with the "Always show" function so that > it only appears if "always show" is turned off. > It uses up screen space we would rather use to see the last several items we > checked out - and there is already room for only one or two rows to show > unless the screen resolution is dialed up. A patch implementing this can be found at http://git.esilibrary.com/?p=koha-equinox.git;a=commitdiff;h=6d63573393b911444db599b1b2e2d5c680ee5a15. Perhaps this should be spun off into a separate bug? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:57:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:57:17 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51974|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 52317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52317&action=edit Bug 13691: Remove existing selenium scripts They are not usable. Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:57:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:57:26 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51975|0 |1 is obsolete| | --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 52318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52318&action=edit Bug 13691: Add basic selenium script This script has been used to compare 3.16.x and 3.18.x performances on bug 13690. What it does: - Go on the mainpage and process a log in - Create a patron category - Create a patron - Add 3 items - check the 3 items out to the patron - check the 3 items in How to use it? $ wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar $ vim /etc/apt/sources.list.d/firefox.list deb http://packages.linuxmint.com debian import $ apt-get update $ apt-get install firefox $ sudo apt-get install xvfb $ SELENIUM_PATH=/home/koha/tools/selenium-server-standalone-2.53.0.jar $ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & $ DISPLAY=:1 java -jar $SELENIUM_PATH perl t/db_dependent/selenium/basic_workflow.t Signed-off-by: Chris Cormack Note the pages have changed so the tests will not all pass. Also you need Selenium::Remote::Driver installed and staffClientBaseURL must be set I will change the tests in a follow up patch. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:57:38 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51976|0 |1 is obsolete| | --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 52319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52319&action=edit Bug 13691: Add changes for 3.22 To test: Run the tests t/db_dependent/selenium/basic_workflow.t After you have set up selenium following the tests in the previous patch Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:58:04 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 15:59:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 13:59:14 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 --- Comment #7 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #3) > Why is it hard to set the env var? Maybe it's not that hard, but it needs to be done in many places, and somehow it gets often forgotten. E.g., in 3.22.6 (or 3.22.7) installed from packages, memcached is enabled by default for CGI/plack, but memcached environment variables are not defined for shell / maintenance scripts. After installer/data/mysql/updatedatabase.pl DB update is done from command line, GUI is still prompting for an update, because it fetches (outdated) version preference from the memcache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 16:22:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 14:22:09 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 OpenGeek changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #18 from OpenGeek --- ?This patch solve the repodted issue with overdue_process.pl using TZ=America/Santiago In fact, overdue_process.pl calculated until 1985 without errors. (Do not ask me why they have issues with that date :P ) Many Thanks David, Chris, John, and all involved !! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 16:26:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 14:26:27 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #19 from Tom?s Cohen Arazi --- (In reply to OpenGeek from comment #18) > ?This patch solve the repodted issue with overdue_process.pl using > TZ=America/Santiago > > In fact, overdue_process.pl calculated until 1985 without errors. > (Do not ask me why they have issues with that date :P ) > > > Many Thanks David, Chris, John, and all involved !! Hey, this one is failed-qa, I promised a regression test which I haven't provided and Jonathan failed it! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 16:26:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 14:26:36 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 16:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 14:26:43 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 17:11:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 15:11:46 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 17:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 15:11:48 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52314|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard --- Created attachment 52320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52320&action=edit Bug 15485: Introduce new sysprefs for lists XSLTs This patch introduces two new sysprefs, allowing the users to set custom XSLTs for lists display. This is done almost the usual way. If none is specified (value='') it defaults to the current behaviour: using the *Results.xsl file for the corresponding interface. Sponsored-by: Carnegie Stout Library Signed-off-by: Nick Clemens Signed-off-by: Deb Stephenson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 17:11:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 15:11:54 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52315|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 52321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52321&action=edit Bug 15485: Use lists-specific XSLT sysprefs This patch makes the shelves.pl (staff) and opac-shelves.pl scripts use the new sysprefs for specifying custom XSLTs for lists display. XSLT.pm is patched so it defaults to the corresponding *Results.xsl files if none is specified. To test: - Create a list - Open the list in the staff interface - On a new tab, open the list in the OPAC. - Apply this patches === default behaviour - Open the list (both opac and staff) on new tabs => SUCCESS: They look exactly the same (hint: the syspref is set to '' so it should fallback to using the one we were using. === using the new functionality - Create custom XSLTs for lists, for example: $ cd /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/xslt $ cp MARC21slim2OPACResults.xsl MARC21slim2OPACLists.xsl - Edit your sysprefs, setting OPACXSLTListsDisplay to: /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/MARC21slim2OPACLists.xsl - Reload the OPAC list view => SUCCESS: Looks exactly as before - Make some minor tweak (for example in line 423 replace for BLAH - Reload the list => SUCCESS: BLAH shows in several places on the title. - Repeat for the staff interface - Sign off :-D So we can now set custom XSLTs for lists. Sponsored-by: Carnegie Stout Library Signed-off-by: Nick Clemens Signed-off-by: Deb Stephenson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:04:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:04:00 +0000 Subject: [Koha-bugs] [Bug 16720] New: DBIx ActionLogs.pm should be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Bug ID: 16720 Summary: DBIx ActionLogs.pm should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It is just a leftover. The update_dbix_class_files.pl now produces non-plural names, and we have ActionLog.pm in the source tree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:04:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:04:06 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:05:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:05:57 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #251 from Jonathan Druart --- (In reply to Juan Romay Sieira from comment #250) > Thank you Jonathan, the patch in bug 16708 applies correctly and the > authorities reindex fine So go and sign it off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:11:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:11:30 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:11:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:11:33 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 52322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52322&action=edit Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:12:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:12:55 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:06 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:10 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51361|0 |1 is obsolete| | Attachment #51362|0 |1 is obsolete| | Attachment #51363|0 |1 is obsolete| | Attachment #51364|0 |1 is obsolete| | Attachment #51365|0 |1 is obsolete| | Attachment #51366|0 |1 is obsolete| | Attachment #51367|0 |1 is obsolete| | Attachment #51368|0 |1 is obsolete| | Attachment #51369|0 |1 is obsolete| | Attachment #51370|0 |1 is obsolete| | Attachment #51371|0 |1 is obsolete| | --- Comment #107 from Kyle M Hall --- Created attachment 52323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52323&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:20 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #108 from Kyle M Hall --- Created attachment 52324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52324&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:25 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #109 from Kyle M Hall --- Created attachment 52325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52325&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:29 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #110 from Kyle M Hall --- Created attachment 52326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52326&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:33 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #111 from Kyle M Hall --- Created attachment 52327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52327&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:38 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #112 from Kyle M Hall --- Created attachment 52328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52328&action=edit Bug 12598 - Fix merge to master. Backport 3 updates from latest import_borrowers.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:42 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #113 from Kyle M Hall --- Created attachment 52329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52329&action=edit Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes package Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:47 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #114 from Kyle M Hall --- Created attachment 52330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52330&action=edit Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:51 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #115 from Kyle M Hall --- Created attachment 52331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52331&action=edit Bug 12598 - Creating objects in misc/import_patrons.pl and tools/import_borrowers.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:14:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:14:56 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #116 from Kyle M Hall --- Created attachment 52332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52332&action=edit Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical date types and header column parsing Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:15:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:15:21 +0000 Subject: [Koha-bugs] [Bug 16721] New: Serial claims table too wide Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16721 Bug ID: 16721 Summary: Serial claims table too wide Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The serial claims table gets far too wide, especially when new subscription fields are added to it. It should be possible to configure if those display or not, but it also looks like a general problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:15:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:15:24 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #117 from Kyle M Hall --- Created attachment 52333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52333&action=edit Bug 12598 - Rebase + backport of 16426 plus fixing 16426 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:17:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:17:07 +0000 Subject: [Koha-bugs] [Bug 16722] New: Display internal note for late orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16722 Bug ID: 16722 Summary: Display internal note for late orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Libraries use the internal note for multiple purposes. One of these is noting if the vendor has already been contacted about the late order and a possible new shipment date (making more claims useless). It would be very useful if the internal note would display in the late orders table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:09 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use separate memached |Use separate memcached |namespace for caching |namespace for caching |koha-conf.xml |koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:13 +0000 Subject: [Koha-bugs] [Bug 16723] New: Add additional subscription fields to serial claim notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723 Bug ID: 16723 Summary: Add additional subscription fields to serial claim notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if it was possible to output the additional subscription fields in the serial related notices - especially the late issue / claim notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:22 +0000 Subject: [Koha-bugs] [Bug 16723] Add additional subscription fields to serial claim notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 [Bug 10855] Custom fields for subscriptions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:22 +0000 Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723 [Bug 16723] Add additional subscription fields to serial claim notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:23 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 [Bug 6193] Use memcached cache koha-conf.xml configuration variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:23 +0000 Subject: [Koha-bugs] [Bug 6193] Use memcached cache koha-conf.xml configuration variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 [Bug 16579] Use separate memcached namespace for caching koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:28 +0000 Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6193 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 [Bug 6193] Use memcached cache koha-conf.xml configuration variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:21:28 +0000 Subject: [Koha-bugs] [Bug 6193] Use memcached cache koha-conf.xml configuration variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 [Bug 11921] memcached configuration should be moved back to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:35:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:35:06 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:35:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:35:09 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52307|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 52334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52334&action=edit Bug 16715: Proposed followup to use Sereal for serialization This manages to eke out a bit more performance on my machine. Signed-off-by: Jacek Ablewicz Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:36:51 +0000 Subject: [Koha-bugs] [Bug 16724] New: Link from online help to manual broken (as of version 16.05) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Bug ID: 16724 Summary: Link from online help to manual broken (as of version 16.05) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org In Koha version 16.05, the links from the online help to koha manual are broken. To reproduce: In staff client (e.g. About page), click on 'Help' at the top right af the screen. Then click on link 'manual' in "See the full documentation for the About page in the manual (online)." Result: For 16.05: http://manual.koha-community.org/16.4/en/aboutkoha.html The requested URL /16.4/en/aboutkoha.html was not found on this server. For current master (16.06.00.002): http://manual.koha-community.org/16.06/en/aboutkoha.html The requested URL /16.06/en/aboutkoha.html was not found on this server. The correct link should be (for both): The requested URL /16.05/en/aboutkoha.html was not found on this server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:41:38 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #1 from Marc V?ron --- Note: Version number for help files is calculated in help.pl line 68 ff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:42:21 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:44:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:44:24 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- A quick comment to tell that bug 15407 is going to remove GetborCatFromCatType -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:48:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:48:59 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:49:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:49:04 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51770|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 52335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52335&action=edit Bug 16500: Catch two warns in TestBuilder.t with warning_like When testing a wrong case in TestBuilder.t, two warns show up. We can catch them with warning_like. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:49:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:49:42 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52335|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 52336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52336&action=edit Bug 16500: Catch two warns in TestBuilder.t with warning_like When testing a wrong case in TestBuilder.t, two warns show up. We can catch them with warning_like. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:50:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:50:37 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52300|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 52337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52337&action=edit Bug 16500: [QA Follow-up] Catch warning if branch MPL already exists The current test had no warnings, when you have no MPL branch, and only catches the warn from the second build on line 57. If you do have MPL, a warning comes from line 56. This patch fixes it by removing MPL from the test. A new branch is created first and then we try to create it again. Test plan: Run the test. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:51:38 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 18:51:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 16:51:43 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52303|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 52338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52338&action=edit Bug 16607: Remove CPL/MPL from two unit tests Test t/db_dependent/Accounts.t: This test created a MPL branch, but did not use it any more. Test t/db_dependent/Items/AutomaticItemModificationByAge.t: This test still used CPL/MPL branches. Now it uses two new branches. Test plan: [1] Run t/db_dependent/Accounts.t. [2] Run t/db_dependent/Items/AutomaticItemModificationByAge.t. Signed-off-by: Marcel de Rooy Both tests pass OK Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:03:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:03:50 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #2 from Marc V?ron --- Calculation was introduced for 3.14.x ( by Bug 11238 - The version of the manual online link should be dynamically updated ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:04:36 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11238 [Bug 11238] The version of the manual online link should be dynamically updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:04:36 +0000 Subject: [Koha-bugs] [Bug 11238] The version of the manual online link should be dynamically updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11238 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 [Bug 16724] Link from online help to manual broken (as of version 16.05) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:16:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:16:21 +0000 Subject: [Koha-bugs] [Bug 16725] New: Link sent in SHARE_INVITE message yields software error when a private list is shared. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16725 Bug ID: 16725 Summary: Link sent in SHARE_INVITE message yields software error when a private list is shared. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To re-create: Choose two koha accounts -- I'll call them SENDER and RECEIVER. Make sure that RECEIVER has your email address. Make sure that SHARE_INVITE letter is defined for email, and contains the string <> 1/ Log in to the opac as user SENDER 2/ Click on 'your lists' in left menu bar 3/ Create a private list 4/ Click 'edit' 5/ Make sure that permissions for 'anyone else to add entries.', 'anyone to remove their own contributed entries.', 'anyone to remove other contributed entries.' are all set to 'Allow' (I'm not sure that this is necessary, but it's in the steps that I got from the library) 6/ Click 'Save' 7/ Click 'Share' 8/ Add the email address for RECEIVER 9/ Click 'Send' Check your email (if your test environment sends email ) or search message_queue for last entry with your email address. Navigate to the link generated by <> You will get a software error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:20:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:20:42 +0000 Subject: [Koha-bugs] [Bug 16725] Link sent in SHARE_INVITE message yields software error when a private list is shared. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16725 --- Comment #1 from Barton Chittenden --- Notes found during trouble-shooting: borrowernumber is NULL in both message_queue and virtualshelfshares. I suspect that a borrowernumber must be present for private shares, but the link isn't being made between the email provided and the borrower account, but that's just a hunch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:21:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:21:55 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:22:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:22:01 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #3 from Jonathan Druart --- Created attachment 52339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52339&action=edit Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:22:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:22:35 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:32:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:32:36 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 --- Comment #8 from Owen Leonard --- (In reply to Jonathan Druart from comment #6) > For instance I don't think it's important for them to see the link to the > offline circ tools. I agree. If we went forward with this patch I would probably say we ought to leave them out altogether. I don't think this change looks bad, but I'm not sure it's necessary. The most important options (check out, check in, renew, set library) are always available in the header. On the other hand, it is inconsistent that the circulation module doesn't have a sidebar menu. I think the original intention was to keep things like checkout and checkin distraction-free because they are such important tasks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:33:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:33:27 +0000 Subject: [Koha-bugs] [Bug 16725] Link sent in SHARE_INVITE message yields software error when a private list is shared. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16725 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:40:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:40:03 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #4 from Mirko Tietgen --- Created attachment 52340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52340&action=edit Bug 16724 - Link from online help to manual broken (as of version 16.05) To test: - apply patch - load some page in staff client, open help, check the link to the manual for 16.05, it should include 16.05 for master, it should include 16.05 for versions < 16, it should still work as before This will work for xx.05 and xx.11 releases. If we will have xx.04 or xx.06 at some point, it has to be adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:41:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:41:54 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- The script accepts negative numbers, is it expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:44:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:44:22 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Attachment #52340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:45:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:45:53 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52339|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 52341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52341&action=edit Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:46:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:46:05 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:46:23 +0000 Subject: [Koha-bugs] [Bug 16726] New: Text in Preferences search box does not clear Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Bug ID: 16726 Summary: Text in Preferences search box does not clear Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: arm at hanover.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When in Administration - Preferences, using search box. Enter search term, hit enter or click button to search. After search completes, the search box still shows the search text. Once a search is done, the search box should clear as it does for checkout, catalogue, patron searches etc. (Note that this is more annoying now that the search text also persists when switching to a different tab, like from Preferences to Checkout.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 19:56:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 17:56:14 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart --- QA comments: 1/ Prefer mock_preference to C4::Context->set_preference 2/ "my" variable $yaml masks earlier declaration in same scope at C4/Circulation.pm line 1968. 3/ Fix some the indendation in JS code I have not tested it already, but please fix that first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:01:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:01:02 +0000 Subject: [Koha-bugs] [Bug 16727] New: Upload tool needs better warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Bug ID: 16727 Summary: Upload tool needs better warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org If you don't have an UPLOAD authorized value category set the upload tool says "Note: No upload categories have been defined. All uploads will be marked as temporary." But doesn't say that you have to create an authorized value. The error should be clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:20:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:20:15 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #6 from Marc V?ron --- It displays OK with 16.05 and 16.06, but what about future versions? E.g. 16.07, 16.08 (will result in a link to http://manual.koha-community.org/16.07/en/ ) and 16.09, 16.10 (will result in a link to http://manual.koha-community.org/16.09/en/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:22:02 +0000 Subject: [Koha-bugs] [Bug 16724] Link from online help to manual broken (as of version 16.05) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- The numbers for stable should always be .05 and .11 (may and november) currently - so that might work ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:27:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:27:20 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 --- Comment #4 from Kyle M Hall --- Created attachment 52342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52342&action=edit Bug 16672 [QA Followup] - Convert negative days to positive days -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:28:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:28:53 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #3) > The script accepts negative numbers, is it expected? That seems like inadvisable behavior. I can't imagine needing to automatically delete holidays in the future! I can imagine the thought process of thinking about days in the past as a negative number. I've added a following that simply makes it so a days of 20 or -20 would both remove holidays older than 20 days in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:31:21 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Kyle M Hall --- I think bug 11921 is a far more sane solution than this. Far fewer moving parts, less prone to regressions. Setting this to WONTFIX for the time being. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:31:50 +0000 Subject: [Koha-bugs] [Bug 16728] New: Display Issued with entry (MARC21 777) to staff and OPAC normal view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16728 Bug ID: 16728 Summary: Display Issued with entry (MARC21 777) to staff and OPAC normal view Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: eb at efdss.org QA Contact: testopia at bugs.koha-community.org The 777 field is not one of the fields currently displayed in staff or OPAC normal view. It is visible in the MARC view, but this does not enable the link (via subfield w) to the related record. The subfields are identical to 773 (which does display in the normal view). The main difference being the automatic text generated by the indicators. http://www.loc.gov/marc/bibliographic/concise/bd777.html This is a very important field for music libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:33:32 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Kyle M Hall --- All the unit tests pass for me. Are you running them on a stock sample database? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:34:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:34:49 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #1 from Elaine Bradtke --- Just adding a +1 this is an important field for sound recording libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:38:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:38:30 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 20:57:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 18:57:35 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #22 from Nicole C. Engard --- Can someone address the qa issues here, this is a big deal to some of our libraries? Nicoel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 21:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 19:04:29 +0000 Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 21:10:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 19:10:34 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 21:47:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 19:47:38 +0000 Subject: [Koha-bugs] [Bug 16729] New: The street number missing when printing user summary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Bug ID: 16729 Summary: The street number missing when printing user summary Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mehdi.hamidi at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When printing a user summary, the street number is not showing up. The template used for the printing(moremember-print.tt) only shows the address, instead of street number + address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 21:48:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 19:48:37 +0000 Subject: [Koha-bugs] [Bug 16729] The street number missing when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 21:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 19:50:35 +0000 Subject: [Koha-bugs] [Bug 16729] The street number missing when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 21:54:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 19:54:54 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 13 23:34:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 21:34:51 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |c.gravely at arts.ac.uk |ity.org | CC| |c.gravely at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 00:38:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 22:38:50 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 00:38:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 22:38:53 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 --- Comment #1 from Claire Gravely --- Created attachment 52343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52343&action=edit Bug 15929 - typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck There's a typo in the explanation for the new MaxSearchResultsItemsPerRecordStatusCheck sys pref that was added in 3.22.2. "If a record has more than this number of items, they availability statuses ..." I have re-worded the description so it reads a bit better. Test plan: 1. Check the description for syspref MaxSearchResultsItemsPerRecordStatusCheck. 2. Apply patch 3. Check syspref MaxSearchResultsItemsPerRecordStatusCheck description to make sure it makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 00:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 22:41:21 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 00:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 22:41:24 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52343|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 52344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52344&action=edit Bug 15929 - typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck There's a typo in the explanation for the new MaxSearchResultsItemsPerRecordStatusCheck sys pref that was added in 3.22.2. "If a record has more than this number of items, they availability statuses ..." I have re-worded the description so it reads a bit better. Test plan: 1. Check the description for syspref MaxSearchResultsItemsPerRecordStatusCheck. 2. Apply patch 3. Check syspref MaxSearchResultsItemsPerRecordStatusCheck description to make sure it makes sense. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 01:24:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 23:24:28 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Liz Rea --- library-koha at wingardium-leviosa:~/koha-src/koha$ prove t/db_dependent/Serials.t t/db_dependent/Serials.t .. 1/49 "my" variable @serialsByStatus masks earlier declaration in same scope at t/db_dependent/Serials.t line 256. t/db_dependent/Serials.t .. 2/49 No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. t/db_dependent/Serials.t .. ok All tests successful. Files=1, Tests=49, 3 wallclock secs ( 0.02 usr 0.00 sys + 0.99 cusr 0.05 csys = 1.06 CPU) Result: PASS These tests look like they are passing to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 01:25:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jun 2016 23:25:22 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #24 from Liz Rea --- Oops I meant to do that with -v: library-koha at wingardium-leviosa:~/koha-src/koha$ prove -v t/db_dependent/Serials.t t/db_dependent/Serials.t .. 1..49 ok 1 - use C4::Serials; "my" variable @serialsByStatus masks earlier declaration in same scope at t/db_dependent/Serials.t line 256. ok 2 - NewSubscription should set notes ok 3 - NewSubscription should set internalnotes ok 4 - NewSubscription should not set subscriptionhistory opacnotes ok 5 - NewSubscription should not set subscriptionhistory librariannotes ok 6 - A reference of type 'ARRAY' isa 'ARRAY' ok 7 - A reference of type 'ARRAY' isa 'ARRAY' ok 8 - A reference of type 'ARRAY' isa 'ARRAY' ok 9 - A reference of type 'ARRAY' isa 'ARRAY' ok 10 - expiration date is not NULL ok 11 - test getting history from sub-scription ok 12 - Subscription has at least one serial ok 13 - test getting Serial Status From Serial Id ok 14 - 'test getting Serial Information' isa 'HASH' ok 15 - test adding item to serial ok 16 - test updating claim date ok 17 - test getting full subscription ok 18 - test preparing serial data ok 19 - test getting subscriptions form biblio number ok 20 - test getting serials when you enter nothing ok 21 - test getting serials when you enter nothing ok 22 - test getting lastest serials ok 23 - test getting distributed when nothing is entered ok 24 - test getting next seq when you enter nothing ok 25 - test getting seq when you enter nothing ok 26 - test counting subscription when nothing is entered ok 27 - test modding subscription history ok 28 - test modding serials ok 29 - test finding serial by status with no parameters ok 30 - test getting 0 when nothing is entered ok 31 - test if the subscriptions has expired ok 32 - test if the subscriptions has expired ok 33 - test getting last or missing issues ok 34 - test updating claim ok 35 - test getting supplier idea ok 36 - test checking route ok 37 - test adding route member ok 38 - NewSubscription created a first serial ok 39 - GetSerials returns the serial No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. No method update! at /home/liz/koha-src/koha/C4/Serials.pm line 1603. ok 40 - findSerialByStatus returns all serials with chosen status ok 41 - GetSerials returns total_issues ok 42 - GetSerials returns 5 arrived/missing by default ok 43 - GetSerials returns all serials not arrived and not missing ok 44 - GetSerials returns total_issues ok 45 - GetSerials returns all arrived/missing if count given ok 46 - GetSerials returns all serials not arrived and not missing if count given ok 47 - subscription missinglist is updated after ModSerialStatus ok 48 - ModSerialStatus delete corectly serial expected and create another if not exist ok 49 - ModSerialStatus delete corectly serial expected and not create another if exist ok All tests successful. Files=1, Tests=49, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.98 cusr 0.06 csys = 1.06 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 02:02:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 00:02:50 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 --- Comment #4 from Srdjan Jankovic --- Ok, I can either drop that one now or wait for 15407 to be merged. The thing is anyone installing on a newer version of MySql may find this a quick fix. What about the authorised values? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 03:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 01:57:21 +0000 Subject: [Koha-bugs] [Bug 16702] Notice Triggers Issue: Delivery Mechanism Options Not Saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16702 Craig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Craig --- This was the result of a corrupted SQL schema. Perhaps from incorrectly upgrading from 3.22 to 16.05 by restoring an sql dump from 3.22 into 16.05. I haven't been able to reproduce the transport option save failure on a fresh install of 16.05. Everything looks good here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 06:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 04:11:19 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 06:11:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 04:11:21 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52322|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 52345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52345&action=edit [SIGNED-OFF] Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 06:19:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 04:19:44 +0000 Subject: [Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52184|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 52346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52346&action=edit [SIGNED-OFF] Bug 16693: Remove reserve/renewscript.pl It is not used since bug 11703 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 06:20:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 04:20:42 +0000 Subject: [Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 07:18:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 05:18:53 +0000 Subject: [Koha-bugs] [Bug 16729] The street number missing when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 07:19:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 05:19:02 +0000 Subject: [Koha-bugs] [Bug 16718] Translatability: Fix problems with sentence splitting by in about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16718 --- Comment #3 from Marc V?ron --- Created attachment 52347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52347&action=edit Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 07:21:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 05:21:12 +0000 Subject: [Koha-bugs] [Bug 16729] The street number missing when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 --- Comment #1 from Marc V?ron --- Created attachment 52348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52348&action=edit Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate https://bugs.koha-community.org/show_bug.cgi?id=16718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 07:22:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 05:22:43 +0000 Subject: [Koha-bugs] [Bug 16729] The street number missing when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52348|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 52349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52349&action=edit Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 07:24:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 05:24:07 +0000 Subject: [Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Summary|The street number missing |Use |when printing user summary |member-display-address-styl | |e*-includes when printing | |user summary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 08:42:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 06:42:37 +0000 Subject: [Koha-bugs] [Bug 16730] New: Use member-display-address-style*-includes in moremember-brief.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730 Bug ID: 16730 Summary: Use member-display-address-style*-includes in moremember-brief.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Creating new patron with the same first and last name as an existing patron triggers a duplicate warning message with the possibility to display a pop-up window with a patron detail brief view (moremember-brief.tt). Address formatting in this window should use syspref 'AddressFormat' to display the address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 08:49:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 06:49:05 +0000 Subject: [Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 08:49:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 06:49:51 +0000 Subject: [Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730 --- Comment #1 from Marc V?ron --- Created attachment 52350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52350&action=edit Bug 16730 - Use member-display-address-style*-includes in moremember-brief.tt To test: - Apply patch - Create a new patron with the same first and last name as an existing patron. This should trigger a duplicate warning message. Click the "View existing record" link to trigger a pop-up window with a patron detail brief view. - Verify that the address information displays the same way as on the patron details screen (moremember.pl). - Change syspref 'AddressFormat' and verify that the address displays as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 08:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 06:50:35 +0000 Subject: [Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 09:17:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 07:17:05 +0000 Subject: [Koha-bugs] [Bug 16728] Display Issued with entry (MARC21 777) to staff and OPAC normal view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16728 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 10:32:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 08:32:25 +0000 Subject: [Koha-bugs] [Bug 10760] Street Number field is missing from the Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 10:33:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 08:33:50 +0000 Subject: [Koha-bugs] [Bug 10760] Street Number field is missing from the Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 --- Comment #2 from Marc V?ron --- Created attachment 52351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52351&action=edit Bug 10760: Alternate Address: Make street number and street type editable Table 'borrowers' contain columns B_streetnumber and B_streettype. This patch makes them editable for alternate address. To test: - Apply patch - Edit a patron's details - Verify that in edit mode for Alternate address, the fields 'street type' and 'street number' appear and follow the settings in sysprefs AddressFormat, BorrowerMandatoryField, BorrowerUnwantedField - Verify that the values are saved correctly. Note: A second patch will follow to manage the display of street number and street type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 10:34:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 08:34:22 +0000 Subject: [Koha-bugs] [Bug 10760] Street Number field is missing from the Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:07:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:07:21 +0000 Subject: [Koha-bugs] [Bug 10760] Street Number field is missing from the Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 --- Comment #3 from Marc V?ron --- Created attachment 52352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52352&action=edit Bug 10760: Alternate Address: Display street number and street type This patch displays alternate streetnumber and street type on patron's detail page. To test: - Apply patch - Verify that the alternate address information displays follwing the setting in syspref AddressFormat and contains street type and street number (as appropriate) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:08:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:08:50 +0000 Subject: [Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Street Number field is |Use Street Number and |missing from the Alternate |Street type in Alternate |Address section |Address section Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:10:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:10:05 +0000 Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email already filled in borrowers.email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:10:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:10:11 +0000 Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email already filled in borrowers.email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:11:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:11:35 +0000 Subject: [Koha-bugs] [Bug 3765] Road Types and Street Numbers on Patron Rec Inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3765 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:16:42 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:16:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:16:45 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52081|0 |1 is obsolete| | Attachment #52342|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 52353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52353&action=edit Bug 16672 - Add ability to remove expired holidays from special_holidays It would be very helpful if the cleanup_database.pl script had the ability to delete holidays from the special_holidays table there were older than a given number of days in the past. Test Plan: 1) Apply this patch 2) Create some unique holidays in the past of varying ages 3) Test the new switch '--unique-holidays DAYS' for cleanup_database.pl 4) Verify only holidays older then the specified number of days are removed NOTE: The language 'unique holdays' is used in the interface to match it's use in the staff web interface. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:17:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:17:06 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 --- Comment #7 from Jonathan Druart --- Created attachment 52354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52354&action=edit Bug 16672 [QA Followup] - Convert negative days to positive days Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:17:13 +0000 Subject: [Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672 --- Comment #8 from Jonathan Druart --- Created attachment 52355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52355&action=edit Bug 16672: Fix typo unqiue vs unique Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:31:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:31:16 +0000 Subject: [Koha-bugs] [Bug 16280] purge_suggestions.pl: Cron job log should tell number of days used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #2 from Marc V?ron --- Is blocked by Bug 13287 (Failed QA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:53:32 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:53:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:53:36 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47775|0 |1 is obsolete| | Attachment #47776|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 52356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52356&action=edit Bug 12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:53:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:53:42 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #26 from Jonathan Druart --- Created attachment 52357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52357&action=edit Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus https://bugs.koha-community.org/show_bug.cgi?id=12478 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:53:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:53:47 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #27 from Jonathan Druart --- Created attachment 52358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52358&action=edit Bug 12748: Remove warning 'masks earlier declaration in same scope' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:53:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:53:52 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #28 from Jonathan Druart --- Created attachment 52359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52359&action=edit Bug 12748: Code tidy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 11:53:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 09:53:56 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #29 from Jonathan Druart --- Created attachment 52360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52360&action=edit Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:11:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:11:04 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:11:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:11:08 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52251|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 52361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52361&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module. Also correct a error dialog in JQuery functions To test: -Apply patch -Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all. -Add new patron list and add some patrons, notice about the trash icon. -Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove. -Set syspref TagsModeration to Require. This will show all pending tags to review. -Make some tags in bib records and goto Tools -> Tags. -Notice about the new look. -In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending. -Play with filters; Check if terms exist or not in appoved/rejected lists -Play with Terms summary and see if DataTable is working as expected -Click in some term tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tag from a selected title. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 Test plan amended for clarity Clock icon for "Select all pending" removed (QA comment 23). Fix some forbidden patterns (tab char) in review.tt according by IRC comment by Marc Veron Followed test plan, looks and works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:11:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:11:13 +0000 Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #35 from Jonathan Druart --- Created attachment 52362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52362&action=edit Bug 16456: Reintroduce wording "Delete tag" "Delete tag" seems more appropriate than "Delete" on this tag, but I may be wrong. This patch also removes an extra space. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:13:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:13:49 +0000 Subject: [Koha-bugs] [Bug 7565] Fee/fines receipt for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7565 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Hi, had you worked on this on the last version of koha ? I'm especially interested by the question of automatic numbering for receipt given to borrowers. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:20:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:20:43 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:20:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:20:47 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52304|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 52363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52363&action=edit Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy Test passes OK Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:20:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:20:51 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 --- Comment #4 from Jonathan Druart --- Created attachment 52364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52364&action=edit Bug 16717: Improve variable naming $category was a categorycode, to help the readability it's better to name it $categorycode or assign a Category to $category Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:27:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:27:16 +0000 Subject: [Koha-bugs] [Bug 15485] Allow choosing different XSLTs for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 --- Comment #7 from Jonathan Druart --- Comment on attachment 52321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52321 Bug 15485: Use lists-specific XSLT sysprefs Review of attachment 52321: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15485&attachment=52321) ----------------------------------------------------------------- ::: opac/opac-shelves.pl @@ +248,4 @@ > > my $borrower = GetMember( borrowernumber => $loggedinuser ); > > + my $xslfile = C4::Context->preference('OPACXSLTListsDisplay'); it seems that || 'default' is missing here, could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:32:08 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com Version|3.22 |unspecified Depends on| |13022 --- Comment #3 from Jonathan Druart --- Letting this one to Kyle as he is the author of the description. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:32:08 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:32:16 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #20 from Nick Clemens --- Created attachment 52365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52365&action=edit Bug 14576 (QA Folllowup) Address issues use mock for tests use a separate variable for yaml fix indentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:32:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:32:13 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:33:17 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #31 from Jonathan Druart --- @RM: the DB entry 3.23.00.012 refers to "Bug 15380 - Move the authority types related code to Koha::Authority::Type[s] - part 1", please correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:36:27 +0000 Subject: [Koha-bugs] [Bug 16731] New: Use INSERT IGNORE when inserting a syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731 Bug ID: 16731 Summary: Use INSERT IGNORE when inserting a syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:38:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:38:43 +0000 Subject: [Koha-bugs] [Bug 16731] Use INSERT IGNORE when inserting a syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:38:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:38:46 +0000 Subject: [Koha-bugs] [Bug 16731] Use INSERT IGNORE when inserting a syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16731 --- Comment #1 from Jonathan Druart --- Created attachment 52366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52366&action=edit Bug 16731: Use INSERT IGNORE when inserting a syspref IGNORE should be used to allow backporting (and local patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 12:48:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 10:48:07 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #2 from Lari Taskula --- Thanks for the interest! Unfortunately, I am having some issues with this approach. The specifications won't validate through Swagger-UI validator (online.swagger.io/validator/debug?url=url_to_your_swagger.json). I read a little about the issue, and to my understanding the structure I described above does not seem to meet Swagger2 specification. It seems that the Paths Object does not take a $ref, but Path Item Object, which can take a $ref. This means that we would not meet the Swagger2 specification if we attempted something like this in swagger.json: .. "paths": { "$ref": "paths/index.json" }, .. In fact the same error happens when running the current master version (the definitions/index.json in Bug 15126) against online.swagger.io-validator. This is the error message I get with the online.swagger.io-validator: {"messages":["attribute definitions.$ref is not of type `object`"],"schemaValidationMessages":[{"level":"error","domain":"validation","keyword":"type","message":"instance type (string) does not match any allowed primitive type (allowed: [\"object\"])","schema":{"loadingURI":"http://swagger.io/v2/schema.json#","pointer":"/definitions/schema"},"instance":{"pointer":"/definitions/$ref"}}]} An option would be to keep the proposed structure for development, and use the minifySwagger.pl-script (Bug 16212) to have a valid Swagger specification in the minified swagger.min.json. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 13:54:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 11:54:55 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #63 from Kyle M Hall --- > I agree. It is confusing to have two menu items on the administration page, > "Libraries and groups" and "Library groups." I think we should think of a > way to manage all this functionality in one section. These two sub-systems are completely unrelated. They really don't belong together. I'd be more than happy to rename it "Library hierarchies" if you find that acceptable, or to rename the existing groups to "search groups" which is what they are. > Some other comments: > > - Nowhere else do we use the "fa-plus-circle" icon for "add." We always use > "fa-plus." Changed with followup. > > - Nowhere else in Koha do we use a modal to display an add form. We either > display a form on a separate page or we use JS to show/hide the edit form on > the page to mimic the display of a separate page. See > admin/items_search_fields.pl for example. You are correct, but I believe the modal may be a better paradigm. Would you disagree? It means we aren't shifting elements on the page around when we hide/display a form. I know it's without precedent at the moment but I'd like you to consider the advantages. Think about how every other site does this stuff. It's typically with modals. Koha is generally working against the standard web ux by *not* using modals! Would you agree? > > - Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always > use "fa-pencil." Changed with followup! > > - When displaying confirmation messages we use '
    ' not '
    ' Can do! > > - There is no reason to display an icon ("") next to each group. It doesn't serve any function. Changed in followup! > > - There is no reason to display an icon ("") next > to each library in a group. It doesn't serve any function. Changed in followup! > > - Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It > should be "fa-trash." Fixed in followup! > > - Nowhere else in Koha do we add an icon to the "actions" menu. Will do! > - Nowhere else in Koha do we use a modal to display a delete confirmation > message. I think I could be convinced that we should, but I'd like to hear > the argument. If we do, we should use the space given to display more > information about the deletion than this implementation does, e.g. what > exactly am I deleting? We use plenty of js confirm dialogs for delete confirmation messages. Over the years they've gotten more and more jarring in my opinion. They cannot be styled to match the look of Koha. Even more importantly, we tend to abuse confirm dialogs by adding far to much text to them which we attempt to lay out with only spaces and newlines. With the modal this is a non-issue because we can simply use html. The modal seems much more natural and integrated, while presenting the exact same options to the user. > > - Instead of a "home" icon for "Add library" I think it should be the "plus" > icon which is associated with adding or creating something. Fixed! > > - The list of libraries in the "Add library" dropdown should be alphabetized > by library name, not library code. Fixed! > - This patch adds five new instances of "onclick." I've been working very > hard to eliminate the use of "onclick" and I don't think new patches should > add them. Fixed! I wrote this patch before the move away from onclick and I'm happy to see them go ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 13:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 11:55:38 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 13:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 11:55:41 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #64 from Kyle M Hall --- Created attachment 52367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52367&action=edit Bug 15707 [QA Followup] - Fix UI issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 14:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 12:48:03 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #3 from Lari Taskula --- Created attachment 52368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52368&action=edit Bug 16212: Move from misc/devel to api/v1 Move minifySwagger.pl from misc/devel to api/v1 since it is directly related to swagger.json and the usage is simplified when it is in the same location with swagger.json. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 14:51:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 12:51:56 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit at student.uef.fi --- Comment #4 from Lari Taskula --- If the change above is OK, I think also all Swagger-related stuff could be in api/v1/swagger. I'm working on Bug 16699 so maybe this can be done there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 14:52:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 12:52:41 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 14:52:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 12:52:41 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 14:55:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 12:55:30 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #65 from Owen Leonard --- (In reply to Kyle M Hall from comment #63) > These two sub-systems are completely unrelated. They really don't belong > together. If this is a feature without any real application in Koha yet, perhaps we shouldn't add it to the menu system at all? > > - Nowhere else in Koha do we use a modal to display an add form. > > You are correct, but I believe the modal may be a better paradigm. Perhaps. However, I think introducing a new interface pattern requires a certain amount of commitment to making that change consistently throughout the interface. For example, using jEditable for the Quote of the Day feature was an interesting proof of concept, but it went nowhere after that. Introducing the use of Font Awesome was a good improvement, but it took a lot of buy-in and work to make it consistent. > > - Nowhere else in Koha do we use a modal to display a delete confirmation > > message. > > The modal seems much more natural and > integrated, while presenting the exact same options to the user. I think that's fine, especially if we take advantage of the opportunity to display thorough information to the user. As I said above, I think making the change requires /some/ commitment to implementing the same change throughout the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:01:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:01:03 +0000 Subject: [Koha-bugs] [Bug 16732] New: Add audio alerts (custom sound notifications) to web based self checkout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Bug ID: 16732 Summary: Add audio alerts (custom sound notifications) to web based self checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Work to be done: * Create new audio alert entries for self check out in the administration area * Have sounds be accessible via the self check * Play sounds at appropriate times in the self check interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:01:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:01:24 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:11:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:11:17 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Owen Leonard --- > I've removed the > patch that adds the treegrid library and have added a follow switching to > treetables. Treegrid is still getting added to the about page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:15:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:15:31 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #67 from Kyle M Hall --- (In reply to Owen Leonard from comment #65) > (In reply to Kyle M Hall from comment #63) > > > These two sub-systems are completely unrelated. They really don't belong > > together. > > If this is a feature without any real application in Koha yet, perhaps we > shouldn't add it to the menu system at all? I don't expect this patch set to be pushed to master until Bug 15708 is ready to be pushed along with it. I would like to get this to Passed QA in the meantime. > > > > - Nowhere else in Koha do we use a modal to display an add form. > > > > You are correct, but I believe the modal may be a better paradigm. > > Perhaps. However, I think introducing a new interface pattern requires a > certain amount of commitment to making that change consistently throughout > the interface. For example, using jEditable for the Quote of the Day feature > was an interesting proof of concept, but it went nowhere after that. > Introducing the use of Font Awesome was a good improvement, but it took a > lot of buy-in and work to make it consistent. I agree. I'm willing to put in some work if you can identify some areas where you'd like to see modals. I think the low-hanging fruit would be any of the hide/show forms we have. The audio alerts editor is the first one that comes to mind, but I'm sure you can point out some others! > > > > - Nowhere else in Koha do we use a modal to display a delete confirmation > > > message. > > > > The modal seems much more natural and > > integrated, while presenting the exact same options to the user. > > I think that's fine, especially if we take advantage of the opportunity to > display thorough information to the user. As I said above, I think making > the change requires /some/ commitment to implementing the same change > throughout the staff client. Agreed, this latest followup takes advantage of that a bit be showing the group to be deleted in one case, in the case of removing a library from a group it shows the library name and the group it will be removed from with some minor styling. Nothing amazing but definitely easier on the eyes and no unnecessary use of quotes around the names of things because the confirm dialogs are only plaintext. If you think my styling could be improved just let me know! Basically it's just styled with the group and library names italicized and bold. I think we need a standard pattern for how to style the names of things in this fashion, and I see no reason not to start here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:18:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:18:58 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #5 from Lari Taskula --- Created attachment 52369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52369&action=edit Bug 16212: Use swagger.min.json insted of swagger.json Our current approach with splitting the Swagger specification brings problems. For example, in swagger.json, if we split the whole "definitions" object with $ref, validations will fail with online.swagger.io validator. (See http://online.swagger.io/validator/debug?url=url_to_your_swagger_json) The problem also occurs with "paths" (Paths Object), because simply $ref to all paths for example in /paths/index.json does not meet the Swagger2 specification. The problem is solved by using the minification script and the minified version of swagger.json after which the swagger.min.json is valid Swagger2 specification, because the minifier resolves the problematic $refs of swagger.json file in the minified version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:22:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:22:17 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:22:20 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #68 from Kyle M Hall --- Created attachment 52370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52370&action=edit Bug 15707 [QA Followup] - Remove class for treegrid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:24:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:24:36 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #69 from Owen Leonard --- (In reply to Kyle M Hall from comment #63) > > I agree. It is confusing to have two menu items on the administration page, > > "Libraries and groups" and "Library groups." I think we should think of a > > way to manage all this functionality in one section. > > These two sub-systems are completely unrelated. Do you not plan to replace the existing library groups functionality with this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:40:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:40:36 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 --- Comment #9 from Jacek Ablewicz --- To make things a bit more complicated, this separate cache is used not just for caching koha config in C4/Context; e.g. in C4/Languages.pm: if (C4::Context->ismemcached) { require Memoize::Memcached; import Memoize::Memcached qw(memoize_memcached); memoize_memcached('getTranslatedLanguages', memcached => memcached => C4::Context->memcached); memoize_memcached('getFrameworkLanguages', memcached => memcached => C4::Context->memcached); memoize_memcached('getAllLanguages', memcached => memcached => C4::Context->memcached); } Looks like an excellent material for a bunch of the brand new '... is not plack safe' bug reports ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:54:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:54:16 +0000 Subject: [Koha-bugs] [Bug 16710] Hide overflow of long words in lefthand navigation (e.g. "=?UTF-8?Q?Anschaffungsvorschl=C3=A4ge?=") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16710 --- Comment #1 from Owen Leonard --- I thought CSS hyphenation would be a good solution for this, but it turns out Chrome hasn't implemented it yet. Strange that it's so behind IE and Firefox on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:58:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:58:32 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 15:58:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 13:58:35 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 --- Comment #1 from Owen Leonard --- Created attachment 52371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52371&action=edit Bug 16640 - Move actions on acquisitions receipt summary page into menu This patch moves two groups of links into two menus: MARC and Card preview into one, Receive, transfer, cancel, etc. into another. Also changed: The transfer order pop-up window has been sized down to be more consistent with other similar pop-ups. Baskets and basket group links now include the whole name rather than just the number to make it easier to click. To test you must have a basket or baskets with multiple titles on order, both received and pending. - Apply the patch and go to Acquisitions -> Vendor -> Receive shipment -> Receive a new shipment (or open an existing invoice). - In the list of pending orders: - Test the 'View' menu for multiple titles. The 'MARC' and 'Card' menu items should work correctly. - Test the 'Actions' menu for the following actions: - Receive - Transfer - Cancel order - Cancel order and delete catalog record - Confirm that under some circumstances the 'Cancel order' and 'Cancel order and delete catalog record' items are disabled. In these cases hovering over the menu items should trigger a tooltip. An explanation should be displayed in red at the bottom of the menu. Clicking the menu item should trigger an alert with the explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:16:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:16:41 +0000 Subject: [Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:16:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:16:44 +0000 Subject: [Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52349|0 |1 is obsolete| | --- Comment #3 from Mehdi Hamidi --- Created attachment 52372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52372&action=edit Bug 16729: Use member-display-address-style*-includes when printing user summary This patch replaces the address part in moremember-print.tt to print identical address information as displayed on the screen (including street numer, formatted as required by syspref 'AddressFormat' To test: - Apply patch - Search for a user with all address information filled - Verify that 'Print summmary' displays the same information as displayed on the screen. - Change value of syspref 'AdressFormat' - Verify that address format on 'Print summary' changes as appropriate Signed-off-by: mehdi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:18:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:18:18 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:18:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:18:18 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15707 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:19:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:19:13 +0000 Subject: [Koha-bugs] [Bug 16733] New: Adjust or make flexible some paths in debian scripts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Bug ID: 16733 Summary: Adjust or make flexible some paths in debian scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:19:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:19:25 +0000 Subject: [Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:20:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:20:48 +0000 Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15707 CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- I suspect that bug 15707 is a step towards fixing independent branch permissions for consortia. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:20:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:20:48 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12599 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:30:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:30:35 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:30:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:30:37 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #9 from Owen Leonard --- Created attachment 52373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52373&action=edit Bug 16148 [Follow-up] Revised layout and behavior of marc modification template management This follow-up corrects a JavaScript error by using jQuery, which is is more forgiving when selecting elements which may not exist on the page. Also changed: Corrected a duplicate class attribute and fixed a jshint error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:31:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:31:49 +0000 Subject: [Koha-bugs] [Bug 16734] New: getLanguages() in opac-search.pl should be called only if needed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Bug ID: 16734 Summary: getLanguages() in opac-search.pl should be called only if needed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org There is no need to always call getLanguages() in opac/opac-search.pl (especially not if it's an actual search), it's output is used only in opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type eq 'advsearch' )' block. Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too busy, and the results are already in query cache), but it eliminates a lot of small DBI calls, making a further profiling of OPAC searches a bit easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:37:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:37:53 +0000 Subject: [Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:37:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:37:56 +0000 Subject: [Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 --- Comment #1 from Jacek Ablewicz --- Created attachment 52374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52374&action=edit Bug 16734: getLanguages() in opac-search.pl should be called only if needed There is no need to always call getLanguages() in opac/opac-search.pl (especially not if it's an actual search), it's output is used only in opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type eq 'advsearch' )' block. Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too busy, and the results are already in query cache), but it eliminates a lot of small DBI calls, making a further profiling of OPAC searches a bit easier. Test plan: just ensure that language selection is still available on OPAC advanced search page, and that it still works like intended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:40:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:40:50 +0000 Subject: [Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:40:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:40:50 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 [Bug 16734] getLanguages() in opac-search.pl should be called only if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:43:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:43:17 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:43:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:43:17 +0000 Subject: [Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12017 Assignee|gmcharlt at gmail.com |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:51:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:51:46 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #70 from Jonathan Druart --- The discussion about the modal should be brought at the next dev meeting I think: Is everybody (i.e. the majority) agrees on this change, who is going to implement it to the other pages, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:54:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:54:15 +0000 Subject: [Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:54:25 +0000 Subject: [Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:57:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:57:52 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #71 from Kyle M Hall --- (In reply to Owen Leonard from comment #69) > (In reply to Kyle M Hall from comment #63) > > > I agree. It is confusing to have two menu items on the administration page, > > > "Libraries and groups" and "Library groups." I think we should think of a > > > way to manage all this functionality in one section. > > > > These two sub-systems are completely unrelated. > > Do you not plan to replace the existing library groups functionality with > this? I had not thought about it, but it would make a log of sense! That should definitely be a separate bug to limit scope creep, but I think it's an excellent idea. After that we could do away with the existing groups functionality altogether. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 16:59:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 14:59:13 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 --- Comment #3 from Tom?s Cohen Arazi --- Just for the record, I confirmed this is the only schema file in this situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:01:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:01:28 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #3 from Lari Taskula --- Created attachment 52375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52375&action=edit Bug 16699: Split parameters and paths in Swagger Parameters and paths should be split in our Swagger specification, because otherwise swagger.json would become messy with all the paths and their further specification in the same file. Also parameters should be split for the same reason. Instead of using index.json for definitions, parameters and paths, we define new files "definitions.json", "parameters.json" and "paths.json" in order to simplify the references. If we kept using index.json and try to reference "/definitions/error.json" from "/paths/holds.json", reference would be "../definitions/index.json#/error" instead of now simplified version, "../definitions.json#/error". Here is the proposed structure: . ??? swagger.json ??? definitions.json ??? paths.json ??? parameters.json ??? definitions ? ??? error.json ? ??? patron.json ??? parameters ? ??? patron.json ??? paths ? ??? patrons.json ??? minifySwagger.pl ??? swagger.min.js The swagger.json paths, definitions and parameters will look as follows: ... "paths": { "$ref": "paths.json" }, "definitions": { "$ref": "definitions.json" }, "parameters": { "$ref": "parameters.json" } ... A problem with splitting specification into multiple files directly from swagger.json (e.g. "paths": { "$ref": "paths.json" }) is that it is not following the Swagger specification and an error will be thrown by the Swagger-UI default validator (online.swagger.io/validator). To overcome this problem, we use the minifySwagger.pl script from Bug 16212. This allows the developers to work with the structure introduced in this patch thus allowing developers to split the specification nicely, and still have a valid Swagger specification in the minified swagger.min.json. To test: -2: Apply the minifier-patch in Bug 16212. -1: Make sure you can validate your specification with Swagger2 validator at online.swagger.io/validator/debug?url=url_to_swaggerjson, or install it locally from https://github.com/swagger-api/validator-badge. 1. Don't apply this patch yet, but first validate swagger.json with swagger.io-validator (or your local version, if you installed it) 2. Observe that validation errors are given 3. Run minifySwagger.pl 4. Validate swagger.min.json with the validator you used in step 1 5. Observe that validation passes and we overcame the invalid specification problem in swagger.min.json 6. Apply this patch 7. Run minifySwagger.pl 8. Repeat step 4 9. Observe that validation passes with new structure 10. Run REST tests at t/db_dependents/api/v1 (11. Study the new structure of our Swagger specifications :)) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:01:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:01:53 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #4 from Lari Taskula --- Created attachment 52376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52376&action=edit Bug 16699: Add borrowernumberQueryParam for reusability The borrowernumber as a query parameter should be defined in parameters.json in order to allow its reusability. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate swagger.min.json in online.swagger.io/validator/debug?url=url_to+ _your_swagger_min_json or your local swagger-api/validator-badge validator 4. Observe that validation passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:02:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:02:13 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #5 from Lari Taskula --- Created attachment 52377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52377&action=edit Bug 16699: Fix mixed-up indentation from 2-4 spaces to 2 spaces These definitions had indentation of 4 spaces, while rest of the specification uses 2 spaces. This patch simply maintains the consistency in indentations and provides no other modifications to code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:02:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:02:32 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #6 from Lari Taskula --- Created attachment 52378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52378&action=edit Bug 16699: Support multiple types in primitive definitions Currently it is not possible to define multiple types for primitive definitions in /definitions/*. If you try to use the following "firstname": { "type": ["string", "null"], "description": "patron's first name" } in definitions.json, online.swagger.io validator will not validate it: {"messages":["attribute definitions.firstname.type is not of type `string`"]} One way to get around this issue is to extend definitions with custom "x-primitives" object, where we will define all reusable primitive definitions. To test: 1. Add the "firstname" example above to definitions.json 2. Run minifySwagger.pl 3. Validate your specification 4. Observe that error with description mentioned above is given 5. Apply patch 6. Repeat step 2 and 3 7. Observe that validation passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:03:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:03:21 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #7 from Lari Taskula --- Created attachment 52379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52379&action=edit Bug 16699: Reference new x-primitives in currently defined objects Since we have defined some basic x-primitives in x-primitives.json, we can now start to reuse them in our currently defined objects. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate your Swagger specifications 4. Observe that validation passes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:03:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:03:45 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #8 from Lari Taskula --- Created attachment 52380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52380&action=edit Bug 16699: Move Swagger-related files to api/v1/swagger This patch separates Swagger-specifications and the minifySwagger.pl from other api-files by moving specifications & minifier into api/v1/swagger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:05:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:05:10 +0000 Subject: [Koha-bugs] [Bug 16735] New: Replace existing library search groups functionality with the new hierarchical groups system Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Bug ID: 16735 Summary: Replace existing library search groups functionality with the new hierarchical groups system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should replace the existing library search groups with the use of the new hierarchical groups system so that old system can be removed completely. General outline: 1) Add the option to each group for it to be a "search" group 2) Port over existing groups by creating a new group for each "categorycode" in the branchrelations table 3) Re-implement the group search using the new system, remove the old system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:05:19 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:05:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:05:25 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:05:19 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:05:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:05:29 +0000 Subject: [Koha-bugs] [Bug 16736] New: Keep branch filter when changing suggestion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Bug ID: 16736 Summary: Keep branch filter when changing suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When changing suggestion, the selected tab is kept. The same should be done with the selected branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:05:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:05:36 +0000 Subject: [Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:09:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:09:01 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #72 from Kyle M Hall --- (In reply to Jonathan Druart from comment #70) > The discussion about the modal should be brought at the next dev meeting I > think: > Is everybody (i.e. the majority) agrees on this change, who is going to > implement it to the other pages, etc. That sounds good to me. I think we should vote to add this behavior as the preferred "one page" viewer/editor style, deprecating the older "hide/show" style in preference to it. Once that is voted on, we can identify pages that use the "hide/show" style and file bugs to replace each one. I'd be happy to work on those bugs. I think using the modal is great ux improvement and it would be worthwhile to make that change throughout Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:09:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:09:28 +0000 Subject: [Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:09:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:09:30 +0000 Subject: [Koha-bugs] [Bug 16736] Keep branch filter when changing suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16736 --- Comment #1 from Fridolin SOMERS --- Created attachment 52381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52381&action=edit Bug 16736 - Keep branch filter when changing suggestion When changing suggestion, the selected tab is kept. The same should be done with the selected branch. Test plan: - Go to suggestions table : /cgi-bin/koha/suggestion/suggestion.pl - Select a branch in Acquisition information > For - Select a pending suggestion - Change status as accepted - Click on Submit => without patch, the table is no longer filtered by branch => with patch, the table is filtered by branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:12:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:12:17 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #9 from Lari Taskula --- The patches above with Bug 16212 is my proposal for splitting the Swagger spec. This passes online.swagger.io/validator validations and passes all current REST tests in master. I think it is essential to split the specification yet also maintain its validity against the swagger.io-validator. I'm open to ideas and criticism :) I will soon provide the patch for defining the required permissions in Swagger paths spec. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:18:11 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 14 17:18:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jun 2016 15:18:19 +0000 Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51977|0 |1 is obsolete| | Attachment #52080|0 |1 is obsolete| | Attachment #52373|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 52382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52382&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate"