[Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #1)
> This line in C4/Auth_with_cas.pm is the culprit of all those warns:
> 
> my $context = C4::Context->new() or die 'C4::Context->new failed';
> 
> Comment it out and run 'prove t' and you are back to the basic mess that is
> expected. Sadly, I believe it is necessary, even though $context is not used.
> 
> What do you think, Marcel?

Just running Prices.t with this line changed to my $context; does not resolve
my warnings with a missing KOHA_CONF.
If I am adding a fake KOHA_CONF without db password, no warns. (Should be kind
of equal to stopping the sql server.)
So, more fundamental is: if we put a test in t and we do not want database
access, should the test need existence of koha-conf (without database access
info)? Of course, some tests may do completely without it. Should we mock it
somehow in an early begin block?
Making a distinction between tests with conf and without would be a bridge too
far.

-- 
You are receiving this mail because:
You are watching all bug changes.