[Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

--- Comment #4 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to M. Tompsett from comment #1)
> This line in C4/Auth_with_cas.pm is the culprit of all those warns:
> 
> my $context = C4::Context->new() or die 'C4::Context->new failed';
> 
> Comment it out and run 'prove t' and you are back to the basic mess that is
> expected. Sadly, I believe it is necessary, even though $context is not used.

Hm, why do you think this call is necessary in C4/Auth_with_cas.pm?

It caught my attention because I was planning to post a patch which eliminates
C4::Context->new() calls in C4/Auth_with_cas.pm and in Koha/Database.pm (config
file is being parsed 3 times for an average Koha script for no aparent reason,
this is bad for performance). I've concluded that both those calls are 100%
redundant, but maybe I overlooked something?

-- 
You are receiving this mail because:
You are watching all bug changes.