[Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
> (M. Tompsett from comment #1)
> This line in C4/Auth_with_cas.pm is the culprit of all those warns:
> my $context = C4::Context->new() or die 'C4::Context->new failed';
> Comment it out and run 'prove t' and you are back to the basic mess that is
> expected. Sadly, I believe it is necessary, even though $context is not
> used.

> (Jacek Ablewicz from comment #4)
> Hm, why do you think this call is necessary in C4/Auth_with_cas.pm?
[SNIP]
> I've concluded that both those calls are 100% redundant, but maybe
> I overlooked something?

While you are likely correct, I didn't trace it completely, my worry is the
order in which things are run. There may be an accidental order dependency in
terms of the caching, object creation, or whatever. We don't have full test
coverage, so I don't know if something will break. I believe there "... be
dragons".

-- 
You are receiving this mail because:
You are watching all bug changes.