[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Aliki Pavlidou from comment #12)

Hi Aliki thank your for testing

> Regarding Patrons list the "Select all" and "Clear all" icons are not the
> same as the "Remove selected patrons" or "Remove selected".
That was intentionally did it since comment 5 about that I can cite "There is
currently some confusion in how we indicate remove or cancel (See Bug 16005). I
think the "trash" icon should be the standard for delete or remove." So I can't
use the same trash icon for clear button.

> Regarding comments "delete and" icon is not there (of course there are no
> comments in the test page and this may be the reason).
Perhaps I did not write well the test plan "delete and" icon really does not
exist, I was refering only to three buttons: "Approve", "Delete", "Unapprove",
those buttons shown in two tabs "Approved comments" and "Comments awaiting
moderation".

> regarding "Tags", "Test" and "Apply filter(s)" have the same shiny icon!
> There are no "Clear all" and "Set TagsModeration to Require", buttons.
In this point the interface was little changed to reflect the same look as
other parts in Koha. If you see before apply patch the leyend for this is
"Select: All Pending None" and after is shown like in attach
<https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51499>
Respect to "Set TagsModeration to Require" again I did not explain well, I was
refering to set the syspref "TagsModeration" to "Require"

> The "The Approved", "Rejected", "Pending, and "Total" buttons in the right
> box are not icons.
Citing again the comment 5 "The links under "Terms summary" should not have
icons. Icons are attached to controls which trigger actions. These links are
for different views of the data." So I did not put icons in this right box.
Look an obsolete image attached
<https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51251>

At this point I would like to know the opinion of Owen or another QA like
Katrin.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.