[Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 3 18:56:56 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #4)
> Because I have not found anywhere it's called many times. As I wrote
> previously, I am not sure it'd be interesting to cache it, but I may be
> wrong.
> If we decide to cache it, we need to make sure the values in cache are
> deleted when letters are updated/deleted.
> Anyway it will be a much bigger patch and more an enhancement than a bugfix.

Yes, it would be more work. But this patch affects performance.
Note that I am not sure if this is actually a bugfix.
The comment about regularly restarting plack is probably outdated. If we let
each worker process only handle 50 requests, you do not need to restart plack
very often.
Since a new worker starts with an empty 'cache', you will not long see the old
letter contents anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list