[Koha-bugs] [Bug 16635] t/00-load.t warning from C4/Barcodes/hbyymmincr.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jun 6 07:33:13 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16635

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51955|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 52070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52070&action=edit
[SIGNED-OFF] Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm

According to http://perldoc.perl.org/vars.html, "our" should
be a reasonable substitute for the "use vars". By declaring as
"our", and removing the INIT, prove t/00-load will no longer
generate a warning about INIT for the C4/Barcodes/hbyymmincr.pm
module.

TEST PLAN
---------
1) prove t/00-load.t
   -- warnings about INIT for hbyymmincr
2) prove `git grep -l hbyymmincr | grep [.]t$`
   -- should all run okay
3) apply patch
4) repeat steps 1 and 2
   -- warning should be gone, and everything else run okay
5) run koha qa test tools

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list