[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 52132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52132&action=edit
Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.