[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #62 from Owen Leonard <oleonard at myacpl.org> ---
> (In reply to Jonathan Druart from comment #59)
> It is weird to have 2 "library groups" features and I think the first step
> should be to replace the existing one.

I agree. It is confusing to have two menu items on the administration page,
"Libraries and groups" and "Library groups." I think we should think of a way
to manage all this functionality in one section.

Some other comments:

- Nowhere else do we use the "fa-plus-circle" icon for "add." We always use
"fa-plus."

- Nowhere else in Koha do we use a modal to display an add form. We either
display a form on a separate page or we use JS to show/hide the edit form on
the page to mimic the display of a separate page. See
admin/items_search_fields.pl for example.

- Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always use
"fa-pencil."

- When displaying confirmation messages we use '<div class="dialog message">'
not '<div class="dialog alert">'

- There is no reason to display an icon ("<i class="fa fa-object-group"></i>")
next to each group. It doesn't serve any function.

- There is no reason to display an icon ("<i class="fa fa-home"></i>") next to
each library in a group. It doesn't serve any function.

- Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It should
be "fa-trash."

- Nowhere else in Koha do we add an icon to the "actions" menu.

- Nowhere else in Koha do we use a modal to display a delete confirmation
message. I think I could be convinced that we should, but I'd like to hear the
argument. If we do, we should use the space given to display more information
about the deletion than this implementation does, e.g. what exactly am I
deleting?

- Instead of a "home" icon for "Add library" I think it should be the "plus"
icon which is associated with adding or creating something.

- The list of libraries in the "Add library" dropdown should be alphabetized by
library name, not library code.

- This patch adds five new instances of "onclick." I've been working very hard
to eliminate the use of "onclick" and I don't think new patches should add
them.

-- 
You are receiving this mail because:
You are watching all bug changes.