[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> ---
> I agree. It is confusing to have two menu items on the administration page,
> "Libraries and groups" and "Library groups." I think we should think of a
> way to manage all this functionality in one section.

These two sub-systems are completely unrelated. They really don't belong
together. I'd be more than happy to rename it "Library hierarchies" if you find
that acceptable, or to rename the existing groups to "search groups" which is
what they are.

> Some other comments:
> 
> - Nowhere else do we use the "fa-plus-circle" icon for "add." We always use
> "fa-plus."

Changed with followup.

> 
> - Nowhere else in Koha do we use a modal to display an add form. We either
> display a form on a separate page or we use JS to show/hide the edit form on
> the page to mimic the display of a separate page. See
> admin/items_search_fields.pl for example.

You are correct, but I believe the modal may be a better paradigm. Would you
disagree? It means we aren't shifting elements on the page around when we
hide/display a form. I know it's without precedent at the moment but I'd like
you to consider the advantages. Think about how every other site does this
stuff. It's typically with modals. Koha is generally working against the
standard web ux by *not* using modals! Would you agree?

> 
> - Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always
> use "fa-pencil."

Changed with followup!
> 
> - When displaying confirmation messages we use '<div class="dialog
> message">' not '<div class="dialog alert">'

Can do!

> 
> - There is no reason to display an icon ("<i class="fa
> fa-object-group"></i>") next to each group. It doesn't serve any function.

Changed in followup!

> 
> - There is no reason to display an icon ("<i class="fa fa-home"></i>") next
> to each library in a group. It doesn't serve any function.

Changed in followup!

> 
> - Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It
> should be "fa-trash."

Fixed in followup!

> 
> - Nowhere else in Koha do we add an icon to the "actions" menu.

Will do!

> - Nowhere else in Koha do we use a modal to display a delete confirmation
> message. I think I could be convinced that we should, but I'd like to hear
> the argument. If we do, we should use the space given to display more
> information about the deletion than this implementation does, e.g. what
> exactly am I deleting?

We use plenty of js confirm dialogs for delete confirmation messages. Over the
years they've gotten more and more jarring in my opinion. They cannot be styled
to match the look of Koha. Even more importantly, we tend to abuse confirm
dialogs by adding far to much text to them which we attempt to lay out with
only spaces and newlines. With the modal this is a non-issue because we can
simply use html. The modal seems much more natural and integrated, while
presenting the exact same options to the user.

> 
> - Instead of a "home" icon for "Add library" I think it should be the "plus"
> icon which is associated with adding or creating something.

Fixed!

> 
> - The list of libraries in the "Add library" dropdown should be alphabetized
> by library name, not library code.

Fixed!

> - This patch adds five new instances of "onclick." I've been working very
> hard to eliminate the use of "onclick" and I don't think new patches should
> add them.

Fixed! I wrote this patch before the move away from onclick and I'm happy to
see them go ; )

-- 
You are receiving this mail because:
You are watching all bug changes.