[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #67 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Owen Leonard from comment #65)
> (In reply to Kyle M Hall from comment #63)
> 
> > These two sub-systems are completely unrelated. They really don't belong
> > together.
> 
> If this is a feature without any real application in Koha yet, perhaps we
> shouldn't add it to the menu system at all?

I don't expect this patch set to be pushed to master until Bug 15708 is ready
to be pushed along with it. I would like to get this to Passed QA in the
meantime.

> 
> > > - Nowhere else in Koha do we use a modal to display an add form.
> >
> > You are correct, but I believe the modal may be a better paradigm.
> 
> Perhaps. However, I think introducing a new interface pattern requires a
> certain amount of commitment to making that change consistently throughout
> the interface. For example, using jEditable for the Quote of the Day feature
> was an interesting proof of concept, but it went nowhere after that.
> Introducing the use of Font Awesome was a good improvement, but it took a
> lot of buy-in and work to make it consistent.

I agree. I'm willing to put in some work if you can identify some areas where
you'd like to see modals. I think the low-hanging fruit would be any of the
hide/show forms we have. The audio alerts editor is the first one that comes to
mind, but I'm sure you can point out some others!

> 
> > > - Nowhere else in Koha do we use a modal to display a delete confirmation
> > > message.
> >
> > The modal seems much more natural and
> > integrated, while presenting the exact same options to the user.
> 
> I think that's fine, especially if we take advantage of the opportunity to
> display thorough information to the user. As I said above, I think making
> the change requires /some/ commitment to implementing the same change
> throughout the staff client.

Agreed, this latest followup takes advantage of that a bit be showing the group
to be deleted in one case, in the case of removing a library from a group it
shows the library name and the group it will be removed from with some minor
styling. Nothing amazing but definitely easier on the eyes and no unnecessary
use of quotes around the names of things because the confirm dialogs are only
plaintext. If you think my styling could be improved just let me know!
Basically it's just styled with the group and library names italicized and
bold. I think we need a standard pattern for how to style the names of things
in this fashion, and I see no reason not to start here.

-- 
You are receiving this mail because:
You are watching all bug changes.