[Koha-bugs] [Bug 16734] New: getLanguages() in opac-search.pl should be called only if needed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jun 14 16:31:49 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

            Bug ID: 16734
           Summary: getLanguages() in opac-search.pl should be called only
                    if needed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org

There is no need to always call getLanguages() in opac/opac-search.pl
(especially not if it's an actual search), it's output is used only in
opac-advsearch.tt template. This patch moves it into 'if ( ... $template_type
eq 'advsearch' )' block.

Speed gain is rather moderate (40 - 80 msec, if the mysql server is no too
busy, and the results are already in query cache), but it eliminates a lot of
small DBI calls, making a further profiling of OPAC searches a bit easier.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list