[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Jun 14 17:46:27 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734
Marc Véron <veron at veron.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #52374|0 |1
is obsolete| |
--- Comment #2 from Marc Véron <veron at veron.ch> ---
Created attachment 52390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52390&action=edit
Bug 16734: getLanguages() in opac-search.pl should be called only if needed
There is no need to always call getLanguages() in opac/opac-search.pl
(especially not if it's an actual search), it's output is used only
in opac-advsearch.tt template. This patch moves it into
'if ( ... $template_type eq 'advsearch' )' block.
Speed gain is rather moderate (40 - 80 msec, if the mysql server
is no too busy, and the results are already in query cache),
but it eliminates a lot of small DBI calls, making a further
profiling of OPAC searches a bit easier.
Test plan: just ensure that language selection is still available
on OPAC advanced search page, and that it still works like intended.
Signed-off-by: Marc Véron <veron at veron.ch>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list