[Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50797|0                           |1
        is obsolete|                            |

--- Comment #2 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 52409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52409&action=edit
Bug 16365: Selectivelly introduce GetMarcStructure() "unsafe" variant for
better performance

GetMarcStructure() currently uses Koha::Cache in the "safe" mode
(returning deep copy of the result data structure by default), which
causes numerous performance issues in many Koha scripts. Switching
it to the "unsafe" mode globally (2nd patch from Bug 16140) resolves
those issues, but ensuring that it is regression-free (and that it
will stay that way in the future) is far from easy. This patch
proposes a bit more manageable solution, it introduces
a possibility to use "unsafe" variant selectivelly (only in those
places in the code where GetMarcStructure() is called repetively).
That way, amount of the code that needs to be audited for possible
problems gets vastly reduced, without any performance trade-offs.

Test plan:

1) Have a look at the code and audit the parts affected by this patch
for possible regressions

-- 
You are receiving this mail because:
You are watching all bug changes.