[Koha-bugs] [Bug 16770] New: Remove wrong uses of Memoize::Memcached

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Jun 18 16:18:39 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770

            Bug ID: 16770
           Summary: Remove wrong uses of Memoize::Memcached
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

>From C4/languages.pm:
 32 eval { 
 33     if (C4::Context->ismemcached) {
 34         require Memoize::Memcached;
 35         import Memoize::Memcached qw(memoize_memcached);
 36         
 37         memoize_memcached('getTranslatedLanguages', memcached =>
C4::Context->memcached);
 38         memoize_memcached('getFrameworkLanguages' , memcached =>
C4::Context->memcached);
 39         memoize_memcached('getAllLanguages',        memcached =>
C4::Context->memcached);
 40     }
 41 };

Looking at this code, you might think these subroutines are cached, but
actually they are not.

The eval surrounding the code hides a bug, if you remove it, you will get:
  Invalid memcached argument (expected a hash)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list