[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #121 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1/ + use namespace::clean;

Why do you need it?

2/ + use Moo;

You are going to start a neverending debate using Moo: it is not marked as
mandatory and is not used from a CGI script. If you persist, you will have to
start the discussion during the next dev meeting.

3/ On bug 15451, I have created a Koha::Exporter::Record file, which will
export records.
Here you created a Koha::Patrons::Import. We will need to uniformise the
namespace.

4/ You should use pod2usage to display the help of the command line script

5/ Doc of the script is wrong:
  import_patrons.pl -c /path/to/patrons.csv -m cardnumber
-f is missing

6/ Data::Dumper is not imported

7/ The pod does not explain that the script supports several levels of
verbosity

-- 
You are receiving this mail because:
You are watching all bug changes.