[Koha-bugs] [Bug 16787] New: 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

            Bug ID: 16787
           Summary: 'Too many holds' message appears inappropriately and
                    is missing data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

bug 11250 changed the holds message to be and if,elsif loop, falling through to
catch the first appropriate message

bug 13116 changed the reporting from CanItemBeReserved causing tooManyHolds to
trigger when no holds are allowed

A side effect is that 'maxreserves' is only passed to the template when there
are too many reserves, but the too many reserves message is called when no
holds are available

To recreate:
Set maxreserves to 50
Set some item type to allow 0 holds
Attempt to place a hold on a record with that itemtype
Message will be 
"Too many holds: [Firstname Surname] can only place a maximum of total holds."
Message should be
"[Firstname Surname] cannot place any holds on these items."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.