[Koha-bugs] [Bug 16804] New: Searching can be broken by search terms containing semicolons in XSLT

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

            Bug ID: 16804
           Summary: Searching can be broken by search terms containing
                    semicolons in XSLT
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

As of CGI version 2.64 ( which was a long time again ) Perl's CGI module began
supporting the use of the semicolon (;) as a key value pair separator in
addition to the ampersand (&) which Koha currently uses.

This causes an issue where is search string is truncated at the semicolon. Not
only can this cause issues with incorrect searches/results, it can cause
malformed CCL which causes Koha to return no search results!

Test Plan:
1) Create a record with a 490$a series statement where there is a semicolon at
the end
2) Enable OPAC Suppression
3) Search for the record and click the "Series:" link
4) You will get no results

This is because the search:
se,phr:"Report to the Mississippi Legislature ;"
is
converted to
se,phr:"Report to the Mississippi Legislature

When the opac suppression is tacked on, we get malformed CCL:
(se,phr="Report to the Mississippi Legislature ) not Suppress=1

This is not an issue if we simply search for se,phr:"Report to the Mississippi
Legislature ;" because the search form properly encodes the semicolon.

The solution appears to be to make sure all URL elements are properly url
encoded and converts all ";" to "%3B".

I do notice that in
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils-MODS31.xsl we have a
template url-encode that may prove useful.

-- 
You are receiving this mail because:
You are watching all bug changes.