[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

--- Comment #28 from Owen Leonard <oleonard at myacpl.org> ---
I've made some progress on testing this. These are the pages I've tested which
appear to be fine:

admin/branches.pl
admin/smart-rules.pl
admin/patron-attr-types.pl
admin/aqplan.pl
admin/aqbudgets.pl
admin/edi_ean_accounts.pl
acqui/addorderiso2709.pl
acqui/neworderbiblio.pl
acqui/neworderempty.pl
acqui/newordersubscription.pl
acqui/newordersuggestion.pl
acqui/basketgroup.pl
acqui/basketheader.pl
acqui/parcel.pl
catalogue/issuehistory.pl
catalogue/moredetail.pl
circ/circulation.pl
circ/reserveratios.pl
circ/selectbranchprinter.pl
circ/transferstoreceive.pl
circ/view_holdsqueue.pl
circ/waitingreserves.pl
course_reserves/course-details.pl
members/members-home.pl 
members/memberentry.pl
suggestion/suggestion.pl

These are the problems I encountered:

admin/patron-attr-types.pl - Limiting by library works (data is saved) but
correct library is not selected when editing that attribute again.

admin/branch_transfer_limits.pl - "Undefined subroutine &main::mybranch called
at /admin/branch_transfer_limits.pl line 43."

admin/transport-cost-matrix.pl - Table rows display library names correctly,
but table columns are blank

admin/authorised_values.pl - Editing any authorized value "Not a HASH reference
at /admin/authorised_values.pl line 61."

admin/item_circulation_alerts.pl - No libraries listed in "select a library"
dropdown

admin/categories.pl - Editing any patron category - "Not a HASH reference at
/admin/categories.pl line 62.""

acqui/basket.pl?basketno=X - "Not a HASH reference at /acqui/basket.pl line
251.""

opac-detail.pl and catalogue/detail.pl - Can't use string ( [my library's name]
) as a HASH ref while "strict refs" in use at /C4/XSLT.pm line 308.

members/moremember.pl - sidebar: Logged-in branch is displayed instead of
patron home library
patron_lists/list.pl

reserve/request.pl - Pickup library is saved correctly but not displayed
correctly for existing holds

circ/returns.pl - If I check in an item which belongs at another library, the
holding library is shown as the destination library rather than the library
where the item was checked in

Several of those problems are blockers for this patch, but I think it's still
worthwhile to keep this bug open to encourage others to test the areas which
haven't been tested yet.

-- 
You are receiving this mail because:
You are watching all bug changes.