[Koha-bugs] [Bug 16806] New: "Too soon" renewal error generates no alert for user

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806

            Bug ID: 16806
           Summary: "Too soon" renewal error generates no alert for user
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ephetteplace at cca.edu
        QA Contact: testopia at bugs.koha-community.org

Created attachment 52773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52773&action=edit
example of error

Steps to recreate:

- for a particular item type & patron category, configure a non-zero "no
renewal before" date i.e. make it so items cannot be immediately renewed
- sign in as a patron in aforementioned patron category
- check out an item of aforementioned item type
- go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl

Actual results:

- note that under the "Renew" column a message prints indicating you cannot
renew, due to lines 244-249 of
/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt -
https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c38a2f7e24/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt#L244-L249
- however, the logic above on lines 77-85 doesn't match, the "too_soon" error
isn't being tested for -
https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c38a2f7e24/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt#L77-L85

The end result is undesirable: because the error loop triggers, the patron sees
a message, but *there's no reason given*! See attached screenshot.

Expected results:

- a message prints indicating the reason why you cannot renew the item

I'll add a patch to opac-user.tt for this shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.