[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have squashed the patches for the review, so I won't use the splinter:

1/ my $item_holding_branch = $item->{ holdingbranch };
=> would be good to have a comment here to explain the last patch.

2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference
should continue to be used everywhere, to take advantage of the syspref cache.

3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete;
should use Koha::RefundLostItemFeeRules

4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary'

-- 
You are receiving this mail because:
You are watching all bug changes.