[Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950

Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48517|0                           |1
        is obsolete|                            |

--- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 48518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48518&action=edit
[SIGNED-OFF]Bug 15950: Use Font Awesome icons for acquisitions basket close
confirmation

When closing a basket in Acquisitions the confirmation dialog should be
styled using Font Awesome icons. This patch adds them.

The cancel button has been moved into its own form so that we can get
rid of several problematic JavaScript issues: The use of the
"javascript:" pseudo-protocol, the use of an "onclick" attribute, and
the use of a JS redirect where a GET action will do.

To test, apply the patch and locate an open basket in Acquisitions which
can be closed.

- Click the 'Close this basket' button and confirm that the icons in the
  dialog look correct.
- Test the cancel operation to make sure you are redirected back to the
  page showing the basket details.
- Test the confirm operation and verify that the basket is closed.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.