[Koha-bugs] [Bug 15970] Plack should not clear syspref cache

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #1)
> (In reply to Jonathan Druart from comment #0)
> > Just played with nytprof and found something exciting:
> > 
> > If I remove the following line:
> >   C4::Context->clear_syspref_cache();
> > from the psgi file, the processing time is divided per 2 (!)
> > 
> > With the clear cache:
> > for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine
> > calls in 421 source files and 63 string evals.
> > 
> > Without the clear cache:
> > for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine
> > calls in 421 source files and 63 string evals.
> 
> Such a difference looks kind of weird - unless the script you are testing
> calls (for whatever reasons) CGI->new() repeatedly ?
> 
> BTW, how many times was C4::Context::preference() called in that test?

No idea, patch is coming.

> > Am I missing something?
> 
> With that line removed, each time when you change some syspref value, you'll
> need to restart starman server/workers manually for that change to take
> effect. However, clearing syspref cache inside CGI->new() override sub is
> probably not 100% flawless method anyway, so serwer restarts are still
> needed if one wants to be on the safe side ;)

Yes indeed, I have fixed bug 11998 to solve this constraint.

-- 
You are receiving this mail because:
You are watching all bug changes.