[Koha-bugs] [Bug 15350] DBIx::Class Startup speed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 3 22:34:28 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48519|0                           |1
        is obsolete|                            |

--- Comment #5 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 48653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48653&action=edit
Bug 15350: Move the import of Koha::Schema to a basic `use`

This moves the import of Koha::Schema from an on-demand `require` to
just a `use`; most everything in Koha uses C4::Context, which will
indirectly end up calling Koha::Database->schema->new anyway, so this
was no longer saving anything.

Note that this saves time only when a Plack-based Koha needs to create
a database connection, which is usually only the case for a new worker.

Unscientific timings before patch:
  * First load of koha2marclinks.pl on a new worker: 0.70 seconds
  * Each load after: 0.17 seconds

After patch:
  * First load: 0.31 seconds
  * Each load after: 0.17 seconds

Jonathan, you seem to be right. NYTProf was making me think we needed to do
both, but timings suggest otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list