[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 20164
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20164
Bug 10697 - Adding more unit tests to CheckReserves

Review of attachment 20164:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10697&attachment=20164)
-----------------------------------------------------------------

Is it still valid?

::: t/db_dependent/Reserves.t
@@ +130,5 @@
> +        $constraint, $bibitems,  $priority, $resdate, $expdate, $notes,
> +        $title, undef, $found);
> +
> +($status, $reserve, $all_reserves) = CheckReserves($itemnumber2);
> +is($status,"Reserved", "Reserved - title level hold, still on shelf");

Why are we expecting "Reserved"?
If I understand correctly the tests, there is not hold at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.