[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
A minor problem:

 FAIL   C4/Circulation.pm
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: Data::Dumper::Dumper (line 1870)
                forbidden pattern: Data::Dumper::Dumper (line 1872)

I think this text could be improved:

" Item location updated from CART (Not an authorized value) to Fiction shelf "

I think that should be "Item shelving location" (since "location" could be
confused with "library").

I think the text "Not an authorized value" is not helpful to the user and is
potentially scary. Think "UNAUTHOIRZED VALUE!!"

I still have an issue with the data-entry aspect of this feature. In testing, I
was stopped right away by having not put a space after the colon:

'FIC: CART' works
'FIC:CART' fails silently

I don't think it's reasonable to expect the user to know this. For that matter,
I don't think it's reasonable to expect the user to know the code for all
existing shelving location authorized values. I realize this is an
administrative setting, but I think we can do better.

At minimum we need:

- Text describing explicitly the correct format.
- Some way to warn the user if their entry is incorrect.
- Text explaining that an "_ALL_" rule overrides all others, or better:
- Some way to warn the user if they have set an "_ALL_" rule along with other
rules

Overall this new patch is a great improvement over the last. But I still think
we can do better. I think a separate template is needed, although I wouldn't
fail the patch for that unless there was some consensus.

-- 
You are receiving this mail because:
You are watching all bug changes.