[Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #9)
> Kyle,
> The module has been moved to the Koha namespace but does not respect the
> requirements for that (object oriented). I don't see the point to have it in
> Koha in that case.

Koha namespace modules do not *have* to be OO, though they should be.

PERL15:
Whenever it makes sense, code added to the Koha:: namespace should be
object-oriented. However, code that is naturally procedural should not be
shoehorned into the OO style.

I'd rather see this moved to the Koha namespace and get maybe updated to be OO
later than to introduce a new module to C4. After all, why did we get a promise
from Charles to submit this patch if we were later going to decide we would not
use it!

-- 
You are receiving this mail because:
You are watching all bug changes.