[Koha-bugs] [Bug 11998] Syspref caching issues

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #126 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #125)
> Hi Jacek,
> Did you try to profile a "real life" situation?

catalogue/search.pl (159 search results, w/ 50 results displayed per page)

It calls ->preference() 808 times, fetching 84 different preferences.

Total time spent in ->preference() calls (excluding 1st call which triggers
DBIx class loading = 250-300ms on this test server)

1) without patch, current master: 98 ms
2) without patch, Bug 13967 reverted: 11 ms
3) with patch & default caching system (Cache::Memory): 98 ms + 70 ms spent in 
->get_from_cache()
4) with patch & memcached: 34 ms spent in ->get_from_cache()

I have no idea how "typical" is that particular example... I expect that a
given script will use somewhere around 50-100 different system preferences, but
how many times will ->preference() be called on average is pretty much
impossible to estimate (200 ... 1000 ... 2000 ?)

Re/ caching system penalty in general - this patch will be probably not the
biggest offender though; for example, Bug 11842 had bigger impact on
catalogue/search.pl (150-350ms) - deserialising big, complex data structures in
perl turns out to be quite expensive (especially if you do it 50 times per
script run, like in this case).

-- 
You are receiving this mail because:
You are watching all bug changes.