[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #2 from Sally Healey <sally.healey at cheshiresharedservices.gov.uk> ---
I was keen to sign this patch off, as this causes terrible problems for us.  

Test plan:
1) Create manual invoice for 64.60 (or 1.14, 1.36, ...)
2) Try to pay it using "Pay amount" or "Pay selected" buttons

Using 'Pay Amount' button:

1)  Create manual invoice for a single payment:  64.60 (or 1.14, 1.36, ...)
2)  Pay it using 'Pay Amount' button

Pass:  this works as expected.

1)  Create manual invoice for multiple lines which total:  64.60 (or 1.14,
1.36, ...)
2)  Pay all lines using 'Pay Amount' button

Pass:  this works as expected.

1)  Create manual invoice for multiple lines.  
2)  Decide to pay an amount which totals:  64.60 (or 1.14, 1.36, ...)
3)  Pay using 'Pay Amount' button

Pass:  this works as expected.

Using 'Pay Selected' button:

1)  Create manual invoice for a single payment:  64.60 (or 1.14, 1.36, ...)
2)  Pay it using 'Pay Selected' button

Fail:  'You must pay a value less than or equal to 64.60 (or 1.14, 1.36, ...)'
displays

1)  Create manual invoice for multiple lines which total:  64.60 (or 1.14,
1.36, ...)
2)  Pay all lines using 'Pay Selected' button

Pass:  this works as expected

1)  Create manual invoice for multiple lines.  
2)  Choose some lines which total:  64.60 (or 1.14, 1.36, ...)
3)  Pay chosen lines using 'Pay Selected' button

Pass:  the error line does not appear.

However, there seems to be a major error with the 'Pay Selected' function,
which is reported in the following bug: 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397

Can we sign off this patch as it mends the functionality of the 'Pay Amount'
button and focus on the 'Pay Selected' issue in a different bug - which appears
to be a much bigger problem?

-- 
You are receiving this mail because:
You are watching all bug changes.