[Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48830|0                           |1
        is obsolete|                            |

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 48862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48862&action=edit
Bug 16008: noisy "fatal" warning when new file is moved in another patch

The failure was tracked down to check_forbidden_patterns in
QohA/File.pm's check_forbidden_patterns function.

As there can't be any forbidden patterns on a non-existent file,
this patch returns the default 1 when the file being checked
does not exist. It maintains a warning message as suggested in
comment #2.

It is better to create another check as stated in comment #2,
but I figure I'll share my less than perfect work anyways.

TEST PLAN
---------
apply bug 15870 to your koha
run qa test tools
-- see the warning
apply this patch to your qa test tools
run qa test tools
-- no more warning

-- 
You are receiving this mail because:
You are watching all bug changes.