[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Mar 11 09:36:52 CET 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 48890
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48890
[SIGNED-OFF] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool
Review of attachment 48890:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10612&attachment=48890)
-----------------------------------------------------------------
::: tools/cleanborrowers.pl
@@ +40,4 @@
> use C4::Members; # GetBorrowersWhoHavexxxBorrowed.
> use C4::Circulation; # AnonymiseIssueHistory.
> use Koha::DateUtils qw( dt_from_string output_pref );
> +use Koha::Database;
Not used.
@@ +128,5 @@
> $radio = $params->{'radio'};
> for ( my $i = 0 ; $i < $totalDel ; $i++ ) {
> $radio eq 'testrun' && last;
> + my $borrowernumber = $patrons_to_delete->[$i]->{'borrowernumber'}
> + || $patrons_to_delete->[$i]->get_column('borrowernumber');
I don't understand this line, GetBorrowersToExpunge won't return a DBIx::Class
object, so the || $patrons_to_delete->[$i]->get_column('borrowernumber'); part
is not necessary.
@@ +179,4 @@
> my $borrowers = shift;
> my $balance;
> @$borrowers = map {
> + (undef, undef, $balance) = GetMemberIssuesAndFines( $_->{borrowernumber} || $_->get_column('borrowernumber') );
Same here.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list