[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Srdjan Jankovic from comment #6)
> Kyle, since you wrote Koha::Logger, wouldn't it be more appropriate to use
> Koha::Logger->get(() instead of passing $server around?

Passing $server around improves the efficiency of the code, but that's not the
primary reason to do so. The primary reason is that this gives is the ability
to store and output the sip login username as part of all of our log lines.
This is by far the most important improvement this patch set provides. Right
now reading SIP2 logs can be downright painful to do on a busy site as all the
SIP2 communications from various devices are mixed together. With this patch,
making the logs more readable is as simple as assigning each device a separate
SIP2 login to each device!

-- 
You are receiving this mail because:
You are watching all bug changes.