[Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 16 12:21:20 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 49197
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49197
[SIGNED-OFF] Bug 15877 - Unit tests

Review of attachment 49197:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15877&attachment=49197)
-----------------------------------------------------------------

A warning is raised by C4::Barcodes, use warning_is to catch it.

::: t/db_dependent/Barcodes.t
@@ +53,5 @@
> +        barcode => $barcodevalue
> +    }
> +});
> +
> +ok($barcodevalue eq $barcodeobj->db_max(), "(annual) First barcode saved to db is equal to db_max" );

use is instead of ok.

@@ +59,5 @@
> +$barcodevalue = $barcodeobj->next_value();
> +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> +$barcodevalue = $barcodeobj->next_value($barcodevalue);

Why are you calling 4x this method?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list