[Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Failed QA

--- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Sorry to see that this patchset fails:
If you run qa tools (you should..), you have a lot of fails like:
 FAIL   t/db_dependent/Serials/Claims.t
   OK     critic
   OK     forbidden patterns
   OK     pod
   SKIP   spelling
   FAIL   valid
                Global symbol "$ordernumber" requires explicit package name
                Compilation failed in require

This comes from C4/Acquistion.pm L 1458 
 NotifyOrderUsers( $ordernumber );

Note that your patch removes its declaration:
 sub ModReceiveOrder {
-    my ( $params ) = @_;
-    my $biblionumber = $params->{biblionumber};
-    my $ordernumber = $params->{ordernumber};

When running qa tools, I also saw:
5xUse of uninitialized value $_[0] in lc at /usr/share/perl5/Cache.pm line 485.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/masterclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
line 350.

-- 
You are receiving this mail because:
You are watching all bug changes.