[Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 18 15:31:31 CET 2016


--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 49318
[COUNTER-PATCH] Bug 16008: Deal with removed files

    Bug 16008: Deal with removed files

    This patch fixes 2 issues:
    1/ When a patch just removes files, the $git->log method did not
    return the right list of files. The commit which only removed files were
    not counted.
    2/ If a file is added then deleted in the same patch set, the following
    error occurred:
    fatal: ambiguous argument 't/db_dependent/RecordProcessor_ViewPolicy.t':
    unknown revision or path not in the working tree.
    Now it's correctly handled: a new 'git manipulation' check has been

    Note that lot of changes has been made to achieve this goal:
    1/ QohA::Files->filter has been removed: it was not needed the
    assignement was done in the BUILDER
    2/ QohA::Git->log now returns all changes (even for deleted files)
    3/ QohA::Report->type has been deleted, it was not used
    4/ The report member initialization has been moved to the parent class

    Test plan:
    % echo "#simple file" > new_file
    % echo "#comment" >> mainpage.pl
    % git add new_file mainpage.pl; git commit -m'1'
    % git rm new_file
    % git commit -m'2'
    % qa -c 2 -v 2 # should return a warning for new_file

You are receiving this mail because:
You are watching all bug changes.

More information about the Koha-bugs mailing list