[Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 23 19:07:16 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 48565
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48565
Bug 15824 - 'Done' button is unclear on batch item modification and deletion

Review of attachment 48565:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15824&attachment=48565)
-----------------------------------------------------------------

Comments base on eyeballing.

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
@@ +161,5 @@
> +            [% ELSIF src %]
> +                <a href="[% src %]">Return to where you were</a>
> +            [% ELSE %]
> +                <a href="/cgi-bin/koha/tools/batchMod.pl?del=1">Return to batch item deletion</a>
> +            [% END %]

Why not style this identical to the existing block below?

@@ +192,4 @@
>  
>      <p>
>          [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Delete items in a batch%]
> +           <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to the record", as above?

@@ +196,2 @@
>          [% ELSIF src %]
> +           <a class="btn" href="[% src %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to where you were", as above?

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
@@ +66,5 @@
> +                  [% ELSIF src %]
> +                      <a href="[% src %]">Return to where you were</a>
> +                  [% ELSE %]
> +                      <a href="/cgi-bin/koha/tools/batchMod.pl">Return to batch item modification</a>
> +                  [% END %]

Why not style this block as was done below?

@@ +245,4 @@
>  [% ELSE %] <!-- // show -->
>  <fieldset class="action">
>  [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Edit items in a batch%]
> +   <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to where you were", as above?

@@ +249,2 @@
>  [% ELSIF src %]
> +   <a class="btn" href="[% src %]"><i class="fa fa-check-square-o"></i> Done</a>

Why not change this to "Return to where you were", as above?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list