[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 25 08:35:54 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jesse Weaver from comment #12)
> I strongly believe that for consistency with the rest of Koha (and due to
> frustrations that changing the autogenerated schema files causes), that the
> sub allows_add_by should be moved to a Koha:: module. The code has no tie to
> the uploaded_files table anyway.

Hi Jesse,
I am all for consistency. But I moved this sub here instead of Upload.pm
because it does not really fit into Upload's object design. Felt like
polluting..
Not sure what frustrations you exactly mean, but imo they should not be a
reason to block this patch. The custom section of the Results modules should be
regenerated each update.
The tie to the table is indirect but clear: the sub functionally determines if
you have permission to add to the table.

> Koha::UploadedFiles might be a good name, as that could later easily become
> a Koha::Objects subclass, but that's just a suggestion.
I referred to the Object[s] in the commit message, but doing the whole exercise
was out of scope here. And just adding it for one sub did not attract me.

So I am not convinced that we should move it. But if you really insist, I'd
rather move it to Upload.pm or so?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list