[Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 25 21:52:28 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #7)
> Review of attachment 49197 [details] [review]:
> use is instead of ok.
ok (or should I say is ;-) )


> @@ +59,5 @@
> > +$barcodevalue = $barcodeobj->next_value();
> > +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> > +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> > +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> > +$barcodevalue = $barcodeobj->next_value($barcodevalue);
> Why are you calling 4x this method?

To set the value higher without using any constants. It's arbitrary to use 4, I
just knew that triggered the problem for me each time and it felt more
illustrative than 1

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list