[Koha-bugs] [Bug 15749] Add library menu to OPAC header

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 28 05:07:35 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 47704
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47704
Add branch selector to the opac header

Review of attachment 47704:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15749&attachment=47704)
-----------------------------------------------------------------

::: opac/opac-setbranch.pl
@@ +26,5 @@
> +my $sessionID = $1;
> +my $session   = get_session($sessionID);
> +
> +if ( $input->param('newbranch') ) {
> +    $session->param( 'mylibraryfirst', $input->param('newbranch') );

No validation on the parameter?!

@@ +27,5 @@
> +my $session   = get_session($sessionID);
> +
> +if ( $input->param('newbranch') ) {
> +    $session->param( 'mylibraryfirst', $input->param('newbranch') );
> +    $session->param( 'branch',         $input->param('newbranch') );

I'm not sure it is wise to just shove a random parameter value like this into
the session.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list