[Koha-bugs] [Bug 16168] New: Eliminate unneeded C4::Context->dbh calls in C4/Biblio.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 30 12:16:14 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16168

            Bug ID: 16168
           Summary: Eliminate unneeded C4::Context->dbh calls in
                    C4/Biblio.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org

Right now, ->dbh calls are actually quite expensive (they involve DB connection
health checks, each and every time). Some speed-sensitive subroutines inside
C4/Biblio.pm (GetMarcStructure, GetAuthorisedValueDesc) have this statement

    my $dbh = C4::Context->dbh;

on top of the code, but they don't always/don't usually need DB handle - not at
that stage at least. This trivial patch eliminates unneeded ->dbh calls in
those subroutines. With it, average GetMarcStructure() running time goes down
from 14 miliseconds to 9 miliseconds (on top of Bug 16166), it also makes
catalogue search profiling a bit easier.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list