[Koha-bugs] [Bug 16129] Remove URL::Encode dependency

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 31 21:06:07 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49419|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 49743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49743&action=edit
Bug 16129: Remove URL::Encode dependency

This patch makes the PayPal integration feature independent from the
URL::Encode library, which is absent in some supported distributions.

It uses the URI package which is already a Koha dependency.

To test:
- Apply the patch
- Notice there are no deps for URL::Encode
- Follow the steps from the original patch
=> SUCCESS: It works as expected
- Sign-off :-D

Note: I deleted the line in which $amount_to_pay was url-encoded, because
that's
one of the things query_form does (and the variable is only used as a parameter
to it).

Sponsored-by: ByWater Solutions

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list