From bugzilla-daemon at bugs.koha-community.org  Sun May  1 00:17:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Apr 2016 22:17:08 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-kFwBbXpYIO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #131 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
Quick feedback on a few quirks. I don't know if any of these would prevent
closing this and pushing it to master, but nonetheless:

In Circ Client

1.      It appears staff can place item level holds when this feature is on,
regardless of whether item level holds are allowed. We tested on Wednesday, and
it appears Nicole has already identified this.

2.      The holds to place count (up to three) is set to 3. Select one barcode,
set ?holds to place? dropdown to 3, and it only does one hold on the item. This
seems to be unexpected, but we don?t really know why that dropdown box is there
or what it is for.

3.      Put three items on hold on one record. Once you check in one of the
three items you placed on hold, and it is now ?waiting? for the patron, you can
place the fourth hold. You don?t need to check it out to the patron before
being able to place the fourth hold. Is this expected behavior?

In the OPAC

1.      Related to point 1 above, this does not appear to affect the OPAC.
Users are blocked from placing item level holds if they are not allowed.

In both

1.      Item level holds seem to be disregarded by the hold limit. So if you
have a limit of 10, with 9 items on hold, you can still place 2 item level
holds. We haven?t tested this in more detail.

2.      A patron can?t place a bib level and item level hold for the same item.
I?m actually struggling to think what scenario this might be used in, but we?re
nothing if not thorough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  1 00:26:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Apr 2016 22:26:11 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-sL4qHm2RrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50889|0                           |1
        is obsolete|                            |

--- Comment #7 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51066&action=edit
Bug 16330 - REST API: add routes to add, update and delete patrons

This patch adds support for add, edit and delete patrons via REST API.

GET  /api/v1/patrons                   Get patron list from params
GET  /api/v1/patrons/<borrowernumber>  Get single patron
POST /api/v1/patrons                   Create a new patron
PUT  /api/v1/patrons/<borrowernumber>  Update data about patron
DEL  /api/v1/patrons/<borrowernumber>  Delete a patron

Test plan:
1) Apply this patch (on top of dependent bug 15126)
2) Run tests perl t/db_dependent/api/v1/patrons.t
3) Add a user with proper rights to use the REST API
4) play with your favourite REST client (curl/httpie, etc.):
   Authenticate with the user created above and get a CGISESSION id.
   Use the CGISESSION to add, edit and delete patrons via the API.

Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May  1 00:31:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Apr 2016 22:31:33 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-3d4ZEIm1Rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #8 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---

> GET  /api/v1/patrons                   Get patron list from params
> GET  /api/v1/patrons/<borrowernumber>  Get single patron

Added possibiblity to search for patrons by any patron properties.

e.g. 
GET /api/v1/patrons?cardnumber=<mycardnumber>
GET /api/v1/patrons?branchcode=<mybranchcode>&categorycode=S

should give an array of matching patrons or empty array if none.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May  1 11:14:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 May 2016 09:14:49 +0000
Subject: [Koha-bugs] [Bug 16383] Making Local Use sysprefs actions buttons
In-Reply-To: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16383-70-PJmsF1V4EX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16383

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50973|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51067&action=edit
Bug 16383: Making Local Use sysprefs actions buttons

To test:
1) Go to Admin -> System Preferences -> Local Use tab
2) Confirm buttons show as font awesome buttons and work as expected
3) Confirm buttons do not wrap on a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  1 11:15:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 May 2016 09:15:12 +0000
Subject: [Koha-bugs] [Bug 16383] Making Local Use sysprefs actions buttons
In-Reply-To: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16383-70-5a2khnGH91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16383

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 02:18:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 00:18:17 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-qghqNFwwCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

--- Comment #61 from David Cook <dcook at prosentient.com.au> ---
Woo! Hurray Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 02:31:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 00:31:40 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-lxhvsHU6ya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #38 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #37)
> I would agree with you that is not necessary to test string concatenation.

I disagree. I think it is important to test string concatenation, as the query
is just a string, and it's possible that concatenation could mess up the query.

> We should be pragmatic in this regard.
> I guess the point here is not if you can concatenate strings but if you add
> this stuff to the query, will we still have results? Can you predict what
> will happen in a test case?
> This will be hard because we probably do not like to query external sources
> in a unit test.
> I once added some stuff in t/db_dependent/Breeding.t in order to start some
> testing of this module.

Spot on! 

Alternatives to querying an external source would be parsing the query. We
might be able to use the ZOOM modules for that.

Example:
$q = new ZOOM::Query::PQF('@attr 1=4 dinosaur');

"Creates a new query object, compiling the query passed as its argument
according to the rules of the particular query-type being instantiated. If
compilation fails, an exception is thrown. Otherwise, the query may be passed
to the Connection method search()."

http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#ZOOM::Query

BOOM! Surely that should work?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 04:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 02:43:36 +0000
Subject: [Koha-bugs] [Bug 16409] New: Remove redundant
 'koha-tmpl/opac-tmpl/lib/famfamfam' dir
Message-ID: <bug-16409-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16409

            Bug ID: 16409
           Summary: Remove redundant 'koha-tmpl/opac-tmpl/lib/famfamfam'
                    dir
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

Remove redundant 'koha-tmpl/opac-tmpl/lib/famfamfam' dir, from Koha repo

patch to come...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 04:43:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 02:43:47 +0000
Subject: [Koha-bugs] [Bug 16409] Remove redundant
	'koha-tmpl/opac-tmpl/lib/famfamfam' dir
In-Reply-To: <bug-16409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16409-70-pAapoYme69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16409

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:02:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:02:47 +0000
Subject: [Koha-bugs] [Bug 16397] Unable to delete audio alerts
In-Reply-To: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16397-70-BWyLhkPSJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16397

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:02:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:02:50 +0000
Subject: [Koha-bugs] [Bug 16397] Unable to delete audio alerts
In-Reply-To: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16397-70-JYSvtj2O3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16397

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51047|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51068&action=edit
[PASSED QA] Bug 16397 - Unable to delete audio alerts

This patch corrects a JavaScript error which has arisen due to the
jQuery upgrade. This should have been included in Bug 16321.

To test, apply the patch and go to Administration -> Audio alerts.

- In the list of existing audio alerts, check one or more checkboxes.
  The "Delete selected" button should become enabled.
- Uncheck all checkboxes and check that the "Delete selected" button is
  now disabled.
- Confirm that deletions are completed correctly.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:10:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:10:21 +0000
Subject: [Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
In-Reply-To: <bug-16363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16363-70-9hHCDsAjLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16398


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398
[Bug 16398] Keep expanded view after clearing the search form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:10:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:10:21 +0000
Subject: [Koha-bugs] [Bug 16398] Keep expanded view after clearing the
	search form
In-Reply-To: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16398-70-f8whd4T9er@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16363


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363
[Bug 16363] Use floating toolbar on advanced search
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:12:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:12:02 +0000
Subject: [Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
In-Reply-To: <bug-16363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16363-70-tkSPIQ5BiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confused - I don't see the floating toolbar in master?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:13:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:13:29 +0000
Subject: [Koha-bugs] [Bug 16363] Use floating toolbar on advanced search
In-Reply-To: <bug-16363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16363-70-Q1SWIccGu8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Never mind - a problem with my branch not being as current as I had thought.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:16:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:16:03 +0000
Subject: [Koha-bugs] [Bug 16398] Keep expanded view after clearing the
	search form
In-Reply-To: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16398-70-uGyKiz8zBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:16:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:16:06 +0000
Subject: [Koha-bugs] [Bug 16398] Keep expanded view after clearing the
	search form
In-Reply-To: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16398-70-LyssBszstw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51048|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51069&action=edit
[PASSED QA] Bug 16398: Keep the expanded view after clearing the search form

On the advanced search form, the "Clear fields" button should pass
expanded_options
param to preserve the view we use.

Test plan:
- Click on more options
- Fill some fields
- Click on "Clear fields"
=> Without this patch you get the "fewer options" view
=> With this patch, you will keep the "more options" view

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:21:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:21:07 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-C5kkHEUBaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:21:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:21:13 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-1uUWTCcxWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51056|0                           |1
        is obsolete|                            |

--- Comment #298 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51070&action=edit
[PASSED QA] Bug 7143: Moving about to 16.05. Hurray.

Any suggestions to highlight the version number more prominently or
elegantly are welcome. Just add a follow-up.

Test plan:
Go to About. Check Koha team. Hover over the version number.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
16.05, Yeah!
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:22:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:22:30 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-rio9L0QP1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #299 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, history.txt ends in December last year:
December 26 2015        Koha 3.20.7.1 released  releases
New bug or fix that here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:58:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:58:03 +0000
Subject: [Koha-bugs] [Bug 16410] New: koha-remove should optionally remove
 an instance's database and db-user
Message-ID: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16410

            Bug ID: 16410
           Summary: koha-remove should optionally remove an instance's
                    database and db-user
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

It would be useful if koha-remove optionally removed an instance's database and
db-user

more info to come...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:58:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:58:13 +0000
Subject: [Koha-bugs] [Bug 16410] koha-remove should optionally remove an
 instance's database and db-user
In-Reply-To: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16410-70-3J0zlhGnFX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16410

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:59:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:59:21 +0000
Subject: [Koha-bugs] [Bug 6416] koha-remove fails when dropping user
In-Reply-To: <bug-6416-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6416-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6416-70-XlT31qReMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16410

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 08:59:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 06:59:21 +0000
Subject: [Koha-bugs] [Bug 16410] koha-remove should optionally remove an
 instance's database and db-user
In-Reply-To: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16410-70-l7DkWmDjl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16410

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6416

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 09:00:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 07:00:13 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-l5UBUXI3lL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #300 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #299)
> Hm, history.txt ends in December last year:
> December 26 2015        Koha 3.20.7.1 released  releases
> New bug or fix that here?

Chris regularly updated that one until now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 09:01:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 07:01:34 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-IzZE70ZbEe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Thx for your signoffs, Bernardo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 10:11:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 08:11:34 +0000
Subject: [Koha-bugs] [Bug 16411] New: Make Hold.t not depend on two existing
	branches
Message-ID: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

            Bug ID: 16411
           Summary: Make Hold.t not depend on two existing branches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: gmcharlt at gmail.com

If you do not have two branches, this test will fail.
Can't call method "branchcode" on an undefined value at t/db_dependent/Hold.t
line 60.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 10:13:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 08:13:26 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-G67w4uHl5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 10:13:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 08:13:29 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-z4XEaMVGyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51071&action=edit
Bug 16411: Make Hold.t not depend on two existing branches

If you do not have two branches, this test will fail.
Can't call method "branchcode" on an undefined value.

This patch adds a borrower and two branches with TestBuilder.

Test plan:
Run the test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 10:13:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 08:13:42 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-OkJWPyGKmJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:04:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:04:45 +0000
Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating
 toolbar like cataloging interface
In-Reply-To: <bug-11088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11088-70-sEwKdoFygJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #23)
> (In reply to Jonathan Druart from comment #22)
> > When saving a patron, it will be at the bottom right.
> > Should not we keep a consistency?
> 
> Aleisha and I both tried to implement the floating toolbar for this bug in
> the same way that it is implemented elsewhere, but the hidden form fields in
> the search header make it difficult to implement the fixfloat()
> functionality correctly (See Comment 2).

I think I have managed to fix the issue on bug 16400, please have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:06:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:06:10 +0000
Subject: [Koha-bugs] [Bug 16167] Remove prefs to drive authorised value
	images
In-Reply-To: <bug-16167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16167-70-zN1bixrb2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16408
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16408                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408
[Bug 16408] Fix UsageStats.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:06:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:06:10 +0000
Subject: [Koha-bugs] [Bug 16408] Fix UsageStats.t
In-Reply-To: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16408-70-VzDfW8TbpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |16167
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16167                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167
[Bug 16167] Remove prefs to drive authorised value images
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:07:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:07:04 +0000
Subject: [Koha-bugs] [Bug 16408] Fix UsageStats.t
In-Reply-To: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16408-70-57hVmKXcp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51059|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51072&action=edit
Bug 16408: Fix UsageStats.t

Bug 16167 removed some prefs. This impacts the number of tests.

Test plan:
Run the test.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass
No errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:07:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:07:02 +0000
Subject: [Koha-bugs] [Bug 16408] Fix UsageStats.t
In-Reply-To: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16408-70-20gdUW9azn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:31:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:31:53 +0000
Subject: [Koha-bugs] [Bug 16403] Fix Holds.t (tests 9 and 39)
In-Reply-To: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16403-70-GZXnQ0guI7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:31:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:31:56 +0000
Subject: [Koha-bugs] [Bug 16403] Fix Holds.t (tests 9 and 39)
In-Reply-To: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16403-70-QsIvZHqVum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51054|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51073&action=edit
Bug 16403: Fix holds.t (tests 9 and 39)

Resolves this:

Failed test 'GetReservesFromItemnumber should return a valid borrowernumber'
at t/db_dependent/Holds.t line 97.
          got: '2000001890'
     expected: '2000001889'
Failed test 'Test AlterPriority(), move to bottom'
at t/db_dependent/Holds.t line 220.
          got: '4'
     expected: '5'

Test plan:
Run the test before and after applying this patch.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:32:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:32:00 +0000
Subject: [Koha-bugs] [Bug 16403] Fix Holds.t (tests 9 and 39)
In-Reply-To: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16403-70-uL8ghvfHol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51074&action=edit
Bug 16403: Remove unnecessary undef param

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:34:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:34:15 +0000
Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from
 placing a hold on a record with available items
In-Reply-To: <bug-15534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15534-70-52SIlANIBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16404


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404
[Bug 16404] Fix Circulation/Branch.t (tests 8-11)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:34:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:34:15 +0000
Subject: [Koha-bugs] [Bug 16404] Fix Circulation/Branch.t (tests 8-11)
In-Reply-To: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16404-70-dBMNzeB6TB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15534
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534
[Bug 15534] Add the ability to prevent a patron from placing a hold on a record
with available items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:36:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:36:07 +0000
Subject: [Koha-bugs] [Bug 16404] Fix Circulation/Branch.t (tests 8-11)
In-Reply-To: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16404-70-GYXvoBDJhk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51052|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51075&action=edit
Bug 16404: Fix Circulation/Branch.t (tests 8-11)

Resolves:
Failed test 'GetBranchitem returns holdallowed and return branch'
at t/db_dependent/Circulation/Branch.t line 226.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist
Failed test 'Without parameters GetBranchItemRule returns the values in
default_circ_rules'
at t/db_dependent/Circulation/Branch.t line 234.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist
Failed test 'With only a branchcode GetBranchItemRule returns values in
default_branch_circ_rules'
at t/db_dependent/Circulation/Branch.t line 239.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist
Failed test 'With only one parametern GetBranchItemRule returns default values'
at t/db_dependent/Circulation/Branch.t line 244.
     Structures begin differing at:
          $got->{hold_fulfillment_policy} = 'any'
     $expected->{hold_fulfillment_policy} = Does not exist

Test plan:
Run test before and after applying this patch.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Note: I do not see the usefulness of the lazy_any variable, I don't
think it make things easier to read.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:36:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:36:03 +0000
Subject: [Koha-bugs] [Bug 16404] Fix Circulation/Branch.t (tests 8-11)
In-Reply-To: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16404-70-Zb4p1Px2eV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:38:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:38:57 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-lYCk4fomIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14577
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577
[Bug 14577] Allow restriction of checkouts based on fines of
guarantor/guarantee
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:38:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:38:57 +0000
Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on
 fines of guarantor/guarantee
In-Reply-To: <bug-14577-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14577-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14577-70-zLvA6scKG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16405


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405
[Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t test 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:41:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:41:20 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-LTvYQJgd3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51076&action=edit
[ALTERNATIVE-PATCH] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test
2

Resolves:
Failed test 'Patron cannot check out item due to debt for guarantee'
at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
          got: '10'
     expected: '10.00'

Test plan:
Run the test again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:41:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:41:57 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-DjE6dcCjuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, I think it's better to keep `is`, could you have a look at my
alternative patch please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:47:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:47:45 +0000
Subject: [Koha-bugs] [Bug 16407] Fix Koha_borrower_modifications.t
In-Reply-To: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16407-70-4Hg0CFReUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:47:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:47:48 +0000
Subject: [Koha-bugs] [Bug 16407] Fix Koha_borrower_modifications.t
In-Reply-To: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16407-70-SAP9BnREWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16407

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51060|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51077&action=edit
Bug 16407: Fix Koha_borrower_modifications.t

This test was using hardcoded borrower number, assuming they should be
present. Now we use TestBuilder.

Test plan:
Run the test.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass before and after patch.
No errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:48:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:48:10 +0000
Subject: [Koha-bugs] [Bug 16407] Fix Koha_borrower_modifications.t
In-Reply-To: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16407-70-NzuvxUFk7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16407

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51078&action=edit
Bug 16407: Simplify comments

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:56:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:56:07 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-vKJKCllJOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #10)
> @RM please revert this patch

ping!

Above all, it fails 2 tests in t/db_dependent/Context.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:58:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:58:38 +0000
Subject: [Koha-bugs] [Bug 16406] Fix Context.t tests 27, 37 and sysprefs.t
In-Reply-To: <bug-16406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16406-70-IDssbVGP63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16406

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's a specific case, maybe we should skip the caching tests if no cache is
enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 11:59:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 09:59:57 +0000
Subject: [Koha-bugs] [Bug 16384] When canceling 'edit basket',
 return to basket summary if you came from there
In-Reply-To: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16384-70-YFnBqEreq8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16384

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:08:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:08:47 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-bUCw81WKwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Jonathan Druart from comment #10)
> > @RM please revert this patch
> 
> ping!
> 
> Above all, it fails 2 tests in t/db_dependent/Context.t

And t/db_dependent/sysprefs.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:10:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:10:45 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-9hzDITPlSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch reverted in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:11 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-BFJcU136Rh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:13 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-K61ZMbuyDK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51061|0                           |1
        is obsolete|                            |
  Attachment #51076|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51079&action=edit
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2

Resolves:
Failed test 'Patron cannot check out item due to debt for guarantee'
at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
          got: '10'
     expected: '10.00'

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:27 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-TNPokaXVJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48867|0                           |1
        is obsolete|                            |

--- Comment #48 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51080&action=edit
Bug 13321: Rename variables

This patch renames the variable according to the new DB column names
 * gste => tax_excluded
 * gsti => tax_included
 * gstrate => tax_rate
 * gstvalue => tax_value

This patch also modify the ModReceiveOrder subroutine:
 * Edit vendor note on receiving is not possible, so the code should not
   permit that.
 * Update ModReceiveOrder to pass a hashref

And that's all!
git grep on gste, gsti, gstrate and gstvalue should not return any code
that can be executed.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:31 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-02zlk6ItzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48868|0                           |1
        is obsolete|                            |

--- Comment #49 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51081&action=edit
Bug 13321: use the populate_with_prices where needed

Now we need to calculate the prices (ecost, rrp, unitprice) and tax
(tax_rate, tax_value) when the price is set for an order.

This only appends in the 3 files impacted by this patch.
addorder*.pl on ordering
finishreceive.pl on receiving

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:35 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-EFu3c4KfI3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48869|0                           |1
        is obsolete|                            |

--- Comment #50 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51082&action=edit
Bug 13321: Fix the prices calculation method

Well, we have finally arrived here \o/

The method where the prices are calculated uses the equations listed on
the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC).

The ecost is calculated from the rrp (using the discount and the tax
rate). That's why we removed the ability to edit this value.

That's why we remove the ability to edit the ecost on ordering in a
previous commit (bug 12840).

The total is now calculated in the scripts. That's why this patch
removes lines in the test file.

In C4::Acquisition::populate_order_with_prices, the calculation on
receiving must depend on the 'invoiceincgst' supplier parameter, and not
listincgst (which is used on ordering).
It also removes the rounding errors, now we store "exact" values in DB
(10^-6).
The values will be displayed using the Price TT plugin it will round the
values for us.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:39 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-g3bZR5rvyx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48870|0                           |1
        is obsolete|                            |

--- Comment #51 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51083&action=edit
Bug 13321: Tax and prices calculation - DB Changes

This patch adds 7 columns to the aqorders table:
 * unitprice_tax_excluded
 * unitprice_tax_included
 * rrp_tax_excluded
 * rrp_tax_included
 * ecost_tax_excluded
 * ecost_tax_included
 * tax_value

It also renames:
 * aqorders.gstrate with aqorders.tax_rate
 * aqbooksellers.gstrate with aqbooksellers.tax_rate

The new columns are filled with the previous calculation method.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:43 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-jQB1Y79Ig6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48871|0                           |1
        is obsolete|                            |

--- Comment #52 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51084&action=edit
Bug 13321: Csv export - Display rrp and ecost with and without taxes

If a basketgroup is exported as a CSV file, both prices should be displayed to
avoid confusion.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:11:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:11:47 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-NUbE3NyDAz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48872|0                           |1
        is obsolete|                            |

--- Comment #53 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51085&action=edit
Bug 13321: Fix unitprice rounding

We need to display the rounded value, but insert the exact value.
The unit price can be change on receiving, so the input value can be
modified.
But if it's not, we must insert the exact (not rounded) unit price,
which is the ecost value.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:14:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:14:24 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-cpOrJK85Ec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
No problem.

is( $issuingimpossible->{DEBT_GUARANTEES} == 10.00 , 1, '')
and 
is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, '')

look the same to me btw

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:14:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:14:32 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-IkAJ5HjL6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #54 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches rebased on master + 1st patch amended to use $order->{ordernumber}
instead of $ordernumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:14:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:14:41 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-NK3d15aor2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|m.de.rooy at rijksmuseum.nl    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:24:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:24:27 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-2HQn2bhp1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16406

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:24:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:24:27 +0000
Subject: [Koha-bugs] [Bug 16406] Fix Context.t tests 27, 37 and sysprefs.t
In-Reply-To: <bug-16406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16406-70-sg2CUdmmh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16406

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16104

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:30:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:30:05 +0000
Subject: [Koha-bugs] [Bug 16412] New: Cache undef in L1 only
Message-ID: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

            Bug ID: 16412
           Summary: Cache undef in L1 only
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

No need to cache undef in L2.
Prevent numerous warnings like:
Use of uninitialized value in subroutine entry at
/usr/share/koha/masterclone/Koha/Cache.pm line 284

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:31:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:31:20 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-QTOZvub7A5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:31:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:31:23 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-nwydjn6nix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51086&action=edit
Bug 16412: Cache undef in L1 only

No need to cache undef in L2.
Prevent numerous warnings like:
Use of uninitialized value in subroutine entry at
/usr/share/koha/masterclone/Koha/Cache.pm line 284

Test plan:
Run t/Cache.t
Run t/db_dependent/sysprefs.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:31:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:31:31 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-lkIfMnEb0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:36:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:36:34 +0000
Subject: [Koha-bugs] [Bug 16403] Fix Holds.t (tests 9 and 39)
In-Reply-To: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16403-70-mOVynYHr1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #5)
> Created attachment 51074 [details] [review]
> Bug 16403: Remove unnecessary undef param
> 
> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

I explicitly added the undef to *show* that the date is not defined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 12:59:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 10:59:07 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-FGl37rH9Q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #132 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Benjamin Daeuber from comment #131)
> Quick feedback on a few quirks. I don't know if any of these would prevent
> closing this and pushing it to master, but nonetheless:
> 
> In Circ Client
> 
> 1.	It appears staff can place item level holds when this feature is on,
> regardless of whether item level holds are allowed. We tested on Wednesday,
> and it appears Nicole has already identified this.

I'll look into this!

> 
> 2.	The holds to place count (up to three) is set to 3. Select one barcode,
> set ?holds to place? dropdown to 3, and it only does one hold on the item.
> This seems to be unexpected, but we don?t really know why that dropdown box
> is there or what it is for.

The "Holds to place" does not do anything when placing item specific holds. The
last patch in this series should hide that pulldown when the record-level hold
checkbox is unchecked.

> 
> 3.	Put three items on hold on one record. Once you check in one of the three
> items you placed on hold, and it is now ?waiting? for the patron, you can
> place the fourth hold. You don?t need to check it out to the patron before
> being able to place the fourth hold. Is this expected behavior?

Yes. That is standard Koha behavior.

> 
> In the OPAC
> 
> 1.	Related to point 1 above, this does not appear to affect the OPAC. Users
> are blocked from placing item level holds if they are not allowed.
> 
> In both
> 
> 1.	Item level holds seem to be disregarded by the hold limit. So if you have
> a limit of 10, with 9 items on hold, you can still place 2 item level holds.
> We haven?t tested this in more detail.

This is also standard Koha behavior. If you want more accurate hold limits, you
need to add a record level itemtype to each record so that Koha will have a
fallback itemtype to check if the hold is a record level hold and not item
level.

> 
> 2.	A patron can?t place a bib level and item level hold for the same item.
> I?m actually struggling to think what scenario this might be used in, but
> we?re nothing if not thorough.

That is also intentional and expected behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:03:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:03:58 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals
	given a delay
In-Reply-To: <bug-15581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15581-70-xW78bcOfkl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #20)
> (In reply to Kyle M Hall from comment #19)
> > Would you please update the code to pass the object instead of the keys? It
> > makes sense to avoid fetching all this data multiple times when there is no
> > need to do so.
> 
> Kyle,
> I have written GetLatestAutoRenewDate following the same pattern as
> GetSoonestRenewDate. I have noticed the inconsistencies in this part of code
> but opted to keep it as it instead of making the code diverge.
> If you agree I'd prefer to fix the two subroutines on another bug report,
> instead of adding a follow-up on this one.

That sounds like a good plan to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:14:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:14:30 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-jYwTbFYm3u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51087&action=edit
Revert "Bug 16104: Remove warnings "used only once: possible typo""

This reverts commit 6b319a2d487257e8a08bc26af9c6b2e7fa2ece2c.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:14:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:14:38 +0000
Subject: [Koha-bugs] [Bug 16406] Fix Context.t tests 27, 37 and sysprefs.t
In-Reply-To: <bug-16406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16406-70-viLoYgF8Hp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16406

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The revert on bug 16104 will resolve this issue too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:16:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:16:19 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-0LSqjZ2JaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:16:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:16:25 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-0kxvvYVkOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:16:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:16:32 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-Uo6LZITgsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:22:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:22:48 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-DOOCkwwacK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:22:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:22:51 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-7JgxC9ujvi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49827|0                           |1
        is obsolete|                            |
  Attachment #51087|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51088&action=edit
Revert "Bug 16104: Remove warnings "used only once: possible typo""

This reverts commit 6b319a2d487257e8a08bc26af9c6b2e7fa2ece2c.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with memcached and without MEMCACHED_SERVERS.
Cache.t, Context.t and sysprefs.t pass now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:44:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:44:17 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-tk9JB2gyIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:44:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:44:20 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-NeJTlCyYxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51089&action=edit
Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:44:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:44:31 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-ZZ3X5GWFGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51086|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51090&action=edit
Bug 16412: Cache undef in L1 only

No need to cache undef in L2.
Prevent numerous warnings like:
Use of uninitialized value in subroutine entry at
/usr/share/koha/masterclone/Koha/Cache.pm line 284

Test plan:
Run t/Cache.t
Run t/db_dependent/sysprefs.t

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: remove trailing space char and replace 'you' with 'we' to
match existing wordings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:47:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:47:09 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-5Ed6LoPQLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks, Jonathan.
Just to clarify for QA:
If you use memcached, this patch will remove numerous warnings like:
Use of uninitialized value in subroutine entry at
/usr/share/koha/masterclone/Koha/Cache.pm line 284

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:52:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:52:48 +0000
Subject: [Koha-bugs] [Bug 16384] When canceling 'edit basket',
 return to basket summary if you came from there
In-Reply-To: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16384-70-3SH006VPev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16384

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:52:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:52:51 +0000
Subject: [Koha-bugs] [Bug 16384] When canceling 'edit basket',
 return to basket summary if you came from there
In-Reply-To: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16384-70-w4QhPwESTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16384

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50994|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51091&action=edit
Bug 16384: Fix cancel link for 'Edit basket'

When you edit the basket from the basket summary page,
saving the change brings you back to the basket summary
page, but cancelling brings you to the baskets page of
the vendor.

To test:
- Add a basket in acq
  - Test cancel link returns to baskets page of vendor
- Add a basket and save
- Edit this basket
  - Test cancel link now returns to basket summary page

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:55:35 +0000
Subject: [Koha-bugs] [Bug 16390] Accounts.t does not need MPL
In-Reply-To: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16390-70-iazjAPeHF6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |14878, 14402

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fix a regression of bug 14878 introduced by bug 14402.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
[Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance
fees and payments older than the given number of days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878
[Bug 14878] Tests - Create the branchcodes if needed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:55:35 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: <bug-14402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14402-70-qPtZkV7Tyx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390
[Bug 16390] Accounts.t does not need MPL
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:55:35 +0000
Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed
In-Reply-To: <bug-14878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14878-70-ZypaxTwL4p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390
[Bug 16390] Accounts.t does not need MPL
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:56:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:56:33 +0000
Subject: [Koha-bugs] [Bug 16390] Accounts.t does not need MPL
In-Reply-To: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16390-70-CIJJwOc4gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 13:56:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 11:56:36 +0000
Subject: [Koha-bugs] [Bug 16390] Accounts.t does not need MPL
In-Reply-To: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16390-70-SRERsbKhf6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51049|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51092&action=edit
Bug 16390: Accounts.t does not need MPL

This test fails if you do not have a MPL branch, but a closer look shows
that we only need to replace one occurrence.

Test plan:
Run Accounts.t

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:08:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:08:15 +0000
Subject: [Koha-bugs] [Bug 16369] Clean up and improve plugins template
In-Reply-To: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16369-70-jvKSTWyAl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:08:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:08:18 +0000
Subject: [Koha-bugs] [Bug 16369] Clean up and improve plugins template
In-Reply-To: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16369-70-xA96u4Z571@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50910|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51093&action=edit
Bug 16369 - Clean up and improve plugins template

This patch makes multiple changes to the plugins home page template to
bring it up to date with current interface patterns.

Test the following changes:

- Breacrumb links have been corrected to include "Tools" in the path.
  Verify that this link is correct.
- A toolbar has been added for an "Upload plugin" button. Uploading is
  an action, not a view, so it should be displayed in a toolbar. Verify
  that the button works correctly.
- Messages are now formatted as messages rather than as headings. To
  test, trigger a message by, for instance, uninstalling all plugins or
  passing an invalid "method" parameter with the URL.
- Incorrect capitalization corrected.
- Plugin actions are moved to a single "Actions" dropdown menu. This
  includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test
  that all these menu options work correctly.
- The standard "Tools" sidebar menu has been added.
- An "onclick" attribute has been removed in favor of defining the event
  in JavaScript. Test by choosing the 'Uninstall' menu item for a
  plugin. Test both confirm and cancel actions.

Also changed:

- Corrected capitalization on the tools home page.
- Adding missing plugins link to the tools sidebar menu.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:08:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:08:35 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-oynTsTyiDn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51071|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51094&action=edit
Bug 16411: Make Hold.t not depend on two existing branches

If you do not have two branches, this test will fail.
Can't call method "branchcode" on an undefined value.

This patch adds a borrower and two branches with TestBuilder.

Test plan:
Run the test.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:08:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:08:44 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-qPHrqpvdvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:09:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:09:23 +0000
Subject: [Koha-bugs] [Bug 16369] Clean up and improve plugins template
In-Reply-To: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16369-70-Iur84OTQT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |normal

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I'd consider this patch as a bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:10:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:10:45 +0000
Subject: [Koha-bugs] [Bug 16383] Making Local Use sysprefs actions buttons
In-Reply-To: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16383-70-K4FkuLCKxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16383

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:10:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:10:48 +0000
Subject: [Koha-bugs] [Bug 16383] Making Local Use sysprefs actions buttons
In-Reply-To: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16383-70-6pn7bAgPDr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16383

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51067|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51095&action=edit
Bug 16383: Making Local Use sysprefs actions buttons

To test:
1) Go to Admin -> System Preferences -> Local Use tab
2) Confirm buttons show as font awesome buttons and work as expected
3) Confirm buttons do not wrap on a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:13:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:13:47 +0000
Subject: [Koha-bugs] [Bug 11089] Item edit screen should use floating
 toolbar like cataloging interface
In-Reply-To: <bug-11089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11089-70-XD2tZxriaf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11089

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please see bug 16400 before QAing this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:18:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:18:30 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-ryk2i06LnL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jesse Weaver from comment #40)
> I think that may be a devbox-specific problem, Kyle; this works for me, at
> least in a single-site (OPAC/intranet) git installation.
> 
> Though note that I used koha-multi.psgi, after adding:
> 
> use Koha::Handler::Plack::CGI;

Excellent! Do you think you can sign off on the patch set?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:22:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:22:22 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-u8CvWT7dMb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #33)
> It looks like we have a 'ton' of timestamp in the database. Apart from that
> there seems to be no existing other schema for timestamps columns that I
> could spot. I am not opposed to changing it - I think that's what Marcel
> wanted to do?

Indeed! I think we should standardize on a single format. I think "updated_on"
for timestamps that are set on each update and "created_on" for timestamps that
are only set at the time of creation would be appropriate. We could have a vote
at the next dev meeting to formalize this ( or another proposed format ) and
add it to the coding guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:33:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:33:27 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-grVBPUDSWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #36 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Kyle M Hall from comment #35)
> I think we should standardize on a single format.

+1

> I think "updated_on" for timestamps that are set on each update
> and "created_on" for timestamps ... only set at the time of creation

+1


> We could have a vote at the next dev meeting to formalize this ( or another
> proposed format ) and add it to the coding guidelines.

+1 -- Just incase I don't make it to the next dev meeting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:39:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:39:32 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-lzx4VLw8YI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
> Kyle: You most probably did not. If I do, these test pass with me. Note that
> Holds.t does not pass (in current master). And a fix is in PQA for
> ILSDI_Services.t.
> See comment 12, giving you an q-a-d alternative too for running
> update_dbix_class_files.pl (for testing only).

Indeed, that was my issue!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:41:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:41:09 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-BS6QepnLva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #37 from Marc V?ron <veron at veron.ch> ---
(In reply to Kyle M Hall from comment #35)
> (In reply to Katrin Fischer from comment #33)
> > It looks like we have a 'ton' of timestamp in the database. Apart from that
> > there seems to be no existing other schema for timestamps columns that I
> > could spot. I am not opposed to changing it - I think that's what Marcel
> > wanted to do?
> 
> Indeed! I think we should standardize on a single format. I think
> "updated_on" for timestamps that are set on each update and "created_on" for
> timestamps that are only set at the time of creation would be appropriate.
> We could have a vote at the next dev meeting to formalize this ( or another
> proposed format ) and add it to the coding guidelines.

+1 for standardizing, "created_on", "updated_on"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:46:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:46:08 +0000
Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal
 before' (days or hours)
In-Reply-To: <bug-14395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14395-70-LVTTzGhKoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

--- Comment #50 from bondiurbano <costalc at gmail.com> ---
(In reply to Holger Mei?ner from comment #44)
> Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA.
> The QA team also has to check a lot of other bugs, so this may take some
> time. That's all.

Holger, please look at bug #15581 by Jonathan Druart

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:52:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:52:17 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-ErHDmcEMXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:52:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:52:19 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-NodTc3f0ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49723|0                           |1
        is obsolete|                            |
  Attachment #49724|0                           |1
        is obsolete|                            |
  Attachment #49771|0                           |1
        is obsolete|                            |
  Attachment #49772|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51096&action=edit
Bug 16170: Pseudo foreign key in Items

While many of us would like to get rid of biblioitems one day, the current
scheme includes a biblioitemnumber and a biblionumber in Items.
(Which is not so great..)

But also note that biblionumber is NOT defined as a foreign key in Items,
although a belongs_to relation has been added to the DBIx scheme!
This inconsistency should be resolved. The "remove biblioitem table"
operation is a large one, but in the meantime we better make biblionumber
a regular FK not a 'pseudo' one.

Note: If in an (very) exceptional case biblionumbers are found in items,
that do not exist in biblio, this patch prints a warning at upgrade
time and does not add the constraint.

@RM: Please update the DBIx scheme accordingly.

Test plan:
[1] Run the upgrade. Check if the FK constraint has been added.
[2] Remove the FK constraint. Change the biblionumber of one item to an
    unexisting record. Run the upgrade again. Notice the warning.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested both cases: constraint added as well as warning printed.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:52:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:52:29 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-8eFQW0fBVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51097&action=edit
Bug 16170 - Corrected to make work more smoothly

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:52:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:52:31 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-va9wzzOnt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51098&action=edit
Bug 16170: [QA Follow-up] Adjust Items.t

Items.t inserts an item via biblioitem not correctly linked to biblio.
The new foreign key constraint does not allow that.
Actually, we should be choosing to either remove biblioitems from Koha or
remove biblionumber from items.

Note: This seems to be the only case where an item is added this way.

Test plan:
Run Items.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 14:52:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 12:52:34 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-gcfyH1qsQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51099&action=edit
Bug 16170: [QA Follow-up] Fix embeded typos

Just noticed this typo three times here.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:09:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:09:38 +0000
Subject: [Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl )
 complains about ftp based URLs
In-Reply-To: <bug-14530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14530-70-ZqvaAZwqP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530

Jesse Lambertson <jesse at meta21st.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at meta21st.com

--- Comment #7 from Jesse Lambertson <jesse at meta21st.com> ---
This is mostly a question about URL checking in general.

This script checks for good links in 856 $ u?

Cab it be run anywhere while logged into the server, or does it need to be run
from a specific part in the file system?

Just want to make sure.
Thank you,

Jesse

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:39:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:39:57 +0000
Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by
	overdues process"
In-Reply-To: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12509-70-HwHoDljPO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:49:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:49:53 +0000
Subject: [Koha-bugs] [Bug 16413] New: Prototype for GetLatestAutoRenewDate
 and GetSoonestRenewDate should be changed
Message-ID: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

            Bug ID: 16413
           Summary: Prototype for GetLatestAutoRenewDate and
                    GetSoonestRenewDate should be changed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16344

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate subroutines
takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to accept
the patron, item and issue information directly to avoid unnecessary refetches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344
[Bug 16344] Add a circ rule to limit the auto renewals given a specific date
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:49:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:49:53 +0000
Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals
 given a specific date
In-Reply-To: <bug-16344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16344-70-qdkc6wAceQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16413


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413
[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should
be changed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:53:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:53:13 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-KKyYgbMU9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51100&action=edit
Bug 16413: Change prototype GetLatestAutoRenewDate

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate
subroutines takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to
accept the patron, item and issue information directly to avoid
unnecessary refetches.

Test plan:
Make sure this change does not introduce regressions on bug 15581 and bug
16344.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:53:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:53:10 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-LhXNKKd2Rv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:53:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:53:17 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-RNqwof8OX0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51101&action=edit
Bug 16413: Change prototype of GetSoonestRenewDate

Same change as previous patch for the GetSoonestRenewDate subroutine.

Test plan:
Make sure this change does not introduce regressions on bug 7413.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:53:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:53:47 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals
	given a delay
In-Reply-To: <bug-15581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15581-70-WyuT6IKPI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16413

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #21)
> (In reply to Jonathan Druart from comment #20)
> > (In reply to Kyle M Hall from comment #19)
> > > Would you please update the code to pass the object instead of the keys? It
> > > makes sense to avoid fetching all this data multiple times when there is no
> > > need to do so.
> > 
> > Kyle,
> > I have written GetLatestAutoRenewDate following the same pattern as
> > GetSoonestRenewDate. I have noticed the inconsistencies in this part of code
> > but opted to keep it as it instead of making the code diverge.
> > If you agree I'd prefer to fix the two subroutines on another bug report,
> > instead of adding a follow-up on this one.
> 
> That sounds like a good plan to me!

Patches submitted on bug 16413.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 15:53:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 13:53:47 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-Ibl9pvk8qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15581

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:01:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:01:24 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-bWokByRwlD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14637
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hello Gopalakrishna,
Please try to comment the sql_mode=STRICT_TRANS_TABLES line in your
MySQL/MariaDB config file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:01:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:01:24 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: <bug-14637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14637-70-Xt1oOkBsfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16402

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:03:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:03:36 +0000
Subject: [Koha-bugs] [Bug 16414] New: aqorders.budgetgroup_id has never been
 used and can be removed
Message-ID: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

            Bug ID: 16414
           Summary: aqorders.budgetgroup_id has never been used and can be
                    removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:03:55 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-iVgFb2UOOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13669

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:03:55 +0000
Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-yVTPOymbW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16414

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Humberto Blanco from comment #5)
> > Tom?s, 
> > I have similar problem with mysql enterprise end i need to modify the
> > database structure.so:
> > 
> > ALTER TABLE aqorders ALTER COLUMN budgetgroup_id  SET DEFAULT 0;
> 
> This column does not seem to be used and could be removed.
> In the meanwhile it would be better to set it to NULL (and remove the NOT
> NULL constraint) instead of set it to 0 (which does not make sense).

See bug 16414.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:07:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:07:48 +0000
Subject: [Koha-bugs] [Bug 16415] New: Layout problem on staff client detail
 page if local cover images are enabled
Message-ID: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

            Bug ID: 16415
           Summary: Layout problem on staff client detail page if local
                    cover images are enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51102&action=edit
Screenshot showing layout problem

If you have local cover images enabled in the staff client but not Amazon
images, local covers are not displayed in a column on the right like they
should be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:16:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:16:16 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-3rgfJe5TGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:16:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:16:18 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-S73Bc5BA0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51103&action=edit
Bug 16415 - Layout problem on staff client detail page if local cover images
are enabled

This patch fixes a layout problem which appears on the staff client
bibliographic detail page if local covers are enabled but Amazon covers
are not.

To test, apply the patch and turn off AmazonCoverImages.

- Enable the LocalCoverImages system preference and locate or create a
  record which has a local cover image associated with it.
- View the bibliographic detail page. The bibliographic details should
  display in two columns, with text on the left and local cover image on
  the right.
- Test with AmazonCoverImages and LocalCoverImages enabled.
- Test with AmazonCoverImages enabled and LocalCoverImages disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:22:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:22:13 +0000
Subject: [Koha-bugs] [Bug 16416] New: insecure connection for bug report
	search
Message-ID: <bug-16416-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16416

            Bug ID: 16416
           Summary: insecure connection for bug report search
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: wosch at freebsd.org

On the page https://koha-community.org/support/search-bugs/

I searched for a bug report. I put in the string "boston" and pressed the
submit button. 

In Firefox and Safari I get a popup warning from the browser:

"The information you have entered on this page will be sent over an insecure
connection and could be read by a third party.

Are you sure you want to send this information?"

In the source code I see:

<form action="http://bugs.koha-community.org/bugzilla3/buglist.cgi"
method="get">

the protocol "http" should be replaced with "https"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:24:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:24:05 +0000
Subject: [Koha-bugs] [Bug 16417] New: Koha Calendar
Message-ID: <bug-16417-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16417

            Bug ID: 16417
           Summary: Koha Calendar
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: wosch at freebsd.org

On the Koha web site is a link "Calendar"
https://koha-community.org/calendar/

There are only entries for "Koha Bugfix Release"

I miss the KohaConf,  Koha Hackfest, IRC meeting etc...

I'm wondering if the calendar is still maintained?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:33:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:33:18 +0000
Subject: [Koha-bugs] [Bug 16418] New: EnhancedMessagingPreferencesOPAC
 appears twice in sysprefs.sql
Message-ID: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

            Bug ID: 16418
           Summary: EnhancedMessagingPreferencesOPAC appears twice in
                    sysprefs.sql
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 12528


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528
[Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:33:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:33:18 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-yq2Nz0C8Dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418
[Bug 16418] EnhancedMessagingPreferencesOPAC appears twice in sysprefs.sql
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:34:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:34:07 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-rJx1qZv0dY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:34:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:34:10 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-wbli6Zeu9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51104&action=edit
Bug 16418: Remove duplicate of EnhancedMessagingPreferencesOPAC

Test plan:
  mysql < installer/data/mysql/sysprefs.sql
should work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:40:57 +0000
Subject: [Koha-bugs] [Bug 16419] New: Tests of t/db_dependent/Acquisition.t
	do not pass
Message-ID: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

            Bug ID: 16419
           Summary: Tests of t/db_dependent/Acquisition.t do not pass
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 11371

The tests added by bug 11371 have been put after the rollback statement.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371
[Bug 11371] Add a new report : Orders by budget
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:40:57 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-vomIYBgrH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16419


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419
[Bug 16419] Tests of t/db_dependent/Acquisition.t do not pass
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:41:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:41:15 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-sbinMUA2z4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The tests in t/db_dependent/Acquisition.t are broken, see bug 16419.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:41:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:41:37 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-hkMKR4P0w9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
% prove t/db_dependent/Acquisition.t
t/db_dependent/Acquisition.t .. 63/91 
#   Failed test 'GetBudgetReport OK'
#   at t/db_dependent/Acquisition.t line 950.

#   Failed test 'GetBudgetsReport(1) OK'
#   at t/db_dependent/Acquisition.t line 953.
# Looks like you failed 2 tests of 91.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:42:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:42:48 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-zkoxWSlui2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:42:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:42:51 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-VDcj7aEEvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51105&action=edit
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t

The tests added by bug 11371 have been put after the rollback statement.

Test plan:
  prove t/db_dependent/Acquisition.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:48:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:48:35 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-FNk0dOk2y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:48:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:48:37 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-MPtmhSfBKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51104|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51106&action=edit
Bug 16418: Remove duplicate of EnhancedMessagingPreferencesOPAC

Test plan:
  mysql < installer/data/mysql/sysprefs.sql
should work

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:51:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:51:53 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-gRcQPKThqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51105|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51107&action=edit
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t

The tests added by bug 11371 have been put after the rollback statement.

Test plan:
  prove t/db_dependent/Acquisition.t
should return green

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:52:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:52:49 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-RFbJOWDwdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:56:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:56:33 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-l9cnz7QtfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:56:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:56:36 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-DMbdaPKjsu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51108&action=edit
Bug 16414: Drop aqorders.budgetgroup_id

This column has never been used and can be removed.

Test plan:
1/ update the schema
2/ prove t/db_dependent/Acquisition.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 16:59:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 14:59:27 +0000
Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when
	TransformHtmlToMarc
In-Reply-To: <bug-16370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16370-70-m35CQ2Mhmo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi C?dric,
Please have a look at the following wiki patch to know how to correctly format
a patch: https://wiki.koha-community.org/wiki/SubmitingAPatch
It would be also good to provide a test plan to reproduce the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:00:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:00:26 +0000
Subject: [Koha-bugs] [Bug 16358] Rancor - Deleting records when Rancor is
 enabled just opens them
In-Reply-To: <bug-16358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16358-70-uGoC5lfnhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16358

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Jesse, do you plan to provide a patch (if so, please switch the status to
assigned).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:08:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:08:41 +0000
Subject: [Koha-bugs] [Bug 16353] Serials Claims Filters should allow for
 combining multiple filters
In-Reply-To: <bug-16353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16353-70-qwV8vrfAGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16353

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Are you talking about master?
Since bug 10855, there are only 2 date filters on the top of the page, then
there are filters at the bottom of each column.
They seem to work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:09:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:09:32 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-t792YHE9vW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51103|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51109&action=edit
Bug 16415 - Layout problem on staff client detail page if local cover images
are enabled

This patch fixes a layout problem which appears on the staff client
bibliographic detail page if local covers are enabled but Amazon covers
are not.

To test, apply the patch and turn off AmazonCoverImages.

- Enable the LocalCoverImages system preference and locate or create a
  record which has a local cover image associated with it.
- View the bibliographic detail page. The bibliographic details should
  display in two columns, with text on the left and local cover image on
  the right.
- Test with AmazonCoverImages and LocalCoverImages enabled.
- Test with AmazonCoverImages enabled and LocalCoverImages disabled.

All combinations are OK.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:10:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:10:21 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-YhMp63oQAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:10:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:10:26 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-rQOLUr14kz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:10:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:10:28 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-NFNhBumwXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51107|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51110&action=edit
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t

The tests added by bug 11371 have been put after the rollback statement.

Test plan:
  prove t/db_dependent/Acquisition.t
should return green

Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Tests fail before the patch, and pass with it. QA scripts like the patch too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:14:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:14:59 +0000
Subject: [Koha-bugs] [Bug 16342] Placks breaks Baker and Taylor cover images
In-Reply-To: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16342-70-YuRx4luDZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, this comes certainly from the scope of $user and $pass.
Try making it a clean OO module, or use subroutines to retrieve the user and
password infos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 17:29:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 15:29:48 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-SU54c64SkH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Revert pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 19:52:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 17:52:29 +0000
Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new
 style (see also 10480)
In-Reply-To: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13438-70-YzqIAB9rl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi,
testing loading no-NB frameworks.

Leader and 007 seems right, 007 gives warnings on log file.
Buy 008 does not save, only resets the value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:33:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:33:27 +0000
Subject: [Koha-bugs] [Bug 16420] New: Buttons inconsistent between "Hold
 found" and "Hold found (waiting)" dialogs in checkin
Message-ID: <bug-16420-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420

            Bug ID: 16420
           Summary: Buttons inconsistent between "Hold found" and "Hold
                    found (waiting)" dialogs in checkin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jweaver at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

"Hold found":                           "Confirm hold", "Print slip and
confirm" and "Ignore"
"Hold found (item is already waiting)": "Confirm", "Cancel hold", "Print and
confirm"

We should settle on one ordering and wording; the current approach is both bad
for translators and confusing for librarians. It's all too easy to reach for
the middle button out of muscle memory and cancel a hold!

I would argue that the wording and ordering of the "Hold found" dialog is more
natural, so the waiting dialog should be changed to the following:

"Confirm hold", "Print slip and confirm", "Cancel hold"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:38:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:38:35 +0000
Subject: [Koha-bugs] [Bug 16421] New: Move hold edit actions into dropdown
	menu
Message-ID: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

            Bug ID: 16421
           Summary: Move hold edit actions into dropdown menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/reserve/request.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51111&action=edit
Screenshot showing proposed interface change

I propose that we re-work the way existing holds are displayed in the staff
client so that many of the actions associated with a hold are moved into a
dropdown menu. I would also add some additional information about the status of
a hold into the "details" column.

This change would accomplish a few things:

- Make the display more compact
- Make clearer some information which may not be clear. For instance, that a
hold is suspended until a particular date, or that a hold is set to lowest
priority.
- Make clearer the meaning of the hold priority icons. Using text labels with
icons, the meaning of each is explicit.

Unfortunately Font Awesome doesn't have the equivalent of the "move to top" or
"move to bottom" icon, so I've tried to fake it with a border. It's not perfect
buy may be passable.

See attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:41:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:41:56 +0000
Subject: [Koha-bugs] [Bug 16391] In 'Tools',
 the link 'Tool plugins' has '?method=tool' in its link,
 which does not show all installed plugins
In-Reply-To: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16391-70-5rNSWpjsMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:50:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:50:31 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-tl8o7M512u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51112&action=edit
Bug 10171: (QA followup) Make search tests use the right form

This bug removed the search tab from the main search box, so the tests
that use /cgi-bin/koha/catalogue/search.pl for searching, should use
the advanced search box instead.

To test:
- Run
  $ prove t/db_dependent/www/search_utf8.t
=> FAIL: Several tests related to searching on the intranet interface fail.
- Apply the patch
- Run
  $ prove t/db_dependent/www/search_utf8.t
=> SUCCESS: Tests pass
- Be happy

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:51:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:51:06 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-mMnZVHygzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:51:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:51:13 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-4qtqFxtWAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:51:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:51:21 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-fMoGnho9Qh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 20:51:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 18:51:50 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-pCNKitDd9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
@RM, please push the last followup to adjust tests to the new page layout.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:01:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:01:57 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-8Nr6DHfbqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

g.meyer at esgbonn.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:05:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:05:19 +0000
Subject: [Koha-bugs] [Bug 15254] Koha/Plack runs in endless loop if mysql is
	down
In-Reply-To: <bug-15254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15254-70-Q1o4Czcie2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15254

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I cannot recreate the issue, Tomas could you confirm that on your side?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:18:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:18:07 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-zSRoe4UbO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:18:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:18:10 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-jzzZGpZHgm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51079|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51113&action=edit
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2

Resolves:
Failed test 'Patron cannot check out item due to debt for guarantee'
at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
          got: '10'
     expected: '10.00'

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:22:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:22:04 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-jrKQ0WB5OR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51114&action=edit
Bug 15919: Batch checkout - Display the due date

When an item has been checked out in a batch, the due date will now be
displayed in the information column.

Test plan:
Use the batch checkout to check some items out
Confirm that the due date is displayed if the items have been checked
out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:22:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:22:21 +0000
Subject: [Koha-bugs] [Bug 16422] New: moremember.pl should show warning if
 lost status is changed on a checked out item.
Message-ID: <bug-16422-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16422

            Bug ID: 16422
           Summary: moremember.pl should show warning if lost status is
                    changed on a checked out item.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Changing lost status for checked out items, then wondering why the replacement
price is not refunded is a common user error, and a source of a lot of trouble
tickets.

Checking to see if an item is checked out, and displaying a warning if so, like

"It looks like you're trying to change the lost status on a checked out item --
this will not allow the replacement price to be refunded -- Do you wish to
proceed? (Yes/No)"

Would cut down confusion and reduce work-flow issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:22:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:22:28 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-CqQIg5UUtP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:25:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:25:22 +0000
Subject: [Koha-bugs] [Bug 16422] moremember.pl should show warning if lost
 status is changed on a checked out item.
In-Reply-To: <bug-16422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16422-70-tHboYZE3cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16422

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:28:34 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-RMr5YFIGns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51114|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51115&action=edit
Bug 15919: Batch checkout - Display the due date

When an item has been checked out in a batch, the due date will now be
displayed in the information column.

Test plan:
Use the batch checkout to check some items out
Confirm that the due date is displayed if the items have been checked
out.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:28:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:28:53 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-WbwkG8OLnM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:33:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:33:37 +0000
Subject: [Koha-bugs] [Bug 16290] "Name of Season" description in numbering
 pattern erases everything ahead of it in numbering formula
In-Reply-To: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16290-70-7P6enn5Ifp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16290

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Karl,
It seems to work (using master):
  TEST Spring 0         03/05/2016      
  TEST Summer 0         03/05/2016      
  TEST Fall   0         04/05/2016      
  TEST Winter 0         04/05/2016      
  TEST Spring 1         05/05/2016      
  TEST Summer 1         05/05/2016      
  TEST Fall   1         06/05/2016      
  TEST Winter 1         06/05/2016

On which version of Koha are you testing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:43:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:43:38 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-iQtuT98Tq1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |pianohacker at gmail.com,
                   |                            |tomascohen at gmail.com

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think we need to talk more about comment 3, CCing other fellows.

I personally think that we cannot support all the configurations and that Koha
will only be usable with Plack and a caching system enabled.
If it's not what everybody has in mind, we should discuss all together about
that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:47:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:47:40 +0000
Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the
	time
In-Reply-To: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16156-70-Fo4d9z3flI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
And? Is this stupid? Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 21:49:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 19:49:43 +0000
Subject: [Koha-bugs] [Bug 15782] Paging on comments moderation broken
In-Reply-To: <bug-15782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15782-70-N9vRyHUVWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is this fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:01:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:01:23 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-hv9EhDDIev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:06:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:06:36 +0000
Subject: [Koha-bugs] [Bug 16290] "Name of Season" description in numbering
 pattern erases everything ahead of it in numbering formula
In-Reply-To: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16290-70-sqRgpgXdCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16290

--- Comment #2 from Karl Holten <kholten at switchinc.org> ---
I first noticed it on our institution's install of Koha, which is 3.20. I've
tested it just now on ByWater's demo site at intranet.bywatersolutions.com and
it also seems to hold true there too. 

Finally, I've tested it on our test server, which is on master. It also occurs
there, though I'm not entirely confident that the test server is set up
completely right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:30:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:30:29 +0000
Subject: [Koha-bugs] [Bug 16423] New: Fix t/db_dependent/www/batch.t so it
 matches new layout
Message-ID: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

            Bug ID: 16423
           Summary: Fix t/db_dependent/www/batch.t so it matches new
                    layout
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: tomascohen at gmail.com
        QA Contact: gmcharlt at gmail.com

To reproduce:
- Run
  $ prove t/db_dependent/www/batch.t
=> FAIL: Several tests fail due to page layout/information problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:30:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:30:36 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-26FmABgRmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:45:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:45:14 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-skbtlwOUqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:45:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:45:16 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-nW9k5oBCUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51116&action=edit
Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout

This patch adjusts batch.t so it matches the use of datatables on the
'Manage staged records' page, and small layout changes already fixed
on search_utf8.t.

The tests are slightly modified so they actually test interesting stuff.
Some were passing only because an undefined value was passed.

To test:
- On master, run
  $ prove t/db_dependent/www/batch.t
=> FAIL: Tests fail notably
- Apply the patch
- Run:
  $ prove t/db_dependent/www/batch.t
=> SUCCESS: Notice tests now pass.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:45:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:45:22 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-HXLzS0uAIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51117&action=edit
Bug 16423: (followup) Add more tests

On fixing this tests, we retrieved the JSON data for the datatable used on
the 'Manage staged records' page. It would be cool to check the data it
carries makes sense.

To test:
- Run t/db_dependent/www/batch.t
=> SUCCESS: Tests pass
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 22:46:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 20:46:49 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-zHeRzkWxQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:17:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:17:04 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-GTBZya2mub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50950|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:18:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:18:40 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-rco2Y1FUiH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #6 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51118&action=edit
Two MARC21 records to test with multiples 7XX fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:25:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:25:37 +0000
Subject: [Koha-bugs] [Bug 16424] New: Advanced editor reverts records back
 to Default framework
Message-ID: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

            Bug ID: 16424
           Summary: Advanced editor reverts records back to Default
                    framework
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: verolencinas at yahoo.com.ar
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If you use the new advanced editor in the cataloging module, all records lose
their framework information and revert to the Default framework. Since
frameworks permit to change vocabulary and presence of fields/subfields in the
OPAC, this should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:29:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:29:08 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-WiGSvmtZRp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:29:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:29:11 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-5aK7osrhnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51045|0                           |1
        is obsolete|                            |

--- Comment #7 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51119&action=edit
Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached wit titles:
  - Surface & coatings technology.
  - Women crime writers
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet  detail page
- Look the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:33:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:33:55 +0000
Subject: [Koha-bugs] [Bug 16425] New: Advanced editor should be able to
 search, link and add authority records
Message-ID: <bug-16425-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16425

            Bug ID: 16425
           Summary: Advanced editor should be able to search, link and add
                    authority records
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: verolencinas at yahoo.com.ar
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The advanced editor in the cataloging module does not permit to search, link
and add new authority records. You can link fields to authority records through
the $9 subfield but that means searching for each authority record in a
separated browser tab or window to retrieve the record id.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:35:26 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-8a8ZCHsaiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #8 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Danielle Elder from comment #5)
> Thanks for the quick response, H?ctor.

Hi Danielle

I attach a new patch with more changes, I've included new things to the patch,
fix some mistake and also added the changes to Intranet and OPAC results.

There is a new marc file with two records, staged for test purposes.

Tanks for you test and sign-off

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:36:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:36:48 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-22opH4RsgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #9 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to H?ctor Eduardo Castro Avalos from comment #8)
> 
> Tanks for you test and sign-off

Please re-test and re-sing-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:42:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:42:54 +0000
Subject: [Koha-bugs] [Bug 2786] Allow waiting holds to be diverted to
	different branch
In-Reply-To: <bug-2786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2786-70-4eIBRmZQ38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2786

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  2 23:59:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 21:59:38 +0000
Subject: [Koha-bugs] [Bug 16417] Koha Calendar
In-Reply-To: <bug-16417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16417-70-XkF5UuekRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16417

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
The calendar depends on people putting things into it, and/or letting me know
to do so. 

You are right that KohaCon should probably be in there, I will add it.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:01:51 +0000
Subject: [Koha-bugs] [Bug 16416] insecure connection for bug report search
In-Reply-To: <bug-16416-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16416-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16416-70-NEEoHP8ZZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16416

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:03:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:03:34 +0000
Subject: [Koha-bugs] [Bug 15452] Website: Get Involved: Community Resources:
 Link to Oloh outdated (Name)
In-Reply-To: <bug-15452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15452-70-pPhB03FLeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15452

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |liz at catalyst.net.nz
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:04:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:04:34 +0000
Subject: [Koha-bugs] [Bug 15457] HEA : Display of charts is cut on Koha
 community statistics website
In-Reply-To: <bug-15457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15457-70-0keX44oV81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
           Assignee|wizzyrea at gmail.com          |paul.poulain at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:06:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:06:43 +0000
Subject: [Koha-bugs] [Bug 16318] the "Download Koha" page is outdated
In-Reply-To: <bug-16318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16318-70-RYlaCu45Md@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16318

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |liz at catalyst.net.nz
         Resolution|---                         |WORKSFORME

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
I'm not seeing this, possibly it has been fixed already.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:08:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:08:00 +0000
Subject: [Koha-bugs] [Bug 16319] the "Release Schedule" page looks stale
In-Reply-To: <bug-16319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16319-70-bsCp0jFC9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16319

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
I have removed the version numbering for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:10:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:10:43 +0000
Subject: [Koha-bugs] [Bug 16345] Spam in comments
In-Reply-To: <bug-16345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16345-70-yFqZQsPJD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16345

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Spam tidied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:13:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:13:11 +0000
Subject: [Koha-bugs] [Bug 16346] Website should be translatable
In-Reply-To: <bug-16346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16346-70-TceZQfeXyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16346

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
We had one of these for a while, then the solution was found to have a horrible
security problem, so we removed it. 

I'll investigate again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:14:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:14:23 +0000
Subject: [Koha-bugs] [Bug 16348] Kohacon 2012 is not on the website
In-Reply-To: <bug-16348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16348-70-DxTShiOcR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16348

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
https://koha-community.org/kohacon/

Edinburgh is listed here, but no link, presumably because the website for it
doesn't exist anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:15:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:15:03 +0000
Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16349-70-nGRIsALqYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Hi,

Where were you thinking of putting this information?

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:22:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:22:17 +0000
Subject: [Koha-bugs] [Bug 16350] Koha version history
In-Reply-To: <bug-16350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16350-70-SNH5gGYxMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16350

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
             Status|NEW                         |ASSIGNED

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Keen for this, let me see if I can find a way to generate this automagically.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:27:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:27:52 +0000
Subject: [Koha-bugs] [Bug 16392] Tips & Tricks?
In-Reply-To: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16392-70-C2IMNpdQeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16392

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
I think the thinking here is that the newsletters often have tips and tricks in
them. Categories are assigned by the person writing the post. I don't
necessarily disagree with the way it's been done, but possibly tags would be
better. Not sure how to resolve this one, but I thank you for raising it as a
possible issue.

I can't seem to recruit anybody to write tips and tricks posts for the
community website. (sort of) Rightfully, they tend to put them on their own
company websites.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:48:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:48:35 +0000
Subject: [Koha-bugs] [Bug 16426] New: Import borrowers tool warns for blank
 and/or existing userids
Message-ID: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

            Bug ID: 16426
           Summary: Import borrowers tool warns for blank and/or existing
                    userids
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 15840 added warns for existing userids, however these warning are now
triggering when borrowers are imported with:

1 - no userid
2 - existing userids even if they belong to the matching user

To recreate:
Find a borrower with a userid in your system
Create an import file with that patron and a new patron with no user id
Try to import and match on userid
Errors are generated and no patrons are updated or imported

Added comments From IRC:
<wizzyrea> if there is no userid, we should ignore it.
<wizzyrea> or optionally create one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:49:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:49:01 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-dX2U4g8X16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
                 CC|                            |nick at bywatersolutions.com,
                   |                            |wizzyrea at gmail.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15840

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 00:49:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 22:49:01 +0000
Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid
	already exists
In-Reply-To: <bug-15840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15840-70-1cUwkGHNG5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16426

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:14:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:14:27 +0000
Subject: [Koha-bugs] [Bug 16427] New: Direct link to authority records
 missing in record detail view
Message-ID: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

            Bug ID: 16427
           Summary: Direct link to authority records missing in record
                    detail view
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: verolencinas at yahoo.com.ar
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In previous versions of Koha you could see next to a controlled access point
with link to an authority record a magnifying glass icon that linked to the
authority record with or without the default XSLT enabled (XSLTDetailsDisplay).
In the OPAC the icon is visible and usable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:37:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:37:53 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-7nzbI2iE1m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51108|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51120&action=edit
[SIGNED.OFF] Bug 16414: Drop aqorders.budgetgroup_id

This column has never been used and can be removed.

Test plan:
1/ update the schema
2/ prove t/db_dependent/Acquisition.t
should return green

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Test green pre & post patch
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:37:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:37:50 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-JyxkHpr7VR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:41:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:41:34 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-PW6zpGkVEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:41:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:41:37 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-qwPqHpVKsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50771|0                           |1
        is obsolete|                            |

--- Comment #15 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51121&action=edit
Bug 15823: Can still access patron discharge slip without having the syspref on

EDIT: Fix for OPAC side
EDIT: Comment 10
EDIT: Merge conflicts

To test:
1) Ensure syspref useDischarge is disabled
2) Go to /cgi-bin/koha/members/discharge.pl?borrowernumber=X&discharge=1
3) Validate that you are still able to generate a discharge slip for this
patron
4) Apply patch and refresh page
5) Confirm that you are redirected to the circulation.pl page for the user and
that an error message is there.
OPAC SIDE
6) Go to the OPAC
7) Go to /cgi-bin/koha/opac-discharge.pl
8) Confirm you get a message saying discharges are disabled
9) Go to /cgi-bin/koha/opac-discharge.pl?op=request
10) Confirm you see same message

Sponsored-by: Catalyst IT

Followed test plan, works as expected (both staff client and OPAC).
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:56:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:56:50 +0000
Subject: [Koha-bugs] [Bug 16353] Serials Claims Filters should allow for
 combining multiple filters
In-Reply-To: <bug-16353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16353-70-PajbWhJwEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16353

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Nope, I wasn't talking about master, but I should have been :-)

*** This bug has been marked as a duplicate of bug 10855 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 01:56:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 May 2016 23:56:50 +0000
Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions
In-Reply-To: <bug-10855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-M0UcXz73TM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #246 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 16353 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 06:27:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 04:27:45 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-5iL1Lc9DL2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #82 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51122&action=edit
Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 06:38:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 04:38:15 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-fdGL6mouXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #83 from Florent Mara <florent.mara at gmail.com> ---
The latest patch includes the following:

(1) Further refactoring and regression tests in Koha::Patrons::Import module.

(2) A minor bug fix for header row parser by which it was possible to fail the
header row parsing (status equal to 0) yet call on Text::CSV->field() which
would create an undef entry in both the @csvcolumns and %csvkeycol variables.

(3) A more important bug fix related to dateofbirth, dateenrolled and
dateexpiry imports by which the failure to format the dates would see these
being silently ignored/replaced with default dates. This defect was caused by
the @missing_criticals being populated but ignored in the remainder of the
loop. This defect is still present in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 08:22:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 06:22:47 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-kCIBtVCKRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Florent, please be careful not to let this grow too big on a single bug
report, might be got so split issues out into several bugs at some point :)
We will also need a test plan for the testers.
Is the status correct? (Patch doesn't apply)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 08:24:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 06:24:58 +0000
Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in
 record detail view
In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16427-70-9JkULWn8tA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
           Severity|minor                       |enhancement
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this wasn't implemented for the staff side in the past - I have taken a
look recently as one of our libraries has also asked for this (3.18). One
problem is that there is no 'nice' authority view page in staff, so the link
would have to go to the standard MARC view.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 08:26:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 06:26:18 +0000
Subject: [Koha-bugs] [Bug 16290] "Name of Season" description in numbering
 pattern erases everything ahead of it in numbering formula
In-Reply-To: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16290-70-SXY59tnWmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe bug 13877 very recently pushed to master fixed this? It could explain the
difference you see in testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 08:27:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 06:27:00 +0000
Subject: [Koha-bugs] [Bug 16424] Advanced editor reverts records back to
 Default framework
In-Reply-To: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16424-70-nLv8LnSZDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m, katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 08:28:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 06:28:08 +0000
Subject: [Koha-bugs] [Bug 16425] Advanced editor should be able to search,
 link and add authority records
In-Reply-To: <bug-16425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16425-70-rHOvdZbShT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16425

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m, katrin.fischer at bsz-bw.de
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 08:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 06:35:26 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-adoFB5vKmU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Agreed, no userid in the import file should be ignored. Sorry to have missed
this in testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 09:14:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 07:14:13 +0000
Subject: [Koha-bugs] [Bug 16290] "Name of Season" description in numbering
 pattern erases everything ahead of it in numbering formula
In-Reply-To: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16290-70-ciH3MvVC7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16290

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #3)
> Maybe bug 13877 very recently pushed to master fixed this? It could explain
> the difference you see in testing.

Good catch Katrin, you must be right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:06:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:06:47 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-HmL7jfR0un@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51123&action=edit
Bug 16426: Add tests for ModMember - do not update userid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:06:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:06:44 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-p8M7w4zdAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:06:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:06:52 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-oZmf6Q8ThJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51124&action=edit
Bug 16426: follow-up of bug 15840 - correctly manage userid while inserting
patrons

Bug 15840 tried to fix a bug but makes things more complicated than it
was before.
If an userid is not provided for 1 or more rows of the csv file, it
should not be updated. However, if a userid is provided and it already
used by an other patron, the import should fail for this row (but not
crash!).

Test plan:
0/ Create a patron with a userid=your_userid
1/ Use the import patron tool to update this userid
=> userid should have been updated
2/ Update another data and do not provide the userid
=> data should have been updated and not the userid
3/ Update another data and provide the userid, but set it to an empty
string, or '0'
=> data should have been updated and not the userid
4/ Update another patron, and set userid=your_userid
=> Update should fail and an error whouls be displayed ("already used by
another patron")

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:08:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:08:38 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-VuWGzRQyop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Important note: this patch assumes that borrowers.userid should not be undef,
0, or ''. If everybody agrees with that, we will have to add an updatedb entry
to check if there are no rows in the DB matching that, otherwise an update of a
patron without userid will fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:10:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:10:06 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-tLP3EortWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15840
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=15840                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840
[Bug 15840] Import borrowers tool explodes if userid already exists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:10:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:10:06 +0000
Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid
	already exists
In-Reply-To: <bug-15840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15840-70-Jmr1vdy3Gz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16426
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16426                   |

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #27)
> I think I am seeing a problem here, that error trips whenever there is no
> username or the username exists.  
> 
> 1 - We should be able to import files with no username,
> 2 - Username existence should also check that the existing name doesn't
> belong to the matching patron

Fr?d?ric & Julian, I have submited a patch on bug 16426 to fix this issue, stay
tuned for the backport!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426
[Bug 16426] Import borrowers tool warns for blank and/or existing userids
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 10:28:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 08:28:41 +0000
Subject: [Koha-bugs] [Bug 16391] In 'Tools',
 the link 'Tool plugins' has '?method=tool' in its link,
 which does not show all installed plugins
In-Reply-To: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16391-70-gtC53Alxaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391

--- Comment #3 from Arslan Farooq <arslanone at gmail.com> ---
Hmm, then at least we should make heading of this page
/cgi-bin/koha/plugins/plugins-home.pl?method=report to be "Report Plugins", and
the heading of this /cgi-bin/koha/plugins/plugins-home.pl?method=tools should
be "Tool Plugins".

Right now for both it's "Plugins". Which is confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 11:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 09:07:10 +0000
Subject: [Koha-bugs] [Bug 16391] In 'Tools',
 the link 'Tool plugins' has '?method=tool' in its link,
 which does not show all installed plugins
In-Reply-To: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16391-70-31rlYLIzMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Arslan Farooq from comment #3)
> Hmm, then at least we should make heading of this page
> /cgi-bin/koha/plugins/plugins-home.pl?method=report to be "Report Plugins",
> and the heading of this /cgi-bin/koha/plugins/plugins-home.pl?method=tools
> should be "Tool Plugins".
> 
> Right now for both it's "Plugins". Which is confusing.

+1

I was also wondering: we now got import plugins and OPAC plugins too - I am not
sue if they are a new type or not and how you get to display them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:03:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:03:18 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-N0Q2EuPKPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:03:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:03:22 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-Tm9M3UVaW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16428


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428
[Bug 16428] The framework is not checked to know if a field is mapped
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:03:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:03:22 +0000
Subject: [Koha-bugs] [Bug 16428] New: The framework is not checked to know
 if a field is mapped
Message-ID: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

            Bug ID: 16428
           Summary: The framework is not checked to know if a field is
                    mapped
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 12874
            Blocks: 13074


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874
[Bug 12874] On editing an item, some fields can be set to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074
[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use
Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:03:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:03:22 +0000
Subject: [Koha-bugs] [Bug 12874] On editing an item,
	some fields can be set to NULL
In-Reply-To: <bug-12874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12874-70-NQCqDaeadE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16428


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428
[Bug 16428] The framework is not checked to know if a field is mapped
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:08:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:08:13 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-bIv5uty2VB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:08:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:08:16 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-BZ8ICQ16j3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51125&action=edit
Bug 16428: Use the biblio framework to know if a field is mapped

The subroutine _build_default_values_for_mod_marc takes the
frameworkcode in parameter, but ModItemFromMarc did not pass it.
It uses it to know if a field is mapped or not to a Koha field
(C4::Koha::IsKohaFieldLinked).
Consequently the default framework ("") was always used.

This bug has been found working on bug 13074 and has been put on a
separate bug report to ease the backport.

Test plan:
Without this change, the tests added by bug 16428 won't pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:15:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:15:27 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-E3LowBiy3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #85 from Florent Mara <florent.mara at gmail.com> ---
I agree 100% Katrin. Being merge master at work, I know the pain and have
debated the options several times. It was already a bit patch when I found it,
only made it bigger ...

Overall, I doubt more than 30 lines of 'working' code has been added so far.
Most of my contributions are tests + bug fixes. ~95% of my refactoring is
taking chunks of existing code from the main script and putting it in methods.
Then adding pedantic tests to validate equivalence of output.
The other 5% are defect fixes. 

I thought of stopping last week then found a defect so kept going (I intended
to create a specific bug report for the dates defect but ran out of time
today). Then a second - minor - defect while at it today. 

Ultimately, none of my work is intended to change code behavior - unless
defect. This refactoring + tests work is in preparation for my task of
improving the importer performance which is hardly possible while working on a
300 lines untested script.

For test plan, I use the 1000 entries file from the importer performance bug,
would it be worth giving more details here? I loaded plenty of patrons today,
it would be good for someone else to give it a try and update the status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:15:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:15:44 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-0Xc2uYmNvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:15:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:15:47 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-XjSdON7XbU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51126&action=edit
Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record

With the global %default_values_for_mod_from_marc variable, the changes
made to the marc_subfield_structure table and especially the links
between MARC and DB fields are not safe and might be outdated (if a
field is linked/unlinked)

Test plan:
Under Plack:
- Link the barcode field, edit a record and set a barcode.
- Remove the mapping for the barcode field and then update again the
  barcode of the record.
The items.barcode DB field must not have been updated.

Without this patch, the field should have been updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:19:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:19:23 +0000
Subject: [Koha-bugs] [Bug 16391] In 'Tools',
 the link 'Tool plugins' has '?method=tool' in its link,
 which does not show all installed plugins
In-Reply-To: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16391-70-6dydIDLnt9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:19:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:19:32 +0000
Subject: [Koha-bugs] [Bug 16391] In 'Tools',
 the link 'Tool plugins' has '?method=tool' in its link,
 which does not show all installed plugins
In-Reply-To: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16391-70-vnzhhrWNM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:26:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:26:52 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-UMqvb9oZax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7172


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:26:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:26:52 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-OeqENLP4e0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13074


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074
[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use
Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:28:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:28:39 +0000
Subject: [Koha-bugs] [Bug 16429] New: Going to circulation from notice
 triggers may change logged in branch
Message-ID: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

            Bug ID: 16429
           Summary: Going to circulation from notice triggers may change
                    logged in branch
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If you edit notice triggers and then use the "Checko out" tab from the top bar,
you may change your logged in library by accident!

To reproduce:
1) Disable the system preference CircAutocompl
2) Go to the notice triggers
3) Select the triggers for a library other than the one you logged in as
4) Use the "Check out" tab at the top to check out to a patron
5) Note your logged in branch has changed ( you'll need to refresh the page if
the check out search took you directly to one patron ).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:30:25 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-BfiVuu1Jkv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:30:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:30:54 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-BVD414KOZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12598

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:30:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:30:54 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-TILb6RSRPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16426

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:49:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:49:18 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-eo9u418hr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:49:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:49:21 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-FluHiqmdZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51127&action=edit
Bug 16429 - Going to circulation from notice triggers may change logged in
branch

If you edit notice triggers and then use the "Checko out" tab from the
top bar, you may change your logged in library by accident!

Test Plan:
1) Disable the system preference CircAutocompl
2) Go to the notice triggers
3) Select the triggers for a library other than the one you logged in as
4) Use the "Check out" tab at the top to check out to a patron
5) Note your logged in branch has changed ( you'll need to refresh the
    page if the check out search took you directly to one patron ).
6) Apply this patch
7) Repeat steps 2-4
8) Note the branch no longer changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:49:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:49:28 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-bmW7llMJP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51128&action=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:51:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:51:40 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-ozgU7LexMb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51128|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51129&action=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:53:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:53:34 +0000
Subject: [Koha-bugs] [Bug 11779] Unexpected change in logged in branch when
 changing overdue notice triggers
In-Reply-To: <bug-11779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11779-70-70BIDofwHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11779

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16429

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:53:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:53:34 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-IgSm00c2GF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11779

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:56:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:56:36 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-lp2vv9Zrsf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51129|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51130&action=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 12:59:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 10:59:43 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-BiEEXynEgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Before patch I found
not ok 7 - upload succeeded
and this message
malformed JSON string, neither array, object, number, string or atom, at
character offset 0 (before "<!DOCTYPE html>\n<!-...") at
t/db_dependent/www/batch.t line 104.

After patch, test 7 pass and no message, but test 23 fails
not ok 23 - bib is gone

#   Failed test 'bib is gone'
#   at t/db_dependent/www/batch.t line 201.
#     searched: "\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}<!DOCTYPE
html>\x{0a}<!-- TEMPLATE FILE: detail"...
#   can't find: "The record you requested does not exist"
#         LCSS: " record y"
# LCSS context: "ave been uploaded for this bibliographic record ye"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:35:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:35:59 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-syVEevqKdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:36:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:36:02 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-R4XxJsTmwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51066|0                           |1
        is obsolete|                            |

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51131&action=edit
[SIGNED-OFF] Bug 16330: REST API: add routes to add, update and delete patrons

This patch adds support for add, edit and delete patrons via REST API.

GET  /api/v1/patrons                   Get patron list from params
GET  /api/v1/patrons/<borrowernumber>  Get single patron
POST /api/v1/patrons                   Create a new patron
PUT  /api/v1/patrons/<borrowernumber>  Update data about patron
DEL  /api/v1/patrons/<borrowernumber>  Delete a patron

Test plan:
1) Apply this patch (on top of dependent bug 15126)
2) Run tests perl t/db_dependent/api/v1/patrons.t
3) Add a user with proper rights to use the REST API
4) play with your favourite REST client (curl/httpie, etc.):
   Authenticate with the user created above and get a CGISESSION id.
   Use the CGISESSION to add, edit and delete patrons via the API.

Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

On top of 15126
Tested using postman, first try with the api
GET, POST, PUT and DELETE works, i.e. list, add, update, search and delete.
Small errors fixed in followup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:36:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:36:35 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-zBWLNmepQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51132&action=edit
Bug 16330: (followup) fix spelling and number of tests

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:48:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:48:27 +0000
Subject: [Koha-bugs] [Bug 14748] REST API Testing framework
In-Reply-To: <bug-14748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14748-70-vpMdpJ92rn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Olli-Antti Kivilahti from comment #6)
> Hi!
> 
> This depends on the authentication system of the REST API which was under
> much scrutiny last time I checked.
> Bug 13920

That is in discussion, but not listed as dependency.
Anyway, more qa fails now

 FAIL   t/lib/RESTTest.pm
 FAIL   t/db_dependent/Api/V1/Borrowers.pm
 FAIL   t/db_dependent/Api/V1/testREST.pl
 FAIL   t/lib/Swagger2TestRunner.pm

and still the message "Can't locate Koha/ApiKeys.pm in @INC"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:49:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:49:05 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-xOhBj5TIOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Is that on current master??

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:54:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:54:06 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-MvUSVsXqZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #4)
> Is that on current master??

Yes.

a7446eb Bug 16423: (followup) Add more tests
c802f5b Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout
4d0d52e Revert "Bug 16104: Remove warnings "used only once: possible typo""
b20ba02 Bug 15533 - DBRev - Update OldReserve schema file to match database
schema
68dbe84 Bug 14632: Add Copyright for the Koha Dev Team
....

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 13:54:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 11:54:25 +0000
Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new
 style (see also 10480)
In-Reply-To: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13438-70-S8fXsEZV46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Bernardo Gonzalez Kriegel from comment #8)
> Hi,
> testing loading no-NB frameworks.
> 
> Leader and 007 seems right, 007 gives warnings on log file.
> Buy 008 does not save, only resets the value.

Thx for testing.
I have the same problem with 008 (as noted on the commit message), but it is
not related to this patch. You have the same problem before this patch.
Perhaps Magnus can clarify or open a new report for it ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:01:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:01:39 +0000
Subject: [Koha-bugs] [Bug 16392] Tips & Tricks?
In-Reply-To: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16392-70-UswuoieXvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16392

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Liz Rea from comment #1)

> I can't seem to recruit anybody to write tips and tricks posts for the
> community website.

Ha, that would be fun! :) But no, if there is no new content in that category,
old content in that category can't be found and is probably outdated, and the
category itself is not linked anywhere from the menu, should we get rid of it
then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:05:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:05:34 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-G7Nc9DHKbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Passes with me (one warning):

1..24
Use of uninitialized value $opac in substitution (s///) at
t/db_dependent/www/batch.t line 55.
ok 1 - connect to intranet
ok 2 - login to staff client
ok 3 - load main page
ok 4 - open tools module
ok 5 - go to stage MARC
ok 6 - uploaded file
ok 7 - upload succeeded
ok 8 - reopen stage MARC page
ok 9 - stage MARC
ok 10 - have job ID
ok 11 - job was completed
ok 12 - reopen stage MARC page at end of upload
ok 13 - stage MARC
ok 14 - view batch
ok 15 - get the datatable for the new batch id
ok 16 - found book
ok 17 - record marked as staged
ok 18 - record has no matches
ok 19 - imported records into catalog
ok 20 - record marked as imported
ok 21 - revert import
ok 22 - getting reverted bib
ok 23 - bib is gone
ok 24 - record marked as reverted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:11:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:11:35 +0000
Subject: [Koha-bugs] [Bug 16348] Kohacon 2012 is not on the website
In-Reply-To: <bug-16348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16348-70-BbG8JpZfP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16348

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
https://koha-community.org/kohacon12/ at least leads to this:
https://koha-community.org/kohacon12-attendees/

There was more on k-c.org at some point, with the schedule, their fancy logo
and all. I think they actually did not have a separate website but only used
the official one. Why did it get deleted? That's strange.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:15:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:15:58 +0000
Subject: [Koha-bugs] [Bug 16348] Kohacon 2012 is not on the website
In-Reply-To: <bug-16348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16348-70-2N2RRr3DgW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16348

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
See also
https://web.archive.org/web/20160121052908/https://koha-community.org/kohacon/kohacon12/
and the programme here
https://web.archive.org/web/20160121025923/https://koha-community.org/kohacon/kohacon12/program/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:20:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:20:00 +0000
Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new
 style (see also 10480)
In-Reply-To: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13438-70-u8L6mVcPTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Marcel de Rooy from comment #9)
> I have the same problem with 008 (as noted on the commit message), but it is
> not related to this patch. You have the same problem before this patch.

Not exactly the same, it fails to load current values but can save new ones.
With patch clicking Save does nothing, for me of course (i'm having doubts
about my testing env)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:24:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:24:55 +0000
Subject: [Koha-bugs] [Bug 16342] Placks breaks Baker and Taylor cover images
In-Reply-To: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16342-70-vKKlazy8oV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:30:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:30:00 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-mmw1RntqBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51121|0                           |1
        is obsolete|                            |

--- Comment #16 from Marc V?ron <veron at veron.ch> ---
Created attachment 51133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51133&action=edit
Bug 15823: Can still access patron discharge slip without having the syspref on

EDIT: Fix for OPAC side
EDIT: Comment 10
EDIT: Merge conflicts

To test:
1) Ensure syspref useDischarge is disabled
2) Go to /cgi-bin/koha/members/discharge.pl?borrowernumber=X&discharge=1
3) Validate that you are still able to generate a discharge slip for this
patron
4) Apply patch and refresh page
5) Confirm that you are redirected to the circulation.pl page for the user and
that an error message is there.
OPAC SIDE
6) Go to the OPAC
7) Go to /cgi-bin/koha/opac-discharge.pl
8) Confirm you get a message saying discharges are disabled
9) Go to /cgi-bin/koha/opac-discharge.pl?op=request
10) Confirm you see same message

Sponsored-by: Catalyst IT

Followed test plan, works as expected (both staff client and OPAC).
Re-tested, works OK.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:30:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:30:23 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-V4H3Pne2TK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:34:38 +0000
Subject: [Koha-bugs] [Bug 16394] Fix formatting of review.tt
In-Reply-To: <bug-16394-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16394-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16394-70-ZeIm3PpMOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
The staff client templates are full of tab characters, so I don't think we
should file bugs for each one. My understanding of the general practice
regarding indentation is:

- Always remove tab characters from lines which are changed by your patches.

- If you want to make other changes to whitespace or indentation, submit a
separate patch.

Submitting whitespace fixes is always going to create merge problems for
pending patches, so we should check http://splitter.koha-community.org for
pending patches.

It would be interesting if the splitter tool could show a list of templates
which have /no/ patches in the queue. Those would be great candidates for
whitespace fix patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:43:36 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-ZUwNkimK5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51127|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 51134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51134&action=edit
Bug 16429 - Going to circulation from notice triggers may change logged in
branch

If you edit notice triggers and then use the "Checko out" tab from the
top bar, you may change your logged in library by accident!

Test Plan:
1) Disable the system preference CircAutocompl
2) Go to the notice triggers
3) Select the triggers for a library other than the one you logged in as
4) Use the "Check out" tab at the top to check out to a patron
5) Note your logged in branch has changed ( you'll need to refresh the
    page if the check out search took you directly to one patron ).
6) Apply this patch
7) Repeat steps 2-4
8) Note the branch no longer changes

Tested with both patches applied. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:44:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:44:35 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-p016uIN90g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51130|0                           |1
        is obsolete|                            |

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Created attachment 51135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51135&action=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:45:01 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-3yDWlzZhX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:49:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:49:43 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-d8lfXphgFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
This seems to be working well, two questions:

1 - If I am matching on userid, and import a patron with no userid in the file
but the cardnumber is already used the warning says "Cardnumber ###### is not a
valid cardnumber"  
It would be clearer if it said 'this cardnumber is already used'

2 - If I am mathching on cardnumber and include an existing username in the
file I am not warned, but the username is replaced with a generated one
(surname.firstname) - I think there should be a warning since the udername
doesn't match the submitted data, or that line should fail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:56:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:56:53 +0000
Subject: [Koha-bugs] [Bug 16430] New: Mainpage.pl dies if library is not set
Message-ID: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

            Bug ID: 16430
           Summary: Mainpage.pl dies if library is not set
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On a fresh install of Koha, logging in I was met with:

Invalid dateformat parameter () at /home/vagrant/kohaclone/Koha/DateUtils.pm
line 112.

It appears that if the library is not set, you get this message on mainpage.pl.
Needless to say, this adds difficulty in setting up a fresh install of Koha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:58:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:58:50 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-5qfXDzzdA8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51136&action=edit
Bug 16430 - Mainpage.pl dies if library is not set

On a fresh install of Koha, logging in I was met with:

Invalid dateformat parameter () at
/home/vagrant/kohaclone/Koha/DateUtils.pm line 112.

It appears that if the library is not set, you get this message on
mainpage.pl. Needless to say, this adds difficulty in setting up a fresh
install of Koha!

Test Plan:
1) Check out master, start with a fresh empty database
2) Go through the installer, log in with the db user for the first time
3) Note the error
4) Apply this patch
5) Refresh the page, the error should be gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:59:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:59:07 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-PcIYDS9BbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 14:59:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 12:59:04 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-MbJLWXj7zN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:04:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:04:58 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-oUTuSSC2Qs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51136|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51137&action=edit
Bug 16430 - Mainpage.pl dies if library is not set

On a fresh install of Koha, logging in I was met with:

Invalid dateformat parameter () at
/home/vagrant/kohaclone/Koha/DateUtils.pm line 112.

It appears that if the library is not set, you get this message on
mainpage.pl. Needless to say, this adds difficulty in setting up a fresh
install of Koha!

Test Plan:
1) Check out master, start with a fresh empty database
2) Go through the installer, install all default data, log in with the db user
for the first time
3) Note the error
4) Apply this patch
5) Refresh the page, the error should be gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:07:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:07:51 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-aSh7flWW9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
On further testing, I think this may be a much deeper problem than this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:10:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:10:37 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-NRzgrLATz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51126|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51138&action=edit
Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record

With the global %default_values_for_mod_from_marc variable, the changes
made to the marc_subfield_structure table and especially the links
between MARC and DB fields are not safe and might be outdated (if a
field is linked/unlinked)

Test plan:
Under Plack:
- Link the barcode field, edit a record and set a barcode.
- Remove the mapping for the barcode field and then update again the
  barcode of the record.
The items.barcode DB field must not have been updated.

Without this patch, the field should have been updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:16:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:16:14 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-x5asayALBu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
I'm having some problems with this patch:

- It needs to be rebased (although I think I was able to correctly fix the
merge problems for testing).
- In my tests the toolbar doesn't "stick' to the top of the viewport because it
has a margin on it.
- When it is floating, the toolbar isn't styled like it is on other pages
without this patch. There is a "floating" class which isn't getting added.
- It breaks other instances of the floating toolbar. I'm getting a JS error on
the cataloging page, for instance.

I'm not sure why, but having only "save" and "cancel" in the toolbar doesn't
feel right to me. But I agree that we need to be consistent, and I agree that
this page really needs some form of always-visible save button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:16:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:16:35 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-g4e8a9qByA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |blocker

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
The root case is a change in dt_from_string:

$date_format = C4::Context->preference('dateformat') unless $date_format;

This line means that if the caller does not pass a format, the native preferred
format is assumed. When not logged in, $date_format will be empty and cause an
error. There are also many calls to dt_from_string where no format is passed
which will cause other errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:16:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:16:46 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-El8JlXvB0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51137|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:17:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:17:00 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-63jZHzuPic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED
           Assignee|kyle at bywatersolutions.com   |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:25:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:25:11 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-PGe4NGNhr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I'd keep the die, to catch next issues of the same kind.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:32:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:32:23 +0000
Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
In-Reply-To: <bug-8089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8089-70-CZ9rQM9lGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13074


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074
[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use
Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:32:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:32:23 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-kDK2EIlm9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8089


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
[Bug 8089] Use Koha::Cache everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:33:40 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-iC18XuhOqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16431


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431
[Bug 16431] Marc subfield structure should be cached using Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:33:40 +0000
Subject: [Koha-bugs] [Bug 16431] New: Marc subfield structure should be
 cached using Koha::Cache
Message-ID: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

            Bug ID: 16431
           Summary: Marc subfield structure should be cached using
                    Koha::Cache
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13074
            Blocks: 7172, 8089


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
[Bug 8089] Use Koha::Cache everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074
[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use
Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:33:40 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-0iXH8TI78f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16431


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431
[Bug 16431] Marc subfield structure should be cached using Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:33:40 +0000
Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
In-Reply-To: <bug-8089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8089-70-H4nya3PtkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16431


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431
[Bug 16431] Marc subfield structure should be cached using Koha::Cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:48:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:48:29 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-FpQ0W7yXCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Status|NEW                         |ASSIGNED
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:53:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:53:01 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-VOoWdQGMPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:53:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:53:04 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-Z7abwiXy7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51139&action=edit
Bug 16431: Use Koha::Cache to cache marc subfield structure

The marc subfield structure is currently cached using a global variable
of C4::Context. The infos are retrieved every time a new context is
created.
This patch suggests to use Koha::Cache instead.

To achieve this goal, a new subroutine is created
C4::Biblio::GetMarcSubfieldStructure, it will be called from code which
needs to get the marc subfield structure. GetMarcFromKohaField,
GetMarcSubfieldStructureFromKohaField, TransformKohaToMarc and
_get_inverted_marc_field_map are modified accordingly and the cache is cleared
when the table is updated (from the 3 pl scripts modified by this patch).

The caching done in C4::Context (marcfromkohafield) is removed.

Test plan:
Play with the marc subfield structure (in the administration module),
then add and edit records and make sure everything went fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:53:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:53:22 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-5cLZUkNBIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:53:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:53:24 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-sNxmowDYON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51140&action=edit
Bug 16315 - OPAC Shelfbrowser doesn't display the full title

This patch adds subtitle information to the display of titles in the
OPAC's shelf browser.

To test, apply the patch and make sure OPACShelfBrowser is enabled.

- View the detail page for any title in the OPAC which has items.
- Click the "Browse shelf" link next to any item in the holdings table.
- The titles in the shelf browser should display with all subtitle
  information as defined in Keywords to MARC mapping.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 15:53:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 13:53:28 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-t75yQHpHRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:00:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:00:06 +0000
Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new
 style (see also 10480)
In-Reply-To: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13438-70-4ijPGvdkbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438

--- Comment #11 from Magnus Enger <magnus at libriotech.no> ---
Yes, there is a problem with 008. My plan was to fix this here:
Bug 10997 - Modernize value_builders for NORMARC
but I have not found the time yet...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:00:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:00:21 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-bAJv1vNfcK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51134|0                           |1
        is obsolete|                            |

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 51141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51141&action=edit
Bug 16429 - Going to circulation from notice triggers may change logged in
branch

If you edit notice triggers and then use the "Checko out" tab from the
top bar, you may change your logged in library by accident!

Test Plan:
1) Disable the system preference CircAutocompl
2) Go to the notice triggers
3) Select the triggers for a library other than the one you logged in as
4) Use the "Check out" tab at the top to check out to a patron
5) Note your logged in branch has changed ( you'll need to refresh the
    page if the check out search took you directly to one patron ).
6) Apply this patch
7) Repeat steps 2-4
8) Note the branch no longer changes

Tested with both patches applied. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Heather Braum <hbraum at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:00:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:00:27 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-9zWCnjeAdu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51135|0                           |1
        is obsolete|                            |

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 51142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51142&action=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Heather Braum <hbraum at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:01:51 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-jX3mFtRaC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:01:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:01:53 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-25ObTrM602@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45327|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51143&action=edit
Bug 15194 - Drop-down menu 'Actions' has problem in 'Saved reports' page with
language bottom bar

This patch changes the direction of the "actions" menu on the saved
reports page so that it popup up instead of down.

To test, apply the patch and go to Reports -> Saved reports.

- Click the "Actions" menu for any report and confirm that the menu
  displays above the button instead of below it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:04:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:04:57 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-OOvc2Sy3Jq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51044|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51144&action=edit
Bug 16400: Let's hack the fixFloat plugin to fix our needs

On comment bug 11088 comment 2, Owen explained the problem with the
fixFloat toolbar. Since we have a hidden div, the plugin does not manage
to place the toolbar correctly.
In order to make it work, this patch adds some changes to the plugin to
add the ability to define our own offset.
When the div is extended (+, filteraction_on), the offset should be
updated to move the toolbar. Same when the div is folded (-,
filteraction_off)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:05:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:05:00 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-3Akm1Ii7u0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51145&action=edit
Bug 16400: Reintroduce the floating class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:07:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:07:25 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-93l78vGS1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #5)
> I'm having some problems with this patch:
> 
> - It needs to be rebased (although I think I was able to correctly fix the
> merge problems for testing).

Done.

> - In my tests the toolbar doesn't "stick' to the top of the viewport because
> it has a margin on it.
> - When it is floating, the toolbar isn't styled like it is on other pages
> without this patch. There is a "floating" class which isn't getting added.

Last patch reintroduces the floating class.

> - It breaks other instances of the floating toolbar. I'm getting a JS error
> on the cataloging page, for instance.

Fixed, I have updated the second patch.

> I'm not sure why, but having only "save" and "cancel" in the toolbar doesn't
> feel right to me. But I agree that we need to be consistent, and I agree
> that this page really needs some form of always-visible save button.

As I said, the patches are here for discussion.
I have understood from the discussion on bug 11088 that it's what you needed
but you did not manage to implement it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:13:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:13:31 +0000
Subject: [Koha-bugs] [Bug 15254] Koha/Plack runs in endless loop if mysql is
	down
In-Reply-To: <bug-15254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15254-70-DfSOhEgbe2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15254

Wolfram Schneider <wosch at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Wolfram Schneider <wosch at freebsd.org> ---
I upgraded koha-common to 3.22.06 and the endless loop is gone. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:29:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:29:42 +0000
Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16349-70-N9cQ3hf3pS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Places that would make sense (I think) are

1. the main page, maybe under the "try it now" button, something like

Introducing Koha 3.22

[Try it now]

Currently supported branches:
3.22 (stable), latest version 3.22.x
3.20 (oldstable), latest version 3.20.x
3.18, latest version 3.18.x

I don't know if we could automatically get the latest version from somewhere,
because you probably don't want to change that manually every month, but it
would be nice to display it.

or

2. the download page, under "Get Koha", instead of the link to the wiki that
does not really explain anything related to currently supported versions.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:32:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:32:06 +0000
Subject: [Koha-bugs] [Bug 16430] Mainpage.pl dies if library is not set
In-Reply-To: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16430-70-pUWdErfvBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate, did you fix the sysprefs.sql file before? See bug 16418

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:33:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:33:14 +0000
Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure()
 "unsafe" variant for better performance
In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16365-70-z5Tjl5z8Mn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16431

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:33:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:33:14 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-FeXis6Luxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16365

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:38:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:38:37 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-bVi6cFynQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16424


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424
[Bug 16424] Advanced editor reverts records back to Default framework
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:38:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:38:37 +0000
Subject: [Koha-bugs] [Bug 16424] Advanced editor reverts records back to
 Default framework
In-Reply-To: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16424-70-P8EQAxvMjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |unspecified
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|minor                       |major
         Depends on|                            |11559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559
[Bug 11559] Professional cataloger's interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:40:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:40:55 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-zq3IEiA5yH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:40:57 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-eT4c6KBSjo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51106|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51146&action=edit
Bug 16418: Remove duplicate of EnhancedMessagingPreferencesOPAC

Test plan:
  mysql < installer/data/mysql/sysprefs.sql
should work

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:41:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:41:54 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-qB2b7XNd86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for the 16.05 release!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:44:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:44:03 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-c8LcyEJO9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for the 16.05 release!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:44:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:44:07 +0000
Subject: [Koha-bugs] [Bug 15802] The system will not allow me to return any
	books
In-Reply-To: <bug-15802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15802-70-U3UG7duF9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15802

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:51:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:51:42 +0000
Subject: [Koha-bugs] [Bug 16432] New: When you delete an item type the
 system preference "item-level_itypes" is not considered
Message-ID: <bug-16432-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16432

            Bug ID: 16432
           Summary: When you delete an item type the system preference
                    "item-level_itypes" is not considered
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: christophe.croullebois at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

i.e if item-level_itypes is on "bibio record" and if you have in items.itype an
item type you want to delete via itemtypes.pl you can't do that.
And you can't change this via the interface.
The better way would be that Koha do check only in the good table depending on
the system preference to allow the delete.
I will check if it is also in master.
I will propose a patch.
Thx.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:59:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:59:30 +0000
Subject: [Koha-bugs] [Bug 16397] Unable to delete audio alerts
In-Reply-To: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16397-70-xa1f0YwuER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16397

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05! Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:59:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:59:31 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-d4pOHs2oUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:59:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:59:33 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-PToPQy1Ia2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51123|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51147&action=edit
Bug 16426: Add tests for ModMember - do not update userid

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 16:59:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 14:59:39 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-ct9faA5hAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51124|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51148&action=edit
Bug 16426: follow-up of bug 15840 - correctly manage userid while inserting
patrons

Bug 15840 tried to fix a bug but makes things more complicated than it
was before.
If an userid is not provided for 1 or more rows of the csv file, it
should not be updated. However, if a userid is provided and it already
used by an other patron, the import should fail for this row (but not
crash!).

Test plan:
0/ Create a patron with a userid=your_userid
1/ Use the import patron tool to update this userid
=> userid should have been updated
2/ Update another data and do not provide the userid
=> data should have been updated and not the userid
3/ Update another data and provide the userid, but set it to an empty
string, or '0'
=> data should have been updated and not the userid
4/ Update another patron, and set userid=your_userid
=> Update should fail and an error whouls be displayed ("already used by
another patron")

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:00:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:00:58 +0000
Subject: [Koha-bugs] [Bug 16433] New: Patron import tool warning on
 duplicate card number is unclear
Message-ID: <bug-16433-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16433

            Bug ID: 16433
           Summary: Patron import tool warning on duplicate card number is
                    unclear
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If I am matching on userid, and import a patron with no userid in the file but
the cardnumber is already used the warning says "Cardnumber ###### is not a
valid cardnumber"  
It would be clearer if it said 'this cardnumber is already used'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:01:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:01:24 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-8CTfyH7onq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51116|0                           |1
        is obsolete|                            |

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51149&action=edit
[SIGNED-OFF] Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout

This patch adjusts batch.t so it matches the use of datatables on the
'Manage staged records' page, and small layout changes already fixed
on search_utf8.t.

The tests are slightly modified so they actually test interesting stuff.
Some were passing only because an undefined value was passed.

To test:
- On master, run
  $ prove t/db_dependent/www/batch.t
=> FAIL: Tests fail notably
- Apply the patch
- Run:
  $ prove t/db_dependent/www/batch.t
=> SUCCESS: Notice tests now pass.
- Sign off :-D

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:01:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:01:32 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-zr165TwVrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51117|0                           |1
        is obsolete|                            |

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51150&action=edit
[SIGNED-OFF] Bug 16423: (followup) Add more tests

On fixing this tests, we retrieved the JSON data for the datatable used on
the 'Manage staged records' page. It would be cool to check the data it
carries makes sense.

To test:
- Run t/db_dependent/www/batch.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

All test pass
prove t/db_dependent/www/batch.t
t/db_dependent/www/batch.t .. ok
All tests successful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:01:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:01:54 +0000
Subject: [Koha-bugs] [Bug 16434] New: Patron import tool does not warn when
 username exists and a new one is created
Message-ID: <bug-16434-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16434

            Bug ID: 16434
           Summary: Patron import tool does not warn when username exists
                    and a new one is created
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If I am mathching on cardnumber and include an existing username in the file I
am not warned, but the username is replaced with a generated one
(surname.firstname) - I think there should be a warning since the username
doesn't match the submitted data, or that line should fail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:01:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:01:59 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-04D9GJExWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:02:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:02:56 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-UBwzYpefDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #5)
> This seems to be working well, two questions:
moving these to separate bug reports as they were present before 15840

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16433

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16434

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:05:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:05:29 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-ZMVEakV8es@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.04!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:06:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:06:18 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-M7zYIEqdpd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:06:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:06:20 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-OkyT6r9otq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51149|0                           |1
        is obsolete|                            |
  Attachment #51150|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51151&action=edit
Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout

This patch adjusts batch.t so it matches the use of datatables on the
'Manage staged records' page, and small layout changes already fixed
on search_utf8.t.

The tests are slightly modified so they actually test interesting stuff.
Some were passing only because an undefined value was passed.

To test:
- On master, run
  $ prove t/db_dependent/www/batch.t
=> FAIL: Tests fail notably
- Apply the patch
- Run:
  $ prove t/db_dependent/www/batch.t
=> SUCCESS: Notice tests now pass.
- Sign off :-D

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:06:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:06:24 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-xs8OEEd0rK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51152&action=edit
Bug 16423: (followup) Add more tests

On fixing this tests, we retrieved the JSON data for the datatable used on
the 'Manage staged records' page. It would be cool to check the data it
carries makes sense.

To test:
- Run t/db_dependent/www/batch.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

All test pass
prove t/db_dependent/www/batch.t
t/db_dependent/www/batch.t .. ok
All tests successful.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:06:35 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-O34aZKBYCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:07:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:07:15 +0000
Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576
 bytes) are not searchable.
In-Reply-To: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15399-70-Y8n9VgmJTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
(In reply to Barton Chittenden from comment #0)
> Created attachment 45852 [details]
> Test file for import.

Thank you for providing a clear test plan.
This bug is affecting us and will hit our serials department hard soon.

I am looking forward to ElasticSearch as a fix, but maybe this can be
circumvented simply by cutting "extra" marc subfields from items when indexing.

Looks like we need to shift our priorities :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:16:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:16:53 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-9JTkYg7hX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:16:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:16:55 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-VEABn9Jf3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51153&action=edit
Bug 16325: Add a test for SearchSuggestions when searching for STATUS=''

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:16:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:16:58 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-IdPvIAvIgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51154&action=edit
Bug 16325: Do not return all suggestions if search for STATUS=''

This is a quick and dirty way to fix a bad bug in a messy area.
The "unknown status" tab in the suggestions table display all the
suggestions. It should only display suggestions with a STATUS=''

Test plan:
- Create some suggestions
- Go to Home > Acquisitions > Suggestions management
- Edit some suggestions and give them different status,
e.g. accepted, rejected, pending.
- Verify that they appear in the tabs as appropriate
- Edit one suggestion, set "Mark selected as" to --Choose a status--
=> Without this patch: New tab "Status unknown" containing all
suggestions
=> With this patch: tab contains only suggestions with "Unknown status"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:17:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:17:16 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-5RgU7PaqA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|16322                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322
[Bug 16322] Translatability: "Unknown" in suggestion/suggestion.pl not
translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:17:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:17:16 +0000
Subject: [Koha-bugs] [Bug 16322] Translatability: "Unknown" in
 suggestion/suggestion.pl not translatable
In-Reply-To: <bug-16322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16322-70-aGDj4hrmiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16325                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325
[Bug 16325] Suggestions: Tab "Status unknown" contains all suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:18:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:18:52 +0000
Subject: [Koha-bugs] [Bug 16369] Clean up and improve plugins template
In-Reply-To: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16369-70-jYnpnRQBO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:20:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:20:23 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-zbEVRpPi1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51155&action=edit
Bug 16423: [QA Follow-up] Remove $opac

It is not used. And even may raise an uninitialized warnings.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Test still passes :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:22:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:22:23 +0000
Subject: [Koha-bugs] [Bug 16404] Fix Circulation/Branch.t (tests 8-11)
In-Reply-To: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16404-70-FkenkrTyLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05! Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:23:00 +0000
Subject: [Koha-bugs] [Bug 16273] Prevent selfregistration from printing the
 borrower password and filling the logging form
In-Reply-To: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16273-70-3EmU9pkkLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:23:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:23:02 +0000
Subject: [Koha-bugs] [Bug 16273] Prevent selfregistration from printing the
 borrower password and filling the logging form
In-Reply-To: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16273-70-oOhogPYBIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50608|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51156&action=edit
Bug 16273: Add the new pref PatronSelfRegistrationPrefillForm

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:23:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:23:39 +0000
Subject: [Koha-bugs] [Bug 16396] Update package version for master packages
In-Reply-To: <bug-16396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16396-70-kkgcqWpmuf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16396

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:23:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:23:54 +0000
Subject: [Koha-bugs] [Bug 16273] Prevent selfregistration from printing the
 borrower password and filling the logging form
In-Reply-To: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16273-70-ZuNnj9kO4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51156|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51157&action=edit
Bug 16273: Add the new pref PatronSelfRegistrationPrefillForm

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:24:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:24:04 +0000
Subject: [Koha-bugs] [Bug 16273] Prevent selfregistration from printing the
 borrower password and filling the logging form
In-Reply-To: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16273-70-SfHaXO7vZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50609|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51158&action=edit
Bug 16273: Add the ability not to display the login details for newly
registered patrons

When a new patron registers, the confirmation page is displayed with
login details (login, password, cardnumber) and the login form is
prefilled.
In the case of public computer, for security reasons that should not
appear, patrons might forget to close the window.

Test plan:
1/ Set PatronSelfRegistrationPrefillForm on
2/ Register a new patron
=> The login details should not be displayed and the login form should
not be prefilled.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:26:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:26:31 +0000
Subject: [Koha-bugs] [Bug 16403] Fix Holds.t (tests 9 and 39)
In-Reply-To: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16403-70-k7ozsoRg57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05. Thanks Marcel and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:29:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:29:17 +0000
Subject: [Koha-bugs] [Bug 16407] Fix Koha_borrower_modifications.t
In-Reply-To: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16407-70-LKLdkoybgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16407

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Marcel and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:31:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:31:50 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-9aPT2Pvtub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:34:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:34:26 +0000
Subject: [Koha-bugs] [Bug 16423] Fix t/db_dependent/www/batch.t so it
	matches new layout
In-Reply-To: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16423-70-0soL29eKGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Marcel, Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:34:38 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-GApV3kh34k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51153|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51159&action=edit
Bug 16325: Add a test for SearchSuggestions when searching for STATUS=''

Test fails as expected without second patch and passes OK with second patch.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:36:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:36:09 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-Di6LmteFSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51154|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 51160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51160&action=edit
Bug 16325: Do not return all suggestions if search for STATUS=''

This is a quick and dirty way to fix a bad bug in a messy area.
The "unknown status" tab in the suggestions table display all the
suggestions. It should only display suggestions with a STATUS=''

Test plan:
- Create some suggestions
- Go to Home > Acquisitions > Suggestions management
- Edit some suggestions and give them different status,
e.g. accepted, rejected, pending.
- Verify that they appear in the tabs as appropriate
- Edit one suggestion, set "Mark selected as" to --Choose a status--
=> Without this patch: New tab "Status unknown" containing all
suggestions
=> With this patch: tab contains only suggestions with "Unknown status"

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:38:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:38:05 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-pVlUbGNSYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:40:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:40:05 +0000
Subject: [Koha-bugs] [Bug 16384] When canceling 'edit basket',
 return to basket summary if you came from there
In-Reply-To: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16384-70-xmGwIUqoSI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16384

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:41:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:41:38 +0000
Subject: [Koha-bugs] [Bug 16398] Keep expanded view after clearing the
	search form
In-Reply-To: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16398-70-A6sVnQeghm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:45:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:45:30 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-tay4RGG2lp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |hector.hecaxmmx at gmail.com

--- Comment #7 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi Owen

Tested with es-Es language still deployed the same way

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:46:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:46:31 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-aiqu9Skd8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51143|0                           |1
        is obsolete|                            |

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Created attachment 51161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51161&action=edit
Bug 15194 - Drop-down menu 'Actions' has problem in 'Saved reports' page with
language bottom bar

This patch changes the direction of the "actions" menu on the saved
reports page so that it popup up instead of down.

To test, apply the patch and go to Reports -> Saved reports.

- Click the "Actions" menu for any report and confirm that the menu
  displays above the button instead of below it.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:47:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:47:50 +0000
Subject: [Koha-bugs] [Bug 16408] Fix UsageStats.t
In-Reply-To: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16408-70-ExrAVeynxF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:48:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:48:15 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-2colwRi1OU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
(In reply to H?ctor Eduardo Castro Avalos from comment #7)
> Hi Owen
> 
> Tested with es-Es language still deployed the same way

Hi H?ctor, did you do a translate?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:48:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:48:50 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-4dEdEae0hd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:49:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:49:54 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-Kf6TW5gjOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #10 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Marc V?ron from comment #8)
> Created attachment 51161 [details] [review]
> Bug 15194 - Drop-down menu 'Actions' has problem in 'Saved reports' page
> with language bottom bar
> 
> This patch changes the direction of the "actions" menu on the saved
> reports page so that it popup up instead of down.
> 
> To test, apply the patch and go to Reports -> Saved reports.
> 
> - Click the "Actions" menu for any report and confirm that the menu
>   displays above the button instead of below it.
> 
> Signed-off-by: Marc V?ron <veron at veron.ch>

Hi Marc

I still don't see all options in last drowp-down menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:50:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:50:32 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-WceIG1D6g6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

--- Comment #11 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Marc V?ron from comment #9)
> (In reply to H?ctor Eduardo Castro Avalos from comment #7)
> > Hi Owen
> > 
> > Tested with es-Es language still deployed the same way
> 
> Hi H?ctor, did you do a translate?

Yes, with Spanish

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 17:54:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 15:54:13 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-rTnxjlsMi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

--- Comment #12 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51162&action=edit
drop-down-menu-spanish

Hi Marc

I don't see the option "Delete" -> "Borrar" in spanish

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:25:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:25:00 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-24eCOu7wGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:26:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:26:12 +0000
Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in
 record detail view
In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16427-70-Qt07kpAFMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

--- Comment #2 from verolencinas <verolencinas at yahoo.com.ar> ---
Katrin, you are right. It was the OPAC that includes the magnifying glass icon.
This improvement will be very useful to distinguish between access points
linked to authority records and other without authority record. In my library
for example we have a lot of records that include subjects linked to authority
records and subjects without authority record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:38:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:38:35 +0000
Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when
 using HTTPS in Koha.
In-Reply-To: <bug-11358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11358-70-cJjiy9SxKH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Fixed by Bug 14571

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:40:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:40:52 +0000
Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a
 'no-image' class, in the staff client
In-Reply-To: <bug-13597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13597-70-p1nZKAG06E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:40:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:40:53 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-Am8WqeatIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:40:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:40:56 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-T3jNTJzZyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51140|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51163&action=edit
[SIGNED-OFF] Bug 16315 - OPAC Shelfbrowser doesn't display the full title

This patch adds subtitle information to the display of titles in the
OPAC's shelf browser.

To test, apply the patch and make sure OPACShelfBrowser is enabled.

- View the detail page for any title in the OPAC which has items.
- Click the "Browse shelf" link next to any item in the holdings table.
- The titles in the shelf browser should display with all subtitle
  information as defined in Keywords to MARC mapping.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Adding 245a and c as 'subtitle' in Keywords to Marc make them
show on shelf browser.
No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 18:45:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 16:45:32 +0000
Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in
 record detail view
In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16427-70-TjLPxbFfys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes, I think it woudl be an useful enhancement. For the staff side I think it
would not be a big problem to point to the MARC view, even if a prettier view
would be nice :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 19:17:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 17:17:06 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-MMO01UN3CX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 19:17:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 17:17:09 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-EqCCjcTySm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51164&action=edit
Bug 16159 - guarantor section missing ID on patron add form

In the patron entry form template most <fieldset> and <legend> tags have
unique ids. This patch adds ids to fieldsets and legends which lack
them.

To test apply the patch and view the patron entry form. There should be
no visual changes. There should be no HTML validation errors triggered
by this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 19:19:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 17:19:39 +0000
Subject: [Koha-bugs] [Bug 8373] opacheader should not show in print layout
In-Reply-To: <bug-8373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8373-70-WpP4DoYin1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 20:26:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 18:26:41 +0000
Subject: [Koha-bugs] [Bug 16435] New: add possibility to set the contents of
 a virtual list
Message-ID: <bug-16435-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16435

            Bug ID: 16435
           Summary: add possibility to set the contents of a virtual list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,


it would be nice to choose which marc field you want to display in the list.

This would create customized lists for periodical for example. We need to
display marc field that do not appear to bibliographic records .

Perhaps a tool to create template Marc would be the solution.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 20:58:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 18:58:44 +0000
Subject: [Koha-bugs] [Bug 16436] New: Allow action logs to be logged to the
	koha log file
Message-ID: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

            Bug ID: 16436
           Summary: Allow action logs to be logged to the koha log file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It would be very useful if it were possible to log actions to a log file as
well as to the database. With Koha::Logger we can give the option of sending
those logs to a separate file, but by default they can go to the standard log
files. They should also be off by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:02:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:02:02 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-qxSEnhpLHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:02:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:02:04 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-gcxt7rQWvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51165&action=edit
Bug 16436 - Allow action logs to be logged to the koha log file

Test Plan:
1) Ensure that your Koha::Logger configuration is in good working order
2) Apply this patch
3) Modify the first line of your log4perl.conf file from:
    log4perl.logger.intranet = WARN, INTRANET
   to
    log4perl.logger.intranet = INFO, INTRANET
4) Change a system preference setting
5) Note the new line in your log file!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:02:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:02:54 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-2gc0ptNZ6p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:06:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:06:24 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-ec6eAKr2uR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51165|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51166&action=edit
Bug 16436 - Allow action logs to be logged to the koha log file

Test Plan:
1) Ensure that your Koha::Logger configuration is in good working order
2) Apply this patch
3) Modify the first line of your log4perl.conf file from:
    log4perl.logger.intranet = WARN, INTRANET
   to
    log4perl.logger.intranet = INFO, INTRANET
4) Change a system preference setting
5) Note the new line in your log file!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:16:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:16:27 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-Xkj3F8279N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51166|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51167&action=edit
Bug 16436 - Allow action logs to be logged to the koha log file

Test Plan:
1) Ensure that your Koha::Logger configuration is in good working order
2) Apply this patch
3) Modify the first line of your log4perl.conf file from:
    log4perl.logger.intranet = WARN, INTRANET
   to
    log4perl.logger.intranet = INFO, INTRANET
4) Change a system preference setting
5) Note the new line in your log file!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:31:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:31:01 +0000
Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual
 fine is wrong
In-Reply-To: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14605-70-zmgW9TWv3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41218|0                           |1
        is obsolete|                            |

--- Comment #8 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 51168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51168&action=edit
Bug 14605 - Corrects the individual fine's description

When paying a fine, the description is built out of the borrower's type and
title, instead of the actual fine's description.

STEPS:
1) in the staff, go to a user with a fine to pay.
   a) if none, go to a user and Fines>>"Create manual invoice" with a
distinctive description.
2) In Fines>>Pay fines, click the "Pay" button on the line of the fine.
3) This will take you a "Pay an individual fine" screen, where the description
will look like "Staff Mrs", for the category and title of the borrower.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:34:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:34:48 +0000
Subject: [Koha-bugs] [Bug 16437] New: Automatic item modifications by age
	needs prettying
Message-ID: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

            Bug ID: 16437
           Summary: Automatic item modifications by age needs prettying
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
               URL: /cgi-bin/koha/tools/automatic_item_modification_by_age
                    .pl
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This page seems very confusing. There is no 'new' button, just edit and
conditions and substitutions are confusing in terms of language. I think this
page could do with the Owen magic touch :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 21:36:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 19:36:54 +0000
Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual
 fine is wrong
In-Reply-To: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14605-70-AWfkizcLin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #9 from Blou <philippe.blouin at inlibro.com> ---
I rebased.
Regarding the "issues": The biblio's title was not part of the previous
functionality, and I don't think it's right anyway, since I presume fines can
be for things other than associated to a biblio.

As for correcting the current DB, that's feasible, but a bit dodgy.  I would
really fear to replace perfectly valid subjects (corrected manually by the
employee), and validating what is right or not might be a bit too much work for
what it's worth.  This patch is here to correct make life easier in the future,
but it's not correcting a major bug that's worth a big discussion on "How to
fix the current data", don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 22:11:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 20:11:49 +0000
Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when
 handling Serial Items. Show enumerations for Serial Items in the circ- and
 member-modules.
In-Reply-To: <bug-13430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13430-70-upnfVZu6EF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14668

--- Comment #6 from Blou <philippe.blouin at inlibro.com> ---
Olli-Antti, any plan to fix this patch?

Our first attemp at #14668 included changes you're making for this one.  We cut
them but are hoping this one goes through.  Please let us know if you do not
plan to move ahead.  

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 22:11:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 20:11:49 +0000
Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page
 and the patron's opac checkout summary
In-Reply-To: <bug-14668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14668-70-ZTINL7xL5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13430

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 22:47:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 20:47:35 +0000
Subject: [Koha-bugs] [Bug 16438] New: Use Font Awesome icons in batch record
 deletion table
Message-ID: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

            Bug ID: 16438
           Summary: Use Font Awesome icons in batch record deletion table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: hector.hecaxmmx at gmail.com
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Add Font Awesome icons in table for tables in authorities and bib records in
batch record deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 22:52:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 20:52:27 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch record
	deletion table
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-hQxVhT0lOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 22:52:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 20:52:29 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch record
	deletion table
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-KmdHV82hE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51169&action=edit
Bug 16438: Use Font Awesome icons in batch record deletion table

Add Font Awesome icons in table for tables in authorities and bib records
in batch record deletion

To test:
1- Go to Tools > Batch record deletion
2- Try to delete bib and authorities records
3- Look the table presented
4- Apply patch and repeat steps 1 to 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 23:46:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 21:46:36 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch record
	deletion table
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-oA9x69ff0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51169|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51170&action=edit
Bug 16438: Use Font Awesome icons in batch templates

Add Font Awesome icons in tables in authorities and bib records
in batch item/record deletion, modification templates

To test:
1- Go to Tools > Batch item/record deletion/modification
2- Try to delete/modify itmes/bib and authorities records
3- Look all tables presented and notice about the new icons in Select all
   Clear all, etc.
4- Apply patch and repeat step 1 to 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May  3 23:48:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 21:48:03 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-UPa9QHRjKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Use Font Awesome icons in   |Use Font Awesome icons in
                   |batch record deletion table |batch templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 00:09:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 22:09:27 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-MhNsXGl8vo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 00:09:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 May 2016 22:09:30 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-IxMYKfcEvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51170|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51171&action=edit
[SIGNED-OFF] Bug 16438: Use Font Awesome icons in batch templates

Add Font Awesome icons in tables in authorities and bib records
in batch item/record deletion, modification templates

To test:
1- Go to Tools > Batch item/record deletion/modification
2- Try to delete/modify itmes/bib and authorities records
3- Look all tables presented and notice about the new icons in Select all
   Clear all, etc.
4- Apply patch and repeat step 1 to 3

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work, nice view.
No Errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 02:04:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 00:04:43 +0000
Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual
 fine is wrong
In-Reply-To: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14605-70-Ov9g7GXs5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Blou from comment #9)
> I rebased.
> Regarding the "issues": The biblio's title was not part of the previous
> functionality

That's correct.
It can be done, but I think in another bug.

> As for correcting the current DB, that's feasible, but a bit dodgy.
I don't know if it's possible, description in accountlines must be set
initially. A fee entry does not reference the original biblio.

I think that correct Status for this is Signed off, no problem if you need
another sign but it's already signed by Mirko.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 03:00:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 01:00:10 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-yy2Kdpx35p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 03:00:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 01:00:13 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-uH9iKj6BL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51172&action=edit
Bug 16386 - Replace the use of "onclick" from patron card creator templates

This patch removes the use of "onclick" from several patron card creator
templates. Events are defined instead in JavaScript.

Also changed:

- Patron search pop-up window is now slightly larger because I found it
  never quite large enough to prevent horizontal scrolling.
- Replaced "Borrower" with "Patron" in a couple of places.
- "Add" link in patron search pop-up is now styled as a Bootstrap
  button.
- Removed Bootstrap styles from some submit buttons.
- Some Font Awesome icons were made using the invalid element
  <icon></icon> instead of <i></i>. These are corrected.
- Fixed some other HTML validation errors.

To test, apply the patch and go to Tools -> Patron card creator.

- Choose New -> Card batch.
  - Click "Add patrons" and perform a search for patrons in the pop-up
    window.
  - Click the "Add" button. The corresponding borrowernumber should be
    added to the textarea in the parent window, and a message should
    appear at the top of the pop-up window confirming that the patron
    has been added. (Note: This patch fixes a version of Bug 13041 which
    prevented the "add" button from working on patrons whose name
    include an apostrophe).
  - In the parent page, in the list of patrons you added to the batch,
    confirm that clicking the "Delete" link triggers a confirmation
    dialog. Test both confirming and canceling.
  - Confirm that clicking the "Export" button next to an individual
    patron triggers a modal window.
    - In the export window, confirm that the "Cancel" link works to
      close the modal.
    - Click the "Export" button again and then the "Export" button in
      the modal.
      - Test that the "Done" button works to close the modal.
- Choose Manage -> Card batches.
  - Test the "Delete" and "Export" buttons as described above.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 03:03:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 01:03:26 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-O3hpi7ztEk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16386

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 03:03:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 01:03:26 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-JtRywZBNaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13041

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:40:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:40:25 +0000
Subject: [Koha-bugs] [Bug 8966] Koha::Calendar::is_holiday truncates the date
In-Reply-To: <bug-8966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8966-70-KMfwF5HeGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8966

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
I just noticed that the Calendar.t uses a DateTime object with a timezone of
Europe/London. 

If we change the test to include the following,

my $dt = DateTime->new(
    month => 9,
    year => 2015,
    day => 6,
    hour => 12,
    minute => 00,
    second => 00,
    time_zone => 'America/Santiago',
);
my $calendar = Koha::Calendar->new(branchcode => "MAIN");
$calendar->is_holiday($dt);

We'll get a fatal error with the following message:

Invalid local time for date in time zone: America/Santiago

See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:40:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:40:49 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-zgbsgzF8gb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8966

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:40:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:40:49 +0000
Subject: [Koha-bugs] [Bug 8966] Koha::Calendar::is_holiday truncates the date
In-Reply-To: <bug-8966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8966-70-uffVYSCdfy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8966

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16376

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:55:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:55:15 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-bp4txbrj32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #30 from David Cook <dcook at prosentient.com.au> ---
I don't think this patch is actually a good idea... you're only sometimes - and
very unexpectedly - making a DateTime object with a floating timezone. 

Consider the following from DateTime's perldoc
(http://search.cpan.org/~drolsky/DateTime-1.26/lib/DateTime.pm#):

"Floating DateTimes

The default time zone for new DateTime objects, except where stated otherwise,
is the "floating" time zone. This concept comes from the iCal standard. A
floating datetime is one which is not anchored to any particular time zone. In
addition, floating datetimes do not include leap seconds, since we cannot apply
them without knowing the datetime's time zone.

The results of date math and comparison between a floating datetime and one
with a real time zone are not really valid, because one includes leap seconds
and the other does not. Similarly, the results of datetime math between two
floating datetimes and two datetimes with time zones are not really comparable.

If you are planning to use any objects with a real time zone, it is strongly
recommended that you do not mix these with floating datetimes."

--

I think it would be smarter to actually review where we're using timezones and
re-read
http://search.cpan.org/~drolsky/DateTime-1.26/lib/DateTime.pm#How_DateTime_Math_Works. 

--

Another idea would be to use DateTime->ymd() instead of DateTime->truncate()
(http://search.cpan.org/~drolsky/DateTime-1.26/lib/DateTime.pm#$dt->ymd(_$optional_separator_),_$dt->mdy(...),_$dt->dmy(...)),
so that you're actually just comparing the date portion of a datestamp rather
than possibly creating an invalid local time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:55:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:55:38 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-uyyiq8gegq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16376

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:55:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:55:38 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-4uJulWSAQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12669

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 04:58:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 02:58:33 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-QU3HZCxEub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
Except ymd() probably wouldn't work for sub single_holidays or sub
exception_holidays because they use DateTime::Set I think... so that option is
probably no good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 05:49:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 03:49:21 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-P9hXs1onZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #5 from Mason James <mtj at kohaaloha.com> ---
Created attachment 51173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51173&action=edit
Bug 10756 - Carousel Display of New Titles on OPAC home page

add ContentFlow dir

 http://www.jacksasylum.eu/ContentFlow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 05:50:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 03:50:07 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-5sf0q1pgKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #6 from Mason James <mtj at kohaaloha.com> ---
Created attachment 51174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51174&action=edit
Bug 10756 - Carousel Display of New Titles on OPAC home page

test plan...
1/ import some bibs into your database for testing (important)

 $ wget http://www.loc.gov/catdir/cpso/RDAtest/extra_bib_marc.zip
 $ unzip extra_bib_marc.zip
 $ bulkmarcimport.pl -b -m ISO2709 -file ./formal_extra_all_final.bib

2/ apply patches

3/ execute atomic update to add syspref and 'Carousel' table

 $ perl ./installer/data/mysql/atomicupdate/Bug-10756-carousel.pl

4/ open OPAC homepage in web-browser, observe no change

5/ set 'OpacCarousel' syspref to 'display'

6/ open OPAC homepage in web-browser, observe a new carousel :0)

extra QA tests...

7/ run 5 carousel tests
 $ prove ./t/db_dependent/Carousel.t

8/ run qa-tool on patchset
 $ qa -c 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 05:50:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 03:50:47 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-kRFrL6akp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 06:05:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 04:05:43 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-fKHhF2wS4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
QA note: patchset applied to 68dbe84 'Bug 14632: Add Copyright for the Koha'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 06:50:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 04:50:53 +0000
Subject: [Koha-bugs] [Bug 16392] Tips & Tricks?
In-Reply-To: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16392-70-yrcMCHVNZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16392

Arslan Farooq <arslanone at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arslanone at gmail.com

--- Comment #3 from Arslan Farooq <arslanone at gmail.com> ---
Hi guys,

I can do this. Take the responsibility I mean. I'll talk to Liz for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 07:52:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 05:52:53 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-STmMv5sRek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
David: I recall falling back to floating timezone for making calculations with
far future dates like an expiry in 9999 or so.
If you would use a normal timezone, you will have major performance issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 08:03:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 06:03:02 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-9nSXsWqDU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #8 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Mason James from comment #7)
> QA note: patchset applied to 68dbe84 'Bug 14632: Add Copyright for the Koha'

That bug number and title does not match up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 08:28:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 06:28:40 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-tVh22hH1vV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 08:28:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 06:28:43 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-8iupLEz6IL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51173|0                           |1
        is obsolete|                            |
  Attachment #51174|0                           |1
        is obsolete|                            |

--- Comment #9 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 51175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51175&action=edit
Bug 10756 - Carousel Display of New Titles on OPAC home page

add ContentFlow dir

 http://www.jacksasylum.eu/ContentFlow

Signed-off-by: Magnus Enger <magnus at libriotech.no>
Comment on the other patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 08:28:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 06:28:58 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-TDB18USiFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #10 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 51176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51176&action=edit
Bug 10756 - Carousel Display of New Titles on OPAC home page

test plan...
1/ import some bibs into your database for testing (important)

 $ wget http://www.loc.gov/catdir/cpso/RDAtest/extra_bib_marc.zip
 $ unzip extra_bib_marc.zip
 $ bulkmarcimport.pl -b -m ISO2709 -file ./formal_extra_all_final.bib

2/ apply patches

3/ execute atomic update to add syspref and 'Carousel' table

 $ perl ./installer/data/mysql/atomicupdate/Bug-10756-carousel.pl

4/ open OPAC homepage in web-browser, observe no change

5/ set 'OpacCarousel' syspref to 'display'

6/ open OPAC homepage in web-browser, observe a new carousel :0)

extra QA tests...

7/ run 5 carousel tests
 $ prove ./t/db_dependent/Carousel.t

8/ run qa-tool on patchset
 $ qa -c 2

Signed-off-by: Magnus Enger <magnus at libriotech.no>
Followed the test plan, everything worked as expected. The front page
displays a nice coverflow widget.

More parameters to control the widget would be nice, but that could
be added later.

On first running this I got a nasty 500 error: "Can't call method
"is_valid" on an undefined value at
/home/magnus/scripts/kohaclone/Koha/Carousel.pm
line 128." But I think I found a cure for that and will propose a
followup patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 08:29:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 06:29:03 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-ZFlbW58LUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 09:07:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 07:07:08 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-E1qBk22tNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #11 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 51177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51177&action=edit
Bug 10756 - Carousel Display - Followup

On first testing this I got a 500 error saying "Can't call method
"is_valid" on an undefined value at
/home/magnus/scripts/kohaclone/Koha/Carousel.pm
line 128." This was caused by a record with an ISBN of "979-10-91414-01-2".
The relevant code looks like this:
    my $isbn_obj = Business::ISBN->new($ii);
    my $isbn10;
    $isbn10 = $isbn_obj->as_isbn10;
    if ( $isbn10->is_valid() ) {...}
The documentation for Business::ISBN::as_isbn10 says: "Returns a new
ISBN object. If the object is already ISBN-10, this method clones it.
If it is an ISBN-13 with the prefix 978, it returns the ISBN-10
equivalent. For all other cases it returns undef." So for an ISBN that
starts with 979 like mine did, $isbn10 will be undef and we need to do
some extra checking before is_valid().

To test:
- Apply the first two patches on this bug and follow their test plan
- Make sure you have a new record with an ISBN that starts with 979
- Refresh the front page and observe the error
- Apply this patch
- Refresh the front page again and notice the absence of the error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 09:10:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 07:10:27 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-cxq1whamFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #12 from Magnus Enger <magnus at libriotech.no> ---
I have signed off the two original patches from Mason. As noted in the sign off
message I found a problem for 13 digit ISBNs that do not start with 978. The
third patch attempts to fix this. I think my patch needs a signoff, so I am
leaving this bug as "Needs Signoff".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 10:35:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 08:35:18 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-RWUHjgkUD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51164|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51178&action=edit
Bug 16159 - guarantor section missing ID on patron add form

In the patron entry form template most <fieldset> and <legend> tags have
unique ids. This patch adds ids to fieldsets and legends which lack
them.

To test apply the patch and view the patron entry form. There should be
no visual changes. There should be no HTML validation errors triggered
by this change.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 10:35:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 08:35:44 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-94T8kPoJV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 10:51:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 08:51:22 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-iANYKRiuUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 10:51:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 08:51:25 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-oiI0ZiQA4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50610|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51179&action=edit
Bug 16274: Add the new pref PatronSelfRegistrationLibraryList

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 10:52:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 08:52:28 +0000
Subject: [Koha-bugs] [Bug 16274] Make the selfregistration branchcode
 selection configurable
In-Reply-To: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16274-70-6oevCFZrHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16274

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50611|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51180&action=edit
Bug 16274: Limit the patron self registration to some libraries

Currently a patron can select a home library in the list of all
libraries defined in the system.
However some of these libraries might not accept self registration.
This patch adds a new pref to display only the allowed libraries.

Test plan:
0/ Apply the patch, do not fill the new pref
1/ Self register a new patron
=> All the libraries defined should be displayed in the "Home library"
dropwdown list
2/ Fill the pref PatronSelfRegistrationLibraryList with some of the
branchcode defined in the system
=> Self register a new patron and confirm that the dropdown list has
been filtered.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 11:22:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 09:22:58 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email
 already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-xMv3684FcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

--- Comment #5 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51181&action=edit
Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No errors

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 11:23:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 09:23:03 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-jb2kalKboF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

flittle <flittle at thedowns.avon.sch.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |flittle at thedowns.avon.sch.u
                   |                            |k

--- Comment #1 from flittle <flittle at thedowns.avon.sch.uk> ---
Hi, I have this issue also, trying to install koha on a fresh ubuntu 16.04
install, MySQL 5.7.12.

Same message in the web installer:

mysql: [Warning] Using a password on the command line interface can be
insecure. ERROR 1171 (42000) at line 1385: All parts of a PRIMARY KEY must be
NOT NULL; if you need NULL in a key, use UNIQUE instead

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 11:23:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 09:23:06 +0000
Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email
 already filled in borrowers.email
In-Reply-To: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16275-70-NSoj3fUgYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275

--- Comment #6 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51182&action=edit
Bug 16275: Do not allow a self registration with an existing email address

To avoid multiple registrations, it would be good to check the unicity
of the primary email address.
This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique.
If on, a patron will get "This email address already exists in our
database" if he try to register with an existing email address.

Test plan:
1/ Register a new patron with an email address
2/ Make an other registration using the same email address
=> With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be
allowed
=> With the pref off, no change should be noticed.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no errors.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 12:00:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 10:00:42 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
	log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-doUyl28JBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51167|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51183&action=edit
Bug 16436 - Allow action logs to be logged to the koha log file

Test Plan:
1) Ensure that your Koha::Logger configuration is in good working order
2) Apply this patch
3) Modify the first line of your log4perl.conf file from:
    log4perl.logger.intranet = WARN, INTRANET
   to
    log4perl.logger.intranet = INFO, INTRANET
4) Change a system preference setting
5) Note the new line in your log file!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 12:12:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 10:12:08 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically suppressing expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-iwFIictrpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

--- Comment #7 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Does not apply, there's a conflict on
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref. I'm not
sure what's the righte move to do? Fix the conflict and if everything's OK
sign?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 13:14:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 11:14:26 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-ahsMmXwDjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

--- Comment #6 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
In most places if there are no edifact vendors present the functionality gets
disabled. The main feature to control is probably the admin screens. A syspref
shouldnt be to turn it off but to enable it - I'll see if I can generate a
patch to add an enabling system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 13:23:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 11:23:05 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-tE1pMj3Y1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Mason:
Just wondering why you picked ContentFlow?
I once wrote something simple with jquery.jcarousel.min.js and just note that
this carousel is considerably larger (18K vs 264K?). BTW I am not saying that
we should use the other one :)
On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010? If
there is no further development(?), this might be a risk.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 13:50:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 11:50:03 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-IpmmpP304G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51112|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51184&action=edit
Bug 10171: (QA followup) Make search tests use the right form

This bug removed the search tab from the main search box, so the tests
that use /cgi-bin/koha/catalogue/search.pl for searching, should use
the advanced search box instead.

To test:
- Run
  $ prove t/db_dependent/www/search_utf8.t
=> FAIL: Several tests related to searching on the intranet interface fail.
- Apply the patch
- Run
  $ prove t/db_dependent/www/search_utf8.t
=> SUCCESS: Tests pass
- Be happy

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 14:04:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 12:04:15 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-YL0Uqq2maP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16386                   |
         Depends on|                            |16386


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386
[Bug 16386] Replace the use of "onclick" from patron card creator templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 14:04:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 12:04:15 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-o8V6XV9cvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13041
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=13041                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041
[Bug 13041] Can't add user as manager of basket if name includes a single quote
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 14:09:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 12:09:29 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-a6fUNyESQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #14 from Fr?d?ric Demians <frederic at tamil.fr> ---
I don't see the advantage of this implementation against Bywater plugin. I can
rather see disadvantages, including ContentFlow.js obsolescence (not updated
since 2010, when jQuery Flipster used by ByWater plugin is actively
maintained). Reading the code, I don't understand how GetRecentBibs generates
the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to
read/re-read this table each time the OPAC main page is loaded?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 14:44:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 12:44:23 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-gyXfNRAJpn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #7 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 51185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51185&action=edit
Proposed Patch

Patch to add the syspreference. Set to no the Edi related screens are hidden
from the admin page. Also removes the edifact messages link in acq.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:08:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:08:25 +0000
Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown
 parameter from opac-detail.tt
In-Reply-To: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15636-70-op8e6AmKLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50146|0                           |1
        is obsolete|                            |

--- Comment #10 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 51186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51186&action=edit
Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:21:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:21:18 +0000
Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown
 parameter from opac-detail.tt
In-Reply-To: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15636-70-fxKQ6Y1PT6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

--- Comment #11 from Blou <philippe.blouin at inlibro.com> ---
I rebased it.
Now, I've asked bouzid to find a way to reproduce it, but that's low on his
priority list.
As he said previously, the fix is just reproducing the same conditions for the
header as for the entries in the table.  No need of big research to imagine a
scenario where the unfixed code might break, even though it seems all of you
have been lucky so far :-)

So in that sense, I was under the hope this would go smoother...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:32:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:32:25 +0000
Subject: [Koha-bugs] [Bug 16383] Making Local Use sysprefs actions buttons
In-Reply-To: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16383-70-boPFAdPf4a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16383

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.04, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:33:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:33:15 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-efAmP9mbWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51177|0                           |1
        is obsolete|                            |

--- Comment #15 from Mason James <mtj at kohaaloha.com> ---
Created attachment 51187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51187&action=edit
Bug 10756 - Carousel Display - Followup

On first testing this I got a 500 error saying "Can't call method
"is_valid" on an undefined value at
/home/magnus/scripts/kohaclone/Koha/Carousel.pm
line 128." This was caused by a record with an ISBN of "979-10-91414-01-2".
The relevant code looks like this:
    my $isbn_obj = Business::ISBN->new($ii);
    my $isbn10;
    $isbn10 = $isbn_obj->as_isbn10;
    if ( $isbn10->is_valid() ) {...}
The documentation for Business::ISBN::as_isbn10 says: "Returns a new
ISBN object. If the object is already ISBN-10, this method clones it.
If it is an ISBN-13 with the prefix 978, it returns the ISBN-10
equivalent. For all other cases it returns undef." So for an ISBN that
starts with 979 like mine did, $isbn10 will be undef and we need to do
some extra checking before is_valid().

To test:
- Apply the first two patches on this bug and follow their test plan
- Make sure you have a new record with an ISBN that starts with 979
- Refresh the front page and observe the error
- Apply this patch
- Refresh the front page again and notice the absence of the error

Signed-off-by: Mason James <mtj at kohaaloha.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:33:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:33:26 +0000
Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning
 an item which is in a rotating collection
In-Reply-To: <bug-15564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15564-70-YiRPJg3ChH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.04, thanks Natasha, Alex!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:34:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:34:47 +0000
Subject: [Koha-bugs] [Bug 16016] Integrate sitemap.pl into the packages
In-Reply-To: <bug-16016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16016-70-nmwaP1Aopr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:36:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:36:25 +0000
Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url
 register when source $2 is uri
In-Reply-To: <bug-15555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15555-70-B23PkdmaTP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:43:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:43:38 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-4h4inJmBkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
(In reply to Marcel de Rooy from comment #13)
> Mason:
> Just wondering why you picked ContentFlow?

2 reasons, 
 1/ it's the carousel CALYX selected for production 3 years ago
 2/ it works well in responsive views, (others did not work)

> I once wrote something simple with jquery.jcarousel.min.js and just note
> that this carousel is considerably larger (18K vs 264K?). BTW I am not
> saying that we should use the other one :)
> On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> If there is no further development(?), this might be a risk.

I think it a great idea to offer multiple carousel options, 
but I left this extra functionality until after the patch was accepted

I plan to add other carousels to the feature, should the patch be accepted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:45:44 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-kAvyvoXRTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #33 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
I wonder if we could use utc internally and just use the local timezone to
convert user input and to present the date externally. We'd need to be fairly
vigorous in cleaning up the various vaguely different ways we currently treat
dates, cetainly when we're doing calculations we probably want to do them in a
common base as otherwise there's too many opportunities to fall into a given
timezone's black hole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:45:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:45:55 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-HDMCFkCNoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:46:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:46:35 +0000
Subject: [Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every
	result processed
In-Reply-To: <bug-15263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15263-70-AB2WEDJLVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Mirko, Jonathan and Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:51:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:51:29 +0000
Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
In-Reply-To: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16155-70-CaMDvPWv4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:53:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:53:04 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-a1Gqx5NhML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Martin and Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 15:54:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 13:54:31 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete holds
In-Reply-To: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-Qc4vx9wjmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:00:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:00:59 +0000
Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings
In-Reply-To: <bug-15599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15599-70-MCacNtOK8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|Passed QA                   |RESOLVED

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
I pretty sure this patch is no longer necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:01:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:01:27 +0000
Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are
 removed from a borrowers record.
In-Reply-To: <bug-8484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8484-70-c3JjG2Ldla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:02:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:02:56 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-zduNSCZRPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |ASSIGNED

--- Comment #301 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master, thanks Marcel!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:04:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:04:09 +0000
Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer
In-Reply-To: <bug-14622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14622-70-6mJNZhSRjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Francois!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:08:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:08:22 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-kiFr5XSw9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:08:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:08:24 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-ibpofztLgf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51188&action=edit
Bug 13041 - Can't add user as manager of basket if name includes a single quote

If you are trying to add a user as a manager of a basket in
acquisitions, a JavaScript error will be triggered if that user has a
single quote in their name (e.g. "O'Neil"). This patch corrects the
issue by removing the "onclick" attribute and using the JS change made
in Bug 16386.

Also changed by this patch: Increased the size of the patron search
popup and made a correction to some invalid HTML.

To test you should have a patron whose name contains a single quote who
is also a user with permission to manage acquisitions.

- Apply the patch and go to Acquisitions.
- Locate an open basket and view the details for that basket.
- In the "Managed by" section, click the "Add user" button to trigger
  the patron search popup.
- Search for the patron described above and click the "Add" button.
- In the parent window, the patron you chose should have been added to
  the "Managed by" section.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:13:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:13:27 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-VIfXGF2lHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |enhancement
            Version|16.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:18:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:18:02 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-ndQ4yjcFWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:18:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:18:05 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-Arf4ZZSZyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51172|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51189&action=edit
[SIGNED-OFF] Bug 16386 - Replace the use of "onclick" from patron card creator
templates

This patch removes the use of "onclick" from several patron card creator
templates. Events are defined instead in JavaScript.

Also changed:

- Patron search pop-up window is now slightly larger because I found it
  never quite large enough to prevent horizontal scrolling.
- Replaced "Borrower" with "Patron" in a couple of places.
- "Add" link in patron search pop-up is now styled as a Bootstrap
  button.
- Removed Bootstrap styles from some submit buttons.
- Some Font Awesome icons were made using the invalid element
  <icon></icon> instead of <i></i>. These are corrected.
- Fixed some other HTML validation errors.

To test, apply the patch and go to Tools -> Patron card creator.

- Choose New -> Card batch.
  - Click "Add patrons" and perform a search for patrons in the pop-up
    window.
  - Click the "Add" button. The corresponding borrowernumber should be
    added to the textarea in the parent window, and a message should
    appear at the top of the pop-up window confirming that the patron
    has been added. (Note: This patch fixes a version of Bug 13041 which
    prevented the "add" button from working on patrons whose name
    include an apostrophe).
  - In the parent page, in the list of patrons you added to the batch,
    confirm that clicking the "Delete" link triggers a confirmation
    dialog. Test both confirming and canceling.
  - Confirm that clicking the "Export" button next to an individual
    patron triggers a modal window.
    - In the export window, confirm that the "Cancel" link works to
      close the modal.
    - Click the "Export" button again and then the "Export" button in
      the modal.
      - Test that the "Done" button works to close the modal.
- Choose Manage -> Card batches.
  - Test the "Delete" and "Export" buttons as described above.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All works, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:22:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:22:44 +0000
Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff
	interface)
In-Reply-To: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10171-70-tzAR73ghFF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Followup pushed to master for 16.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:24:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:24:10 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-8guIqel2RL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:25:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:25:42 +0000
Subject: [Koha-bugs] [Bug 16390] Accounts.t does not need MPL
In-Reply-To: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16390-70-uaL93x3XbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:29:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:29:25 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-qSYJoXzhHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

--- Comment #51 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Galen Charlton from comment #47)
> I have uploaded to the squeeze-dev/unstable slot the following backported
> packages:
> 
> libswagger2-perl 0.77-1~kohadev+1
> libmojolicious-perl 6.15+dfsg-1~kohadev+1
> libjson-validator-perl 0.67+dfsg-1~kohadev+1
> libio-socket-socks-perl 0.67-1~kohadev+1
> 
> Please give it a whirl.

I confirm that it works with Swagger 2 0.77 and Mojolicious 6.15. Should we
update PerlDependencies.pm ?
libjson-validator-perl was installed automatically as a dependency, but
libio-socket-socks-perl was not and it seems not needed. Why is it packaged ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:39:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:39:34 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
 version of Swagger2
In-Reply-To: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15126-70-m2nIRZrfHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

--- Comment #52 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Julian Maurice from comment #51)
> libio-socket-socks-perl was not and it seems not needed. Why is it packaged ?

It's one of the recommends for libmojolicious-perl and I tossed it in, but it's
not required as far as I can tell (and thus doesn't need to be added as a Koha
perldep).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:39:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:39:49 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-FSSFkWmnmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #10 from Danielle Elder <danielle at bywatersolutions.com> ---
Ok. I am going to retest and check Intranet this time. I only checked OPAC
first test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:45:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:45:33 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-vcNvlaI8zl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51119|0                           |1
        is obsolete|                            |

--- Comment #11 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51190&action=edit
Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:47:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:47:25 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-bnQX6t4mwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #12 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi Danielle

I rebase the patch with some typos fixed
Sorry for the inconvenience

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:51:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:51:45 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically suppressing expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-ySBdSCT0JX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50615|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51191&action=edit
Bug 16276: Add a new pref TrackLastPatronActivity and new column
borrowers.lastseen

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:53:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:53:18 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically suppressing expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-L1f9c51D0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nicolas Legrand from comment #7)
> Does not apply, there's a conflict on
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref. I'm
> not sure what's the righte move to do? Fix the conflict and if everything's
> OK sign?

The right way is to change the status to 'does not apply' and let the developer
rebase the patches. However, if the fix is easy, you can fix it and sign it
off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:53:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:53:21 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-D1Vw5Zedov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:53:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:53:23 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-R2E3ahziDr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51094|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51192&action=edit
Bug 16411: Make Hold.t not depend on two existing branches

If you do not have two branches, this test will fail.
Can't call method "branchcode" on an undefined value.

This patch adds a borrower and two branches with TestBuilder.

Test plan:
Run the test.

Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:55:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:55:27 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically suppressing expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-FbFTcsv2P8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16331                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16331
[Bug 16331] TestBuilder does not allow undef/NULL values
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:55:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:55:27 +0000
Subject: [Koha-bugs] [Bug 16331] TestBuilder does not allow undef/NULL values
In-Reply-To: <bug-16331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16331-70-dQi4j8ZDtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16331

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16276                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276
[Bug 16276] When automatically suppressing expired borrowers, make sure they
didn't log them selves recently
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:56:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:56:37 +0000
Subject: [Koha-bugs] [Bug 16331] TestBuilder does not allow undef/NULL values
In-Reply-To: <bug-16331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16331-70-uaECoyNfQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16331

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #4)
> Jonathan: Please check bug 16155. It already includes this point and more.

Bug 16155 is pushed to master. I confirm that it fixes this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:56:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:56:54 +0000
Subject: [Koha-bugs] [Bug 16331] TestBuilder does not allow undef/NULL values
In-Reply-To: <bug-16331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16331-70-uFEH1tz2RY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16331

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16155                   |
         Resolution|---                         |DUPLICATE

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 16155 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 16:56:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 14:56:54 +0000
Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
In-Reply-To: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16155-70-7PdcESVoPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16331                   |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 16331 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:06:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:06:04 +0000
Subject: [Koha-bugs] [Bug 12682] Shibboleth attribute manipulation
In-Reply-To: <bug-12682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12682-70-XZVW5uWkO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
Hi Martin,

do you have any code about this topic ?
I'm tring to do a similar development.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:10:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:10:45 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-ul2immdwly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51161|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51193&action=edit
Bug 15194 - Drop-down menu 'Actions' has problem in 'Saved reports' page with
language bottom bar

This patch changes the direction of the "actions" menu on the saved
reports page so that it popup up instead of down.

To test, apply the patch and go to Reports -> Saved reports.

- Click the "Actions" menu for any report and confirm that the menu
  displays above the button instead of below it.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:10:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:10:42 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-Qfhn3oBi3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:12:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:12:44 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-FSfQO4Eg6l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to H?ctor Eduardo Castro Avalos from comment #12)
> Created attachment 51162 [details]
> drop-down-menu-spanish
> 
> Hi Marc
> 
> I don't see the option "Delete" -> "Borrar" in spanish

H?ctor, this patch has nothing to do with this button.
I have tested with fr-FR and see the button, check that your user has the
correct rights to delete a report (reports_create_reports).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:13:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:13:31 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-X3ICMUZm4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:25:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:25:42 +0000
Subject: [Koha-bugs] [Bug 13597] Amazon 'no image' element needs a
 'no-image' class, in the staff client
In-Reply-To: <bug-13597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13597-70-A58kzlblZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Mason James from comment #7)
> > On master, I have set a local cover image for 1 record and not for another
> > one.
> > Launch a search, I get the local cover image for the first record and the
> > "No cover image available" for the other one.
> > 
> > Switching off LocalCoverImages, I get the amazon "No image available" image
> 
> Jonathan, on staff, with patch and CSS added, LocalCoverImages off.. you get
> the amazon "No image available" image shown?

I do not know, I have not tried, why should I?
I think I did not get the goal of this patch.
Could you please give me the use case and provide a more detailed test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:30:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:30:09 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-qjNnUu25Qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:35:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:35:56 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-uuR5YE67Mr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Why do we need an id on the legend elements?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 17:51:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 15:51:10 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-zNZ56fWlFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #4)
> Why do we need an id on the legend elements?

I don't know. I assume that the IDs were added at some time in the past in
order to facilitate some kind of customization. My patch simply makes them
consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:03:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:03:43 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-bRhbYt3YPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:03:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:03:47 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-gzqOA2Wx2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51141|0                           |1
        is obsolete|                            |
  Attachment #51142|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51194&action=edit
Bug 16429 - Going to circulation from notice triggers may change logged in
branch

If you edit notice triggers and then use the "Checko out" tab from the
top bar, you may change your logged in library by accident!

Test Plan:
1) Disable the system preference CircAutocompl
2) Go to the notice triggers
3) Select the triggers for a library other than the one you logged in as
4) Use the "Check out" tab at the top to check out to a patron
5) Note your logged in branch has changed ( you'll need to refresh the
    page if the check out search took you directly to one patron ).
6) Apply this patch
7) Repeat steps 2-4
8) Note the branch no longer changes

Tested with both patches applied. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Heather Braum <hbraum at nekls.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:03:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:03:59 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-9ocCblBhKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
I would prefer that we use no icon if there is no single icon which works well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:04:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:04:11 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-ET5w4AWdsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Good catch Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:04:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:04:25 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-yUiG4n5wDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51195&action=edit
Bug 16429 - Fix root problem

The root of this issue is old code in circulation.pl that is no longer
needed and leaves the affected scripts open to future regressions.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Heather Braum <hbraum at nekls.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:05:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:05:43 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-anBKHQvjjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Master is moving fast

fatal: sha1 information is lacking or useless (admin/biblio_framework.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 16431: Use Koha::Cache to cache marc subfield
structure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:14:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:14:01 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-cLcU6Fe1km@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:14:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:14:04 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-q0FW2aV5Si@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51163|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51196&action=edit
Bug 16315 - OPAC Shelfbrowser doesn't display the full title

This patch adds subtitle information to the display of titles in the
OPAC's shelf browser.

To test, apply the patch and make sure OPACShelfBrowser is enabled.

- View the detail page for any title in the OPAC which has items.
- Click the "Browse shelf" link next to any item in the holdings table.
- The titles in the shelf browser should display with all subtitle
  information as defined in Keywords to MARC mapping.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Adding 245a and c as 'subtitle' in Keywords to Marc make them
show on shelf browser.
No errors.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:23 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-aJNXvuMhi9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:31 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-24AiaOgl5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48281|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51198&action=edit
Bug 15839: Koha::Reviews - Remove getreviews

The C4::Reviews::getreviews subroutine retrieved the reviews for a given
record, depending on their status.
This can be achieve with a call to Koha::Reviews->search.
There were 2 calls to this subroutine. The one from opac-ISBDdetail.pl
does not look in used: the reviews are not display on this page. It
certainly comes from an old copy/paste from opac-detail.pl.
The one from opac-detail only asked for the approved reviews. So the
logged in user does not see its own review if it is pending approval.
Actually this pending approval review is only displayed when the user
submits it (because of a unecessary complex text replacement done in
JS).
With this patch, the approved reviews AND the unaproved review from the
logged in user will be displayed.
It will allow a future enhancement to add a way to delete our own
reviews.

Moreover, the reviews were retrieved even if they were not displayed (if
reviewson is off), it's now fixed.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:26 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-rqHpOrA8JW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48280|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51197&action=edit
Bug 15839: Koha::Reviews - Add Koha::Review[s] classes

The subroutines in C4::Reviews are only doing CRUD operations.
This patch set moves them to 2 new Koha::Review[s] classes.

Test plan for the whole patch set:
0/ Set the reviewson syspref
1/ At the OPAC, create a couple of reviews for a record
Try and create a review without html tags different that br b i em big
small strong: You should get a warning.
2/ Edit a review
3/ On the Staff interface, you should see a "Comments pending approval"
link on the mainpage
4/ Approve 1 review and delete the other
5/ At the OPAC you should only see 1 review (the approved one) in the
"Comments" tab
6/ Modify the review
7/ The review should appear again in the "comments awaiting moderation"
tab.
Note that even the comment has not been changed, it will have to be
reapproved (FIXME later). This behavior already existed prior to this
patch.

Tested all patches together (with database updated)
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:35 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-7OW16Vtbtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48282|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51199&action=edit
Bug 15839: Koha::Reviews - Remove getallreviews

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:40 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-YfIWpBlpyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48283|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51200&action=edit
Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview

This patch adds 2 new methods to Koha::Review: approve and unapprove.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:44 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-T17WAAxPyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48284|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51201&action=edit
Bug 15839: Koha::Reviews - Change default value for approved to 0

The reviews.approved column had a default value set to NULL.
It does not make sense, the default value should be 0, this will avoid
to have to specify the approved value when creating a new review.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:49 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-OZzUQJ2ZSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48285|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51202&action=edit
Bug 15839: Koha::Reviews - Remove deletereview

Note that a future enhancement should take into account the possible
error returned by ->approve, ->unapprove and ->delete

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:53 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-YEj5NwvDkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48286|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51203&action=edit
Bug 15839: Koha::Reviews - Remove getreview

Note that this (biblionumber, borrowernumber) pair should be defined as
a unique key at the DB level (FIXME added)

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:19:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:19:57 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-8RTAGZ6f4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48287|0                           |1
        is obsolete|                            |

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51204&action=edit
Bug 15839: Koha::Reviews - Remove getnumberofreviews

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:20:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:20:01 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-DBtcKcSkvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48288|0                           |1
        is obsolete|                            |

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51205&action=edit
Bug 15839: Koha::Reviews - Remove updatereview

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:20:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:20:06 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-otYFscSMB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48289|0                           |1
        is obsolete|                            |

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51206&action=edit
Bug 15839: Koha::Reviews - Remove savereview

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:20:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:20:11 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-lmyhuqzYp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48290|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51207&action=edit
Bug 15839: Koha::Reviews - Remove C4::Review residue

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:21:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:21:57 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-YfX8ndrFR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:22:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:22:30 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-oKbsjcnaPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Sorry, forgot the dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:26:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:26:31 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-Vtv1dYCKeQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7540

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > Why do we need an id on the legend elements?
> 
> I don't know. I assume that the IDs were added at some time in the past in
> order to facilitate some kind of customization. My patch simply makes them
> consistent.

Added by bug 7540.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:26:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:26:31 +0000
Subject: [Koha-bugs] [Bug 7540] Add ids to the legend elements to make it
 easier to tweak with javascript
In-Reply-To: <bug-7540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7540-70-zyER0d558P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7540

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16159

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:27:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:27:42 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-qGOagFhMyt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:27:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:27:45 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-vA3jy2BX8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51178|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51208&action=edit
Bug 16159 - guarantor section missing ID on patron add form

In the patron entry form template most <fieldset> and <legend> tags have
unique ids. This patch adds ids to fieldsets and legends which lack
them.

To test apply the patch and view the patron entry form. There should be
no visual changes. There should be no HTML validation errors triggered
by this change.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:29:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:29:51 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-h0QH34DzA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Adding Aleisha, Tomas and Katrin to the discussion.

What are your thoughts about the 2 displays/behaviors?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:42:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:42:34 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-nsRRTrakQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:42:37 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-XtPkGrohtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51109|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51209&action=edit
Bug 16415 - Layout problem on staff client detail page if local cover images
are enabled

This patch fixes a layout problem which appears on the staff client
bibliographic detail page if local covers are enabled but Amazon covers
are not.

To test, apply the patch and turn off AmazonCoverImages.

- Enable the LocalCoverImages system preference and locate or create a
  record which has a local cover image associated with it.
- View the bibliographic detail page. The bibliographic details should
  display in two columns, with text on the left and local cover image on
  the right.
- Test with AmazonCoverImages and LocalCoverImages enabled.
- Test with AmazonCoverImages enabled and LocalCoverImages disabled.

All combinations are OK.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:45:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:45:59 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-RcX2f7y6de@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #10)
> 10/ Yes I see the message, but the discharge has been requested anyway.
> You have to redirect to a 404 in case of opac-discharge.pl is called with
> the op parameter set.

And what about the redirect at the OPAC?
Switch to signoff when you will submit a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:47:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:47:56 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-7uVYVnjCYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:47:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:47:58 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-EGPgRn4Gsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #5 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51210&action=edit
Bug 16438: (followup) change icons to one icon

Change the two icons to just one: "fa fa-minus-square"

To test: follow the previous commit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:52:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:52:43 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-POwY7KO05R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51210|0                           |1
        is obsolete|                            |

--- Comment #6 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51211&action=edit
Bug 16438: (followup) change icons to one icon

Change the two icons to just one: "fa fa-minus-square"

To test: follow the previous commit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:55:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:55:16 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-DBsEx0O14H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #7 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi Owen and Jonathan

Please look if this is Ok

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 18:59:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 16:59:26 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-clleIWc5vl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com,
                   |                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:04:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:04:27 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-XH9FWIt5YS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
My vote is still for no icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:09:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:09:32 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-Bek1fh2thC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #9 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Owen Leonard from comment #8)
> My vote is still for no icon.

For all options or just for those icons which don't work well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:13:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:13:48 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-odz2gMO3pG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #13)
> On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> If there is no further development(?), this might be a risk.

I can see that as blocker, Mason, would it be easy to update the plugin you
used?

(In reply to Fr?d?ric Demians from comment #14)
> I don't see the advantage of this implementation against Bywater plugin. I
> can
> rather see disadvantages, including ContentFlow.js obsolescence (not updated
> since 2010, when jQuery Flipster used by ByWater plugin is actively
> maintained). Reading the code, I don't understand how GetRecentBibs generates
> the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to
> read/re-read this table each time the OPAC main page is loaded?

Same for me, it's not conceivable to call this subroutine for each get of the
opac main page. Could you please detail what is the purpose of this subroutine?
Why do you need a new table, cache of the image url that's it?

Additional comments:
- kohastructure.sql changes are missing
- Amazon lookup should be optional
- We have several subroutines in C4::Koha to deal with ISBNs, I am sure you
could reuse
- What are the 150 and 300 hardcoded limits?
- It would be better to use Koha::Object
- It would be great to remove all the debug variables, it will ease the
readability

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:14:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:14:51 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-b239TebqAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:19:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:19:49 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-A6AJka5Ts3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:19:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:19:51 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-tNZY7Dx1Ks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51211|0                           |1
        is obsolete|                            |

--- Comment #10 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51212&action=edit
Bug 16438: (followup) remove item where no single icon exist for options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:20:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:20:04 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-yzHcImCqOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:22:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:22:55 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-HOyub4VyIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #11 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi Owen

I've deleted the icons for options where icon doesn't fit well with
description.

Feel free to change and/or close the bug if you think this isn't the right way.
No biggie.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:33:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:33:14 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-t0xlutcEoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:33:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:33:16 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-jQJHgq6dCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51212|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51213&action=edit
[SIGNED-OFF] Bug 16438: (followup) remove item where no single icon exist for
options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 19:36:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 17:36:26 +0000
Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast
	again.
In-Reply-To: <bug-15262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15262-70-xIIGDtRgzF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:00:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:00:53 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-a650qsnnGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:00:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:00:57 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-cmIlTxyhbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51171|0                           |1
        is obsolete|                            |
  Attachment #51213|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51214&action=edit
Bug 16438: Use Font Awesome icons in batch templates

Add Font Awesome icons in tables in authorities and bib records
in batch item/record deletion, modification templates

To test:
1- Go to Tools > Batch item/record deletion/modification
2- Try to delete/modify itmes/bib and authorities records
3- Look all tables presented and notice about the new icons in Select all
   Clear all, etc.
4- Apply patch and repeat step 1 to 3

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work, nice view.
No Errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:01:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:01:01 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-GDeU7vRta7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51215&action=edit
Bug 16438: (followup) remove item where no single icon exist for options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:04:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:04:47 +0000
Subject: [Koha-bugs] [Bug 16439] New: Allow styling to button for upload
 local cover images (Font Awesome Icons)
Message-ID: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

            Bug ID: 16439
           Summary: Allow styling to button for upload local cover images
                    (Font Awesome Icons)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Improve button for upload local cover image with Font Awesome Icon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:08:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:08:33 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-vYMF5sUkwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:08:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:08:35 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-ViHKbXfijb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51216&action=edit
Bug 16439: Allow styling to button for upload local cover images (Font Awesome
Icons)

Improve button for upload local cover image with Font Awesome Icon

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the button upload.
-Apply the patch and reload the page.
-The button is changed for class=btn btn-mini like the button "edit"
 used in items in the tab Holdings
-Also added the Font Awesome icon upload "fa fa-upload" class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:10:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:10:03 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-iRlt20PeQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16439


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439
[Bug 16439] Allow styling to button for upload local cover images (Font Awesome
Icons)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:10:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:10:03 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-XFOSLQWeGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16438


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438
[Bug 16438] Use Font Awesome icons in batch templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:15:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:15:44 +0000
Subject: [Koha-bugs] [Bug 16440] New: Update report parameters
Message-ID: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440

            Bug ID: 16440
           Summary: Update report parameters
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51217&action=edit
Placement of report parameters on report results.

Let's say you have a report that asks you for parameters.  You run the report,
get the results, and then you want to run the report again with different
parameters.  Or maybe you made a mistake and need to change it.  Yes, you could
back up and change things and run it again.  But what if the parameters were
showing over on the left of the report under the "Useful resources" section? 
You could see what you set, and change whatever you needed and then click
update.  Perhaps the row setting and update button could also be on the left of
the report.

Just a thought.  I was able to change a parameter up in the URL, and hit
update, and it worked.  It was nice because I set the report to show more than
20 records, and I didn't have to repeat that step after updating.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:43:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:43:30 +0000
Subject: [Koha-bugs] [Bug 16441] New: C4::Letters::getletter is not plack
	safe
Message-ID: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

            Bug ID: 16441
           Summary: C4::Letters::getletter is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 9452
            Blocks: 7172

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to remove it.
It won't be a big deal to hit the DBMS to get a valid letter when needed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452
[Bug 9452] C4::Letters does not function under Plack
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:43:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:43:30 +0000
Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack
In-Reply-To: <bug-9452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9452-70-GAESjj4eVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16441


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441
[Bug 16441] C4::Letters::getletter is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:43:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:43:30 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-XkXVicvNdg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16441


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441
[Bug 16441] C4::Letters::getletter is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:44:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:44:20 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-Kgw5cfj2Tr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi,
found a fail in t/db_dependent/Items.t, subtest 4 of test 10

    not ok 4 - items.barcode is not mapped anymore, so the DB column has not
been updated

    #   Failed test 'items.barcode is not mapped anymore, so the DB column has
not been updated'
    #   at t/db_dependent/Items.t line 661.
    #          got: undef
    #     expected: 'a barcode'
    # Looks like you failed 1 test of 4.
not ok 10 - C4::Items::_build_default_values_for_mod_marc

Something in my data?
Does not fail in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:44:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:44:45 +0000
Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe
In-Reply-To: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16441-70-5v6PJbHp24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:44:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:44:48 +0000
Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe
In-Reply-To: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16441-70-ta7lw3IlBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51218&action=edit
Bug 16441: Do not use a package variable to cache C4::Letters::getletter

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.

No test plan here, just confirm that the changes make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:48:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:48:18 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-9AEUq7qqG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #3)
> Hi,
> found a fail in t/db_dependent/Items.t, subtest 4 of test 10

What I found is that I need more sleep, forget dependency again. Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:53:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:53:43 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-1K7WGdborV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16442


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442
[Bug 16442] C4::Ris is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 20:53:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 18:53:43 +0000
Subject: [Koha-bugs] [Bug 16442] New: C4::Ris is not plack safe
Message-ID: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

            Bug ID: 16442
           Summary: C4::Ris is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 7172

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is usmarc if
not defined
our $marcprint: always 0, so set it to 0
our $protoyear: only used in 1 subroutine, let's define it at this level


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:02:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:02:49 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-pNmq0TwI3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

g.meyer at esgbonn.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
           Priority|P3                          |P2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:04:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:04:33 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-ar7E6AsNuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:04:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:04:45 +0000
Subject: [Koha-bugs] [Bug 16442] C4::Ris is not plack safe
In-Reply-To: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16442-70-rVCvpOGKBn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:04:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:04:48 +0000
Subject: [Koha-bugs] [Bug 16442] C4::Ris is not plack safe
In-Reply-To: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16442-70-3TZ1vNdLnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51219&action=edit
Bug 16442: C4::Ris is not plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:08:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:08:46 +0000
Subject: [Koha-bugs] [Bug 16443] New: C4::Members::Statistics is not plack
	safe
Message-ID: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

            Bug ID: 16443
           Summary: C4::Members::Statistics is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 7172

If the prefs is updated, the fields won't be.
To make sure we already fetch updated values, we should remove the package
variable and define it in the subroutine.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:08:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:08:46 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-u2wVtoK4V9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16443


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443
[Bug 16443] C4::Members::Statistics is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:09:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:09:52 +0000
Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe
In-Reply-To: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16443-70-sJ1dB1gcfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:09:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:09:55 +0000
Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe
In-Reply-To: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16443-70-WzmLOmMCM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51220&action=edit
Bug 16443: Make C4::Members::Statistics plack safe

If the prefs is updated, the fields won't be.
To make sure we already fetch updated values, we should remove the
package variable and define it in the subroutine.

There is not test plan, just make sure the changes are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:10:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:10:42 +0000
Subject: [Koha-bugs] [Bug 16442] C4::Ris is not plack safe
In-Reply-To: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16442-70-HTyWJsjSOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51219|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51221&action=edit
Bug 16442: Make C4::Ris plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:20:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:20:36 +0000
Subject: [Koha-bugs] [Bug 16444] New: C4::Tags is not plack safe
Message-ID: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

            Bug ID: 16444
           Summary: C4::Tags is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 7172

C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's
not needed and not safe.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:20:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:20:36 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-BYDpNKhNpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444
[Bug 16444] C4::Tags is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:21:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:21:57 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-n0O7tam2BP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:22:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:22:01 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-9z0FoehqAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51222&action=edit
Bug 16444: Make C4::Tags plack safe

C4::Tags use a package variable to cache the pref
TagsExternalDictionary, it's not needed and not safe.

There is not test plan, just make sure the changes are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:26:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:26:10 +0000
Subject: [Koha-bugs] [Bug 14315] Slow checkouts,
 caused by many 'special_holidays' definitions
In-Reply-To: <bug-14315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14315-70-zsrXm86nQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Mason James from comment #8)
> Update: A new bug has been created, that contains a patch for this problem...
> 
>   http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

So can we close this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:35:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:35:22 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-dyCmxUyuBy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can you continue the web installer after this warning?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:39:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:39:47 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-wtfpMrwKvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:39:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:39:51 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-lDpPcyUF0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51223&action=edit
Bug 15333: Use Koha::Cache to cache exception_holidays instead of a package
variable

On the same way as bug 14522, we should use Koha::Cache to cache
exception_holidays.
It's not safe to use a package variable if running under Plack.

There is not test plan, just make sure the changes make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:40:57 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-Q0vx0oqWEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15333


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333
[Bug 15333] Use Koha::Cache for caching all holidays
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:40:57 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-rPXO7SahH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7172
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note that we won't add any performance gain with this patch (on the contrary),
but at least we will get rid of possible weird behaviors.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:44:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:44:54 +0000
Subject: [Koha-bugs] [Bug 16445] New: Bug 12478 has added an unnecessary
 line to Koha/Database.pm
Message-ID: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

            Bug ID: 16445
           Summary: Bug 12478 has added an unnecessary line to
                    Koha/Database.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 12478

>From commit 95dabf4bfd15f6aed149c17546c00083063a01c1
  Bug 12478 - add some base objects that the ES code will depend on

+our $schema; # the schema is a singleton

This is not needed


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:44:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:44:54 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-D9qxt9QIKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16445


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445
[Bug 16445] Bug 12478 has added an unnecessary line to Koha/Database.pm
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:47:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:47:29 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-RvnR7P6grI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 21:47:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 19:47:32 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-MhoNiGd7w7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51224&action=edit
Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm

These changes were a mistake, let's revert them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 22:08:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 20:08:14 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be
	removed
In-Reply-To: <bug-7976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-GVRfHXYNZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Bouzid <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |bouzid.fergani at inlibro.com
         Resolution|FIXED                       |---

--- Comment #14 from Bouzid <bouzid.fergani at inlibro.com> ---
Hi all,
The borrow permission is removed, but it existing in this files: 

opac/opac-idref.pl:40:        flagsrequired   => { borrow => 1 },
opac/opac-news-rss.pl:37:        flagsrequired   => { borrow => 1 },
opac/opac-restrictedpage.pl:43:        flagsrequired   => { borrow => 1 },
opac/svc/login:46  checkauth( $query, 1,  { borrow => 1 }, 'opac',
$decoded_json->{'email'} );

I think, it's a bug.

Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 22:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 20:21:39 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-9RDUvZjOKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Danielle Elder <danielle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51190|0                           |1
        is obsolete|                            |

--- Comment #13 from Danielle Elder <danielle at bywatersolutions.com> ---
Created attachment 51225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51225&action=edit
Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 22:38:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 20:38:48 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-4AbQUQiYqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Danielle Elder <danielle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51225|0                           |1
        is obsolete|                            |

--- Comment #14 from Danielle Elder <danielle at bywatersolutions.com> ---
Created attachment 51226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51226&action=edit
Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

Signed-off-by: Dani Elder <danielle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 22:45:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 20:45:07 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-OArQgPhZfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #15 from Danielle Elder <danielle at bywatersolutions.com> ---
I tested the css classes and ordering in Intranet and OPAC. Looked great. I
signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 23:08:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 21:08:28 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-DEZYBiN18Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May  4 23:08:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 May 2016 21:08:42 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-XofWPxpsrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51224|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51227&action=edit
Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm

These changes were a mistake, let's revert them.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 02:38:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 00:38:04 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-fDiGOD68Qg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #245 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Also, with my version of elastic, I had to do following changes:

diff --git a/Koha/ElasticSearch.pm b/Koha/ElasticSearch.pm
index d56c344..22bc064 100644
--- a/Koha/ElasticSearch.pm
+++ b/Koha/ElasticSearch.pm
@@ -171,11 +171,6 @@ sub get_elasticsearch_mappings {
                     include_in_all => JSON::false,
                     type           => "string",
                 },
-                '_all.phrase' => {
-                    search_analyzer => "analyser_phrase",
-                    index_analyzer  => "analyser_phrase",
-                    type            => "string",
-                },
             }
         }
     };
@@ -195,15 +190,12 @@ sub get_elasticsearch_mappings {
               ? 'boolean'
               : 'string';
             $mappings->{data}{properties}{$name} = {
-                search_analyzer => "analyser_standard",
-                index_analyzer  => "analyser_standard",
+                analyzer  => "analyser_standard",
                 type            => $es_type,
                 fields          => {
                     phrase => {
-                        search_analyzer => "analyser_phrase",
-                        index_analyzer  => "analyser_phrase",
+                        analyzer  => "analyser_phrase",
                         type            => "string",
-                        copy_to         => "_all.phrase",
                     },
                     raw => {
                         "type" => "string",
@@ -222,22 +214,19 @@ sub get_elasticsearch_mappings {
             if ($suggestible) {
                 $mappings->{data}{properties}{ $name . '__suggestion' } = {
                     type => 'completion',
-                    index_analyzer => 'simple',
-                    search_analyzer => 'simple',
+                    analyzer => 'simple',
                 };
             }
             # Sort may be true, false, or undef. Here we care if it's
             # anything other than undef.
             if (defined $sort) {
                 $mappings->{data}{properties}{ $name . '__sort' } = {
-                    search_analyzer => "analyser_phrase",
-                    index_analyzer  => "analyser_phrase",
+                    analyzer  => "analyser_phrase",
                     type            => "string",
                     include_in_all  => JSON::false,
                     fields          => {
                         phrase => {
-                            search_analyzer => "analyser_phrase",
-                            index_analyzer  => "analyser_phrase",
+                            analyzer  => "analyser_phrase",
                             type            => "string",
                         },
                     },
diff --git a/installer/data/mysql/updatedatabase.pl
b/installer/data/mysql/updatedatabase.pl
index 9e6d390..e092704 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -12332,13 +12332,13 @@ my $indexes = LoadFile( $mappings_yaml );

 while ( my ( $index_name, $fields ) = each %$indexes ) {
         while ( my ( $field_name, $data ) = each %$fields ) {
-            my $field_type = $data->{type};
+            my $field_type = $data->{type} || 'string';
             my $field_label = $data->{label};
             my $mappings = $data->{mappings};
             my $search_field = Koha::SearchFields->find_or_create({ name =>
$field_name, label => $field_label, type => $field_type }, { key => 'name' });
             for my $mapping ( @$mappings ) {
                 my $marc_field = Koha::SearchMarcMaps->find_or_create({
index_name => $index_name, marc_type => $mapping->{marc_type}, marc_field =>
$mapping->{marc_field} });
-                $search_field->add_to_search_marc_maps($marc_field, { facet =>
$mapping->{facet}, suggestible => $mapping->{suggestible}, sort =>
$mapping->{sort} } );
+                $search_field->add_to_search_marc_maps($marc_field, { facet =>
$mapping->{facet} || 0, suggestible => $mapping->{suggestible} || 0, sort =>
$mapping->{sort} || undef } );
             }
         }
 }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 02:47:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 00:47:34 +0000
Subject: [Koha-bugs] [Bug 16446] New: Allow librarians to add borrowers to
 lists by borrowernumber or cardnumber
Message-ID: <bug-16446-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446

            Bug ID: 16446
           Summary: Allow librarians to add borrowers to lists by
                    borrowernumber or cardnumber
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It would be nice to be able to add borrowers to lists based on a supplied list
of cardnumbers or borrowernumbers (that they could get from a report, for
example).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 03:58:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 01:58:19 +0000
Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human
	readable
In-Reply-To: <bug-15434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15434-70-BQDGQtJi4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #34 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---

> We build the breadcrumbs... so why are we doing this client-side? Why aren't
> we doing this server-side?

I could have done it both ways, but these days I prefer client side.
* As a sever side dude, I prefer that clients use their cycles
* Tomorrow we decide to make search an api call, this still works

And a personal, not a valid reason: I find that translations are easier
(cleaner) in js

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 04:38:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 02:38:29 +0000
Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human
	readable
In-Reply-To: <bug-15434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15434-70-xglblm6WPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
(In reply to Srdjan Jankovic from comment #34)
> I could have done it both ways, but these days I prefer client side.
> * As a sever side dude, I prefer that clients use their cycles

I think client capabilities really range a lot, so as a server side dude I'd
rather present as consistent a baseline as possible. 

> * Tomorrow we decide to make search an api call, this still works
> 

Your API call would still need to return the text for you to replace, so that
doesn't really make sense. The API call could return translated text. You'd
just need a locale parameter. 

> And a personal, not a valid reason: I find that translations are easier
> (cleaner) in js

I haven't done much with translations, but I believe you with that one. That
said, if we used resource files for certain strings as I've suggested
elsewhere, translations would be simple. In a persistent environment, you only
load the file once, so there's not much overhead. 

But that's just my 2 cents. I'm not offering up any alternative patches, so I'm
mostly just curious about the rationale. Thanks for taking the time to respond
:).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 04:39:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 02:39:24 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-baYEtlgRi3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #34 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #32)
> David: I recall falling back to floating timezone for making calculations
> with far future dates like an expiry in 9999 or so.
> If you would use a normal timezone, you will have major performance issues.

Yeah, that's an unrelated issue I believe.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 04:44:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 02:44:11 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
 Invalid local time for date in time zone"
In-Reply-To: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12669-70-5HSWpnG9G2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
(In reply to Colin Campbell from comment #33)
> I wonder if we could use utc internally and just use the local timezone to
> convert user input and to present the date externally. We'd need to be
> fairly vigorous in cleaning up the various vaguely different ways we
> currently treat dates, cetainly when we're doing calculations we probably
> want to do them in a common base as otherwise there's too many opportunities
> to fall into a given timezone's black hole

Agreed. I think we could use UTC internally and just use the local timezone to
convert user input and convert output for users.

We would need to be vigorous in cleaning up how we've currently treating dates
though, yeah :/. Generally speaking, we're not recording super precise datetime
data, so I don't see why we couldn't use floating timezones for calculations. I
suppose it depends on the calculations being done, but that's really the only
way of doing it with our current holiday checking code without causing invalid
local times. 

We might be able to use UTC for some calculations, but... I don't think so  in
the holiday case because we'd be interested in local days and obviously UTC
doesn't always correspond with the same day. You might have 2 UTC timestamps
for the same day in UTC, but they'd actually correspond to different days in
local time. If you truncated that for the sake of date checking, you'd be
skipping one of the local days, which would be really bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 07:53:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 05:53:09 +0000
Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
In-Reply-To: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16258-70-xUllQvQ7Ej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51185|0                           |1
        is obsolete|                            |

--- Comment #8 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 51228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51228&action=edit
Proposed patch

make an import explicit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 08:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 06:24:54 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-nAdKC8Ruw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

--- Comment #18 from Marc V?ron <veron at veron.ch> ---
Created attachment 51229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51229&action=edit
[FOLLOW-UP] Bug 15823: Redirect opac-discharge.pl to 404 page

See comment #17: Redirect to 404 in opac-discharge.pl and remove
message in template because with the redirect it will never be
reached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 08:26:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 06:26:00 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-LRfNXvcwxH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #19 from Marc V?ron <veron at veron.ch> ---
Reset to Signed Off (see comment 17)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 11:16:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 09:16:48 +0000
Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records
 with multiple items where 1 is not available (checked out) but others are
In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13715-70-lJOWADpGcy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 11:21:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 09:21:52 +0000
Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all
 images on the OPAC
In-Reply-To: <bug-7706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7706-70-obUA5OJj2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 12:16:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 10:16:00 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-YC1woYYAhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

--- Comment #3 from flittle <flittle at thedowns.avon.sch.uk> ---
(In reply to Katrin Fischer from comment #2)
> Can you continue the web installer after this warning?

Hi, no it will not continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 12:21:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 10:21:49 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-jbufl0LF2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 13:09:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 11:09:09 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-yZO6fcTJvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

--- Comment #4 from g.meyer at esgbonn.de ---
For me it is exactly the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 14:27:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 12:27:26 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-bz8hG4vRA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Charles Gruener <cgruener at gruener.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgruener at gruener.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 14:32:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 12:32:04 +0000
Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-SZOZ3ADbyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 14:32:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 12:32:19 +0000
Subject: [Koha-bugs] [Bug 15347] itemcallnumber syspref does not work when
 adding items through acquisitions
In-Reply-To: <bug-15347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15347-70-G9akX0faGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15347

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 14:36:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 12:36:40 +0000
Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost
	on next edit
In-Reply-To: <bug-15030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15030-70-wnWkUK4DJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:16:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:16:36 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-AIaASPM201@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51230&action=edit
Bug 16428: (regression tests)

This patch adds tests to t/db_dependent/Items.t to verify the kohafield
mapping is not always taken from the default framework, but from the correct
one.

To test:
- Apply the patch
- Run:
  $ prove t/db_dependent/Items.t
=> FAIL: Mapping is not done on the right framework

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:39:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:39:47 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-n4ItoiEe3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #2 from Charles Gruener <cgruener at gruener.us> ---
I attempted to change the sql_mode as suggested and the error persists upon
trying to import the database structure.  The file
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/kohastructure.sql needs
to be updated to comply with the changes introduced in MySQL release 5.7.3.

See: http://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-3.html

Specifically: Columns in a PRIMARY KEY must be NOT NULL, but if declared
explicitly as NULL produced no error. Now an error occurs. For example, a
statement such as CREATE TABLE t (i INT NULL PRIMARY KEY) is rejected. The same
occurs for similar ALTER TABLE statements. (Bug #13995622, Bug #66987, Bug
#15967545, Bug #16545198)

Since I don't know much about how the database needs to be structured to
properly function, I'll just call out the fields that MySQL is erroring out on
in kohastructure.sql rather than attempting to write my own patch.

On line 1385: CREATE TABLE 'letter' uses 'branchcode' as part of its
PRIMARY_KEY, but is "default NULL"

On line 2476: CREATE TABLE 'permissions' uses 'code' as part of its PRIMARY_KEY
but is "DEFAULT NULL"

If I change those two (branchcode and code) to be "NOT NULL", I am able to get
the installer to continue, but as I stated above, I don't know if this is the
correct fix as I don't know how this impacts the database structure for the
usability of koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:42:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:42:29 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-Wr7c312NjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
  Attachment #51230|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 51230
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51230
Bug 16428: (regression tests)

The same tests are introduced on 13074 by Jonathan. I'm picking his tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:45:01 +0000
Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26
In-Reply-To: <bug-14637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14637-70-F4Oqj2l1kK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

Charles Gruener <cgruener at gruener.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=16402                   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:45:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:45:01 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-hCbLC9lWfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Charles Gruener <cgruener at gruener.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=14637                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:51:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:51:03 +0000
Subject: [Koha-bugs] [Bug 16447] New: "Borrow Permission" should not be used
	anymore
Message-ID: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

            Bug ID: 16447
           Summary: "Borrow Permission" should not be used anymore
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 7976 has removed this permission, but other patches re-added it...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:51:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:51:56 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be
	removed
In-Reply-To: <bug-7976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-IFcbGmlndx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
             Blocks|                            |16447

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bouzid from comment #14)
> Hi all,
> The borrow permission is removed, but it existing in this files: 
> 
> opac/opac-idref.pl:40:        flagsrequired   => { borrow => 1 },
> opac/opac-news-rss.pl:37:        flagsrequired   => { borrow => 1 },
> opac/opac-restrictedpage.pl:43:        flagsrequired   => { borrow => 1 },
> opac/svc/login:46  checkauth( $query, 1,  { borrow => 1 }, 'opac',
> $decoded_json->{'email'} );
> 
> I think, it's a bug.
> 
> Bouzid.

Yes it is, it always better to open a new bug report, especially when the
original one is marked as resolved.

See bug 16447


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447
[Bug 16447] "Borrow Permission" should not be used anymore
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:51:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:51:57 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-518MjEIhl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447
Bug 16447 depends on bug 7976, which changed state.

Bug 7976 Summary: "Borrow Permission" is not used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:51:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:51:56 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-2ULTn1e36O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976
[Bug 7976] "Borrow Permission" is not used and can be removed
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:56:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:56:49 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-Uz9IuOBYUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:58:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:58:32 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-NqQrj8TAMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:58:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:58:35 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-6xce5lt4nP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51231&action=edit
Bug 16447: Remove occurrence of the borrow permission which does no longer
exist

Bug 7976 has removed this permission, but other patches re-added it...
Note that the occurrences in sendbasket.pl and opac/svc/login should
have been removed by bug 16447.

Test plan:
  git grep 'borrow => 1'
should not return any results.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 15:58:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 13:58:51 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-Di2cpMR8kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:04:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:04:24 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-l07izqatkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:04:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:04:27 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-81H9tQgOgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51232&action=edit
Bug 16437 - Automatic item modifications by age needs prettying

This patch makes layout and behavior changes to the automatic item
modifications by age interface, bringing some aspects of it closer into
conformance with established interface patterns.

- The intial view is now a standard table of information about existing
  rules, or a message dialog saying there are no rules.
- If there are no rules, a toolbar button reads "Add rules."
- If there are existing rules, the toolbar button reads "Edit rules."
  - Clicking the button leads to the rules edit interface, which now has
    a floating toolbar with "Add rule," "Save," and "Cancel" buttons.
  - Clicking the "Add rule" button displays a blank rule block.
    - If you are adding a rule to existing rules, the new block is
      appended at the bottom, and the page scrolls to the new rule.
    - As you add or remove rule blocks, the legend containing the rule
      count updates so that the numbers are sequential.
    - In each rule block, "age" and "substitutions" are now required.
      The age field is now validated to require a number.
    - The add/remove condition/substitution links now have more
      descriptive text labels.
    - The control to remove a rule is now a link in the <legend> element
      associated with each rule.
- Most JavaScript for this page is now in a separate file.
- Breadcrumbs are updated to be a little more specific.

To test, apply the patch and clear your browser cache if necessary.

- Go to Tools -> Automatic item modifications by age.
- Test adding and removing rules.
- Test removing all rules.
- Test adding and removing conditions and substitutions within rules.
- Test submitting the form without filling in required fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:05:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:05:57 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-062X7jTFtG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51232|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51233&action=edit
Bug 16437 - Automatic item modifications by age needs prettying

This patch makes layout and behavior changes to the automatic item
modifications by age interface, bringing some aspects of it closer into
conformance with established interface patterns.

- The intial view is now a standard table of information about existing
  rules, or a message dialog saying there are no rules.
- If there are no rules, a toolbar button reads "Add rules."
- If there are existing rules, the toolbar button reads "Edit rules."
  - Clicking the button leads to the rules edit interface, which now has
    a floating toolbar with "Add rule," "Save," and "Cancel" buttons.
  - Clicking the "Add rule" button displays a blank rule block.
    - If you are adding a rule to existing rules, the new block is
      appended at the bottom, and the page scrolls to the new rule.
    - As you add or remove rule blocks, the legend containing the rule
      count updates so that the numbers are sequential.
    - In each rule block, "age" and "substitutions" are now required.
      The age field is now validated to require a number.
    - The add/remove condition/substitution links now have more
      descriptive text labels.
    - The control to remove a rule is now a link in the <legend> element
      associated with each rule.
- Most JavaScript for this page is now in a separate file.
- Breadcrumbs are updated to be a little more specific.

To test, apply the patch and clear your browser cache if necessary.

- Go to Tools -> Automatic item modifications by age.
- Test adding and removing rules.
- Test removing all rules.
- Test adding and removing conditions and substitutions within rules.
- Test submitting the form without filling in required fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:07:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:07:32 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-ASVaYvWjoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51188|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51234&action=edit
Bug 13041 - Can't add user as manager of basket if name includes a single quote

If you are trying to add a user as a manager of a basket in
acquisitions, a JavaScript error will be triggered if that user has a
single quote in their name (e.g. "O'Neil"). This patch corrects the
issue by removing the "onclick" attribute and using the JS change made
in Bug 16386.

Also changed by this patch: Increased the size of the patron search
popup and made a correction to some invalid HTML.

To test you should have a patron whose name contains a single quote who
is also a user with permission to manage acquisitions.

- Apply the patch and go to Acquisitions.
- Locate an open basket and view the details for that basket.
- In the "Managed by" section, click the "Add user" button to trigger
  the patron search popup.
- Search for the patron described above and click the "Add" button.
- In the parent window, the patron you chose should have been added to
  the "Managed by" section.

Tested on top of Bug 16383, behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:08:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:08:14 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-SfkAiQbeE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:09:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:09:01 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be
	removed
In-Reply-To: <bug-7976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-FnAhbUWO8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

--- Comment #16 from Bouzid <bouzid.fergani at inlibro.com> ---
Ok Jonathan.
thanks.
Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:16:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:16:48 +0000
Subject: [Koha-bugs] [Bug 16448] New: Perlcritic errors introduced by 12478
Message-ID: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

            Bug ID: 16448
           Summary: Perlcritic errors introduced by 12478
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/00-testcritic.t 
t/00-testcritic.t .. 113/728 
#   Failed test 'Test::Perl::Critic for "catalogue/search.pl"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "catalogue/search.pl":
# "@results" is declared but not used at line 475, column 1.  Unused variables
clutter code and make it harder to read.  (Severity: 3)
t/00-testcritic.t .. 262/728 
#   Failed test 'Test::Perl::Critic for "Koha/Authority.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "Koha/Authority.pm":
# "return" statement with explicit "undef" at line 67, column 9.  See page 199
of PBP.  (Severity: 5)
t/00-testcritic.t .. 723/728 # Looks like you failed 2 tests of 728.
t/00-testcritic.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/728 subtests 

Test Summary Report
-------------------
t/00-testcritic.t (Wstat: 512 Tests: 728 Failed: 2)
  Failed tests:  114, 265
  Non-zero exit status: 2
Files=1, Tests=728, 139 wallclock secs ( 0.20 usr  0.01 sys + 127.21 cusr 10.62
csys = 138.04 CPU)
Result: FAIL
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:16:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:16:59 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-ovQ3aW6cXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com
         Depends on|                            |12478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:16:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:16:59 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-CG79rQ0zHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16448


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448
[Bug 16448] Perlcritic errors introduced by 12478
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:17:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:17:41 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-1CsGmkbFnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:17:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:17:46 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-pZY79sqrQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51235&action=edit
Bug 16402: Make kohastructure.sql valid for MySQL v5.7

A primary key should not contain null value, and MySQL v5.7 is now more
strict and won't accept our errors in the DB structure.

Test plan:
  mysql < installer/data/mysql/kohastructure.sql
should work using MySQL v5.7

QA:
- letter.branchcode should not be NULL, the default (all) is an empty
string
- permissions.code should not be NULL, it's always a string

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:18:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:18:25 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-7wdI4RipSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51216|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51236&action=edit
Bug 16439: Allow styling to button for upload local cover images (Font Awesome
Icons)

Improve button for upload local cover image with Font Awesome Icon

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the button upload.
-Apply the patch and reload the page.
-The button is changed for class=btn btn-mini like the button "edit"
 used in items in the tab Holdings
-Also added the Font Awesome icon upload "fa fa-upload" class.

Button is styled as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:19:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:19:24 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-7xuOrBZVqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:22:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:22:24 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-XjULmULYqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:22:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:22:27 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-HYIMtB1nyw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51237&action=edit
Bug 16448: Fix perlcritic errors introduced by 12478

Bug 12478 introduced two perlcritic errors. This patch fixes them.

To test:
- On master, run:
  $ prove t/t/00-testcritic.t
=> FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests.
- Apply the patch
- Run:
  $ prove t/t/00-testcritic.t
=> SUCCESS: All happy
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:25:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:25:44 +0000
Subject: [Koha-bugs] [Bug 16449] New: unimarc_field_4XX raises a warning
Message-ID: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449

            Bug ID: 16449
           Summary: unimarc_field_4XX raises a warning
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14828

Because of bug 14828, the unimarc_field_4XX now raises a warning:
"No method selected!"

There are no need to select an item type on this page, the default (all) is
always selected.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828
[Bug 14828] Move the item types related code to Koha::ItemTypes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:25:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:25:44 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: <bug-14828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14828-70-4ApAQ9DmZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449
[Bug 16449] unimarc_field_4XX raises a warning
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:27:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:27:00 +0000
Subject: [Koha-bugs] [Bug 16450] New: Remove the use of "onclick" from
 guarantor search template
Message-ID: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

            Bug ID: 16450
           Summary: Remove the use of "onclick" from guarantor search
                    template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/members/guarantor_search.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13041, 16386

When adding a guantor to a patron record, a search form is shown in a popup
window. This page should be reworked to avoid the use of "onclick."


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041
[Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386
[Bug 16386] Replace the use of "onclick" from patron card creator templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:27:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:27:00 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-mK6k0Qd2vz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16450


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450
[Bug 16450] Remove the use of "onclick" from guarantor search template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:27:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:27:00 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-a69oWxYDwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16450


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450
[Bug 16450] Remove the use of "onclick" from guarantor search template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:27:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:27:58 +0000
Subject: [Koha-bugs] [Bug 16451] New: Fix missisng body id in
	orders_by_budget.tt
Message-ID: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

            Bug ID: 16451
           Summary: Fix missisng body id in orders_by_budget.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:

- Run:
  $ prove xt/tt_valid.t
=> FAIL: Tests fail on orders_by_budget.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:28:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:28:05 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-Pky5Ov46wb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16451


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451
[Bug 16451] Fix missisng body id in orders_by_budget.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:28:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:28:05 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missisng body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-Sf6TyjqezN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11371
           Assignee|oleonard at myacpl.org         |tomascohen at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371
[Bug 11371] Add a new report : Orders by budget
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:28:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:28:54 +0000
Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
In-Reply-To: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16449-70-vGnGbff78x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:28:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:28:57 +0000
Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
In-Reply-To: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16449-70-5Del3P9jSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51238&action=edit
Bug 16449: Remove "no method selected" warning from unimarc_field_4XX

Because of bug 14828, the unimarc_field_4XX now raises a warning:
"No method selected!"

There are no need to select an item type on this page, the default (all)
is always selected.

Test plan:
Link the unimarc_field_4XX value builder with on of the subfield
Edit a record, click on the value builder icon
Note the warning without the patch and that it's gone with the patch
applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:31:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:31:11 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missisng body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-e1jAfpJnI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:31:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:31:14 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missisng body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-PzcoVpWdji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51239&action=edit
Bug 16451: Fix missisng body id in orders_by_budget.tt

Bug 11371 introduced a new template, which fails the xt/tt_valid.t tests.

To test:
- On master, run:
  $ prove xt/tt_valid.t
=> FAIL: Tests fail on orders_by_budget.tt
- Apply the patch
- Run
  $ prove xt/tt_valid.t
=> SUCCESS: Tests don't fail on orders_by_budget.tt
- Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:32:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:32:39 +0000
Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate
	fields
In-Reply-To: <bug-12375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12375-70-QvMssd4Hnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Jenkins raises a warning:

No method update! at /srv/jenkins/workspace/Koha_Master_D8/C4/Serials.pm line
1602.

It seems that ->update should be replaced with ->store

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:35:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:35:09 +0000
Subject: [Koha-bugs] [Bug 16248] ModZebra doesn't update zebraqueue if ES is
	enabled
In-Reply-To: <bug-16248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16248-70-sbpVFPvXs8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16248

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:36:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:36:47 +0000
Subject: [Koha-bugs] [Bug 16452] New: PatronLists.t raises a warning
Message-ID: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

            Bug ID: 16452
           Summary: PatronLists.t raises a warning
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

% prove t/db_dependent/PatronLists.t
t/db_dependent/PatronLists.t .. 1/9 C4::Context->userenv not defined! at
Koha/List/Patron.pm line 66.
t/db_dependent/PatronLists.t .. 3/9 C4::Context->userenv not defined! at
Koha/List/Patron.pm line 66.
t/db_dependent/PatronLists.t .. 5/9 C4::Context->userenv not defined! at
Koha/List/Patron.pm line 66.
C4::Context->userenv not defined! at Koha/List/Patron.pm line 94.
C4::Context->userenv not defined! at Koha/List/Patron.pm line 94.
C4::Context->userenv not defined! at Koha/List/Patron.pm line 66.
t/db_dependent/PatronLists.t .. ok   
All tests successful.
Files=1, Tests=9,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.00 cusr  0.02
csys =  1.04 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:37:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:37:54 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-OyGjAI51eU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:37:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:37:57 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-QdNu8kI5V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51240&action=edit
Bug 16452: Remove the warnings raised by PatronLists.t

We need to define a userenv to get rid of the warnings

Test plan:
  prove t/db_dependent/PatronLists.t
should not return any warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:38:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:38:05 +0000
Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate
	fields
In-Reply-To: <bug-12375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12375-70-9vCF7XiFsi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375

Karl Holten <kholten at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholten at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:42:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:42:01 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-8wB0DblOEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51241&action=edit
Bug 16450 - Remove the use of "onclick" from guarantor search template

This patch updates the guarantor search template so that event
definition is done in the script rather than in an onclick attribute.

This patch also increases the size of the popup window to help prevent
the need for horizontal scrolling and adds Bootstrap style to the
"select" button.

To test, apply the patch and clear your browser cache if necessary.

- Go to Patrons and add a patron with a "child" category type.
- In the "Guarantor information" section, click the "Set to patron"
  button.
- In the pop-up window, search for a patron.
- Click the "Select" button next to a patron.
- The window should close, and the patron you selected should now appear
  as the guarantor. The guarantor's address information should be added
  to the "Main address" section.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:41:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:41:59 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-uhTIdLhmjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:43:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:43:24 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-zhorpp92kL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
(In reply to Jonathan Druart from comment #1)
(...)
> Note that the occurrences in sendbasket.pl and opac/svc/login should
> have been removed by bug 16447.
We are on Bug 16447 - mistake of bug number?

> Test plan:
>   git grep 'borrow => 1'
> should not return any results.

Is OK, but git grep 'borrow ' finds additonally:

edithelp.pl:            borrow           => 1,
t/db_dependent/Auth.t:            borrow            => 0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:47:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:47:12 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missisng body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-rHj8N7nKE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:47:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:47:14 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missisng body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-zDwPFH2Djl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51239|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51242&action=edit
[SIGNED-OFF] Bug 16451: Fix missisng body id in orders_by_budget.tt

Bug 11371 introduced a new template, which fails the xt/tt_valid.t tests.

To test:
- On master, run:
  $ prove xt/tt_valid.t
=> FAIL: Tests fail on orders_by_budget.tt
- Apply the patch
- Run
  $ prove xt/tt_valid.t
=> SUCCESS: Tests don't fail on orders_by_budget.tt
- Sign off

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:53:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:53:15 +0000
Subject: [Koha-bugs] [Bug 16453] New:
 t/db_dependent/Koha_ElasticSearch_Indexer.t should use koha-conf.xml
 information
Message-ID: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

            Bug ID: 16453
           Summary: t/db_dependent/Koha_ElasticSearch_Indexer.t should use
                    koha-conf.xml information
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: tomascohen at gmail.com
        QA Contact: gmcharlt at gmail.com

t/db_dependent/Koha_ElasticSearch_Indexer.t currently has hardcoded information
about the ES server it needs to use.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:53:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:53:24 +0000
Subject: [Koha-bugs] [Bug 16453] t/db_dependent/Koha_ElasticSearch_Indexer.t
 should use koha-conf.xml information
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-GKVRjYVHxC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:53:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:53:24 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-H3ndRurbTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16453


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453
[Bug 16453] t/db_dependent/Koha_ElasticSearch_Indexer.t should use
koha-conf.xml information
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:53:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:53:39 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-4FNu29WXoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51222|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51244&action=edit
Bug 16444: Make C4::Tags plack safe

C4::Tags use a package variable to cache the pref
TagsExternalDictionary, it's not needed and not safe.

There is not test plan, just make sure the changes are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:53:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:53:34 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-sROq5tnyhl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51233|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51243&action=edit
Bug 16437 - Automatic item modifications by age needs prettying

This patch makes layout and behavior changes to the automatic item
modifications by age interface, bringing some aspects of it closer into
conformance with established interface patterns.

- The intial view is now a standard table of information about existing
  rules, or a message dialog saying there are no rules.
- If there are no rules, a toolbar button reads "Add rules."
- If there are existing rules, the toolbar button reads "Edit rules."
  - Clicking the button leads to the rules edit interface, which now has
    a floating toolbar with "Add rule," "Save," and "Cancel" buttons.
  - Clicking the "Add rule" button displays a blank rule block.
    - If you are adding a rule to existing rules, the new block is
      appended at the bottom, and the page scrolls to the new rule.
    - As you add or remove rule blocks, the legend containing the rule
      count updates so that the numbers are sequential.
    - In each rule block, "age" and "substitutions" are now required.
      The age field is now validated to require a number.
    - The add/remove condition/substitution links now have more
      descriptive text labels.
    - The control to remove a rule is now a link in the <legend> element
      associated with each rule.
- Most JavaScript for this page is now in a separate file.
- Breadcrumbs are updated to be a little more specific.

To test, apply the patch and clear your browser cache if necessary.

- Go to Tools -> Automatic item modifications by age.
- Test adding and removing rules.
- Test removing all rules.
- Test adding and removing conditions and substitutions within rules.
- Test submitting the form without filling in required fields.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:54:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:54:10 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-HZzu6dAeim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:59:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:59:02 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-8e5NnvIE0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51240|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51245&action=edit
Bug 16452: Remove the warnings raised by PatronLists.t

We need to define a userenv to get rid of the warnings

Test plan:
  prove t/db_dependent/PatronLists.t
should not return any warnings

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 16:59:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 14:59:36 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-RZRvdI8DPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 17:04:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 15:04:49 +0000
Subject: [Koha-bugs] [Bug 16454] New: Use "inventory" instead of
	"inventory/stocktaking"
Message-ID: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

            Bug ID: 16454
           Summary: Use "inventory" instead of "inventory/stocktaking"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/tools/inventory.pl
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

We don't say "check out/issue" or "patron/member," so I don't think we should
use "inventory/stocktaking." Let's just say "inventory."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 17:16:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 15:16:49 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-90aIQU5tnF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51231|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51246&action=edit
Bug 16447: Remove occurrence of the borrow permission which does no longer
exist

Bug 7976 has removed this permission, but other patches re-added it...
Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should
have been removed by bug 7976.

Test plan:
  git grep 'borrow.*=> 1'
should not return any results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 17:19:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 15:19:52 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-yP4bVErHB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marc V?ron from comment #2)
> (In reply to Jonathan Druart from comment #1)
> (...)
> > Note that the occurrences in sendbasket.pl and opac/svc/login should
> > have been removed by bug 16447.
> We are on Bug 16447 - mistake of bug number?
> 
> > Test plan:
> >   git grep 'borrow => 1'
> > should not return any results.
> 
> Is OK, but git grep 'borrow ' finds additonally:
> 
> edithelp.pl:            borrow           => 1,
> t/db_dependent/Auth.t:            borrow            => 0

Good catches, fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 17:57:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 15:57:43 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-RnWV7hFD0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455
[Bug 16455] TagsExternalDictionary does not work under Plack
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 17:57:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 15:57:43 +0000
Subject: [Koha-bugs] [Bug 16455] New: TagsExternalDictionary does not work
	under Plack
Message-ID: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

            Bug ID: 16455
           Summary: TagsExternalDictionary does not work under Plack
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16444

The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an other
dictionary, different from the default one (/usr/bin/ispell).

To do so we need to set $Lingua::Ispell::path to the expected path.
It's currently done in the INIT block.

If you try to use C4::Tags, you will get the famous "Too late to run INIT block
at C4/Tags.pm line 74." warning. Plack use the INIT block to load functions at
run time, when we are using C4::Tags when hitting a pl script, the compilation
phase is finished and it's "too late to run INIT block" from C4::Tags.

I do not really know if it has an impact on the behavior of Lingua::Ispell
(i.e. is the path redefined?), but I know that this INIT block is not executed
when we want.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444
[Bug 16444] C4::Tags is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:00:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:00:21 +0000
Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under
	Plack
In-Reply-To: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16455-70-0qfsROf7gk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:00:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:00:24 +0000
Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under
	Plack
In-Reply-To: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16455-70-Gm3lyksoYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51247&action=edit
Bug 16455: Remove the "Too late to run INIT block" from C4::Tags

The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an
other dictionary, different from the default one (/usr/bin/ispell).

To do so we need to set $Lingua::Ispell::path to the expected path.
It's currently done in the INIT block.

If you try to use C4::Tags, you will get the famous "Too late to run
INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to
load functions at run time, when we are using C4::Tags when hitting a pl
script, the compilation phase is finished and it's "too late to run INIT
block" from C4::Tags.

I do not really know if it has an impact on the behavior of
Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT
block is not executed when we want.

Test plan:
under Plack,
- hit /cgi-bin/koha/opac-search.pl and confirm that the warning does no
longer appears
- Use another dictionnary (??), fill TagsExternalDictionary with its
  path and confirm that it is used by the tags approval system

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:19:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:19:12 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should use
 koha-conf.xml information and skip if absent
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-ciqm2E7IYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|t/db_dependent/Koha_Elastic |Elasticsearch tests should
                   |Search_Indexer.t should use |use koha-conf.xml
                   |koha-conf.xml information   |information and skip if
                   |                            |absent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:26:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:26:44 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should use
 koha-conf.xml information and skip if absent
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-ZhfpPKzwU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:27:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:27:24 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should use
 koha-conf.xml information and skip if absent
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-uMqaEwGs2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:27:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:27:27 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should use
 koha-conf.xml information and skip if absent
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-RFPX3Y5BbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51248&action=edit
Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing

The current tests fail to run if the configuration entry is missing. This is
problematic on jenkins and should be fixed.

To test:
- On master, having koha-conf.xml without (or commented) an <elasticsearch>
entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> FAIL: Tests fail due to missing configuration entry
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped
- Have elasticsearch running and the koha-conf.xml entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Same results as without the patch
- Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 18:28:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 16:28:02 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-I7SH5uB8z6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Elasticsearch tests should  |Elasticsearch tests should
                   |use koha-conf.xml           |be skipped if configuration
                   |information and skip if     |entry missing
                   |absent                      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 19:37:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 17:37:40 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-xLnMGW05Yo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456
[Bug 16456] Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 19:37:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 17:37:40 +0000
Subject: [Koha-bugs] [Bug 16456] New: Add Font Awesome icons to some buttons
 in Tools module, section Patrons and circulation
Message-ID: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

            Bug ID: 16456
           Summary: Add Font Awesome icons to some buttons in Tools
                    module, section Patrons and circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16438, 16439

Add Font Awesome Icons to section Patrons and circulation in Tools module
(Save, Upload, Filter, Import)

Also the Tag and Comments tools has been revised to fit with others 
interfaces in Koha.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438
[Bug 16438] Use Font Awesome icons in batch templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439
[Bug 16439] Allow styling to button for upload local cover images (Font Awesome
Icons)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 19:37:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 17:37:40 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-XFKN8NxYJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456
[Bug 16456] Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:07:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:07:38 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-9cWmsF4urj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:07:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:07:40 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-DFJpliumHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51249&action=edit
Bug 16456: Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation

Add Font Awesome Icons to section Patrons and circulation in Tools module
(Save, Upload, Filter, Import)

To test goto:
-Patron lists -> New patron List -> Save
-Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,
 Clear all, Select all
-Comments -> Approve, delete and, unapprove
-Import patrons -> Import
-Overdue notice/status triggers -> Save changes
-Batch patron modification -> Save, Select all and Clear all
-Upload patron images -> Upload
-Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all,
 Select all pending. Set TagsModeration to Require.
-Verify that all tools work as expected

NOTE: The Tag and Comments tools has been revised to fit with others
interfaces in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:10:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:10:03 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-VxMBqX2HSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51250&action=edit
New look for comments tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:11:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:11:12 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-Grza3qZpsz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #3 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51251&action=edit
New look for tags tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:27:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:27:45 +0000
Subject: [Koha-bugs] [Bug 16411] Make Hold.t not depend on two existing
	branches
In-Reply-To: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16411-70-cZ2gZquZrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16411

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:28:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:28:57 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-FyKuetWlaE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:30:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:30:08 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-ZnVYRtQuuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:31:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:31:06 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-YniapMoUYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:43:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:43:10 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-VkDhx0o2yy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix missisng body id in     |Fix missing body id in
                   |orders_by_budget.tt         |orders_by_budget.tt
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:53:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:53:18 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-TaOa1Ohaet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457
[Bug 16457] Remove the use of "onclick" from the patron entry form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:53:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:53:18 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-IMhf2MSwm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457
[Bug 16457] Remove the use of "onclick" from the patron entry form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:53:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:53:18 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-W5CJk3crxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457
[Bug 16457] Remove the use of "onclick" from the patron entry form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 20:53:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 18:53:18 +0000
Subject: [Koha-bugs] [Bug 16457] New: Remove the use of "onclick" from the
 patron entry form
Message-ID: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

            Bug ID: 16457
           Summary: Remove the use of "onclick" from the patron entry form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/members/memberentry.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 13041, 16386, 16450

There are several instances of "onclick" in memberentrygen.tt. It should be
rewritten so that JS functionality can be separate from the markup.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041
[Bug 13041] Can't add user as manager of basket if name includes a single quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386
[Bug 16386] Replace the use of "onclick" from patron card creator templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450
[Bug 16450] Remove the use of "onclick" from guarantor search template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:04:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:04:40 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-DKeBRhS437@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|chris at bigballofwax.co.nz    |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:05:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:05:20 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-rMNrYcavfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:05:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:05:59 +0000
Subject: [Koha-bugs] [Bug 16458] New: Setting to guarantor: JavaScript error
 form.branchcode is undefined
Message-ID: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

            Bug ID: 16458
           Summary: Setting to guarantor: JavaScript error form.branchcode
                    is undefined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To reproduce:
- Go to a child parton's detail page
- Edit it using the toolbar item "Edit"
- Edit "Guarantor information", "Set to patron" or "Change patron"
- Select a patron
=>Result OK (patron search window closes, guarantor information is set,
  e.g. Library changes to Guarantor's library if it is different)
- Go back to child patron's detail page
- This time do not use toolbar "Edit" but the "Edit" link below "Date of birth"
/ "Guarantor"
- Edit "Guarantor information", "Set to patron" or "Change patron"
- Select a patron
=>Result NOT OK (patron search window does not close, JavaScript console says: 
  TypeError: form.branchcode is undefined
  (...)/intranet-tmpl/prog/js/members.js
  Line: 213
  Some of the Guarantor's information is not set, e.g. library if it is
different.

I found this while testing Bug 16450, this error appears without and with 16450
applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:08:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:08:21 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-xi0qXfqNdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51241|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51252&action=edit
Bug 16450 - Remove the use of "onclick" from guarantor search template

This patch updates the guarantor search template so that event
definition is done in the script rather than in an onclick attribute.

This patch also increases the size of the popup window to help prevent
the need for horizontal scrolling and adds Bootstrap style to the
"select" button.

To test, apply the patch and clear your browser cache if necessary.

- Go to Patrons and add a patron with a "child" category type.
- In the "Guarantor information" section, click the "Set to patron"
  button.
- In the pop-up window, search for a patron.
- Click the "Select" button next to a patron.
- The window should close, and the patron you selected should now appear
  as the guarantor. The guarantor's address information should be added
  to the "Main address" section.

Tested on top of Bug 13041 and Bug 16386, works as expected, however see
Bug 16458
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:09:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:09:01 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-3bY1y5a2ow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16450

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:09:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:09:01 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-0Y4ZSWUdth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16458
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:16:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:16:55 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-e2EBHRShNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51246|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 51253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51253&action=edit
Bug 16447: Remove occurrence of the borrow permission which does no longer
exist

Bug 7976 has removed this permission, but other patches re-added it...
Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should
have been removed by bug 7976.

Test plan:
  git grep 'borrow.*=> 1'
should not return any results.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:17:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:17:17 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-cuyqNrTTyP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:19:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:19:16 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
	entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-e1dCc0VDFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:19:28 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-zG0lDq9sap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51237|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51254&action=edit
[SIGNED-OFF]Bug 16448: Fix perlcritic errors introduced by 12478

Bug 12478 introduced two perlcritic errors. This patch fixes them.

To test:
- On master, run:
  $ prove t/00-testcritic.t
=> FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests.
- Apply the patch
- Run:
  $ prove t/00-testcritic.t
=> SUCCESS: All happy
- Sign off :-D

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
All test successful. Needs $ export TEST_QA=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:19:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:19:39 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-eyuf03vQiY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:20:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:20:48 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-irZUIPRpq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #8 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:26:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:26:45 +0000
Subject: [Koha-bugs] [Bug 14005] Fix wording of
 previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder
In-Reply-To: <bug-14005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14005-70-88vuUaSvNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:27:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:27:10 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-vf9mllg1CD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #16 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi Danielle, you forgot to change the bug status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:46:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:46:49 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-xox664iBti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:46:51 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-ppwwS2Kd81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51227|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51255&action=edit
[PASSED QA] Bug 16445: Revert changes made by bug 12478 to Koha/Database.pm

These changes were a mistake, let's revert them.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:50:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:50:08 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-dntcxmhBM4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:50:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:50:11 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-hqnFqsT4DB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51236|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51256&action=edit
[PASSED QA] Bug 16439: Allow styling to button for upload local cover images
(Font Awesome Icons)

Improve button for upload local cover image with Font Awesome Icon

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the button upload.
-Apply the patch and reload the page.
-The button is changed for class=btn btn-mini like the button "edit"
 used in items in the tab Holdings
-Also added the Font Awesome icon upload "fa fa-upload" class.

Button is styled as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:50:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:50:21 +0000
Subject: [Koha-bugs] [Bug 16438] Use Font Awesome icons in batch templates
In-Reply-To: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16438-70-okQFeKvU9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #15 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - should be in the May 2016 Release.  thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:51:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:51:29 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-Lk0TlnAQD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - should be in the May 2016 Release.  thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:52:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:52:16 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-EFTnn66gJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - should be in the May 2016 Release.  thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:52:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:52:58 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-SkscaxQVL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:53:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:53:02 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-7rpzkyPFZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51245|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51257&action=edit
[PASSED QA] Bug 16452: Remove the warnings raised by PatronLists.t

We need to define a userenv to get rid of the warnings

Test plan:
  prove t/db_dependent/PatronLists.t
should not return any warnings

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 21:58:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 19:58:00 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-wqokCZNOGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #17 from Danielle Elder <danielle at bywatersolutions.com> ---
Status is signed off.  Do you mean in giz bz? (I am a novice here, so let me
know).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:10:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:10:11 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-XpEnl8efh2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51249|0                           |1
        is obsolete|                            |

--- Comment #4 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51258&action=edit
Bug 16456: Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation

Add Font Awesome Icons to section Patrons and circulation in Tools module
(Save, Upload, Filter, Import)

To test goto:
-Patron lists -> New patron List -> Save
-Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,
 Clear all, Select all
-Comments -> Approve, delete and, unapprove
-Import patrons -> Import
-Overdue notice/status triggers -> Save changes
-Batch patron modification -> Save, Select all and Clear all
-Upload patron images -> Upload
-Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all,
 Select all pending. Set TagsModeration to Require.
-Verify that all tools work as expected

NOTE: The Tag and Comments tools has been revised to fit with others
interfaces in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:17:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:17:49 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-ttfSuLefNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:17:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:17:52 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-agom2bdGU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51159|0                           |1
        is obsolete|                            |
  Attachment #51160|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51259&action=edit
[PASSED QA] Bug 16325: Add a test for SearchSuggestions when searching for
STATUS=''

Test fails as expected without second patch and passes OK with second patch.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:18:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:18:20 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-6J2SgHJl5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51260&action=edit
[PASSED QA] Bug 16325: Do not return all suggestions if search for STATUS=''

This is a quick and dirty way to fix a bad bug in a messy area.
The "unknown status" tab in the suggestions table display all the
suggestions. It should only display suggestions with a STATUS=''

Test plan:
- Create some suggestions
- Go to Home > Acquisitions > Suggestions management
- Edit some suggestions and give them different status,
e.g. accepted, rejected, pending.
- Verify that they appear in the tabs as appropriate
- Edit one suggestion, set "Mark selected as" to --Choose a status--
=> Without this patch: New tab "Status unknown" containing all
suggestions
=> With this patch: tab contains only suggestions with "Unknown status"

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:45:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:45:42 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-Go5am1UlIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:46:51 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-lFgI3Lmekg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:51:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:51:03 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-UKXOLyHzKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Richard Gardner <rtgardner90 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rtgardner90 at gmail.com

--- Comment #4 from Richard Gardner <rtgardner90 at gmail.com> ---
Hey there,

Was having this same problem. Just wanted to give you all a shout-out for the
fix. Was having trouble locating the file but eventually got it all worked out. 

Still ended up getting::

mysql: [Warning] Using a password on the command line interface can be
insecure.

but I found a workaround for that and now i've created and access the staff
interface via command line. I am still having some trouble connecting via
web-browser, but I suspect it's because I just set my nameservers up earlier
today and they haven't had time to propagate. I hope that is the "problem" at
least.

Otherwise I may need to figure out my host files, .conf files, or the proper
settings for my server's DNS manager.

Anyway, thanks again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:55:40 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-x5CAA4k0i2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 22:55:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 20:55:43 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-bWkHmubBU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51254|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51261&action=edit
[PASSED QA] Bug 16448: Fix perlcritic errors introduced by 12478

Bug 12478 introduced two perlcritic errors. This patch fixes them.

To test:
- On master, run:
  $ prove t/00-testcritic.t
=> FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests.
- Apply the patch
- Run:
  $ prove t/00-testcritic.t
=> SUCCESS: All happy
- Sign off :-D

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
All test successful. Needs $ export TEST_QA=1

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:05:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:05:58 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-80QBwEo2QH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:06:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:06:01 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-F7luLhdh5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51253|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51262&action=edit
[PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no
longer exist

Bug 7976 has removed this permission, but other patches re-added it...
Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should
have been removed by bug 7976.

Test plan:
  git grep 'borrow.*=> 1'
should not return any results.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:27:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:27:37 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-98E1oL5bbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:28:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:28:45 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-tWKVdGxmvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:41:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:41:57 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-V5l9tdi4w0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:42:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:42:00 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-jlvItOIZTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51248|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51263&action=edit
Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing

The current tests fail to run if the configuration entry is missing. This is
problematic on jenkins and should be fixed.

To test:
- On master, having koha-conf.xml without (or commented) an <elasticsearch>
entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> FAIL: Tests fail due to missing configuration entry
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped
- Have elasticsearch running and the koha-conf.xml entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Same results as without the patch
- Sign off

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:50:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:50:59 +0000
Subject: [Koha-bugs] [Bug 16459] New: Adding patrons to a patron card label
 batch requires 'routing' permission
Message-ID: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

            Bug ID: 16459
           Summary: Adding patrons to a patron card label batch requires
                    'routing' permission
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When adding patrons to a patron card batch using the search for patrons
feature, the required permission is 'routing'... which  makes no sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:51:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:51:06 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-XQYl2zREi3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:57:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:57:14 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-8h2nVacgME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May  5 23:57:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 21:57:17 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-KBtPVeMgfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51234|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51264&action=edit
[PASSED QA] Bug 16386 - Replace the use of "onclick" from patron card creator
templates

This patch removes the use of "onclick" from several patron card creator
templates. Events are defined instead in JavaScript.

Also changed:

- Patron search pop-up window is now slightly larger because I found it
  never quite large enough to prevent horizontal scrolling.
- Replaced "Borrower" with "Patron" in a couple of places.
- "Add" link in patron search pop-up is now styled as a Bootstrap
  button.
- Removed Bootstrap styles from some submit buttons.
- Some Font Awesome icons were made using the invalid element
  <icon></icon> instead of <i></i>. These are corrected.
- Fixed some other HTML validation errors.

To test, apply the patch and go to Tools -> Patron card creator.

- Choose New -> Card batch.
  - Click "Add patrons" and perform a search for patrons in the pop-up
    window.
  - Click the "Add" button. The corresponding borrowernumber should be
    added to the textarea in the parent window, and a message should
    appear at the top of the pop-up window confirming that the patron
    has been added. (Note: This patch fixes a version of Bug 13041 which
    prevented the "add" button from working on patrons whose name
    include an apostrophe).
  - In the parent page, in the list of patrons you added to the batch,
    confirm that clicking the "Delete" link triggers a confirmation
    dialog. Test both confirming and canceling.
  - Confirm that clicking the "Export" button next to an individual
    patron triggers a modal window.
    - In the export window, confirm that the "Cancel" link works to
      close the modal.
    - Click the "Export" button again and then the "Export" button in
      the modal.
      - Test that the "Done" button works to close the modal.
- Choose Manage -> Card batches.
  - Test the "Delete" and "Export" buttons as described above.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All works, no errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:00:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:00:04 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-EGSXvrR1l8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have problems testing this because I am missing ES dependencies (old Ubuntu
still). Can someone else take a look at this please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:01:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:01:27 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-44frdSXEyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #51264|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:01:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:01:47 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-IYVrp5njEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51234|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:02:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:02:00 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-AxQZEEN5Dj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:02:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:02:03 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-OhAGoPgpAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51189|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51265&action=edit
[PASSED QA] Bug 16386 - Replace the use of "onclick" from patron card creator
templates

This patch removes the use of "onclick" from several patron card creator
templates. Events are defined instead in JavaScript.

Also changed:

- Patron search pop-up window is now slightly larger because I found it
  never quite large enough to prevent horizontal scrolling.
- Replaced "Borrower" with "Patron" in a couple of places.
- "Add" link in patron search pop-up is now styled as a Bootstrap
  button.
- Removed Bootstrap styles from some submit buttons.
- Some Font Awesome icons were made using the invalid element
  <icon></icon> instead of <i></i>. These are corrected.
- Fixed some other HTML validation errors.

To test, apply the patch and go to Tools -> Patron card creator.

- Choose New -> Card batch.
  - Click "Add patrons" and perform a search for patrons in the pop-up
    window.
  - Click the "Add" button. The corresponding borrowernumber should be
    added to the textarea in the parent window, and a message should
    appear at the top of the pop-up window confirming that the patron
    has been added. (Note: This patch fixes a version of Bug 13041 which
    prevented the "add" button from working on patrons whose name
    include an apostrophe).
  - In the parent page, in the list of patrons you added to the batch,
    confirm that clicking the "Delete" link triggers a confirmation
    dialog. Test both confirming and canceling.
  - Confirm that clicking the "Export" button next to an individual
    patron triggers a modal window.
    - In the export window, confirm that the "Cancel" link works to
      close the modal.
    - Click the "Export" button again and then the "Export" button in
      the modal.
      - Test that the "Done" button works to close the modal.
- Choose Manage -> Card batches.
  - Test the "Delete" and "Export" buttons as described above.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All works, no errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:02:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:02:12 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-O6cRfPSRVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51264|0                           |1
        is obsolete|                            |
  Attachment #51264|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:08:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:08:14 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-9MOha1WqYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51234|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51266&action=edit
[PASSED QA] Bug 13041 - Can't add user as manager of basket if name includes a
single quote

If you are trying to add a user as a manager of a basket in
acquisitions, a JavaScript error will be triggered if that user has a
single quote in their name (e.g. "O'Neil"). This patch corrects the
issue by removing the "onclick" attribute and using the JS change made
in Bug 16386.

Also changed by this patch: Increased the size of the patron search
popup and made a correction to some invalid HTML.

To test you should have a patron whose name contains a single quote who
is also a user with permission to manage acquisitions.

- Apply the patch and go to Acquisitions.
- Locate an open basket and view the details for that basket.
- In the "Managed by" section, click the "Add user" button to trigger
  the patron search popup.
- Search for the patron described above and click the "Add" button.
- In the parent window, the patron you chose should have been added to
  the "Managed by" section.

Tested on top of Bug 16383, behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:10:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:10:45 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-llbPfjjC3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:10:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:10:48 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-qEbbtD7pU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51242|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51267&action=edit
[PASSED QA] Bug 16451: Fix missisng body id in orders_by_budget.tt

Bug 11371 introduced a new template, which fails the xt/tt_valid.t tests.

To test:
- On master, run:
  $ prove xt/tt_valid.t
=> FAIL: Tests fail on orders_by_budget.tt
- Apply the patch
- Run
  $ prove xt/tt_valid.t
=> SUCCESS: Tests don't fail on orders_by_budget.tt
- Sign off

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:26:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:26:48 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-IPnIGVsdR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:26:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:26:51 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-UvP92chLqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51133|0                           |1
        is obsolete|                            |
  Attachment #51229|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51268&action=edit
[PASSED QA] Bug 15823: Can still access patron discharge slip without having
the syspref on

EDIT: Fix for OPAC side
EDIT: Comment 10
EDIT: Merge conflicts

To test:
1) Ensure syspref useDischarge is disabled
2) Go to /cgi-bin/koha/members/discharge.pl?borrowernumber=X&discharge=1
3) Validate that you are still able to generate a discharge slip for this
patron
4) Apply patch and refresh page
5) Confirm that you are redirected to the circulation.pl page for the user and
that an error message is there.
OPAC SIDE
6) Go to the OPAC
7) Go to /cgi-bin/koha/opac-discharge.pl
8) Confirm you get a message saying discharges are disabled
9) Go to /cgi-bin/koha/opac-discharge.pl?op=request
10) Confirm you see same message

Sponsored-by: Catalyst IT

Followed test plan, works as expected (both staff client and OPAC).
Re-tested, works OK.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:27:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:27:37 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-UhQEW4CABM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51269&action=edit
[PASSED QA] Bug 15823: Redirect opac-discharge.pl to 404 page

See comment #17: Redirect to 404 in opac-discharge.pl and remove
message in template because with the redirect it will never be
reached.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:35:26 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-Ga2uroNqms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:35:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:35:29 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-xQuW1JNAzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51120|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51270&action=edit
[PASSED QA] Bug 16414: Drop aqorders.budgetgroup_id

This column has never been used and can be removed.

Test plan:
1/ update the schema
2/ prove t/db_dependent/Acquisition.t
should return green

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Test green pre & post patch
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:35:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:35:58 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-GErRjuvwLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51271&action=edit
Bug 16414: Follow-up - change to kohastructure.sql

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:43:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:43:47 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-QL3CmPyHnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:43:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:43:50 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-zxtZa4LyF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51115|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51272&action=edit
[PASSED QA] Bug 15919: Batch checkout - Display the due date

When an item has been checked out in a batch, the due date will now be
displayed in the information column.

Test plan:
Use the batch checkout to check some items out
Confirm that the due date is displayed if the items have been checked
out.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 00:50:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 22:50:53 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-fu6YAkQcho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 01:05:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 23:05:20 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-lMftQgZaFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51263|0                           |1
        is obsolete|                            |

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51273&action=edit
Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing

The current tests fail to run if the configuration entry is missing. This is
problematic on jenkins and should be fixed.

To test:
- On master, having koha-conf.xml without (or commented) an <elasticsearch>
entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> FAIL: Tests fail due to missing configuration entry
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped
- Have elasticsearch running and the koha-conf.xml entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Same results as without the patch
- Sign off

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 01:05:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 23:05:18 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-E5UU9pxtWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 01:17:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 23:17:38 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-m6T8FMDSBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51274&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 01:18:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 23:18:54 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-6LNtSeWCYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 01:18:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 23:18:57 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-6kNiox0qcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51147|0                           |1
        is obsolete|                            |
  Attachment #51148|0                           |1
        is obsolete|                            |
  Attachment #51274|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51275&action=edit
[PASSED QA] Bug 16426: Add tests for ModMember - do not update userid

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 01:19:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 May 2016 23:19:43 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-6QwY0o95Rr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51276&action=edit
[PASSED QA] Bug 16426: follow-up of bug 15840 - correctly manage userid while
inserting patrons

Bug 15840 tried to fix a bug but makes things more complicated than it
was before.
If an userid is not provided for 1 or more rows of the csv file, it
should not be updated. However, if a userid is provided and it already
used by an other patron, the import should fail for this row (but not
crash!).

Test plan:
0/ Create a patron with a userid=your_userid
1/ Use the import patron tool to update this userid
=> userid should have been updated
2/ Update another data and do not provide the userid
=> data should have been updated and not the userid
3/ Update another data and provide the userid, but set it to an empty
string, or '0'
=> data should have been updated and not the userid
4/ Update another patron, and set userid=your_userid
=> Update should fail and an error whouls be displayed ("already used by
another patron")

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 05:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 03:42:37 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-kxJC8ACGlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #12 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed To Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 05:47:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 03:47:35 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-ZSmFFEm4n6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed To Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 05:48:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 03:48:35 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-aRg4kxdjSd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed To Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 06:07:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 04:07:57 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-DBphPGbRPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 06:20:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 04:20:27 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-Dzo09wuddN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 06:21:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 04:21:39 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-Ilv2VLmkcO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 06:23:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 04:23:33 +0000
Subject: [Koha-bugs] [Bug 16386] Replace the use of "onclick" from patron
 card creator templates
In-Reply-To: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16386-70-DRJUxjkthB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 06:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 04:24:54 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-7cPEH7ATQ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 08:01:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 06:01:14 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-zGZ7lOHxYk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If one of you could tell that Jonathan's patch works (sign off on it), this
would help to get the fix into Koha :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 08:06:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 06:06:00 +0000
Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all
 images on the OPAC
In-Reply-To: <bug-7706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7706-70-Jiv25bhba1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|Patch doesn't apply         |RESOLVED

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
AuthorisedValueImages has been removed from the code recently - which makes
this bug invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 08:07:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 06:07:03 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-z8dNtmcYsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16402

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please take a look at bug 16402 for a possible fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 08:07:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 06:07:03 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-CvkMcNZtyf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16393

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 08:11:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 06:11:09 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-wqg0ZY44np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When automatically          |When automatically deleting
                   |suppressing expired         |expired borrowers, make
                   |borrowers, make sure they   |sure they didn't log them
                   |didn't log them selves      |selves recently
                   |recently                    |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 10:41:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 08:41:08 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-9YI3ccIRNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13738

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 10:41:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 08:41:08 +0000
Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service
In-Reply-To: <bug-13738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13738-70-6zrCU4JwGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16330

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:44:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:44:59 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-6tDLrLaEKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51030|0                           |1
        is obsolete|                            |

--- Comment #133 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51277&action=edit
Bug 14695 - Update database

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:45:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:45:10 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-fYiEXQHkEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51031|0                           |1
        is obsolete|                            |

--- Comment #134 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51278&action=edit
Bug 14695 - Update DB Schema file

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:45:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:45:18 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-yfZzhR0uqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51032|0                           |1
        is obsolete|                            |

--- Comment #135 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51279&action=edit
Bug 14695 - Add new circulation rule

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:45:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:45:28 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-DFrIdCqpgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51033|0                           |1
        is obsolete|                            |

--- Comment #136 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51280&action=edit
Bug 14695 - Tidy C4::Reserves::CanItemBeReserved

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:45:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:45:36 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-LYWh0aOzvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51034|0                           |1
        is obsolete|                            |

--- Comment #137 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51281&action=edit
Bug 14695 - Add ability to place multiple item holds on a given record per
patron

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:45:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:45:46 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-Qe40vrN1tp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51035|0                           |1
        is obsolete|                            |

--- Comment #138 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51282&action=edit
Bug 14695 [QA Followup] - Filling one hold fills all of them

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:45:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:45:55 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-rCVmvrSsvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51036|0                           |1
        is obsolete|                            |

--- Comment #139 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51283&action=edit
Bug 14695 [QA Followup] - Make existing unit tests pass

* Removes tests no longer needed
* Updates rules to work with existing tests
* Fixes code issues revealed by unit tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:46:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:46:03 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-BU3eNBTI42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51037|0                           |1
        is obsolete|                            |

--- Comment #140 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51284&action=edit
Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:46:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:46:12 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-5ACcUNCYAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51038|0                           |1
        is obsolete|                            |

--- Comment #141 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51285&action=edit
Bug 14695 - Warn librarian if max_holds_per_record is reached

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:46:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:46:19 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-8xIF2ShY3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51039|0                           |1
        is obsolete|                            |

--- Comment #142 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51286&action=edit
Bug 14695 - Don't use holds_to_place_count when checking an item.

This fix the following bug:
If you select 2 in "Holds to place (count)" and finally
check an item, so you get 2 holds for the same item.

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:46:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:46:27 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-lJzdyWxLIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51040|0                           |1
        is obsolete|                            |

--- Comment #143 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51287&action=edit
Bug 14695 [QA Followup] - Fix method names 'type' to '_type'

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:46:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:46:34 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-bUpQptoMLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51041|0                           |1
        is obsolete|                            |

--- Comment #144 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51288&action=edit
Bug 14695: Fix typo in template

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 12:46:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 10:46:42 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-wNBYssJYOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51042|0                           |1
        is obsolete|                            |

--- Comment #145 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51289&action=edit
Bug 14695 [QA Followup] - Disable "Holds to place (count)" unless "Hold next
available item" is checked

Signed-off-by: Jason M. Burds <JBurds at dubuque.lib.ia.us>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 13:20:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 11:20:53 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-bWx7lZdCdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #13 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
1 out of 7 hunks FAILED -- saving rejects to file opac/opac-reserve.pl.rej
...
2 out of 3 hunks FAILED -- saving rejects to file reserve/placerequest.pl.rej

seems to conflict with Bug 15533 - Allow patrons and librarians to select
itemtype when placing holds pushed recently?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 14:37:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 12:37:04 +0000
Subject: [Koha-bugs] [Bug 16460] New: Update MARC21 frameworks to Update No.
 22 (April 2016)
Message-ID: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

            Bug ID: 16460
           Summary: Update MARC21 frameworks to Update No. 22 (April 2016)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org

New update: few new subfields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 14:41:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 12:41:38 +0000
Subject: [Koha-bugs] [Bug 16461] New: Add some information (branch and
 barcode) in fine description for overdue
Message-ID: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

            Bug ID: 16461
           Summary: Add some information (branch and barcode) in fine
                    description for overdue
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Some libraries need to display item's branch code and barcode number in each
fine line, set for overdues.
This way librarian avoid making a mistake and collect a fine for an item that
belongs to another branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:14:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:14:38 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-1Vk9Kkjs7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Patch doesn't apply

--- Comment #30 from Owen Leonard <oleonard at myacpl.org> ---
Nick, could I get you to rebase your patches? After that I'll see about fixing
up mine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:22:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:22:20 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-oQPUr8VIeE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #5 from R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> ---
Created attachment 51290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51290&action=edit
bug 5620 - Capture Mode of payment, receipt number and notes in pay fines.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:27:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:27:40 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-habOBbVcSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |remi.mayrand-provencher at inL
                   |                            |ibro.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:28:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:28:41 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-ZKcTpunjfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2997|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:29:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:29:36 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-MtsEs3fUXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |g.meyer at esgbonn.de

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 16393 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:29:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:29:36 +0000
Subject: [Koha-bugs] [Bug 16393] mysql  error 1171 in Web installer Step 3
In-Reply-To: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16393-70-pRdd9UzTXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16393

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 16402 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:51:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:51:43 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-fbwq470d4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51291&action=edit
Bug 16460: Update MARC21 frameworks to Update No. 22 (April 2016)

Update No. 22
Bibliographic
    New 382$r, 382$t, 753$0, 753$2
    Modified 382$e

Authority
    New 382$r, 382$t
    Modified 382$e

Also added final 'S' on 654 description

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 15:54:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 13:54:06 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-FjZX0FqNBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch
           Assignee|gmcharlt at gmail.com          |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:03:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:03:14 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-oJYEq3ervr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51292&action=edit
Bug 16336 - UX of holds patron search with long lists of results

Bug 15793 made a change to an interface which is also found in the place
hold template. This patch creates a new include file to be used by both
circulation.tt and request.tt so that these pages do not diverge.

In the process, this patch removes some markup and JavaScript which was
made obsolete by Bug 15793 and should have been removed.

This patch also revises the sorting of the results table so that the
patron name is sortable (Bug 16334) and the default sort is on card
number (matching 3.20.x and 3.22.x).

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- The table of results which displays should look correct and work
  correctly, including DataTables sorting.
- Clicking any table row should forward you to the checkout page for
  that patron.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the table of patron results looks correct and works
  correctly.
- Clicking any table row should forward you to the place hold page for
  that patron and the title you selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:04:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:04:04 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-xozi7z6gTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16334                       |
             Blocks|                            |16334
             Status|ASSIGNED                    |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334
[Bug 16334] Cannot sort checkout search by name
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:04:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:04:04 +0000
Subject: [Koha-bugs] [Bug 16334] Cannot sort checkout search by name
In-Reply-To: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16334-70-dHiPzvaoaB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16336                       |
         Depends on|                            |16336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336
[Bug 16336] UX of holds patron search with long lists of results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:05:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:05:52 +0000
Subject: [Koha-bugs] [Bug 16334] Cannot sort checkout search by name
In-Reply-To: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16334-70-Qt40IYl9TK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Instead of resubmitting this patch, I'm incorporating a corrected fix into Bug
16336, "UX of holds patron search with long lists of results."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:08:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:08:02 +0000
Subject: [Koha-bugs] [Bug 16334] Cannot sort checkout search by name
In-Reply-To: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16334-70-ePMITnkvd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:14:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:14:23 +0000
Subject: [Koha-bugs] [Bug 16462] New: Change default sorting of circulation
 patron search results to patron name
Message-ID: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

            Bug ID: 16462
           Summary: Change default sorting of circulation patron search
                    results to patron name
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 16336

At some point in the past the sorting of patron search results in circulation
(checkout and placing holds) changed from being sorted by name to being sorted
by card number. I think sorting by name is more useful in these interfaces.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336
[Bug 16336] UX of holds patron search with long lists of results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:14:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:14:23 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-2nbLsGHOKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16462


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462
[Bug 16462] Change default sorting of circulation patron search results to
patron name
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:20:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:20:31 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-tjAm2BWpsG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:20:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:20:35 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-YwzJQDgGQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51252|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51293&action=edit
Bug 16450 - Remove the use of "onclick" from guarantor search template

This patch updates the guarantor search template so that event
definition is done in the script rather than in an onclick attribute.

This patch also increases the size of the popup window to help prevent
the need for horizontal scrolling and adds Bootstrap style to the
"select" button.

To test, apply the patch and clear your browser cache if necessary.

- Go to Patrons and add a patron with a "child" category type.
- In the "Guarantor information" section, click the "Set to patron"
  button.
- In the pop-up window, search for a patron.
- Click the "Select" button next to a patron.
- The window should close, and the patron you selected should now appear
  as the guarantor. The guarantor's address information should be added
  to the "Main address" section.

Tested on top of Bug 13041 and Bug 16386, works as expected, however see
Bug 16458
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:24:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:24:28 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14695-70-YPNV6YDGE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #146 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #132)
> (In reply to Benjamin Daeuber from comment #131)
> > 1.	It appears staff can place item level holds when this feature is on,
> > regardless of whether item level holds are allowed. We tested on Wednesday,
> > and it appears Nicole has already identified this.
> 
> I'll look into this!

What about this point?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:30:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:30:33 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-B29Gcmbkwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1/ The age field is not mandatory
2/ The right member of the substitutions is not mandatory (you could empty it)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:31:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:31:57 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-ZILhltIoKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
3/ "Remove condition/substitution" moves the scrollbar to the top

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:32:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:32:43 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-5frfQ0siRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #5)
> 3/ "Remove condition/substitution" moves the scrollbar to the top

Also "Remove this rule"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:36:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:36:25 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-UIRy0flr1L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51291|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51294&action=edit
[SIGNED-OFF]Bug 16460: Update MARC21 frameworks to Update No. 22 (April 2016)

Update No. 22
Bibliographic
    New 382$r, 382$t, 753$0, 753$2
    Modified 382$e

Authority
    New 382$r, 382$t
    Modified 382$e

Also added final 'S' on 654 description

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:36:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:36:39 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-81mRsIFfSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:50:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:50:32 +0000
Subject: [Koha-bugs] [Bug 16463] New: OPAC discharge page should warn the
 user about checkouts before they request
Message-ID: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463

            Bug ID: 16463
           Summary: OPAC discharge page should warn the user about
                    checkouts before they request
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/opac-discharge.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

If you have checkouts you cannot request a discharge. The "ask for a discharge"
page on the OPAC should warn the user about their checkouts instead of waiting
to do so until after they have clicked on the "ask for a discharge" link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:50:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:50:43 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-Gb1RmnDEmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's a tricky one, the JS error occurs because the libraries select is not
displayed in the page. Should we update the library even if it's not displayed?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:57:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:57:44 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-em47FdSNvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:57:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:57:47 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-EtH1Otbk66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51295&action=edit
Bug 16459: Add patron to a patron card requires catalogue permission

Currently, serials => 'routing' is required, which does not make any
sense.
It's a copy/paste error when this file has been created (you can blame
me).

Note that I am not sure catalogue is the correct permission, but it's
the one used almost everywhere in this module

Test plan:
Confirm that catalogue is enough to search for patrons to add to a
patron card.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:57:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:57:55 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-i6bet9Ho6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |jonathan.druart at bugs.koha-c
                   |u                           |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 16:58:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 14:58:32 +0000
Subject: [Koha-bugs] [Bug 16464] New: If a patron has been discharged,
 show a message in the OPAC
Message-ID: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

            Bug ID: 16464
           Summary: If a patron has been discharged, show a message in the
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/opac-discharge.pl
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

When a patron is discharged a restriction is added to their account. In the
OPAC this triggers the default warning about the account being frozen.

If the restriction is for a discharge a different message should be shown, with
a link to the discharge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 17:02:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 15:02:54 +0000
Subject: [Koha-bugs] [Bug 16465] New: OPAC discharge page has no title tag
Message-ID: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

            Bug ID: 16465
           Summary: OPAC discharge page has no title tag
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/opac-discharge.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The OPAC discharge page should have a title tag.

It should also use the word "checkouts" instead of "issues."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 17:15:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 15:15:52 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-esUECtyF9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|show more on pending patron |Show more on pending patron
                   |requests                    |modification requests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 17:17:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 15:17:53 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-R1NwFIWRll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Looks like the only part of this bug which hasn't already been fixed is the
patron category.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 17:31:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 15:31:19 +0000
Subject: [Koha-bugs] [Bug 16466] New: Patron discharge page should show
	pending requests
Message-ID: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466

            Bug ID: 16466
           Summary: Patron discharge page should show pending requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/members/discharge.pl
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If a patron has requested a discharge via the OPAC, that request does not show
up on their discharge page in the staff client. I think it should.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 17:35:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 15:35:24 +0000
Subject: [Koha-bugs] [Bug 16467] New: Discharge requests pending count
 should appear on patrons home page
Message-ID: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16467

            Bug ID: 16467
           Summary: Discharge requests pending count should appear on
                    patrons home page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently the "Discharge requests pending" count appears only on the staff
client home page. Like the count of patrons requesting modification, the
discharge request count should also appear on the patrons home page
(members-home.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:14:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:14:27 +0000
Subject: [Koha-bugs] [Bug 16337] Remove the use of "onclick" from the stage
 MARC records template
In-Reply-To: <bug-16337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16337-70-TDmTmAn0eR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16468


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468
[Bug 16468] Remove last "onclick" from the stage MARC records template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:14:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:14:27 +0000
Subject: [Koha-bugs] [Bug 16468] New: Remove last "onclick" from the stage
 MARC records template
Message-ID: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

            Bug ID: 16468
           Summary: Remove last "onclick" from the stage MARC records
                    template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/tools/stage-marc-import.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle at bywatersolutions.com,
                    testopia at bugs.koha-community.org, veron at veron.ch
        Depends on: 16337

There is one more instance of "onclick" in stage-marc-import.tt which I didn't
catch in Bug 16337 somehow. It can be removed in favor of defining events in
the JavaScript.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337
[Bug 16337] Remove the use of "onclick" from the stage MARC records template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:26:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:26:53 +0000
Subject: [Koha-bugs] [Bug 16468] Remove last "onclick" from the stage MARC
 records template
In-Reply-To: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16468-70-pJ55LKA4c1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:26:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:26:55 +0000
Subject: [Koha-bugs] [Bug 16468] Remove last "onclick" from the stage MARC
 records template
In-Reply-To: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16468-70-YH0Q81Ua6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51296&action=edit
Bug 16468 - Remove last "onclick" from the stage MARC records template

This patch reviseds the stage MARC records template, removing
one more "onclick" attribute from the markup and defining that event in
the script.

This patch also corrects a missing quotation mark in the HTML. I have
done some reindentation to that section.

To test, apply the patch and go to Tools -> Stage MARC records for
import.

- Select a MARC file for import.
- Click the "Upload file" button.
- Click the "Stage for import" button. Your import should be correctly
  staged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:42:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:42:03 +0000
Subject: [Koha-bugs] [Bug 16469] New: Remove the use of "onclick" from some
	catalog pages
Message-ID: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469

            Bug ID: 16469
           Summary: Remove the use of "onclick" from some catalog pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Two catalog-related templates contain the use of "onclick" and should be
modified to remove it: catalogue/results.tt and catalogue/imageviewer.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:45:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:45:33 +0000
Subject: [Koha-bugs] [Bug 16249] Zebra-specific tests should pass with ES
	disabled
In-Reply-To: <bug-16249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16249-70-oOEeUgjWQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51297&action=edit
Bug 16469 - Remove the use of "onclick" from some catalog pages

This patch removes the use of "onclick" attributes from two
catalog-related templates: The local cover image viewer and the search
results page. Events are now defined in JavaScript.

To test:

On the search results page:

- Perform a catalog search which will return multiple results.
- On the search results page, confirm that the "Select all" and "Clear
  all" links at the top of the results table work correctly.

In the local cover image viewer:

- The LocalCoverImages and AllowMultipleCovers system preferences must
  enabled, and at least one catalog record must have at least two local
  cover images attached.
- Locate that record in the catalog and view the detail page for it.
- Click the cover image in the "Images" tab to go to the image viewer
  page.
- Clicking each local cover image thumnail should correctly display the
  larger version of each image.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:46:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:46:46 +0000
Subject: [Koha-bugs] [Bug 16249] Zebra-specific tests should pass with ES
	disabled
In-Reply-To: <bug-16249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16249-70-474Oua5ukI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51297|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Comment on attachment 51297
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51297
Bug 16469 - Remove the use of "onclick" from some catalog pages

Sorry, git-bz typo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:47:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:47:27 +0000
Subject: [Koha-bugs] [Bug 16469] Remove the use of "onclick" from some
	catalog pages
In-Reply-To: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16469-70-lTEVvKY8lY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 18:47:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 16:47:29 +0000
Subject: [Koha-bugs] [Bug 16469] Remove the use of "onclick" from some
	catalog pages
In-Reply-To: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16469-70-vdDP5p49Gl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51298&action=edit
Bug 16469 - Remove the use of "onclick" from some catalog pages

This patch removes the use of "onclick" attributes from two
catalog-related templates: The local cover image viewer and the search
results page. Events are now defined in JavaScript.

To test:

On the search results page:

- Perform a catalog search which will return multiple results.
- On the search results page, confirm that the "Select all" and "Clear
  all" links at the top of the results table work correctly.

In the local cover image viewer:

- The LocalCoverImages and AllowMultipleCovers system preferences must
  enabled, and at least one catalog record must have at least two local
  cover images attached.
- Locate that record in the catalog and view the detail page for it.
- Click the cover image in the "Images" tab to go to the image viewer
  page.
- Clicking each local cover image thumnail should correctly display the
  larger version of each image.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 19:27:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 17:27:26 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-yjhZVCjEIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Chris Kirby <christopherlawrencekirby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christopherlawrencekirby at gm
                   |                            |ail.com

--- Comment #11 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
I have applied the patches. However, I am seeing a "Please transfer item to"
message when I check in a book where patron home library and checkin library
are the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 20:26:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 18:26:23 +0000
Subject: [Koha-bugs] [Bug 16470] New: Update MARC21 es-ES frameworks to
 Update 22 (April 2016)
Message-ID: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

            Bug ID: 16470
           Summary: Update MARC21 es-ES frameworks to Update 22 (April
                    2016)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Follow EN update on Bug 16460

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 20:28:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 18:28:59 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-6C2fyOzhOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51299&action=edit
Bug 16470:

Same test plan of Bug 16460

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem, for
es-ES files
3) Check new fields/subfields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 20:29:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 18:29:55 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-6fynsJ848B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch
                 CC|                            |hector.hecaxmmx at gmail.com
           Assignee|gmcharlt at gmail.com          |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 22:00:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 20:00:05 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-fwpu7Lq38J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 22:00:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 20:00:08 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-An0LHl3z8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

--- Comment #7 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51300&action=edit
Bug 15816: Redirect back to correct page after login

This uses a hacky but simple method to get the correct script name under
proxied packaged Plack.

Test plan:
  1) Log out of both the OPAC and staff side.
  2) Try to access a page that requires login (opac-reserve.pl is a
good one for the OPAC), then log in.
  3) You will be redirected back to mainpage.pl or opac-user.pl.
  4) Repeat above for both staff side and OPAC.
  5) Apply patch.
  6) Repeat steps 1-4; you should be redirected back to the original
     page you were on.
  7) Repeat the above for both a traditional CGI and kohadevbox/package
     Plack installation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 22:00:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 20:00:54 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-NxJA6Ppuwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #8 from Jesse Weaver <jweaver at bywatersolutions.com> ---
This isn't a beautiful fix, but works around the problem without requiring
Apache config changes or new Perl modules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 22:29:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 20:29:59 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-k1fUSw4ypB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
(In reply to Jonathan Druart from comment #1)
> It's a tricky one, the JS error occurs because the libraries select is not
> displayed in the page. Should we update the library even if it's not
> displayed?

I think it should be consistent. 
If it's updated if you reach the form via the toolbar Edit it should be updated
as well if you go via the "Edit" link. Or it should not be updated in both
ways.

Maybe there are more values that are not consitently updated?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 22:46:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 20:46:16 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-Ki8Xftsnjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 22:46:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 20:46:19 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-mxu42lrijF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51235|0                           |1
        is obsolete|                            |

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51301&action=edit
[SIGNED-OFF] Bug 16402: Make kohastructure.sql valid for MySQL v5.7

A primary key should not contain null value, and MySQL v5.7 is now more
strict and won't accept our errors in the DB structure.

Test plan:
  mysql < installer/data/mysql/kohastructure.sql
should work using MySQL v5.7

QA:
- letter.branchcode should not be NULL, the default (all) is an empty
string
- permissions.code should not be NULL, it's always a string

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Clean install of Ubuntu 16.05, MySQL 5.7.11
kohastructure.sql loads ok, just one warning
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 23:19:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 21:19:26 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-MOnBwHc10C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51299|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51302&action=edit
Bug 16470: Update MARC21 es-ES frameworks to Update 22 (April 2016)

Same test plan of Bug 16460

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem, for
es-ES files
3) Check new fields/subfields

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
es-ES frameworks updated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 23:19:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 21:19:52 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-6fvR5gjZtz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
         Depends on|                            |16460


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460
[Bug 16460] Update MARC21 frameworks to Update No. 22 (April 2016)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May  6 23:19:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 21:19:52 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-G4DAtrf1tg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16470


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470
[Bug 16470] Update MARC21 es-ES frameworks to Update 22 (April 2016)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 00:00:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 22:00:27 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-oQPgHI0Qtf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #12 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Rebased against master with Bug 15126 and Bug 13903.

Also fixed tests failing above due to missing branchcode in AddIssue and
calculated duedate on renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 00:01:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 22:01:58 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-8sdfdWXq37@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50021|0                           |1
        is obsolete|                            |

--- Comment #13 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51303&action=edit
Bug 13895: Add API routes for checkouts retrieval and renewal

GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}

+ unit tests in t/db_dependent/api/v1/checkouts.t

Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
   XXX with a borrowernumber that has checkouts) and check you receive
   correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
   existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
   the maximum number of renewals is reached (you should have a 403
   error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t

Depends on bug 15126

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 00:02:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 May 2016 22:02:24 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-y7ZWrEPFEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 10:44:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 May 2016 08:44:15 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-kierYUw1k2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #8 from g.meyer at esgbonn.de ---
(In reply to Richard Gardner from comment #4)
> Hey there,
> 
> Was having this same problem. Just wanted to give you all a shout-out for
> the fix. Was having trouble locating the file but eventually got it all
> worked out. 
> 
> Still ended up getting::
> 
> mysql: [Warning] Using a password on the command line interface can be
> insecure.
> 
> but I found a workaround for that and now i've created and access the staff
> interface via command line. I am still having some trouble connecting via
> web-browser, but I suspect it's because I just set my nameservers up earlier
> today and they haven't had time to propagate. I hope that is the "problem"
> at least.
> 
> Otherwise I may need to figure out my host files, .conf files, or the proper
> settings for my server's DNS manager.
> 
> Anyway, thanks again.

Hello Richard,
I did not find the file. Could you please give me a hint?
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 13:54:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 May 2016 11:54:32 +0000
Subject: [Koha-bugs] [Bug 16471] New: Translatability: Fix issues in
 opac-password-recovery.tt
Message-ID: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

            Bug ID: 16471
           Summary: Translatability: Fix issues in
                    opac-password-recovery.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Fix sentence-splitting by a-tags.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 14:09:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 May 2016 12:09:27 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-KYKRqoEVBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51304&action=edit
Bug 16471: Translatability: Fix issues in opac-password-recovery.tt

This patch fixes issues with the translatability of opac-password-recovery.tt

To test:
- Apply patch
- Verify that text changes make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May  7 14:10:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 May 2016 12:10:29 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-i8dvZ0xxZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 09:51:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 07:51:25 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-XSnkh7WpP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |theod at lib.auth.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:08:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:08:46 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-VJfgHS65PY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Upping severity as this blocks people from being able to install Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:10:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:10:14 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-fBD4XDv5wr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com
           Assignee|nengard at gmail.com           |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|About                       |Installation and upgrade
                   |                            |(web-based installer)
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:13:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:13:53 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-DYYXguic4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I think this will work for new installations, but shouldn't we change
existing ones to match?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:24:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:24:29 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-OsoTKaPasI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:25:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:25:26 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-GpJ0xWyVrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51301|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51305&action=edit
[PASSED QA] Bug 16402: Make kohastructure.sql valid for MySQL v5.7

A primary key should not contain null value, and MySQL v5.7 is now more
strict and won't accept our errors in the DB structure.

Test plan:
  mysql < installer/data/mysql/kohastructure.sql
should work using MySQL v5.7

QA:
- letter.branchcode should not be NULL, the default (all) is an empty
string
- permissions.code should not be NULL, it's always a string

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Clean install of Ubuntu 16.05, MySQL 5.7.11
kohastructure.sql loads ok, just one warning
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:42:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:42:15 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-WblXfFMTNi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 11:42:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 09:42:18 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-ewgqZFOIU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51304|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51306&action=edit
Bug 16471: Translatability: Fix issues in opac-password-recovery.tt

This patch fixes issues with the translatability of opac-password-recovery.tt

To test:
- Apply patch
- Verify that text changes make sense.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 12:45:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 10:45:45 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-zR7x5gQxHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Hector,
thx a lot for taking the time to work on this!
Reading the XSLT is quite hard, but in my tests it looked alright.
I am not sure this was the way of fix Winona had thought of - I'd love to get
her opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 12:57:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 10:57:49 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-j86Z4TZjuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is it intentional to not display 100$t any longer with this patch? Can you
please check? It displays without this patch, 700$t displays with and without,
but sequence is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:18:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:18:45 +0000
Subject: [Koha-bugs] [Bug 16259] More: Replace CGI->param with
 CGI->multi_param in list context
In-Reply-To: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16259-70-ZbfCOWdPu9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:18:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:18:48 +0000
Subject: [Koha-bugs] [Bug 16259] More: Replace CGI->param with
 CGI->multi_param in list context
In-Reply-To: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16259-70-NPAr0Rt1vA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50986|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51307&action=edit
[PASSED QA] Bug 16259: Replace CGI->param with CGI->multi_param in list context
- part 2

This patch is a follow-up of bug 16154.

It removes the warning "CGI::param called in list context" in the
following scripts:
admin/branches.pl
admin/categories.pl
admin/patron-attr-types.pl
admin/preferences.pl
catalogue/image.pl
circ/circulation.pl
patroncards/add_user_search.pl
serials/add_user_search.pl
tools/marc_modification_templates.pl
virtualshelves/shelves.pl

Note that the warning from catalogue/itemsearch.pl still exists (the
call to CGI->param is done from the template).

Test plan:
- Add/modify a library, patron category, patron attr type
- Update a syspref
- Set localcoverimage and call catalogue/image.pl?biblionumber=XXX
- Search for patrons in the patron cards or serials module
- Add a marc modification templates
- Add a list (shelves)

You should not get the warning in the log after all these actions.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:30:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:30:04 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
	but not if renewed
In-Reply-To: <bug-9805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9805-70-HlaDdYckWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This patch no longer applies (see below)

Jonathan, do you oppose to continue testing this as is? Should we discuss more
widely?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 9805 - Lost items are un-lost if returned, but not if renewed.
Using index info to reconstruct a base tree...
M       C4/Circulation.pm
M       admin/smart-rules.pl
M       installer/data/mysql/kohastructure.sql
M       installer/data/mysql/updatedatabase.pl
M       koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
M       koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging admin/smart-rules.pl
CONFLICT (content): Merge conflict in admin/smart-rules.pl
Auto-merging C4/Circulation.pm
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:35:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:35:29 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-r8qMan5gLN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, took me too long to get back to this - patch currently doesn't
apply:

Applying: Bug 14390 - Fine not updated from 'FU' to 'F' on renewal
Using index info to reconstruct a base tree...
M       C4/Circulation.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
CONFLICT (content): Merge conflict in C4/Circulation.pm

I took a quick look, but not sure what caused the conflict in the first place
(which change/fix in master).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:46:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:46:39 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-LpHRNffYbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I keep thinking we should have a way to update the existing frameworks as well,
but we haven't done so for the last update, so this is in line to the current
practice.
Maybe sometime in the future some tool to point out missing fields/subfields in
an existing framework could be useful for the libraries?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:47:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:47:30 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-ScbhzUoxcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:47:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:47:32 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-sDcFH9SuCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51294|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51308&action=edit
[PASSED QA] Bug 16460: Update MARC21 frameworks to Update No. 22 (April 2016)

Update No. 22
Bibliographic
    New 382$r, 382$t, 753$0, 753$2
    Modified 382$e

Authority
    New 382$r, 382$t
    Modified 382$e

Also added final 'S' on 654 description

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
For comparison:
https://www.loc.gov/marc/bibliographic/bdapndxg.html
https://www.loc.gov/marc/authority/adapndxf.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:48:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:48:04 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-HPyUdHy82G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel this is somewhere between bug and enh... maintenance?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:50:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:50:35 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-WqLSb2w6C4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 13:50:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 11:50:38 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-B1UB0UBzrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51302|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51309&action=edit
[PASSED QA] Bug 16470: Update MARC21 es-ES frameworks to Update 22 (April 2016)

Same test plan of Bug 16460

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem, for
es-ES files
3) Check new fields/subfields

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
es-ES frameworks updated

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:01:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:01:39 +0000
Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription
	edit menu
In-Reply-To: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16231-70-4pF87bHW6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe my first test here was flawed. This is something I see retesting this:

- Set independentbranches to prevent
- Make sure staff patron doesn't have superserials permission
= I should not be allowed to change serials from other branches
- Go to another branches subscription (by URL manipulation)
- With the patches I can: renew (opens wrong window?), receive (ew!) and DELETE
- Without the patch on master, I can't delete (better)

I'd say this is a change of the behaviour that we don't want - allowing
deletions. But overall... permission handling in serials could still be
improved a lot.

Can we find a good fix for delete here and then see about the other problems
later?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:04:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:04:27 +0000
Subject: [Koha-bugs] [Bug 16231] Correct permission handling in subscription
	edit menu
In-Reply-To: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16231-70-JicCoGs1L1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think if you don't have edit_subscription, but delete an 'cannotedit = 0 (can
edit)' - then maybe show a single 'delete' button?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:08:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:08:54 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-AOdqCj0yCp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The patron card creator link on the tools home page uses:
CAN_user_tools_label_creator
I think that would make sense to me overall.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:11:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:11:24 +0000
Subject: [Koha-bugs] [Bug 16472] New: Update MARC21 es-ES frameworks to
 Update 22 (April 2016)
Message-ID: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

            Bug ID: 16472
           Summary: Update MARC21 es-ES frameworks to Update 22 (April
                    2016)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Changes from bug 16460 for German web installer files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:11:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:11:54 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-3r9vEAS0vz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Update MARC21 es-ES         |Update MARC21 de-DE
                   |frameworks to Update 22     |frameworks to Update 22
                   |(April 2016)                |(April 2016)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:16:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:16:36 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-NrWaJ2pgYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just finished translation, files for submitting should be ready tomorrow at:
http://translate.koha-community.org/files/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:20:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:20:48 +0000
Subject: [Koha-bugs] [Bug 16394] Fix formatting of review.tt
In-Reply-To: <bug-16394-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16394-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16394-70-MltVZDHqeh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Owen is right stating that we decided a while ago not to clean files globally
to avoid conflicts. Tab cleaning is a bit less difficult than perltidy, as it
does keep the lines the same and you can use -w to not see whitespace changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:24:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:24:24 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-KBmHXwdCOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like it!

But something I wonder about: do we really need all 5 options for changing the
holds sequence? 
We have the pull down which allows you to select a new number, we have up,
down, to the bottom, to the top.
The first and the last 4 allow you to achieve the same thing - with the first
option being the most flexible, as you can do all 4 with less clicks.
Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:24:54 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-zzfFCSBiCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:27:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:27:00 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-4wCFDDQY93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
see comment#4 - needs a follow-up to be about 'holds'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:41:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:41:48 +0000
Subject: [Koha-bugs] [Bug 16473] New: Tiny typeo: there was _an_ problem ...
Message-ID: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

            Bug ID: 16473
           Summary: Tiny typeo: there was _an_ problem ...
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

opac-tmpl/bootstrap/en/modules/opac-account.tt:48 
opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt:27

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:41:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:41:53 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typeo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-z7v1ujxpTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:52:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:52:28 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-wmOtoxWvX0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Tiny typeo: there was _an_  |Tiny typo: there was _an_
                   |problem ...                 |problem ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:59:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:59:09 +0000
Subject: [Koha-bugs] [Bug 16474] New: Standardize spelling of EDIFACT
Message-ID: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

            Bug ID: 16474
           Summary: Standardize spelling of EDIFACT
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

There are currently different spellings present in the templates for EDIFACT:
- Are you sure you want to generate an edifact order and close basket %s?
- Are you sure you want to close this basket and generate an Edifact order?
-  

As EDIFACT is an abbreviation, we should spell it like one:

https://en.wikipedia.org/wiki/EDIFACT
United Nations/Electronic Data Interchange For Administration, Commerce and
Transport (UN/EDIFACT)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 14:59:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 12:59:17 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-HWfoWVxIxz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 15:18:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 13:18:07 +0000
Subject: [Koha-bugs] [Bug 16475] New: Marc 700 $d incorrectly displays after
 $t in staff client and OPAC
Message-ID: <bug-16475-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16475

            Bug ID: 16475
           Summary: Marc 700 $d incorrectly displays after $t in staff
                    client and OPAC
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: imingchan at yahoo.com.au
        QA Contact: testopia at bugs.koha-community.org

Marc 700 incorrectly display subfield $d (Date associates with a name) after
subfield $t (Title of a work) in staff client and OPAC. 

Subfield display ignores the order found in cataloguing edit mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 15:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 13:23:00 +0000
Subject: [Koha-bugs] [Bug 16475] Marc 700 $d incorrectly displays after $t
 in staff client and OPAC
In-Reply-To: <bug-16475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16475-70-PcjCurnLYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16475

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 16343 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 15:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 13:23:00 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-NCE5TwZ8Nx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imingchan at yahoo.com.au

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16475 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 15:42:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 13:42:09 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-SRRs0KURId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #114 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, this patch no longer applies:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11592 - Updated License Text and use Modern::Perl
Using index info to reconstruct a base tree...
M       C4/Biblio.pm
M       C4/XSLT.pm
M       opac/opac-detail.pl
Falling back to patching base and 3-way merge...
Auto-merging C4/XSLT.pm
Auto-merging C4/Biblio.pm
Applying: Bug 11592 - Add should_hide_marc method to filter
Applying: Applying filtering to opac interface.
Applying: Biblio tweak for MARCSUBJECT
Applying: Bug 11592: MARCView and ISBD followup
fatal: sha1 information is lacking or useless (C4/Biblio.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 16:34:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 14:34:40 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-scheOe6fnX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 16:34:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 14:34:42 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-v9KnN9viDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51089|0                           |1
        is obsolete|                            |
  Attachment #51090|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51310&action=edit
[PASSED QA] Bug 16412: Make sure Koha::Cache->set_in_cache will not warn
anymore

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 16:35:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 14:35:15 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-rDv6b7D09j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51311&action=edit
[PASSED QA] Bug 16412: Cache undef in L1 only

No need to cache undef in L2.
Prevent numerous warnings like:
Use of uninitialized value in subroutine entry at
/usr/share/koha/masterclone/Koha/Cache.pm line 284

Test plan:
Run t/Cache.t
Run t/db_dependent/sysprefs.t

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: remove trailing space char and replace 'you' with 'we' to
match existing wordings.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 16:49:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 14:49:47 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-ko3lFDdME3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 16:49:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 14:49:50 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-vQgVF3315b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51312&action=edit
Bug 16474: Standardize spelling of EDIFACT

Some templates use Edifact and edifact. As EDIFACT
is an abbreviation, we should spell it like one.

To test:
- Check templates for occurrences of EDIFACT
  - acquisitions navigation menu
  - basket page
  - basketgroup page
  - EDIFACT messages page
- Verify changes are correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May  8 17:01:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 May 2016 15:01:21 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-et5CrhIg6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 02:27:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 00:27:25 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-UPA2fwk0U3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #115 from M. Tompsett <mtompset at hotmail.com> ---
The OPACISBD variable bug caused this. I'll work on a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 03:43:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 01:43:01 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-tiCFuPfT5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50550|0                           |1
        is obsolete|                            |

--- Comment #116 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51313&action=edit
Bug 11592 - Updated License Text and use Modern::Perl

Why not clean up the License Agreement stuff while the files
are being changed? Used the current one found at:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

Changed the strict and warning lines into just a Modern::Perl.

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 03:43:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 01:43:10 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-PA4lykMoRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50551|0                           |1
        is obsolete|                            |

--- Comment #117 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51314&action=edit
Bug 11592 - Add should_hide_marc method to filter

Add should_hide_marc to ViewPolicy filter
Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 03:43:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 01:43:18 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-y5qNsktF12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50552|0                           |1
        is obsolete|                            |

--- Comment #118 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51315&action=edit
Applying filtering to opac interface.

Applying the filtering and then...
Debugging opac/opac-detail.pl filtering
Debugging opac/opac-ISBDdetail.pl more
Debugging opac/opac-export.pl
Tweak opac/opac-export.pl fix variable declarations, conditional assignments
Debugging opac/opac-showmarc.pl

https://bugs.koha-community.org/show_bug.cgi?id=11592

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 03:43:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 01:43:24 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-aznAjbiHsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50553|0                           |1
        is obsolete|                            |

--- Comment #119 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51316&action=edit
Biblio tweak for MARCSUBJECT

https://bugs.koha-community.org/show_bug.cgi?id=11592

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 03:43:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 01:43:32 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-GF0DseKTHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50554|0                           |1
        is obsolete|                            |

--- Comment #120 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51317&action=edit
Bug 11592: MARCView and ISBD followup

There are still some leaks, but it is not as a result
of the filter, but rather a result of poorly written
template files.

Bug fixing template files is beyond the scope of this
set of patches.

TEST PLAN
---------
 1) Backup your DB
 2) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=-8;
    -- this should set EVERYTHING to hidden across the board.
 3) In staff client, set OPACXSLTDetailsDisplay to blank
 4) In OPAC, view any detail.
    -- Normal view may mostly leak values still.
    -- MARC view may leak values.
    -- ISBD view may leak values.
 5) In staff client, set OPACXSLTDetailsDisplay to default
 6) In OPAC, view any detail.
    -- same issues as step 4
    -- 'View Plain' may leak too.
 7) 'Save record' -> 'Dublin Core'
 8) Apply this patch
 9) run koha qa test tools
    -- should be fine
10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t
    -- should pass
    -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too
11) In OPAC, view any detail.
    -- Normal view:
       -- Material type comes from the LEADER field.
       -- Lists this is on will still display
       -- 'Tags from this library' will still display
       -- Item information in table will still display
          (THIS IS BEYOND SCOPE)
    -- MARC view:
       -- Record number is leaked
          (THIS IS BEYOND SCOPE)
       -- 'View plain' leaks LEADER field.
    -- ISBD view may leak field headings, but not values.
       (THIS IS BEYOND SCOPE)
12) In staff client, set OPACXSLTDetailsDisplay to blank
13) In OPAC, view any detail.
    -- same kind of output as step 10
14) 'Save record' -> BIBTEXT
    -- Should be next to nothing leaked.
15) 'Save record' -> Dublin Core
    -- Should be the same or less leaked between the two versions.
    -- (XML FILTERING IS BEYOND SCOPE)
16) In the staff client, go view the same record.
    -- it should be mostly hidden in ISBD View.
17) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=1;
    -- this should set EVERYTHING to hidden in OPAC, but not
       the STAFF across the board.
18) Refresh the staff ISBD page
    -- values should reappear.
19) View the ISBD details in the OPAC
    -- values should still be hidden.
20) Check out the OPAC Cart and List
    -- while the intermediate pages may still leak
       the download links should leak very minimally.
    -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH
        THE INTRANET ISBD AND SOME CART/LIST STUFF
        WERE FIXED BECAUSE OF THE GetISBDView REFACTOR)

Expectations:
Before Patch - all the OPAC Detail pages will display things
After Patch - all the OPAC Detail pages will display much less,
              and hopefully nothing (though there are known limits).
              the ISBD detail page in the Staff client will be
              filtered as well based on STAFF settings.
              The saving/exporting should generate nearly empty
              files.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 03:57:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 01:57:38 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-ZiNBfgDkLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51317|0                           |1
        is obsolete|                            |

--- Comment #121 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51318&action=edit
Bug 11592: MARCView and ISBD followup

There are still some leaks, but it is not as a result
of the filter, but rather a result of poorly written
template files.

Bug fixing template files is beyond the scope of this
set of patches.

TEST PLAN
---------
 1) Backup your DB
 2) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=-8;
    -- this should set EVERYTHING to hidden across the board.
 3) In staff client, set OPACXSLTDetailsDisplay to blank
 4) In OPAC, view any detail.
    -- Normal view may mostly leak values still.
    -- MARC view may leak values.
    -- ISBD view may leak values.
 5) In staff client, set OPACXSLTDetailsDisplay to default
 6) In OPAC, view any detail.
    -- same issues as step 4
    -- 'View Plain' may leak too.
 7) 'Save record' -> 'Dublin Core'
 8) Apply this patch
 9) run koha qa test tools
    -- should be fine
10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t
    -- should pass
    -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too
11) In OPAC, view any detail.
    -- Normal view:
       -- Material type comes from the LEADER field.
       -- Lists this is on will still display
       -- 'Tags from this library' will still display
       -- Item information in table will still display
          (THIS IS BEYOND SCOPE)
    -- MARC view:
       -- Record number is leaked
          (THIS IS BEYOND SCOPE)
       -- 'View plain' leaks LEADER field.
    -- ISBD view may leak field headings, but not values.
       (THIS IS BEYOND SCOPE)
12) In staff client, set OPACXSLTDetailsDisplay to blank
13) In OPAC, view any detail.
    -- same kind of output as step 10
14) 'Save record' -> BIBTEXT
    -- Should be next to nothing leaked.
15) 'Save record' -> Dublin Core
    -- Should be the same or less leaked between the two versions.
    -- (XML FILTERING IS BEYOND SCOPE)
16) In the staff client, go view the same record.
    -- it should be mostly hidden in ISBD View.
17) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=1;
    -- this should set EVERYTHING to hidden in OPAC, but not
       the STAFF across the board.
18) Refresh the staff ISBD page
    -- values should reappear.
19) View the ISBD details in the OPAC
    -- values should still be hidden.
20) Check out the OPAC Cart and List
    -- while the intermediate pages may still leak
       the download links should leak very minimally.
    -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH
        THE INTRANET ISBD AND SOME CART/LIST STUFF
        WERE FIXED BECAUSE OF THE GetISBDView REFACTOR)

Expectations:
Before Patch - all the OPAC Detail pages will display things
After Patch - all the OPAC Detail pages will display much less,
              and hopefully nothing (though there are known limits).
              the ISBD detail page in the Staff client will be
              filtered as well based on STAFF settings.
              The saving/exporting should generate nearly empty
              files.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 04:57:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 02:57:45 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-NFw6RpVUfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

--- Comment #21 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Katrin Fischer from comment #19)
> Is it intentional to not display 100$t any longer with this patch? Can you
> please check? It displays without this patch, 700$t displays with and
> without, but sequence is fixed.

Hi Katrin. I intencional did it since subfield $t is only used in 7XX fields in
MARC bibliographic. This subfield is only used in MARC authority. If a
librarian use some authorized access point with $t (name-title) subfield in bib
record, the uniform title is placed in 240$a field. But if some library use
1XX$t I can include it.

Regards

PS: This is a policy that Library of Congress don't want to change neither LCRI
nor LC-PCC PS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 06:21:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 04:21:07 +0000
Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in
	list context
In-Reply-To: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16154-70-N5D3YVTVv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au,
                   |                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 06:21:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 04:21:54 +0000
Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in
	list context
In-Reply-To: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16154-70-DwBUCtpwgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 08:07:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 06:07:52 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-X4fARovmqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:38:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:38:23 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-EW6dXmxk7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:39:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:39:12 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-ZHqb1HpeIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:39:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:39:42 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-wI78eVVlhE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:52:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:52:06 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-GXeJudN1Se@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50272|0                           |1
        is obsolete|                            |

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51319&action=edit
Bug 16271: Allow more filters on /api/v1/holds

borrowernumber parameter is no longer required and you can filter on
every column of reserves table

Some example requests
- GET /api/v1/hols
- GET /api/v1/hols?biblionumber=123
- GET /api/v1/hols?borrowernumber=456
- GET /api/v1/hols?priority=0&found=W

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:53:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:53:27 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-wnDQ31EzZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51319|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51320&action=edit
Bug 16271: Allow more filters on /api/v1/holds

borrowernumber parameter is no longer required and you can filter on
every column of reserves table

Some example requests
- GET /api/v1/holds
- GET /api/v1/holds?biblionumber=123
- GET /api/v1/holds?borrowernumber=456
- GET /api/v1/holds?priority=0&found=W

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:53:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:53:58 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-RVYhcPGH00@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 09:54:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 07:54:17 +0000
Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
In-Reply-To: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16271-70-SZ33BUugYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased on master and 'reserves' changed to 'holds'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:07:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:07:22 +0000
Subject: [Koha-bugs] [Bug 16373] merge.pl reports success but files are not
	merged
In-Reply-To: <bug-16373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16373-70-XXj7Q3Kis7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16373

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:09:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:09:49 +0000
Subject: [Koha-bugs] [Bug 16378] Overdues.pm: Can't call method "store"
 without a package or object reference
In-Reply-To: <bug-16378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16378-70-nlMz9sw0ay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:13:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:13:17 +0000
Subject: [Koha-bugs] [Bug 16354] Fix FK constraints for edifact_messages
	table
In-Reply-To: <bug-16354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16354-70-IpS8ptZ3yd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16354

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable version, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:13:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:13:42 +0000
Subject: [Koha-bugs] [Bug 16361] Installer syntax error
In-Reply-To: <bug-16361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16361-70-PyWg1Dcn1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:22:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:22:46 +0000
Subject: [Koha-bugs] [Bug 16217] Notice' names may have diverged
In-Reply-To: <bug-16217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16217-70-PrxzqMYvfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16217

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:23:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:23:42 +0000
Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold
 Available for Pickup"
In-Reply-To: <bug-12752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12752-70-GzVAwgwLG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:27:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:27:58 +0000
Subject: [Koha-bugs] [Bug 16397] Unable to delete audio alerts
In-Reply-To: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16397-70-MHzPhOmgdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16397

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:30:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:30:44 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-DbQJSugYRI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:30:51 +0000
Subject: [Koha-bugs] [Bug 16418] EnhancedMessagingPreferencesOPAC appears
 twice in sysprefs.sql
In-Reply-To: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16418-70-5Pnv3Hvz5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16418

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:36:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:36:10 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-Zup8cwlVmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:40:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:40:04 +0000
Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on
	selfcheck login page
In-Reply-To: <bug-12663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12663-70-GReUZGvfb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 10:41:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 08:41:20 +0000
Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect
 fieldnames given in sypref StatisticsFields
In-Reply-To: <bug-12721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12721-70-gXbi6EDLly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 11:14:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 09:14:10 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-U2Iw3nUuoD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #10)
> Hm, I think this will work for new installations, but shouldn't we change
> existing ones to match?

Yes indeed we must, I have thought about that during the week-end :)
Patches coming soon...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 11:24:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 09:24:24 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-44WWVzaFIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #2)
> The patron card creator link on the tools home page uses:
> CAN_user_tools_label_creator
> I think that would make sense to me overall.

Yes but it's the only script in this directory, others use catalogue.
Moreover patroncards/edit-batch.pl, which calls add_user_search.pl, uses
catalogue also, it would not make sense to have different perms.

If we need to fix the whole module, it should be done on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 11:29:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 09:29:37 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-L8XiWfVKxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok - It sure doesn't make much sense now :) 

Having another bug report sounds good - maybe it would be best to add a new
permission just for this tool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 11:46:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 09:46:20 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-MEXKtvB8CR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51321&action=edit
[3.22.x] Bug 13041: Fix add of basket's manager when name contains a single
quote

Patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 11:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 09:46:53 +0000
Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name
 includes a single quote
In-Reply-To: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13041-70-PSW9FEw8ga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 11:54:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 09:54:12 +0000
Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test
In-Reply-To: <bug-13877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13877-70-SGfrJA7rKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 12:00:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 10:00:17 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: <bug-14362-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14362-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14362-70-XU2XlEzLA7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 12:02:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 10:02:55 +0000
Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe
In-Reply-To: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16443-70-qQmCq2FxX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 12:02:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 10:02:58 +0000
Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe
In-Reply-To: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16443-70-RzRnOqyE0C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51220|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51322&action=edit
Bug 16443: Make C4::Members::Statistics plack safe

If the prefs is updated, the fields won't be.
To make sure we already fetch updated values, we should remove the
package variable and define it in the subroutine.

There is not test plan, just make sure the changes are consistent.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 12:04:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 10:04:11 +0000
Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe
In-Reply-To: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16443-70-9kruIUyzMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
This works, I haven't tested if there is a performance hit, but even if there
was we need to make the change anyway. But if there is, we may want to put some
caching in get_fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 12:36:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 10:36:23 +0000
Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in
 'Saved reports' page with language bottom bar
In-Reply-To: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15194-70-bAivqqb9wX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 12:50:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 10:50:40 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-vI7e5skMfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #9 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Trying to evaluate this patch, but I'm having trouble understanding how it
works.

$Koha::CGI::language is a package variable (persistent under plack); if some
stript calls Languages::getlanguage() without calling Koha::CGI->new()
somewhere earlier, it may pick "outdated" language code (set by some other
script which was calling getlanguage() first).

Not sure if the parameters in "use Koha::CGI qw('-no_undef_params' -utf8 )"
will get propagated from catalogue/search.pl to Koha::CGI somehow, there is no
"use CGI qw( -utf8 );" in the Koha/CGI.pm, there is only commented out "# use
base CGI;" (?).

BTW, I wonder why there is "use CGI" instead of "use CGI (-uft8)" in
C4::Languages, looks like some kind of exception or omission - is there a
correlation with Bug 13815? Can't find an explanation in Bug 13815 why exactly
plack was losing that uft8 flag in the 1st place..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 13:33:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 11:33:49 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
	but not if renewed
In-Reply-To: <bug-9805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9805-70-LsWbMMDkNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #48)
> (In reply to Jonathan Druart from comment #46)
> > (In reply to Kyle M Hall from comment #45)
> > > Created attachment 49165 [details] [review] [review] [review]
> > > Bug 9805 [QA Followup] - Stop calling GetMember repeatedly
> > 
> > Kyle, This change looks safe, but it's very hard to say it won't introduce a
> > regression. The $borrower var is passed from a sub to another without being
> > "refreshed" like it was before this patch. This means we could use an
> > outdated data.
> 
> I do not believe this is a valid concern. There is no reason to suspect
> there could be any problems caused by this. If we force each subroutine in
> Koha to fetch all db data with each call, we will continue to make Koha
> slower and slower. If you have a specific scenario in mind where this will
> cause an issue, I'm certainly open to amending my position. Otherwise I we
> should keep this patch to improve speed and efficiency.

Of course it's a valid concern :)
It's the same problematic we have for caching.
I don't suggest to "fetch all db data with each call", but we need to take care
of the obsolescence of the data we manipulate.
You are fetching the patron info using GetMemberDetails, which returns
accounting data, but AddRenewal modify these infos. At some point your
$borrower is obsolete. For instance if SendCirculationAlert (which does not
refetch patron infos) needs to access the accounting infos to sent the letter
and decide to get if from $borrower, we will have a very hard to debug issue.

It would make more sense to have this kind of patches on a separate bug report,
not to block the integration of this bugfix into master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 13:58:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 11:58:17 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-3O1lSVCyyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #10 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #3)
> For discussion
> With this patch, I get only 1 call to CGI->new (hard to do less:)) instead
> of 344 on a search with 20 results (default XSLT used).
> It's quite dirty but I have no idea how we could do another way (we could
> store it in the L1 cache instead?)

We certainly don't want language code to be propagated to shared persitent L2
cache ;). I think that some kind of extra simple L1 memory-only cache
implementation may come in handy anyway, for caching things that are specific
to the given script run. Something as simple as possible - eg.
Koha/Cache/Memory/Lite.pm, with get(), set() and clear() methods - no
expiration, deep copying etc. needed.

Having something like that, we can:

1) cache CGI object first (in plack startup CGI->new() override and eg. in
C4::Auth::get_template_and_user() as well)
2) use that cached CGI object in getlanguage() later - if it's a 1st call for a
given run
3) cache language code obtained in the 1st call for possible later uses so this
subroutine would not need to check CGI object again in subsequent calls
4) clear extra-simpe-L1-memory-only cache in the CGI override

By the look of it, language code returned by getlanguage() stays always the
same for a given script run, so it shouldn't introduce any regressions, at
least in theory.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 14:26:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 12:26:10 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
	record
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-PwGDx3kzO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 14:50:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 12:50:45 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-5zzsnqQK5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 14:50:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 12:50:49 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-2W7xp2ax0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51300|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51323&action=edit
Bug 15816: Redirect back to correct page after login

This uses a hacky but simple method to get the correct script name under
proxied packaged Plack.

Test plan:
  1) Log out of both the OPAC and staff side.
  2) Try to access a page that requires login (opac-reserve.pl is a
good one for the OPAC), then log in.
  3) You will be redirected back to mainpage.pl or opac-user.pl.
  4) Repeat above for both staff side and OPAC.
  5) Apply patch.
  6) Repeat steps 1-4; you should be redirected back to the original
     page you were on.
  7) Repeat the above for both a traditional CGI and kohadevbox/package
     Plack installation.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 15:41:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 13:41:10 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-YmcKXqBJWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 51323
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51323
Bug 15816: Redirect back to correct page after login

Review of attachment 51323:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15816&attachment=51323)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +2055,5 @@
> +
> +sub _get_script_name {
> +    # This is the method about.pl uses to detect Plack; now that two places use it, it MUST be
> +    # right.
> +    if ( ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) && $ENV{SCRIPT_NAME} =~ m,^/(intranet|opac)(.*), ) {

Jesse, why do we need to parse SCRIPT_NAME?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 15:55:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 13:55:06 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-1bmtYdlRkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51323|0                           |1
        is obsolete|                            |

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51324&action=edit
Bug 15816: Redirect back to correct page after login

This uses a hacky but simple method to get the correct script name under
proxied packaged Plack.

Test plan:
  1) Log out of both the OPAC and staff side.
  2) Try to access a page that requires login (opac-reserve.pl is a
good one for the OPAC), then log in.
  3) You will be redirected back to mainpage.pl or opac-user.pl.
  4) Repeat above for both staff side and OPAC.
  5) Apply patch.
  6) Repeat steps 1-4; you should be redirected back to the original
     page you were on.
  7) Repeat the above for both a traditional CGI and kohadevbox/package
     Plack installation.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 15:55:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 13:55:03 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-D6k5XZBlBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:00:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:00:22 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-R2kj7Vmfsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #170 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This patchset introduces some uses of CGI->param in list context, please fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:06:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:06:19 +0000
Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have
	multi_param
In-Reply-To: <bug-15809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15809-70-fqsniy24Tm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16476

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:06:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:06:19 +0000
Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in
	list context
In-Reply-To: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16154-70-S0i1CVlijt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16476

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:06:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:06:19 +0000
Subject: [Koha-bugs] [Bug 16259] More: Replace CGI->param with
 CGI->multi_param in list context
In-Reply-To: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16259-70-NRL1qwOFRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16476

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:08:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:08:27 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-hM7VC0ZcE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:08:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:08:32 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-PnGIKgrkdH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51318|0                           |1
        is obsolete|                            |

--- Comment #122 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51326&action=edit
Bug 11592: MARCView and ISBD followup

There are still some leaks, but it is not as a result
of the filter, but rather a result of poorly written
template files.

Bug fixing template files is beyond the scope of this
set of patches.

TEST PLAN
---------
 1) Backup your DB
 2) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=-8;
    -- this should set EVERYTHING to hidden across the board.
 3) In staff client, set OPACXSLTDetailsDisplay to blank
 4) In OPAC, view any detail.
    -- Normal view may mostly leak values still.
    -- MARC view may leak values.
    -- ISBD view may leak values.
 5) In staff client, set OPACXSLTDetailsDisplay to default
 6) In OPAC, view any detail.
    -- same issues as step 4
    -- 'View Plain' may leak too.
 7) 'Save record' -> 'Dublin Core'
 8) Apply this patch
 9) run koha qa test tools
    -- should be fine
10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t
    -- should pass
    -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too
11) In OPAC, view any detail.
    -- Normal view:
       -- Material type comes from the LEADER field.
       -- Lists this is on will still display
       -- 'Tags from this library' will still display
       -- Item information in table will still display
          (THIS IS BEYOND SCOPE)
    -- MARC view:
       -- Record number is leaked
          (THIS IS BEYOND SCOPE)
       -- 'View plain' leaks LEADER field.
    -- ISBD view may leak field headings, but not values.
       (THIS IS BEYOND SCOPE)
12) In staff client, set OPACXSLTDetailsDisplay to blank
13) In OPAC, view any detail.
    -- same kind of output as step 10
14) 'Save record' -> BIBTEXT
    -- Should be next to nothing leaked.
15) 'Save record' -> Dublin Core
    -- Should be the same or less leaked between the two versions.
    -- (XML FILTERING IS BEYOND SCOPE)
16) In the staff client, go view the same record.
    -- it should be mostly hidden in ISBD View.
17) run the following SQL on your DB.
    > UPDATE marc_subfield_structure set hidden=1;
    -- this should set EVERYTHING to hidden in OPAC, but not
       the STAFF across the board.
18) Refresh the staff ISBD page
    -- values should reappear.
19) View the ISBD details in the OPAC
    -- values should still be hidden.
20) Check out the OPAC Cart and List
    -- while the intermediate pages may still leak
       the download links should leak very minimally.
    -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH
        THE INTRANET ISBD AND SOME CART/LIST STUFF
        WERE FIXED BECAUSE OF THE GetISBDView REFACTOR)

Expectations:
Before Patch - all the OPAC Detail pages will display things
After Patch - all the OPAC Detail pages will display much less,
              and hopefully nothing (though there are known limits).
              the ISBD detail page in the Staff client will be
              filtered as well based on STAFF settings.
              The saving/exporting should generate nearly empty
              files.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:08:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:08:58 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-UlorRYc7SG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:09:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:09:00 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-5SUe6T751d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51125|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51327&action=edit
Bug 16428: Use the biblio framework to know if a field is mapped

The subroutine _build_default_values_for_mod_marc takes the
frameworkcode in parameter, but ModItemFromMarc did not pass it.
It uses it to know if a field is mapped or not to a Koha field
(C4::Koha::IsKohaFieldLinked).
Consequently the default framework ("") was always used.

This bug has been found working on bug 13074 and has been put on a
separate bug report to ease the backport.

Test plan:
Without this change, the tests added by bug 16428 won't pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:09:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:09:14 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-uDtGnAOTY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:09:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:09:18 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-OZmgxo9jku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51328&action=edit
Bug 16402: Fix fox existing installations

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:14:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:14:48 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-P1K8mEi0sa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51138|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51329&action=edit
Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record

With the global %default_values_for_mod_from_marc variable, the changes
made to the marc_subfield_structure table and especially the links
between MARC and DB fields are not safe and might be outdated (if a
field is linked/unlinked)

Test plan:
Under Plack:
- Link the barcode field, edit a record and set a barcode.
- Remove the mapping for the barcode field and then update again the
  barcode of the record.
The items.barcode DB field must not have been updated.

Without this patch, the field should have been updated.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:14:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:14:57 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-6MZnJ0OAaq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51330&action=edit
Bug 13074: (followup) remove useless diag

On running all Items-related tests some useless diag showed up. Removing it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:15:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:15:21 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-2dy7OVm9lW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:20:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:20:19 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-crtW02W0cl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #6 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #5)

> I personally think that we cannot support all the configurations and that
> Koha will only be usable with Plack and a caching system enabled.

Yep, and apart from DBIx class loading penalty under CGI, soon Koha will
require Moose as well (and/or Moo or whatever) and so on.

+1 for depreciating setups w/o memcached (or another persistent caching system)
in (eg.) 1 release cycle and non-plack setups (in 1-2 release cycles ?).

That doesn't necessarily mean Koha should / needs to completely cease to work
without plack and memcache (not in the near future at least), more like: all
performance-related complains for non-plack setups could be by default
redirected to /dev/null after that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:27:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:27:37 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-CdS6DZLaNZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #9)
> Trying to evaluate this patch, but I'm having trouble understanding how it
> works.
> 
> $Koha::CGI::language is a package variable (persistent under plack); if some
> stript calls Languages::getlanguage() without calling Koha::CGI->new()
> somewhere earlier, it may pick "outdated" language code (set by some other
> script which was calling getlanguage() first).

I am feeling a bit silly, this patch did not make any sense, indeed...
It seems that I was looking at the performances too much and did not keep in
mind that the patch should not be buggy :) 

> Not sure if the parameters in "use Koha::CGI qw('-no_undef_params' -utf8 )"
> will get propagated from catalogue/search.pl to Koha::CGI somehow, there is
> no "use CGI qw( -utf8 );" in the Koha/CGI.pm, there is only commented out "#
> use base CGI;" (?).
> 
> BTW, I wonder why there is "use CGI" instead of "use CGI (-uft8)" in
> C4::Languages, looks like some kind of exception or omission - is there a
> correlation with Bug 13815? Can't find an explanation in Bug 13815 why
> exactly plack was losing that uft8 flag in the 1st place..

I guess we should add the flag to C4::Languages.
I do not remember why the flag is getting lost, but it is :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:27:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:27:42 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-kKuKm5DViU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 16:57:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 14:57:55 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-pIQrTMResA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Jacek, what about caching the language (as usual) using the sessionID in the
cache key (with a limited TTL)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:00:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:00:15 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-50ULX5D02N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #52 from Nick Clemens <nick at bywatersolutions.com> ---
This patch has altered the way that the patron branch is sent.  Previously it
was in a separate AF field, now the branch is concatenated onto the other
messages with a ' -- '

I am not sure if this is intentional but it is causing problems for one of our
libraries where this field was captured for statistical purposes. Can we adjust
this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:02:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:02:07 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-7W8lqJhcBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #6)
> (In reply to Jonathan Druart from comment #5)
> 
> > I personally think that we cannot support all the configurations and that
> > Koha will only be usable with Plack and a caching system enabled.
> 
> Yep, and apart from DBIx class loading penalty under CGI, soon Koha will
> require Moose as well (and/or Moo or whatever) and so on.
> 
> +1 for depreciating setups w/o memcached (or another persistent caching
> system) in (eg.) 1 release cycle and non-plack setups (in 1-2 release cycles
> ?).
> 
> That doesn't necessarily mean Koha should / needs to completely cease to
> work without plack and memcache (not in the near future at least), more
> like: all performance-related complains for non-plack setups could be by
> default redirected to /dev/null after that.

Koha 3.22 is already unusable (waiting for 30sec to serve a page is not
acceptable in a user POV I imagine) without Plack...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:12:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:12:03 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-2m1IQx3CSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50606|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51331&action=edit
Bug 16272: Automatically switch an on-site checkout to a regular checkout when
checked out

Use case: A patron checks some items out on-site and want to take it home.
To facilitate the librarian work the checkout is directly switched from
on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is
on.

Test plan:
0/ Let the new pref SwitchOnSiteCheckouts off
1/ Checkout one items to a patron and tick the "on-site checkout"
checkbox
2/ Check the same item out without ticking the "on-site checkout"
checkbox
=> You should get "This item can not be renewed, it's an on-site checkout"
3/ Switch the pref on
4/ Repeat 2
=> The on-site checkout should be automatically switched to a regular checkout

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small changes to apply to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:12:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:12:34 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-CBIbFUoFfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51331|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51332&action=edit
Bug 16272: Automatically switch an on-site checkout to a regular checkout when
checked out

Use case: A patron checks some items out on-site and want to take it home.
To facilitate the librarian work the checkout is directly switched from
on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is
on.

Test plan:
0/ Let the new pref SwitchOnSiteCheckouts off
1/ Checkout one items to a patron and tick the "on-site checkout"
checkbox
2/ Check the same item out without ticking the "on-site checkout"
checkbox
=> You should get "This item can not be renewed, it's an on-site checkout"
3/ Switch the pref on
4/ Repeat 2
=> The on-site checkout should be automatically switched to a regular checkout

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small changes to apply to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:12:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:12:40 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-J03sqp5zq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50607|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51333&action=edit
Bug 16272: Specific case when switching an on-site checkout to a regular
checkout

In the case on-site checkouts are considered as a regular checkout in issuing
rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on):
When after the on-site checkout the maximum limit of checkouts is
reached and the patron wants to switch an on-site checkout to a regular
checkout, the C4::Circulation::TooMany subroutine will return a
TOO_MANY_CHECKOUTS error.
To avoid that, we need to allow an extra checkout in this subroutine.

Test plan:
0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and
SwitchOnSiteCheckouts on
1/ In the issuing rules, set the total number of checkouts (maxissueqty)
to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty)
2/ Check 2 items out ticking the 'on-site checkout' checkbox
3/ Check one of these items out, to automatically switch it to a regular
checkout
=> The checkout should be allowed.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:41:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:41:32 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-RQBeB9w8LC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #12)
> Jacek, what about caching the language (as usual) using the sessionID in the
> cache key (with a limited TTL)?

Forget that, it does not make sense...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:43:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:43:02 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-Nvw9C8XI6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|pianohacker at gmail.com       |jweaver at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:55:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:55:33 +0000
Subject: [Koha-bugs] [Bug 16477] New: Improve staff client cart JavaScript
	and template
Message-ID: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477

            Bug ID: 16477
           Summary: Improve staff client cart JavaScript and template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I'm working on a patch which will make several updates to the staff client cart
template and JavaScript, including removal of "onclick," moving JS out of the
template, and other template improvements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 17:57:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 15:57:43 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-IYT6w8X6dI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39925|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:07:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:07:13 +0000
Subject: [Koha-bugs] [Bug 16478] New: Translation breaks display of Checkout
 history in tab Checks / On-site-checkouts
Message-ID: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

            Bug ID: 16478
           Summary: Translation breaks display of Checkout history in tab
                    Checks / On-site-checkouts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt the filter
for the tabs 'Checkouts' and 'On-site checkouts' uses text that is exposed to
translation.

If they are translated, the tabs will be empty on translated pages. (Note:
Enable syspref OnSiteCheckuts for testing)

See opac-readingrecord.tt line 83ff:
[% IF issue.onsite_checkout %]
    onsite
[% ELSE %]
    checkout
[% END %]

E.g. in German (/de-DE/modules/opac-readingrecord.tt), it translates to:
[% IF issue.onsite_checkout %] vor Ort [% ELSE %] ausgeliehen [% END %]

It should be the same as in the English version. A very dirty workaround would
be not to translate 'onsite' and 'checkout' in Pootle.

Most problably other language will fall into this trap as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:11:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:11:46 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checks / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-lJF1iWFnre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51334&action=edit
Screenshots with broken display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:20:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:20:53 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-G5haE07uZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #171 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #170)
> This patchset introduces some uses of CGI->param in list context, please fix.

Any clue as to where?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:25:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:25:32 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-FmwD6XVV8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, we are still testing without Plack not seeing response times as long so far
- is it special pages that are affected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:26:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:26:03 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-yKaocRSlnW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|pianohacker at gmail.com       |jweaver at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:34:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:34:21 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-sYWyBXyfud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:34:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:34:25 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-NPn7TuZxOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49588|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51335&action=edit
Bug 16088: Use Koha::Cache to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

Test plan:
At the OPAC and the intranet interfaces:
- Clear the cookies of your browser
- Choose a language and browse
- Change the language and browse

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:41:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:41:36 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checks / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-QlD54Pd5rk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51336&action=edit
Bug 16478: Translation breaks display of Checkout history in tab Checks /
On-site-checkouts

To test:
- Make sure that syspref OnsiteCheckouts is enabled
- Log in to OPAC as a patron who has checkouts, online checkouts and checkout
history enabled
- Go to 'your reading history' (in English)
- Display all three tabs
- Apply patch
- Reload page, display oll three tabs again, there should be no difference
- Examine source code changes to verify that the words 'checkout' and 'onsite'
no longer
  will be exposed to translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:41:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:41:54 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-eOkpjXPU5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #172 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Colin Campbell from comment #171)
> (In reply to Jonathan Druart from comment #170)
> > This patchset introduces some uses of CGI->param in list context, please fix.
> 
> Any clue as to where?

  grep '=>.*->param' admin/edi_*

and see commit f3e4b5bbb6b02d7bb6e89d84c0379666eb1e704f
    Bug 16154: CGI->multi_param - Force scalar context
should give you some tricks.

Basically you need to force the scalar context if called in a list context
(when passed to the template).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:42:27 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checks / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-LrMGSSJZuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |veron at veron.ch
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:42:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:42:58 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-FDUmkzd7h4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Translation breaks display  |Translation breaks display
                   |of Checkout history in tab  |of Checkout history in tab
                   |Checks / On-site-checkouts  |Checkouts /
                   |                            |On-site-checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 18:45:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 16:45:14 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-g5WDhHCmnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #8)
> Hm, we are still testing without Plack not seeing response times as long so
> far - is it special pages that are affected?

A catalogue search with opac images displayed should make you wait for ~30sec.
The problem is the hit to opac-image.pl which will load the DBIX::Class schema.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:01:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:01:47 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-dXJW1nZLdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51336|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51337&action=edit
Bug 16478: Translation breaks display of Checkout history in tab Checks /
On-site-checkouts

To test:
- Make sure that syspref OnsiteCheckouts is enabled
- Log in to OPAC as a patron who has checkouts, online checkouts and checkout
history enabled
- Go to 'your reading history' (in English)
- Display all three tabs
- Apply patch
- Reload page, display oll three tabs again, there should be no difference
- Examine source code changes to verify that the words 'checkout' and 'onsite'
no longer
  will be exposed to translation.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:01:51 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-lEGPMmlJol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51338&action=edit
Bug 16478: Fix checkout history tabs - intranet

Test plan:
Same as before for the intranet.
And please retest the OPAC => I have changed the filter's values to
match OPAC/intranet

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:06:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:06:14 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-6rOZdNzOqf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

--- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #10)
> Comment on attachment 51323 [details] [review]
> Bug 15816: Redirect back to correct page after login
> 
> Review of attachment 51323 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Auth.pm
> @@ +2055,5 @@
> > +
> > +sub _get_script_name {
> > +    # This is the method about.pl uses to detect Plack; now that two places use it, it MUST be
> > +    # right.
> > +    if ( ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) && $ENV{SCRIPT_NAME} =~ m,^/(intranet|opac)(.*), ) {
> 
> Jesse, why do we need to parse SCRIPT_NAME?

This is to make sure that we're not needlessly applying the fix; a local
testing setup with plackup and (I think) the multi-host work on bug 15562 don't
need this fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:09:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:09:51 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-k5qxxOcKnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, can you please open a new bug linked to this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:22:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:22:07 +0000
Subject: [Koha-bugs] [Bug 16479] New: SIP shoudl send separate AF message
 for send_patron_home_library_in_af
Message-ID: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479

            Bug ID: 16479
           Summary: SIP shoudl send separate AF message for
                    send_patron_home_library_in_af
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Bug 13871 changed the way patron branchcode is sent in the SIP message. Instead
of a separate AF the branchcode is now sent concatenated to the message by  "
-- "

This is causing issues for libraries who use the separate field to track
statistics.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:22:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:22:57 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-lLf7bFt9Zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16479

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:22:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:22:57 +0000
Subject: [Koha-bugs] [Bug 16479] SIP shoudl send separate AF message for
 send_patron_home_library_in_af
In-Reply-To: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16479-70-PZOME1Vaam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13871
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:25:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:25:31 +0000
Subject: [Koha-bugs] [Bug 16480] New: Unclosed tag <span> in shelves line
	332 on intranet
Message-ID: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

            Bug ID: 16480
           Summary: Unclosed tag <span> in shelves line 332 on intranet
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: hector.hecaxmmx at gmail.com
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Unclosed tag <span> in shelves line 332 on intranet when translating
>    <span>An error occurred when creating this list./span>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:31:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:31:18 +0000
Subject: [Koha-bugs] [Bug 16481] New: Report menu has unexpected issues
Message-ID: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

            Bug ID: 16481
           Summary: Report menu has unexpected issues
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 introduced a
feature that is a little buggy.  The menu is altered by some reports.  I will
attach some examples shortly.

Basically, the new menu in Koha 3.22.6 added the ability to duplicate the
report from within the report, not just on the report listing table.  However,
some of our reports are causing the menu to be altered.  Here is one of our
reports that causes the failure:

SELECT CONCAT_WS(' ',authorised_values.lib,av2.lib) AS
'Status',reserves.reservenotes AS Notes,concat(biblio.title, '
',ExtractValue(bi.marcxml, '//datafield[@tag="245"]/subfield[@code="b"]')) AS
'Title',biblio.author AS 'Author',items.location AS
'Location',items.itemcallnumber AS 'Call Number',items.barcode AS
'Barcode',CONCAT_WS(', ',borrowers.surname,borrowers.firstname) AS
'Patron',reserves.branchcode AS 'Send To',reserves.reservedate AS
'Date',if(reserves.itemnumber IS NULL,'Next Available','Item Level') AS
'Type',Date(Now()) AS 'Report Date'
  FROM (((((reserves INNER JOIN biblio ON reserves.biblionumber =
biblio.biblionumber) 
     INNER JOIN borrowers ON reserves.borrowernumber =
borrowers.borrowernumber) 
     INNER JOIN items ON biblio.biblionumber = items.biblionumber)
     LEFT JOIN biblioitems bi ON (biblio.biblionumber=bi.biblionumber)
     LEFT JOIN hold_fill_targets ON (reserves.biblionumber =
hold_fill_targets.biblionumber) 
     AND (reserves.borrowernumber = hold_fill_targets.borrowernumber)) 
     LEFT JOIN branchtransfers ON items.itemnumber =
branchtransfers.itemnumber) 
     LEFT JOIN authorised_values ON items.itemlost =
authorised_values.authorised_value
         LEFT JOIN authorised_values av2 ON items.damaged =
av2.authorised_value
  WHERE (((authorised_values.category)="LOST") AND reserves.suspend=0
     And ((av2.category="DAMAGED"))
     And ((reserves.reservedate)<=now())
     And ((reserves.waitingdate) Is Null) 
     And ((reserves.priority)=1)
         And ((items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE
itemnumber=items.itemnumber AND found IS NOT NULL)))
     And ((items.notforloan)=0) 
     And ((items.damaged)=0) 
     And ((items.itemlost)=0)
     And ((items.withdrawn)=0) 
     And ((items.onloan) Is Null) 
     And ((reserves.itemnumber) Is Not Null 
     And (reserves.itemnumber)=items.itemnumber) 
     And ((items.itype)<>"REF") 
     And ((hold_fill_targets.itemnumber) Is Null)) 
     Or (((authorised_values.category)="LOST")
         And ((av2.category="DAMAGED"))
     And ((hold_fill_targets.itemnumber)=items.itemnumber))
         And ((reserves.found) IS NULL) AND reserves.suspend=0
  GROUP BY items.holdingbranch, items.itemcallnumber, items.enumchron,
biblio.author, biblio.title, items.barcode, reserves.branchcode
  HAVING items.holdingbranch=<<Branch filled at|branches>>
     And Count(branchtransfers.datesent)=Count(branchtransfers.datearrived)
  ORDER BY items.location, items.itemcallnumber, items.enumchron,
biblio.author, biblio.title ASC

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:34:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:34:20 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-7YIKMfqaa0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:34:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:34:22 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-DCmKDMTi8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51339&action=edit
Bug 16480: Unclosed tag <span> in shelves line 332 on intranet

Unclosed tag <span> in shelves line 332 on intranet when translating
<span>An error occurred when creating this list./span>
This error was introduced by bug 15403

To test: Verify the template in line 332 to see the unclosed tag fixed
or follow test plan for bug 15403

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:34:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:34:41 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-6dhquBT0Dq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421
[Bug 15421] Show all available actions in reports toolbar
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:34:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:34:41 +0000
Subject: [Koha-bugs] [Bug 15421] Show all available actions in reports
	toolbar
In-Reply-To: <bug-15421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15421-70-cGMJ6to74Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481
[Bug 16481] Report menu has unexpected issues
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:34:50 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-hNQ9Wljxc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403
[Bug 15403] Confirm messages in intranet lists interface strangely worded
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:34:50 +0000
Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists
 interface strangely worded
In-Reply-To: <bug-15403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15403-70-oj4X2HixkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16480


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480
[Bug 16480] Unclosed tag <span> in shelves line 332 on intranet
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:35:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:35:52 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-4IvdRgagfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 51340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51340&action=edit
Snapshot of menu failure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 19:36:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 17:36:32 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-pqd7vmw1gf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 51341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51341&action=edit
Snapshot of good menu (how it should look)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:01:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:01:56 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-TbiRhKbLmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51338|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 51342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51342&action=edit
Bug 16478: Fix checkout history tabs - intranet

Test plan:
Same as before for the intranet.
And please retest the OPAC => I have changed the filter's values to
match OPAC/intranet

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:02:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:02:22 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-8us7VCbURe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:23:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:23:02 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-kZr9baGwBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |oleonard at myacpl.org
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:32:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:32:37 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-QWw4TpJkb9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:32:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:32:39 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-0OVKVviKlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51343&action=edit
Bug 16481 - Report menu has unexpected issues

This patch corrects a problem with the reports toolbar include file
which can cause a problem with the "duplicate" button. The duplicate
button passes the entire report SQL as a URL parameter, but the template
variable was not escaped as a URL variable.

This patch also adds the "uri" filter to the report name and notes
fields just to be safe.

To reproduce the bug, create a new SQL report using the SQL in the bug
report. When you run the report you should see a broken "Duplicate"
button.

Apply the patch and run the report again. The duplicate button should
look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:34:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:34:25 +0000
Subject: [Koha-bugs] [Bug 14250] can generate discharge for patron with fines
In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14250-70-WrRmvBy5Jk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:36:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:36:23 +0000
Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user
 about checkouts before they request
In-Reply-To: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16463-70-GQQdIuv92x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:36:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:36:41 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-64fSoDcVC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:37:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:37:11 +0000
Subject: [Koha-bugs] [Bug 16466] Patron discharge page should show pending
	requests
In-Reply-To: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16466-70-v91Balygsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:37:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:37:28 +0000
Subject: [Koha-bugs] [Bug 16440] Update report parameters
In-Reply-To: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16440-70-KRc2H0Ouov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Sounds like a really good idea!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:56:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:56:34 +0000
Subject: [Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and
	template
In-Reply-To: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16477-70-OIvzEBcC6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 20:56:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 18:56:36 +0000
Subject: [Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and
	template
In-Reply-To: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16477-70-O3Xm1VMTtg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51344&action=edit
Bug 16477 - Improve staff client cart JavaScript and template

This patch makes several changes to the cart JavaScript and template. In
the template:

- Remove "onclick" attributes in favor of defining events in the
  JavaScript.
- Add a [% BLOCK %] section for some repeated markup.
- Add some Font Awesome icons (I didn't add icons to all controls
  because I thought it looked cluttered).
- Move the batch modification control out of the toolbar and into the
  group of controls which affects selected records. I think this is a
  logical grouping, and makes more sense than having a drop-down menu in
  the toolbar with a single menu item.

JavaScript:

- Created separate "cart.js" file so that JS could be moved out of the
  template without loading up basket.js with event functions which are
  not needed on every page in the staff client.
- Fix JSHint errors.

To test, apply the patch and clear your browser cache if necessary.

- Add multiple items to the cart in the staff client and open the cart.
- Confirm correct functionality of these toolbar buttons:
  - "More details" (and the corresponding "Show less")
  - "Send"
  - "Print"
  - "Empty and close"
- Confirm the correct functionality of all the selection controls:
  Select all, clear all, Remove, Add to a list, Place hold, Batch
  modify, and Batch delete.
- Confirm that clicking any title in the cart opens the correct detail
  page in the parent window.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 21:11:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 19:11:41 +0000
Subject: [Koha-bugs] [Bug 16482] New: Check-in page: Display can be broken
 in translations
Message-ID: <bug-16482-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16482

            Bug ID: 16482
           Summary: Check-in page: Display can be broken in translations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 51345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51345&action=edit
Screenshot English and GErman with broken display

On the check-in page, if the translated strings are longer than the English
strings, the form controls display is broken.
See screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 21:12:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 19:12:19 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-W9u6Wnfg2W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 21:13:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 19:13:37 +0000
Subject: [Koha-bugs] [Bug 16479] SIP should send separate AF message for
 send_patron_home_library_in_af
In-Reply-To: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16479-70-iHJOZhWBJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
            Summary|SIP shoudl send separate AF |SIP should send separate AF
                   |message for                 |message for
                   |send_patron_home_library_in |send_patron_home_library_in
                   |_af                         |_af

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 21:14:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 19:14:26 +0000
Subject: [Koha-bugs] [Bug 16482] Check-in page: Display can be broken in
	translations
In-Reply-To: <bug-16482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16482-70-d1eCLOR1rZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16482

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51345|Screenshot English and      |Screenshot English and
        description|GErman with broken display  |German with broken display

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 21:32:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 19:32:02 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-UFWVhGVgXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Chris Kirby <christopherlawrencekirby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #12 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
-Applied patches - Made sure that SMS driver and TalkingTech sysprefs are
defined  to enable SMS and Phone preferences for users (SMS driver can be a
dummy
  value).
- Placed a hold for a patron
- Set patron's messaging preferences to different choices (including none)
- Check in the item that is on hold (it has not to be checked out for the
  test
- Verified that below the message "Hold found (item is already waiting") an
  information appears about the patron's messaging preferences.

--Message (notification preference) only appears where a transfer is not
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 22:09:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 20:09:37 +0000
Subject: [Koha-bugs] [Bug 16483] New: Ampersand breaks search for analytics
Message-ID: <bug-16483-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16483

            Bug ID: 16483
           Summary: Ampersand breaks search for analytics
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

A customer has reported the following problem:

A journal is catalogued with separate records for each issue. The journal has
an ampersand in the title, let's call it "This & that". Each issue has 245$a
like "This & that 2011-1", "This & that 2011-2" and so on. For each issue,
there are analytical records. 

Now, when you are on the detail view of one of the issues in the staff client
(<intranet>/cgi-bin/koha/catalogue/detail.pl?biblionumber=12657) and click on
"Show analytics", you get results from all issues of the journal, not just the
one you wanted. The URL you are taken to looks like this:

<intranet>/cgi-bin/koha/catalogue/search.pl?q=Host-item:This & that 2011-3.

Above the search results it says:

14 result(s) found for 'Host-item:This ' in MyLibrary Catalog.

Note that the title has been cut before the ampersand. 

It is possible to tweak the search URL (remove the ampersand) and get the
expected results. Changing the URL to this:

<intranet>/cgi-bin/koha/catalogue/search.pl?q=Host-item:This that 2011-3.

gives this:

8 result(s) found for 'Host-item:This that 2011-3.' in MyLibrary Catalog.

The same thing happens in the OPAC. 

I guess a workaround will be to enable UseControlNumber and follow the
descriptions here: https://wiki.koha-community.org/wiki/Analytics

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 22:28:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 20:28:22 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-sJfVD7fGWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Chris Kirby <christopherlawrencekirby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49939|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 22:28:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 20:28:24 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-Gcv7nfCO44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Chris Kirby <christopherlawrencekirby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49940|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 22:33:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 20:33:30 +0000
Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different
 library doesn't re-route item to correct library
In-Reply-To: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13153-70-C4MhWLlS3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 22:56:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 20:56:23 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-UXMXVa8C2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #13 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
Created attachment 51346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51346&action=edit
Bug 16390: Accounts.t does not need MPL

This test fails if you do not have a MPL branch, but a closer look shows
that we only need to replace one occurrence.

Test plan:
Run Accounts.t

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:01:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:01:45 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-1NrmAlom5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:01:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:01:49 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-8sELjhgsgq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44283|0                           |1
        is obsolete|                            |

--- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51348&action=edit
Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue
notices

The patch changes the sequence of cronjobs in the crontab example
file and in the cron.daily file of the packages.

This is why:
1) Renew automatically
   ... only when we can't renew, we want to
2) Calculate fines
   ... once the fine are calculated and charged
   we can print the amount into the
3) Overdue notices

Before the change it could happen that you'd charge for an item,
that would then be renewed. Or that you'd try to print fine
amounts into the overdue notices, when they would only be
charged moments later.

To test:
- configure your system so you have items that should
  - be charged with fines
  - renew automatically
- configure your crontabs according to the example file
  or switch the cron.daily in your package installation with
  the new one
- configure your overdue notices so that one should be generated
  <<items.fine>>
- Wait for the cronjobs or schedule them to run earlier
- Verify all is well and as it should be

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:28:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:28:09 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-sc7TkobBb9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16460


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460
[Bug 16460] Update MARC21 frameworks to Update No. 22 (April 2016)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:28:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:28:09 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-q2BirqPZYa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16472


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472
[Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:28:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:28:16 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-b62v4fcnuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:31:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:31:48 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-3PusH0K3Mc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:31:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:31:52 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-KcrUvHN7f2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51350&action=edit
Bug 16472: Update MARC21 de-DE frameworks to update 22 (April 2016)

To test:
1) Start with a fresh database
2) Check mandatory bibliographic and authority files
   load without problem using the German web installer
3) Check new fields/subfields are ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:38:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:38:58 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-TlQHTwZljZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
> first option being the most flexible, as you can do all 4 with less clicks.

I don't think the dropdown menu with the numbers is necessarily the most
convenient if you have a lot of holds. For instance, moving hold number 50 up
one space would required a lot of scrolling through numbers.

I think it could be argued that by moving the arrows into a menu I have taken
away the convenience they offer by being visible all the time.

At my library we don't monkey with holds priorities much, so I don't use the
options in a real-life situation very often.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:39:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:39:57 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-DHMs3KllY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com,
                   |                            |veron at veron.ch

--- Comment #3 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Add here Marc since he is the most appropriate person to sign-of

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:43:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:43:26 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-ztmk3WfDEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51312|0                           |1
        is obsolete|                            |

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51351&action=edit
[SIGNED-OFF]Bug 16474: Standardize spelling of EDIFACT

Some templates use Edifact and edifact. As EDIFACT
is an abbreviation, we should spell it like one.

To test:
- Check templates for occurrences of EDIFACT
  - acquisitions navigation menu
  - basket page
  - basketgroup page
  - EDIFACT messages page
- Verify changes are correct

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Changes are correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May  9 23:43:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 21:43:50 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-llMnwSHCAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 00:12:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 22:12:35 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-mWnqauurvm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 00:12:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 22:12:38 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-fS3Ab4sPQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51343|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51352&action=edit
[SIGNED-OFF] Bug 16481 - Report menu has unexpected issues

This patch corrects a problem with the reports toolbar include file
which can cause a problem with the "duplicate" button. The duplicate
button passes the entire report SQL as a URL parameter, but the template
variable was not escaped as a URL variable.

This patch also adds the "uri" filter to the report name and notes
fields just to be safe.

To reproduce the bug, create a new SQL report using the SQL in the bug
report. When you run the report you should see a broken "Duplicate"
button.

Apply the patch and run the report again. The duplicate button should
look correct and work correctly.

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 00:19:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 22:19:16 +0000
Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
In-Reply-To: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3669-70-ngFFDKlDVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 00:19:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 22:19:20 +0000
Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
In-Reply-To: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3669-70-ylAHDrljM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50976|0                           |1
        is obsolete|                            |

--- Comment #25 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51353&action=edit
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar

This patch moves all the code into an include which can be accessed from the
'Add a new message' link or the patron toolbar.

EDIT: Ensuring modal opens on all pages
EDIT2: Once the form has been submitted the page will redirect to where you
submitted the form from.
EDIT3: Fixing indentation of member-add-message.inc
       Ensuring messages save on every page
       Fill branch
       Ensure predefined notes appear
       Form redirects to where it was submitted from, or just the circulation
page.
EDIT4: Removing the new include file and moving it all into the modal in the
toolbar
EDIT5: Removing swp file and unnecessary code duplication by utilising plugins
EDIT6: Batch checkout fixes
EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref
must be turned on)

To test:
1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X)
2) Click 'Add a new message' under Messages
3) Confirm this brings up the modal to add a message. Confirm clicking Save
saves your message. If it is an OPAC message (for the user), confirm it shows
as expected on the OPAC.
4) Click Cancel. Confirm this closes the modal.
5) Click 'Add message' button in toolbar. Complete steps 3 and 4.
6) Confirm the modal opens from all other pages with the members toolbar.
Confirm predefined notes shows.
        circ/circulation.pl
        members/moremember.pl
        members/routing-lists.pl
        members/statistics.pl
        members/boraccount.pl
        members/pay.pl
        members/maninvoice.pl
        members/mancredit.pl
        members/readingrec.pl
        members/notices.pl
        members/member-flags.pl
        members/member-password.pl
        members/paycollect.pl
        members/files.pl
        turn on BatchCheckouts syspref and put in appropriate patron category
        circ/circulation.pl?borrowernumber=X&batch=1
7) Confirm that the page redirects to where you submitted the form from once
you have submitted it.
8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you
saved it)

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 01:28:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 23:28:11 +0000
Subject: [Koha-bugs] [Bug 16484] New: Virtualshelves: Using no
 XSLTResultsDisplay breaks content display in intranet
Message-ID: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

            Bug ID: 16484
           Summary: Virtualshelves: Using no XSLTResultsDisplay breaks
                    content display in intranet
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Similar to bug 16296 but on the staff side

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 01:28:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 23:28:18 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-62Lo2aCp4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16296

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 01:28:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 May 2016 23:28:18 +0000
Subject: [Koha-bugs] [Bug 16296] Virtualshelves: Using no
 OPACXSLTResultsDisplay breaks content display
In-Reply-To: <bug-16296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16296-70-2fV381ORCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16296

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16484

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:28:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:28:12 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-lT8RbK2P2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #14 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
Hi Marc and Nick,
After signing off on the two patches (and obsoleting yours) I tried to attach
my commit, but obviously I screwed up the commit. I'll try to straighten this
out, but if you have suggestions let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:36:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:36:01 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-REr2ZKTvVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:36:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:36:03 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-0Or5DmFqWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51354&action=edit
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display
in intranet

To test:
1 - Create a list in staff client
2 - Set XSLTResultsDisplay to blank
3 - View list, titles don't display
4 - Apply patch
5 - View list, titles display
6 - Set XSLTResultsDisplay to default
7 - View list, titles display as before patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:36:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:36:14 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-HEFeWz7oOT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:37:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:37:03 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-OWuTrFs3l5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:37:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:37:05 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-h9HmwVNK5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51339|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51355&action=edit
[SIGNED-OFF] Bug 16480: Unclosed tag <span> in shelves line 332 on intranet

Unclosed tag <span> in shelves line 332 on intranet when translating
<span>An error occurred when creating this list./span>
This error was introduced by bug 15403

To test: Verify the template in line 332 to see the unclosed tag fixed
or follow test plan for bug 15403

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:37:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:37:43 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-6RFkRFdtAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
   Patch complexity|---                         |Trivial patch
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:42:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:42:35 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-IWmUxDuJis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:42:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:42:38 +0000
Subject: [Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16472-70-KGG3ujPD4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51350|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51356&action=edit
[SIGNED-OFF] Bug 16472: Update MARC21 de-DE frameworks to update 22 (April
2016)

To test:
1) Start with a fresh database
2) Check mandatory bibliographic and authority files
   load without problem using the German web installer
3) Check new fields/subfields are ok

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Not a german speaker but seems right :)
File loads without problem.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:42:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:42:41 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-MgZXNY5BXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51346|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:42:55 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-an9gq879LS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49940|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:43:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:43:02 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-LMrd4pb6CR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49939|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:48:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:48:05 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-XM8zi3bfuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Chris Kirby from comment #14)
Hi Chris,

It looks like maybe you did:
git bz attach 9543 HEAD~2

Commits are counted from head, so the last patches are:
HEAD HEAD~1 (HEAD~2) (HEAD~3)

Two attach the two latest you want to do:
git bz attach 9543 HEAD~1^..

I un-obsoleted the original patches and obsoleted the extraneous one.  I am
leaving as signed off for now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 02:55:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 00:55:32 +0000
Subject: [Koha-bugs] [Bug 15900] Remove use of recordpayment in
	ProcessOfflinePayment
In-Reply-To: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15900-70-NNZb3VtvPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
On top of 15895, test fails

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 1/83 Can't locate object method "find" via
package "Koha::Borrowers" (perhaps you forgot to load "Koha::Borrowers"?) at
/home/bgkriegel/kohaclone/C4/Circulation.pm line 3912.

Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 03:06:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 01:06:37 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-7hLS4x7Ha3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Sorry, does not apply again.
I promise to test and sign.

Applying: Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks
fatal: sha1 information is lacking or useless (C4/Koha.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:00:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:00:49 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-q20d3qPAw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #16 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
Thanks, Nick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:06:35 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-Inl113ZaES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com

--- Comment #14 from Florent Mara <florent.mara at gmail.com> ---
While rebasing bug 12598, I backported this patch and it broke my tests.

(unless I missed something) With this patch, either overwrite_cardnumber is set
to 0 and the duplicate borrower number will be caught as an 'already_in_db'
feedback - before reaching the new code and get to the next input line. 

OR overwrite_cardnumber is set to 1 and duplicates are overwritten anyway. 

In other words, there does not appear to be any duplicate userid check anymore
with the current code.

In bug 12598, I relocated the new code block above 'if ($borrowernumber) {' to
restore functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:30:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:30:47 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-DgFGElUjPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #86 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51357&action=edit
Attachment to Bug 12598 - New misc/import_borrowers.pl command line tool

Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:34:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:34:13 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-CDaGuD3CkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51357|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:34:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:34:52 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-7g8qXAJ1zW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #87 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51358&action=edit
Attachment to Bug 12598 - New misc/import_borrowers.pl command line tool

Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:35:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:35:57 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-wSGYiK5ehi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51358|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:51:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:51:38 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-HKaN41DxXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #88 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51359&action=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 04:52:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 02:52:08 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-p8BAHm0bxK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51359|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:04:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:04:00 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-tm4BNud7HJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50693|0                           |1
        is obsolete|                            |

--- Comment #89 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51360&action=edit
Attachment to Bug 12598 - New misc/import_borrowers.pl command line tool

Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:33:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:33:17 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-jhLXjrRv6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50694|0                           |1
        is obsolete|                            |

--- Comment #90 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51361&action=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:34:17 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-USB5sBYcPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51360|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:35:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:35:29 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-5qSNlwtyJn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50695|0                           |1
        is obsolete|                            |

--- Comment #91 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51362&action=edit
Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:36:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:36:29 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-KXuMiVImSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50696|0                           |1
        is obsolete|                            |

--- Comment #92 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51363&action=edit
Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:38:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:38:27 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-N1xvnlaKJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50697|0                           |1
        is obsolete|                            |

--- Comment #93 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51364&action=edit
Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:42:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:42:06 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-7onQFlsn9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #94 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51365&action=edit
Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:43:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:43:36 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-dFt9AgG64X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50698|0                           |1
        is obsolete|                            |

--- Comment #95 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51366&action=edit
Bug 12598 - Fix merge to master. Backport 3 updates from latest
import_borrowers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:44:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:44:24 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-n1PXFSh6Eg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50699|0                           |1
        is obsolete|                            |

--- Comment #96 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51367&action=edit
Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:45:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:45:17 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-RVLkE6YGXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50700|0                           |1
        is obsolete|                            |

--- Comment #97 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51368&action=edit
Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:46:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:46:01 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-SsTXiiTpYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50704|0                           |1
        is obsolete|                            |

--- Comment #98 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51369&action=edit
Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:48:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:48:11 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-0flDXvwuRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51122|0                           |1
        is obsolete|                            |

--- Comment #99 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51370&action=edit
Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:50:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:50:01 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-G7fWOlAyst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #100 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51371&action=edit
Bug 12598 - Rebase + backport of 16426 plus fixing 16426

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 05:56:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 03:56:12 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-VlspcmAEX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #101 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51372&action=edit
Patrons sample data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 06:10:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 04:10:43 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-i5NwGnfh3H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #102 from Florent Mara <florent.mara at gmail.com> ---
This patch has been rebased today. Bug 16426 was backported and fixed.

Test plan:
1) Apply this patch. 
2) Set dateformat to mm/dd/yyyy. (Koha home->Administration->search for
dateformat -> select and save)
3) run 'prove t/db_dependent/Koha/Patrons/Import.t' which should result in 2
file handle warnings and 122 tests passing.
4) Run the online importer ( Koha home->tools->Import patrons) Load
PatronDataCSV1.csv sample file with default import parameters. It should result
in 165 imported records and 835 not imported because they are not in the
expected format.
5) Set dateformat to dd/mm/yyyy.
6) Run the new command line importer 'perl misc/import_patrons.pl -f
~/Downloads/PatronDataCSV1.csv -c -m 'cardnumber' -v'
It should load the remaining 835 entries from the sample file.
Import complete:
Imported:    835
Overwritten: 0
Skipped:     0
Invalid:     165
Total:       1000
7) Optional. Run 'perl misc/import_patrons.pl --help' because you can.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 08:04:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 06:04:43 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-AdflcstwxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 08:04:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 06:04:46 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-qKGeIrO3Kj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51244|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51373&action=edit
[SIGNED-OFF] Bug 16444: Make C4::Tags plack safe

C4::Tags use a package variable to cache the pref
TagsExternalDictionary, it's not needed and not safe.

There is not test plan, just make sure the changes are consistent.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 08:20:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 06:20:04 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-97W9lBp3Nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #18 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Marcel de Rooy from comment #13)
> > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> > If there is no further development(?), this might be a risk.
> 
> I can see that as blocker, Mason, would it be easy to update the plugin you
> used?

hi, yes - its very easy to swap the carousel plugin to anything else
i'm happy to change the carousel plugin to whatever people desire


> (In reply to Fr?d?ric Demians from comment #14)
> > I don't see the advantage of this implementation against Bywater plugin.

afaik, the big advantage is that the Bywater plugin can't display an
*automated* selection of verified cover-images for recently added items

i think for the Bywater plugin, a manual list (report?) would need to be
created daily, then each item manually verified for a matching amazon image?


> > rather see disadvantages, including ContentFlow.js obsolescence (not updated
> > since 2010, when jQuery Flipster used by ByWater plugin is actively
> > maintained). Reading the code, I don't understand how GetRecentBibs generates
> > the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to
> > read/re-read this table each time the OPAC main page is loaded?
> 
> Same for me, it's not conceivable to call this subroutine for each get of
> the opac main page. 

with a warmed cache table, the GetRecentBibs() sub takes around 10ms on my old
slow VM.  10ms seems acceptable?

> Could you please detail what is the purpose of this subroutine?

the subroutine returns a list of recently added bibs with verified matching
amazon cover images

> Why do you need a new table, cache of the image url that's it?

yes, thats all - a method of caching the urls is needed for the feature to work
at an acceptable speed
fyi: i did experiment with memcache - but the speed difference was
small/negligible, so i decided upon the convenience of a mysql table instead


> Additional comments:
> - kohastructure.sql changes are missing
thanks, i can do this - no problem

> - Amazon lookup should be optional
amazon lookups effectively cease (ie: become 0) as the cache table becomes
populated
so this is probably not needed? (unless i misunderstand your point)

> - We have several subroutines in C4::Koha to deal with ISBNs, I am sure you
> could reuse

thanks for the suggestion, i could use NormalizedISBN() instead

> - What are the 150 and 300 hardcoded limits?

they are limits to reduce the item list, 
the values were chosen to give a happy balance of acceptable performance and a
good selection of randomised items

> - It would be better to use Koha::Object

sure, i can do this - no problem

> - It would be great to remove all the debug variables, it will ease the
> readability

i would really prefer to leave the debug/profiling code (should any future
problems occur?), 
i'm happy to tidy/improve the readability of the profiling code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 08:29:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 06:29:36 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-7Wf6nzda2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #19 from Mason James <mtj at kohaaloha.com> ---

> > Same for me, it's not conceivable to call this subroutine for each get of
> > the opac main page. 
> 
> with a warmed cache table, the GetRecentBibs() sub takes around 10ms on my
> old slow VM.  10ms seems acceptable?

a small missed point.. the GetRecentBibs() sub is only executed if the Caro
syspref is manually enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 09:18:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 07:18:41 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-vr4H6SwoW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #80 from David Cook <dcook at prosentient.com.au> ---
Fixed the manual error resolution process, so that should be good.

Need to add tools/manage-oai-imports to navigation and give it paging, but that
should be trivial.

Need to improve error handling for Koha::Icarus::Task::Upload::Biblio, and need
to add more data validation to Koha::Icarus::Task::Upload and
Koha::Icarus::Task::Download... 

I'm out of time this week, but I'll resume work on these next week.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 09:44:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 07:44:33 +0000
Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
In-Reply-To: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3669-70-G49kH3ku0C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51353|0                           |1
        is obsolete|                            |

--- Comment #26 from Marc V?ron <veron at veron.ch> ---
Created attachment 51374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51374&action=edit
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar

This patch moves all the code into an include which can be accessed from the
'Add a new message' link or the patron toolbar.

EDIT: Ensuring modal opens on all pages
EDIT2: Once the form has been submitted the page will redirect to where you
submitted the form from.
EDIT3: Fixing indentation of member-add-message.inc
       Ensuring messages save on every page
       Fill branch
       Ensure predefined notes appear
       Form redirects to where it was submitted from, or just the circulation
page.
EDIT4: Removing the new include file and moving it all into the modal in the
toolbar
EDIT5: Removing swp file and unnecessary code duplication by utilising plugins
EDIT6: Batch checkout fixes
EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref
must be turned on)

To test:
1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X)
2) Click 'Add a new message' under Messages
3) Confirm this brings up the modal to add a message. Confirm clicking Save
saves your message. If it is an OPAC message (for the user), confirm it shows
as expected on the OPAC.
4) Click Cancel. Confirm this closes the modal.
5) Click 'Add message' button in toolbar. Complete steps 3 and 4.
6) Confirm the modal opens from all other pages with the members toolbar.
Confirm predefined notes shows.
        circ/circulation.pl
        members/moremember.pl
        members/routing-lists.pl
        members/statistics.pl
        members/boraccount.pl
        members/pay.pl
        members/maninvoice.pl
        members/mancredit.pl
        members/readingrec.pl
        members/notices.pl
        members/member-flags.pl
        members/member-password.pl
        members/paycollect.pl
        members/files.pl
        turn on BatchCheckouts syspref and put in appropriate patron category
        circ/circulation.pl?borrowernumber=X&batch=1
7) Confirm that the page redirects to where you submitted the form from once
you have submitted it.
8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you
saved it)

Sponsored-by: Catalyst IT

Followed test plan, works as expected. (Re-tested for comment #24)
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 09:44:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 07:44:54 +0000
Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
In-Reply-To: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3669-70-WJqxBcmpRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 10:10:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 08:10:10 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-treekibsWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #173 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #172)
> (In reply to Colin Campbell from comment #171)
> > (In reply to Jonathan Druart from comment #170)
> > > This patchset introduces some uses of CGI->param in list context, please fix.
> > 
> > Any clue as to where?
> 
>   grep '=>.*->param' admin/edi_*
> 
> and see commit f3e4b5bbb6b02d7bb6e89d84c0379666eb1e704f
>     Bug 16154: CGI->multi_param - Force scalar context
> should give you some tricks.
> 
> Basically you need to force the scalar context if called in a list context
> (when passed to the template).

Exactly these are scalar context calls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 10:40:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 08:40:17 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-43z1tQ2Uoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51354|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51375&action=edit
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display
in intranet

To test:
1 - Create a list in staff client
2 - Set XSLTResultsDisplay to blank
3 - View list, titles don't display
4 - Apply patch
5 - View list, titles display
6 - Set XSLTResultsDisplay to default
7 - View list, titles display as before patch

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 10:40:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 08:40:57 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-Z4v0Mv9iFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 11:13:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 09:13:53 +0000
Subject: [Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and
	template
In-Reply-To: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16477-70-d2x9NXYAiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51344|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51376&action=edit
Bug 16477 - Improve staff client cart JavaScript and template

This patch makes several changes to the cart JavaScript and template. In
the template:

- Remove "onclick" attributes in favor of defining events in the
  JavaScript.
- Add a [% BLOCK %] section for some repeated markup.
- Add some Font Awesome icons (I didn't add icons to all controls
  because I thought it looked cluttered).
- Move the batch modification control out of the toolbar and into the
  group of controls which affects selected records. I think this is a
  logical grouping, and makes more sense than having a drop-down menu in
  the toolbar with a single menu item.

JavaScript:

- Created separate "cart.js" file so that JS could be moved out of the
  template without loading up basket.js with event functions which are
  not needed on every page in the staff client.
- Fix JSHint errors.

To test, apply the patch and clear your browser cache if necessary.

- Add multiple items to the cart in the staff client and open the cart.
- Confirm correct functionality of these toolbar buttons:
  - "More details" (and the corresponding "Show less")
  - "Send"
  - "Print"
  - "Empty and close"
- Confirm the correct functionality of all the selection controls:
  Select all, clear all, Remove, Add to a list, Place hold, Batch
  modify, and Batch delete.
- Confirm that clicking any title in the cart opens the correct detail
  page in the parent window.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 11:14:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 09:14:19 +0000
Subject: [Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and
	template
In-Reply-To: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16477-70-5NkHiMCz86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 11:38:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 09:38:00 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-bUJiLVjotr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #15 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #14)
> Created attachment 51335 [details] [review]
> Bug 16088: Use Koha::Cache to cache the language

This new version looks a bit half-baked: you define new subroutine
set_in_L1_cache_only(), but it's not used anywhere, instead you are using
set_in_cache() / get_from_cache() so language code gets propagated to L2, if L2
== memcached this will have some "interesting" side effects.

Under plack, there still will be one unnecessary L1 flush - that's way better
than hundreds of unnecessary flushes, but that one extra flush is probably
avoidable as well.

IMO it would be better to have separate L1 memory-only cache for goals like
that (implemented in different package, or separate hash + a set of subroutines
to deal with it in Koha::Cache). Storing things that we don't want to propagate
to L2 in the same hash (%L1_cache) will make further improvements (both Bug
16140 and Bug 16166 for example) much more complicated. I suggested to
implement such a cache in a new package because having subroutines like
get_from_separate_L1_memory_only_cache() in Koha::Cache may look kind of silly
;).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 11:49:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 09:49:15 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-dybka0htc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Tested with patch:

- Set permissions 'catalogue' and 'label_creator'
- Go to Home > Tools > Patron card creator
- New card batch
- Add patrons
- Search windows pops up. Do a search.
Result: Endless "Processing"

- Set addtitionally permission 'borrowers'
Result: Search window works as expected, patrons are found and can be selected.

I think there should be two separate permissions for '...creator', one for
labels ('label_creator') and one for patron cards ('patroncard_creator'). The
latter would then additionally need 'borrowers' (with a hint in the
description)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 12:33:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 10:33:36 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-vf9EOnEar2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |theod at lib.auth.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 12:58:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 10:58:17 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-fTyQY8oDso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #103 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Is it ready to be signed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 13:01:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 11:01:50 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-RUQ2yixUYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #10 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
"Unusable" may sound a bit like an overstatement, but indeed some features
(like OPACLocalCoverImages, Bug 16309) in 3.22+ are pretty much unusable
without plack. 
Penalty for having non-plack config is somewhere around 0.8 - 1.5 sec on
average (per script run), and growing - not to mention that 80-90% of CPU
cycles are being wasted in non-plack setups. Koha without plack is very
environmentally unfriendly ;) (*)

*) unless you are running Koha in France
(https://upload.wikimedia.org/wikipedia/commons/9/9b/Nuclear_power_percentage.svg)

OPACLocalCoverImages is kind of the special case, when 1 catalogue search
triggers ~20 runs of the opac/opac-image.pl. But there are many other places in
Koha when 1 script triggers a lot of other scripts server-side (eg. all that
ajax-ish kind of stuff in circulation, etc.) so it's not just this particular
feature being affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 13:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 11:03:55 +0000
Subject: [Koha-bugs] [Bug 16485] New: collection column in Item search is
	always empty
Message-ID: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

            Bug ID: 16485
           Summary: collection column in Item search is always empty
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: theod at lib.auth.gr
        QA Contact: testopia at bugs.koha-community.org

When in "Item Search", it seems that regardless of the items returned in the
result set, the collection name is always empty.

This should be fixed and have the collection name displayed as expected.

(The issue appears in 3.20, but seems to exists in 3.22 as well...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 13:06:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 11:06:47 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-dBUOaUlQZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

--- Comment #1 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Needless to say that in my case the authorized values for the collections are
correct and collection names appear correctly in other result pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 13:28:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 11:28:07 +0000
Subject: [Koha-bugs] [Bug 16486] New: Display the TIME a fine was
	collected/written off
Message-ID: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

            Bug ID: 16486
           Summary: Display the TIME a fine was collected/written off
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: theod at lib.auth.gr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In many cases it would be very useful to be able to know the time a fine was
collected/written off (in addition to the date).

So ideally, the TIME could be shown next to the date in the Fines->Account tab.
(This would make sense in almost all cases except maybe in Accruing fines).

Alternatively, a text could be added to the description column. For example,
"Payment, thanks" could become "Payment on 15/09/2015 14:30, thanks",
"Writeoff" could become "Written off on 15/09/2015 14:30", etc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 13:39:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 11:39:41 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-FZm9IYxDdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I think we should try and get more people to look at this :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 13:53:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 11:53:46 +0000
Subject: [Koha-bugs] [Bug 16487] New: Cataloging/Authority search: add link
 to number of times used
Message-ID: <bug-16487-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16487

            Bug ID: 16487
           Summary: Cataloging/Authority search: add link to number of
                    times used
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: theod at lib.auth.gr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When cataloging an authority-controlled field, the librarians get a popup
window by clicking at the "...", where they search a term and get a list of
results.

In that list there is a separate column (titled "used") where one gets the
number this term is used in records.
It would be very helpful for the librarian if this number was a LINK that
displayed these specific records, so that he/she may select the proper
authority.

This functionality exists already in simple authority search (Home ?
Authorities ? Authority search results), so if accepted by the community,
implementing it in the popup window too would be fairly easy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:06:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:06:13 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-KlddHbArGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50930|0                           |1
        is obsolete|                            |

--- Comment #23 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 51377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51377&action=edit
Rebase on master

Same patch rebased on master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:07:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:07:46 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-Sb8dOjRcxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50286|0                           |1
        is obsolete|                            |

--- Comment #38 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 51378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51378&action=edit
Rebase on Master

Same patch, rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:25:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:25:45 +0000
Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials
In-Reply-To: <bug-16284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16284-70-6p6Q9sM5DJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:27:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:27:18 +0000
Subject: [Koha-bugs] [Bug 16488] New: UNIMARC to MARC21 xslt to be used in
 z39.50 import sources
Message-ID: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

            Bug ID: 16488
           Summary: UNIMARC to MARC21 xslt to be used in z39.50 import
                    sources
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Z39.50 / SRU / OpenSearch Servers
          Assignee: gmcharlt at gmail.com
          Reporter: theod at lib.auth.gr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It would be very helpful to have at least a 'basic' xsl template to be able to
convert UNIMARC data to USMARC when trying to search and import data from
UNIMARC z39.50 sources.

It seems that there is a generic xslt available for UNIMARC to MARC conversion
(https://github.com/edsd/biblio-metadata/blob/master/UNIMARC2MARC21.xsl) but it
obviously needs a few changes to work with Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:29:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:29:23 +0000
Subject: [Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50
 import sources
In-Reply-To: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16488-70-DxReYbIc4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6536

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:29:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:29:23 +0000
Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and
 additional XSLT processing
In-Reply-To: <bug-6536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6536-70-UtlcaO5Vkg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16488

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 14:40:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 12:40:15 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-Yth0P7a0Me@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Virtualshelves: Using no    |Virtualshelves: Using no
                   |XSLTResultsDisplay breaks   |XSLTResultsDisplay breaks
                   |content display in intranet |content display in intranet
                   |                            |(titles not showing in
                   |                            |lists)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 15:10:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 13:10:49 +0000
Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to
 regular checkout
In-Reply-To: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16272-70-30jWtPWB2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 15:16:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 13:16:50 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-LtpwHEeqNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #11 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #6)
> soon Koha will require Moose as well (and/or Moo or whatever)

Heh, it already does (in Koha/SearchEngine/* modules). I'm wondering why we
don't preload it in plack startup (and why we don't preload many more
heavy-weighted Koha and CPAN modules as well). And for the things we do preload
- is there any particular reason for preloading them from scratch again and
again per each 20 requests?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 15:58:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 13:58:29 +0000
Subject: [Koha-bugs] [Bug 16489] New: ES code incorrectly refers to Moose
Message-ID: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

            Bug ID: 16489
           Summary: ES code incorrectly refers to Moose
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- Run:
  $ git grep Moose
=> FAIL: There are unneeded references to Moose:
Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role;
Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 15:58:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 13:58:38 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-kj3Yfy55BP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:03:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:03:25 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-Suo04U46XN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:03:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:03:28 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-yiWEwYsHmr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51379&action=edit
Bug 16489: ES code incorrectly refers to Moose

Probably a leftover from the original SolR code, there are unused references to
Moose in the new Elasticsearch code.

To test:
- Run:
  $ git grep Moose
=> FAIL: There are unneeded references to Moose:
Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role;
Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role;
- Apply the patch
- Run:
  $ git grep Moose
=> SUCCESS: No references to Moose
- Run:
  $ prove t/Search* t/db_dependent/Search*
=> SUCCESS: Tests pass
- Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:04:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:04:05 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-8xRUw54UuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jacek Ablewicz from comment #11)
> (In reply to Jacek Ablewicz from comment #6)
> > soon Koha will require Moose as well (and/or Moo or whatever)
> 
> Heh, it already does (in Koha/SearchEngine/* modules).

It shouldn't, see bug 16489, I just filled it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:12:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:12:41 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-L2u0aJq8DP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:12:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:12:44 +0000
Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached
 using Koha::Cache
In-Reply-To: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16431-70-25Uv98tfjC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51139|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51380&action=edit
Bug 16431: Use Koha::Cache to cache marc subfield structure

The marc subfield structure is currently cached using a global variable
of C4::Context. The infos are retrieved every time a new context is
created.
This patch suggests to use Koha::Cache instead.

To achieve this goal, a new subroutine is created
C4::Biblio::GetMarcSubfieldStructure, it will be called from code which
needs to get the marc subfield structure. GetMarcFromKohaField,
GetMarcSubfieldStructureFromKohaField, TransformKohaToMarc and
_get_inverted_marc_field_map are modified accordingly and the cache is cleared
when the table is updated (from the 3 pl scripts modified by this patch).

The caching done in C4::Context (marcfromkohafield) is removed.

Test plan:
Play with the marc subfield structure (in the administration module),
then add and edit records and make sure everything went fine.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Everything works as expected on my functional tests. I'm really happy to see
the
patch introduces relevant tests for previously untested functions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:15:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:15:56 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-Ttelkh3Inh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:15:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:15:58 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-NnobgGBe1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51379|0                           |1
        is obsolete|                            |

--- Comment #2 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 51381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51381&action=edit
Bug 16489: ES code incorrectly refers to Moose

Probably a leftover from the original SolR code, there are unused references to
Moose in the new Elasticsearch code.

To test:
- Run:
  $ git grep Moose
=> FAIL: There are unneeded references to Moose:
Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role;
Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role;
- Apply the patch
- Run:
  $ git grep Moose
=> SUCCESS: No references to Moose
- Run:
  $ prove t/Search* t/db_dependent/Search*
=> SUCCESS: Tests pass
- Sign off

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:23:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:23:24 +0000
Subject: [Koha-bugs] [Bug 16490] New: Add an "add to cart" link for each
 search results in the staff client
Message-ID: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490

            Bug ID: 16490
           Summary: Add an "add to cart" link for each search results in
                    the staff client
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/catalogue/search.pl?q=X
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

On the OPAC search results page each line has an "add to cart" link. This lets
the user select individual results without having to check a box and scroll all
the way to the top. I propose to add this to the staff client search results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:26:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:26:11 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-Uu4FWONF7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16489


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489
[Bug 16489] ES code incorrectly refers to Moose
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:26:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:26:11 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-Y7Be7cArcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:27:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:27:21 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-n8chwGBI2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:43:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:43:41 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-HjizzOkEoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #13 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Tom?s Cohen Arazi from comment #12)

> > > soon Koha will require Moose as well (and/or Moo or whatever)
> > 
> > Heh, it already does (in Koha/SearchEngine/* modules).
> 
> It shouldn't, see bug 16489, I just filled it.

OTOH, it would be kinda helpfull to left it as is, if we are willing to peddle
plack more aggressively (just kidding).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:47:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:47:51 +0000
Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database
 via DBIx is not fast enough
In-Reply-To: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16079-70-ydsVa24i68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

--- Comment #14 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jacek Ablewicz from comment #13)

> OTOH, it would be kinda helpfull to left it as is, if we are willing to

s/left/leave/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 16:48:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 14:48:33 +0000
Subject: [Koha-bugs] [Bug 16491] New: Link barcodes in messages link to
 specific item during check in
Message-ID: <bug-16491-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16491

            Bug ID: 16491
           Summary: Link barcodes in messages link to specific item during
                    check in
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 15736 introduced a fix that turns off local use from populating the check
in table.  However, this takes away some functionality.  There are times, after
checking in an item, that a staff member needs to adjust something on the item.
 When the item appears in the check in table, the barcode gives a direct link
to the item.  With it off, all you have is what is shown in the message.  The
barcode shows, but the barcode and title are a single link to the record. 
Because of this, with the ShowAllCheckins preference set to Do not show, it
takes an extra click to get to the item.  It would be helpful if the barcode
was a separate link to the item.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:00:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:00:41 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-quIknSstxK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #39 from Marc V?ron <veron at veron.ch> ---
Testing:

- patch applied
- dbupdate done
- schema updated

Test 1:

- System preferences CheckPrevCheckout is: 'Unless overridden, DO...'
- Category X has: 'NO and try to override system preferences'
- Patron (of category X) has: Check previous checkouts: inherited

Result: Warning 'This item has previously been checked out to this patron.'
Expected: No warning.

Test 2:
- System preferences CheckPrevCheckout is: 'Unless overridden, DO NOT...'
- Category X has: 'YES and try to override system preferences'
- Patron (of category X) has: Check previous checkouts: inherited

Result: No warning
Expected: Warning

If I read correctly, I would expect that the patron category settings override
the system preferences.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:01:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:01:08 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-PcplDOhYBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:01:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:01:11 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-KN7CDkKfD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50665|0                           |1
        is obsolete|                            |
  Attachment #50666|0                           |1
        is obsolete|                            |
  Attachment #50729|0                           |1
        is obsolete|                            |

--- Comment #31 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51382&action=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
    PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:06:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:06:01 +0000
Subject: [Koha-bugs] [Bug 16490] Add an "add to cart" link for each search
 results in the staff client
In-Reply-To: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16490-70-gX3nBYzMxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:06:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:06:03 +0000
Subject: [Koha-bugs] [Bug 16490] Add an "add to cart" link for each search
 results in the staff client
In-Reply-To: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16490-70-oVDUHXGlx5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51383&action=edit
Bug 16490 - Add an "add to cart" link for each search results in the staff
client

This patch adds an "add to cart" link to each line of search results in
the staff client.

To test, apply the patch and clear your browser cache if necessary.

- Enable the intranetbookbag system preference.
- Perform a search which will return multiple search results.
- Each result should have an "Add to cart" link.
  - Clicking the "Add to cart" link should add the title to the cart,
    triggering the correct pop-up message and changing the link to read
    "In your cart (remove)."
  - Clicking the "remove" link should remove the title from your cart
    and trigger the correct messages.
- Add multiple titles to your cart and perform the same search again.
  Each result should correctly indicate which titles are already in your
  cart.
- Open the cart popup window.
  - Check the checkbox for one or more titles in your cart and choose
    "Remove." The titles should be removed, and the "In your cart" label
    in the search results page should reflect that the titles are no
    longer in the cart.
  - Choose "Empty and close." All titles in the parent page should now
    indicate that they are not in the cart.
- Disable the intranetbookbag preference and confirm that the "Add to
  cart" links are no longer there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:06:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:06:52 +0000
Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems,
 OpacHiddenItems total count, prog them facet display
In-Reply-To: <bug-11909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11909-70-8Er2buQ2Uj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:17:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:17:51 +0000
Subject: [Koha-bugs] [Bug 16490] Add an "add to cart" link for each search
 results in the staff client
In-Reply-To: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16490-70-Uh74IidA1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51383|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51384&action=edit
Bug 16490 - Add an "add to cart" link for each search results in the staff
client

This patch adds an "add to cart" link to each line of search results in
the staff client.

To test, apply the patch and clear your browser cache if necessary.

- Enable the intranetbookbag system preference.
- Perform a search which will return multiple search results.
- Each result should have an "Add to cart" link.
  - Clicking the "Add to cart" link should add the title to the cart,
    triggering the correct pop-up message and changing the link to read
    "In your cart (remove)."
  - Clicking the "remove" link should remove the title from your cart
    and trigger the correct messages.
- Add multiple titles to your cart and perform the same search again.
  Each result should correctly indicate which titles are already in your
  cart.
- Open the cart popup window.
  - Check the checkbox for one or more titles in your cart and choose
    "Remove." The titles should be removed, and the "In your cart" label
    in the search results page should reflect that the titles are no
    longer in the cart.
  - Choose "Empty and close." All titles in the parent page should now
    indicate that they are not in the cart.
- Disable the intranetbookbag preference and confirm that the "Add to
  cart" links are no longer there.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:20:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:20:28 +0000
Subject: [Koha-bugs] [Bug 16490] Add an "add to cart" link for each search
 results in the staff client
In-Reply-To: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16490-70-g8kS6Gor6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:22:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:22:43 +0000
Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by
 OpacHiddenItems turn up in facet results
In-Reply-To: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14007-70-zgf9g1Rkad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:25:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:25:46 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-4lrQ6iTGSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:26:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:26:16 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-hpdJrvxNsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48938|0                           |1
        is obsolete|                            |
  Attachment #48939|0                           |1
        is obsolete|                            |
  Attachment #50259|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51385&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop

The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns
them ordered by the description (frameworktext). If a parameter is
passed, a selected flag is set. The selection of the options should be
done on the template side.
These 2 calls can be replaced with
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });

Test plan:
1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl)
You should see a dropdown list with the biblio frameworks. The framework
of the record should be selected by default
2/ Create a sql report using the biblio_framework parameter, something
like:
  SELECT COUNT(*) FROM biblio WHERE
frameworkcode=<<framework|biblio_framework>>
Save and execute the report.
You should get a dropdown list with the framework list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:26:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:26:46 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-3MFqRivBEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51386&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks

C4::Koha::getframeworks returned a hashref of biblio frameworks.
It was mainly used to generate the dropdown list of frameworks.
The scripts modified in this patch did not necessary order the element
by description (frameworktext), the displays were not consistent from
one screen to another.
Using the same search method everywhere:
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
We will know always get the framework in the same order.

Test plan:
Following the different pages modified by this patch, and make sure the
frameworks are displayed correctly in the dropdown list:
1/ acqui/z3950_search.pl - Create an order from an external source.
2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field
3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select
another framework than the default one and click on the 'Search' button
4/ catalogue/MARCdetail.pl - On the MARC defail page, change the
framework you want to use to display the record
5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its
framework. When editing, the framework of the record should be selected
by default
6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click
on the "New record" button. You should see all the frameworks
7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first
step (select the merge reference), you should be allowed to select the
framework to use.
8/ tools/inventory.pl - On the inventory page, the "Item statuses" part
should be populated as before this patch
9/ tools/manage-marc-import.pl - Stage records for import. Before
importing them into the catalog, you should see the framework dropdown
list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:27:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:27:40 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-K5c7VYFAlh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51387&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo

This was the "Get" subroutine for the framework, it can be easily
replaced with a call to the Koha::BiblioFrameworks->find method.
This patch also replaces some confusing wordings (framework vs frameworkcode).

Test plan:
On the circulation home page, you should get a warning message if you
don't have the FA (Fast cataloguing) framework

Note that the admin/marctagstructure.pl has already been tested in the
previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:38:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:38:57 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-0bhMxYVnHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:39:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:39:45 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-37bB6FViKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51381|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51388&action=edit
Bug 16489: ES code incorrectly refers to Moose

Probably a leftover from the original SolR code, there are unused references to
Moose in the new Elasticsearch code.

To test:
- Run:
  $ git grep Moose
=> FAIL: There are unneeded references to Moose:
Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role;
Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role;
- Apply the patch
- Run:
  $ git grep Moose
=> SUCCESS: No references to Moose
- Run:
  $ prove t/Search* t/db_dependent/Search*
=> SUCCESS: Tests pass
- Sign off

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:41:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:41:58 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-vGZ7Fan4Oo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51382|0                           |1
        is obsolete|                            |

--- Comment #32 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51389&action=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
    PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 17:42:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 15:42:40 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-BesAb6j5Ao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #174 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Colin Campbell from comment #173)
> (In reply to Jonathan Druart from comment #172)
> > (In reply to Colin Campbell from comment #171)
> > > (In reply to Jonathan Druart from comment #170)
> > > > This patchset introduces some uses of CGI->param in list context, please fix.
> > > 
> > > Any clue as to where?
> > 
> >   grep '=>.*->param' admin/edi_*
> > 
> > and see commit f3e4b5bbb6b02d7bb6e89d84c0379666eb1e704f
> >     Bug 16154: CGI->multi_param - Force scalar context
> > should give you some tricks.
> > 
> > Basically you need to force the scalar context if called in a list context
> > (when passed to the template).
> 
> Exactly these are scalar context calls

Please have a look at bug 16154 and bug 15809 if you want more information on
this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:06:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:06:22 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-MTWsn6zu9o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #40 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Hi Marc,

Thank you very much for taking the time to test the patch.

I am currently not able to reproduce the problem you describe on my test system
(with a fresh install of Koha and this patch).

Would you be able to run the test suite to see if that passes for you (prove
t/db_dependent/Patron/CheckPrevCheckout.t)?

Bizarre thing is, your test results are exactly the opposite of what is
supposed to happen.  You are right in thinking the determining factor in this
context should be the category setting *only*.

Alex

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:09:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:09:48 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-q9ny3WEllf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
I disagree with some of these choices. These are the existing patterns for
button use as I understand them:

https://wiki.koha-community.org/wiki/Interface_patterns#Buttons

> -Patron lists -> New patron List -> Save

In general submit buttons are not styled as Bootstrap buttons and do not have
icons attached to them.

> -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,

There is currently some confusion in how we indicate remove or cancel (See Bug
16005). I think the "trash" icon should be the standard for delete or remove.

> -Import patrons -> Import
> -Overdue notice/status triggers -> Save changes
> -Batch patron modification -> Save
> -Upload patron images -> Upload

I think these are all basic submits button and should be unstyled.

> -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all,

The links under "Terms summary" should not have icons. Icons are attached to
controls which trigger actions. These links are for different views of the
data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:13:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:13:04 +0000
Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive
In-Reply-To: <bug-16282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16282-70-efGc8sRoRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |chris at bigballofwax.co.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:26:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:26:24 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-Xb5vWXhedS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #41 from Marc V?ron <veron at veron.ch> ---
Hi Alex,

I get:
t/db_dependent/Patron/CheckPrevCheckout.t .. ok     
All tests successful.
Files=1, Tests=59,  3 wallclock secs ( 0.03 usr  0.01 sys +  2.37 cusr  0.31
csys =  2.72 CPU)
Result: PASS

However, I did not test on a fresh install. I will try to find out what happens
on my site.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:33:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:33:47 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-8PDIcewalj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #42 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Hmm... thanks for your quick response.

The tests essentially go through all permutations of the user, category,
syspref combinations ? and they pass.

It seems interesting the error occurs in the UI for you.

I'd be very interested in hearing further results from your side!

Alex

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:36:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:36:15 +0000
Subject: [Koha-bugs] [Bug 16492] New: Checkouts ( and possibly checkins and
 other actions ) will use the patron home branch as the logged in library
Message-ID: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

            Bug ID: 16492
           Summary: Checkouts ( and possibly checkins and other actions )
                    will use the patron home branch as the logged in
                    library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
non-Koha internal authentication processes would be able to function via SIP (
LDAP et al ).

The problem is that checkpw changes the userenv to that of the patron! This is
not usually an issue in Koha because most of the time that patron running
through checkpw is the one to be logged in.

Aside from SIP2 the only other area where this may be an issue is in SCO when
using SelfCheckoutByLogin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:36:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:36:30 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-ANVXvF2QgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:39:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:39:21 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-yNXKV5JDaR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51390&action=edit
Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the
patron home branch as the logged in library

Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
non-Koha internal authentication processes would be able to function via
SIP ( LDAP et al ).

The problem is that checkpw changes the userenv to that of the patron!
This is not usually an issue in Koha because most of the time that
patron running through checkpw is the one to be logged in.

Aside from SIP2 the only other area where this may be an issue is in SCO
when using SelfCheckoutByLogin.

Test Plan:
1) On master, check out an item to a patron via SIP2
2) Note the checkout lists the item as having been checked out
   from the patron's home library not matter which library is was
   supposed to be checked out from.
3) Apply this patch
4) Re-checkout the item
5) The item should now be checked out as if it was checked out from
   the library as defined in the SIP configuration file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:41:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:41:07 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-uXU9mb0LEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51390|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51391&action=edit
Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the
patron home branch as the logged in library

Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
non-Koha internal authentication processes would be able to function via
SIP ( LDAP et al ).

The problem is that checkpw changes the userenv to that of the patron!
This is not usually an issue in Koha because most of the time that
patron running through checkpw is the one to be logged in.

Aside from SIP2 the only other area where this may be an issue is in SCO
when using SelfCheckoutByLogin.

Test Plan:
1) On master, check out an item to a patron via SIP2
2) Note the checkout lists the item as having been checked out
   from the patron's home library not matter which library is was
   supposed to be checked out from.
3) Apply this patch
4) Re-checkout the item
5) The item should now be checked out as if it was checked out from
   the library as defined in the SIP configuration file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:41:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:41:22 +0000
Subject: [Koha-bugs] [Bug 14722] Refactor the catalogue export tool
 (command-line tools/export.pl does not work anymore. Use
 misc/export_records.pl instead)
In-Reply-To: <bug-14722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14722-70-pYTYCmNmPp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:41:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:41:33 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-KCHW2qW9XF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14507
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507
[Bug 14507] SIP Authentication broken when LDAP Auth Enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:41:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:41:33 +0000
Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth
	Enabled
In-Reply-To: <bug-14507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14507-70-4SDKvi2ZzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492
[Bug 16492] Checkouts ( and possibly checkins and other actions ) will use the
patron home branch as the logged in library
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 18:42:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 16:42:24 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-qO4zdeLe7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #43 from Marc V?ron <veron at veron.ch> ---
Hi Alex,

I'm sorry... I messed up the patron categories while testing... Mea culpa!

Will do some more testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 19:09:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 17:09:19 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-JNuavCEwQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51335|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51392&action=edit
Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

The new class Koha::Cache::Memory::Lite must be flushed by the CGI
constructor overide done in the psgi file. This new class will ease
caching of specific stuffs used by running script.

Test plan:
At the OPAC and the intranet interfaces:
Open 2 different browser session to simulate several users
- Clear the cookies of the browsers
- User 1 (U1) an User 2 (U2) should be set to the default language
  (depending on the browser settings)
- U1 chooses another language
- U2 refreshes and the language used must be the default one
- U2 chooses a third language
- U1 refreshes and must be still using the one he has choosen.

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 19:14:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 17:14:39 +0000
Subject: [Koha-bugs] [Bug 16493] New: acq matching on title and author
Message-ID: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

            Bug ID: 16493
           Summary: acq matching on title and author
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When you order from a staged file you're getting duplicate warnings that are
inaccurate.  For example, when you order a file of 50 DVDs for example and they
don't have ISBNs they're matching on the books. And then you have to order them
one by one.

----------

[11:42]  <cait> it seems to use FindDuplicate
[11:43]  <cait>
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Search.pm;hb=47dc39997198126be702c13c58053e793c609f90#l83
[11:44]  <cait> i might be misreading it, but looks like isbn when there is one
- if there is none, title and author

-----------

This shouldn't happen, it's a big deal in libraries that do a lot of ordering
and is just plain wrong based on cataloging rules.  Is there any way to
override this without doing them one by one or a way to make it use the
matching rules instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 19:57:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 17:57:23 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-bmASD7KgQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #44 from Marc V?ron <veron at veron.ch> ---
Created attachment 51393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51393&action=edit
Bug 6906 - show 'Borrower has previously issued...

New feature: provide granular means to configure warnings about items
that have been issued to a particular borrower before, according to
their checkout history.

- Global syspref ('CheckPrevCheckout'), set to 'hardno' by default,
  allows users to enable this feature library wide.
- Per patron category pref allows libraries to create overrides per
  category, falling back on the global setting by default.
- Per patron pref allows switching the functionality on at the level
  of patron. Fall-back to category settings by default.

* Koha/Patron (wantsCheckPrevCheckout, doCheckPrevCheckout): New
  methods.
* C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevCheckout
  check.
* admin/categories.pl: Pass along checkprevcheckout.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose
  CheckPrevCheckout per category setting.
* koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref:
  Expose CheckPrevCheckout syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
  Expose per patron CheckPrevCheckout preference.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose
  per patron CheckPrevCheckout preference.
* koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add
  'CHECKPREVCHECKOUT' confirmation message.
* installer/data/mysql/kohastructure.sql: Modify structure of
  'categories', 'borrowers', 'oldborrowers'.
* installer/data/mysql/sysprefs.sql: Add 'CheckPrevCheckout'.
* installer/data/mysql/atomicupdate/checkPrevCheckout.sql: New file.
* t/db_dependent/Patron/CheckPrevCheckout.t: New file with unit tests.

Test plan:
- Apply patch.
- Run updatedatabase.
- Regenerate Koha Schema files.
- Run the unit tests.
- Verify 'CheckPrevCheckout' is visible in Patrons sysprefs and can be
  switched to 'hardyes', 'softyes', 'softno' and 'hardno'.
  + Check out previously checked out items to a patron, checking the
    message appears as expected.
- Verify no 'Check previous checkouts' setting appears on the borrower
  category pages if the syspref is set to a 'hard' option.
- Verify 'Check previous checkouts' setting appears on the borrower
  category pages and can be modified per borrower category.
  + Issue previously issued items to a borrower, checking the message
    appears as expected (This setting should override the default
    setting if that is set to a 'soft' option).
- Verify no 'Check previous checkouts' setting appears on the individual
  borrower pages if the syspref is set to a 'hard' option.
- Verify 'Check previous checkouts' setting appears on individual
  borrower pages and can be modified.
  + Issue previously issued items to a borrower, checking the message
    appears as expected (This setting should override the category
    setting and the default setting if the latter is set to a 'soft'
    option).

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 19:57:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 17:57:52 +0000
Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM'
 alert on checkout
In-Reply-To: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6906-70-cqxs2sFJSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 20:02:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 18:02:33 +0000
Subject: [Koha-bugs] [Bug 16494] New: Remove the use of "onclick" from some
	patron pages
Message-ID: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494

            Bug ID: 16494
           Summary: Remove the use of "onclick" from some patron pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Several patron-related pages include the use of "onclick" attributes. These
should be replaced in favor of defining events in JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 20:19:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 18:19:44 +0000
Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha
In-Reply-To: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14239-70-wJJk4ahEXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 20:25:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 18:25:16 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-IvmKjXIXI7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 20:37:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 18:37:44 +0000
Subject: [Koha-bugs] [Bug 16495] New: acq ordering from staged file
	laborious with dups
Message-ID: <bug-16495-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16495

            Bug ID: 16495
           Summary: acq ordering from staged file laborious with dups
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When you order from a staged file if there are duplicates you have to process
each title individually.  The individual process doesn't bring over the fund,
and takes you back to the basket after every title. I will get a video of this.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 20:41:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 18:41:55 +0000
Subject: [Koha-bugs] [Bug 16495] acq ordering from staged file laborious
	with dups
In-Reply-To: <bug-16495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16495-70-Ss4KRtfjns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16495

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Video: http://screencast.com/t/qcojJvy9GPJK

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:03:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:03:57 +0000
Subject: [Koha-bugs] [Bug 16496] New: accountlines.issue_id not set when new
 overdue is processed
Message-ID: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

            Bug ID: 16496
           Summary: accountlines.issue_id not set when new overdue is
                    processed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It appears that somehow the adding of issue_id to accountlines for new fines
was missed! This is incredibly important, otherwise UpdasteFine will always
create a new fine!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:05:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:05:13 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-fhNi2Ex44Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:06:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:06:47 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-3QoX3r8lBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:06:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:06:49 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-zhxQZjZt3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51394&action=edit
Bug 16496 - accountlines.issue_id not set when new overdue is processed

It appears that somehow the adding of issue_id to accountlines for new
fines was missed! This is incredibly important, otherwise UpdasteFine
will always create a new fine!

Test Plan:
1) Create a new overdue checkout
2) Run fines.pl to generate an accountline for it
3) Note it has no issue_id
4) Apply this patch
5) Repeat steps 1 and 2
6) Note it now has an issue_id!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:07:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:07:43 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-fwRkjgpvV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51394|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51395&action=edit
Bug 16496 - accountlines.issue_id not set when new overdue is processed

It appears that somehow the adding of issue_id to accountlines for new
fines was missed! This is incredibly important, otherwise UpdateFine
will always create a new fine!

Test Plan:
1) Create a new overdue checkout
2) Run fines.pl to generate an accountline for it
3) Note it has no issue_id
4) Apply this patch
5) Repeat steps 1 and 2
6) Note it now has an issue_id!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:08:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:08:07 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-5LxIxDjBTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
s/UpdasteFine/UpdateFine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:28:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:28:40 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-2aJr6S9SQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #33 from Marc V?ron <veron at veron.ch> ---
I re-tested, it seems that the "Save" button in the quick add form no longer
works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 21:30:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 19:30:16 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-vHy53a68iy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #104 from Florent Mara <florent.mara at gmail.com> ---
It is good enough for now. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 22:14:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 20:14:57 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-7i3d70JG4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #54 from Mason James <mtj at kohaaloha.com> ---
(In reply to Nick Clemens from comment #52)
> This patch has altered the way that the patron branch is sent.  Previously
> it was in a separate AF field, now the branch is concatenated onto the other
> messages with a ' -- '
> 
> I am not sure if this is intentional but it is causing problems for one of
> our libraries where this field was captured for statistical purposes. Can we
> adjust this?

hi Nick, no, it's not an intentional change, and can be changed back

(i think the AF change may have happened in a follow-up patch?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 22:18:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 20:18:59 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-ziStojpyJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #105 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Florent Mara from comment #104)
> It is good enough for now. :-)

If it's ready, could you please change status to 'Needs Signoff'?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 10 22:21:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 20:21:05 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-kwangMSMQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 00:36:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 22:36:14 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-c9nxwNCGtN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
          Component|Installation and upgrade    |I18N/L10N
                   |(web-based installer)       |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 00:40:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 22:40:26 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-HcRWcO6mVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 00:40:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 22:40:29 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-auy66cfVnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51396&action=edit
Bug 16382: Update German web installer sample files for 16.05

Easy this time, only sample notices have been changed:
- Changed discharge to match the English sample notice.
- Translated new PASSWORD_RESET e-mail

To test:
- Start with an empty database
- Install de-DE
- Run the web installer in de-DE/German
- Verify all files, especially sample notices, load
  without any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 00:50:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 May 2016 22:50:55 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-JBWtD4q7Xk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 05:21:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 03:21:13 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-eOTY29aPgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496
[Bug 16496] accountlines.issue_id not set when new overdue is processed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 05:21:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 03:21:13 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-An82CARxTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
         Depends on|                            |13790

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Ahh looks like this was missed when bug 13790 was done, will test now


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790
[Bug 13790] Add unique id issue_id to issues and old_issues tables
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 05:32:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 03:32:41 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-UBKhaqOFK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 05:32:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 03:32:43 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-qn6xap9jEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51395|0                           |1
        is obsolete|                            |

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51397&action=edit
Bug 16496 - accountlines.issue_id not set when new overdue is processed

It appears that somehow the adding of issue_id to accountlines for new
fines was missed! This is incredibly important, otherwise UpdateFine
will always create a new fine!

Test Plan:
1) Create a new overdue checkout
2) Run fines.pl to generate an accountline for it
3) Note it has no issue_id
4) Apply this patch
5) Repeat steps 1 and 2
6) Note it now has an issue_id!

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 10:59:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 08:59:22 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-r5YwQOfxl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51392|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51398&action=edit
Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

The new class Koha::Cache::Memory::Lite must be flushed by the CGI
constructor overide done in the psgi file. This new class will ease
caching of specific stuffs used by running script.

Test plan:
At the OPAC and the intranet interfaces:
Open 2 different browser session to simulate several users
- Clear the cookies of the browsers
- User 1 (U1) an User 2 (U2) should be set to the default language
  (depending on the browser settings)
- U1 chooses another language
- U2 refreshes and the language used must be the default one
- U2 chooses a third language
- U1 refreshes and must be still using the one he has choosen.

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:24:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:24:45 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-z3ZewvB7k9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:24:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:24:48 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-xBIzol6EuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51397|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51399&action=edit
Bug 16496 - accountlines.issue_id not set when new overdue is processed

It appears that somehow the adding of issue_id to accountlines for new
fines was missed! This is incredibly important, otherwise UpdateFine
will always create a new fine!

Test Plan:
1) Create a new overdue checkout
2) Run fines.pl to generate an accountline for it
3) Note it has no issue_id
4) Apply this patch
5) Repeat steps 1 and 2
6) Note it now has an issue_id!

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:24:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:24:52 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-hd1C8ppJO9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51400&action=edit
Bug 16496: Add test

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:36:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:36:08 +0000
Subject: [Koha-bugs] [Bug 16385] Fix breadcrumbs when ordering from
	subscription
In-Reply-To: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16385-70-yKirfFjNR9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16385

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |5343


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343
[Bug 5343] Subscription cost (Link serial and acqui modules)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:36:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:36:08 +0000
Subject: [Koha-bugs] [Bug 5343] Subscription cost (Link serial and acqui
	modules)
In-Reply-To: <bug-5343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5343-70-yYT5x2DFGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16385


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16385
[Bug 16385] Fix breadcrumbs when ordering from subscription
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:37:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:37:15 +0000
Subject: [Koha-bugs] [Bug 16385] Fix breadcrumbs when ordering from
	subscription
In-Reply-To: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16385-70-mgzJaxhkoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16385

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:37:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:37:18 +0000
Subject: [Koha-bugs] [Bug 16385] Fix breadcrumbs when ordering from
	subscription
In-Reply-To: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16385-70-NW3U4V8pAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16385

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50992|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51401&action=edit
Bug 16385: Fix breadcrumbs when ordering from subscription

- Rephrase removing 'Shopping'
- Fix link to vendor

To test:
- Create a subscription for vendor X
- Create a baskest for vendor X
- Choose: order from subscription
- Check breadcrumbs:
  - Link to vendor works
  - 'Shopping' is gone, Basket remains

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:39:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:39:36 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-fAXakA44YQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:39:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:39:39 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-upYCeVi4JH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51306|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51402&action=edit
Bug 16471: Translatability: Fix issues in opac-password-recovery.tt

This patch fixes issues with the translatability of opac-password-recovery.tt

To test:
- Apply patch
- Verify that text changes make sense.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:40:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:40:56 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-CUiMHHeVnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:44:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:44:05 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-DLCJlA8RBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13234, 10860
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860
[Bug 10860] On-site checkouts (was In-House Use)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234
[Bug 13234] Make on-site checkouts visible in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:44:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:44:05 +0000
Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
In-Reply-To: <bug-10860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10860-70-OGymlJYtL8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478
[Bug 16478] Translation breaks display of Checkout history in tab Checkouts /
On-site-checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:44:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:44:05 +0000
Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC
In-Reply-To: <bug-13234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13234-70-owDbcbM3K4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478
[Bug 16478] Translation breaks display of Checkout history in tab Checkouts /
On-site-checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:44:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:44:24 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-7sFprRvUTM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Who signed the|                            |Jonathan Druart
          patch off|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:46:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:46:28 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-cLAnli9cgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #18 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
That part of the code

  if ( $cgi and not $cgi->param('language') ) {
      my $cached = $memory_cache->get_from_cache($cache_key);

still doesn't look quite right IMO; getlanguage() is almost never called with
$cgi parameter, and the cached value will be hardly ever used.

Shoudn't it be something like that instead:

  unless ($cgi && $cgi->param('language')) {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:51:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:51:48 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-950KAoj9Tt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Just wondering:
With that change, if automatic_renewals.pl and/or fines.pl fail,
overdue_notices.pl will not be launched. Is it really what we expect?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:57:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:57:36 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-cdEicVYRD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |7736


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:57:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:57:36 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-fkV3DSN6Yk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16474


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474
[Bug 16474] Standardize spelling of EDIFACT
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:58:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:58:33 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-7myfnSJwla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 11:58:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 09:58:37 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-xz1LMD7oUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51351|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51403&action=edit
Bug 16474: Standardize spelling of EDIFACT

Some templates use Edifact and edifact. As EDIFACT
is an abbreviation, we should spell it like one.

To test:
- Check templates for occurrences of EDIFACT
  - acquisitions navigation menu
  - basket page
  - basketgroup page
  - EDIFACT messages page
- Verify changes are correct

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Changes are correct

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:02:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:02:57 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-g1hJ4bvuEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:03:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:03:01 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-Rg6XvRuWtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51352|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51404&action=edit
Bug 16481 - Report menu has unexpected issues

This patch corrects a problem with the reports toolbar include file
which can cause a problem with the "duplicate" button. The duplicate
button passes the entire report SQL as a URL parameter, but the template
variable was not escaped as a URL variable.

This patch also adds the "uri" filter to the report name and notes
fields just to be safe.

To reproduce the bug, create a new SQL report using the SQL in the bug
report. When you run the report you should see a broken "Duplicate"
button.

Apply the patch and run the report again. The duplicate button should
look correct and work correctly.

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:07:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:07:33 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-0Wh3c0EBjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51398|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51405&action=edit
Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

The new class Koha::Cache::Memory::Lite must be flushed by the CGI
constructor overide done in the psgi file. This new class will ease
caching of specific stuffs used by running script.

Test plan:
At the OPAC and the intranet interfaces:
Open 2 different browser session to simulate several users
- Clear the cookies of the browsers
- User 1 (U1) an User 2 (U2) should be set to the default language
  (depending on the browser settings)
- U1 chooses another language
- U2 refreshes and the language used must be the default one
- U2 chooses a third language
- U1 refreshes and must be still using the one he has choosen.

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:07:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:07:52 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-OJN6LlujN6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #18)
> That part of the code
> 
>   if ( $cgi and not $cgi->param('language') ) {
>       my $cached = $memory_cache->get_from_cache($cache_key);
> 
> still doesn't look quite right IMO; getlanguage() is almost never called
> with $cgi parameter, and the cached value will be hardly ever used.
> 
> Shoudn't it be something like that instead:
> 
>   unless ($cgi && $cgi->param('language')) {

Indeed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:09:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:09:55 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-88FEMLIkXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:09:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:09:59 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves line 332 on
	intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-2UM297gA0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51355|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51406&action=edit
Bug 16480: Unclosed tag <span> in shelves line 332 on intranet

Unclosed tag <span> in shelves line 332 on intranet when translating
<span>An error occurred when creating this list./span>
This error was introduced by bug 15403

To test: Verify the template in line 332 to see the unclosed tag fixed
or follow test plan for bug 15403

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:25 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-EtbcFRHOnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50616|0                           |1
        is obsolete|                            |

--- Comment #10 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51407&action=edit
Bug 16276: Update borrowers.lastseen when a patron is active

In order to add the ability to delete patrons who have been inactive for
more than a given time, we need to track down the last time they were
active.
To do that, we need a new DB column in the borrowers table (lastseen).
Note that the borrowers.lastseen column will not be initialised for existing
installations (set to NULL) so inactive existing patrons will never be
deleted.
A workaround would be to init them at the date when the new column will
be added.

Test plan:
0/ Set the new pref TrackLastPatronActivity on
1/ Log in as a patron (staff or OPAC)
2/ Check that the borrowers.lastseen field has been updated with the
current time

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:23 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-IJtvSzWcfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:30 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-GsFNOvuH8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50617|0                           |1
        is obsolete|                            |

--- Comment #11 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51408&action=edit
Bug 16276: Make delete_patrons.pl deal with --last_seen

This patch modify the delete_patrons.pl cronjob to deal with the
last_seen option.

To test it, you just have to use the --last_seen option and pass a valid
date (iso format)

Example:
  perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm
will delete all the patrons who do not have been active since this date.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:38 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-sbC3p5NPUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50619|0                           |1
        is obsolete|                            |

--- Comment #13 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51410&action=edit
Bug 16276: Make the batch patron deletion tool deal with last_seen

This patch adds the same change as the previous one to the batch patron
deletion tool.

If the pref TrackLastPatronActivity is enabled, the librarians will be
able to delete patrons who do not have been connected since a given
time.

Test plan:
Define a date for the "who have not been connected since" options and
confirm that it works as expected.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:34 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-mRzNnnhirR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50618|0                           |1
        is obsolete|                            |

--- Comment #12 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51409&action=edit
Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
With small change: number of tests in t/db_dependent/Members.t

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:43 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-DYLAyZZKmv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50620|0                           |1
        is obsolete|                            |

--- Comment #14 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51411&action=edit
Bug 16276: [DO_NOT_PUSH ] schema changes

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:27:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:27:47 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log them selves recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-e5neQpFdUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51191|0                           |1
        is obsolete|                            |

--- Comment #15 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51412&action=edit
Bug 16276: Add a new pref TrackLastPatronActivity and new column
borrowers.lastseen

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

https://bugs.koha-community.org/show_bug.cgi?id=12276

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:35:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:35:28 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves on intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-36AEx16DHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Summary|Unclosed tag <span> in      |Unclosed tag <span> in
                   |shelves line 332 on         |shelves on intranet
                   |intranet                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:40:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:40:05 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-3wNEWerTqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for the 16.05 release! Thanks for the unit test Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:51:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:51:12 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-l3fKFSOsS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
opac-shelves.pl and virtualshelves/shelves.pl have diverged in this area.
The OPAC script calls GetBiblioData, which populated title and other infos.
It would make sense to add the call to the staff script to avoid different
behaviors between these 2 scripts.

The eternal question is: should we continue to fix non-XSLT views? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:53:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:53:57 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-MU9s1DFkFf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #26 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #25)
> Just wondering:
> With that change, if automatic_renewals.pl and/or fines.pl fail,
> overdue_notices.pl will not be launched. Is it really what we expect?

I still think comment #17 is better: (R && F) ; O

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 12:58:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 10:58:13 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-GP0U7pdV4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
For our libraries, I'd say yes - because the overdues sent would be wrong
(wrong fines, overdues that shouldn't be overdue, but renewed).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:16:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:16:57 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-CgfzljAy63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #27)
> For our libraries, I'd say yes - because the overdues sent would be wrong
> (wrong fines, overdues that shouldn't be overdue, but renewed).

Yes but the letters will not be generated at all and the patron will not be
notified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:19:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:19:28 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-hOgIvquOSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:19:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:19:52 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-BIi6cTnOto@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:19:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:19:56 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-LuP4XGQ1S3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51413&action=edit
Bug 16458: Update library when a guarantor is set

If you edit a patron from the Edit link of the patron information block
(step 1 of the memberentry script), the branchcode is not displayed. If
you set a guarantor to a child from this form, a JavaScript error will
be raised:
  JavaScript error form.branchcode is undefined

It happens because there is the branchcode is not displayed and there is
no element with a branchcode name.

To avoid this issue, a branchcode hidden input is added to the form and
it will be updated when a guarantor is selected (same behavior as when
you edit a patron using the complete form).

Test plan:
Edit a patron using the Edit link of the patron info block (not the Edit
button in the toolbar)
Set a guarantor
=> Notice that the branchcode of the patron has been updated with the
branchcode of the guarantor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:21:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:21:31 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: <bug-11622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11622-70-gwbOcC2RDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16473


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473
[Bug 16473] Tiny typo: there was _an_ problem ...
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:21:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:21:31 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-PBrpFWctse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |11622


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622
[Bug 11622] Add ability to pay fees and fines from OPAC via PayPal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:22:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:22:18 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-eWu9ya0qMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:22:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:22:26 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-fEtkF5w27u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51414&action=edit
Bug 16473: Fix typo "an problem" vs "a problem"

Test plan:
Confirm the wording is correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:28:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:28:25 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-TdK3zxl5QC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |julian.maurice at biblibre.com

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Theodoros,
It seems to be related to the field biblioitems.collectiontitle which is only
used by UNIMARC users.
Julian, could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:28:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:28:37 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-b7kKjGRzWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.20                        |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:32:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:32:11 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-Wmk8SG2e7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493
[Bug 16493] acq matching on title and author
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:32:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:32:11 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-kyPm4guwzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12074
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074
[Bug 12074] Filter duplicates when adding a full batch from a staged file
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:32:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:32:21 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-vunnccMHsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:35:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:35:35 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-XE3pjj5Thh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #52)
> This patch has altered the way that the patron branch is sent.  Previously
> it was in a separate AF field, now the branch is concatenated onto the other
> messages with a ' -- '
> 
> I am not sure if this is intentional but it is causing problems for one of
> our libraries where this field was captured for statistical purposes. Can we
> adjust this?

Hi Nick,
Your problem should not be that hard to resolve.
I think we should not rely on the fact that AF only includes the patron branch
code. It is just a screen message field. And I am not sure if SIP2 officially
supports multiple AF fields btw.
Could you use field AO that only contains the institution id? But not usable
for another branch.
Or - as workaround - add a prefix to the AF home branch part and capture only
that part with a simple regex or so?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:36:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:36:00 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-RpePJ5yiff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:36:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:36:03 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-D6L9QsER6y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51405|0                           |1
        is obsolete|                            |

--- Comment #21 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 51415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51415&action=edit
Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

The new class Koha::Cache::Memory::Lite must be flushed by the CGI
constructor overide done in the psgi file. This new class will ease
caching of specific stuffs used by running script.

Test plan:
At the OPAC and the intranet interfaces:
Open 2 different browser session to simulate several users
- Clear the cookies of the browsers
- User 1 (U1) an User 2 (U2) should be set to the default language
  (depending on the browser settings)
- U1 chooses another language
- U2 refreshes and the language used must be the default one
- U2 chooses a third language
- U1 refreshes and must be still using the one he has choosen.

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:47:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:47:02 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-KhI8LDOTmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #22 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Looks good, tests good and works really good - now there is only one CGI->new()
call! Aparently get_template_and_user(), which usually triggers the 1st
getlanguage() call is doing it properly with $cgi parameter included.

Not sure if cache clean in setlanguagecookie() is strictly necessary, but it's
not harming performance in any way, and this sub is used also in installer,
better to be on the safe side.

Koha::Cache::set_in_L1_cache_only() may need some kind of unit test, if it's
intended to stay there.

In t/Cache.t

    skip "Cache not enabled", 33
      unless ( $cache->is_cache_active() && defined $cache );

number of tests to skip is out of sync, but it was out of sync before this
patch as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:49:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:49:18 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-QdMonH6oRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What do you suggest?
Do you think bug 12704 should be reverted because it's not valid (matching
rules should be used instead)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:51:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:51:09 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-Uj0pz2jZCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16495


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16495
[Bug 16495] acq ordering from staged file laborious with dups
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:51:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:51:09 +0000
Subject: [Koha-bugs] [Bug 16495] acq ordering from staged file laborious
	with dups
In-Reply-To: <bug-16495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16495-70-SnJ07mtxIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16495

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12074
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074
[Bug 12074] Filter duplicates when adding a full batch from a staged file
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 13:52:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 11:52:35 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-NV1UOSRLcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd rather fix the first and have correct overdues sent, then having to sent
another batch of emails to "correct" - but that's probably a problem mostly for
libraries charging fines. 

Please note: This whole discussion is about the file for non-package setups. I
think the behaviour for packages is different anyway. As we are using packages
I am fine with any solution. We use debian/koha-common.cron.daily as changed in
this patch for several versions now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:05:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:05:27 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-1y86AveMCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:05:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:05:30 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-aqakV8sIZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51416&action=edit
Bug 16465: discharge - Add a title tag at the OPAC

Test plan:
Confirm that the opac-discharge.pl has now a title

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:05:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:05:34 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-aZcMZ9wglT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51417&action=edit
Bug 16465: Fix typo issues vs checkouts

Test plan:
Confirm the wording is correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:10:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:10:08 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-GTVWcVwgSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51415|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51418&action=edit
Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language

The goal of this patch is to avoid unecessary flush of the L1 cache on
creating a new CGI object each time C4::Languages::getlanguage is called
without a CGI object.

The new class Koha::Cache::Memory::Lite must be flushed by the CGI
constructor overide done in the psgi file. This new class will ease
caching of specific stuffs used by running script.

Test plan:
At the OPAC and the intranet interfaces:
Open 2 different browser session to simulate several users
- Clear the cookies of the browsers
- User 1 (U1) an User 2 (U2) should be set to the default language
  (depending on the browser settings)
- U1 chooses another language
- U2 refreshes and the language used must be the default one
- U2 chooses a third language
- U1 refreshes and must be still using the one he has choosen.

Try to use a language which is not defined:
Add &language=es-ES (if es-ES is not translated) to the url, you should
not see the Spanish interface.

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:10:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:10:47 +0000
Subject: [Koha-bugs] [Bug 16494] Remove the use of "onclick" from some
	patron pages
In-Reply-To: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16494-70-uZYC0nzXB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:10:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:10:49 +0000
Subject: [Koha-bugs] [Bug 16494] Remove the use of "onclick" from some
	patron pages
In-Reply-To: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16494-70-ra0EyDZePD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51419&action=edit
Bug 16494 - Remove the use of "onclick" from some patron pages

This patch removes the use of "onclick" attributes from some patron
pages.

To test, apply the patch and:

- In Patrons, perform any search which will return multiple results.
  Confirm that the "select all" and "clear all" links work as expected.
  Font Awesome icons have been added to these links.

  In the left-hand sidebar, change any of the filters and click the
  "Clear" button. The form (and your search results) should reset.

- Open the 'Set permissions' page for any patron. Checking any
  permission with sub-permissions should correctly expand the tree and
  select all sub-permissions. The reverse should also work.

  Also changed in this file: The "Inconsistency detected" alert has been
  reformatted to make it translatable.

- View the detail page for a patron with one or more restrictions.
  Clicking the "View restrictions" link at the top of the page should
  jump you to and activate the restrictions tab.

- View the 'Notices' tab for a patron who has been sent one or more
  notices. Click any notice title to expand the notice. Clicking the
  "resend" button should resend the notice.

- Create a new patron with the same first and last name as an existing
  patron. This should trigger a duplicate warning message. Click the
  "View existing record" link to trigger a pop-up window with a patron
  detail brief view.

  In this window an "email" class has been added to the primary and
  secondary email lines so that long email addresses don't overlap the
  second column of data.

  Confirm that clicking the "close" button in this window closes the
  window. The changes to staff-global.css are included in this patch to
  prevent the close button from having an incorrect color change on
  hover.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:12:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:12:14 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-Zb6ClHvzU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #22)
> Looks good, tests good and works really good - now there is only one
> CGI->new() call! Aparently get_template_and_user(), which usually triggers
> the 1st getlanguage() call is doing it properly with $cgi parameter included.
> 
> Not sure if cache clean in setlanguagecookie() is strictly necessary, but
> it's not harming performance in any way, and this sub is used also in
> installer, better to be on the safe side.

What I thought too, I did not manage to know if it was useful but preferred to
keep it.

> Koha::Cache::set_in_L1_cache_only() may need some kind of unit test, if it's
> intended to stay there.

Erk, of course it is not intended, I have amended the patch using
 git reset HEAD~1 Koha/Cache.pm
 git checkout Koha/Cache.pm
 git commit --amend
Nothing more

> In t/Cache.t
> 
>     skip "Cache not enabled", 33
>       unless ( $cache->is_cache_active() && defined $cache );
> 
> number of tests to skip is out of sync, but it was out of sync before this
> patch as well.

I will submit a patch for that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:14:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:14:12 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-zxiIESoznG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51420&action=edit
Bug 16088: Fix the number of tests to skip

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:16:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:16:18 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-zLLNzpdJWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> ---
> Hi Nick,
> Your problem should not be that hard to resolve.
> I think we should not rely on the fact that AF only includes the patron
> branch code. It is just a screen message field. And I am not sure if SIP2
> officially supports multiple AF fields btw.
> Could you use field AO that only contains the institution id? But not usable
> for another branch.
> Or - as workaround - add a prefix to the AF home branch part and capture
> only that part with a simple regex or so?

Yes, SIP2 can have multiple AF fields. The branchcode in AF field feature was
requested specifically by Overdrive to be able to track use by home library.
The AO does not transmit the patron home branch, it transmits the branch of the
user used to authenticate as for using SIP. It is not practical or correct to
send the patron branch on the AO field. This is definitely a regression and
needs to be fixed or we may have to revert this bug in master before the
release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:27:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:27:53 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-tbinDcA3ny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #56)
> Yes, SIP2 can have multiple AF fields. 
In that case that is the best route.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:38:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:38:05 +0000
Subject: [Koha-bugs] [Bug 16497] New: REST API: add routes to list libraries
Message-ID: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

            Bug ID: 16497
           Summary: REST API: add routes to list libraries
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: benjamin.rokseth at kul.oslo.kommune.no
        QA Contact: testopia at bugs.koha-community.org

Small enhancement to REST API to add the possibility to list libraries.

GET /api/v1/libraries              List all libraries and branchcodes
GET /api/v1/libraries/{branchcode} Get library description and branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:40:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:40:13 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-R1pXNwCi9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #56)
> This is
> definitely a regression and needs to be fixed or we may have to revert this
> bug in master before the release.

Note that I have seen more serious regressions than this where the word
"revert" is not used rightaway. Just saying.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:43:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:43:04 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-GkkgvdHiWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The problem I see here is that it's already in a stable release. So a revert is
 not as easy as just getting it out of master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:49:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:49:28 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-eZuGWMQ2t0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51421&action=edit
Bug 13871: [QA Follow-up] Fix small regression on AF with branchcode in Patron
Info request

If you enable send_patron_home_library_in_af in your sip account, you
want a separate AF field for the home branch.

Test plan:
Send a 63 (Patron Info) and verify that you have an extra AF.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:50:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:50:14 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-hXkuE2y61N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED

--- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #59)
> The problem I see here is that it's already in a stable release. So a revert
> is  not as easy as just getting it out of master.

It is a trivial fix. So why talk revert?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:50:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:50:29 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-gNXLbhK7YJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:50:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:50:46 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-YyfexSbCat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:51:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:51:01 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-ETgoa1tUmV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:51:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:51:35 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-fHLWnVAbWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
@RM: Handled as QA follow-up. Please check last patch and push that one only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:53:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:53:44 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-5zMGhvlJSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree - fixing it is better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 14:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 12:55:35 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-yg5k7sqeqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51421|0                           |1
        is obsolete|                            |

--- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51422&action=edit
Bug 13871: [QA Follow-up] Fix small regression on AF with branchcode in Patron
Info request

If you enable send_patron_home_library_in_af in your sip account, you
want a separate AF field for the home branch.

Test plan:
Send a 63 (Patron Info) and verify that you have an extra AF.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested Patron Status and Patron Info.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:04:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:04:27 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-HW1iSD2VNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> ---
Thanks Marcel! Follow-up has been pushed to master for 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:06:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:06:52 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-69ZKCTq9v8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Jonathan

1) Small qa fail
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
 FAIL   forbidden patterns
                forbidden pattern: tab char (line 66)

2) Bad: Can't change framework on edit, think that this code needs change

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt

line 495+            [% FOREACH frameworkcodeloo IN frameworkcodeloop %]

3) Test plan for third patch: don't get a warning, only a link to fast catalog
if FA is present and have right permissions.


All other parts of all test plans works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:09:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:09:31 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-NFE7DF2LZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #1)
> What do you suggest?
> Do you think bug 12704 should be reverted because it's not valid (matching
> rules should be used instead)?

Jonathan, is that the right bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:13:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:13:40 +0000
Subject: [Koha-bugs] [Bug 16498] New: Cannot process uploaded offline
	circulation file
Message-ID: <bug-16498-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16498

            Bug ID: 16498
           Summary: Cannot process uploaded offline circulation file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/offline_circ/process_koc.pl
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 51423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51423&action=edit
Screenshot showing background-job-progress.pl requests

I have created an offline circulation file via the Windows application
("Version=1.0    Generator=kocDesktop    GeneratorVersion=1.3" containing
checkouts. After uploading the file, both methods of processing the file fail. 

Choosing "Add to offline circulation queue" results in an error:

Can't use an undefined value as an ARRAY reference at
/offline_circ/enqueue_koc.pl line 146, <GEN36> line 7.

The error log has:

Use of uninitialized value $command in hash element at
/offline_circ/enqueue_koc.pl line 175, <GEN36> line 7.
Can't use an undefined value as an ARRAY reference at
/offline_circ/enqueue_koc.pl line 146, <GEN36> line 7.

If I start over and choose the "Apply directly" button instead, the job
progress never gets past 0%. Firebug shows a never-ending succession of queries
to background-job-progress.pl (see attached screenshot).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:19:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:19:40 +0000
Subject: [Koha-bugs] [Bug 11490] Deleting Batch Items
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-gjeDH1W1nG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:19:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:19:43 +0000
Subject: [Koha-bugs] [Bug 11490] Deleting Batch Items
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-vFFkySMBaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51424&action=edit
Bug 11490: Add prefs MaxItemsToProcessForBatchMod and
MaxItemsToDisplayForBatchDel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:19:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:19:47 +0000
Subject: [Koha-bugs] [Bug 11490] Deleting Batch Items
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-KJEf6EwEL5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51425&action=edit
Bug 11490: Split MaxItemsForBatch into 2 prefs to clarify things

Prior to this patch, a single pref (MaxItemsForBatch) was used to
restrict the use of the batch item modification and deletion.

On the batch modification tool, the pref is used to limit the number of
items a librarian is allowed to modify in a batch, but on the batch
deletion tool the pref is used to limit the number of items to display.

To clarify things, this patch split the pref into 2 new prefs:
MaxItemsToDisplayForBatchDel and MaxItemsToProcessForBatchMod.

Later we could add a MaxItemsToProcessForBatchDel if needed.
Note that this patch should not introduce any changes in the current behaviors.

Test plan:
0/ Do not execute the update DB entry
1/ Set a value != 1000 for MaxItemsForBatch
2/ Execute the update DB entry and confirm that the 2 new prefs are
initially set with the value of MaxItemsForBatch and that
MaxItemsForBatch has been deleted
3/ Set different values for these 2 prefs (2 and 3 for instance to ease
the next steps)
4/ Try to delete less than MaxItemsToDisplayForBatchDel items
=> You must see the items details
5/ Try to delete more than MaxItemsToDisplayForBatchDel items
=> You must not see the items details but are allowed to delete them
6/ Try to modify less than MaxItemsToProcessForBatchMod items
=> You must see the items details
7/ Try to modify more than MaxItemsToProcessForBatchMod items
=> You must be restricted and not allowed to process

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:21:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:21:20 +0000
Subject: [Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two
	new prefs
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-PeQn8idyfd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Deleting Batch Items        |MaxItemsForBatch should be
                   |                            |split into two new prefs
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:23:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:23:07 +0000
Subject: [Koha-bugs] [Bug 8132] batch delete tool deletes items with holds
	on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-zazgjqDrco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #14)
> What about merging the Batch item deletion tool with the Batch record
> deletion tool?
> We could have
> 
>  Record type
>     Bibliographic:
>     Authorities:
>     Items:

Does it make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:25:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:25:40 +0000
Subject: [Koha-bugs] [Bug 16498] Cannot process uploaded offline circulation
	file
In-Reply-To: <bug-16498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16498-70-iUYOTsRUJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16498

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Never mind, my .koc file got munged when I moved it from Windows to my VM.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:35:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:35:52 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-2hGPfhAQE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51387|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51426&action=edit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo

This was the "Get" subroutine for the framework, it can be easily
replaced with a call to the Koha::BiblioFrameworks->find method.
This patch also replaces some confusing wordings (framework vs frameworkcode).

Test plan:
On the circulation home page, you should see a "Fast cataloguing" link
if the FA framework exists.

Note that the admin/marctagstructure.pl has already been tested in the
previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:35:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:35:56 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-zlLZRB3iaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51427&action=edit
Bug 15801: minor fixes

- Fix a tab
- Fix a variable name in a template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:37:01 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-tNDKM4MLil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bernardo Gonzalez Kriegel from comment #15)
> Hi Jonathan

Hi Bernardo, Thanks for testing :)

> 1) Small qa fail
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>  FAIL   forbidden patterns
>                 forbidden pattern: tab char (line 66)

Fixed.

> 2) Bad: Can't change framework on edit, think that this code needs change
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
> 
> line 495+            [% FOREACH frameworkcodeloo IN frameworkcodeloop %]

Fixed as well.


> 3) Test plan for third patch: don't get a warning, only a link to fast
> catalog if FA is present and have right permissions.

I have updated the test plan, actually you should see a "Fast cataloguing" like
if the FA framework exists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:37:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:37:42 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-jmeC7rmreR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51414|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51428&action=edit
Bug 16473: Fix typo "an problem" vs "a problem"

Test plan:
Confirm the wording is correct

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:37:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:37:39 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-ee0GFY4AFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:38:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:38:24 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-hTIAMfyV8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Taking liberty to put this trivial patch directly in PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:39:29 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-T4dfI2AHT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #2)
> (In reply to Jonathan Druart from comment #1)
> > What do you suggest?
> > Do you think bug 12704 should be reverted because it's not valid (matching
> > rules should be used instead)?
> 
> Jonathan, is that the right bug?

Not at all! :)
It is bug 12074.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:43:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:43:49 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-Pz3FYhnQky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51420|0                           |1
        is obsolete|                            |

--- Comment #26 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 51429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51429&action=edit
Bug 16088: Fix the number of tests to skip

Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:48:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:48:22 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-BtYetMSbrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #27 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Yikes, finally it would be possible to benchmark koha under plack and get the
timings that actually make some sense ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:54:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:54:18 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-imYxsBNKq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:54:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:54:21 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-PQ2PSJ3dge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51327|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51430&action=edit
Bug 16428: Use the biblio framework to know if a field is mapped

The subroutine _build_default_values_for_mod_marc takes the
frameworkcode in parameter, but ModItemFromMarc did not pass it.
It uses it to know if a field is mapped or not to a Koha field
(C4::Koha::IsKohaFieldLinked).
Consequently the default framework ("") was always used.

This bug has been found working on bug 13074 and has been put on a
separate bug report to ease the backport.

Test plan:
Without this change, the tests added by bug 16428 won't pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:54:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:54:26 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-kYSuzMHLV4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51431&action=edit
Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in
_build_default_values_for_mod_marc

The routine calls GetMarcStructure and does not use its return value
after all.

Test plan:
Run t/db_dependent/Items.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:54:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:54:44 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-n7t0MREGwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:54:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:54:48 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-ReFwMGKurI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #27)
> Yikes, finally it would be possible to benchmark koha under plack and get
> the timings that actually make some sense ;)

Does that mean you have doubt about this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:59:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:59:39 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-GbGfXVJzYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51385|0                           |1
        is obsolete|                            |

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51432&action=edit
[SIGNED-OFF] Bug 15801: Koha::BiblioFrameworks - Remove
C4::Koha::GetFrameworksLoop

The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns
them ordered by the description (frameworktext). If a parameter is
passed, a selected flag is set. The selection of the options should be
done on the template side.
These 2 calls can be replaced with
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });

Test plan:
1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl)
You should see a dropdown list with the biblio frameworks. The framework
of the record should be selected by default
2/ Create a sql report using the biblio_framework parameter, something
like:
  SELECT COUNT(*) FROM biblio WHERE
frameworkcode=<<framework|biblio_framework>>
Save and execute the report.
You should get a dropdown list with the framework list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Both dropdowns Ok
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:59:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:59:51 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-E24szMyKfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51386|0                           |1
        is obsolete|                            |

--- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51433&action=edit
[SIGNED-OFF] Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks

C4::Koha::getframeworks returned a hashref of biblio frameworks.
It was mainly used to generate the dropdown list of frameworks.
The scripts modified in this patch did not necessary order the element
by description (frameworktext), the displays were not consistent from
one screen to another.
Using the same search method everywhere:
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
We will know always get the framework in the same order.

Test plan:
Following the different pages modified by this patch, and make sure the
frameworks are displayed correctly in the dropdown list:
1/ acqui/z3950_search.pl - Create an order from an external source.
2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field
3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select
another framework than the default one and click on the 'Search' button
4/ catalogue/MARCdetail.pl - On the MARC defail page, change the
framework you want to use to display the record
5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its
framework. When editing, the framework of the record should be selected
by default
6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click
on the "New record" button. You should see all the frameworks
7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first
step (select the merge reference), you should be allowed to select the
framework to use.
8/ tools/inventory.pl - On the inventory page, the "Item statuses" part
should be populated as before this patch
9/ tools/manage-marc-import.pl - Stage records for import. Before
importing them into the catalog, you should see the framework dropdown
list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works Ok.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 15:59:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 13:59:58 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-IRPQ7XM249@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51426|0                           |1
        is obsolete|                            |

--- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51434&action=edit
[SIGNED-OFF] Bug 15801: Koha::BiblioFrameworks - Remove
C4::Koha::getframeworkinfo

This was the "Get" subroutine for the framework, it can be easily
replaced with a call to the Koha::BiblioFrameworks->find method.
This patch also replaces some confusing wordings (framework vs frameworkcode).

Test plan:
On the circulation home page, you should see a "Fast cataloguing" link
if the FA framework exists.

Note that the admin/marctagstructure.pl has already been tested in the
previous patch.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Link pops Ok
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:00:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:00:07 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-j7ilfAcZTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51427|0                           |1
        is obsolete|                            |

--- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51435&action=edit
[SIGNED-OFF] Bug 15801: minor fixes

- Fix a tab
- Fix a variable name in a template

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

With all patches applied no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:00:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:00:20 +0000
Subject: [Koha-bugs] [Bug 15801] Move the framework related code to
 Koha::BiblioFramework[s] - part 2
In-Reply-To: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15801-70-CIKiHvNl1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:05:48 +0000
Subject: [Koha-bugs] [Bug 16499] New: circulation.pl logs warnings about Use
 of uninitialized value
Message-ID: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

            Bug ID: 16499
           Summary: circulation.pl logs warnings about Use of
                    uninitialized value
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14015

If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at
/home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at
/home/koha/src/circ/circulation.pl line 170.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015
[Bug 14015] Checkout: Fix software error if barcode '0' is given
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:05:48 +0000
Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0'
	is given
In-Reply-To: <bug-14015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14015-70-augdvJMYqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16499


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499
[Bug 16499] circulation.pl logs warnings about Use of uninitialized value
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:07:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:07:51 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-rXbkO9E7XU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:07:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:07:54 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-5lfkY6fCt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51436&action=edit
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl

If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at
/home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at
/home/koha/src/circ/circulation.pl line 170.

Test plan:
- Search for a patron and confirm the warnings are not displayed anymore
- Make sure this patch does not introduce regression on bug 14015

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:10:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:10:15 +0000
Subject: [Koha-bugs] [Bug 16500] New: Replace two warns in TestBuilder.t
 with warning_like
Message-ID: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

            Bug ID: 16500
           Summary: Replace two warns in TestBuilder.t with warning_like
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:12:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:12:47 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-gEbrGLohuK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Replace two warns in        |Catch two warns in
                   |TestBuilder.t with          |TestBuilder.t with
                   |warning_like                |warning_like

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:15:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:15:37 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-d2TdLInJPD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #29 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #28)
> (In reply to Jacek Ablewicz from comment #27)
> > Yikes, finally it would be possible to benchmark koha under plack and get
> > the timings that actually make some sense ;)
> 
> Does that mean you have doubt about this patch?

No, not at all. I think this patch is pretty essential for all plack setups.
What I meant was that some earlier benchmarks I did with plack (catalogue
searches in particular) were 50%-100% slower in comparision with CGI, for no
apparent reasons, and with this patch I expect this to be fixed.

BTW, is 3.22 also affected by this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:16:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:16:03 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-PDJ9iiuoVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51437&action=edit
Bug 16500: Catch two warns in TestBuilder.t with warning_like

When testing a wrong case in TestBuilder.t, two warns show up.
We can catch them with warning_like.

Test plan:
Run t/db_dependent/TestBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:16:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:16:01 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-LwvOpxoBO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:16:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:16:35 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-iGF1OacopX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:19:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:19:57 +0000
Subject: [Koha-bugs] [Bug 16501] New: Remove some unneeded warns in Upload.t
Message-ID: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

            Bug ID: 16501
           Summary: Remove some unneeded warns in Upload.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:20:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:20:41 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-YuHPocpXaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:26:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:26:00 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-MeaglupJEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:26:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:26:03 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-bDSmLfkCMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51438&action=edit
Bug 16501: Remove some unneeded warns in Upload.t

At some point I saw some gain in warning about a missing config line.
But these warns are actually not needed here.
Removing them here.

Test plan:
Run t/db_dependent/Upload.t while having upload_path in your koha-conf and
also without it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:26:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:26:18 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-hXKcnA1Lna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:26:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:26:56 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-HxqEEpH5t9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:26:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:26:58 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-oz2O239AdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51439&action=edit
Bug 16493 - acq matching on title and author

When you order from a staged file you're getting duplicate warnings that
are inaccurate.  For example, when you order a file of 50 DVDs for
example and they don't have ISBNs they're matching on the books. And
then you have to order them one by one.

This patch replaces the use of FindDuplicates with Koha's match point
system. This means you can select from the same match points defined
and used in the batch record importer, or you can opt to skip matching
altogether!

Test Plan:
1) Import a record with a title, isbn and author.
2) Delete the from the record and stage it again
3) Attempt to add it to a basket via the staged record
4) You should note the gives you the "No records imported" message
5) Apply this patch
6) Create a matcher for ISBN
7) Create a matcher for Author/Title
8) Attempt to add the record to your basket using the ISBN matcher
8) Koha should find no match and import the record to the basket
9) Stage the record again
10) Attempt to add the record to your basket using the Title/Author matcher
11) You should recieve the "No records imported" message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:33:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:33:28 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-rb6W2EMnSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
I confirm that the "Collection" column display data from
biblioitems.collectiontitle. I don't know if it's specific to UNIMARC users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:34:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:34:29 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-MtuJO7FCPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:34:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:34:31 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-VZQZSkLxHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51436|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51440&action=edit
[SIGNED-OFF] Bug 16499: Remove "Use of uninitialized value" warnings in
circulation.pl

If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at
/home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at
/home/koha/src/circ/circulation.pl line 170.

Test plan:
- Search for a patron and confirm the warnings are not displayed anymore
- Make sure this patch does not introduce regression on bug 14015

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:39:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:39:54 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-lT2RCa1Snc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #29)
> BTW, is 3.22 also affected by this?

Yes but to a lesser extent, bug 16044 has not been backported (yet?): in 3.22,
CGI->new is overridden to call clear_syspref_L1_cache.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:43:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:43:18 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-SkHvh0YbZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Julian Maurice from comment #3)
> I don't know if it's specific to UNIMARC users.

It's all NULL in our MARC21 database, for what it's worth.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:44:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:44:38 +0000
Subject: [Koha-bugs] [Bug 16502] New: Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
Message-ID: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

            Bug ID: 16502
           Summary: Table
                    koha_plugin_com_bywatersolutions_kitchensink_mytable
                    not always dropped after running Plugin.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Happened to notice that running this test (t/db_dependent/Plugin.t) twice may
not have the expected result. Sometimes(?) I need to manually drop the table.
Note that quickly adding a transaction does not resolve it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:45:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:45:33 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13961-70-I9f1LyZWfu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

--- Comment #16 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
Are we sure that <<items.fines>> is working as it should? We are on 3.20.01 and
we recently changed ODUE to use <item></item> allowing nice layout rather than
the horridly formatted <<items.content>> variable. But often (not always) the
fine amount wasn?t pulling through. Also to our horror, after the change
sometimes only the first overdue would be listed, and not the full list. The
consensus here is that the <<items.fine>> tag can cause problems when
generating notices and we have reverted to <<items.content>>. This has resolved
issues with notices being truncated after the first item. (We can find no
pattern for why some of these fail but we suspect it is related to the
<<items.fine>> variable.)
Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:45:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:45:44 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-GWdp7eHBn3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51439|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 51441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51441&action=edit
Bug 16493 - acq matching on title and author

When you order from a staged file you're getting duplicate warnings that
are inaccurate.  For example, when you order a file of 50 DVDs for
example and they don't have ISBNs they're matching on the books. And
then you have to order them one by one.

This patch replaces the use of FindDuplicates with Koha's match point
system. This means you can select from the same match points defined
and used in the batch record importer, or you can opt to skip matching
altogether!

Test Plan:
1) Import a record with a title, isbn and author.
2) Delete the from the record and stage it again
3) Attempt to add it to a basket via the staged record
4) You should note the gives you the "No records imported" message
5) Apply this patch
6) Create a matcher for ISBN
7) Create a matcher for Author/Title
8) Attempt to add the record to your basket using the ISBN matcher
8) Koha should find no match and import the record to the basket
9) Stage the record again
10) Attempt to add the record to your basket using the Title/Author matcher
11) You should recieve the "No records imported" message.

Signed-off-by: Barbara Fondren <bfondren at roundrocktexas.gov>

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:45:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:45:51 +0000
Subject: [Koha-bugs] [Bug 16485] collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-AfruSN6nZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

--- Comment #5 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Also In our MARC21 system, ALL ~1m items have NULL in
biblioitems.collectiontitle

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:45:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:45:56 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-qrtSPT1pHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:46:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:46:45 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-guNpUdFopa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicole at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:46:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:46:58 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-uPi8DwErfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |16.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:57:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:57:03 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-tuhnbgCn45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:57:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:57:06 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-hIrnFc4S5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51396|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51442&action=edit
[SIGNED-OFF] Bug 16382: Update German web installer sample files for 16.05

Easy this time, only sample notices have been changed:
- Changed discharge to match the English sample notice.
- Translated new PASSWORD_RESET e-mail

To test:
- Start with an empty database
- Install de-DE
- Run the web installer in de-DE/German
- Verify all files, especially sample notices, load
  without any problems.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested removing all from letter table and loading file.
File loads Ok, notices look good.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:58:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:58:04 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-zuk0WKLY8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51443&action=edit
Bug 16461 - Add branch and barcode in fine description for overdue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 16:58:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 14:58:36 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-tMc1fOHilR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:17:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:17:44 +0000
Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has
	warnings
In-Reply-To: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15086-70-uRXZ7D565J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:17:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:17:48 +0000
Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has
	warnings
In-Reply-To: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15086-70-cCw2fpZ5Kj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46233|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51444&action=edit
[SIGNED-OFF] Bug 15086: Creators layout and template sql has warnings

When doing a hacked install off the master branch:
use ... {koha database name}
truncate creator_layouts;
truncate creator_templates;
truncate printers_profiles;
source installer/data/mysql/... {name of a sample_labels type file}
Warnings are generated, which may not be visible in the UI.

Most of the warnings were triggered by:
-/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */;
-/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */;
http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha

In the Russian, the layout_name was truncated, because the layout_name was only
20. An atomic update sql and kohastructure.sql update were provided to widen it
to 25.
http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated

Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the
structure was made the same as the other files.

See comment #1 for the test plan.

NOTE: pl-PL is likely very out of date, but is not affected in this regard.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works, no more warnings
mysql> show warnings;
Empty set (0.01 sec)

No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:18:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:18:44 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-NNep8PTVSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51389|0                           |1
        is obsolete|                            |

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51445&action=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
    PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:18:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:18:51 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-0fepSbnsxS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51446&action=edit
Bug 3534 - QA Followup - use floating save

I am not sure if this is desired, it makes sense for consistency but
floats in a wierd place for a short form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:32:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:32:29 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-s03LmHJg1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #31 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #30)
> (In reply to Jacek Ablewicz from comment #29)
> > BTW, is 3.22 also affected by this?
> 
> Yes but to a lesser extent, bug 16044 has not been backported (yet?): in
> 3.22, CGI->new is overridden to call clear_syspref_L1_cache.

AFAIRC feching a syspref from memcached takes 80-120 usec on average, in 3.22
there are ~1500 ->preference() calls per catalog search (for 20 results per
page, ~3000 for 50 results per page). There is still some (hard to say how
much) syspref caching going on.. Worst case scenario: 1500 * 0.0001 = 150 msec
penalty.
Unless someone is running 3.22 under plack without memcached (worst case: 1500
* 0.0014 = 2.1 seconds) - probably not such a big deal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:33:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:33:56 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-JEmLXsk814@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #32 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Question about naming/design; this thing you're making has less in common with
Koha::Cache and more in common with a per-request C4::Context. Might it make
more sense to tie it to the latter?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:38:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:38:36 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-aYNJYeMpdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #66 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 16479 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 17:38:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 15:38:36 +0000
Subject: [Koha-bugs] [Bug 16479] SIP should send separate AF message for
 send_patron_home_library_in_af
In-Reply-To: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16479-70-rf59BofIZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 13871 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 18:18:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 16:18:15 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13961-70-WFT9lI4kLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, this bug is about a different feature, so it would be good to open a
separate bug report, maybe with a 'see also' link to this one if you want to.

We have been using the items.fine variable without any problems for quite some
time now - although not in 3.20, but in 3.18 and 3.22.

One reson for the fine not printing can be the sequence the cronjobs are being
run. fines.pl should be run before overdue_notices.pl (currently not the
default, see bug 11144). Or that you haven't defined a proper ISO code for your
active currency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 18:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 16:18:58 +0000
Subject: [Koha-bugs] [Bug 3534] Patron quick add form
In-Reply-To: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3534-70-LTAXS8fZnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #36 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marc V?ron from comment #33)
> I re-tested, it seems that the "Save" button in the quick add form no longer
> works.
Yeah, the quick add save 'clicks' the full form save button, fixed the selector
and should work again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 18:19:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 16:19:08 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13961-70-EticPwg6IY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Btw: you can use <item></item> and leave the <<items.fine>> out too!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 18:53:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 16:53:23 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-seKIanoBan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 18:53:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 16:53:26 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-OAKi46ObnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51413|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51447&action=edit
[SIGNED-OFF] Bug 16458: Update library when a guarantor is set

If you edit a patron from the Edit link of the patron information block
(step 1 of the memberentry script), the branchcode is not displayed. If
you set a guarantor to a child from this form, a JavaScript error will
be raised:
  JavaScript error form.branchcode is undefined

It happens because there is the branchcode is not displayed and there is
no element with a branchcode name.

To avoid this issue, a branchcode hidden input is added to the form and
it will be updated when a guarantor is selected (same behavior as when
you edit a patron using the complete form).

Test plan:
Edit a patron using the Edit link of the patron info block (not the Edit
button in the toolbar)
Set a guarantor
=> Notice that the branchcode of the patron has been updated with the
branchcode of the guarantor

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 19:06:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 17:06:33 +0000
Subject: [Koha-bugs] [Bug 16394] Fix formatting of review.tt
In-Reply-To: <bug-16394-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16394-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16394-70-Zhld17HsQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 21:03:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 19:03:48 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-xoBedQWuvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 21:03:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 19:03:51 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-IxXMIECvOF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51438|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51448&action=edit
Bug 16501: Remove some unneeded warns in Upload.t

At some point I saw some gain in warning about a missing config line.
But these warns are actually not needed here.
Removing them here.

Test plan:
Run t/db_dependent/Upload.t while having upload_path in your koha-conf and
also without it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 21:31:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 19:31:18 +0000
Subject: [Koha-bugs] [Bug 16503] New: Label creator: grouping fields with
 quotes does not work in layout creator
Message-ID: <bug-16503-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16503

            Bug ID: 16503
           Summary: Label creator: grouping fields with quotes does not
                    work in layout creator
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The description for "Data field" under label-edit-layout.pl shows

"Enter a comma separated list of fields to print. You may include any Koha
field or MARC subfield.

See online help for advanced options

ex: barcode, itemcallnumber, title, "050a 050b", 300a

Fields homebranch_description, holdingbranch_description, ccode_description,
location_description and permanent_location_description show description
instead of code."

This seems to indicate that grouping fields using quotes, non-comma separated,
*should* work:

Given an item with the following data:

         title: Juggling for the complete klutz /
        author: Cassidy, John.
itemcallnumber: JNF 793.8 Cas

Using the data fields 

"title author", itemcallnumber

Should yield a CSV export this:

"Juggling for the complete klutz / Cassidy, John.","JNF 793.8 Cas"

Instead I get this:

,"JNF 793.8 Cas"


To replicate:

1/ Create a record using the title, author and itemcallnumber above.
2/ Go to tools > label creator
3/ Add a batch containing the created item
4/ Add a new layout. Click the list fields radio button, and add the fields
title, author, itemcallnumber
5/ Export the batch as CSV using the new layout. The resulting file will look
like this:

   "Juggling for the complete klutz /","Cassidy, John.","JNF 793.8 Cas"

6/ Edit the layout, change the field list to

    "title author", itemcallnumber

7/ Export the batch again, the new CSV file will read

    ,"JNF 793.8 Cas"

The bug was replicated under version 3.23.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 11 22:17:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 20:17:50 +0000
Subject: [Koha-bugs] [Bug 16503] Label creator: grouping fields with quotes
 does not work in layout creator
In-Reply-To: <bug-16503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16503-70-74bOolSP6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16503

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #1 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Barton Chittenden from comment #0)
> The description for "Data field" under label-edit-layout.pl shows
> 
> "Enter a comma separated list of fields to print. You may include any Koha
> field or MARC subfield.
> 
> See online help for advanced options
> 
> ex: barcode, itemcallnumber, title, "050a 050b", 300a
> 
> Fields homebranch_description, holdingbranch_description, ccode_description,
> location_description and permanent_location_description show description
> instead of code."
> 
> This seems to indicate that grouping fields using quotes, non-comma
> separated, *should* work:

This is a "vestigial example." The feature itself never quite made it in. A
quick look over the code shows that there does not appear to be any code to
handle this feature. It is described in the formal documentation as
"concatenating and keeping on a single line."

If one were to write code to handle this, it would probably best go here:
http://tinyurl.com/j9o4au3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 00:13:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 22:13:47 +0000
Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are
 not saved when invisible
In-Reply-To: <bug-15163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15163-70-1h4gaU3gus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16504

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 00:13:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 22:13:47 +0000
Subject: [Koha-bugs] [Bug 16504] New: All borrower attribute values for a
 given code deleted if that attribute has branch limits
Message-ID: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

            Bug ID: 16504
           Summary: All borrower attribute values for a given code deleted
                    if that attribute has branch limits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jweaver at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com,
                    jonathan.druart at bugs.koha-community.org,
                    kyle.m.hall at gmail.com

Bug 15163 introduced a regression for branch-limited patron attributes; when
modifying a patron attribute with branch limits, all of the values for that
attribute for every patron will be deleted due to a predecence mistake:

            WHERE b_branchcode = ? OR b_branchcode IS NULL
                AND borrowernumber = ?

is parsed as:

            WHERE b_branchcode = ? OR (b_branchcode IS NULL
                AND borrowernumber = ?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 00:55:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 May 2016 22:55:06 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-pR03cqYwzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 02:18:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 00:18:17 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-H7tcYAOcVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Craig Dean <craig at dean.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |craig at dean.net.nz

--- Comment #15 from Craig Dean <craig at dean.net.nz> ---
I have a customer affected by this bug and thus can't import any new users.
Looking at the previous releases it seems that 3.22.7 won't be out until closer
to the end of the month. This is not really an acceptable wait to be able to
provision new users.

1. Is there any chance that the 3.22.7 will be released sooner?
2. Is there anything I can do to import this patch now, without breaking future
updates. Given then I am a Systems Administrator and not a developer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 04:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 02:36:58 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-Sfhe8JtaHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #10 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51449&action=edit
Toolbar covers drop down menu

I'm getting this problem where the syspref toolbar covers the drop down menu.

Agreed that it would be nice to have some consistency across the buttons.
Having just 'Save' and 'Cancel' in the toolbar alone doesn't bother me too much
imo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:25:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:25:07 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-ub7hHYbcLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:25:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:25:10 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-54b5uU1HBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50990|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51450&action=edit
Bug 16388: Move option to download report into reports toolbar

To test:

1) Create a new SQL report or edit a report
2) Ensure that the download option does NOT show in the toolbar
3) Save and run the report
4) Confirm that download option DOES show in toolbar as a dropdown with the 3
options (csv, tab and ods)
5) Confirm that downloading all 3 file types works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:42:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:42:58 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-CZHUcbeau7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:43:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:43:01 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-dOQlpA07gk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51451&action=edit
Bug 12402: Show patron category on pending patron modifications

To test:
1) Go to OPAC and make a modification to user
2) Go to Staff Client and go to pending patron modifications
3) Notice that we have the user's surname, first name, branch and cardnumber
4) Apply patch and refresh page
5) Notice that patron category now shows after user's name

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:43:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:43:16 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-FzdKe6aWbE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |
                 CC|                            |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:49:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:49:26 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-HQgPN5xFGN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:49:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:49:29 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-Ch2W9LgiiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51452&action=edit
Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'

To test:
1) Go to the tools home page. Confirm it says 'Inventory' instead of
'Inventory/stocktaking'
2) Click Inventory. Confirm heading now says 'Inventory' instead of
'Inventory/stocktaking'
3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in
the tools menu along the left of the page
4) Click Help in top right corner. Confirm help heading now says 'Inventory'
instead of 'Inventory/stocktaking'

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:49:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:49:39 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-AtdYkS1XbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com
                 CC|                            |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 06:56:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 04:56:22 +0000
Subject: [Koha-bugs] [Bug 16371] Quote of the Day (QOTD) - Display in
 different interfaces
In-Reply-To: <bug-16371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16371-70-aP0kZuf31r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
No patch has been attached!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 07:11:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 05:11:25 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-EBdRaFMoyt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If you are importing new borrowers it will will help to add a userid column
with some unique key to your import file - for example the cardnumber or
something similar. That will let you import the data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 11:27:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 09:27:23 +0000
Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new
 style (see also 10480)
In-Reply-To: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13438-70-0ZoxPkZOlh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51453&action=edit
Bug 13438: Fix report function in normarc_field_008 js

The report function did not deal well with undefined fields and
did not respect the length of all elements.

NOTE: This is a quick fix for something that is currently broken.
A next (larger) step would be to bring it back to the approach in
the marc21 counterpart.

Test plan:
Make sure that normarc_field_008.pl is connected to your field 008.
Click tag editor for 008, save some values and go back to tag editor.
Test different material types in the tag editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 11:27:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 09:27:53 +0000
Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new
 style (see also 10480)
In-Reply-To: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13438-70-JFg3McJPQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10997

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 11:27:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 09:27:53 +0000
Subject: [Koha-bugs] [Bug 10997] Modernize value_builders for NORMARC
In-Reply-To: <bug-10997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10997-70-Xkcj90S3Gj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10997

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13438

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 11:31:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 09:31:49 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-1WdQ1X2x80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 11:32:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 09:32:24 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-K615vTASyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #1 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 51454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51454&action=edit
Bug 16497 - REST API: add routes to list libraries

Simple routes to list all or get one Library
GET /api/v1/libraries              - List all libraries
GET /api/v1/libraries/{branchcode} - Get one Library

Test plan:
  - apply patch
  - run tests: t/db_dependent/api/v1/libraries.t
  - test API with some API tool or simple curl

e.g.:
curl http://host:port/api/v1/libraries
curl http://host:port/api/v1/libraries/cpl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 13:06:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 11:06:54 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-2YET5TEkM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

--- Comment #2 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Thank you Alex and Sophie, this would indeed come very handy to our Koha
installation.

However, in the long term, (especially if this is to be used the whole
community), I think it would be far better if separate columns were created in
the accountlines table to hold (at least) the branchcode and/or the item
barcode[1]. 

In the same context, an ideal situation would be if branchcode/barcode would be
displayed in separate columns in the fines table (and not concatenated in the
description).
This way description text would not be unnecessarily long and would not include
hardcoded "Branch" and "Barcode" strings (which instead would be shown as
translatable table headers in the fines table).

Just as food for thought :)

[1] if you don't want to keep barcodes both in items and accountlines table
(also useful if barcode was changed in the meantime), it could be dynamically
read during fines display (using itemnumber as key)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 13:38:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 11:38:40 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-2iphtuWQIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

--- Comment #3 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Another advantage of the 'separate columns for Branch/Barcode in fines'
approach would be that instead of branch CODE, the branch NAME could be
displayed in the separate "Branch" column (as it happens with other
item-related tables) which is more clear to staff librarians.

Of course, similarly due date could be a separate column in the fines table!

So to wrap the whole idea up: My proposal for the long run would be something
like:

Fines & charges | Description | Barcode | Due Date | Branch | Payment note |
Account type | Notify id | Level | Amount | Amount outstanding

(The table seems to hold too much information to fit into the screen, but
description is no longer required to be that long!)


Having said that, the disadvantage of this approach is that not ALL fines are
related to items, in which case Barcode and Due Date columns will be empty. If
this is acceptable and you're willing to make the change in the database schema
of the accountlines table, I think it would be fairly easy to implement and
would worth the time and effort...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 13:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 11:55:35 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-KTQReLAHFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 13:55:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 11:55:38 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-Rks3rCDct1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51451|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51455&action=edit
[SIGNED-OFF] Bug 12402: Show patron category on pending patron modifications

To test:
1) Go to OPAC and make a modification to user
2) Go to Staff Client and go to pending patron modifications
3) Notice that we have the user's surname, first name, branch and
   cardnumber
4) Apply patch and refresh page
5) Notice that patron category now shows after user's name

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 14:04:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 12:04:53 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-afney21TPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51450|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51456&action=edit
[SIGNED-OFF] Bug 16388: Move option to download report into reports toolbar

To test:

1) Create a new SQL report or edit a report
2) Ensure that the download option does NOT show in the toolbar
3) Save and run the report
4) Confirm that download option DOES show in toolbar as a dropdown with
   the 3 options (csv, tab and ods)
5) Confirm that downloading all 3 file types works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 14:08:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 12:08:38 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-ighFE86CE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This looks great, but it occurred to me to look for other forms of
"stocktaking." I see some instances of "inventory (stocktaking)":

/includes/permissions.inc:
/modules/help/members/member-flags.tt:
/modules/tools/tools-home.tt:

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 15:20:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 13:20:16 +0000
Subject: [Koha-bugs] [Bug 16505] New: rebuild_zebra.pl skips updates if -x
	is passed
Message-ID: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

            Bug ID: 16505
           Summary: rebuild_zebra.pl skips updates if -x is passed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 15:20:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 13:20:29 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-mbbxdfaHkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 15:21:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 13:21:33 +0000
Subject: [Koha-bugs] [Bug 16506] New: rebuild_zebra.pl still using USMARC as
	default
Message-ID: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

            Bug ID: 16506
           Summary: rebuild_zebra.pl still using USMARC as default
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The current rebuild_zebra.pl still uses usmarc as serialization format.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 15:21:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 13:21:55 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-0RtlupJ3v2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 15:32:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 13:32:16 +0000
Subject: [Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be
 based on tax included values
In-Reply-To: <bug-13324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13324-70-Z4aIpDM4DM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om
             Status|BLOCKED                     |Signed Off

--- Comment #13 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> ---
bz 13321 rebased, so status resetted/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 15:38:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 13:38:44 +0000
Subject: [Koha-bugs] [Bug 16507] New: show play media tab first
Message-ID: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

            Bug ID: 16507
           Summary: show play media tab first
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51457&action=edit
opac view

It might be nice if there are no holdings and there is a play media tab to show
that tab first. For example I'm cataloging streaming media so I don't need
items, but the video can be viewed right in the OPAC so why not show that tab
first?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 17:04:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 15:04:18 +0000
Subject: [Koha-bugs] [Bug 16508] New: User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
Message-ID: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

            Bug ID: 16508
           Summary: User permission "parameters_remaining_permissions
                    Remaining system parameters permissions" does not
                    allow saving systempreferences.
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

A staff borrower with catalogue and "parameters_remaining_permissions Remaining
system parameters permissions" cannot save sysprefs.

To recreate:

1/ Create a staff user.
2/ Go to details, select more->set permissions.
3/ Set catalogue, Manage Koha system settings (Administration panel), manage
circulation rules, and Remaining system parameters permissions.
4/ Log in as the new staff user, go to administration > system preferences.
Change a syspref and save it... it will save correctly.
5/ Log back in as superlibrarian
6/ On the 'set permissions' screen, un-check 'manage circulation rules' and
save.
7/ Log back in to the new staff user, and try to change the same
systemprefrence and save.

You will see the following message:

Error; your data might not have been saved
You need to log in again, your session has timed out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 17:12:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 15:12:53 +0000
Subject: [Koha-bugs] [Bug 16508] User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16508-70-0EvAH4q9To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 17:44:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 15:44:55 +0000
Subject: [Koha-bugs] [Bug 14941] Subfield defaults: Add information about
 substitutable values
In-Reply-To: <bug-14941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14941-70-O0FlLR7h2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
I had this documented and removed it because it didn't seem to work can you
confirm that it works now - I know that 'user' didn't work last time I tried
it.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 17:52:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 15:52:17 +0000
Subject: [Koha-bugs] [Bug 14251] style discharge letter
In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14251-70-fTy9weTxtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
I did not - good to know - but I'm not sure that everything can be done with
CSS - can it?

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 17:54:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 15:54:35 +0000
Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table
In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7021-70-JX8yCuY1wQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

--- Comment #27 from Nicole C. Engard <nengard at gmail.com> ---
Checking in here again ... any updates on a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:07:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:07:59 +0000
Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include
	deleted items
In-Reply-To: <bug-8483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8483-70-xxTNHp4qvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #52 from Nicole C. Engard <nengard at gmail.com> ---
Checking in here. Can anyone on the QA team help Kyle with his question?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:39:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:39:15 +0000
Subject: [Koha-bugs] [Bug 16509] New: Koha::Logger dies when log4perl.conf
 has FileAppender files with different permissions,
 also compatibility with logrotate
Message-ID: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

            Bug ID: 16509
           Summary: Koha::Logger dies when log4perl.conf has FileAppender
                    files with different permissions, also compatibility
                    with logrotate
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org

We define all the logging configurations for various interfaces in
log4perl.conf.
Interfaces log to files, and every interface can run as a different user.
Every time you execute a Perl program that uses Koha::Logger and Log::Log4perl,
Log::Log4perl tries to open all the filehandles in the log4perl.conf.

Since different interface logs should be owned by different users, this crashes
the system.

Can't sysopen /home/koha/koha-dev/var/log/intranet.log (Permission denied) at
/usr/local/share/perl/5.18.2/Log/Log4perl/Appender/File.pm line 120.


This patch introduces lazy-loading parameters to the FileAppenders, so they
open only the files they need. Koha::Logger makes sure they always use the
correct log file for the interface (opac, intranet, commandline, sip, restapi,
...).
log4perl.appender.CLI.syswrite=true
log4perl.appender.*.create_at_logtime=true



Also while working on this bug identified as a target of opportunity some
useful extra parameters for the appenders.


log4perl.appender.*.syswrite=true

This should solve concurrency issues under multithreaded Perl-apps such as what
Mojolicious should be ran as.


log4perl.appender.*.recreate=true

This polls the filesystem path to the logfile for changes. Eg. if logrotate of
the admin might move the logfile for storage purposes, Log4perl can recreate
the missing file, instead of writing to the moved file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:51:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:51:21 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-n0Xjxq1XkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Koha::Logger dies when      |Koha::Logger dies when
                   |log4perl.conf has           |log4perl.conf has
                   |FileAppender files with     |FileAppender files with
                   |different permissions, also |different owners, also
                   |compatibility with          |compatibility with
                   |logrotate                   |logrotate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:51:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:51:28 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-04RlP4ZFFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:51:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:51:41 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-gfivyDdo6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167
[Bug 14167] Add Koha::Logger based on Log4perl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:51:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:51:41 +0000
Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
In-Reply-To: <bug-14167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14167-70-VDINlRFVtm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509
[Bug 16509] Koha::Logger dies when log4perl.conf has FileAppender files with
different owners, also compatibility with logrotate
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:58:20 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-4gD4deLsO0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 51458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51458&action=edit
Bug-16509-Koha-Logger-dies-when-log4perl.conf-has-Fi.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 18:58:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 16:58:38 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-COd0eDkZdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From kamalbd627 at gmail.com  Thu May 12 17:10:48 2016
From: kamalbd627 at gmail.com (Kamal Hossain)
Date: Thu, 12 May 2016 21:10:48 +0600
Subject: [Koha-bugs] [Bug 16508] New: User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <CAM-x=kZhJB7Wt34EvgccjTNtnNjiu0ALkS6cK6mRjxxn8Y+Wmw@mail.gmail.com>

Hi All,

Thank you very much for the update.

Regards,
Kamal


On Thu, May 12, 2016 at 9:04 PM, <bugzilla-daemon at bugs.koha-community.org>
wrote:

> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508
>
>             Bug ID: 16508
>            Summary: User permission "parameters_remaining_permissions
>                     Remaining system parameters permissions" does not
>                     allow saving systempreferences.
>  Change sponsored?: ---
>            Product: Koha
>            Version: 3.22
>           Hardware: All
>                 OS: All
>             Status: NEW
>           Severity: enhancement
>           Priority: P5 - low
>          Component: Patrons
>           Assignee: koha-bugs at lists.koha-community.org
>           Reporter: barton at bywatersolutions.com
>         QA Contact: testopia at bugs.koha-community.org
>                 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
>
> A staff borrower with catalogue and "parameters_remaining_permissions
> Remaining
> system parameters permissions" cannot save sysprefs.
>
> To recreate:
>
> 1/ Create a staff user.
> 2/ Go to details, select more->set permissions.
> 3/ Set catalogue, Manage Koha system settings (Administration panel),
> manage
> circulation rules, and Remaining system parameters permissions.
> 4/ Log in as the new staff user, go to administration > system preferences.
> Change a syspref and save it... it will save correctly.
> 5/ Log back in as superlibrarian
> 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and
> save.
> 7/ Log back in to the new staff user, and try to change the same
> systemprefrence and save.
>
> You will see the following message:
>
> Error; your data might not have been saved
> You need to log in again, your session has timed out.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> You are watching all bug changes.
> _______________________________________________
> Koha-bugs mailing list
> Koha-bugs at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-bugs/attachments/20160512/e32cb71a/attachment-0001.html>

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 19:37:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 17:37:21 +0000
Subject: [Koha-bugs] [Bug 14251] style discharge letter
In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14251-70-keL3emnI4f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It depends on what you want to do - did you try to add the logo?
You could either try adding it in the HTML of the notice or with CSS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 23:25:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 21:25:11 +0000
Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch?
In-Reply-To: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7441-70-xwIf3p7pE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #70 from Nick Clemens <nick at bywatersolutions.com> ---
Still valid in current master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 23:41:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 21:41:06 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-2ktUTfGYTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 12 23:41:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 21:41:08 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-pv49kViPJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51452|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51459&action=edit
Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'

To test:
1) Go to the tools home page. Confirm it says 'Inventory' instead of
'Inventory/stocktaking' in heading and in description
2) Click Inventory. Confirm heading now says 'Inventory' instead of
'Inventory/stocktaking'
3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in
the tools menu along the left of the page
4) Click Help in top right corner. Confirm help heading now says 'Inventory'
instead of 'Inventory/stocktaking'
5) Go to user account page, go to Set Permissions
6) Expand Tools option and confirm it says 'inventory' instead of 'inventory
(stocktaking)'

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:04:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:04:33 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-rJ49sI7hS6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Pushed for inclusion in 16.05, to be released in May 2015. Thanks for your
work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:08:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:08:51 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-yD70XwmFdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #7 from Jesse Weaver <jweaver at bywatersolutions.com> ---
I have some qualms about pushing this... there are a very significant number of
places in Koha that use the default framework's mappings (enough to make it a
de-facto standard). See the results of a $ git grep TransformMarcToKoha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:11:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:11:33 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-TMjiMoqalO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #7 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Pushed for inclusion in 16.05, to be released in May 2015. Thanks for your
work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:15:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:15:56 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-iZGRKxGqCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

--- Comment #5 from Jesse Weaver <jweaver at bywatersolutions.com> ---
May 2016, rather...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:16:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:16:05 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-QlQzxX566f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

--- Comment #8 from Jesse Weaver <jweaver at bywatersolutions.com> ---
May 2016, rather...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:17:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:17:41 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-wjvU5LGEHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Pushed for inclusion in 16.05, to be released in May 2016. Thanks for your
work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:21:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:21:35 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves on intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-GuxIoxK01r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Pushed for inclusion in 16.05, to be released in May 2016. Thanks for your
work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 00:22:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 22:22:47 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-rVWP6PZ0Lk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Pushed for inclusion in 16.05, to be released in May 2016. Thanks for your
work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:10:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:10:37 +0000
Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password
	comparison
In-Reply-To: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6979-70-jFOwUBC7Mr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

Manuel Flores <manuel.flores.villatoro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manuel.flores.villatoro at gma
                   |                            |il.com

--- Comment #15 from Manuel Flores <manuel.flores.villatoro at gmail.com> ---
We had the same problem authenticating LDAP with KOHA 3.22 in Debian Jessie, we
ran some tests and found that the file /usr/share/koha/lib/C4/Auth_with_ldap.pm
 in  the line:

my $cmpmesg = $db->compare( $userldapentry, attr=>'userpassword', value =>
$password );

Wasn't encoding the password to md5_base64 (which use LDAP), so we changed the
line to:


my $cmpmesg = $db->compare( $userldapentry, attr=>'userPassword', value =>
"{MD5}".md5_base64($password)."==" );

Retrieve userPassword attribute, encode the clear text password to md5_base64
and add '{MD5}' at start and '==' end of the password.

If LDAP is using different encryption, that change should be made in the code.
Hope it helps someone.

Greetings.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:44:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:44:12 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-TaL6G7PEZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:44:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:44:15 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-WkqQ4EljSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51460&action=edit
Bug 16507: Show play media tab first if record has no holdings

To test:
1) Go to Admin -> Global sysprefs
2) Turn on HTML5MediaEnabled and HTML5MediaYouTube
3) Go to Cataloging and create a new record
4) Catalogue a YouTube link in 856$u and save record. Do not add any items
(click Normal tab)
5) Confirm that Play media tab shows first
6) Add an item then go back to Normal tab
7) Confirm that Holdings tab now shows first and Play media tab is last

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:44:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:44:44 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-mOt2r769Rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |aleishaamohia at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:51:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:51:11 +0000
Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too
 many Items to display unless viewing them all.
In-Reply-To: <bug-13654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13654-70-d3u6xldr1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Did you get any feedback Olli?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:52:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:52:50 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-yMY2lpWTyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #81 from David Cook <dcook at prosentient.com.au> ---
Just a reminder that koha-gitify can't be used for testing changes to Zebra
configuration files or koha-conf.xml, and this patch makes changes to both.

You'll need to do a source install. It doesn't matter which type you do,
although I personally find a "dev" install to be the nicest. Regardless of what
you choose, you'll need to use "make" and "make upgrade" to update your Zebra
configuration files and koha-conf.xml.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 01:56:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 May 2016 23:56:50 +0000
Subject: [Koha-bugs] [Bug 14096] Licences on About page not consistently
	linked
In-Reply-To: <bug-14096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14096-70-YfuQO9Jzqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14096

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
I think this has been fixed. Can you check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:24:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:24:12 +0000
Subject: [Koha-bugs] [Bug 16510] New: When record items exceed
 OpacMaxItemsToDisplay opacSerialDefaultTab is ignored
Message-ID: <bug-16510-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16510

            Bug ID: 16510
           Summary: When record items exceed OpacMaxItemsToDisplay
                    opacSerialDefaultTab is ignored
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In opac-detail.pl the if construct checks (@itemloop) to see if holdings should
be displayed, however, if items exceed OpacMaxItemsToDisplay @itemloop isn't
populated and the syspref is ignored

my $opac_serial_default = C4::Context->preference('opacSerialDefaultTab');
my $defaulttab =
    $opac_serial_default eq 'subscriptions' && $subscriptionsnumber
        ? 'subscriptions' :
    $opac_serial_default eq 'serialcollection' && @serialcollections > 0
        ? 'serialcollection' :
    $opac_serial_default eq 'holdings' && scalar (@itemloop) > 0
        ? 'holdings' :
    $subscriptionsnumber
        ? 'subscriptions' :
    @serialcollections > 0
        ? 'serialcollection' : 'subscriptions';
$template->param('defaulttab' => $defaulttab);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:25:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:25:38 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-DWX6wDVg0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|REMIND                      |---
           Assignee|henridamien at koha-fr.org     |oleonard at myacpl.org
            Version|rel_3_0                     |master
           Hardware|Macintosh                   |All
             Status|CLOSED                      |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:27:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:27:25 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-Hb2gIBGMlZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
If you're building a notice and select multiple fields, either by using
click+shift+click or ctrl+click, when you add them they are not added as
separate fields:

<<branches.branchname, branches.branchaddress2, branches.branchzip>>

Instead of
<<branches.branchname>><<branches.branchaddress2>><<branches.branchzip>>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:46:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:46:24 +0000
Subject: [Koha-bugs] [Bug 16511] New: Making contracts actions buttons
Message-ID: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

            Bug ID: 16511
           Summary: Making contracts actions buttons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:49:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:49:36 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-Nz7ku517sA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:49:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:49:39 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-a9c8WGKO85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51461&action=edit
Bug 16511: Making contracts actions buttons

To test:
1) Go to Acqui -> find a vendor
2) On Vendor details page (supplier.pl) confirm that Contracts table now has
one column called Actions
3) Confirm that Edit and Delete show as buttons
4) Confirm that buttons don't wrap on a narrower browser
5) Click Contracts tab
6) Confirm Actions column, Edit and Delete buttons, and button's don't wrap

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:50:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:50:03 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-vJYeg3YiUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 02:59:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 00:59:50 +0000
Subject: [Koha-bugs] [Bug 16512] New: Route to library alert missing
Message-ID: <bug-16512-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16512

            Bug ID: 16512
           Summary: Route to library alert missing
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david.roberts at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When an item belonging to one library is checked in at a different library
using the main check in box at the top of the screen, and alert pops up to
remind the staff member to return the item to the owning library. However, if
an item is returned by using the list of checkouts in the patron record, this
alert doesn't display. It would be ideal if these could be consistent and
generate an alert in both instances.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 11:20:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 09:20:50 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-0NaeouzNCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 51462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51462&action=edit
Proposed patch

Remove the reference to the EAN syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 11:21:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 09:21:55 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-aqCgcWwm2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 51463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51463&action=edit
Proposed patch

REmove the shipping budget syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:38:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:38:56 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-Lv5koTz8jT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for the 16.05 release. Thanks Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:40:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:40:46 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-qz0kLLtNQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:40:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:40:50 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-I4RmQGHMUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51464&action=edit
Bug 1859 - Notice fields: can't select multiple fields at once

When selecting database fields to appear in a notice, selecting multiple
fields at once doesn't work correctly. The selected fields are grouped
together between << and >> instead of each being bracketed separately.

This patch corrects this problem. Also changed: Removal of 'onclick';
Conversion of 'insert' button to a Bootstrap buttons styled with a Font
Awesome icon; HTML validation error fixes.

To test, apply the patch and go to Tools -> Notices & Slips.

- Edit any notice.
- Select a notice version to edit (Email, Print, etc.).
- Confirm that the "Insert" button looks correct.
- Using ctrl+click, select multiple database fields to add to the
  notice. Confirm that clicking the "Insert" button adds the fields
  correctly.
- Confirm that there are no HTML validation errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:41:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:41:39 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-43koipQGPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Olli, this patch doesn't apply to master. I think this must be dependent on
another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:41:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:41:49 +0000
Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has
 FileAppender files with different owners, also compatibility with logrotate
In-Reply-To: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16509-70-9FWiVbm4q0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:47:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:47:55 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-OCxJNVDtF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 14:47:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 12:47:57 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-dUh18X101z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51464|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 51465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51465&action=edit
Bug 1859 - Notice fields: can't select multiple fields at once

When selecting database fields to appear in a notice, selecting multiple
fields at once doesn't work correctly. The selected fields are grouped
together between << and >> instead of each being bracketed separately.

This patch corrects this problem. Also changed: Removal of 'onclick';
Conversion of 'insert' button to a Bootstrap buttons styled with a Font
Awesome icon; HTML validation error fixes.

To test, apply the patch and go to Tools -> Notices & Slips.

- Edit any notice.
- Select a notice version to edit (Email, Print, etc.).
- Confirm that the "Insert" button looks correct.
- Using ctrl+click, select multiple database fields to add to the
  notice. Confirm that clicking the "Insert" button adds the fields
  correctly.
- Confirm that there are no HTML validation errors.

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:08:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:08:46 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-fO8xND7DSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51462|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51466&action=edit
Bug 16288: Remove Reference to obsolete EAN syspref

Remove reference to obsolete syspref EDIfactEAN
which was present in earlier test version of
EDI code but should not now be used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:08:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:08:54 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-rGJzudY5M4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51463|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51467&action=edit
Bug 16288: Remove unused EDI Shipping Budget syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:09:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:09:02 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-QSqKe9vWJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51468&action=edit
Bug 16288: (QA followup) Remove the syspref INSERT line

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:09:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:09:57 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-SyEGanTdjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:11:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:11:10 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-U7pIjAwidG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #6 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
I'm not sure to understand so I need more explanations :)
Now, since BZ 12074 was pushed to master, when someone adds a full batch from a
staged file, there's an alert for duplicates. But this alert is based on what
is found by FindDuplicate.
Could we change Findduplicate as it can find duplicate on another field than
ISBN rather to avoid to use findDuplicate ?

I have no preference, all what I want is that we can find duplicates for books,
DVDs or whatever materials when we're importing a batch records.

But, is it better to do it without FindDuplicates ?
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:14:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:14:29 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-3gZqAaEt45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
(In reply to Koha Team Lyon 3 from comment #6)
> Hi,
> I'm not sure to understand so I need more explanations :)
> Now, since BZ 12074 was pushed to master, when someone adds a full batch
> from a staged file, there's an alert for duplicates. But this alert is based
> on what is found by FindDuplicate.
> Could we change Findduplicate as it can find duplicate on another field than
> ISBN rather to avoid to use findDuplicate ?
> 
> I have no preference, all what I want is that we can find duplicates for
> books, DVDs or whatever materials when we're importing a batch records.
> 
> But, is it better to do it without FindDuplicates ?
> Sonia

Sonia,

The problem was that FindDuplicates was hardcoded and the library had no way to
change that.  So the following scenario is just one example of where
FindDuplicates fails libraries:

1. Stage DVD Marc Records
2. Use a rule to match on 024 (the identifier on many DVDs)
3. Find duplicates
4. Go to Acq and add staged file to basket
5. Koha says there are duplicates but there aren't instead it's matching on
Title & Author and matching DVDs to books because the DVDs don't have ISBNs

By using this patch we allow for libraries to choose how to find duplicates
instead of forcing them to use a hard coded script that they have no control
over.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:23:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:23:52 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-kVHyBvAsND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #8 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Ok, Thanks Nicole, I understand and I share the "setting principle" that allow
librarians to choose the key to deduplicate.
I will test the patch with unimarc file to see if it's ok for us.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 15:59:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 13:59:16 +0000
Subject: [Koha-bugs] [Bug 16513] New: Improvements and fixes for quote
	upload process
Message-ID: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

            Bug ID: 16513
           Summary: Improvements and fixes for quote upload process
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I have a few minor improvements and fixes for the Quotes editor and upload
process:

 - Removing 'onclick'
 - Making the 'Cancel upload' button work correctly
 - Add a 'Cancel upload' button to the toolbar
 - Capitalization corrections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:00:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:00:43 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-qeb15bfKYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51469&action=edit
Bug 16504: Add regression tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:00:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:00:41 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-pHlPM76Vu2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:00:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:00:47 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-KexUmosRP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51470&action=edit
Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons

Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that
attributes
for every patrons will be deleted.

Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:01:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:01:11 +0000
Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are
 not saved when invisible
In-Reply-To: <bug-15163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15163-70-G9EmXRhppm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16504


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504
[Bug 16504] All borrower attribute values for a given code deleted if that
attribute has branch limits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:01:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:01:11 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-fGSlFUm5JX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
         Depends on|                            |15163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163
[Bug 15163] Patron attributes with branch limiits are not saved when invisible
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:06:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:06:21 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-qkS88tbLCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51471&action=edit
Bug 16400: Restore the previous stack order behavior

When updating the plugin, the stack order behavior has changed. This
patch restores the prevous behavior (not always z-index: 1000)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:06:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:06:53 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-0MLrWXrlwn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51472&action=edit
Bug 16513 - Improvements and fixes for quote upload process

This patch fixes some minor bugs and adds a small enhancement to the
quotes editor and quotes upload pages.

To test, apply the patch and go to Tools -> Quote editor

- In the table of quotes, clicking the "ID" table header should trigger
  an alert, "Click on the quote's ide to select..."
- Go to "Import quotes" and select a file to upload.
- On the upload preview page you should see a new "Cancel import"
  button. Clicking it should return you to the quotes upload page after
  asking for confirmation.
- Test the upload cancel button:
  - If you have fast reflexes or are uploading a file large enough, you
    should be able to see a "Cancel upload" button during the upload
    process.
  - Clicking this button should cancel the upload and return you to the
    quote upload page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:06:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:06:48 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-heSNynNpvZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:07:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:07:27 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-kgkz7Cluw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha, thanks for testing!
The last patch fixes the issue you got.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:08:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:08:54 +0000
Subject: [Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache
 performace under plack
In-Reply-To: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16088-70-v4F4MsdIy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jesse Weaver from comment #32)
> Question about naming/design; this thing you're making has less in common
> with Koha::Cache and more in common with a per-request C4::Context. Might it
> make more sense to tie it to the latter?

To me it makes sense to have it using the Koha::Cache namespace, it's
cache-related, but I don't really mind about the naming :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:17:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:17:30 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-dpok8K6W2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jesse Weaver from comment #7)
> I have some qualms about pushing this... there are a very significant number
> of places in Koha that use the default framework's mappings (enough to make
> it a de-facto standard). See the results of a $ git grep TransformMarcToKoha

It seems that we are using it when adding/modifying a record/item.

  git grep TransformMarcToKoha|grep -v frameworkcode

does not return a lot of relevant results :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:21:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:21:14 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-PKtN5CFyg4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:30:25 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-jSzgXRomgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:30:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:30:28 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-7wlPbQzsgP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51456|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51473&action=edit
Bug 16388: Move option to download report into reports toolbar

To test:

1) Create a new SQL report or edit a report
2) Ensure that the download option does NOT show in the toolbar
3) Save and run the report
4) Confirm that download option DOES show in toolbar as a dropdown with
   the 3 options (csv, tab and ods)
5) Confirm that downloading all 3 file types works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:30:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:30:33 +0000
Subject: [Koha-bugs] [Bug 16388] Move option to download report into reports
	toolbar
In-Reply-To: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16388-70-SFAVqgSOov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16388

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51474&action=edit
Bug 16388: Use existing 'execute' parameter instead of creating a new one

An existing 'execute' parameter is already passed to the template when
we need to display the 'Download' button, so let's use it instead of
creating a new one.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:33:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:33:16 +0000
Subject: [Koha-bugs] [Bug 14908] Item search: Item search results not
 properly sorted by Date. Date filter also not working
In-Reply-To: <bug-14908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14908-70-lPU40efqoW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14636
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:33:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:33:16 +0000
Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year
 in item search doesn't work correctly
In-Reply-To: <bug-14636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14636-70-KtMA86fYuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14908

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:33:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:33:59 +0000
Subject: [Koha-bugs] [Bug 14908] Item search: Item search results not
 properly sorted by Date. Date filter also not working
In-Reply-To: <bug-14908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14908-70-RpMYiIxl3k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Corrected by Bug 14636 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:42:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:42:00 +0000
Subject: [Koha-bugs] [Bug 16514] New: Force scalar cotext where param
 assumes a list incorrectly in admin/edi scripts
Message-ID: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514

            Bug ID: 16514
           Summary: Force scalar cotext where param assumes a list
                    incorrectly in admin/edi scripts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

CGI's param method assumes a list context when lvalue not explicitly scalar.
Force the correct context to avoid errors being logged

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:57:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:57:35 +0000
Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a
 list incorrectly in admin/edi scripts
In-Reply-To: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16514-70-05ewX7McvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com
             Status|NEW                         |Needs Signoff

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 51475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51475&action=edit
proposed patch

Fix up were scalar needs setting explicitly. To test without patch editing an
edi vendor or ean will generate 'CGI::param called in list context' warnings in
log - with patch applied these should no longer appear

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 16:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 14:59:06 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-d59mqkw6Mz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #175 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #174)
> (In reply to Colin Campbell from comment #173)
> > (In reply to Jonathan Druart from comment #172)
> > > (In reply to Colin Campbell from comment #171)
> > > > (In reply to Jonathan Druart from comment #170)
> > > > > This patchset introduces some uses of CGI->param in list context, please fix.
> > > > 
> > > > Any clue as to where?
> > > 
> > >   grep '=>.*->param' admin/edi_*
> > > 
> > > and see commit f3e4b5bbb6b02d7bb6e89d84c0379666eb1e704f
> > >     Bug 16154: CGI->multi_param - Force scalar context
> > > should give you some tricks.
> > > 
> > > Basically you need to force the scalar context if called in a list context
> > > (when passed to the template).
> > 
> > Exactly these are scalar context calls
> 
> Please have a look at bug 16154 and bug 15809 if you want more information
> on this issue.

Patch submitted on separate bug 16514

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:09:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:09:44 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-zzdLdtQ7bd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:10:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:10:02 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-z1JiD92rVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:10:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:10:23 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-s1GjdCXqZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:10:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:10:26 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-7v2zUqVsNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51476&action=edit
Bug 16505: <collection> is missing the marc namespace and updates fail if -x is
passed

Using rebuild_zerba.pl with the -x option switch, produces an incorrect output
in
terms of what our XSLTs expect for indexing. This patch introduces the right
namespace information
on the exported records so indexing succeeds.

To test:
- On current master, have some records on your db
- Run:
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
=> you will get a message like this:

NOTHING cleaned : the export /tmp/NL5ufjUfpp has been kept.

- Run
  $ less /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: The first line looks like this

<?xml version="1.0" encoding="UTF-8"?><collection><record

- Now run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: No output
- Apply the patch
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
- Take a look at the result file:
  $ less /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: The start of the file looks like this:
<?xml version="1.0" encoding="UTF-8"?><collection
xmlns="http://www.loc.gov/MARC21/slim">

- Run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: There is actually indexing data :-D
- Sign off :-D

Sponsored-by: American Numismatic Society

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:11:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:11:05 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-XCh54mhgQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:21:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:21:01 +0000
Subject: [Koha-bugs] [Bug 16515] New: Did you mean? links don't wrap on
	smaller screens
Message-ID: <bug-16515-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515

            Bug ID: 16515
           Summary: Did you mean? links don't wrap on smaller screens
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When you have turned on "did you mean" suggestions in the OPAC, the text in the
yellow box won't wrap on smaller screens.

This is because of: 
.searchsuggestion {   white-space: nowrap; }


.searchsuggestion { white-space: normal } in OpacUserCSS seems to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:27:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:27:54 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-fQnAQzGt69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #14 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Any chance this will work on 3.22?  Would like to be able to fix this on our
server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 17:58:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 15:58:05 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: <bug-14744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14744-70-wSg53fzOEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 18:38:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 16:38:06 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: <bug-14744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14744-70-wx0G39l9d5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|In Discussion               |RESOLVED

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
I believe this is fixed by Bug 16450.

*** This bug has been marked as a duplicate of bug 16450 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 18:38:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 16:38:06 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-q1vtmNOHit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 14744 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 19:03:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 17:03:30 +0000
Subject: [Koha-bugs] [Bug 14209] opacserialdefaulttab ignored with bibs
 having items <1 or >50
In-Reply-To: <bug-14209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14209-70-igVsBPCqGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14209

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |nick at bywatersolutions.com

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 16510 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 19:03:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 17:03:30 +0000
Subject: [Koha-bugs] [Bug 16510] When record items exceed
 OpacMaxItemsToDisplay opacSerialDefaultTab is ignored
In-Reply-To: <bug-16510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16510-70-bhC7P5ADBF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16510

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 14209 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:06:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:06:03 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr should
 have/require a default branch or provide an error
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-nypWa8xxXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:06:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:06:05 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr should
 have/require a default branch or provide an error
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-VrL616sZz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51477&action=edit
Bug 15878 - Updated unit tests for hbyymmincr barcodes

Test plan in second patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:06:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:06:37 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr should
 have/require a default branch or provide an error
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-Jk0cZbCpHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51477|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51478&action=edit
Bug 15878 - Updated unit tests for hbyymmincr barcodes

Test plan in second patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:06:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:06:42 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr should
 have/require a default branch or provide an error
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-bOTX6vvJKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51479&action=edit
Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn
when no branchcode present

Test plan:

1 - prove t/db_dependent/Barcodes.t
2 - All should pass
3 - Apply first patch (unit tests update)
    4 - Tests should fail on values and warnings
    5 - Apply second patch
    6 - All tests should now pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:07:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:07:31 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-JX9mUucSva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|C4::Barcodes::hbyymmincr    |C4::Barcodes::hbyymmincr
                   |should have/require a       |inccorectly calculates max
                   |default branch or provide   |and should warn when no
                   |an error                    |branchcode present

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:08:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:08:20 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-LEUAsvf0NE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Blocks|                            |14752
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752
[Bug 14752] Add multiple copies to a basket at once
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:08:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:08:20 +0000
Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once
In-Reply-To: <bug-14752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14752-70-2zhzRLJaN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15878


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878
[Bug 15878] C4::Barcodes::hbyymmincr inccorectly calculates max and should warn
when no branchcode present
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:25:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:25:59 +0000
Subject: [Koha-bugs] [Bug 16516] New: showListsUpdate JS function is not
 defined at the OPAC
Message-ID: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

            Bug ID: 16516
           Summary: showListsUpdate JS function is not defined at the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 12233


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233
[Bug 12233] remove prog and CCSR OPAC themes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:25:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:25:59 +0000
Subject: [Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes
In-Reply-To: <bug-12233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12233-70-4Y3k537m0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16516


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516
[Bug 16516] showListsUpdate JS function is not defined at the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:31:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:31:10 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-JIZBWRbYEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 20:31:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 18:31:13 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-A6AhkifUnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51480&action=edit
Bug 16516: Define the showListsUpdate JS function at the OPAC

Bug 12233 removes the declaration of the showListsUpdate JS function for
the OPAC.
It results in a JS error (ReferenceError: showListsUpdate is not
defined) when a user tries to add selected titles to a list if no title
is selected.

Test plan:
Launch a catalogue search
Select a list in the "Select titles to" dropdown list
=> Without this patch you will get the JS error
=> With this patch you will get a JS alert "No item was selected"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:17:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:17:42 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: <bug-14544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14544-70-426LdTdr2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16517


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517
[Bug 16517] A server error is raised when creating a new list with an existing
name
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:17:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:17:42 +0000
Subject: [Koha-bugs] [Bug 16517] New: A server error is raised when creating
 a new list with an existing name
Message-ID: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

            Bug ID: 16517
           Summary: A server error is raised when creating a new list with
                    an existing name
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14544

A very bad typo causes a server error when a librarian try to create a list
with an existing list's name.
This is caused by bug 14544


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544
[Bug 14544] Move the list related code to Koha::Virtualshelves
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:20:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:20:44 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-eKsqhA80vZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
For my defense it looks like a merge conflict error when rebasing bug 14544,
but I plead guilty :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:25:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:25:55 +0000
Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once
In-Reply-To: <bug-14752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14752-70-TuEeFOm1oh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46832|0                           |1
        is obsolete|                            |
  Attachment #46833|0                           |1
        is obsolete|                            |
  Attachment #47223|0                           |1
        is obsolete|                            |
  Attachment #47252|0                           |1
        is obsolete|                            |
  Attachment #48254|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51481&action=edit
Bug 14752 - Add multiple copies to a basket at once

This patch add an 'Add multiple copies' button on the new order page in
acquisitions.  While processing the multiple copies a modal is
displayed.

To test:
1 - Add an order to an acquisitions basket
2 - Choose to add multiple items
3 - A modal shouold warn about ignoring UniqueItemFields from syspref
4 - When submitting the modal should popup until all items are processed.
5 - The modal should disappear after items are added.
6 - Items should be cloned, minus unique fields
7 - Enable autoBarcode for various formats, ensure you are warned that
barcodes will be generated, and ensure they are generated correctly

Sponsored by: Middletown Township Public Library (http://www.mtpl.org)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:26:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:26:12 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-goKIubS2F1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:26:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:26:15 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-bGVWSBtXJd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51482&action=edit
Bug 16517: Do not crash when creating a list with an existing name

A typo has been made during a merge conflict when rebasing bug 16517.

it should be
  eval { Koha::Object->new->store; };
instead of
  eval { Koha::Object->new; }->store;

Test plan:
>From the result list (intranet side), check some entries and add them to
a new list
Use an existing list's name
=> Without this patch you will get a server error (exception 'Duplicate shelf
object' raised by Koha::Virtualshelf->new->store)
=> With this patch you must get a friendly error message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:27:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:27:04 +0000
Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once
In-Reply-To: <bug-14752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14752-70-SnfoD22FuJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Patches rebased and squashed, added dependency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:27:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:27:51 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-lDQSyZFeNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Lists
                   |and plumbing                |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:46:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:46:40 +0000
Subject: [Koha-bugs] [Bug 16518] New: opac-addbybiblionumber is not plack
	safe
Message-ID: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

            Bug ID: 16518
           Summary: opac-addbybiblionumber is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 7172

The script opac/opac-addbybiblionumber.pl is not plack safe because the
variable @biblios is declared with our and is not assigned to an empty array
(so not reset).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:46:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:46:40 +0000
Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems
In-Reply-To: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7172-70-GMyxG0y9t6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16518


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518
[Bug 16518] opac-addbybiblionumber is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:51:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:51:05 +0000
Subject: [Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe
In-Reply-To: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16518-70-rdU9rKg5ZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:51:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:51:08 +0000
Subject: [Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe
In-Reply-To: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16518-70-yoYhiPqWcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51483&action=edit
Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl

The script opac/opac-addbybiblionumber.pl is not plack safe because the
variable @biblios is declared with our and is not assigned to an empty
array (so not reset).

The issue:
When trying to add items to a list (virtualshelf), the biblionumbers are
added to the @biblios variable and the list is not reset between each
run.

Test plan:
Check from records from the result list and add them
to a list.
Cancel or save and re-add them (or others) to a list (same or
different).
=> Without this patch, the list of records will never stop growing, the
previous items added are still listed when adding new ones.
=> With this patch, the behavior is the one expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:57:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:57:38 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-nvmAyS8har@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519
[Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:57:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:57:38 +0000
Subject: [Koha-bugs] [Bug 16519] New: Do not use global variables in
 [opac-]addbybiblionumbers.pl
Message-ID: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

            Bug ID: 16519
           Summary: Do not use global variables in
                    [opac-]addbybiblionumbers.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16517, 16518

To avoid bug like bug 16518 and to ease the readability/maintainability of
these scripts, it would be great to see them rewritten not to use global
variables.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517
[Bug 16517] A server error is raised when creating a new list with an existing
name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518
[Bug 16518] opac-addbybiblionumber is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 21:57:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 19:57:38 +0000
Subject: [Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe
In-Reply-To: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16518-70-RjhGS5mPYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519
[Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:00:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:00:55 +0000
Subject: [Koha-bugs] [Bug 14908] Item search: Item search results not
 properly sorted by Date. Date filter also not working
In-Reply-To: <bug-14908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14908-70-y3LzjRqxdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908

--- Comment #4 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Indeed Fridolin, the ordering by date seems to be fixed in 3.20.8+
Thank you all for the great work!

Having said that, filtering by date, still doesn't seem to work.
For example, if you enter a date (that appears in the items results) in the
date filter, you get no results at all. I've checked it with v3.20.10

Can you reproduce it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:02:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:02:20 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-GW1NclKH31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:02:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:02:23 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-4LG7mMg54E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51484&action=edit
Bug 16519: Replace 'our' with 'my' in [opac-]addbybiblionumbers.pl

To avoid bug like bug 16518 and to ease the readability/maintainability
of these scripts, this patch replaces the use of 'our' with 'my' to
avoid the use of global variables.

Basically the code has been moved from subroutines to the appropriate places.

Test plan:
At the intranet and OPAC sides
1/ Add items to a list
2/ Add items to a list using an existing name
3/ Add items to a list you don't have right on it (by modifying the
biblionumber in the url)
4/ At the OPAC, use the opac-addbybiblionumber.pl without being logged
in to add items to a list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:08:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:08:16 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-yVVdBKSePr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Minor: use q{} instead of qq{} if you do not need to interpolate variables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:09:21 +0000
Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a
 list incorrectly in admin/edi scripts
In-Reply-To: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16514-70-GWIBipehud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:24:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:24:20 +0000
Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include
	deleted items
In-Reply-To: <bug-8483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8483-70-vwjAAkDidf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #51)
> I need someone to tell me what needs changed in order to for this to pqa.
> All of these changes are internal to Koha::Object and it's children. Taking
> advantage of the underlying DBIC object should not be an issue. Can someone
> please tell me specifically what needs to be changed?

I am sorry but I do not have any good answers.
It seems that we are stuck with our Koha::Object[s] implementation at different
places. Here you are trying to cache something when we should rely on
DBIx::Class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:30:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:30:53 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-eZNLNFmwSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:30:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:30:56 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-vjz3SuXqIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51442|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51485&action=edit
Bug 16382: Update German web installer sample files for 16.05

Easy this time, only sample notices have been changed:
- Changed discharge to match the English sample notice.
- Translated new PASSWORD_RESET e-mail

To test:
- Start with an empty database
- Install de-DE
- Run the web installer in de-DE/German
- Verify all files, especially sample notices, load
  without any problems.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested removing all from letter table and loading file.
File loads Ok, notices look good.
No errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:39:16 +0000
Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has
	warnings
In-Reply-To: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15086-70-cU0v1IPSh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:39:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:39:20 +0000
Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has
	warnings
In-Reply-To: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15086-70-DQFHfGkpV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51444|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51486&action=edit
Bug 15086: Creators layout and template sql has warnings

When doing a hacked install off the master branch:
use ... {koha database name}
truncate creator_layouts;
truncate creator_templates;
truncate printers_profiles;
source installer/data/mysql/... {name of a sample_labels type file}
Warnings are generated, which may not be visible in the UI.

Most of the warnings were triggered by:
-/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */;
-/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */;
http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha

In the Russian, the layout_name was truncated, because the layout_name was only
20. An atomic update sql and kohastructure.sql update were provided to widen it
to 25.
http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated

Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the
structure was made the same as the other files.

See comment #1 for the test plan.

NOTE: pl-PL is likely very out of date, but is not affected in this regard.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works, no more warnings
mysql> show warnings;
Empty set (0.01 sec)

No errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:44:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:44:59 +0000
Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue
 conflict with each other
In-Reply-To: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14514-70-uMCi1e5iKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |barton at bywatersolutions.com

--- Comment #8 from Barton Chittenden <barton at bywatersolutions.com> ---
Patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:46:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:46:52 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-EAVujvBMMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:54:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:54:09 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-3ngD1nPowh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:54:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:54:12 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-DdBNx6yedL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51448|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51487&action=edit
Bug 16501: Remove some unneeded warns in Upload.t

At some point I saw some gain in warning about a missing config line.
But these warns are actually not needed here.
Removing them here.

Test plan:
Run t/db_dependent/Upload.t while having upload_path in your koha-conf and
also without it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:56:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:56:40 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-kMRbJ7ZVRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 22:56:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 20:56:43 +0000
Subject: [Koha-bugs] [Bug 12402] Show more on pending patron modification
	requests
In-Reply-To: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12402-70-veLlE48ZXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51455|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51488&action=edit
Bug 12402: Show patron category on pending patron modifications

To test:
1) Go to OPAC and make a modification to user
2) Go to Staff Client and go to pending patron modifications
3) Notice that we have the user's surname, first name, branch and
   cardnumber
4) Apply patch and refresh page
5) Notice that patron category now shows after user's name

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:04:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:04:57 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-sHQDHSjvTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:05:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:05:00 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-fsdVEZnCO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51465|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51489&action=edit
Bug 1859 - Notice fields: can't select multiple fields at once

When selecting database fields to appear in a notice, selecting multiple
fields at once doesn't work correctly. The selected fields are grouped
together between << and >> instead of each being bracketed separately.

This patch corrects this problem. Also changed: Removal of 'onclick';
Conversion of 'insert' button to a Bootstrap buttons styled with a Font
Awesome icon; HTML validation error fixes.

To test, apply the patch and go to Tools -> Notices & Slips.

- Edit any notice.
- Select a notice version to edit (Email, Print, etc.).
- Confirm that the "Insert" button looks correct.
- Using ctrl+click, select multiple database fields to add to the
  notice. Confirm that clicking the "Insert" button adds the fields
  correctly.
- Confirm that there are no HTML validation errors.

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:05:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:05:04 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-QAKPXjWUib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51490&action=edit
Bug 1859: Do not display <<>> if an entry without value is selected

For instance there are ---TABLES--- to delimite fields' tables, if
selected we do not want to add "<<>>" to the letter.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:47:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:47:16 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-odaFRfdWc0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:47:18 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-GJUAwZd65t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51482|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51491&action=edit
[SIGNED-OFF] Bug 16517: Do not crash when creating a list with an existing name

A typo has been made during a merge conflict when rebasing bug 16517.

it should be
  eval { Koha::Object->new->store; };
instead of
  eval { Koha::Object->new; }->store;

Test plan:
>From the result list (intranet side), check some entries and add them to
a new list
Use an existing list's name
=> Without this patch you will get a server error (exception 'Duplicate shelf
object' raised by Koha::Virtualshelf->new->store)
=> With this patch you must get a friendly error message

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:52:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:52:47 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-LQIV5Hmrof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 13 23:52:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 21:52:49 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-gey0OsAPf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51480|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51492&action=edit
[SIGNED-OFF] Bug 16516: Define the showListsUpdate JS function at the OPAC

Bug 12233 removes the declaration of the showListsUpdate JS function for
the OPAC.
It results in a JS error (ReferenceError: showListsUpdate is not
defined) when a user tries to add selected titles to a list if no title
is selected.

Test plan:
Launch a catalogue search
Select a list in the "Select titles to" dropdown list
=> Without this patch you will get the JS error
=> With this patch you will get a JS alert "No item was selected"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:23:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:23:23 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-w9dqRuM7Bv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> Minor: use q{} instead of qq{} if you do not need to interpolate variables.

Heh, yes. That's a leftover from the first approach, that changed things a bit
more, so I delayed it for an enhancement bug. Good catch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:24:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:24:37 +0000
Subject: [Koha-bugs] [Bug 16520] New: Per-virtualhost SetEnvs don't work
	with Plack
Message-ID: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

            Bug ID: 16520
           Summary: Per-virtualhost SetEnvs don't work with Plack
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jweaver at bywatersolutions.com
          Reporter: jweaver at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The various SetEnvs that can be used in Koha to configure memcached, change
search limits, override sysprefs and add custom stylesheets don't work in
Plack. It is likely impossible to fix this with the current HTTP proxy setup,
so we need a workaround.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:50:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:50:11 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-CkurtmKrCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:50:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:50:13 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-WvTrQvcfT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #1 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51493&action=edit
Bug 16520: Allow per-VirtualHost environment variables with Plack

This allows MEMCACHED_*, OVERRIDE_SYSPREF_* and others to work properly.

Test plan:

  1) Add the following line to your plack.psgi (near the bottom, just
     above "mount ..."):
       enable "+Koha::Middleware::Plack";
  2) Load the OPAC advanced search page (under Plack). The title should
    read "Koha online catalog" (or whatever your LibraryName syspref
    contains).
  3) Add the following to your Apache configuration:
       RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\,
Potato"
  4) Restart Apache.
  5) Refresh. The title should now read "Potato, Potato online catalog".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:50:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:50:18 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-Ubimf6VcVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #2 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51494&action=edit
Bug 16520: Initialize the sysprefs Koha::Cache on demand

This is needed so that the cache singleton doesn't get created before
the MEMCACHED_* environment variables are set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:50:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:50:21 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-IWeIqDo0fX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #3 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51495&action=edit
Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files

This was not added to the old etc/koha-httpd.conf because that file has
no infrastructure for Plack anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:50:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:50:25 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-kuEmW6WZFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51496&action=edit
Bug 16520: Fix the Apache Plack config to load the main page through Plack

Previously, the ProxyPass would not pass the OPAC/staff homepage to
Plack. This fixes this problem (which is necessary for the other changes
on this bug to show on the main page).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:51:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:51:08 +0000
Subject: [Koha-bugs] [Bug 16521] New: <<item.*>> and <<biblio.*>> not
 expanding on DUE, PREDUE notices.
Message-ID: <bug-16521-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16521

            Bug ID: 16521
           Summary: <<item.*>> and <<biblio.*>> not expanding on DUE,
                    PREDUE notices.
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Items, Biblio and issues information should be available on DUE and PREDUE
notices, but are not populated. I believe that this is a regression.

To reproduce:

Prerequisites: System set up to run predue notices.

1/ Create DUE and PREDUE letters with the following content for email:

The following item is due:

<<biblio.title>>, (<<item.barcode>>), <<issues.date_due>>

2/ Check out two items, and back-date the date due so that one will generate a
predue notice, and the other is due today.

3/ Run advanced_notices.pl

Note that the item information in each notice will show as

, (),

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 00:52:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 May 2016 22:52:06 +0000
Subject: [Koha-bugs] [Bug 16521] <<item.*>> and <<biblio.*>> not expanding
 on DUE, PREDUE notices.
In-Reply-To: <bug-16521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16521-70-M4zRaGW9Ai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16521

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 05:44:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 03:44:47 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-5c3SJz3870@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #106 from Florent Mara <florent.mara at gmail.com> ---
(Thank you Bernardo for the advice on trying to progress this) 

Here are the changes introduces in each of the 6 patches:
Patch 1 - Replace deprecated C4::Dates with Koha::DateUtils and backport fix
from master for entries with empty userids. This fix is deprecated in my last
commit due to bug 16426.

Patch 2 - Add missing dependency C4::Members::Attributes and some pod. Add the
first regression tests - none were present previously - with basic tests for
empty parameters variables and valid input file. 

Patch 3 - Introduced Moo. Refactored setting of column keys, missing borrower
category code and missing borrower branch code into 3 new methods. Features are
identical as prior. Each method is 100% test covered with subtests. 

Patch 4 - Update misc/import_patrons.pl and tools/import_borrowers.pl to use
Koha::Patrons::Import in an object oriented way.

Patch 5 - Adds missing dependency C4::Members::AttributeTypes. Refactor setting
attributes types, prepare columns and dates formatting into 3 new methods.
Features for attributes type and prepare column are identical. 

Date formatting was changes as follows after discussion with Chris.
* The previous implementation let parsing of dates silently failed then be
overwritten with system default values during import as the error was push to
@missing_criticals after this array was last considered. 
* The new implementation formats dates and uses @missing_criticals before it is
used to bail out of importing the entry. 

Each new method is 100% test covered with subtests. 

Patch 6 - Backport changes from bug 16426 and fixes the defect it introduces.
As per my comment in 16426, the fix was introduced at the wrong place in the
code which caused it to never be reached and prevents checks on duplicate
userid . 

Test plan:
1) Apply this patch. 
2) Set dateformat to mm/dd/yyyy. (Koha home->Administration->search for
dateformat -> select and save) 
3) run 'prove t/db_dependent/Koha/Patrons/Import.t'. All 122 tests should pass. 
These regression tests validate (1) Koha::Patrons::Import compiles, (2) all
fields output from the main import() method are identical before and after
refactoring (equivalence of output), (3) all 6 new methods provide the expected
feature, (4) backport duplicate userid fix. 
4) Run the online importer ( Koha home->tools->Import patrons) Load
PatronDataCSV1.csv sample file with default import parameters. It should result
in 165 imported records and 835 not imported because they are not in the
expected format.
This step validates that (1) tools/import_borrowers.pl works as previously and
wrongly formatted dates are now correctly being reported as such. 
5) Set dateformat to dd/mm/yyyy.
6) Run the new command line importer 'perl misc/import_patrons.pl -f
PatronDataCSV1.csv -c -m 'cardnumber' -v'
It should load the remaining 835 entries from the sample file.
Import complete:
Imported:    835
Overwritten: 0
Skipped:     0
Invalid:     165
Total:       1000
This step validates the new command line tool misc/import_patrons works and
confirm date validation is effective.

While this is a big patch, it contains only one feature change to fix dates
being silently overwritten and is coming with a large number of tests with
extensive test coverage for all changes made. It also contains a regression
tested fix for bug 16426.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 07:37:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 05:37:33 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-UqVnxF7Xrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51258|0                           |1
        is obsolete|                            |

--- Comment #6 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51497&action=edit
Bug 16456: Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation

Add Font Awesome Icons to section Patrons and circulation in Tools module

To test goto:
-Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,
 Clear all, Select all
-Comments -> Approve, delete and, unapprove
-Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all,
 Select all pending. Set TagsModeration to Require.
-Verify that all tools work as expected

NOTE: The Tag and Comments tools has been revised to fit with others
interfaces in Koha.
Bug ammended according with QA comment 5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 07:38:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 05:38:50 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-GCZPytmjOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51251|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 07:40:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 05:40:32 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-niUPIyx2wN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #7 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51498&action=edit
Add patrons tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 07:41:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 05:41:10 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-fUm1YqkA29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #8 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51499&action=edit
Tag Moderation Tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 07:42:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 05:42:12 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-lqQz5EYHb7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |oleonard at myacpl.org

--- Comment #9 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Patch changed according with comment #5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 07:56:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 05:56:24 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-s6oWLSy8KA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51497|0                           |1
        is obsolete|                            |

--- Comment #10 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51500&action=edit
Bug 16456: Add Font Awesome icons to some buttons in Tools module, section
Patrons and circulation

Add Font Awesome Icons to section Patrons and circulation in Tools module

To test goto:
-Patron list -> my_list_saved -> Add patrons -> Remove selected patrons,
 Clear all, Select all
-Comments -> Approve, delete and, unapprove
-Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all,
 Select all pending. Set TagsModeration to Require.
-Verify that all tools work as expected

NOTE: The Tag and Comments tools has been revised to fit with others
interfaces in Koha.
Bug ammended according with QA comment 5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 08:27:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 06:27:16 +0000
Subject: [Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in
 Tools module, section Patrons and circulation
In-Reply-To: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16456-70-Tu1VUtYnVY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

--- Comment #11 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51501&action=edit
Bug 16456: Add Font Awesome icons to tag result

To test goto:
-Tags -> and click in a tag with multiple titles
-A table with titles tagged with the term is presented
-See the new button 'Remove'
-Verify if you can remove tags from a selected title.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 12:57:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 10:57:55 +0000
Subject: [Koha-bugs] [Bug 16522] New: Add 773 (Host item entry) to the cart
 display and e-mail
Message-ID: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

            Bug ID: 16522
           Summary: Add 773 (Host item entry) to the cart display and
                    e-mail
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When adding an analytical record to your cart or your list, the host item entry
- the serial or monograph the analytic is included in, will now show. 

Ideally this information should show in staff and OPAC
- in the brief display table
- on the more details view
- in the e-mail text

For libraries with a lot of analytical records this is quite an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 22:46:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 20:46:26 +0000
Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a
 category of authorised values
In-Reply-To: <bug-10095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10095-70-ksv95spdb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 23:00:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 21:00:53 +0000
Subject: [Koha-bugs] [Bug 16523] New: Ability to choose NONE for the
 libraries limitation in authorised values
Message-ID: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

            Bug ID: 16523
           Summary: Ability to choose NONE for the libraries limitation in
                    authorised values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Currently you have to choose at least one library on an authorized value. 
However, I would like to be able to have a location of CART, with a user
friendly description, but not give ANY libraries the ability to choose it
manually.  I only want the check in process to use it.

There should be a NONE option in the list.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 23:55:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 21:55:10 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-VtmqHxJ6Pb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 14 23:55:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 May 2016 21:55:12 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-waLBadTTv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51459|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51502&action=edit
[SIGNED-OFF] Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'

To test:
1) Go to the tools home page. Confirm it says 'Inventory' instead of
   'Inventory/stocktaking' in heading and in description
2) Click Inventory. Confirm heading now says 'Inventory' instead of
   'Inventory/stocktaking'
3) Confirm that it now says 'Inventory' instead of
   'Inventory/stocktaking' in the tools menu along the left of the page
4) Click Help in top right corner. Confirm help heading now says
   'Inventory' instead of 'Inventory/stocktaking'
5) Go to user account page, go to Set Permissions
6) Expand Tools option and confirm it says 'inventory' instead of
   'inventory (stocktaking)'

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 09:23:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 07:23:24 +0000
Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a
	System Preference
In-Reply-To: <bug-13211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13211-70-OjOzGXGXGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
  Text to go in the|                            |From git description:
      release notes|                            |
                   |                            |Use
                   |                            |Google Indic
                   |                            |Transliteration API to
                   |                            |allow users to
                   |                            |transliterate english typed
                   |                            |words into Indic languages.
                   |                            |
                   |                            |This is available only on
                   |                            |the masthead search box in
                   |                            |the OPAC.
                   |                            |
                   |                            |User has to
                   |                            |enter a word in english and
                   |                            |press space or return to
                   |                            |transliterate the word. The
                   |                            |destination language can be
                   |                            |selected from a drop down
                   |                            |list. User can temporarily
                   |                            |turn on/off the feature by
                   |                            |using "ctrl +g".
                   |                            |
                   |                            |A system
                   |                            |preference -
                   |                            |GoogleIndicTransliteration
                   |                            |can be used to turn on this
                   |                            |feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 09:25:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 07:25:00 +0000
Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a
	System Preference
In-Reply-To: <bug-13211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13211-70-H8kYtyTVGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211

--- Comment #15 from Zeno Tajoli <z.tajoli at cineca.it> ---
(In reply to Nicole C. Engard from comment #14)
> Can someone explain to me what this does in librarian terms for the manual?
> Does it just make it so you can type in your language in the search box?

Hi Nicole, I have insert a description of the patch in Text section of this
bug.
Taken from git description.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 17:25:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 15:25:33 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-JoYYuL8aIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51503&action=edit
Bug 14874 - Add ability to search for patrons by date of birth from checkout
and patron quick searches

This patch alters C4::Utils::DataTables::Members::search to autodetect
if the searchmember parameter is a date and search by DOB if so

To test:
1 - Apply patch
2 - Search for members by DOB formatted as per dateformat syspref or
mysql format
3 - Results should be returned as expected
4 - Search combined with other terms, results should be returned as
expected
5 - Search for patrons without using dates, results should be as
expected
6 - Search using search fields 'Date of birth' from expanded menu on
patron search - results should be returned as before (Note dying on
        incorrect format is an existing bug)
7 - prove t/db_dependent/Utils/Datatables_Members.t

Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 17:25:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 15:25:31 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-x6yNLFdaKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 17:25:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 15:25:59 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-v60b109klS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51503|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51504&action=edit
Bug 14874 - Add ability to search for patrons by date of birth from checkout
and patron quick searches

This patch alters C4::Utils::DataTables::Members::search to autodetect
if the searchmember parameter is a date and search by DOB if so

To test:
1 - Apply patch
2 - Search for members by DOB formatted as per dateformat syspref or
mysql format
3 - Results should be returned as expected
4 - Search combined with other terms, results should be returned as
expected
5 - Search for patrons without using dates, results should be as
expected
6 - Search using search fields 'Date of birth' from expanded menu on
patron search - results should be returned as before (Note dying on
        incorrect format is an existing bug)
7 - prove t/db_dependent/Utils/Datatables_Members.t

Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 17:26:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 15:26:03 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-inAsQWKKpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51505&action=edit
Bug 14874 - (followup) Refactor t/db_dependent/Utils/Datatables_Members.t to
use TestBuilder

To test:
1 - Apply other patches (not this one)
2 - Prove t/db_dependent/Utils/Datatables_Members.t
3 - SHould pass
4 - Apply this patch
5 - prove t/db_dependent/Utils/Datatables_Members.t
6 - All tests should continue to pass

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 15 17:26:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 15:26:53 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-wjj3th3Wns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
            Version|unspecified                 |master
                 CC|                            |nick at bywatersolutions.com,
                   |                            |nicole at bywatersolutions.com
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 01:51:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 May 2016 23:51:30 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-bDw5M6aUjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #13 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Hi Jonathan,

I like this. The buttons on the member entry page for adding a new patron don't
have any space between them, but that's the only thing I could find wrong.

Something else did come to mind - I think the cancel buttons should use the fa
fa-times icon like many of our other cancel buttons. Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 02:07:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 00:07:18 +0000
Subject: [Koha-bugs] [Bug 12430] Truncation disables relevance ranking when
 not using QueryParser
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-tzqtzhv4o2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #6)
> It appears that this patch could break the "Publication Date (yyyy)" search,
> when using "yr,st-numeric" (which might be the case after bug 9368).
> 
> If we were to use "yr,st-year" instead, you might get results for a "2000-"
> query but they would only be for "2000". If you specified a full range
> "2000-2012", it would break.
> 
> It seems that relevance can't be run with date ranges (which is usually
> fine, as we use date ranges as limits which are not affected by relevance
> ranking).

FYI, the issue with st-numeric was fixed in Zebra 2.0.62

http://www.indexdata.com/zebra/doc/NEWS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 02:07:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 00:07:58 +0000
Subject: [Koha-bugs] [Bug 12430] Truncation disables relevance ranking when
 not using QueryParser
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-f4pEuwrXob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Also, I'm probably never going to work on this again.

I don't have the time to fix all the things that are wrong with C4::Search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 02:09:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 00:09:16 +0000
Subject: [Koha-bugs] [Bug 9383] Bad logic, missing params,
 and irregular labeling for Members scripts
In-Reply-To: <bug-9383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9383-70-RNHbBOKtH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |INVALID

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
I'm closing this one, as it's super old and I reckon it's been fixed or is no
longer relevant in its current incarnation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 02:11:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 00:11:38 +0000
Subject: [Koha-bugs] [Bug 12430] Truncation disables relevance ranking when
 not using QueryParser
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-P3W51F6L9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
Honestly, there's probably no point trying to refactor the C4::Search code for
Zebra anymore. It would probably be better to scrap it and start over rather
than try to make it work the way it does now.

Time would probably be better spent finishing the QueryParser, or converting
Koha to use actual CCL query syntax.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 02:50:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 00:50:47 +0000
Subject: [Koha-bugs] [Bug 16524] New: Use floating toolbar on item search
Message-ID: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

            Bug ID: 16524
           Summary: Use floating toolbar on item search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:00:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:00:30 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-FgmbtIxcVV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:00:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:00:33 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-2iw1ftsfFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51506&action=edit
Bug 16524: Use floating toolbar on item search

To test:
1) Go to item search
2) Confirm toolbar at top of page, goes down page as you scroll
3) Both output options (screen and CSV) work as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:00:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:00:41 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-gM2TgNb8kG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |aleishaamohia at hotmail.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:03:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:03:51 +0000
Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x
In-Reply-To: <bug-15998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15998-70-3eYb0T3xQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed by Module Maintainer |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:07:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:07:30 +0000
Subject: [Koha-bugs] [Bug 16525] New: Have cancel button when adding new aq
	budget
Message-ID: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

            Bug ID: 16525
           Summary: Have cancel button when adding new aq budget
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:14:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:14:38 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-LRz3rGu14j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:14:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:14:41 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-bFL3waAE37@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51507&action=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an existing
budget. This patch adds a cancel button to the form which adds a budget. Also
changes the wording of the save button from 'Save changes' to just 'Save' so it
makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 03:14:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 01:14:51 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-aIRkXLBZbC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 07:45:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 05:45:10 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-ftAPzFQNLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #82 from David Cook <dcook at prosentient.com.au> ---
I keep wanting to split this bug into 2 separate bug reports, but I don't want
to lose this CC list... so for now I'm going to split it into 2 separate
patches, which can technically be tested separately.

The actual "OAI-PMH Harvesting Client" will be part of the Icarus patch. It's
implemented as a plugin for the Icarus job server. One plugin downloads (ie
"harvests") records, and one plugin uploads them to a Koha HTTP API.

The second patch will include the OAI-PMH import HTTP API for Koha. To test it,
you can use cURL to post to the API, you can write your own OAI-PMH client and
point it at the API, or whatever.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:07:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:07:39 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-7n41llEa6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51469|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51508&action=edit
[SIGNED-OFF] Bug 16504: Add regression tests

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:08:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:08:50 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-ay7jZDEg9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:08:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:08:53 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-KOey468ZOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51470|0                           |1
        is obsolete|                            |

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51509&action=edit
[SIGNED-OFF] Bug 16504: (follow-up for bug 15163) Do not remove attributes of
other patrons

Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that
attributes
for every patrons will be deleted.

Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:13:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:13:02 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-yKJdySXpd1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50980|0                           |1
        is obsolete|                            |

--- Comment #83 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51510&action=edit
Bug 10662 - kohastructure.sql changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:13:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:13:50 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-11aJsp63AU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #84 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51511&action=edit
Bug 10662 - Icarus job server and Koha UI for it

<To be updated>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:14:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:14:21 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-CcTTr79Q8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I think that we need a test for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:14:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:14:29 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-uWumlVpi6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #85 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51512&action=edit
Bug 10662 - Create svc/import_oai API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:18:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:18:53 +0000
Subject: [Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe
In-Reply-To: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16518-70-F5mrVhpXXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 08:18:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 06:18:56 +0000
Subject: [Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe
In-Reply-To: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16518-70-hUGecwdeuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51483|0                           |1
        is obsolete|                            |

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51513&action=edit
[SIGNED-OFF] Bug 16518: Fix Plack variable scoping problem in
opac-addbybiblionumber.pl

The script opac/opac-addbybiblionumber.pl is not plack safe because the
variable @biblios is declared with our and is not assigned to an empty
array (so not reset).

The issue:
When trying to add items to a list (virtualshelf), the biblionumbers are
added to the @biblios variable and the list is not reset between each
run.

Test plan:
Check from records from the result list and add them
to a list.
Cancel or save and re-add them (or others) to a list (same or
different).
=> Without this patch, the list of records will never stop growing, the
previous items added are still listed when adding new ones.
=> With this patch, the behavior is the one expected.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:03:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:03:56 +0000
Subject: [Koha-bugs] [Bug 16496] accountlines.issue_id not set when new
 overdue is processed
In-Reply-To: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16496-70-mopCf7ByuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15675
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675
[Bug 15675] Add issue_id column to accountlines and use it for updating fines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:03:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:03:56 +0000
Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use
 it for updating fines
In-Reply-To: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15675-70-YrRBgnjBj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496
[Bug 16496] accountlines.issue_id not set when new overdue is processed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:12:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:12:40 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-ia3xic4Ygd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51512|0                           |1
        is obsolete|                            |

--- Comment #86 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51514&action=edit
Bug 10662 - Create svc/import_oai API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:13:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:13:53 +0000
Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page
In-Reply-To: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15816-70-66VqQyNUYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:16:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:16:15 +0000
Subject: [Koha-bugs] [Bug 15682] Merging records from cataloguing search
 only allows to merge 2 records
In-Reply-To: <bug-15682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15682-70-IRAr4P4uSu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:23:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:23:57 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-Dw5hkGUA7x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:25:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:25:25 +0000
Subject: [Koha-bugs] [Bug 15919] Batch checkout should show due date in list
 of checked-out items
In-Reply-To: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15919-70-Uj79thssqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15919

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:35:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:35:02 +0000
Subject: [Koha-bugs] [Bug 16041] StaffAuthorisedValueImages &
 AuthorisedValueImages preferences - impact on search performance
In-Reply-To: <bug-16041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16041-70-VxXpwXo0EO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:36:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:36:59 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-0yMpUaLfrI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Revert will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 09:58:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 07:58:06 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16170-70-iPFqK4F0hn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:01:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:01:44 +0000
Subject: [Koha-bugs] [Bug 16248] ModZebra doesn't update zebraqueue if ES is
	enabled
In-Reply-To: <bug-16248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16248-70-rvNlzgWJjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16248

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:05:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:05:24 +0000
Subject: [Koha-bugs] [Bug 16249] Zebra-specific tests should pass with ES
	disabled
In-Reply-To: <bug-16249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16249-70-uKSOrAXCr1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:05:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:05:25 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-ksoQ9Tro2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
Bug 12478 depends on bug 16249, which changed state.

Bug 16249 Summary: Zebra-specific tests should pass with ES disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:06:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:06:46 +0000
Subject: [Koha-bugs] [Bug 16257] EDIfact messages link on tools page results
	error
In-Reply-To: <bug-16257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16257-70-H9UHe9N5tf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16257

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:08:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:08:22 +0000
Subject: [Koha-bugs] [Bug 16315] OPAC Shelfbrowser doesn't display the full
	title
In-Reply-To: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16315-70-hwdjyjS29C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16315

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:18:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:18:10 +0000
Subject: [Koha-bugs] [Bug 16321] 'Show all details' checkbox triggers JS
 error after jQuery upgrade
In-Reply-To: <bug-16321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16321-70-BbnTIWLRSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
It's not strictly needed in 3.22.x, but it works with jQuery 1.7.2 too, and
improves code readability.

Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:21:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:21:21 +0000
Subject: [Koha-bugs] [Bug 16328] datatables on opac-suggestions.pl broken by
	js error
In-Reply-To: <bug-16328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16328-70-Fgq8fz4PMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16328

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:28:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:28:31 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-0zUzUbob0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
The call to checkpw in Patron.pm is weird and will probably make people think
some magic is being invoked. the parameters should be more explicit i.e. :

checkpw($dvh, $self->{userid}, $pwd, undef, undef, 1);

with a comment to document

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:33:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:33:29 +0000
Subject: [Koha-bugs] [Bug 16369] Clean up and improve plugins template
In-Reply-To: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16369-70-cfYftb1UZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:55:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:55:30 +0000
Subject: [Koha-bugs] [Bug 16390] Accounts.t does not need MPL
In-Reply-To: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16390-70-GtTeIvdMxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:56:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:56:08 +0000
Subject: [Koha-bugs] [Bug 16396] Update package version for master packages
In-Reply-To: <bug-16396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16396-70-lCZk9zd9Nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16396

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:58:20 +0000
Subject: [Koha-bugs] [Bug 16403] Fix Holds.t (tests 9 and 39)
In-Reply-To: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16403-70-UeLV2mMO4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:59:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:59:02 +0000
Subject: [Koha-bugs] [Bug 16404] Fix Circulation/Branch.t (tests 8-11)
In-Reply-To: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16404-70-EzYt1UXkK0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 10:59:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 08:59:33 +0000
Subject: [Koha-bugs] [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t
	test 2
In-Reply-To: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16405-70-3L8JmO3saX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:04:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:04:30 +0000
Subject: [Koha-bugs] [Bug 16407] Fix Koha_borrower_modifications.t
In-Reply-To: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16407-70-EqLDPwwgoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16407

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:12:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:12:25 +0000
Subject: [Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in
	cache
In-Reply-To: <bug-16044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16044-70-UjPQvnurQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16412


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412
[Bug 16412] Cache undef in L1 only
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:12:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:12:25 +0000
Subject: [Koha-bugs] [Bug 16412] Cache undef in L1 only
In-Reply-To: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16412-70-8YTirc5bjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16412

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16044
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044
[Bug 16044] Define a L1 cache for all objects set in cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:14:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:14:35 +0000
Subject: [Koha-bugs] [Bug 16414] aqorders.budgetgroup_id has never been used
 and can be removed
In-Reply-To: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16414-70-7l8f8jbvnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:15:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:15:16 +0000
Subject: [Koha-bugs] [Bug 16419] Tests of t/db_dependent/Acquisition.t do
	not pass
In-Reply-To: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16419-70-2kCodRDiwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:35:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:35:22 +0000
Subject: [Koha-bugs] [Bug 16445] Bug 12478 has added an unnecessary line to
 Koha/Database.pm
In-Reply-To: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16445-70-avTqyggdQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:37:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:37:19 +0000
Subject: [Koha-bugs] [Bug 16447] "Borrow Permission" should not be used
	anymore
In-Reply-To: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16447-70-8H487SKQAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:37:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:37:43 +0000
Subject: [Koha-bugs] [Bug 16448] Perlcritic errors introduced by 12478
In-Reply-To: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16448-70-74dEVg2Jwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:38:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:38:46 +0000
Subject: [Koha-bugs] [Bug 16451] Fix missing body id in orders_by_budget.tt
In-Reply-To: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16451-70-XcI9aVuBMS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:39:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:39:03 +0000
Subject: [Koha-bugs] [Bug 16453] Elasticsearch tests should be skipped if
 configuration entry missing
In-Reply-To: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16453-70-iIg5UWAzHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:39:16 +0000
Subject: [Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
In-Reply-To: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16489-70-0O0WgHo3xU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:53:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:53:26 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-9aCoJlysLZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Chris Kirby <christopherlawrencekirby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49939|0                           |1
        is obsolete|                            |
  Attachment #49940|0                           |1
        is obsolete|                            |

--- Comment #17 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
Created attachment 51515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51515&action=edit
Bug 9543 - Show patrons messaging subscription on holds notification

Display an information about a patron's messaging preferences if an item
is checked in where the patron has put a hold.

To test:

- Apply patch
- Make sure that SMS driver and TalkingTech sysprefs are defined to
  enable SMS and Phone preferences for users (SMS driver can be a dummy
  value)
- Place a hold for a patron
- Set patron's messaging preferences to different choices (including none)
- Check in the item that is on hold (it has not to be checked out for the
  test
- Verify that below the message "Hold found (item is already waiting") an
  information appears about the patron's messaging preferences.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Chris Kirby <christopherlawrencekirby at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:53:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:53:46 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-NxVjy5zfOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #18 from Chris Kirby <christopherlawrencekirby at gmail.com> ---
Created attachment 51516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51516&action=edit
Bug 9543 - Show patrons messaging subscription on holds notification not
already waiting

Same plan as previous patch, but this one should show the message for a
hold not already waiting but not requiring a transfer (hold-found2 alert
        box)

Signed-off-by: Chris Kirby <christopherlawrencekirby at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 11:58:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 09:58:42 +0000
Subject: [Koha-bugs] [Bug 9393] Add note to circulation.pl if borrower has
 pending modifications
In-Reply-To: <bug-9393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9393-70-OjWh3IC1nS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:02:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:02:22 +0000
Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore
 "stopwords" in titles
In-Reply-To: <bug-11203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11203-70-qEjibLunrm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:06:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:06:29 +0000
Subject: [Koha-bugs] [Bug 14144] Silence warnings
	t/db_dependent/Auth_with_ldap.t
In-Reply-To: <bug-14144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14144-70-XXbbGz6iZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:21:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:21:46 +0000
Subject: [Koha-bugs] [Bug 16105] Cache::Memory is loaded even if memcache is
	used
In-Reply-To: <bug-16105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16105-70-UezPgRXvhw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16105

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:32:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:32:51 +0000
Subject: [Koha-bugs] [Bug 16526] New: Insufficient permissions to delete
 users with category type set to Staff.
Message-ID: <bug-16526-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16526

            Bug ID: 16526
           Summary: Insufficient permissions to delete users with category
                    type set to Staff.
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: r.delahunty at arts.ac.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We have set up a user category STAFF (name=Staff) which we use for staff
members. We also have set up a user category LIBRARY (name=Library) which we
use for administrative purposes. Users with category Library are assigned the
category type of Staff.
When staff with Delete_Anonymize_Patrons permissions try to delete a user with
a Library category they receive the error: "Unable to delete staff user-
insufficient privileges", but when they change the user category to one with a
Adult category type (for example), they can delete the user. Superlibrarian can
delete the user regardless of user category type.
User category type issues preventing deletion have arisen before (bug 12834).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:39:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:39:55 +0000
Subject: [Koha-bugs] [Bug 16526] Insufficient permissions to delete users
 with category type set to Staff.
In-Reply-To: <bug-16526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16526-70-icDY5RYFrn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16526

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it's by design that you can't delete users of the staff category as
they could fall easily into 'inactive' - only being used for working in Koha,
but having no checkouts. 

An easy workaround here might be to set Library to be non-staff - how are you
using this category? We usually only use staff for users with permissions to
access the staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:47:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:47:19 +0000
Subject: [Koha-bugs] [Bug 16526] Insufficient permissions to delete users
 with category type set to Staff.
In-Reply-To: <bug-16526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16526-70-b7Wqybx1Al@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16526

--- Comment #2 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
We brought over dozens of patrons used for issuing books "in transit" between
our multiple sites, as we had problems with our former LMS workflows for
in-transit functionality. We set them to be their own user category, and
assigned the STAFF category code. (Am pretty sure we have a set of "Repairs"
users with the category/category type being Library/Staff.). In post-migration
clean-up we are deleting the old-LMS workaround patrons, and stumbled across
this issue. Not a major drama as library staff can simply alter the category
type and kill off the obsolete user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 12:56:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 10:56:44 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-8sFscAMiWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51517&action=edit
Bug 16400: Use the fa-times icon for Cancel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:06:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:06:32 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-D7JQY2QhRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:06:35 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-Vgpj35d42V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51466|0                           |1
        is obsolete|                            |
  Attachment #51467|0                           |1
        is obsolete|                            |
  Attachment #51468|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51518&action=edit
Bug 16288: Remove Reference to obsolete EAN syspref

Remove reference to obsolete syspref EDIfactEAN
which was present in earlier test version of
EDI code but should not now be used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:06:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:06:41 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-9MHpqaZ3F8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51519&action=edit
Bug 16288: Remove unused EDI Shipping Budget syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:06:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:06:45 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-bMX8pEJozc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51520&action=edit
Bug 16288: (QA followup) Remove the syspref INSERT line

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:06:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:06:48 +0000
Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add
	form
In-Reply-To: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16159-70-eL6jHgN9OD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:06:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:06:49 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-QDLU7BfVVn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51521&action=edit
Bug 16288: Remove EDIInvoicesShippingBudget for devs

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:10:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:10:28 +0000
Subject: [Koha-bugs] [Bug 16216] Circulation_Branch.t doesn't set itemtype
	for test data
In-Reply-To: <bug-16216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16216-70-ZUwxfRMOyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Why is this pushed if it depends on bug 14598 (which is Signed Off) ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:12:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:12:02 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-RqgnfPG0wp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:12:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:12:05 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-mMYOg1BCOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51502|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51522&action=edit
Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'

To test:
1) Go to the tools home page. Confirm it says 'Inventory' instead of
   'Inventory/stocktaking' in heading and in description
2) Click Inventory. Confirm heading now says 'Inventory' instead of
   'Inventory/stocktaking'
3) Confirm that it now says 'Inventory' instead of
   'Inventory/stocktaking' in the tools menu along the left of the page
4) Click Help in top right corner. Confirm help heading now says
   'Inventory' instead of 'Inventory/stocktaking'
5) Go to user account page, go to Set Permissions
6) Expand Tools option and confirm it says 'inventory' instead of
   'inventory (stocktaking)'

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:12:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:12:09 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-wUfnwcfM9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51523&action=edit
Bug 16454: Remove another occurrence in comment

Note that few other occurrences exist in DB.

This patch also replaces a tab with 4 spaces.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:12:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:12:24 +0000
Subject: [Koha-bugs] [Bug 16216] Circulation_Branch.t doesn't set itemtype
	for test data
In-Reply-To: <bug-16216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16216-70-DCLwTrZNVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14598                       |
             Blocks|                            |14598


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:12:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:12:24 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-BrVydUImWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16216                       |
         Depends on|                            |16216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216
[Bug 16216] Circulation_Branch.t doesn't set itemtype for test data
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:17:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:17:33 +0000
Subject: [Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not
	responsive
In-Reply-To: <bug-16220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16220-70-M9k6OJOozM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:18:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:18:00 +0000
Subject: [Koha-bugs] [Bug 16225] Extra closing quote in circulation home
	page template.
In-Reply-To: <bug-16225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16225-70-zBc0TZUXgz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16225

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:20:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:20:47 +0000
Subject: [Koha-bugs] [Bug 16230] Show tooltip with menu item when fund
	cannot be deleted
In-Reply-To: <bug-16230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16230-70-aLGM033H2l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:21:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:21:33 +0000
Subject: [Koha-bugs] [Bug 16233] Unclosed <strong> tag in the
 opac-facets.inc breaks some display
In-Reply-To: <bug-16233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16233-70-wI4zKXY9z1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:22:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:22:36 +0000
Subject: [Koha-bugs] [Bug 16322] Translatability: "Unknown" in
 suggestion/suggestion.pl not translatable
In-Reply-To: <bug-16322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16322-70-O00SdbxUqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:24:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:24:40 +0000
Subject: [Koha-bugs] [Bug 16325] Suggestions: Tab "Status unknown" contains
 all suggestions
In-Reply-To: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16325-70-7zR8w6O4nR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:25:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:25:26 +0000
Subject: [Koha-bugs] [Bug 16384] When canceling 'edit basket',
 return to basket summary if you came from there
In-Reply-To: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16384-70-Kxm7ODVJlw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16384

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:31:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:31:35 +0000
Subject: [Koha-bugs] [Bug 16398] Keep expanded view after clearing the
	search form
In-Reply-To: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16398-70-zaMawnqM86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51524&action=edit
[3.22.x] Bug 16398: Keep the expanded view after clearing the search form

Patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:31:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:31:54 +0000
Subject: [Koha-bugs] [Bug 16398] Keep expanded view after clearing the
	search form
In-Reply-To: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16398-70-WAJlNHQhaR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:33:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:33:14 +0000
Subject: [Koha-bugs] [Bug 16415] Layout problem on staff client detail page
 if local cover images are enabled
In-Reply-To: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16415-70-g6c7r54aMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:41:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:41:25 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-hxQ01WIIfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
QA comments:
- Avoid c/p of code (use BLOCK instead)
- Correctly name the variables: key is a message_transport_type, it would make
sense to describe it better (mtt?)
- If several MTT are selected, the display is not nice: "Patron is notified:
SMS. Email. Phone."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:41:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:41:32 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-i1UE3q2jWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:46:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:46:39 +0000
Subject: [Koha-bugs] [Bug 16429] Going to circulation from notice triggers
 may change logged in branch
In-Reply-To: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16429-70-3If31ImGi3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:47:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:47:37 +0000
Subject: [Koha-bugs] [Bug 16452] PatronLists.t raises a warning
In-Reply-To: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16452-70-ulpdqFr6PC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16452

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:48:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:48:08 +0000
Subject: [Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
In-Reply-To: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16474-70-hF0DSxQ19y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:51:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:51:54 +0000
Subject: [Koha-bugs] [Bug 9387] Feedback message for FAILED check out items
 are not obvious for visually impaired
In-Reply-To: <bug-9387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9387-70-ykM0CP3gA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9387

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:56:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:56:07 +0000
Subject: [Koha-bugs] [Bug 14050] Default framework for authorities should
 not be deletable
In-Reply-To: <bug-14050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14050-70-SMwVxANSPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14050

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 51525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51525&action=edit
[3.22.x] Bug 14050: Default framework for authorities should not be deletable

Patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 13:56:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 11:56:22 +0000
Subject: [Koha-bugs] [Bug 14050] Default framework for authorities should
 not be deletable
In-Reply-To: <bug-14050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14050-70-5TNcto4APR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14050

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:01:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:01:59 +0000
Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can
	have empty line
In-Reply-To: <bug-15009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15009-70-tWfHGkMeOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:02:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:02:58 +0000
Subject: [Koha-bugs] [Bug 16211] Missing </th> tag in member.tt line 392
In-Reply-To: <bug-16211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16211-70-tDPK9tuVEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16211

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:05:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:05:38 +0000
Subject: [Koha-bugs] [Bug 16218] printfeercpt.tt (and others) does not
	include jQuery
In-Reply-To: <bug-16218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16218-70-xBaKNX8U2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16218

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:06:30 +0000
Subject: [Koha-bugs] [Bug 16253] Acq: Change "Delete order" to "Cancel order
 line" on basket summary and receive page
In-Reply-To: <bug-16253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16253-70-evw3xM3Qz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16253

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:08:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:08:48 +0000
Subject: [Koha-bugs] [Bug 16270] Typo authentification vs authentication in
	404
In-Reply-To: <bug-16270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16270-70-v877ZP6Zq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16270

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:09:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:09:59 +0000
Subject: [Koha-bugs] [Bug 16340] JS variable in opac-bottom.inc is declared
	two times
In-Reply-To: <bug-16340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16340-70-3dOfGK5cQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:17:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:17:26 +0000
Subject: [Koha-bugs] [Bug 16381] Fix capitalization on tags review page
In-Reply-To: <bug-16381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16381-70-Hil5f2va8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:20:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:20:31 +0000
Subject: [Koha-bugs] [Bug 16408] Fix UsageStats.t
In-Reply-To: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16408-70-juwCpIePV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:25:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:25:42 +0000
Subject: [Koha-bugs] [Bug 16439] Allow styling to button for upload local
 cover images (Font Awesome Icons)
In-Reply-To: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16439-70-DZrzihMUrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:26:59 +0000
Subject: [Koha-bugs] [Bug 16473] Tiny typo: there was _an_ problem ...
In-Reply-To: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16473-70-5pKrrjpDW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:30:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:30:05 +0000
Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists
 interface strangely worded
In-Reply-To: <bug-15403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15403-70-q6uSgrSZNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:30:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:30:11 +0000
Subject: [Koha-bugs] [Bug 16480] Unclosed tag <span> in shelves on intranet
In-Reply-To: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16480-70-Msku2wLapX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:45:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:45:20 +0000
Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in
	list context
In-Reply-To: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16154-70-UZrLmqGMZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #36 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:56:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:56:16 +0000
Subject: [Koha-bugs] [Bug 16527] New: Stick due date calendar unexpected
	behaviour
Message-ID: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

            Bug ID: 16527
           Summary: Stick due date calendar unexpected behaviour
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Seeing a few things here that seem unexpected:

1 - Set a date and click "Remember for session" and checkout a book
2 - Click the calendar to change date, today's date is highlighted, not the
current selection
3 - Select a new date, make sure 'remember for session is still checked' and
checkout a book
4 - The book recieves the correct due date, however, the new date is not
remembered, reverts to last saved date
5 - Attempt to set a due date prior to current date, the notice that pops up
reverts to the last saved date and not the selected date

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:56:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:56:25 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-JOSs6DD5Er@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Stick due date calendar     |Sticky due date calendar
                   |unexpected behaviour        |unexpected behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 14:58:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 12:58:00 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-QD99u1C4tn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #67 from Julian Maurice <julian.maurice at biblibre.com> ---
Follow-up pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:08:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:08:09 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-UdjYG0ZWLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:19:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:19:39 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-Ycabnu2dgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51476|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51526&action=edit
Bug 16505: <collection> is missing the marc namespace and updates fail if -x is
passed

Using rebuild_zerba.pl with the -x option switch, produces an incorrect output
in
terms of what our XSLTs expect for indexing. This patch introduces the right
namespace information
on the exported records so indexing succeeds.

To test:
- On current master, have some records on your db
- Run:
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
=> you will get a message like this:

NOTHING cleaned : the export /tmp/NL5ufjUfpp has been kept.

- Run
  $ less /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: The first line looks like this

<?xml version="1.0" encoding="UTF-8"?><collection><record

- Now run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: No output
- Apply the patch
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
- Take a look at the result file:
  $ less /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: The start of the file looks like this:
<?xml version="1.0" encoding="UTF-8"?><collection
xmlns="http://www.loc.gov/MARC21/slim">

- Run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: There is actually indexing data :-D
- Sign off :-D

Edit: I changed qq{} for q{} as suggested by Jonathan.

Sponsored-by: American Numismatic Society

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:41:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:41:58 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-kvre2xImh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50348|0                           |1
        is obsolete|                            |
  Attachment #50349|0                           |1
        is obsolete|                            |
  Attachment #50350|0                           |1
        is obsolete|                            |
  Attachment #50351|0                           |1
        is obsolete|                            |
  Attachment #50352|0                           |1
        is obsolete|                            |
  Attachment #50353|0                           |1
        is obsolete|                            |
  Attachment #50354|0                           |1
        is obsolete|                            |

--- Comment #170 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51527&action=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
    ArticleRequestsMandatoryFields
    ArticleRequestsMandatoryFieldsItemsOnly
    ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:15 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-Zi1Z2SmbGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #171 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51528&action=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:19 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-FCnFXv8j6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #172 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51529&action=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:23 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-suvwwuSG62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #173 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51530&action=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:28 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-n1jR1eeVPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #174 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51531&action=edit
Bug 14610 [QA Followup] - Get rid of separate scripts just for creating new
requests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:33 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-c947LWs0iI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #175 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51532&action=edit
Bug 14610 [QA Followup] - Switch from Koha::Borrower to Koha::Patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:43 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-J0SDijvaf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #177 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51534&action=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 15:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 13:42:37 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-4BJ9dndxNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #176 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51533&action=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 16:48:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 14:48:25 +0000
Subject: [Koha-bugs] [Bug 16528] New: Add ability to parallel process fines
	to fines.pl
Message-ID: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

            Bug ID: 16528
           Summary: Add ability to parallel process fines to fines.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On very large sites with thousands of overdue items, fines.pl may take an
incredibly long time to complete. It may be possible to speed up fines.pl by
allowing it to fork children that run in parallel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 16:48:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 14:48:33 +0000
Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to
	fines.pl
In-Reply-To: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16528-70-Rzy5jX4go5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 16:48:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 14:48:56 +0000
Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to
	fines.pl
In-Reply-To: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16528-70-qARA1OKBgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51535&action=edit
[WIP] Bug 16528 - Add ability to parallel process fines to fines.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 16:56:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 14:56:10 +0000
Subject: [Koha-bugs] [Bug 16529] New: Clean up and improve upload template
Message-ID: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

            Bug ID: 16529
           Summary: Clean up and improve upload template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/tools/upload.pl
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The file upload template has a few issues to be fixed:

- use of 'onclick' should be corrected
- markup errors should be fixed
- layout should be adjusted based on whether the page is displaying in a popup
or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:14:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:14:54 +0000
Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to
	fines.pl
In-Reply-To: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16528-70-Wc6MIpuqKH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51535|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51536&action=edit
[WIP] Bug 16528 - Add ability to parallel process fines to fines.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:19:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:19:22 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-vRsMX9sV5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16506


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506
[Bug 16506] rebuild_zebra.pl still using USMARC as default
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:19:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:19:22 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-1RrqPcZMrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16505


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505
[Bug 16505] rebuild_zebra.pl skips updates if -x is passed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:19:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:19:32 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-8FTr4wvFdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51537&action=edit
Bug 16506: Make rebuild_zebra.pl use XML as default

This patch deprecates the -x switch, making XML the default serialization
format
used by rebuild_zebra.pl. It doesn't remove the option switch, but raises a
warning
for the end user about the deprecation so they fix their cronjobs. Later we
could remove it.

To test:
- Disable all indexing (daemon/cronjob)
- Create 2 records
- Edit one of them, delete the other one
- Verify they are queued for updates in zebraqueue
- sudo koha-mysql kohadev
  > SELECT * FROM zebraqueue WHERE done=0
...
| 265 |                265 | specialUpdate | biblioserver |    1 | 2016-05-13
14:23:45 |
| 266 |                  1 | recordDelete  | biblioserver |    1 | 2016-05-16
14:14:33 |
| 267 |                  2 | specialUpdate | biblioserver |    1 | 2016-05-16
14:15:06 |
+-----+--------------------+---------------+--------------+------+---------------------+
- Now go to koha-shell
  $ sudo koha-shell kohadev ; cd kohaclone
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> FAIL: They contain the records you added/modified/deleted but they are in
         USMARC format
- Apply the patch
- Mark your records for indexing (in koha-mysql kohadev)
  > UPDATE zebraqueue SET done=0 WHERE id > 264
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
<WARNINGS> [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in XML format
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z -noxml

  You will get something similar to this:
<WARNINGS> [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in USMARC format
- Sign off :-D

[1] Warnings covered by a followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:19:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:19:37 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-JUHXOcbL4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51538&action=edit
Bug 16506: (Followup) remove warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:20:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:20:35 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-5nqmYgbd8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:28:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:28:46 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-hGzAcru66K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:31:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:31:28 +0000
Subject: [Koha-bugs] [Bug 16443] C4::Members::Statistics is not plack safe
In-Reply-To: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16443-70-xGL9VEnb0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:32:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:32:46 +0000
Subject: [Koha-bugs] [Bug 16455] TagsExternalDictionary does not work under
	Plack
In-Reply-To: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16455-70-kLjtgvKowC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:33:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:33:03 +0000
Subject: [Koha-bugs] [Bug 16444] C4::Tags is not plack safe
In-Reply-To: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16444-70-UTvnYoB8e1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:33:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:33:28 +0000
Subject: [Koha-bugs] [Bug 16442] C4::Ris is not plack safe
In-Reply-To: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16442-70-vVxjiCiKKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:34:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:34:07 +0000
Subject: [Koha-bugs] [Bug 16342] Placks breaks Baker and Taylor cover images
In-Reply-To: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16342-70-NMjpNvYgsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:34:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:34:23 +0000
Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe
In-Reply-To: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16441-70-m8nbS93YR4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:34:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:34:59 +0000
Subject: [Koha-bugs] [Bug 16529] Clean up and improve upload template
In-Reply-To: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16529-70-RlKpcbCQ1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51539&action=edit
Bug 16529 - Clean up and improve upload template

This patch makes some fixes and improvements to the template for Tools
-> Upload, including markup corrections, removal of 'onclick,' and
conversion of some links to styled buttons.

To test, apply the patch and go to Tools -> Upload.

- Confirm that uploading a file works correctly.
- Confirm that clicking 'Cancel' during a file upload works correctly.
- Search existing uploads.
  - Confirm that the 'Download' and 'Delete' buttons look correct and
    work correctly.
- In Administration -> MARC bibliographic framework, choose a
  framework and configure a tag subfield to use the upload plugin.
- Create or edit a bibliographic record using the framework you
  modified.
- Click the tag editor icon next to your modified subfield to trigger
  the pop-up window with the upload form.
  - Confirm that this window has a layout which is adjusted for the size
    of the window.
  - Confirm that uploading and selecting files from this window works
    correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:34:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:34:57 +0000
Subject: [Koha-bugs] [Bug 16529] Clean up and improve upload template
In-Reply-To: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16529-70-kJj65Hc8YL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:35:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:35:32 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-i0ILpaRVKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:36:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:36:16 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-Dmo5t8LTYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:36:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:36:47 +0000
Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped
In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16357-70-Eu4F7KAyvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:37:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:37:33 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-81MkvEF5Zn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:38:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:38:00 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-srQtFrg2XX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51305|0                           |1
        is obsolete|                            |

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51540&action=edit
Bug 16402: Make kohastructure.sql valid for MySQL v5.7

A primary key should not contain null value, and MySQL v5.7 is now more
strict and won't accept our errors in the DB structure.

Test plan:
  mysql < installer/data/mysql/kohastructure.sql
should work using MySQL v5.7

QA:
- letter.branchcode should not be NULL, the default (all) is an empty
string
- permissions.code should not be NULL, it's always a string

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Clean install of Ubuntu 16.05, MySQL 5.7.11
kohastructure.sql loads ok, just one warning
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:38:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:38:10 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-jkb1aFeaIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51328|0                           |1
        is obsolete|                            |

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51541&action=edit
Bug 16402: Fix fox existing installations

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:38:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:38:19 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-xok2oqg2DV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51542&action=edit
Bug 16402: (QA followup)

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:38:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:38:38 +0000
Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
In-Reply-To: <bug-15341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15341-70-z1W0YV3daj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:39:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:39:04 +0000
Subject: [Koha-bugs] [Bug 16402] Web Installation fails - Step 3 Importing
 the Database Structure
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-nImT9hL2DO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Works as expected. I added a followup to ease the task for the RM.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:39:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:39:22 +0000
Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages
 to user interface
In-Reply-To: <bug-11904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11904-70-U4EQJ29ER7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:39:46 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-HzlbT5LBJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Web Installation fails -    |DB structure cannot be
                   |Step 3 Importing the        |loaded in MySQL 5.7
                   |Database Structure          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 17:45:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 15:45:39 +0000
Subject: [Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe
In-Reply-To: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16518-70-lii7Hny9Oy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 18:06:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 16:06:30 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-reACxUX5UH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 18:06:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 16:06:32 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-zdT1AKjhZp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51526|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51543&action=edit
[SIGNED-OFF] Bug 16505: <collection> is missing the marc namespace and updates
fail if -x is passed

Using rebuild_zerba.pl with the -x option switch, produces an incorrect output
in
terms of what our XSLTs expect for indexing. This patch introduces the right
namespace information
on the exported records so indexing succeeds.

To test:
- On current master, have some records on your db
- Run:
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
=> you will get a message like this:

NOTHING cleaned : the export /tmp/NL5ufjUfpp has been kept.

- Run
  $ less /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: The first line looks like this

<?xml version="1.0" encoding="UTF-8"?><collection><record

- Now run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: No output
- Apply the patch
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
- Take a look at the result file:
  $ less /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: The start of the file looks like this:
<?xml version="1.0" encoding="UTF-8"?><collection
xmlns="http://www.loc.gov/MARC21/slim">

- Run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: There is actually indexing data :-D
- Sign off :-D

Edit: I changed qq{} for q{} as suggested by Jonathan.

Sponsored-by: American Numismatic Society

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described following test plan
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 18:28:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 16:28:13 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-bYBvKohZS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:10:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:10:56 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-lulh9JbeNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05. Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:12:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:12:28 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-5YAeOtp22U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51544&action=edit
Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not
always dropped after running Plugin.t

If you run Plugin.t, the above table will still be present (when you
did not enable UseKohaPlugins). This would trigger a warning when
running the test a second time.

Why? The uninstall call does its work not completely due to a small
inconsistency in Koha::Plugins::Handler::delete when calling run
without the enable_plugins parameter.

This patch resolves that inconsistency and also removes an unneeded skip
in Plugin.t in case the KitchenSink module already exists.
Note: This is a small fix. But I wonder if the Handler routines run and
delete should not have been implemented in Koha::Plugins::Base.
Also note that plugins/plugins-uninstall.pl will not be affacted by this
change, since it checks whether the pref is enabled before calling the
delete method.

Test plan:
[1] Do not yet install this patch.
[2] Verify that plugins are enabled in koha-conf.xml.
[3] Disable UseKohaPlugins in System Preferences!
[4] Run t/db_dependent/Plugins.t.
[5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable
    still exists. (It should have been deleted.) Remove it manually.
[6] Apply this patch.
[7] Run the test again.
[8] Verify that the table does not exist.
[9] Run the test again (without warnings).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:13:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:13:07 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-13h987uq5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:13:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:13:09 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-q5dMO55Rz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51545&action=edit
Bug 16502: Add additional test to Plugins.t

In order to verify if the delete now really works, we add one test
in Plugins.t.

Test plan:
[1] Run the test.
[2] Bonus: Comment line 63 in Plugins.t where delete is called.
    Run the test again. It should fail now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:13:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:13:19 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-AbD06K5N0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:16:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:16:30 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-N2tligTbvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Colin, Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:18:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:18:57 +0000
Subject: [Koha-bugs] [Bug 16529] Clean up and improve upload template
In-Reply-To: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16529-70-WCXSigEkVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:23:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:23:11 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-9hKuCpMc4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:23:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:23:53 +0000
Subject: [Koha-bugs] [Bug 16288] Edifact sysprefs EDIfactEAN and
 EDIInvoicesShippingBudget problems
In-Reply-To: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16288-70-RKWh6AFDo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16288

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:27:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:27:07 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-bDmXA2YqFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Owen, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:28:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:28:31 +0000
Subject: [Koha-bugs] [Bug 16259] More: Replace CGI->param with
 CGI->multi_param in list context
In-Reply-To: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16259-70-vZppWPKWfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:31:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:31:09 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-HtKEhpwwIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:35:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:35:37 +0000
Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has
	warnings
In-Reply-To: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15086-70-wBRGSLQbG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:41:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:41:26 +0000
Subject: [Koha-bugs] [Bug 16385] Fix breadcrumbs when ordering from
	subscription
In-Reply-To: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16385-70-77MmRmLHH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16385

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:44:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:44:18 +0000
Subject: [Koha-bugs] [Bug 16454] Use "inventory" instead of
	"inventory/stocktaking"
In-Reply-To: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16454-70-Yfr2Kp1niN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16454

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Aleisha, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:45:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:45:36 +0000
Subject: [Koha-bugs] [Bug 16471] Translatability: Fix issues in
	opac-password-recovery.tt
In-Reply-To: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16471-70-Gwl25X7lDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:46:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:46:47 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-qGH2eVLv0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:48:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:48:36 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-sLK4Yer1iS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:56:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:56:52 +0000
Subject: [Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22
	(April 2016)
In-Reply-To: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16460-70-BptPww4Ddv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 19:57:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 17:57:35 +0000
Subject: [Koha-bugs] [Bug 16470] Update MARC21 es-ES frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16470-70-kYW8YvoK9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16470

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks again Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:19:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:19:15 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-uWgLMLryqY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51546&action=edit
[SIGNED-OFF] Bug 16400: Update the fixFloat plugin

I have updated it just in case it fixed the issue.
I don't think there are big changes between our current version and this
one, so keep it up-to-date

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:19:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:19:18 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-kMy1haeDyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51547&action=edit
[SIGNED-OFF] Bug 16400: Let's hack the fixFloat plugin to fix our needs

On comment bug 11088 comment 2, Owen explained the problem with the
fixFloat toolbar. Since we have a hidden div, the plugin does not manage
to place the toolbar correctly.
In order to make it work, this patch adds some changes to the plugin to
add the ability to define our own offset.
When the div is extended (+, filteraction_on), the offset should be
updated to move the toolbar. Same when the div is folded (-,
filteraction_off)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:19:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:19:22 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-IFi2xP5Twu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51548&action=edit
[SIGNED-OFF] Bug 16400: Reintroduce the floating class

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:19:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:19:25 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-oPAkIagnK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51549&action=edit
[SIGNED-OFF] Bug 16400: Restore the previous stack order behavior

When updating the plugin, the stack order behavior has changed. This
patch restores the prevous behavior (not always z-index: 1000)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:19:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:19:29 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-WViq3WWNi2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51550&action=edit
[SIGNED-OFF] Bug 16400: Use the fa-times icon for Cancel

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:20:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:20:11 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-E4xZ3ORPU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51517|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:20:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:20:16 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-NEK2F9A6Z4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51471|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:20:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:20:21 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-ooYbzpBMkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51145|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:20:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:20:25 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-SW76jPX2Fp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51144|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:20:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:20:28 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-FGuGf4bL9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51043|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:21:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:21:33 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-p0gCv8Bcvq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51551&action=edit
Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

This follow-up makes some corrections to the markup of the cancel
button:

- Use <a> instead of <button> to eliminate the need for an "onclick"
  attribute.
- Remove the "cancel" class which adds unwanted padding.
- Correct the destination of the cancel button when cancelling during an
  edit (should redirect to the patron detail page).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 20:50:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 18:50:52 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-Q3HgPa586y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I don't think the output options belong in the toolbar since they are not an
"action." I think they belong in the main body of the form, probably in their
own <fieldset>.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 16 21:09:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 19:09:43 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-n3ldqM8W2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51552&action=edit
Bug 16506: (followup) Fix wrong option switch warning message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 00:58:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 May 2016 22:58:04 +0000
Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl
In-Reply-To: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15538-70-rnRzMvvZvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from Florent Mara <florent.mara at gmail.com> ---
Failed to apply this patch. Appear to be due to Koha::Borrowers now being
superseded by Koha::Patrons. 

Applying: bug_15538: Koha::Logger in longoverdue.pl
Using index info to reconstruct a base tree...
M       misc/cronjobs/longoverdue.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/longoverdue.pl
CONFLICT (content): Merge conflict in misc/cronjobs/longoverdue.pl
Failed to merge in the changes.
Patch failed at 0001 bug_15538: Koha::Logger in longoverdue.pl


Could you please provide a test plan to help validate this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 02:20:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 00:20:20 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-AvgX0ZwQoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Florent Mara <florent.mara at gmail.com> ---
Small patch. No apparent adverse effect. 
(No UT or test plan)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 02:23:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 00:23:59 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-IN6FhLI7np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 02:24:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 00:24:02 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-43bzoqDWiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51506|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51553&action=edit
Bug 16524: Use floating toolbar on item search

To test:
1) Go to item search
2) Confirm toolbar at top of page with Search button, goes down page as you
scroll
3) Confirm search button has been removed from final output fieldset
4) Confirm everything works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 02:30:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 00:30:29 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-P4S58Dzjnn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #21 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
This is looking good.

So is the purpose of this to have every Save and Submit button a scrolling
toolbar? In which cases can we just have the buttons at the bottom? Are we
going to add patches with toolbars for all the modules etc. to this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 02:33:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 00:33:45 +0000
Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl
In-Reply-To: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15538-70-AA2ftUhiys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 02:33:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 00:33:48 +0000
Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl
In-Reply-To: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15538-70-ycjWUEKgus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46470|0                           |1
        is obsolete|                            |

--- Comment #5 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51554&action=edit
bug_15538: Koha::Logger in longoverdue.pl

* Removed --verbose option and replaved verbose prints with
  $logger->info()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 03:51:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 01:51:07 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-NqRmriBJvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
I don't think every save and submit button should be in a scrolling toolbar,
but I'm not sure how we should define the rules. Right now the rule is "if the
form is big," but I'm not sure how you make that more specific.

I think our guidelines should allow for simpler forms to have simpler controls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:18:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:18:24 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-3QcLz289OU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
When did this issue appear? I think rebuild_zebra.pl is working fine in 3.20.3?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:35:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:35:52 +0000
Subject: [Koha-bugs] [Bug 16530] New: Add a circ sidebar navigation menu
Message-ID: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

            Bug ID: 16530
           Summary: Add a circ sidebar navigation menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

(Similar to the tools sidebar menu).

This is just an idea that I thought would make navigation around the circ
module a bit easier ... I realise that it changes the display of many of the
pages so I appreciate any thoughts on the upcoming patch. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:40:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:40:04 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-vWyWHhPlZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:40:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:40:07 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-8EiuG5ZesG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51555&action=edit
Bug 16530: Adding a circ sidebar navigation menu

This adds a sidebar to
circ/branchoverdues.tt
circ/circulation.tt (I also fixed up some of the indentation in this file to
make it easier to see where the divs started and ended)
circ/renew.tt
circ/returns.tt
circ/selectbranchprinter.tt
circ/transferstoreceive.tt
circ/view_holdsqueue.tt
circ/waitingreserves.tt
offline_circ/list.tt
offline_circ/process_koc.tt

To test:
1) Go to all of the above pages and confirm the sidebar menu shows up.
2) Trigger any error messages you can possibly think of (i.e. on renew.pl:
barcode does not exist). Confirm that this does not mess up the layout of the
page
3) Go to a user account page, Check out tab. (Since this is a
circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm
it looks as it usually does)
4) Decide if you like how things look or not!

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:40:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:40:18 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-VUZipWfXL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:46:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:46:17 +0000
Subject: [Koha-bugs] [Bug 16531] New: Circ overdues report is showing an
 empty table if no overdues
Message-ID: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

            Bug ID: 16531
           Summary: Circ overdues report is showing an empty table if no
                    overdues
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 51556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51556&action=edit
Empty table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:47:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:47:56 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-QY4TNVUQvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #20 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Marcel de Rooy from comment #13)
> > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> > If there is no further development(?), this might be a risk.
> 
> I can see that as blocker, Mason, would it be easy to update the plugin you
> used?

Jonathan, can you please suggest a replacement for ContentFlow, so I may
proceed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:50:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:50:22 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-l2Cs4kyQCm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:50:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:50:25 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-Je4nHCoAn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51557&action=edit
Bug 16531: Circ overdue report is showing an empty table if no overdues

To test:
1) Ensure you have no items overdue
2) Go to Circ -> Circulation reports -> Overdues
3) Notice empty table, '0 items overdue' heading
4) Apply patch and refresh page
5) Notice empty table is no longer showing and page prompts you to choose
filters to see results
6) Check out an item to a member, ensure due date is a date that has passed
(i.e. yesterday)
7) Refresh overdue report page
8) Confirm table now shows correctly with '1 items overdue' heading etc.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 06:50:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 04:50:37 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-NVEuZIA249@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:03:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:03:56 +0000
Subject: [Koha-bugs] [Bug 16532] New: Libraries and groups showing empty
 tables if nothing defined
Message-ID: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

            Bug ID: 16532
           Summary: Libraries and groups showing empty tables if nothing
                    defined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleishaamohia at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 51558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51558&action=edit
Empty groups tables

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:06:35 +0000
Subject: [Koha-bugs] [Bug 16523] Ability to choose NONE for the libraries
 limitation in authorised values
In-Reply-To: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16523-70-jo092hyvsG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51559&action=edit
Bug 16523: Groups showing empty tables if no groups defined

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:06:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:06:32 +0000
Subject: [Koha-bugs] [Bug 16523] Ability to choose NONE for the libraries
 limitation in authorised values
In-Reply-To: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16523-70-5Lme6GlfTP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:07:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:07:21 +0000
Subject: [Koha-bugs] [Bug 16523] Ability to choose NONE for the libraries
 limitation in authorised values
In-Reply-To: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16523-70-ehSNjMeOhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
  Attachment #51559|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Comment on attachment 51559
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51559
Bug 16523: Groups showing empty tables if no groups defined

Sorry! Wrong bug number

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:07:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:07:59 +0000
Subject: [Koha-bugs] [Bug 16523] Ability to choose NONE for the libraries
 limitation in authorised values
In-Reply-To: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16523-70-ZkU8B3zb9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:08:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:08:35 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-chqRAsNd69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:08:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:08:38 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-8ibnQ1g6BE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

--- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51560&action=edit
Bug 16523: Groups showing empty tables if no groups defined

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:09:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:09:05 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-372OPMG4YM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51560|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51561&action=edit
Bug 16532: Groups showing empty tables if no groups defined

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:09:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:09:17 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-blK6hntDwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:25:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:25:21 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-31zJA8HNmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51511|0                           |1
        is obsolete|                            |

--- Comment #87 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51562&action=edit
Bug 10662 - Icarus job server and Koha UI for it

<To be updated>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:27:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:27:24 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-jq5bg5MAJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51514|0                           |1
        is obsolete|                            |

--- Comment #88 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51563&action=edit
Bug 10662 - Create svc/import_oai API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:45:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:45:18 +0000
Subject: [Koha-bugs] [Bug 16259] More: Replace CGI->param with
 CGI->multi_param in list context
In-Reply-To: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16259-70-4Ulk2jlhCU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16259

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:47:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:47:59 +0000
Subject: [Koha-bugs] [Bug 1859] Notice fields: can't select multiple fields
	at once
In-Reply-To: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1859-70-yiKZ3jis5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1859

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:49:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:49:32 +0000
Subject: [Koha-bugs] [Bug 16481] Report menu has unexpected issues
In-Reply-To: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16481-70-qfOVkADRYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:57:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:57:08 +0000
Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has
	warnings
In-Reply-To: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15086-70-JWbtmQaQLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 07:59:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 05:59:57 +0000
Subject: [Koha-bugs] [Bug 16501] Remove some unneeded warns in Upload.t
In-Reply-To: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16501-70-BLESqZUtvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16501

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 08:16:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 06:16:55 +0000
Subject: [Koha-bugs] [Bug 16533] New: Prep koha-preferences script for
	/usr/sbin
Message-ID: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16533

            Bug ID: 16533
           Summary: Prep koha-preferences script for /usr/sbin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The admin/koha-preferences script is really useful. It would be even more
useful if it was moved to the /usr/sbin dir

This bug aims to achieve that goal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 08:17:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 06:17:18 +0000
Subject: [Koha-bugs] [Bug 16533] Prep koha-preferences script for /usr/sbin
In-Reply-To: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16533-70-wLKtWX8CZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16533

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 08:17:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 06:17:29 +0000
Subject: [Koha-bugs] [Bug 16533] Prep koha-preferences script for /usr/sbin
In-Reply-To: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16533-70-M0VzEXj7Ft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16533

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 08:52:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 06:52:57 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-0A18WaWazi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51562|0                           |1
        is obsolete|                            |

--- Comment #89 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51564&action=edit
Bug 10662 - Icarus job server and Koha UI for it

<To be updated>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 09:02:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 07:02:56 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-o6hKTbqFae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51564|0                           |1
        is obsolete|                            |

--- Comment #90 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51565&action=edit
Bug 10662 - Icarus job server and Koha UI for it

<To be updated>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 10:56:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 08:56:00 +0000
Subject: [Koha-bugs] [Bug 16534] New: Error when checking out already
	checked out item
Message-ID: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

            Bug ID: 16534
           Summary: Error when checking out already checked out item
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: theod at lib.auth.gr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Under very specific circumstances[1] when a librarian tries to check out an
item that is ALREADY checked out to another patron, one of these two nasty
things happen:

- If you're in Koha>=3.20.06
Software error:
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '1204321' for key
'itemnumber' at /home/koha/src/C4/Circulation.pm line 1272

- if you're in Koha<3.20.06
A DUPLICATE entry is entered in issues table


[1] according to my tests, for the issue to appear, the item must belong to (or
must be originally check out to a patron of) a DIFFERENT branch than the one
currently trying to check it out!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 11:11:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 09:11:24 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-98hUAyhfRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #1 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Steps to reproduce:

- Check out item X in patron A (item belonging to branch B1)
- Go to circulation, select patron B (from branch B2!=B1)
- Try to check-out the same item X to patron B
- You get a warning (Please confirm checkout Item X is checked out to A. Check
in and check out?). Click Yes
- You get either the Duplicate entry error / or the duplicate entry in issues
table


[update] Newer tests indicate that the only requirement to get the error is:
ITEM X must belong to a different branch than patron A/B (regardless of which
branch patron A and patron B belong to).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 11:17:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 09:17:21 +0000
Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to
	fines.pl
In-Reply-To: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16528-70-byl5kUhx6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 13:16:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 11:16:42 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-RmUEWFuy0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51537|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51566&action=edit
[SIGNED-OFF] Bug 16506: Make rebuild_zebra.pl use XML as default

This patch deprecates the -x switch, making XML the default serialization
format
used by rebuild_zebra.pl. It doesn't remove the option switch, but raises a
warning
for the end user about the deprecation so they fix their cronjobs. Later we
could remove it.

To test:
- Disable all indexing (daemon/cronjob)
- Create 2 records
- Edit one of them, delete the other one
- Verify they are queued for updates in zebraqueue
- sudo koha-mysql kohadev
  > SELECT * FROM zebraqueue WHERE done=0
...
| 265 |                265 | specialUpdate | biblioserver |    1 | 2016-05-13
14:23:45 |
| 266 |                  1 | recordDelete  | biblioserver |    1 | 2016-05-16
14:14:33 |
| 267 |                  2 | specialUpdate | biblioserver |    1 | 2016-05-16
14:15:06 |
+-----+--------------------+---------------+--------------+------+---------------------+
- Now go to koha-shell
  $ sudo koha-shell kohadev ; cd kohaclone
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> FAIL: They contain the records you added/modified/deleted but they are in
         USMARC format
- Apply the patch
- Mark your records for indexing (in koha-mysql kohadev)
  > UPDATE zebraqueue SET done=0 WHERE id > 264
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
<WARNINGS> [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in XML format
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z -noxml

  You will get something similar to this:
<WARNINGS> [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in USMARC format
- Sign off :-D

[1] Warnings covered by a followup

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
On top of Bug 16505
Work as described following test plan, usmarc default pre patch,
post patch xml default and usmarc on request.
No errors (all patchset)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 13:16:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 11:16:50 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-u6g8mid3ZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51538|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51567&action=edit
[SIGNED-OFF] Bug 16506: (Followup) remove warnings

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 13:16:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 11:16:58 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-nMbLVFmDWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51552|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51568&action=edit
[SIGNED-OFF] Bug 16506: (followup) Fix wrong option switch warning message

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 13:17:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 11:17:12 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-kPZWQrm6cU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:04:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:04:22 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-HiC84rocuO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14978

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:04:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:04:22 +0000
Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key
In-Reply-To: <bug-14978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14978-70-5jsvHkTm3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |theod at lib.auth.gr
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16534

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:09:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:09:40 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-pic0rjP3sD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This works fine, but the markup needs to be restructured:

<a href="[% IF ( budget_period_id)
%]/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[% budget_period_id %][%
ELSE %]/cgi-bin/koha/admin/aqbudgetperiods.pl[% END %]"
class="cancel">Cancel</a>

I thought that this would have triggered a warning by the QA tools because of
coding guideline 'HTML1:'

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

It's more verbose, but you have to do it this way:

[% IF ( budget_period_id) %]
    <a href="/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[%
budget_period_id %]" class="cancel">Cancel</a>
[% ELSE %]
    <a href="/cgi-bin/koha/admin/aqbudgetperiods.pl" class="cancel">Cancel</a>
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:30:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:30:18 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-atvZZf2D6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Can we do the same for libraries?

Even with no libraries defined, "[% IF libraries.size %]" always evaluates as
true. Why?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:56:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:56:44 +0000
Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates
In-Reply-To: <bug-8112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8112-70-qCNebBYKAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:57:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:57:08 +0000
Subject: [Koha-bugs] [Bug 9474] filter overdues with fines
In-Reply-To: <bug-9474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9474-70-bCbAdXjVCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 14:58:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 12:58:14 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-SA1SvmXNHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not reproduce the error with the following steps:
- Check an item (home library is L1) out to Patron P1 (from library L2)
- Check the same item out to patron P2 (from library L3)

Note that I do not use a fresh DB created from 3.20.06, it could make a
difference.

Could you please confirm you do not get any errors in the Koha log file about
the checkin? This error should not appear if the checkin has been correctly
done.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:03:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:03:32 +0000
Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open
 purchase suggestions a patron can make
In-Reply-To: <bug-15128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15128-70-4lROPqB8Wg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:04:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:04:44 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-QTDDMkrtZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Mason James from comment #20)
> (In reply to Jonathan Druart from comment #17)
> > (In reply to Marcel de Rooy from comment #13)
> > > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> > > If there is no further development(?), this might be a risk.
> > 
> > I can see that as blocker, Mason, would it be easy to update the plugin you
> > used?
> 
> Jonathan, can you please suggest a replacement for ContentFlow, so I may
> proceed

I have no idea, but reading the previous comment it seems that jcarousel or
jquery-flipster could be good candidates.
Kyle, any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:07:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:07:11 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-yx6Y6HjSjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:07:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:07:17 +0000
Subject: [Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit
	buttons
In-Reply-To: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16400-70-M5Zto6zCZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51551|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51569&action=edit
Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

This follow-up makes some corrections to the markup of the cancel
button:

- Use <a> instead of <button> to eliminate the need for an "onclick"
  attribute.
- Remove the "cancel" class which adds unwanted padding.
- Correct the destination of the cancel button when cancelling during an
  edit (should redirect to the patron detail page).

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:08:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:08:07 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-pIeHREJlyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I think we can improve this page by giving the user more information about why
nothing is displaying. I can think of two cases to plan for:

1. Nothing displays because there are no overdues. By default the overdue
report show anything which is overdue, with no filters applied by default. If
we know we're showing the unfiltered view, we can show a message which says
"There are no overdues."

2. Nothing displays because the user has applied a filter to the results. ( "[%
IF ( isfiltered ) %]" ). In this case we display a message which says something
like, "There are no overdues matching your search." This would also allow us to
display a link to "Reset filter," which is shown without this patch but isn't
with the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:14:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:14:16 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-0FoWQreJ2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51553|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51570&action=edit
[SIGNED-OFF] Bug 16524: Use floating toolbar on item search

To test:
1) Go to item search
2) Confirm toolbar at top of page with Search button, goes down page as
   you scroll
3) Confirm search button has been removed from final output fieldset
4) Confirm everything works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:14:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:14:14 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-WHj7ZRFom9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:18:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:18:29 +0000
Subject: [Koha-bugs] [Bug 16535] New: Add the date on which the suggestion
 was managed on Purchase suggestions tab
Message-ID: <bug-16535-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535

            Bug ID: 16535
           Summary: Add the date on which the suggestion was managed on
                    Purchase suggestions tab
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi,

It would be helpful if the date on wich the suggestion was managed was added on
Purchase suggestions tab on borrower account.

There is just who managed the suggestion.

This can be as like date on table in suggestion.pl

Regards

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:23:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:23:54 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-NDbFx2IBs0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #3 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
@Jonathan:

Unfortunately, I cannot reproduce anymore the error for Koha<3.20.06 because we
have upgraded both our test/production servers to 3.20.10.
All I know is that BEFORE the upgrade we had 3 cases where duplicate lines
(with the same itemnumber) were found in issues table. This means an item was
found to be checked out to two different borrowers (at the same time). (I have
a screenshot to prove it for one of them).

After discussing with the librarians, they explained that all they did was they
have checked out an already-checked out item to another patron. They DIDN'T get
any error and the item ended up to be checkout to BOTH patron. 

With 3.20.10 now, the new error that appears means that Circulation.pm TRIES to
create a duplicate line in issues (but fails), so the item is NOT checked out
to the new patron in the end (but it would have been if it wasn't for the new
unique key in the DB).

The correct behavior is the item to be checked in and then checked out to the
new patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:25:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:25:50 +0000
Subject: [Koha-bugs] [Bug 16536] New: Warn about Template Toolkit directives
 inside HTML tags
Message-ID: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

            Bug ID: 16536
           Summary: Warn about Template Toolkit directives inside HTML
                    tags
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: QA tools
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: oleonard at myacpl.org

I was testing a patch (on Bug 16525) which contained this markup:

<a href="[% IF ( budget_period_id)
%]/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[% budget_period_id %][%
ELSE %]/cgi-bin/koha/admin/aqbudgetperiods.pl[% END %]"
class="cancel">Cancel</a>

I expected it to trigger a warning by the QA tools.

My system is a gitified package install, so it seems possible that this is a
problem with my configuration. Running "prove xt" doesn't catch it either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:29:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:29:55 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: <bug-10067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10067-70-KVRXiycKJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16527


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527
[Bug 16527] Sticky due date calendar unexpected behaviour
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:29:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:29:55 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-IS5eTpnW42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10067
                 CC|                            |eivin at sysmystic.com,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It seems that it is a regression introduced by bug 10067.

I'd say that the following diff will fix it:

diff --git a/circ/circulation.pl b/circ/circulation.pl
index 66b3dcf..d7fcfbb 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -166,7 +166,7 @@ my $stickyduedate  = $query->param('stickyduedate') ||
$session->param('stickydu
 my $duedatespec    = $query->param('duedatespec')   ||
$session->param('stickyduedate');
 $duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ),
dateformat => 'iso' }); }
     if ( $duedatespec );
-my $restoreduedatespec  = $query->param('restoreduedatespec') ||
$session->param('stickyduedate') || $duedatespec;
+my $restoreduedatespec  = $query->param('restoreduedatespec') || $duedatespec
|| $session->param('stickyduedate');
 if ($restoreduedatespec eq "highholds_empty") {
     undef $restoreduedatespec;
 }

But I have no idea if it won't break bug 10067.

Eivin, could you have a look please?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067
[Bug 10067] decreaseLoanHighHolds messes with specify due date
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:30:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:30:21 +0000
Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user
 about checkouts before they request
In-Reply-To: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16463-70-6Vn0FD4ayw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |8007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
[Bug 8007] Discharge management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:30:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:30:21 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-55IrGLwjqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16463


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463
[Bug 16463] OPAC discharge page should warn the user about checkouts before
they request
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:30:25 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-0DIZoJWCeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8007
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
[Bug 8007] Discharge management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:30:25 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-IgVyAjpC2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464
[Bug 16464] If a patron has been discharged, show a message in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:36:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:36:55 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-rvDaB4djls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 51571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51571&action=edit
Bug 16200: Make 'Hold waiting too long' translatable and give it an unique
accounttype

Holds that have expired have been untranslatable in Patron's Fines-tab. Also,
they are
mixed with other type of fines with accounttype "F". This patch gives expired
holds an
own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize
this new
accounttype in order to make it translatable.

To test:
1. Make a hold and let it expire
2. Go to Patron's Fines tab
3. Change Koha's language to some other than English
4. Observe that there is a "Hold waiting too long" fine described in English
5. Apply patch
6. Make another hold and let it expire
7. Update translations
8. Find "Hold waiting too long" from your .po file
9. Translate it and install translations
10. Go back to Fines tab and observe that the new expired hold is translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:36:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:36:58 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-Y6VH31BVDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
> 4 - Search combined with other terms, results should be returned as
> expected

This step didn't work for me. I found a date of birth which should have
returned two results, "2006-08-09" and searched using the circulation quick
search for that date of birth plus the first name of one of the results,
"2006-08-09 john." No results were found.

Is that how it's supposed to work or do I misunderstand this step?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:37:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:37:49 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-vTVRPuEeaB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #2 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 51572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51572&action=edit
Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this bug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:37:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:37:47 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-srG3JYPQHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:38:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:38:04 +0000
Subject: [Koha-bugs] [Bug 16537] New: Overdue and Status triggers grammar
Message-ID: <bug-16537-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16537

            Bug ID: 16537
           Summary: Overdue and Status triggers grammar
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: nengard at gmail.com
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In the Overdue and Status triggers, there is a grammar error. Delay is the
number of days after an checkout is due before an action is triggered.

It should be "a" checkout rather than "an" checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:39:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:39:18 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-qS0kTXYZ81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Lari!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:39:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:39:35 +0000
Subject: [Koha-bugs] [Bug 16508] User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16508-70-cm7KPbu8QS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:39:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:39:38 +0000
Subject: [Koha-bugs] [Bug 16508] User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16508-70-6nQNRFWeii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51573&action=edit
Bug 16508: Updating a syspref requires parameters_remaining_permissions

And not all of parameters flags.

Test plan:
1/ Create a staff user.
2/ Go to details, select more->set permissions.
3/ Set catalogue, Manage Koha system settings (Administration panel),
manage circulation rules, and Remaining system parameters permissions.
4/ Log in as the new staff user, go to administration > system
preferences. Change a syspref and save it... it will save correctly.
5/ Log back in as superlibrarian
6/ On the 'set permissions' screen, un-check 'manage circulation rules'
and save.
7/ Log back in to the new staff user, and try to change the same
systemprefrence and save.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:39:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:39:52 +0000
Subject: [Koha-bugs] [Bug 16508] User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16508-70-NsCpBRQN84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
            Version|3.22                        |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:41:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:41:21 +0000
Subject: [Koha-bugs] [Bug 11387] "Hold waiting too long" is untranslatable
In-Reply-To: <bug-11387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11387-70-BieviXwbrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11387

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Lari Taskula <larit at student.uef.fi> ---


*** This bug has been marked as a duplicate of bug 16200 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:41:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:41:21 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-3nFvnCpcAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at pttk.fi

--- Comment #4 from Lari Taskula <larit at student.uef.fi> ---
*** Bug 11387 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:44:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:44:23 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-yO0Zhj6fqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #4 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
@Jonathan:

Can you please run:
SELECT itemnumber,COUNT(*) AS nb FROM issues GROUP BY itemnumber HAVING nb > 1;

If you get any lines, then you DO have the problem. You simple don't get the
error because you currently don't have the Unique Key constraint in the DB

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:55:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:55:51 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-keKAF5nWfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Theodoros Theodoropoulos from comment #4)
> @Jonathan:
> 
> Can you please run:
> SELECT itemnumber,COUNT(*) AS nb FROM issues GROUP BY itemnumber HAVING nb >
> 1;
> 
> If you get any lines, then you DO have the problem. You simple don't get the
> error because you currently don't have the Unique Key constraint in the DB

I have the unique key constraint.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:56:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:56:26 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-H0RNcnVtgS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Are you able to reproduce the error on a sandbox or using the master branch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 15:56:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 13:56:42 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-UjNUuvWkTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
> Even with no libraries defined, "[% IF libraries.size %]" always evaluates
> as true. Why?

Jonathan explained to me in IRC that because "libraries" is an object (from
Koha::Libraries) we should use "count" instead:

[% IF libraries.count %]...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:11:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:11:33 +0000
Subject: [Koha-bugs] [Bug 16536] Warn about Template Toolkit directives
	inside HTML tags
In-Reply-To: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16536-70-9T5dQUc7rD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
xt/tt_valid.t and the QA tools do not caught this invalid syntax because the TT
tags ([% %]) are inside the value of the attribute (surrounded by quotes).
It could be possible to add a test for the 'selected' attributes, but it would
not be exhaustive.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:18:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:18:06 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-LgggDqym6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51572|0                           |1
        is obsolete|                            |

--- Comment #5 from Lari Taskula <larit at student.uef.fi> ---
Created attachment 51574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51574&action=edit
Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this bug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:27:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:27:35 +0000
Subject: [Koha-bugs] [Bug 16536] Warn about Template Toolkit directives
	inside HTML tags
In-Reply-To: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16536-70-CUbtXzcCxz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Owen, note that the changes made by bug 16525 do not introduce translatable
issues.

With a quick hack to xt/tt_valid.t, I get:
# intranet-tmpl/prog/en/includes/doc-head-close-receipt.inc: 2
# intranet-tmpl/prog/en/includes/doc-head-close.inc: 19
# intranet-tmpl/prog/en/includes/facets.inc: 6, 6, 45
# intranet-tmpl/prog/en/includes/help-top.inc: 4
# intranet-tmpl/prog/en/includes/page-numbers.inc: 3, 4, 6
# intranet-tmpl/prog/en/modules/acqui/basket.tt: 554, 555, 556, 557, 558, 559,
560, 562
# intranet-tmpl/prog/en/modules/acqui/parcels.tt: 132, 138, 142
# intranet-tmpl/prog/en/modules/acqui/transferorder.tt: 125
# intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: 383
# intranet-tmpl/prog/en/modules/admin/categories.tt: 92
# intranet-tmpl/prog/en/modules/admin/preferences.tt: 121
# intranet-tmpl/prog/en/modules/authorities/authorities.tt: 321
# intranet-tmpl/prog/en/modules/basket/basket.tt: 6
# intranet-tmpl/prog/en/modules/catalogue/subject.tt: 31
# intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: 437, 629
# intranet-tmpl/prog/en/modules/circ/printslip.tt: 14
# intranet-tmpl/prog/en/modules/circ/waitingreserves.tt: 139
# intranet-tmpl/prog/en/modules/members/moremember-print.tt: 8
# intranet-tmpl/prog/en/modules/members/moremember-receipt.tt: 6
# intranet-tmpl/prog/en/modules/members/printfeercpt.tt: 7
# intranet-tmpl/prog/en/modules/members/printinvoice.tt: 5
# intranet-tmpl/prog/en/modules/reports/stats_screen.tt: 23, 25
# intranet-tmpl/prog/en/modules/reserve/request.tt: 847
# intranet-tmpl/prog/en/modules/suggestion/suggestion.tt: 458, 459
# intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: 415, 423, 432
# opac-tmpl/bootstrap/en/includes/doc-head-close.inc: 4
# opac-tmpl/bootstrap/en/includes/opac-facets.inc: 9, 11, 54
# opac-tmpl/bootstrap/en/includes/page-numbers.inc: 5, 11, 15
# opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: 39, 41
# opac-tmpl/bootstrap/en/modules/opac-advsearch.tt: 138
# opac-tmpl/bootstrap/en/modules/opac-detail.tt: 427, 429, 437, 439, 448, 450,
459, 461, 965, 967, 1072, 1081
# opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: 48, 52
# opac-tmpl/bootstrap/en/modules/opac-review.tt: 41
# opac-tmpl/bootstrap/en/modules/opac-showreviews.tt: 8, 82
# opac-tmpl/bootstrap/en/modules/sco/help.tt: 6
# opac-tmpl/bootstrap/en/modules/sco/printslip.tt: 4
# opac-tmpl/bootstrap/en/modules/sco/sco-main.tt: 7

I had a quick look at them and have not seen any problems with them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:28:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:28:13 +0000
Subject: [Koha-bugs] [Bug 16536] Warn about Template Toolkit directives
	inside HTML tags
In-Reply-To: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16536-70-MBk6noVXRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The "quick hack" is

diff --git a/xt/tt_valid.t b/xt/tt_valid.t
index 7285019..c335bb9 100755
--- a/xt/tt_valid.t
+++ b/xt/tt_valid.t
@@ -46,9 +46,12 @@ my $checkers = [
         description => 'TT syntax: not using TT directive within HTML tag',
         check => sub {
             my ($self, $name, $token) = @_;
+            push @{$self->{errors}->{$name}}, $token->{_lc} if exists
$token->{_string} and $token->{_string} =~ m|\[%\s*IF|;
             my $attr = $token->{_attr};
             next unless $attr;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:30:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:30:09 +0000
Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc
 modification template management
In-Reply-To: <bug-16148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16148-70-ncNoWaKZLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:30:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:30:11 +0000
Subject: [Koha-bugs] [Bug 16148] Revised layout and behavior of marc
 modification template management
In-Reply-To: <bug-16148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16148-70-CTVPPlKPnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49603|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51575&action=edit
Bug 16148 - Revised layout and behavior of marc modification template
management

This patch makes changes to the layout and behavior of the marc
modification template management page to make it adhere better to common
interaction patterns in Koha.

- The initial view shows a list of templates rather than pre-selecting
  the first available template for editing.

- A toolbar has been added with a "New template" button.

- The initial view of existing templates has an actions menu containing
  menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't
  appear to be possible to edit an existing template's name.

- The "Create template" form is no longer shown all the time.
  - Clicking the "New template" toolbar button triggers a modal with the
    form for creating a template. An existing template can be chosen to
    duplicate.
  - Choosing "Duplicate" from one of the template menus triggers the
    "New template" modal and preselects the corresponding template in
    the "duplicate" <select>.

- When editing actions for a template:
  - The breadcrumbs menu now reflects that a template is being modified.
  - The template name has been added as a heading.
  - A "New action" button appears in the toolbar
  - The "Edit" and "Delete" links now have a Bootstrap button style.
  - The add/edit form is now hidden by default.
  - Clicking "New action" or "edit" shows the add or edit form.
  - Clicking "Cancel" in the add/edit form hides the form.

To test, apply the patch and clear your cache if necessary.

- Got to Tools ->  MARC modification templates
- Test the "New template" button.
  - Confirm that new template creation works.
  - Confirm that duplicating a template works.
- Test the menu items in the "Actions" menu:
  - "Duplicate" should trigger the new template modal and preselect the
    template you chose to duplicate. Confirm that the template is
    successfully duplicated.
  - "Delete" should prompt you to confirm the deletion. Test both
    cancelling and confirming this operation.
  - "Edit actions" should load the page for adding or editing actions to
    a template. Test the operations on this page: New action, edit,
    delete, changing action order.

    Note that this patch does not fix Bug 15814, so action descriptions
    must still not contain single quotes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:36:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:36:14 +0000
Subject: [Koha-bugs] [Bug 16536] Warn about Template Toolkit directives
	inside HTML tags
In-Reply-To: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16536-70-OeE5DFYIUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
So our coding guideline, "HTML1: Template Toolkit markup inside HTML" is too
broad?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 16:40:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 14:40:15 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-ty1YRuloi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #3)
> Ahh, I bet it's truncating it to compare it to "single_holidays" and
> "exception_holidays"... right... that makes sense.
> 
> In that case, before truncating it, I think you have to turn it into a
> "floating" DateTime. 
> 
> Except that we're using the Timezone in single_holidays() and
> exception_holidays()... that's great...
> 
> I think we might need to re-think Koha::Calendar in light of
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

Hey, where's the patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 17:18:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 15:18:49 +0000
Subject: [Koha-bugs] [Bug 16536] Warn about Template Toolkit directives
	inside HTML tags
In-Reply-To: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16536-70-ygPpP73l0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #4)
> So our coding guideline, "HTML1: Template Toolkit markup inside HTML" is too
> broad?

To avoid translatability  issues, yes.
But if you look at the different places where it is used, it does not ease the
readability. So I think it's good to keep it like that (unless specific cases
where it could be useful) even if we do not have a check to catch them.

Or we could fix all the occurrences and add a new check :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 17:29:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 15:29:36 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-Ymbm0XvUVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #7 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
I couldn't reproduce it in a testing environment running v3.22.06.005

But I reproduced it several times in our production/test systems running
v3.20.10
Maybe(?) it's also related to a system preference that we have and/or
patron/item specific value.

(I also created MT18564, I'll give you login details for our test server and
example patron/items for you to play with)

Thank you for your time. Oh, and I forgot to mention that credits also go to
Fridolin Somers for pointing out that we still had items in this status and
identifying them to us. When we first encountered the issue, we fixed it from
Koha GUI. Thinking that it was a one-of issue, we didn't pay much attention to
it until it happened another 2 times in a short period of time.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 17:54:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 15:54:52 +0000
Subject: [Koha-bugs] [Bug 16533] Prep koha-preferences script for /usr/sbin
In-Reply-To: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16533-70-c29aWapSQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16533

--- Comment #1 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Given how the instances configuration currently works, I think we'll have to
put a small wrapper around this. That may be as easy as: koha-shell $1 -c
"/usr/share/koha/bin/admin/koha-preferences $@"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 17:54:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 15:54:58 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-MTy8cxniwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 17:59:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 15:59:56 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-RQkcJvJsQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51493|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51576&action=edit
Bug 16520: Allow per-VirtualHost environment variables with Plack

This allows MEMCACHED_*, OVERRIDE_SYSPREF_* and others to work properly.

Test plan:

  1) Add the following line to your plack.psgi (near the bottom, just
     above "mount ..."):
       enable "+Koha::Middleware::Plack";
  2) Load the OPAC advanced search page (under Plack). The title should
    read "Koha online catalog" (or whatever your LibraryName syspref
    contains).
  3) Add the following to your Apache configuration:
       RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\,
Potato"
  4) Restart Apache.
  5) Refresh. The title should now read "Potato, Potato online catalog".

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:00:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:00:04 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-LhplHsfpsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51494|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51577&action=edit
Bug 16520: Initialize the sysprefs Koha::Cache on demand

This is needed so that the cache singleton doesn't get created before
the MEMCACHED_* environment variables are set.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:00:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:00:10 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-qR5ZQYmAav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51495|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51578&action=edit
Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files

This was not added to the old etc/koha-httpd.conf because that file has
no infrastructure for Plack anyway.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:00:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:00:17 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-AdxHM6EJsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51496|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51579&action=edit
Bug 16520: Fix the Apache Plack config to load the main page through Plack

Previously, the ProxyPass would not pass the OPAC/staff homepage to
Plack. This fixes this problem (which is necessary for the other changes
on this bug to show on the main page).

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:00:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:00:23 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-AoIEUvTInV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51580&action=edit
Bug 16520: (followup) use __MEMCACHED_NAMESPACE__ where appropriate

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:07:10 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-iaU2Cbm5di@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I tested this patches and I verified they correctly make the ENV variables
reach the plack backend. Thus, the OVERRIVE_SYS* work again, and the memcached
variables are correctly set.
To verify the latter, I wrote a small patch that would go to another bug to
display memcached configuration/status in about.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:21:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:21:23 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-5p4sONcIpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #8 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
I've tested changing sysprefs in my v3.22.06.005 sandbox and it seems that one
of the following parameters is related to the error!

AutomaticItemReturn: Don't
UseBranchTransferLimits: Enforce library transfer limits based on Item type
IndependentBranches: Don't prevent
AllowReturnToBranch: Allow materials to be returned to only the library the
item is from
AutomaticItemReturn: Don't automatically transfer items to their home library
when they are returned.

@Jonathan, can you please set them in your test installation and verify if you
get the duplicate key error?

...we're getting close...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 18:34:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 16:34:02 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-M6ReweXHnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #9 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
The culprit /seems/ to be AllowReturnToBranch.

(Setting it to "Any library" prevents you from getting the error. Setting it to
"Allow materials to be returned to only the library the item is from" produces
the error)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:02:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:02:24 +0000
Subject: [Koha-bugs] [Bug 16538] New: Improve the style of progress bars
Message-ID: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

            Bug ID: 16538
           Summary: Improve the style of progress bars
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51581&action=edit
Screenshot of a progress bar before the patch

I would like to add some style to progress bars on various pages to make them 
look a little nicer. See attached for before and after screenshots.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:02:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:02:48 +0000
Subject: [Koha-bugs] [Bug 16538] Improve the style of progress bars
In-Reply-To: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16538-70-3bdSGSdXTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51582&action=edit
Screenshot of a progress bar after the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:23:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:23:41 +0000
Subject: [Koha-bugs] [Bug 16538] Improve the style of progress bars
In-Reply-To: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16538-70-m8tTnK6B7m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529
[Bug 16529] Clean up and improve upload template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:23:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:23:41 +0000
Subject: [Koha-bugs] [Bug 16529] Clean up and improve upload template
In-Reply-To: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16529-70-1xh0CFIKgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16538


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538
[Bug 16538] Improve the style of progress bars
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:25:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:25:38 +0000
Subject: [Koha-bugs] [Bug 16538] Improve the style of progress bars
In-Reply-To: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16538-70-DB0YOzAp33@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:25:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:25:40 +0000
Subject: [Koha-bugs] [Bug 16538] Improve the style of progress bars
In-Reply-To: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16538-70-V9WxNFZvH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51583&action=edit
Bug 16538 - Improve the style of progress bars

This patch updates the style of progress bars to make them a little
nicer. Progress bars in the staff client are not built in a consisten
way. Some have been updated to use the <progress> element and some have
not. This patch improves some styling common to both kinds.

Other changes:

- Redundant in-page CSS has been removed from many pages.
- An invalid "min" attribute has been removed from several instances of
  <progress>.
- Corrected capitalization.
- Fixed incorrectly quoted attributes.
- Added missing form "action" attributes.

To test, clear your browser cache if necessary. Apply the patch and
test uploads on the following pages:

- Circulation -> Offline circulation file upload
- Tools -> Batch item modification
- Tools -> Batch record modification
- Tools -> Stage MARC records for import
- Tools -> Manage staged MARC records
- Tools -> Upload local cover image
- Tools -> Upload

In all cases, progress bars should look improved and work correctly.

Test Tools -> Batch item deletion. Unused background job handling markup
has been removed. Deletion processing should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:36:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:36:09 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-4aL3Y0wikO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:36:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:36:12 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-0VNaTW0woh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48760|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51584&action=edit
Bug 16001 - Use standard message dialog when there are no cities to list

If there are no existing cities in Administration -> Cities and Towns,
the message saying so should be in the standard message dialog.

Another minor change: Edit the message to say "There are no cities
defined," which I think reads better in English.

To test you must have no cities and towns defined.

Apply this patch and go to Administration -> Cities and Towns. You
should see a message displayed in a standard "message" style dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:38:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:38:36 +0000
Subject: [Koha-bugs] [Bug 16539] New: Koha::Cache is incorrectly caching
	single holidays
Message-ID: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

            Bug ID: 16539
           Summary: Koha::Cache is incorrectly caching single holidays
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 14522 introduced caching for single_holidays, however, when rebuilding the
cache it is using self->branchcode to populate all of the holidays for the
cache.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:42:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:42:27 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-WBGARddnUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:42:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:42:53 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-Sr4ZQJGOvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:42:55 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-eHONB31bBR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51585&action=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:42:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:42:56 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-4FmYOY2VpF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51292|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:43:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:43:48 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-2RWhkyaDte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14522
           Priority|P5 - low                    |P3
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com
           Severity|enhancement                 |blocker


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522
[Bug 14522] Use Koha::Cache for accessing single_holidays()
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:43:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:43:48 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: <bug-14522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14522-70-plw6RizKrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539
[Bug 16539] Koha::Cache is incorrectly caching single holidays
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:51:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:51:21 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-UlhpqCePqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:51:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:51:25 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-Rl2nHeZ98k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51586&action=edit
Bug 16336 [Revised] UX of holds patron search with long lists of results

Bug 15793 made a change to an interface which is also found in the place
hold template. This patch creates a new include file to be used by both
circulation.tt and request.tt so that these pages do not diverge.

In the process, this patch removes some markup and JavaScript which was
made obsolete by Bug 15793 and should have been removed.

This patch also revises the sorting of the results table so that the
patron name is sortable (Bug 16334) and the default sort is on card
number (matching 3.20.x and 3.22.x).

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- The table of results which displays should look correct and work
  correctly, including DataTables sorting.
- Clicking any table row should forward you to the checkout page for
  that patron.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the table of patron results looks correct and works
  correctly.
- Clicking any table row should forward you to the place hold page for
  that patron and the title you selected.

Revision: Although the table row was clickable, you couldn't
middle-click it to open the link in a new tab. The patron name is now a
real link you can middle-click or right-click. The row is still
clickable as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 17 20:51:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 18:51:39 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-FMxmDRuCPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51585|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51587&action=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 01:50:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 23:50:54 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-0f6DxNU3A0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 01:50:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 23:50:57 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-ZEqnmSsEQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51587|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51588&action=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 01:54:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 May 2016 23:54:49 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-NcQOQY2nLw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #5)
> Hey, where's the patch?

I've been too busy working on other projects :/. 

While I might have time to write a patch, I don't have anywhere near the time
to test it or write a comprehensive test plan for others to use... :/.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:19:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:19:13 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-0b6sqIAYEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am trying to install Koha on Ubuntu 16.05 and I can't finish the web
installer. After the tables are created (and they are), the web installer is
stuck with this error:

[Warning] Using a password on the command line interface can be insecure.

You can't continue to choose the sample data, install the mandatory data etc. 

Leaving this here for now - if needed I can file a new bug report tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:21:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:21:05 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-fOFzoGs3qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #20)
> I am trying to install Koha on Ubuntu 16.05 and I can't finish the web
> installer. After the tables are created (and they are), the web installer is
> stuck with this error:
> 
> [Warning] Using a password on the command line interface can be insecure.
> 
> You can't continue to choose the sample data, install the mandatory data
> etc. 
> 
> Leaving this here for now - if needed I can file a new bug report tomorrow.

There's a bug filled for that already, it mentions mysql 5.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:23:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:23:57 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-Y8NYkVqhzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13669

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:23:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:23:57 +0000
Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-WrPjFpv5tA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16402

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:27:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:27:20 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-pHCklYiuFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
bug 13669 doesn't mention the error - was this the one you were thinking about?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:27:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:27:25 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-6CcrZGQB43@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #6)
> (In reply to Tom?s Cohen Arazi from comment #5)
> > Hey, where's the patch?
> 
> I've been too busy working on other projects :/. 
> 
> While I might have time to write a patch, I don't have anywhere near the
> time to test it or write a comprehensive test plan for others to use... :/.

If you write a patch, I write regression tests for it :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 02:28:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 00:28:47 +0000
Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7
In-Reply-To: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16402-70-mjEaNCUeBf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #22)
> bug 13669 doesn't mention the error - was this the one you were thinking
> about?

The first comment explains the failure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 03:12:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 01:12:23 +0000
Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl
In-Reply-To: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15538-70-K60Zooi0ms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Florent Mara <florent.mara at gmail.com> ---
Applied the following SQL to create a long overdue item and got the expected
log print out in stdout.

INSERT INTO biblio(frameworkcode, datecreated) values ('allo', '2016-05-17');
INSERT INTO biblioitems(biblionumber, volume) value ((SELECT biblionumber FROM
biblio WHERE frameworkcode = 'allo'), 'blah');
INSERT INTO items(biblionumber, biblioitemnumber, barcode) values (1, (SELECT
biblioitemnumber FROM biblioitems WHERE volume = 'blah'), 'barcode');
INSERT INTO items(biblionumber, biblioitemnumber, barcode) values (1, (SELECT
biblioitemnumber FROM biblioitems WHERE volume = 'blah'), 'latecode');
INSERT INTO borrowers(surname, address, city, branchcode, categorycode) values
('surname', 'address', 'city', 'CPL', 'B');


INSERT INTO issues (borrowernumber, itemnumber, date_due) values (
(SELECT borrowernumber FROM borrowers WHERE surname = 'surname'), 
(SELECT itemnumber FROM items WHERE barcode = 'barcode'), '2016-05-17'); 

INSERT INTO issues (borrowernumber, itemnumber, date_due) values (
(SELECT borrowernumber FROM borrowers WHERE surname = 'surname'), 
(SELECT itemnumber FROM items WHERE barcode = 'latecode'), '2015-07-17');

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 03:58:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 01:58:40 +0000
Subject: [Koha-bugs] [Bug 16410] koha-remove should optionally remove an
 instance's database and db-user
In-Reply-To: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16410-70-JiZOemiSta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16410

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mason James from comment #0)
> It would be useful if koha-remove optionally removed an instance's database
> and db-user
> 
> more info to come...

well, koha-remove already does this :0)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 04:06:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 02:06:21 +0000
Subject: [Koha-bugs] [Bug 13902] Add --force option to koha-create and
 koha-remove commands
In-Reply-To: <bug-13902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13902-70-tNmbJtHxvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

--- Comment #2 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mason James from comment #1)
> (In reply to Mason James from comment #0)
> > Add --force option to koha-create and koha-remove commands
> 
> hmm, i had an interesting experience related to this BZ...
> 
> 
> a koha-remove failed to delete a /etc/koha/sites/aaa1 dir, as the dir
> contained an unexpected foo.backup file
> 
> on a reboot, the /etc/init.d/koha-common script then failed to run
> koha-create-dirs on all other koha instances alphabetically after 'aaa1'
> 
> this caused zebrasrv to fail on all following instances?!

this BZ is basically a dupe of bug 16291

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 04:06:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 02:06:54 +0000
Subject: [Koha-bugs] [Bug 13902] Add --force option to koha-create and
 koha-remove commands
In-Reply-To: <bug-13902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13902-70-sZQHTAk7lg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---


*** This bug has been marked as a duplicate of bug 16291 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 04:06:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 02:06:54 +0000
Subject: [Koha-bugs] [Bug 16291] koha-remove --purge should also delete
 '/etc/koha/sites/$instance' dir
In-Reply-To: <bug-16291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16291-70-sBbkJuoEY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
*** Bug 13902 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 04:26:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 02:26:13 +0000
Subject: [Koha-bugs] [Bug 10517] kohe-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10517-70-VSMhEzXApr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
any chance a new patch could be added in a diff/patch format?

 https://en.wikipedia.org/wiki/Diff_utility

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 06:26:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 04:26:47 +0000
Subject: [Koha-bugs] [Bug 16540] New: Translatability in opac-auth.tt
 (tag-isolated word 'Logout')
Message-ID: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

            Bug ID: 16540
           Summary: Translatability in opac-auth.tt (tag-isolated word
                    'Logout')
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

In opac-auth.tt, the sentence 'Logout and try with a different user' is
splitted by a-tags. It is difficult to determine the translation of the
isolated word 'Logout' (e.g. in German: 'Abmeldung' or 'Abmelden' or 'Melden
Sie sich ab')

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 08:13:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 06:13:08 +0000
Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-jaQEt2Dhhd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
           Severity|major                       |blocker

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Yeah this is a blocker for release I reckom

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 08:17:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 06:17:08 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails on MySQL 5.6 and .7
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ODfjPul6ff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Webinstaller fails on MySQL |Web installer fails on
                   |5.6                         |MySQL 5.6 and .7
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This means people can't install on current the current Ubuntu LTS - we really
need to fix it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 11:09:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 09:09:32 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-ubU1qAPLTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51571|0                           |1
        is obsolete|                            |

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 51589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51589&action=edit
Bug 16200: Make 'Hold waiting too long' translatable and give it an unique
accounttype

Holds that have expired have been untranslatable in Patron's Fines-tab. Also,
they are
mixed with other type of fines with accounttype "F". This patch gives expired
holds an
own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize
this new
accounttype in order to make it translatable.

To test:
1. Make a hold and let it expire
2. Go to Patron's Fines tab
3. Change Koha's language to some other than English
4. Observe that there is a "Hold waiting too long" fine described in English
5. Apply patch
6. Make another hold and let it expire
7. Update translations
8. Find "Hold waiting too long" from your .po file
9. Translate it and install translations
10. Go back to Fines tab and observe that the new expired hold is translated

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 11:12:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 09:12:25 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-2i2IgoKyKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51574|0                           |1
        is obsolete|                            |

--- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 51590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51590&action=edit
Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this buug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 11:12:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 09:12:50 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-FH05k6vMqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 12:43:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 10:43:41 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-dOzwBokXgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Theodoros Theodoropoulos from comment #9)
> The culprit /seems/ to be AllowReturnToBranch.
> 
> (Setting it to "Any library" prevents you from getting the error. Setting it
> to "Allow materials to be returned to only the library the item is from"
> produces the error)

So do you think in this case Koha should not allow to perform the
checkin+checkout ? Since checkin needs a transfer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 13:38:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 11:38:25 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-HxeL82rzcQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #11 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
> So do you think in this case Koha should not allow to perform the
> checkin+checkout ? Since checkin needs a transfer.

Well, this sounds like the correct way to go...

In any case, the process should not try to chekout the item to another patron
(and try to create the duplicate line in the issues table) because the checkin
process (no matter what the reason) was not complete.

[Hmm... Maybe add an extra step in the checkin process to check if the checkin
process completed without errors and only then proceed with the checkout?]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 14:02:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 12:02:58 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails on MySQL 5.6 and .7
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ZMsxchpzRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 14:29:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 12:29:21 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-VndbQfv4BE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 14:29:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 12:29:23 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-UEl65whMNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51461|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51591&action=edit
[SIGNED-OFF] Bug 16511: Making contracts actions buttons

To test:
1) Go to Acqui -> find a vendor
2) On Vendor details page (supplier.pl) confirm that Contracts table now
   has one column called Actions
3) Confirm that Edit and Delete show as buttons
4) Confirm that buttons don't wrap on a narrower browser
5) Click Contracts tab
6) Confirm Actions column, Edit and Delete buttons, and button's don't
   wrap

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 14:42:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 12:42:10 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-y0vQ4VgvXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This works great in the staff client, but what about the OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 14:47:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 12:47:16 +0000
Subject: [Koha-bugs] [Bug 16541] New: Make edit and delete links styled
 buttons in cities administration
Message-ID: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

            Bug ID: 16541
           Summary: Make edit and delete links styled buttons in cities
                    administration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/admin/cities.pl
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

In Administration -> Cities, the edit and delete buttons should be made into
Bootstrap-styled buttons with Font Awesome icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 14:51:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 12:51:49 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-53lPtBAjdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Web installer fails on      |Web installer fails to load
                   |MySQL 5.6 and .7            |sample data on MySQL 5.6+

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:16:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:16:25 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-9n3ScuPSRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It seems that using MySQL v5.7, the web installer fails on step 3 with "using a
password on command line interface can be insecure".
I don't think we can fix that modifying Koha code.
I think we should remove the password from the command line execute in
C4::Installer::load_sql and let the administrators set a config file containing
the password.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:25:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:25:54 +0000
Subject: [Koha-bugs] [Bug 16542] New: Make edit and delete links styled
 buttons in patron categories administration
Message-ID: <bug-16542-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16542

            Bug ID: 16542
           Summary: Make edit and delete links styled buttons in patron
                    categories administration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/admin/cities.pl
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org

In Administration -> Patron categories, the edit and delete buttons should be
made into Bootstrap-styled buttons with Font Awesome icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:26:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:26:04 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-o3KH88bp9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:26:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:26:08 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-143tSYOZfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51591|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51592&action=edit
Bug 16511: Making contracts actions buttons

To test:
1) Go to Acqui -> find a vendor
2) On Vendor details page (supplier.pl) confirm that Contracts table now
   has one column called Actions
3) Confirm that Edit and Delete show as buttons
4) Confirm that buttons don't wrap on a narrower browser
5) Click Contracts tab
6) Confirm Actions column, Edit and Delete buttons, and button's don't
   wrap

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:26:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:26:42 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-YGjFqicTUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Blocks|14522                       |
         Depends on|                            |14522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522
[Bug 14522] Use Koha::Cache for accessing single_holidays()
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:26:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:26:42 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: <bug-14522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14522-70-P8PrWDEjKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16539
         Depends on|16539                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539
[Bug 16539] Koha::Cache is incorrectly caching single holidays
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 15:26:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 13:26:58 +0000
Subject: [Koha-bugs] [Bug 16543] New: Make edit and delete links styled
 buttons in patron attribute types administration
Message-ID: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

            Bug ID: 16543
           Summary: Make edit and delete links styled buttons in patron
                    attribute types administration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/admin/cities.pl
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org

In Administration -> Patron attribute types, the edit and delete buttons should
be made into Bootstrap-styled buttons with Font Awesome icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 16:01:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 14:01:37 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-dn8FsyZfvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51593&action=edit
Bug 16539: Try to provide tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 16:02:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 14:02:17 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-VBmR9kolHY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, I have tried to provide tests for this change, but they pass even without
your patch.
Could you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 16:10:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 14:10:02 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-x5G2KtvxPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 16:10:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 14:10:05 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-EcMdSiDKaq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51570|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51594&action=edit
Bug 16524: Use floating toolbar on item search

To test:
1) Go to item search
2) Confirm toolbar at top of page with Search button, goes down page as
   you scroll
3) Confirm search button has been removed from final output fieldset
4) Confirm everything works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 16:25:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 14:25:41 +0000
Subject: [Koha-bugs] [Bug 16544] New: Changes to circ rules should be logged.
Message-ID: <bug-16544-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544

            Bug ID: 16544
           Summary: Changes to circ rules should be logged.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

At present, changes to circulation rules are not logged. This means that there
is no way to determine what circulation rules were in effect at a given time,
which makes historical trouble-shooting impossible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 17:23:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 15:23:56 +0000
Subject: [Koha-bugs] [Bug 13074]
 C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
In-Reply-To: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13074-70-z888njre67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 17:25:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 15:25:36 +0000
Subject: [Koha-bugs] [Bug 16428] The framework is not checked to know if a
 field is mapped
In-Reply-To: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16428-70-gTPItqQlH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 17:26:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 15:26:18 +0000
Subject: [Koha-bugs] [Bug 16424] Advanced editor reverts records back to
 Default framework
In-Reply-To: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16424-70-iO4Niw0jEL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 17:49:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 15:49:34 +0000
Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue
 conflict with each other
In-Reply-To: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14514-70-CGlJ55U9FS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 17:49:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 15:49:37 +0000
Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue
 conflict with each other
In-Reply-To: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14514-70-PBmrGMnPq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49089|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51595&action=edit
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 18:33:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 16:33:24 +0000
Subject: [Koha-bugs] [Bug 16545] New: Make edit link a styled button in item
 search results
Message-ID: <bug-16545-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545

            Bug ID: 16545
           Summary: Make edit link a styled button in item search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org

In the table of item search results the edit link should be made into a
Bootstrap-styled button with Font Awesome icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 18:34:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 16:34:22 +0000
Subject: [Koha-bugs] [Bug 16542] Make edit and delete links styled buttons
 in patron categories administration
In-Reply-To: <bug-16542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16542-70-e7Ym7ZTwk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16542

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|/cgi-bin/koha/admin/cities. |/cgi-bin/koha/admin/categor
                   |pl                          |ies.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 18:34:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 16:34:36 +0000
Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons
 in patron attribute types administration
In-Reply-To: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16543-70-j23xUteSlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|/cgi-bin/koha/admin/cities. |/cgi-bin/koha/admin/patron-
                   |pl                          |attr-types.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 18:34:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 16:34:55 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-SFPc7cdYio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 18:34:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 16:34:58 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-klOpiMtk4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51596&action=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 21:23:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 19:23:10 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-eF3YGs3x9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51596|0                           |1
        is obsolete|                            |

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51597&action=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:01:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:01:15 +0000
Subject: [Koha-bugs] [Bug 16547] New: Can't place item level hold directly
 from search results screen
Message-ID: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

            Bug ID: 16547
           Summary: Can't place item level hold directly from search
                    results screen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If you search for an item that brings up a list of results, checking the check
box and clicking the 'Place Hold' button allows you to place a hold -- but
after you've selected the patron, you can only place biblio level holds -- the
section of the 'Confirm Holds' page which usually shows to allow item level
holds is not displayed.

This is most easily demonstrated on the bywater demo machine [usernam and
password are both koha].

Search for Harry Potter:

http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=harry+potter

Click the check-box for the first search result ( Harry Potter and the Chamber
of Secrets [videorecording] ... )

Click the 'Place hold' button, which will take you to the 'Confirm hold' screen
(http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumbers=25778%2F&findborrower=&multi_hold=1)

Enter card number 55.

This takes you to a second 'Confirm hold' screen, showing a hold for 'Harry
Potter and the Chamber of Secrets' for patron Bilbo Baggins (55)... no item
information is viewable.
(http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumber=25778)

By contrast, If I start at
http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=harry+potter,
and click in to the first result page to see the details:

http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=25778&searchid=scs_1463601092892


Then click 'place hold' from the details screen, I am taken to
http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumber=25778&searchid=scs_1463601092892

Entering card number 55 at that point takes me to
http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumber=25778
... but this time item level information *is* available, and an item level hold
can be placed.

Steps to replicate on your system:

1/ Search for an item with more than one search result
2/ Select an item, click 'Place hold'
3/ Enter a patron card number
4/ Note that item level holds are not available.
5/ Run the search again
6/ Click the title to see the detail page on the same bib.
7/ Enter the same patron card number
8/ Items now show on the page, and an item level hold can be placed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:05:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:05:07 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-1eYy2pAIsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:14:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:14:38 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-yZuhUY2Pqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---
16:11 < cait> barton: koha doesn't work as login fro me to check out your
latest bug
16:13 < barton> ok, I'll check that.
16:13 < barton> thanks.
16:14 < barton> cait: sorry, it's bywater/bywater. I'll update the bug.
16:14 < cait> aah :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:23:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:23:59 +0000
Subject: [Koha-bugs] [Bug 16548] New: All libraries selected on Tools ->
 Export Data screen
Message-ID: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

            Bug ID: 16548
           Summary: All libraries selected on Tools -> Export Data screen
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In 3.22.05 when a user goes to the Tools->Export Data screen.  All the
libraries are listed and checked.  This causes two issues:
1. In a large consortium a user may need to unclick a large number of boxes to
only get the libraries they want.
2. When the tool is run as is (with all libraries selected) bibliographic
records without items are not exported.  (ebook bib records without items)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:24:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:24:21 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-zCcPeAm6Jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:35:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:35:46 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-0m04S5Qy09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Suzanne Fayle <sfayle at roseman.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sfayle at roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:36:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:36:24 +0000
Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue
 conflict with each other
In-Reply-To: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14514-70-PqaysZ253h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #10 from Barton Chittenden <barton at bywatersolutions.com> ---
t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 11/42 subtests 

Test Summary Report
-------------------
t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 42 Failed: 11)
  Failed tests:  22, 24-28, 32-34, 36, 40
  Non-zero exit status: 11
Files=1, Tests=42,  3 wallclock secs ( 0.03 usr  0.00 sys +  2.02 cusr  0.12
csys =  2.17 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:39:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:39:30 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-Wg5Ss6k6pb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51597|0                           |1
        is obsolete|                            |

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51598&action=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 22:39:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 20:39:39 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-Yud2vZ9u2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51599&action=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted

The current table creation order is left to mysql's strategy, which is not
suitable for parsing the SQL files and passing one statement at a time in
the current order.

This patch just moves table creation statements around so FK constraints are
defined for previously created tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 23:47:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 21:47:18 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-BGE30kimT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51598|0                           |1
        is obsolete|                            |

--- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51600&action=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 23:47:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 21:47:35 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-IbMd4PyiZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 23:47:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 21:47:39 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-KHW4c2xYC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51599|0                           |1
        is obsolete|                            |

--- Comment #16 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51601&action=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted

The current table creation order is left to mysql's strategy, which is not
suitable for parsing the SQL files and passing one statement at a time in
the current order.

This patch just moves table creation statements around so FK constraints are
defined for previously created tables.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 18 23:48:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 21:48:54 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-kSbYGbRqDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #17 from Chris Cormack <chris at bigballofwax.co.nz> ---
This works, but it is slow, I think that is ok though, as you only run the web
installer once :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:03:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:03:08 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-dQKiskvOkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:03:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:03:11 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-r1ZnMGByvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51337|0                           |1
        is obsolete|                            |
  Attachment #51342|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51602&action=edit
[PASSED QA] Bug 16478: Translation breaks display of Checkout history in tab
Checks / On-site-checkouts

To test:
- Make sure that syspref OnsiteCheckouts is enabled
- Log in to OPAC as a patron who has checkouts, online checkouts and checkout
history enabled
- Go to 'your reading history' (in English)
- Display all three tabs
- Apply patch
- Reload page, display oll three tabs again, there should be no difference
- Examine source code changes to verify that the words 'checkout' and 'onsite'
no longer
  will be exposed to translation.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:03:55 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-PRXyYdSKWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51603&action=edit
[PASSED QA] Bug 16478: Fix checkout history tabs - intranet

Test plan:
Same as before for the intranet.
And please retest the OPAC => I have changed the filter's values to
match OPAC/intranet

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:09:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:09:47 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-NQdhgkTvKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:09:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:09:50 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-10XwXxUpSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51491|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51604&action=edit
[PASSED QA] Bug 16517: Do not crash when creating a list with an existing name

A typo has been made during a merge conflict when rebasing bug 16517.

it should be
  eval { Koha::Object->new->store; };
instead of
  eval { Koha::Object->new; }->store;

Test plan:
>From the result list (intranet side), check some entries and add them to
a new list
Use an existing list's name
=> Without this patch you will get a server error (exception 'Duplicate shelf
object' raised by Koha::Virtualshelf->new->store)
=> With this patch you must get a friendly error message

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:30:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:30:21 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-bA2NXssJI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 00:30:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 22:30:24 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-kYYIFEjnyP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51589|0                           |1
        is obsolete|                            |
  Attachment #51590|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51605&action=edit
[PASSED QA] Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this buug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 01:45:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 23:45:43 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-iv5QcFPhb0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
           Assignee|gmcharlt at gmail.com          |oleonard at myacpl.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 01:54:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 23:54:05 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-7ASGKv2B0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 01:54:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 23:54:14 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-in4MQRWldJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51606&action=edit
Bug 16548 - All libraries selected on Tools -> Export Data screen

This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.

Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.

To test, apply the patch and go to Tools -> Export data.

- Test the select all/select none links and confirm that they work as
  expected.
- Confirm that the structural changes to the form look okay.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 01:58:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 May 2016 23:58:21 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-jJlURxGUF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I suppose another good improvement would be to rename the library selection in
such a way as to clarify that it limits based on items. "Export records with
holdings from these libraries" or something like that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 02:15:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 00:15:57 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-KohB9ElV5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

--- Comment #3 from Suzanne Fayle <sfayle at roseman.edu> ---
Or under options have a checkbox to include bibs without item records in the
export? So that checking the box would export the bibs without items.

There is wording near the top "Note : The items are exported by this tool
unless specified."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 02:38:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 00:38:53 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-54EpBKn22d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51607&action=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.7        66.5
58.6        66.0

b) SQL::SplitStatement (patch 1+2)
59.4        101
59.7        102

c) DBIx::RunSQL (patch 3)
60.7        66.8
59.4        66.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 02:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 00:40:27 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-aE1w0uxE0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #19 from Chris Cormack <chris at bigballofwax.co.nz> ---
OOhhh, that sounds a lot better, I'll test it out

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 03:21:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 01:21:04 +0000
Subject: [Koha-bugs] [Bug 16549] New: Remove the use of "onclick" from
 header search forms
Message-ID: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549

            Bug ID: 16549
           Summary: Remove the use of "onclick" from header search forms
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The header search forms use "onclick" to trigger the "keep_text()" function.
This functionality can be moved to the globally-included js file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 03:28:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 01:28:09 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-3AT2sBWEbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #20 from Chris Cormack <chris at bigballofwax.co.nz> ---
It works, but a new dependency eh? We need to update that too.

I've attached it as a signed off patch, but will let the RM and others decide
if they want to add the new dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 03:28:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 01:28:58 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-esBts6CT94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 03:29:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 01:29:01 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-hOLRaxiqzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51607|0                           |1
        is obsolete|                            |

--- Comment #21 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51608&action=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.7        66.5
58.6        66.0

b) SQL::SplitStatement (patch 1+2)
59.4        101
59.7        102

c) DBIx::RunSQL (patch 3)
60.7        66.8
59.4        66.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 03:57:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 01:57:22 +0000
Subject: [Koha-bugs] [Bug 16549] Remove the use of "onclick" from header
	search forms
In-Reply-To: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16549-70-Y8fz15Q936@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 03:57:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 01:57:26 +0000
Subject: [Koha-bugs] [Bug 16549] Remove the use of "onclick" from header
	search forms
In-Reply-To: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16549-70-GWDlVJKbmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51609&action=edit
Bug 16549 - Remove the use of "onclick" from header search forms

This patch removes the use of "onclick" from all header search forms for
the purpose of triggering the "keep_text" function. This behavior is now
handled in the globally-included JS file.

To test, apply the patch and clear your cache if necessary.

- Enter text in any header search form field. Click to each other tab
  in the header and confirm that your text is copied to each.
- Test the behavior of the header search form on at least one page where
  each is included:

  - The staff client home page
  - The advanced search page
  - The authorities home page
  - The administration home page
  - The cataloging home page
  - The checkin page
  - The circulation home page
  - The patrons home page
  - Acquisitions -> Vendor -> Contracts
  - Administration -> Cities
  - Administration -> Currencies and exchange rates
  - Administration -> Patron categories
  - Administration -> Printers (why is this page still around?)
  - Administration -> System preferences
  - Administration -> Z39.50/SRU servers
  - Tools -> Notices & slips

This patch modifies does not fix the existing (unreported) bug which
prevents the keep text function from working in the include file used on
these pages:

  - Acquisitions -> Vendor -> Basket -> New order from suggestion
  - Administration -> Budgets
  - The serials home page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 04:05:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 02:05:04 +0000
Subject: [Koha-bugs] [Bug 16550] New: Can't set opac news expiration date to
 NULL, it reverts to today
Message-ID: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

            Bug ID: 16550
           Summary: Can't set opac news expiration date to NULL, it
                    reverts to today
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 13813 changed koha-news.pl to remove use of C4::Dates

However, dt_from_string defaults to today when passed a blank value, so news
now must have an expiration date and it defaults to today

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 04:05:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 02:05:38 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-xYq67hJbWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13813
           Priority|P5 - low                    |P3


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
[Bug 13813] Remove deprecated module C4::Dates from system - first steps
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 04:05:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 02:05:38 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
 system - first steps
In-Reply-To: <bug-13813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-a1dL45wALU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16550


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550
[Bug 16550] Can't set opac news expiration date to NULL, it reverts to today
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 05:12:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 03:12:57 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-iBXdbj7eva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Chris Cormack from comment #20)
> It works, but a new dependency eh? We need to update that too.
> 
> I've attached it as a signed off patch, but will let the RM and others
> decide if they want to add the new dependency.

Yeah, it all depends on the packaging complexity. Let's add the packaging
manager to the talk.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 05:13:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 03:13:13 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-3twT9CEFBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dependency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 05:38:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 03:38:29 +0000
Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC
	using HTTPS
In-Reply-To: <bug-14523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14523-70-o9roeZEr5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vanoudt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 06:26:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 04:26:49 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-enP1Y11ZcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51610&action=edit
Bug 13669: (followup) fix I18N files

This patch fix web installer for
de-DE, es-ES, fr-CA, nb-NO and pl-PL

To test:
1) Apply patch
2) Try web installer for any/all listed languages.
There must be no problems for marc21 + all sample files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 06:26:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 04:26:54 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-FqZkQ7znEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #24 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51611&action=edit
Bug 13669: (followup) fix fr-FR files

Rewrite autorites_norme_unimarc.sql to
use only one INSERT IGNORE.

New load method complains about duplicate keys,
and both auth files are mandatory!

Also removed an exotic blank space on sample_labels.sql

Tested with unimarc_complet and all sample files.

To test
1) Apply the patch
2) Try fr-FR web installer, unimarc_complet + all sample files
There must be no errors

Don't know if fr-FR marc21 and unimarc_lecture_pub are used,
need a look from french users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 06:34:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 04:34:50 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-f2PuTfbnHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
                 CC|                            |bgkriegel at gmail.com

--- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Chris Cormack from comment #20)
> It works, but a new dependency eh? We need to update that too.
> 
> I've attached it as a signed off patch, but will let the RM and others
> decide if they want to add the new dependency.

You are right, but SQL::SplitStatement also needs packaging.

Tested web installer in all languages, added fixes for almost all.
ru-RU and uk-UA need more work, but I need to sleep.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 06:45:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 04:45:48 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-kf8izCVZZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51610|0                           |1
        is obsolete|                            |

--- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51612&action=edit
Bug 13669: (followup) fix I18N files

This patch fix web installer for
de-DE, es-ES, fr-CA, nb-NO and pl-PL

To test:
1) Apply patch
2) Try web installer for any/all listed languages.
a) de-DE, es-ES, fr-CA and pl-PL
There must be no problems for marc21 + all sample files
b) nb-NO
There must be no problems for normarc + all sample files

Fixed test plan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 07:15:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 05:15:45 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-g2c8dBMeew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 07:15:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 05:15:48 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-fXQ4fvUQjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51226|0                           |1
        is obsolete|                            |

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51613&action=edit
[PASSED QA] Bug 16343: 7XX XSLT subfields displaying out of order

This patch respect previous css classes
.authordates and .relatorcode but also include .titleportion

.authordates {display: none;}
.titleportion {display: none;}
.relatorcode {display: none;}

To test:
- Stage the two record attached with titles:
  - Surface & coatings technology.
  - Women crime writers.
- Reindex zebra (necessary to Opac and Itranet results)
- Leave empty the OPACUserCSS and IntranetUserCSS sysprefs
- Go to the new records in OPAC and Intranet detail page
- See the wrong display of dates
- Apply patch and refresh the page
- Test in OPACUserCSS and IntranetUserCSS the css stated before
- Play deleting or adding the classes
- Test with multiple records with 700 (with and without dates, etc;
  710 and 711)

NOTE: dates in 710 and 711 can be hidden with .titleportion class;
dates in this kind of heading go with another data for example:
Catholic Church. Plenary Council of Baltimore (2nd : 1866)
Patch rebased some typos fixed in comments

Signed-off-by: Dani Elder <danielle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 09:32:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 07:32:40 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-o7gj1tKdYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 09:44:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 07:44:24 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-q4GnkIOn5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bernardo, how did you generate new sample files?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 09:53:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 07:53:50 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-esjKI0Jsd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What's the expected behavior if an error occurs,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:12:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:12:38 +0000
Subject: [Koha-bugs] [Bug 16551] New: Display the name of lists to the
 search results at the OPAC
Message-ID: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

            Bug ID: 16551
           Summary: Display the name of lists to the search results at the
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

This new enhancement will allow to add the name of lists containing a biblio to
the search results at the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:12:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:12:47 +0000
Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search
 results at the OPAC
In-Reply-To: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16551-70-nxncvorVnF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:14:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:14:04 +0000
Subject: [Koha-bugs] [Bug 16552] New: Add the ability to change the default
	holdings sort
Message-ID: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

            Bug ID: 16552
           Summary: Add the ability to change the default holdings sort
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

This new enhancement will add the ability to change the default holdings sort
on OPAC displays to be by library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:14:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:14:17 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-l1XVOj3QI2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:35:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:35:32 +0000
Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search
 results at the OPAC
In-Reply-To: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16551-70-jcq3hOAru2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:35:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:35:35 +0000
Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search
 results at the OPAC
In-Reply-To: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16551-70-AUgkAoGF0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51614&action=edit
Bug 16551: Display the name of lists to the search results at the OPAC

This new enhancement will allow to add the name of lists containing a
biblio to the search results at the OPAC.

Test plan:
0/ Regenerate the css file to get the style change:
 % lessc --clean-css="--s0 --advanced --compatibility=ie7"
   koha-tmpl/opac-tmpl/bootstrap/less/opac.less >
   koha-tmpl/opac-tmpl/bootstrap/css/opac.css
1/ Create some lists and add items to them
2/ On the search results you should see the name of the lists which
contains the record.

Note that we could add a syspref to make this new behavior optional.

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:44:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:44:00 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-BuaEcsL2Yo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:57:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:57:01 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-bCuGN4wZTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 10:57:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 08:57:04 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-BlO2OdDUuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51615&action=edit
Bug 16552: Add the ability to change the default holdings sort

This new enhancement will add the ability to change the default holdings
sort on OPAC displays to be by library, instead of item type.

This patch adds a new pref OPACHoldingsDefaultSortField with 3 different
possible values:
 - Item type
 - Home library
 - Holding library

Note that if OpacLocationBranchToDisplay is set not to display home libraries,
unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to
"Home library", same for "Holding library".

Test plan:
- Confirm that the default value for OPACHoldingsDefaultSortField is
  'first column' after executing the DB entry and that there is no
  change in the behavior (first column is used to sort the holdings
  table on the detail page).
- Set OpacLocationBranchToDisplay to both and play with the different
  values of OPACHoldingsDefaultSortField
  => Confrm that the default column used to sort the table is correctly
  changed
- Set the pref SeparateHoldings on
  => Confirm that both tables (Holdings and other holdings) are sorted using
  the OPACHoldingsDefaultSortField value.

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 11:44:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 09:44:14 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-7HZM93G2G7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

--- Comment #9 from Lari Taskula <larit at student.uef.fi> ---
What happened to the first patch "Bug 16200: Make 'Hold waiting too long'
translatable and give it an unique accounttype"?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 11:57:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 09:57:18 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-iBdjijRpRp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah, I am sorry. I missed the second patch when signing off and reattaching.
Please feel free to fix - or I will do it tonight.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 12:03:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 10:03:06 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-r62sc8ItvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51589|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 12:40:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 10:40:38 +0000
Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576
 bytes) are not searchable.
In-Reply-To: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15399-70-HYidrlaVSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399

Lari Taskula <larit at student.uef.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 13:37:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 11:37:31 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-LZm4ykXExK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Jonathan,

(In reply to Jonathan Druart from comment #27)
> Bernardo, how did you generate new sample files?

Mmmm, sorry but can't understand exactly...
Just edited current files and fix what was needed

(In reply to Jonathan Druart from comment #28)
> What's the expected behavior if an error occurs,

A) de-DE, es-ES, fr-CA and pl-PL, 
same error for all langs

 * first 3 patches applied
 * (cd misc/translator/; ./translate install de-DE) , for example
 * drop/create database, run webinstaller
 * marc21, select all sample data

1) web installer error

Software error:

[SQL ERROR]: -- ISSN: 1041-5653
-- Refer to http://www.niso.org/standards/index.html

-- General Holdings: Type of Unit Designator
INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES
('HINGS_UT','0','Information not available; Not applicable');INSERT INTO
`authorised_values` (category, authorised_value, lib) VALUES
('HINGS_UT','a','Basic bibliographic unit')
For help

2) logs

install.pl: DBD::mysql::st execute failed: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'INSERT INTO `authorised_values` (category,
authorised_value, lib) VALUES ('HINGS' at line 5 at
/usr/local/share/perl/5.18.2/DBIx/RunSQL.pm line 254...
and more lines

In this case I suppose that DBIx::RunSQL does not know how to parse 2 sql
statments on the same line.

B) fr-FR
1) web installer

Software error:

[SQL ERROR]: 
INSERT INTO `auth_types` (`authtypecode`, `authtypetext`, `auth_tag_to_report`,
`summary`) VALUES ('','D?faut','','')

2) logs

install.pl: DBD::mysql::st execute failed: Duplicate entry '' for key 'PRIMARY'
at /usr/local/share/perl/5.18.2/DBIx/RunSQL.pm line 254.

In this case as both autorite_default.sql and 
autorites_norme_unimarc.sql are 'Obligatoire',
we have duplicate keys for 'D?faut' auth type 
and some other fields/subfields.

Here the second file was edited to join all inserts in
one statement (like EN marc21 files) instead of adding 
IGNORE to all INSERTs to prevent this error 

The other error is a space after final ';' on sample_labels.sql,
similar to case A)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 14:02:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 12:02:19 +0000
Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search
 results at the OPAC
In-Reply-To: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16551-70-o2T3EAXIrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 14:02:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 12:02:21 +0000
Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search
 results at the OPAC
In-Reply-To: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16551-70-F9BKrdMnSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51614|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51616&action=edit
[SIGNED-OFF] Bug 16551: Display the name of lists to the search results at the
OPAC

This new enhancement will allow to add the name of lists containing a
biblio to the search results at the OPAC.

Test plan:
0/ Regenerate the css file to get the style change:
 % lessc --clean-css="--s0 --advanced --compatibility=ie7"
   koha-tmpl/opac-tmpl/bootstrap/less/opac.less >
   koha-tmpl/opac-tmpl/bootstrap/css/opac.css
1/ Create some lists and add items to them
2/ On the search results you should see the name of the lists which
contains the record.

Note that we could add a syspref to make this new behavior optional.

Sponsored-by: University of the Arts London
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 14:30:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 12:30:52 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-ruC8nBTUPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I ran into one problem with this. These were the combinations I tested:

OPACHoldingsDefaultSortField -> Item type
- OpacLocationBranchToDisplay -> home library - Good
- OpacLocationBranchToDisplay -> holding library - Good
- OpacLocationBranchToDisplay -> home and holding library - Good


OPACHoldingsDefaultSortField -> Home library
- OpacLocationBranchToDisplay -> home library - Sorts on third column,
"Collection"
- OpacLocationBranchToDisplay -> holding library - (Not applicable)
- OpacLocationBranchToDisplay -> home and holding library - Good

OPACHoldingsDefaultSortField -> Holding library
- OpacLocationBranchToDisplay -> home library - (Not applicable)
- OpacLocationBranchToDisplay -> holding library - Good
- OpacLocationBranchToDisplay -> home and holding library - Good

When I have OPACHoldingsDefaultSortField set to "Home library" and
OpacLocationBranchToDisplay  set to "home library" the sorting is on the
"Collection" column instead of the home library one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:01:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:01:53 +0000
Subject: [Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff
	client
In-Reply-To: <bug-15883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15883-70-l9MPUhwqJp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16553


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553
[Bug 16553] Incorrect path to jQueryUI file in help template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:01:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:01:53 +0000
Subject: [Koha-bugs] [Bug 16553] New: Incorrect path to jQueryUI file in
	help template
Message-ID: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

            Bug ID: 16553
           Summary: Incorrect path to jQueryUI file in help template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 15883

The jQuery/jQueryUI upgrade patch included an incorrect path to jQueryUI in 
help-top.inc. This is causing a JS error which interferes with other JavaScript
execution on the page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
[Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:09:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:09:48 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-JLkmeWXAW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:09:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:09:50 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-AcaVJ4eXSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51617&action=edit
Bug 16553 - Incorrect path to jQueryUI file in help template

This patch corrects an incorrect path to the jQueryUI library file in
the help system header include.

To test, apply the patch and open any help file in the staff client.
Your browser's JavaScript console should report no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:39:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:39:41 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-KNsdvkfzhM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:39:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:39:44 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-nvJGjRgBXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51617|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51618&action=edit
[SIGNED-OFF] Bug 16553 - Incorrect path to jQueryUI file in help template

This patch corrects an incorrect path to the jQueryUI library file in
the help system header include.

To test, apply the patch and open any help file in the staff client.
Your browser's JavaScript console should report no errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No more console errors
No qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:51:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:51:54 +0000
Subject: [Koha-bugs] [Bug 16554] New: Web installer fails to load i18n
 sample data on MySQL 5.6+
Message-ID: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

            Bug ID: 16554
           Summary: Web installer fails to load i18n sample data on MySQL
                    5.6+
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Followup to bug 13669

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:58:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:58:14 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-KUDdFYECev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51619&action=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.7        66.5
58.6        66.0

b) SQL::SplitStatement (patch 1+2)
59.4        101
59.7        102

c) DBIx::RunSQL (patch 3)
60.7        66.8
59.4        66.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:58:20 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-qWzCUvt44O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51620&action=edit
Bug 16554: Fix fr-FR sample files

Needs Bug 13669

Rewrite autorites_norme_unimarc.sql to
use only one INSERT IGNORE.

New load method complains about duplicate keys,
and both auth files are mandatory!

Also removed blank space from sample_labels.sql

Tested with unimarc_complet and all sample files.

To test
1) Apply the patch
2) Try fr-FR web installer, unimarc_complet + all sample files
There must be no errors

Don't know if fr-FR marc21 and unimarc_lecture_pub are used,
need a look from french users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:58:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:58:24 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-1L2TPWU6po@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51621&action=edit
Bug 16554: Fix I18N sample files

Needs Bug 13669

This patch fix web installer for
de-DE, es-ES, fr-CA, nb-NO and pl-PL

To test:
1) Apply patch
2) Try web installer for any/all listed languages.
a) de-DE, es-ES, fr-CA and pl-PL
There must be no problems for marc21 + all sample files
b) nb-NO
There must be no problems for normarc + all sample files

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:58:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:58:44 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-6vV3LRdEMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51619|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 15:59:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 13:59:38 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-n1Xi6W55sd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:00:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:00:09 +0000
Subject: [Koha-bugs] [Bug 16555] New: Managing patron self edits -- non
 superlibrarians can see patrons for other branches
Message-ID: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16555

            Bug ID: 16555
           Summary: Managing patron self edits -- non superlibrarians can
                    see patrons for other branches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Koha documentation says:

    Note

    Superlibrarians will see modifications for any branch, other staff will
    only see modifications for patrons who belong to their logged in branch.

http://manual.koha-community.org/3.22/en/mangepatronedits.html

However non-superlibrarian staff *can* see patron modification requests from
other branches.

To replicate:

1/ In opac, create a self registration request at branch A.
2/ Log in to staff client as non-superlibrarian staff member with 'modify
patron' permissions, at branch B.
3/ Note that 'Patrons requesting modifications' on Staff Client Home page will
show a request.
4/ Click on 'Patrons requesting modifications'. You will see the request from
step 1/.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:00:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:00:33 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-qEgN9rdFPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51611|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:01:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:01:29 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-8vmoL3JJmb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51612|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:03:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:03:22 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-JdqeZGjekL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Moving i18n files to Bug 16554.
Resetting to 'Signed off' for QA consideration, sorry for the noise

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:04:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:04:00 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-HszKHKhU6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16554


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554
[Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:04:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:04:00 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-5N6A50xjKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13669
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:05:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:05:34 +0000
Subject: [Koha-bugs] [Bug 16555] Managing patron self edits -- non
 superlibrarians can see patrons for other branches
In-Reply-To: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16555-70-0azSvqaqWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16555

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:12:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:12:01 +0000
Subject: [Koha-bugs] [Bug 16556] New: KohaToMarcMapped columns sharing same
 field with biblio(item)number are removed.
Message-ID: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

            Bug ID: 16556
           Summary: KohaToMarcMapped columns sharing same field with
                    biblio(item)number are removed.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

REPLICATE ISSUE:

1. Map biblio.frameworkcode to 999$b
2. Map biblio.biblionumber to 999$c
3. Add a record with something in 999$b
4. 999$b is removed by C4::Biblio::AddBiblio()

After this patch, the field used by biblio.biblionumber or
biblioitems.biblioitemnumber is not removed and created anew, thus dropping all
existing additions.

There is no point in dropping the field in any case, since we can just replace
the existing subfields in-place with no need to recreate the whole field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:12:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:12:21 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
 with biblio(item)number are removed.
In-Reply-To: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16556-70-aUiDGUHKPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Cataloging                  |Architecture, internals,
                   |                            |and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:13:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:13:38 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
 with biblio(item)number are removed.
In-Reply-To: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16556-70-7ZjHsl9rV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 51622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51622&action=edit
Bug 16556 - KohaToMarcMapped columns sharing same field with biblio(item)number
are removed.

REPLICATE ISSUE:

1. Map biblio.frameworkcode to 999$b
2. Map biblio.biblionumber to 999$c
3. Add a record with something in 999$b
4. 999$b is removed by C4::Biblio::AddBiblio()

After this patch, the field used by biblio.biblionumber or
biblioitems.biblioitemnumber
is not removed and created anew, thus dropping all existing additions.

There is no point in dropping the field in any case, since we can just replace
the existing subfields in-place with no need to recreate the whole field.

UNIT TESTS INCLUDED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:14:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:14:10 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
 with biblio(item)number are removed.
In-Reply-To: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16556-70-I7bszTabsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
C4::Biblio::_koha_marc_update_bib_ids() does the dark deed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:17:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:17:55 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-IqzgrJqUMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:17:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:17:58 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-lkHB1JTDGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51584|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51623&action=edit
[SIGNED-OFF] Bug 16001 - Use standard message dialog when there are no cities
to list

If there are no existing cities in Administration -> Cities and Towns,
the message saying so should be in the standard message dialog.

Another minor change: Edit the message to say "There are no cities
defined," which I think reads better in English.

To test you must have no cities and towns defined.

Apply this patch and go to Administration -> Cities and Towns. You
should see a message displayed in a standard "message" style dialog.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Better view, no errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:26:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:26:16 +0000
Subject: [Koha-bugs] [Bug 16557] New: Remove the use of "onclick" from
 several include files
Message-ID: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557

            Bug ID: 16557
           Summary: Remove the use of "onclick" from several include files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

There are several remaining include files in the staff client which use
"onclick." These should be updated so that events are defined in the JavaScript
instead.

 includes/acquisitions-search.inc
 includes/borrower_debarments.inc
 includes/help-bottom.inc
 includes/messaging-preference-form.inc
 includes/serials-toolbar.inc
 includes/subscriptions-search.inc
 includes/subtypes_unimarc.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:30:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:30:58 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-VEnIhRCvTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Just saying:
https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Taking_still_photos

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:31:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:31:40 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-4oCXrdEVLH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51478|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51624&action=edit
[SIGNED-OFF] Bug 15878 - Updated unit tests for hbyymmincr barcodes

Test plan in second patch

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:31:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:31:53 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-fyuGUkkVUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51479|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51625&action=edit
[SIGNED-OFF] Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max
and should warn when no branchcode present

Test plan:

1 - prove t/db_dependent/Barcodes.t
2 - All should pass
3 - Apply first patch (unit tests update)
    4 - Tests should fail on values and warnings
    5 - Apply second patch
    6 - All tests should now pass

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described
Removed tab on line 47 of C4/Barcodes/hbyymmincr.pm
No more qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:32:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:32:10 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-fITv1iaxkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:56:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:56:55 +0000
Subject: [Koha-bugs] [Bug 16494] Remove the use of "onclick" from some
	patron pages
In-Reply-To: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16494-70-gPfpHUKCmK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16557


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557
[Bug 16557] Remove the use of "onclick" from several include files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:56:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:56:55 +0000
Subject: [Koha-bugs] [Bug 16557] Remove the use of "onclick" from several
	include files
In-Reply-To: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16557-70-xNmMJ9TNna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16553, 16494


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494
[Bug 16494] Remove the use of "onclick" from some patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553
[Bug 16553] Incorrect path to jQueryUI file in help template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:56:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:56:55 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-w3bkdzWzDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16557


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557
[Bug 16557] Remove the use of "onclick" from several include files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:59:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:59:38 +0000
Subject: [Koha-bugs] [Bug 16557] Remove the use of "onclick" from several
	include files
In-Reply-To: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16557-70-9v0QJoYT0l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 16:59:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 14:59:41 +0000
Subject: [Koha-bugs] [Bug 16557] Remove the use of "onclick" from several
	include files
In-Reply-To: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16557-70-g7AJmQIHAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51626&action=edit
Bug 16557 - Remove the use of "onclick" from several include files

This patch modifies several include files, removing "onclick" attributes
in favor of defining events in JavaScript.

A reusable "toggle" function has been added to the global JS file so
that clicking elements with the class "toggle_element" will toggle the
display of elements as defined in the click target's "data-element"
attribute.

Also changed: In subtypes_unimarc.inc some capitalization errors have
been fixed and label/id pairs corrected.

To test, apply the patch and clear your browser cache if necessary.

- On the Acquisitions home page, click the "Orders search" header search
  tab. Clicking the [+] link should expand and collapse the additional
  search fields.

- On the checkout or patron detail page, view the "Restrictions" tab.
  Click to add a restriction and use the datepicker to select a date.
  Clicking the "Clear date" link should clear the date.

- Trigger the help window on any page. Clicking the "close window"
  button should work correctly.

- Go to Administration -> Patron categories -> Edit. Checking and
  unchecking messaging preference options should work correctly. The "do
  not notify" checkbox should clear other checkboxes in that row and
  vice versa.

- In Serials, from a subscription detail page, clicking the "Renew"
  button should trigger the renew popup.

- Go to Acquisitions -> Vendor -> Add to basket -> From a subscription.
  Clicking the "Advanced search" link in the left hand sidebar should
  toggle the sidebar search form.

- In a UNIMARC system, view the advanced search page. Clicking the "Show
  coded information filters" link should show additional search fields.
  (I tested in my MARC21 system by temporarily moving line 174 of
  advsearch.tt to line 172).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 17:14:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 15:14:50 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-4gUOQny090@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 17:14:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 15:14:53 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-UpCoP41C7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45280|0                           |1
        is obsolete|                            |
  Attachment #45281|0                           |1
        is obsolete|                            |
  Attachment #45285|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51627&action=edit
Bug 14390 - Fine not updated from 'FU' to 'F' on renewal

Test Plan:
1) Find an overdue checkout with a fine
2) Renew item, note fine is not closed out (Account type F)
3) Apply this patch
4) Find another overdue checkout with a fine
5) Renew item, note fine is now correctly closed out
6) Backdate a checkout to be already overdue ( but not have a fine since
    fines.pl hasn't run yet )
7) Renew item, note a closed out fine is created

Signed-off-by: Sean Minkel <sminkel at rcplib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 17:15:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 15:15:03 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-RELfxPS4uW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51628&action=edit
Bug 14390 [QA Followup] - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 17:15:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 15:15:06 +0000
Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14390-70-nNb7sS14Vd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51629&action=edit
Bug 14390 [QA Followup] - Fix warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 17:52:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 15:52:03 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-RQM8DBwwB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Jonathan could you check the issues you mention in comment 5 and comment 6
again? I cannot reproduce the problem. If they persist, are there JS errors?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 17:59:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 15:59:36 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-LSiYa8IPUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 20:11:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 18:11:50 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-jAu1k7fJk2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Karl Holten <kholten at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholten at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 20:11:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 18:11:50 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-c1AopHDOwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Karl Holten <kholten at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholten at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 20:40:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 18:40:24 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-uXXPuKw3q2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 20:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 18:40:27 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-sCTcrx4CEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51630&action=edit
Bug 16005 - Standardize use of icons for delete and cancel operations

This patch makes changes to Font Awesome icons in order to make icon
choice consistent for common actions.

<i class="fa fa-trash"></i> where something is deleted, removed, or
emptied.

<i class="fa fa-remove"></i> where an operation is cancelled (also where
selections are cancelled, as in checkboxes).

<i class="fa fa-times-circle"></i> for "close," as in baskets and
windows.

To test, apply the patch and view the following pages to confirm that
the correct icon is used:

- Acquisitions -> Vendor -> Vendor delete button.
- Acquisitions -> Vendor -> Edit -> Delete contact button.
- Acquisitions -> Invoices ->  Delete menu item.
- Cataloging -> Edit record -> Authority search pop-up (triggered from
  the tag editor for a tag linked to an authority) -> Clear field button
- Authorities -> Authority detail -> Delete button.
- Tools -> Quotes editor -> Quotes delete button.
- Reports -> View saved report -> Delete button.
- Reports -> Saved reports -> Delete menu item.
- Serials -> Subscription details -> Subscription close button.
- Administration -> Budgets -> Delete menu item.
- Administration -> Item search fields -> Delete button.
- Administration -> Z39.50/SRU servers -> Delete menu item.
- Catalog -> Advanced search -> Clear fields link.
- Cataloging -> Advanced editor -> Macros -> Delete macro button.
- Circulation -> Checkout -> Check out an item which is on hold for
  another patron. "Cancel checkout and place hold" button now uses the
  icon used elsewhere for holds.
- Course reserves -> Course -> Delete course button.
- Patrons -> Patron lists -> Add patrons -> Remove selected button.
- Acquisitions -> Suggestions -> Suggestion details -> Delete button.
- Lists -> List contents -> Remove selected button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 21:47:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 19:47:30 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-pwtMy27Hr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #20)
> Just saying:
> https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/
> Taking_still_photos

Just saying: doesn't work for me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 21:48:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 19:48:26 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-lQkH0m0nQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #22 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. Tompsett from comment #21)
> (In reply to Tom?s Cohen Arazi from comment #20)
> > Just saying:
> > https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/
> > Taking_still_photos
> 
> Just saying: doesn't work for me.

-- google chrome, though. Koha should not be browser specific.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 22:27:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 20:27:36 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-9V0s4J6ici@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
https://webrtc.org/ ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 22:44:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 20:44:07 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-0ih53MYz94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #24 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Katrin Fischer from comment #23)
> https://webrtc.org/ ?

I tried clicking through some link off what Tomas posted. There... it does work
for Chrome is this example I found clicking through there.

However, note the lack of love for IE or Edge. My browser agnosticism point is
still valid. Granted, I think I've stumbled onto something that says it may be
possible to trick Edge into experimentally working for it. But I don't wish to
devote time to researching that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 22:47:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 20:47:43 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-5PRJxPH7K4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think I disagree about this having to work in any and every browser. It's a
feature not a lot of libraries will need - and we don't recommend using IE or
Edge with Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 22:54:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 20:54:53 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
 - fines - overdue notices
In-Reply-To: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-M6A8YafXFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I still think that sending out wrong overdue notices is a bad bad thing. It's
hard to communicate to patrons why you charge them a fine later, that was not
listed in the notice they received - or why the items have been renewed the
next day. Or why they receive a second overdue notice with different
information once you have fixed things. I think overdue notices should only be
generated if the first jobs finish correctly and ideally, if one of the jobs
fails for whatever reason, we should have a way of notifying the library. 

But anyway, this has taken long now, we have a fix in production. I am ready to
make changes as suggested, but I need some clear decision to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 23:38:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 21:38:54 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-NDHyJHXLua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51589|0                           |1
        is obsolete|                            |
  Attachment #51605|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51631&action=edit
[PASSED QA] Bug 16200: Make 'Hold waiting too long' translatable and give it an
unique accounttype

Holds that have expired have been untranslatable in Patron's Fines-tab. Also,
they are
mixed with other type of fines with accounttype "F". This patch gives expired
holds an
own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize
this new
accounttype in order to make it translatable.

To test:
1. Make a hold and let it expire
2. Go to Patron's Fines tab
3. Change Koha's language to some other than English
4. Observe that there is a "Hold waiting too long" fine described in English
5. Apply patch
6. Make another hold and let it expire
7. Update translations
8. Find "Hold waiting too long" from your .po file
9. Translate it and install translations
10. Go back to Fines tab and observe that the new expired hold is translated

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 19 23:39:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 May 2016 21:39:53 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-e7tbhn9ESl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 51632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51632&action=edit
[PASSED QA] Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this buug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 05:24:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 03:24:16 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-CXQfzXijH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #25)
> I think I disagree about this having to work in any and every browser. It's
> a feature not a lot of libraries will need - and we don't recommend using IE
> or Edge with Koha.

I think having an implmentation on top of which interested parties could work
to support more browsers is better than nothing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 05:26:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 03:26:07 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-D7Z2qntc7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #26)
> (In reply to Katrin Fischer from comment #25)
> > I think I disagree about this having to work in any and every browser. It's
> > a feature not a lot of libraries will need - and we don't recommend using IE
> > or Edge with Koha.
> 
> I think having an implmentation on top of which interested parties could
> work to support more browsers is better than nothing.

Also, I found this exmaple to work in both Chrome and Firefox:

https://davidwalsh.name/demo/camera.php

It can be done!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 06:20:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 04:20:42 +0000
Subject: [Koha-bugs] [Bug 14774] Task Scheduler not working on
	Ubuntu/Apache2.4
In-Reply-To: <bug-14774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14774-70-nnWOgkOX4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|In Discussion               |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 06:22:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 04:22:12 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-RI2VHwYab8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #108 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #107)
> (In reply to Tom?s Cohen Arazi from comment #106)
> > I'm abandoning this bug. It went too far.
> 
> C'mon!!! :)
> 
> Question 1 on comment 102 was
> 
> > C4/Circulation.pm
> > 1868     my $biblio   = $item_level_itypes ? undef : GetBiblioData( $item->{
> > biblionumber } ); # don't get bib data unless we need it
> > 
> > Should not we use GetBiblioItemByBiblioNumber instead to avoid 2 left joins
> > per return?
> 
> If you think I am right, I can provide a patch for that.

You are right :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:10:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:10:53 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-blgpXS4m7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:10:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:10:55 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-Dz93xQlyTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51492|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51633&action=edit
Bug 16516: Define the showListsUpdate JS function at the OPAC

Bug 12233 removes the declaration of the showListsUpdate JS function for
the OPAC.
It results in a JS error (ReferenceError: showListsUpdate is not
defined) when a user tries to add selected titles to a list if no title
is selected.

Test plan:
Launch a catalogue search
Select a list in the "Select titles to" dropdown list
=> Without this patch you will get the JS error
=> With this patch you will get a JS alert "No item was selected"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:11:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:11:12 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-7AMJNOzFHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:18:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:18:44 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-MVY81MVHOT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:18:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:18:46 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-wlk1aec9Pw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51375|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51634&action=edit
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display
in intranet

To test:
1 - Create a list in staff client
2 - Set XSLTResultsDisplay to blank
3 - View list, titles don't display
4 - Apply patch
5 - View list, titles display
6 - Set XSLTResultsDisplay to default
7 - View list, titles display as before patch

Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:22:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:22:01 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-dQHzrZhg76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> The eternal question is: should we continue to fix non-XSLT views? :)

If we deprecate something, we should make more definitive plans to remove the
functionality too imo.
Since this is just a one-line fix restoring something very fundamental as the
title of a book, I would recommend to push it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:30:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:30:05 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-FVphjH5qkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:30:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:30:08 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-gVpWi5wQDM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51635&action=edit
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl

If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at
/home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at
/home/koha/src/circ/circulation.pl line 170.

Test plan:
- Search for a patron and confirm the warnings are not displayed anymore
- Make sure this patch does not introduce regression on bug 14015

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:30:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:30:28 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-GGtp5hxhUD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 08:49:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 06:49:03 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-dYKZYxQOgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I still see: TypeError: document.form.password is undefined (members.js line
107)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:28:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:28:05 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-U7qJY80V8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

oliver.bock at aei.mpg.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver.bock at aei.mpg.de

--- Comment #19 from oliver.bock at aei.mpg.de ---
This seems to be limited to Amazon cover images. If so, why? How about the
other providers like Open Library where I run into a similar problem (HTTP API
call blocked for a full HTTPS Koha site).

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:30:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:30:15 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-N7uUBNi9jT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:30:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:30:18 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-1qWQY38ymN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51615|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51636&action=edit
Bug 16552: Add the ability to change the default holdings sort

This new enhancement will add the ability to change the default holdings
sort on OPAC displays to be by library, instead of item type.

This patch adds a new pref OPACHoldingsDefaultSortField with 3 different
possible values:
 - Item type
 - Home library
 - Holding library

Note that if OpacLocationBranchToDisplay is set not to display home libraries,
unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to
"Home library", same for "Holding library".

Test plan:
- Confirm that the default value for OPACHoldingsDefaultSortField is
  'first column' after executing the DB entry and that there is no
  change in the behavior (first column is used to sort the holdings
  table on the detail page).
- Set OpacLocationBranchToDisplay to both and play with the different
  values of OPACHoldingsDefaultSortField
  => Confrm that the default column used to sort the table is correctly
  changed
- Set the pref SeparateHoldings on
  => Confirm that both tables (Holdings and other holdings) are sorted using
  the OPACHoldingsDefaultSortField value.

Sponsored-by: University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:31:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:31:17 +0000
Subject: [Koha-bugs] [Bug 16552] Add the ability to change the default
	holdings sort
In-Reply-To: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16552-70-tK1epLID4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #2)
> When I have OPACHoldingsDefaultSortField set to "Home library" and
> OpacLocationBranchToDisplay  set to "home library" the sorting is on the
> "Collection" column instead of the home library one.

Indeed, the tests are a bit more complicated :)
Thanks for testing Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:33:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:33:17 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-zn9ecWHC7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:33:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:33:19 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-pfxW2Voj5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51223|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51637&action=edit
Bug 15333: Use Koha::Cache to cache exception_holidays instead of a package
variable

On the same way as bug 14522, we should use Koha::Cache to cache
exception_holidays.
It's not safe to use a package variable if running under Plack.

There is not test plan, just make sure the changes make sense.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:33:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:33:25 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-f3iY9RLa0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51638&action=edit
Bug 15333: [QA Follow-up] Add few tests

This report had no test plan and no unit tests.
Adding some lines to Holidays.t.
Added a trivial line move in Calendar.pm.

Test plan:
Run t/db_dependent/Holidays.t with and without cache.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with memcached, Cache::Memory and no cache (edit Cache.pm).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:33:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:33:42 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-0WR8V8hXIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:38:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:38:08 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-0BUMdiJLTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:38:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:38:11 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-RldfyrJmIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51618|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51639&action=edit
Bug 16553 - Incorrect path to jQueryUI file in help template

This patch corrects an incorrect path to the jQueryUI library file in
the help system header include.

To test, apply the patch and open any help file in the staff client.
Your browser's JavaScript console should report no errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No more console errors
No qa errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:42:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:42:58 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-LQRo7SWxsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Did you see my other concern about the divergence of the 2 files?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:46:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:46:35 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-YLxN5LB59g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #6)
> Did you see my other concern about the divergence of the 2 files?
Yes. These scripts should not contain so much logic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:50:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:50:49 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-JkHemyRgWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #6)
> Did you see my other concern about the divergence of the 2 files?

I know it was not introduced by this patch, but it would be good to fix it
(even on another bug report). But... it would be easiest to remove the code
than to fix it...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:54:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:54:39 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-wlDrDseBec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51440|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 10:58:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 08:58:12 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-bDxAAKzLoj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #20 from oliver.bock at aei.mpg.de ---
Created attachment 51640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51640&action=edit
Use SSL when querying Open Library API

FWIW, here's a patch to use SSL for Open Library as well...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 11:05:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 09:05:34 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-fDr0NrTxyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Jonathan Druart from comment #6)
> > Did you see my other concern about the divergence of the 2 files?
> 
> I know it was not introduced by this patch, but it would be good to fix it
> (even on another bug report). But... it would be easiest to remove the code
> than to fix it...

I would recommend now to build on top of this one liner (tested etc.)
New adjustments will not reach 16.05 anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 11:09:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 09:09:05 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-3dyelZPikZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #20 from Marc V?ron <veron at veron.ch> ---
Created attachment 51641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51641&action=edit
Bug 9543 - (Follow-up) Show patrons messaging subscription on holds
notification

As of comment #19
- Code de-duplicated to a BLOCK statement
- Variable renamed
- Wording slightly changed. I like it that way, but feel free to change it
  in a follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 11:10:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 09:10:31 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-ax8a2lbmsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #21 from Marc V?ron <veron at veron.ch> ---
Not sure if it can be switched back to signed-off or if it needs an other
sign-off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 12:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 10:26:34 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-0vVGJHeAzC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51642&action=edit
Bug 16550: Can't set opac news expiration date to NULL, it reverts to today

This patch fixes an issue with the expiration dates for news always reverting
to today if empty.

To test:
- Apply patch
- Go to Home > Tools > News
- Create a news item, do not set expiration date
- Verify that expiration date stays empty
- Edit this news item
- Do not set expiration date
- Verify that expiration date stays empty
- Do the same with expiration dates
- Verify that they are saved properly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:26:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:26:41 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-qOoqW8QoMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51080|0                           |1
        is obsolete|                            |

--- Comment #55 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51643&action=edit
Bug 13321: Rename variables

This patch renames the variable according to the new DB column names
 * gste => tax_excluded
 * gsti => tax_included
 * gstrate => tax_rate
 * gstvalue => tax_value

This patch also modify the ModReceiveOrder subroutine:
 * Edit vendor note on receiving is not possible, so the code should not
   permit that.
 * Update ModReceiveOrder to pass a hashref

And that's all!
git grep on gste, gsti, gstrate and gstvalue should not return any code
that can be executed.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:26:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:26:50 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-QVpPbiLKv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51081|0                           |1
        is obsolete|                            |

--- Comment #56 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51644&action=edit
Bug 13321: use the populate_with_prices where needed

Now we need to calculate the prices (ecost, rrp, unitprice) and tax
(tax_rate, tax_value) when the price is set for an order.

This only appends in the 3 files impacted by this patch.
addorder*.pl on ordering
finishreceive.pl on receiving

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:26:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:26:59 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-6UqhLySc5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51082|0                           |1
        is obsolete|                            |

--- Comment #57 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51645&action=edit
Bug 13321: Fix the prices calculation method

Well, we have finally arrived here \o/

The method where the prices are calculated uses the equations listed on
the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC).

The ecost is calculated from the rrp (using the discount and the tax
rate). That's why we removed the ability to edit this value.

That's why we remove the ability to edit the ecost on ordering in a
previous commit (bug 12840).

The total is now calculated in the scripts. That's why this patch
removes lines in the test file.

In C4::Acquisition::populate_order_with_prices, the calculation on
receiving must depend on the 'invoiceincgst' supplier parameter, and not
listincgst (which is used on ordering).
It also removes the rounding errors, now we store "exact" values in DB
(10^-6).
The values will be displayed using the Price TT plugin it will round the
values for us.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:27:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:27:07 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-2VkmLtVYeW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51083|0                           |1
        is obsolete|                            |

--- Comment #58 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51646&action=edit
Bug 13321: Tax and prices calculation - DB Changes

This patch adds 7 columns to the aqorders table:
 * unitprice_tax_excluded
 * unitprice_tax_included
 * rrp_tax_excluded
 * rrp_tax_included
 * ecost_tax_excluded
 * ecost_tax_included
 * tax_value

It also renames:
 * aqorders.gstrate with aqorders.tax_rate
 * aqbooksellers.gstrate with aqbooksellers.tax_rate

The new columns are filled with the previous calculation method.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:27:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:27:16 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-8jVfK7K1Dl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51084|0                           |1
        is obsolete|                            |

--- Comment #59 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51647&action=edit
Bug 13321: Csv export - Display rrp and ecost with and without taxes

If a basketgroup is exported as a CSV file, both prices should be displayed to
avoid confusion.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:27:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:27:25 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-ma3h8vGdt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51085|0                           |1
        is obsolete|                            |

--- Comment #60 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51648&action=edit
Bug 13321: Fix unitprice rounding

We need to display the rounded value, but insert the exact value.
The unit price can be change on receiving, so the input value can be
modified.
But if it's not, we must insert the exact (not rounded) unit price,
which is the ecost value.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: Francois Charbonnier <francois.charbonnier at inlibro.com>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:27:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:27:33 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-SZ0Rm4aBn3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

--- Comment #61 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 51649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51649&action=edit
Bug 13321: Adds renaming of gstrate column in kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:28:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:28:36 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-PBoA8iUDg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
             Status|Signed Off                  |Needs Signoff

--- Comment #62 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Patches rebased on master + Adds renaming of the column gstrate in
kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:50:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:50:45 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-baN5HKOIUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51650&action=edit
Bug 16550: Add test to NewsChannels.t

To test: Run t/db_dependent/NewsChannels.t

Tests adding and retreiving a news item without expiration date.
This test should fail without patch for Bug 16550 and pass OK with patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:52:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:52:42 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-hlnGr33WYF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 14:59:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 12:59:57 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-NdeBIscIpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:01:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:01:54 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-8qkp1sSDgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
When editing the news item the date is populated to today's date and must be
cleared.  It does save as empty, but shouldn't auto-populate

Tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:02:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:02:06 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-YeXUnEgKS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:20:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:20:51 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-d58SDXDZ30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:20:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:20:53 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-MGm7ujCjbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51606|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51651&action=edit
Bug 16548 - All libraries selected on Tools -> Export Data screen

This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.

Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.

To test, apply the patch and go to Tools -> Export data.

- Test the select all/select none links and confirm that they work as
  expected.
- Confirm that the structural changes to the form look okay.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:22:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:22:40 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-bY62kPg2FP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
I think this is an excellent suggestion, but I think it is beyond the scope of
this bug report (internal functionality vs display/user interface). 

Would you open a new bug for this Suzanne?

(In reply to Suzanne Fayle from comment #3)
> Or under options have a checkbox to include bibs without item records in the
> export? So that checking the box would export the bibs without items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:24:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:24:52 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-Sld2JJZz06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Hi Nick,

I just re-tested:

- Applied both patches

- With MySql, emptied table opac_news
- Went to Home > Tools > News
- New entry, save it without filling in Expiration date
Result OK: News has no Expiration date in list

- Edit the entry
Result OK: In edit form, Expiration date is empty, does not auto-populate

- Change title, leave Expiration date empty, save
Result OK: News has no Expiration date in list

- Edit News, add an expiration date, save
Result OK: Expiration date appears in list

- Edit News again, remove date from Expiration date, save
Result OK: No expiration date in list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:51:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:51:22 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-7BCPjioccr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51504|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51652&action=edit
Bug 14874 - Add ability to search for patrons by date of birth from checkout
and patron quick searches

This patch alters C4::Utils::DataTables::Members::search to autodetect
if the searchmember parameter is a date and search by DOB if so

To test:
1 - Apply patch
2 - Search for members by DOB formatted as per dateformat syspref or
mysql format
3 - Results should be returned as expected
4 - Search combined with other terms, results should be returned as
expected
5 - Search for patrons without using dates, results should be as
expected
6 - Search using search fields 'Date of birth' from expanded menu on
patron search - results should be returned as before (Note dying on
        incorrect format is an existing bug)
7 - prove t/db_dependent/Utils/Datatables_Members.t

Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:51:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:51:48 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-UP0AjagGDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:51:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:51:50 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-Fr4VNslvlD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51652|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51653&action=edit
Bug 14874 - Add ability to search for patrons by date of birth from checkout
and patron quick searches

This patch alters C4::Utils::DataTables::Members::search to autodetect
if the searchmember parameter is a date and search by DOB if so

To test:
1 - Apply patch
2 - Search for members by DOB formatted as per dateformat syspref or
mysql format
3 - Results should be returned as expected
4 - Search combined with other terms, results should be returned as
expected
5 - Search for patrons without using dates, results should be as
expected
6 - Search using search fields 'Date of birth' from expanded menu on
patron search - results should be returned as before (Note dying on
        incorrect format is an existing bug)
7 - prove t/db_dependent/Utils/Datatables_Members.t

Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:51:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:51:53 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-y2SXDUwhfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51505|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51654&action=edit
Bug 14874 - (followup) Refactor t/db_dependent/Utils/Datatables_Members.t to
use TestBuilder

To test:
1 - Apply other patches (not this one)
2 - Prove t/db_dependent/Utils/Datatables_Members.t
3 - SHould pass
4 - Apply this patch
5 - prove t/db_dependent/Utils/Datatables_Members.t
6 - All tests should continue to pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:52:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:52:42 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-0YuA4pM9Hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Owen Leonard from comment #4)
> > 4 - Search combined with other terms, results should be returned as
> > expected
> Is that how it's supposed to work or do I misunderstand this step?

Fixed it, I wasn't resetting the fields type after hitting a date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:56:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:56:55 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-IuvacqRlBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:56:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:56:57 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-Ko2jVqESCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51642|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51655&action=edit
Bug 16550: Can't set opac news expiration date to NULL, it reverts to today

This patch fixes an issue with the expiration dates for news always reverting
to today if empty.

To test:
- Apply patch
- Go to Home > Tools > News
- Create a news item, do not set expiration date
- Verify that expiration date stays empty
- Edit this news item
- Do not set expiration date
- Verify that expiration date stays empty
- Do the same with expiration dates
- Verify that they are saved properly

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 15:57:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 13:57:02 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-I6J9uriWf6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51650|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51656&action=edit
Bug 16550: Add test to NewsChannels.t

To test: Run t/db_dependent/NewsChannels.t

Tests adding and retreiving a news item without expiration date.
This test should fail without patch for Bug 16550 and pass OK with patch.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:08:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:08:25 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-OpLBAWyB5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51630|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51657&action=edit
Bug 16005 - Standardize use of icons for delete and cancel operations

This patch makes changes to Font Awesome icons in order to make icon
choice consistent for common actions.

<i class="fa fa-trash"></i> where something is deleted, removed, or
emptied.

<i class="fa fa-remove"></i> where an operation is cancelled (also where
selections are cancelled, as in checkboxes).

<i class="fa fa-times-circle"></i> for "close," as in baskets and
windows.

To test, apply the patch and view the following pages to confirm that
the correct icon is used:

- Acquisitions -> Vendor -> Vendor delete button.
- Acquisitions -> Vendor -> Edit -> Delete contact button.
- Acquisitions -> Invoices ->  Delete menu item.
- Cataloging -> Edit record -> Authority search pop-up (triggered from
  the tag editor for a tag linked to an authority) -> Clear field button
- Authorities -> Authority detail -> Delete button.
- Tools -> Quotes editor -> Quotes delete button.
- Reports -> View saved report -> Delete button.
- Reports -> Saved reports -> Delete menu item.
- Serials -> Subscription details -> Subscription close button.
- Administration -> Budgets -> Delete menu item.
- Administration -> Item search fields -> Delete button.
- Administration -> Z39.50/SRU servers -> Delete menu item.
- Catalog -> Advanced search -> Clear fields link.
- Cataloging -> Advanced editor -> Macros -> Delete macro button.
- Circulation -> Checkout -> Check out an item which is on hold for
  another patron. "Cancel checkout and place hold" button now uses the
  icon used elsewhere for holds.
- Course reserves -> Course -> Delete course button.
- Patrons -> Patron lists -> Add patrons -> Remove selected button.
- Acquisitions -> Suggestions -> Suggestion details -> Delete button.
- Lists -> List contents -> Remove selected button.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:08:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:08:51 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-0Jlvy9ALc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:19:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:19:47 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-dfJ7dy04c2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Oliver Bock from comment #20)
> Created attachment 51640 [details] [review]
> Use SSL when querying Open Library API
> 
> FWIW, here's a patch to use SSL for Open Library as well...

Would you please open a new bug report (and link it to this one) to attach your
patch?
This one is marked as "pushed to master" and new patches should go on their own
bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:25:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:25:22 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-tcyrqikLTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks Marc.
What about
  [%~ UNLESS loop.last %], [% ELSE %].[% END ~%]
To separate the mtt with a comma and end them with a dot?
I can provide a follow-up if you think it's better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:31:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:31:32 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-C5jMgi7ncQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #23 from Marc V?ron <veron at veron.ch> ---
(In reply to Jonathan Druart from comment #22)
> Thanks Marc.
> What about
>   [%~ UNLESS loop.last %], [% ELSE %].[% END ~%]
> To separate the mtt with a comma and end them with a dot?
> I can provide a follow-up if you think it's better.

Hi Jonathan, that would be nicer indeed, and yes please for the follow up :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:33:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:33:28 +0000
Subject: [Koha-bugs] [Bug 16458] Setting to guarantor: JavaScript error
 form.branchcode is undefined
In-Reply-To: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16458-70-FVniclUVQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #5)
> I still see: TypeError: document.form.password is undefined (members.js line
> 107)

Hi Marcel,
It's another bug, without this patch you are not able to set a guarantor.
It seems that you get the error when saving the patron form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:40:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:40:01 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-qIUez6xzpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #7)
> Jonathan could you check the issues you mention in comment 5 and comment 6
> again? I cannot reproduce the problem. If they persist, are there JS errors?

Yes they persist and I do not get any JS errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:41:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:41:31 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-bwZ5YKIfAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:41:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:41:35 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-zDRpWym89J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51243|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51658&action=edit
Bug 16437 - Automatic item modifications by age needs prettying

This patch makes layout and behavior changes to the automatic item
modifications by age interface, bringing some aspects of it closer into
conformance with established interface patterns.

- The intial view is now a standard table of information about existing
  rules, or a message dialog saying there are no rules.
- If there are no rules, a toolbar button reads "Add rules."
- If there are existing rules, the toolbar button reads "Edit rules."
  - Clicking the button leads to the rules edit interface, which now has
    a floating toolbar with "Add rule," "Save," and "Cancel" buttons.
  - Clicking the "Add rule" button displays a blank rule block.
    - If you are adding a rule to existing rules, the new block is
      appended at the bottom, and the page scrolls to the new rule.
    - As you add or remove rule blocks, the legend containing the rule
      count updates so that the numbers are sequential.
    - In each rule block, "age" and "substitutions" are now required.
      The age field is now validated to require a number.
    - The add/remove condition/substitution links now have more
      descriptive text labels.
    - The control to remove a rule is now a link in the <legend> element
      associated with each rule.
- Most JavaScript for this page is now in a separate file.
- Breadcrumbs are updated to be a little more specific.

To test, apply the patch and clear your browser cache if necessary.

- Go to Tools -> Automatic item modifications by age.
- Test adding and removing rules.
- Test removing all rules.
- Test adding and removing conditions and substitutions within rules.
- Test submitting the form without filling in required fields.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:41:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:41:38 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-N7oOrcpWTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51659&action=edit
Bug 16437 - (follow-up) Automatic item modifications by age needs prettying

Do not move the scrollbar to the top when removing a 'block' to a new
rule.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:41:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:41:56 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-Ttn2VA67iW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Owen Leonard from comment #7)
> > Jonathan could you check the issues you mention in comment 5 and comment 6
> > again? I cannot reproduce the problem. If they persist, are there JS errors?
> 
> Yes they persist and I do not get any JS errors.

Ok fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 16:46:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 14:46:06 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
 with biblio(item)number are removed.
In-Reply-To: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16556-70-f7HUkdaWyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi
           Severity|enhancement                 |major

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This looks like a bug, not an enh :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:30:51 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-RHwYTep1zr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:31:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:31:09 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-darpJaZ7pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:31:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:31:13 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-YyB9AwLS6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51515|0                           |1
        is obsolete|                            |
  Attachment #51516|0                           |1
        is obsolete|                            |
  Attachment #51641|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51660&action=edit
Bug 9543 - Show patrons messaging subscription on holds notification

Display an information about a patron's messaging preferences if an item
is checked in where the patron has put a hold.

To test:

- Apply patch
- Make sure that SMS driver and TalkingTech sysprefs are defined to
  enable SMS and Phone preferences for users (SMS driver can be a dummy
  value)
- Place a hold for a patron
- Set patron's messaging preferences to different choices (including none)
- Check in the item that is on hold (it has not to be checked out for the
  test
- Verify that below the message "Hold found (item is already waiting") an
  information appears about the patron's messaging preferences.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Chris Kirby <christopherlawrencekirby at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:31:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:31:17 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-0RaTkjSpHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51661&action=edit
Bug 9543 - Show patrons messaging subscription on holds notification not
already waiting

Same plan as previous patch, but this one should show the message for a
hold not already waiting but not requiring a transfer (hold-found2 alert
        box)

Signed-off-by: Chris Kirby <christopherlawrencekirby at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:31:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:31:21 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-mCg8Oh6M0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51662&action=edit
Bug 9543 - (Follow-up) Show patrons messaging subscription on holds
notification

As of comment #19
- Code de-duplicated to a BLOCK statement
- Variable renamed
- Wording slightly changed. I like it that way, but feel free to change it
  in a follow-up

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:31:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:31:24 +0000
Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds
	notification
In-Reply-To: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9543-70-iN3iQ9iVeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51663&action=edit
Bug 9543: Separate MTT with commas

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:40:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:40:58 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-8xvADKdAVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:41:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:41:00 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-7AUzEQqoew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51593|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51664&action=edit
Bug 16539: Try to provide tests

Fix minor typo (testing CPL not MPL)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:41:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:41:35 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-CYVEER2KYc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
For me tests fail without patch and pass with it, back to signed off

(In reply to Jonathan Druart from comment #5)
> Nick, I have tried to provide tests for this change, but they pass even
> without your patch.
> Could you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:55:40 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-xLRlqVraVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:55:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:55:43 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-gTWprwAn9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51588|0                           |1
        is obsolete|                            |
  Attachment #51664|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51665&action=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 17:55:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 15:55:47 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-zzuoFLbB1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51666&action=edit
Bug 16539: Add tests

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:06:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:06:25 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ECywx7pOMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think we should gracefully handle errors, as it was before.
If C4::Installer::load_file encounters an error, Koha will crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:11:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:11:11 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-UfdDKJwYHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:11:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:11:13 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-YblerFHAsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51623|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51667&action=edit
Bug 16001 - Use standard message dialog when there are no cities to list

If there are no existing cities in Administration -> Cities and Towns,
the message saying so should be in the standard message dialog.

Another minor change: Edit the message to say "There are no cities
defined," which I think reads better in English.

To test you must have no cities and towns defined.

Apply this patch and go to Administration -> Cities and Towns. You
should see a message displayed in a standard "message" style dialog.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Better view, no errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:12:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:12:04 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-ZiWdF1IUZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:12:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:12:15 +0000
Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities
In-Reply-To: <bug-14888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14888-70-WvQy0IwU7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001
[Bug 16001] Use standard message dialog when there are no cities to list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:12:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:12:15 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-ak30WoJ97D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14888


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888
[Bug 14888] Move the cities related code to Koha::Cities
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:18:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:18:57 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-GPzaftHHos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We usually use "Clear all" instead of "Select none", should not we stick to the
existing wording?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:34:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:34:15 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-gVqAjuHEnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:34:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:34:19 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-nAlXEDSbmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51655|0                           |1
        is obsolete|                            |
  Attachment #51656|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51668&action=edit
Bug 16550: Can't set opac news expiration date to NULL, it reverts to today

This patch fixes an issue with the expiration dates for news always reverting
to today if empty.

To test:
- Apply patch
- Go to Home > Tools > News
- Create a news item, do not set expiration date
- Verify that expiration date stays empty
- Edit this news item
- Do not set expiration date
- Verify that expiration date stays empty
- Do the same with expiration dates
- Verify that they are saved properly

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:34:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:34:22 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-OTecUlytEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51669&action=edit
Bug 16550: Add test to NewsChannels.t

To test: Run t/db_dependent/NewsChannels.t

Tests adding and retreiving a news item without expiration date.
This test should fail without patch for Bug 16550 and pass OK with patch.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 18:34:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 16:34:26 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-tcElOeevYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51670&action=edit
Bug 16550: Clean the tests

- replace ok with is
- remove diag
- replace $dbh->prepare->execute->fetchrow with $dbh->selectrow_array

And remove unecessary force to scalar context in pl

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:02:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:02:23 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-uciFOIDa40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #109 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #108)
> (In reply to Jonathan Druart from comment #107)
> > (In reply to Tom?s Cohen Arazi from comment #106)
> > > I'm abandoning this bug. It went too far.
> > 
> > C'mon!!! :)
> > 
> > Question 1 on comment 102 was
> > 
> > > C4/Circulation.pm
> > > 1868     my $biblio   = $item_level_itypes ? undef : GetBiblioData( $item->{
> > > biblionumber } ); # don't get bib data unless we need it
> > > 
> > > Should not we use GetBiblioItemByBiblioNumber instead to avoid 2 left joins
> > > per return?
> > 
> > If you think I am right, I can provide a patch for that.
> 
> You are right :-D

Forget that, GetBiblioItemByBiblioNumber has a weird return.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:03:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:03:29 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-cvcUkhcQBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #110 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What about (really) deleted items?
The ones which is not in items or deleteditems table?
The update DB entry will raise the warning, but not sure it's relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:07:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:07:44 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-F6e4Elt3G3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #111 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #110)
> What about (really) deleted items?
> The ones which is not in items or deleteditems table?
> The update DB entry will raise the warning, but not sure it's relevant.

Forget that, again.

But what about deleted items, the ones in the deleteditems table?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:10:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:10:28 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14598-70-eZLwWr5Pe6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #112 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Before pushing this, it could be great to execute the update DB entry on a
large DB, which has been updated from several Koha versions.
Does anyone have that on hand?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:25:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:25:00 +0000
Subject: [Koha-bugs] [Bug 16521] <<item.*>> and <<biblio.*>> not expanding
 on DUE, PREDUE notices.
In-Reply-To: <bug-16521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16521-70-LXpfh6FVCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16521

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Barton,
I have tested with PREDUE with master and 3.22.x
(2293f85092714133d47bf846069d48c81e23e4f5) and biblio.title + items.barcode is
displayed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:32:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:32:09 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-rCcWqT67hC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51671&action=edit
Bug 13669: Re-adds error handling to load_sql

This patch prevents crashing in case an
error is detected when loading a file

To test:
1) Apply patch
2) Mangle kohastructure.sql or any sample
file adding and invalid SQL line
3) Run webinstaller and check that the error
is handled gracefully

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:34:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:34:52 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-rmwdEaniVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #31)
> I think we should gracefully handle errors, as it was before.
> If C4::Installer::load_file encounters an error, Koha will crash.

You are right, added a possible fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:36:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:36:00 +0000
Subject: [Koha-bugs] [Bug 12834] patron category with a category type
 written with an accent can't be deleted
In-Reply-To: <bug-12834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12834-70-K6P12Hp5Kj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12834

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is it still valid?
It seems that it's not possible (anymore?) to define a patron category with a
category code containing "?".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:46:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:46:15 +0000
Subject: [Koha-bugs] [Bug 16555] Managing patron self edits -- non
 superlibrarians can see patrons for other branches
In-Reply-To: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16555-70-yosozZAkcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16555

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10904
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Barton,
See bug 10904, did you check the perf IndependentBranchesPatronModifications?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:46:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:46:15 +0000
Subject: [Koha-bugs] [Bug 10904] Limit patron modification request
	management by branch
In-Reply-To: <bug-10904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-FxS19fppQD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16555

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 19:52:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 17:52:58 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-nu4FOKnFlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This should be fixed before the next release (soon!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 20:03:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 18:03:16 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-IskT5r0NYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I don't know if we should fail or continue actually, hard to say.
I would say we should block anything if an error occurs (and so do not execute
next files).
Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 20:17:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 18:17:02 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-4QwM5YfNfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #35 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #34)
> I don't know if we should fail or continue actually, hard to say.
> I would say we should block anything if an error occurs (and so do not
> execute next files).
> Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use.

Any behaviour change in that way would be a nice improvement, but it would need
to be discussed. Also, that would be an enhancement.
This is a blocker bugfix so Koha works on newer operating systems, with
backwards compatibility. Keeping the current behaviour, making it work. I think
we should push it if the Packaging manager agrees to package DBIx::RunSQL (it
only depends on DBI!) and add it to the repository.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 20:34:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 18:34:39 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-f5nDAPum9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #35)
> (In reply to Jonathan Druart from comment #34)
> > I don't know if we should fail or continue actually, hard to say.
> > I would say we should block anything if an error occurs (and so do not
> > execute next files).
> > Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use.
> 
> Any behaviour change in that way would be a nice improvement, but it would
> need to be discussed. Also, that would be an enhancement.
> This is a blocker bugfix so Koha works on newer operating systems, with
> backwards compatibility. Keeping the current behaviour, making it work. I
> think we should push it if the Packaging manager agrees to package
> DBIx::RunSQL (it only depends on DBI!) and add it to the repository.

Was about to say something similar. 
Also 'force' seems to hide the problems, just tried it and can't get number of
problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 21:33:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 19:33:37 +0000
Subject: [Koha-bugs] [Bug 16558] New: Option to choose to include or exclude
 bibs without items when exporting records
Message-ID: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16558

            Bug ID: 16558
           Summary: Option to choose to include or exclude bibs without
                    items when exporting records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: sfayle at roseman.edu
        QA Contact: testopia at bugs.koha-community.org

The addition of an option to "don't export" or "export" bibs without items in
the export data tool. 

Some libraries may need to export only bibs without items or conversely they
may want to only export bibs with items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 21:36:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 19:36:53 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-bYsUDXAz6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

--- Comment #7 from Suzanne Fayle <sfayle at roseman.edu> ---
(In reply to Nick Clemens from comment #5)
> I think this is an excellent suggestion, but I think it is beyond the scope
> of this bug report (internal functionality vs display/user interface). 
> 
> Would you open a new bug for this Suzanne?
> 
> (In reply to Suzanne Fayle from comment #3)
> > Or under options have a checkbox to include bibs without item records in the
> > export? So that checking the box would export the bibs without items.

See Bug 16558. Thanks, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 20 21:38:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 May 2016 19:38:39 +0000
Subject: [Koha-bugs] [Bug 16558] Option to choose to include or exclude bibs
 without items when exporting records
In-Reply-To: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16558-70-SI6MfMYVna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16558

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 02:08:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 00:08:05 +0000
Subject: [Koha-bugs] [Bug 16529] Clean up and improve upload template
In-Reply-To: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16529-70-D7LSvlPxIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Owen Leonard from comment #1)
>   - Confirm that this window has a layout which is adjusted for the size
>     of the window.

What 'adjusted' means?
Fieldset's width is fixed, always centered.
If that's Ok I'll sign

Comment: 'Close' button on page bottom looks different from the others: rounded
corners and bold font.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 08:15:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 06:15:33 +0000
Subject: [Koha-bugs] [Bug 16559] New: [%% ... %%] should not be picked for
	translation
Message-ID: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559

            Bug ID: 16559
           Summary: [%% ... %%] should not be picked for translation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Examples in Koha 16.05:

%s [%% INCLUDE "openlibrary-readapi.inc" bib = { normalized_isbn =>
normalized_isbn, lccn => lccn, normalized_oclc => normalized_oclc } %%] 

%s [%% UNLESS hidden.defined('phone') && hidden.defined('phonepro') &&
hidden.defined('mobile') && hidden.defined('email') &&
hidden.defined('emailpro') && hidden.defined('fax') %%] 

In Pootle, a search for [%% has 40 results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 09:14:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 07:14:05 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-H6gzH4YNdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Yes, I agree: fix without change in the behavior.

That's why I think we should update the patch :)

Without the patch the errors are log into the Koha log file and there is not
crash
With the patch, there is nothing in the log file and Koha crashes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 09:16:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 07:16:53 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ajQ0NyCwL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #37)
> Without the patch the errors are log into the Koha log file and there is not
> crash
> With the patch, there is nothing in the log file and Koha crashes.

Sorry, forgot to apply the last patch locally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 09:36:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 07:36:28 +0000
Subject: [Koha-bugs] [Bug 16560] New: Translatability: Issues in
	opac-memberentry.tt
Message-ID: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560

            Bug ID: 16560
           Summary: Translatability: Issues in opac-memberentry.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

In opac-memberentry.tt, the following parts lead to translaiton errors because
of sentence splitting by tags:

<strong>The entered <a href="#borrower_cardnumber">card number</a> is the wrong
length.</strong>

<strong>The entered <a href="#borrower_cardnumber">card number</a> is already
in use.</strong>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:05:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:05:55 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ARjkXsQnbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51672&action=edit
Bug 13669: Catch the errors to have them to the logs

This patch redirect STDERR to a variable to retrieve the errors raised
by the DBMS when loading a sql file, it could be useful to debug errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:14:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:14:40 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-VWiz6qnRIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:14:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:14:43 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-NB6GK4tt4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51673&action=edit
Bug 16527: Restore sticky due date behavior

Bug 10067 has introduced a regression on the sticky due date behavior:
If "remember for session" is checked and the due date is changed from 1
checkout to another, the old due date will be used.

The code added by bug 10067 is really confusing and it's hard to say
this patch won't introduce another regression.
The manipulation of $restoreduedatespec, $duedatespec and $stickyduedate
is not easy to follow.

Test plan:
Confirm that the regression is fixed and that this patch will not
introduced a regression on bug 10067 (good luck!)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:15:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:15:02 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-azQqLQ2Xqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:20:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:20:06 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-H0u2NdikyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Koha Team Lyon 3 from comment #8)
> Ok, Thanks Nicole, I understand and I share the "setting principle" that
> allow librarians to choose the key to deduplicate.
> I will test the patch with unimarc file to see if it's ok for us.

Do you think you will have time to test it before the release?
It's a critical one and we need it fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:20:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:20:19 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-bAeEszqyBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.05                       |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:43:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:43:01 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-cCCSK8Uh2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:43:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:43:04 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-i9g9IQPeU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51543|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51674&action=edit
Bug 16505: <collection> is missing the marc namespace and updates fail if -x is
passed

Using rebuild_zerba.pl with the -x option switch, produces an incorrect output
in
terms of what our XSLTs expect for indexing. This patch introduces the right
namespace information
on the exported records so indexing succeeds.

To test:
- On current master, have some records on your db
- Run:
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
=> you will get a message like this:

NOTHING cleaned : the export /tmp/NL5ufjUfpp has been kept.

- Run
  $ less /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: The first line looks like this

<?xml version="1.0" encoding="UTF-8"?><collection><record

- Now run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/NL5ufjUfpp/biblio/exported_records
=> FAIL: No output
- Apply the patch
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -r -b -k -x
- Take a look at the result file:
  $ less /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: The start of the file looks like this:
<?xml version="1.0" encoding="UTF-8"?><collection
xmlns="http://www.loc.gov/MARC21/slim">

- Run:
  $ xsltproc \
     /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
     /tmp/asdiouqwiue/biblio/exported_records
=> SUCCESS: There is actually indexing data :-D
- Sign off :-D

Edit: I changed qq{} for q{} as suggested by Jonathan.

Sponsored-by: American Numismatic Society

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described following test plan
No errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:46:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:46:34 +0000
Subject: [Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode
In-Reply-To: <bug-12641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12641-70-oHAaECuNwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16506


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506
[Bug 16506] rebuild_zebra.pl still using USMARC as default
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 10:46:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 08:46:34 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-WrNJKDzQlI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12641
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641
[Bug 12641] Formally deprecate the GRS-1 indexing mode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:04:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:04:16 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-epAK9DtgkX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #10 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Ok, I can test it on monday. Is it too late ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:22:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:22:43 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-qYnxRR4cMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:22:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:22:47 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-YIunBOjcyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51566|0                           |1
        is obsolete|                            |
  Attachment #51567|0                           |1
        is obsolete|                            |
  Attachment #51568|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51675&action=edit
Bug 16506: Make rebuild_zebra.pl use XML as default

This patch deprecates the -x switch, making XML the default serialization
format
used by rebuild_zebra.pl. It doesn't remove the option switch, but raises a
warning
for the end user about the deprecation so they fix their cronjobs. Later we
could remove it.

To test:
- Disable all indexing (daemon/cronjob)
- Create 2 records
- Edit one of them, delete the other one
- Verify they are queued for updates in zebraqueue
- sudo koha-mysql kohadev
  > SELECT * FROM zebraqueue WHERE done=0
...
| 265 |                265 | specialUpdate | biblioserver |    1 | 2016-05-13
14:23:45 |
| 266 |                  1 | recordDelete  | biblioserver |    1 | 2016-05-16
14:14:33 |
| 267 |                  2 | specialUpdate | biblioserver |    1 | 2016-05-16
14:15:06 |
+-----+--------------------+---------------+--------------+------+---------------------+
- Now go to koha-shell
  $ sudo koha-shell kohadev ; cd kohaclone
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> FAIL: They contain the records you added/modified/deleted but they are in
         USMARC format
- Apply the patch
- Mark your records for indexing (in koha-mysql kohadev)
  > UPDATE zebraqueue SET done=0 WHERE id > 264
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
<WARNINGS> [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in XML format
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z -noxml

  You will get something similar to this:
<WARNINGS> [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in USMARC format
- Sign off :-D

[1] Warnings covered by a followup

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
On top of Bug 16505
Work as described following test plan, usmarc default pre patch,
post patch xml default and usmarc on request.
No errors (all patchset)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:22:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:22:50 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-ciJjhZ6Id3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51676&action=edit
Bug 16506: (Followup) remove warnings

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:22:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:22:54 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-gUty6xUCu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51677&action=edit
Bug 16506: (followup) Fix wrong option switch warning message

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:23:00 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-Gu5ljd8oWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51678&action=edit
Bug 16506: Remove warning for UNIMARC installs

Use of uninitialized value in numeric eq (==)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:24:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:24:21 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-j6reseGXRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51679&action=edit
Bug 16505: Make sure $as_xml will not be used later

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 11:27:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 09:27:02 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-KQX1UsJgqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Koha Team Lyon 3 from comment #10)
> Ok, I can test it on monday. Is it too late ?

No, Koha 16.05 will be released on May 26th :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 13:03:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 11:03:03 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-yaQg73Txnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

--- Comment #4 from Eivin Giske Skaaren <eivin at sysmystic.com> ---
I am without a koha dev env because my laptop died.. Installing another
computer today.

The stickyduedate behaviour and 10067 is confusing because there is some jquery
code that intercepts the request and I had to send that data to serverside
somehow to be able to manipulate. (from the top of my head..)

If I am able to get a dev env up and running I will look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 13:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 11:30:25 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-d0kzEcRPFt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Jesse,
It does not work for me, could you please have a look at the test plan and make
sure all tests are listed?
For instance, it seems that debian/templates/apache-shared-intranet-plack.conf
and debian/templates/apache-shared-opac-plack.conf need to be copied (I did but
still does not work).

Code review:
Should not we test if the headers mod is enabled in
debian/templates/apache-site.conf.in?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 13:30:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 11:30:41 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-92uNOe61Qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #11)
> Jesse,
> It does not work for me, could you please have a look at the test plan and
> make sure all tests are listed?

s/tests/steps

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 13:35:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 11:35:56 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-G1UdkTVNTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Jonathan, what i did for testing was applying the changes manually to my
kohadevbox instance. I agree the headers module should be correctly checked. 
The patched config files worked for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 13:58:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 11:58:12 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-fYiiSrdY78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #13)
> Jonathan, what i did for testing was applying the changes manually to my
> kohadevbox instance. I agree the headers module should be correctly checked. 
> The patched config files worked for me.

Yep I have double checked everything and it now works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:00:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:00:08 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-rzTpCQ5Ocy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have to admit I am a bit lost with all the apache config files, but should
not we move the RequestHeader add X-Koha-SetEnv lines to
apache-shared-[intranet|opac]-plack.conf files?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:02:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:02:31 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-bVfQoe8a2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
In C4::Context->preference, the lc $var has been moved after the
OVERRIDE_SYSPREF_* check, I don't think it's expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:05:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:05:52 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-wCTE4sUOsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
108     # We also add the MEMCACHED_ settings to the actual environment, to
make sure any early
109     # initialization of Koha::Cache correctly sets up a memcached
connection.
110     foreach my $special_var ( qw( MEMCACHED_SERVERS MEMCACHED_NAMESPACE ) )
{
111         $ENV{$special_var} = $setenvs{$special_var} if defined
$setenvs{$special_var};
112     }

Jesse, could you explain in which cases this is useful?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:07:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:07:12 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-HyKvYaqXUM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:14:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:14:50 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-NqfDKdxEPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51672|0                           |1
        is obsolete|                            |

--- Comment #40 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51680&action=edit
[SIGNED-OFF] Bug 13669: Catch the errors to have them to the logs

This patch redirect STDERR to a variable to retrieve the errors raised
by the DBMS when loading a sql file, it could be useful to debug errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
It's better of course, trying to load a failed fiel
it outputs mysl errors
DBD::mysql::st execute failed: You have an error in your SQL syntax...
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:16:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:16:30 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-kyQ0BysJ1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #41 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
> 
> Sorry, forgot to apply the last patch locally.

Forgot to sing also :)
I've signed yours, can't sign mine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:19:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:19:57 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-NktwxnbGax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 51624
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51624
[SIGNED-OFF] Bug 15878 - Updated unit tests for hbyymmincr barcodes

Review of attachment 51624:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15878&attachment=51624)
-----------------------------------------------------------------

::: t/db_dependent/Barcodes.t
@@ +84,4 @@
>  };
>  
>  
> +$schema->storage->txn_begin;

There is an issue (existed before this patch), the transaction should begin in
the subtests.

@@ +96,5 @@
> +            source => 'Branch',
> +            branchcode => 'LETTERS',
> +            });
> +
> +    my $branchcode_1 = "LETT";

LETT vs LETTERS?
$barcode_branch is never used later.

@@ +97,5 @@
> +            branchcode => 'LETTERS',
> +            });
> +
> +    my $branchcode_1 = "LETT";
> +    print "$branchcode_1\n";

Unused debug statement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:22:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:22:21 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-xNi0gAlK0v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:13 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-QxUtsnSWCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:34 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-B9YMZjfjzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:38 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-Vgg96McmHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51600|0                           |1
        is obsolete|                            |
  Attachment #51601|0                           |1
        is obsolete|                            |
  Attachment #51608|0                           |1
        is obsolete|                            |
  Attachment #51671|0                           |1
        is obsolete|                            |
  Attachment #51680|0                           |1
        is obsolete|                            |

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51681&action=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:43 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-XwKXAFOwIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51682&action=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted

The current table creation order is left to mysql's strategy, which is not
suitable for parsing the SQL files and passing one statement at a time in
the current order.

This patch just moves table creation statements around so FK constraints are
defined for previously created tables.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:47 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-5urwMplj1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51683&action=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.7        66.5
58.6        66.0

b) SQL::SplitStatement (patch 1+2)
59.4        101
59.7        102

c) DBIx::RunSQL (patch 3)
60.7        66.8
59.4        66.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:54 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-BMJrAo5AHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51684&action=edit
Bug 13669: Re-adds error handling to load_sql

This patch prevents crashing in case an
error is detected when loading a file

To test:
1) Apply patch
2) Mangle kohastructure.sql or any sample
file adding and invalid SQL line
3) Run webinstaller and check that the error
is handled gracefully

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:33:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:33:59 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-9KL6EB11E1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51685&action=edit
Bug 13669: Catch the errors to have them to the logs

This patch redirect STDERR to a variable to retrieve the errors raised
by the DBMS when loading a sql file, it could be useful to debug errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
It's better of course, trying to load a failed fiel
it outputs mysl errors
DBD::mysql::st execute failed: You have an error in your SQL syntax...
No errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:38:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:38:09 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-9Kesn9ETev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:38:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:38:12 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-CwtozQUsKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51657|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51686&action=edit
Bug 16005 - Standardize use of icons for delete and cancel operations

This patch makes changes to Font Awesome icons in order to make icon
choice consistent for common actions.

<i class="fa fa-trash"></i> where something is deleted, removed, or
emptied.

<i class="fa fa-remove"></i> where an operation is cancelled (also where
selections are cancelled, as in checkboxes).

<i class="fa fa-times-circle"></i> for "close," as in baskets and
windows.

To test, apply the patch and view the following pages to confirm that
the correct icon is used:

- Acquisitions -> Vendor -> Vendor delete button.
- Acquisitions -> Vendor -> Edit -> Delete contact button.
- Acquisitions -> Invoices ->  Delete menu item.
- Cataloging -> Edit record -> Authority search pop-up (triggered from
  the tag editor for a tag linked to an authority) -> Clear field button
- Authorities -> Authority detail -> Delete button.
- Tools -> Quotes editor -> Quotes delete button.
- Reports -> View saved report -> Delete button.
- Reports -> Saved reports -> Delete menu item.
- Serials -> Subscription details -> Subscription close button.
- Administration -> Budgets -> Delete menu item.
- Administration -> Item search fields -> Delete button.
- Administration -> Z39.50/SRU servers -> Delete menu item.
- Catalog -> Advanced search -> Clear fields link.
- Cataloging -> Advanced editor -> Macros -> Delete macro button.
- Circulation -> Checkout -> Check out an item which is on hold for
  another patron. "Cancel checkout and place hold" button now uses the
  icon used elsewhere for holds.
- Course reserves -> Course -> Delete course button.
- Patrons -> Patron lists -> Add patrons -> Remove selected button.
- Acquisitions -> Suggestions -> Suggestion details -> Delete button.
- Lists -> List contents -> Remove selected button.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 14:40:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 12:40:41 +0000
Subject: [Koha-bugs] [Bug 16005] Standardize use of icons for delete and
 cancel operations
In-Reply-To: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16005-70-gsc2GyKrCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I did not test every pages, but the diff looks good.

It would be great to have an entry on the wiki page
(https://wiki.koha-community.org/wiki/Interface_patterns) to list the different
icons to use (and when to use them).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 15:18:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 13:18:56 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-P4RexEcTDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51687&action=edit
Bug 16534: Do not process the checkout if the checkin has failed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 21 15:20:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 13:20:05 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-XboAg3F4xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
            Version|3.20                        |unspecified
             Status|NEW                         |ASSIGNED

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This patch should do the trick, but I will need to write some tests to make it
pushable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 01:43:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 23:43:00 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-7PRCwXOFfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 01:43:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 May 2016 23:43:03 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-9unsGv7rfR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51688&action=edit
Bug 15878 - QA Followup

* Remove debug statment
* Move transcation start
* Remove unused testbuilder object

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:13:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:13:44 +0000
Subject: [Koha-bugs] [Bug 16561] New: Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
Message-ID: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

            Bug ID: 16561
           Summary: Regression caused by 15877 - t/db_dependent/Barcodes.t
                    deletes all items from a DB
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: nick at bywatersolutions.com
        QA Contact: gmcharlt at gmail.com

When attempting to avoid accidental deletion of items in Barcodes.t, I instead
caused total deletion of items and issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:14:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:14:33 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-W0em7HUoOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:14:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:14:35 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-GvL7RDelVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51689&action=edit
Bug 16561 - Followup to fix tests

When I altered the tests to avoid accidental deletion of all items, I
didn't rollback the transaction, hence the tests now delete all items
from a db when run.

This patch rollsback the transaction so items are not deleted from your db

To test:
1 - Backup your db
2 - prove -v t/db_dependent/Barcodes.t
3 - Note that all items and issues are deleted from the DB
4 - Restore your DB
5 - Apply this patch
6 - prove -v t/db_dependent/Barcodes.t
7 - Your DB should eb unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:14:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:14:55 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-f4fxEmrg6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16561


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561
[Bug 16561] Regression caused by 15877 - t/db_dependent/Barcodes.t deletes all
items from a DB
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:14:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:14:55 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-v93H4Lf5HH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15878


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878
[Bug 15878] C4::Barcodes::hbyymmincr inccorectly calculates max and should warn
when no branchcode present
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:20:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:20:32 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-B1YOjX8vZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51624|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51690&action=edit
Bug 15878 - Updated unit tests for hbyymmincr barcodes

Test plan in second patch

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:20:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:20:50 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-WwzRL2l9H5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51625|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51691&action=edit
Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn
when no branchcode present

Test plan:

1 - prove t/db_dependent/Barcodes.t
2 - All should pass
3 - Apply first patch (unit tests update)
    4 - Tests should fail on values and warnings
    5 - Apply second patch
    6 - All tests should now pass

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described
Removed tab on line 47 of C4/Barcodes/hbyymmincr.pm
No more qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 02:20:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 00:20:55 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-MvvpkBSzAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51688|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51692&action=edit
Bug 15878 - QA Followup

* Remove debug statment
* Move transcation start
* Remove unused testbuilder object

Rebased on top of 16561

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 08:31:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 06:31:50 +0000
Subject: [Koha-bugs] [Bug 16562] New: Translatability: Issue in opac-user.tt
 (separated word 'item')
Message-ID: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

            Bug ID: 16562
           Summary: Translatability: Issue in opac-user.tt (separated word
                    'item')
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

The following sentence needs a better wording to avoid translation problems: 
Pending for next available <i>[% ItemTypes.GetDescription( RESERVE.itemtype )
%]</i> item

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 08:45:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 06:45:10 +0000
Subject: [Koha-bugs] [Bug 16563] New: Translatability: Issues in
 opac-account.tt (sentence splitting)
Message-ID: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

            Bug ID: 16563
           Summary: Translatability: Issues in opac-account.tt (sentence
                    splitting)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Following sentences in opac-account.tt have a translatability problem
(splitting by tags):

<p>A payment with the transaction id <i>[% message_value %]</i> has already
been posted to an account.</p>

<p>The transaction id <i>[% message_value %]</i> for this payment is
invalid.</p>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 08:49:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 06:49:32 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
 (tag-isolated word 'Logout')
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-X9zkfFQhe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Additional issue:
 <p>If you want to, you can try to <a
href="/cgi-bin/koha/svc/auth/googleopenidconnect?reauthenticate=select_account">log
in using a different account</a>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:14:44 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-gwxhU2tQNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |15877


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877
[Bug 15877] C4::Barcodes  does not correctly calculate db_max for 'annual'
barcodes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:14:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:14:44 +0000
Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate
 db_max for 'annual' barcodes
In-Reply-To: <bug-15877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15877-70-zW6L4yynnS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16561


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561
[Bug 16561] Regression caused by 15877 - t/db_dependent/Barcodes.t deletes all
items from a DB
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:15:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:15:38 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-Ob47X3W7Bh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:17:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:17:04 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-ACXYFqvXBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:17:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:17:08 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-lCt4Q6jm9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51689|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51693&action=edit
Bug 16561 - Bug 15877 followup to fix tests

When I altered the tests to avoid accidental deletion of all items, I
didn't rollback the transaction, hence the tests now delete all items
from a db when run.

This patch rollsback the transaction so items are not deleted from your db

To test:
1 - Backup your db
2 - prove -v t/db_dependent/Barcodes.t
3 - Note that all items and issues are deleted from the DB
4 - Restore your DB
5 - Apply this patch
6 - prove -v t/db_dependent/Barcodes.t
7 - Your DB should eb unchanged

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:18:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:18:10 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-HSPKD4O2Dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have amended the patch to fix alignment and commit message (to display bug
15877).

Skipping QA as it's a trivial one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:24:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:24:57 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-2U9kQPKeDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:25:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:25:00 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-zhklKX6DQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51690|0                           |1
        is obsolete|                            |
  Attachment #51691|0                           |1
        is obsolete|                            |
  Attachment #51692|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51694&action=edit
Bug 15878 - Updated unit tests for hbyymmincr barcodes

Test plan in second patch

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Bug 15878 - QA Followup

* Remove debug statment
* Move transcation start
* Remove unused testbuilder object

Rebased on top of 16561

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:25:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:25:07 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-ezdOLRVMTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51695&action=edit
Bug 15878 - C4::Barcodes::hbyymmincr inccorectly calculates max and should warn
when no branchcode present

Test plan:

1 - prove t/db_dependent/Barcodes.t
2 - All should pass
3 - Apply first patch (unit tests update)
    4 - Tests should fail on values and warnings
    5 - Apply second patch
    6 - All tests should now pass

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described
Removed tab on line 47 of C4/Barcodes/hbyymmincr.pm
No more qa errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 09:25:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 07:25:42 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-bBIM5wJIwH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have squashed 1st & 3rd for the readability.
Thanks for the quick patch Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 10:43:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 08:43:24 +0000
Subject: [Koha-bugs] [Bug 16564] New: New Pattern Category cannot be
 created. Bounces with error: 'The Category might already exist'.
Message-ID: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

            Bug ID: 16564
           Summary: New Pattern Category cannot be created.  Bounces with
                    error: 'The Category might already exist'.
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: HP
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: gk.bmsit at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 51696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51696&action=edit
Patron Category Administration

OS: lubuntu 16.04
Koha: 3.22.06
System: HP Desktop
Mysql: 5.7

On creating a new pattern category, though no category exists, bounces with an
error message - 'An error occured when inserting this pattern category.  The
patron category might already exist.'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:20:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:20:26 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-TPQKR7iJhI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:20:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:20:29 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-cjqeTv5YFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51687|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51697&action=edit
Bug 16534: Add tests for CanBookBeIssued & AllowReturnToBranch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:20:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:20:34 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-vbNMSs1ACN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51698&action=edit
Bug 16534: Make CanBookBeIssued test if the issue can be returned

If an issue is already checked out, CanBookBeIssued must check if the
issue can be checked in before processing the return.
In such cases (depending of the AllowReturnToBranch pref), the issue
should not be allowed.

Prior to this patch, the checkin was not done and the checkout failed
with "Duplicate entry '1204321' for key 'itemnumber'". Indeed since bug
14978, there is an uniq key on issues.itemnumber. Before bug 14978 the
issue existed but was hidden (and some weird behaviors certainly
happened!).

To avoid Koha to crash, a check is added to CanBookBeIssued (call to
CanBookBeReturned) and the librarian is not able to process the
checkout.

Test plan:

- Set AllowReturnToBranch to anywhere
- Check an item (homebranch Library 1, holding branch Library 1) out from
Library 1
- Check the item out from Library 2
=> Confirm the checkout (should work with and without this patch)

- Set AllowReturnToBranch to holdinbranch ("only the library the item
  was checked out from").
- Check an item (homebranch Library 1, holding branch Library 1) out from
Library 1
- Check the item out from Library 2
=> Without this patch, Koha crashed
=> With this patch, you will be warned that the checkin is not possible.

Try other combinations of the AllowReturnToBranch syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:20:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:20:37 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-66V5Hih5Xm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51699&action=edit
Bug 16534: Add tests for AddIssue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:20:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:20:41 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-n9KqxCiM2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51700&action=edit
Bug 16534: Block AddIssue from issuing if the return is not possible

To make sure the return can be done, AddIssue must not trust callers (they
should have done their job, but we are not sure) and check that the issue can
be returned before issuing to the patron.

There is no test plan here, this should not be possible from the Koha
interface.
However, looking at the code, it may be possible using SIP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:21:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:21:48 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-UQcp1P2iql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #17)
> Created attachment 51700 [details] [review]
> Bug 16534: Block AddIssue from issuing if the return is not possible
> 
> To make sure the return can be done, AddIssue must not trust callers (they
> should have done their job, but we are not sure) and check that the issue can
> be returned before issuing to the patron.
> 
> There is no test plan here, this should not be possible from the Koha
> interface.
> However, looking at the code, it may be possible using SIP.

This commit message is awful and does not meant anything but I hope it will be
understood anyway :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:23:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:23:13 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
	item
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-NqbAg15c6m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13790, 14978
           Severity|major                       |critical

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think this is a critical for versions with and without bug 13790 and bug
14978. Feel free to lower the severity if you think I am wrong.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790
[Bug 13790] Add unique id issue_id to issues and old_issues tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978
[Bug 14978] issues.itemnumber should be a unique key
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:23:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:23:13 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-crNE8lTU9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16534


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534
[Bug 16534] Error when checking out already checked out item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:23:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:23:13 +0000
Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key
In-Reply-To: <bug-14978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14978-70-bUIbYWIx3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16534


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534
[Bug 16534] Error when checking out already checked out item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:23:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:23:37 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-3ksAmHxO1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Error when checking out     |Error when checking out
                   |already checked out item    |already checked out item
                   |                            |(depending on
                   |                            |AllowReturnToBranch)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:37:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:37:03 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-EpLjdydD6B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's by design, with multi holds the next available item is automatically
selected.
I'd say this is more an enhancement request than a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 11:38:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 09:38:46 +0000
Subject: [Koha-bugs] [Bug 16558] Option to choose to include or exclude bibs
 without items when exporting records
In-Reply-To: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16558-70-HmGk2rzEOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16558

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This is more an enhancement request than a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 12:32:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 10:32:49 +0000
Subject: [Koha-bugs] [Bug 16564] New Patron Category cannot be created.
 Bounces with error: 'The Category might already exist'.
In-Reply-To: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16564-70-j6kGR4gu34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|New Pattern Category cannot |New Patron Category cannot
                   |be created.  Bounces with   |be created.  Bounces with
                   |error: 'The Category might  |error: 'The Category might
                   |already exist'.             |already exist'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 12:33:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 10:33:04 +0000
Subject: [Koha-bugs] [Bug 16564] New Patron Category cannot be created.
 Bounces with error: 'The Category might already exist'.
In-Reply-To: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16564-70-EraqVHrxui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com
          Component|Authentication              |System Administration
           Assignee|gmcharlt at gmail.com          |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 13:52:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 11:52:36 +0000
Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for
	translation
In-Reply-To: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16559-70-9JFIUiGYrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It happens when TT directive are on several lines.
I tried to fix C4::TTParser::text but failed.
I don't know how to fix this one correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 19:39:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 17:39:02 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-cc5XiPDc4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have installed the dependency from CPAN, made sure that the database was
empty, applied the patches and ran the web installer in English. But I still
get errors, any idea what's going wrong there?

Help?

[Sun May 22 19:38:37 2016] install.pl: Use of uninitialized value in numeric lt
(<) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22
19:38:37 2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: DBD::mysql::st execute failed: BLOB, TEXT, GEOMETRY or JSON
column 'defaultvalue' can't have a default value at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254.

Please contact your system administrator

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 21:47:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 19:47:42 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-JgkLaj46mm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Eivin Giske Skaaren <eivin at sysmystic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51673|0                           |1
        is obsolete|                            |

--- Comment #5 from Eivin Giske Skaaren <eivin at sysmystic.com> ---
Created attachment 51701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51701&action=edit
[SIGNED-OFF] Bug 16527: Restore sticky due date behavior

Bug 10067 has introduced a regression on the sticky due date behavior:
If "remember for session" is checked and the due date is changed from 1
checkout to another, the old due date will be used.

The code added by bug 10067 is really confusing and it's hard to say
this patch won't introduce another regression.
The manipulation of $restoreduedatespec, $duedatespec and $stickyduedate
is not easy to follow.

Test plan:
Confirm that the regression is fixed and that this patch will not
introduced a regression on bug 10067 (good luck!)

Signed-off-by: Eivin Giske Skaaren <eivin at sysmystic.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 21:48:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 19:48:13 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-a8xdRbFOz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Eivin Giske Skaaren <eivin at sysmystic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 22 21:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 19:57:27 +0000
Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected
	behaviour
In-Reply-To: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16527-70-iAac1SSCK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

--- Comment #6 from Eivin Giske Skaaren <eivin at sysmystic.com> ---
This change seems to fix the issues raised by Nick but I also noticed when
testing and trying to understand 10067 again that there has been other changes
to the parts of Koha we are dealing with here.. (And the mix of TT, jQuery and
Perl to handle this together with the highholds is pretty confusing.)

Another regression might be that the decreaseLoanHighHolds does not work
anymore. There was several changes to that since last I looked into this and
when testing on a new kohadevbox the checkout length was not decreased, even
when the new checkbox "Don't decrease checkout length based on holds" was not
selected.

That has nothing to do with this patch however so I signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 00:11:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 May 2016 22:11:26 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-Duq4VozGaP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #48 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Katrin Fischer from comment #47)
> I have installed the dependency from CPAN, made sure that the database was
> empty, applied the patches and ran the web installer in English. But I still
> get errors, any idea what's going wrong there?
> 
...

I can confirm similar problems on Ubuntu 16.05, Myslq 5.7
My test where not done on this kind of system, sorry :(

In case the problem where from DBIX::RunSQL (which gives problems),
I wrote a revision using Tomas' approach (SQL::SplitStatment), and found
the same problems

[Sun May 22 18:49:18 2016] install.pl: DBD::mysql::db do failed: BLOB, TEXT,
GEOMETRY or JSON column 'defaultvalue' can't have a default value at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443. [Sun May 22 18:49:51 2016]
install.pl: DBD::mysql::db do failed: Invalid default value for 'created_on' at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443. [Sun May 22 18:49:52 2016]
install.pl: DBD::mysql::db do failed: Cannot add foreign key constraint at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443. [Sun May 22 18:49:52 2016]
install.pl: DBD::mysql::db do failed: Cannot add foreign key constraint at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 03:05:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 01:05:27 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-EtdeaIIqZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #49 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Errors are not in the procedeure, I tested extensively but on msyql < 5.6, so
this is specific to ver 5.6+ treatment of SQL, or 5.7 more specifically

1) table: auth_subfield_structure

line:  72   `defaultvalue` TEXT DEFAULT '',
error: (BLOB, TEXT, GEOMETRY or JSON column 'defaultvalue' can't have a default
value): CREATE TABLE `auth_subfield_structure`

Seems that we can't have default values here.

Ref: http://dev.mysql.com/doc/refman/5.7/en/blob.html
->" BLOB and TEXT columns cannot have DEFAULT values."

2) table: virtualshelves
line:  2212   `created_on` TIMESTAMP NOT NULL, -- creation time
error: (Invalid default value for 'created_on'): CREATE TABLE `virtualshelves`

Seems that first TIMESTAMP column in a table not explicitly nullable
automatically gets DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP

Could it be DATETIME instead of TIMESTAMP??

Reference
http://shankargopal.blogspot.com.ar/2013/03/mysql-566-timestamp-columns-and-default.html


3) and 4)
error: (Cannot add foreign key constraint): CREATE TABLE `virtualshelfcontents`
error: (Cannot add foreign key constraint): CREATE TABLE `virtualshelfshares`

This two because virtualshelves table not created

MORE
----
Fixing somehow previous kohastructure errors, we have more Errors in sample
data

auth_subfield_structure, (Incorrect integer value: '' for column 'linkid' at
row 1)
Here we have an error, '' instead of 0, MySQL < 5.6 tolerates this, 5.7 no

sample_patrons.sql, (Column 'address' cannot be null)

sample_quotes.sql, (Incorrect datetime value: '0000-00-00 00:00:00' for column
'timestamp' at row 1)

MySQL 5.7 does not like things like that.
Perhaps we can change the sql_mode for Koha globally, 
or fix all the sample data (not difficult) in all languages, 
and test/sign/QA everything... before release?

Ref:
https://www.digitalocean.com/community/tutorials/how-to-prepare-for-your-mysql-5-7-upgrade

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 03:56:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 01:56:46 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-FEKR4EHZjQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #7)
> If you write a patch, I write regression tests for it :-)

Thanks, Tomas :).

Used 'grep -l -R "Koha::Calendar" * --exclude-dir="blib" | xargs grep
"exception_holidays"' to try to find everything using Koha::Calendar and
exception_holidays... looks like it's only Koha::Calendar.

Looks like it's only Koha::Calendar::exeption_holidays() and
Koha::Calendar::is_holiday() as well.

I'm sure this issue pervades Koha, but perhaps we can resolve the problem in
this particular piece of it...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 04:30:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 02:30:34 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-fYxbhybY2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
There's something odd with that t/db_dependent/Plugins.t. Without the patch,
I've changed it:

diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t
index 3271b1a..c5faf87 100755
--- a/t/db_dependent/Plugins.t
+++ b/t/db_dependent/Plugins.t
@@ -43,7 +43,7 @@ ok( $plugin->get_qualified_table_name('mytable') eq
'koha_plugin_test_mytable',
 ok( $plugin->get_plugin_http_path() eq '/plugin/Koha/Plugin/Test', 'Test
$plugin->get_plugin_http_path()' );

 my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins(
'report' );
-ok( $plugins[0]->get_metadata()->{'name'} eq 'Test Plugin',
"Koha::Plugins::GetPlugins functions correctly" );
+is( $plugins[0]->get_metadata()->{'name'}, 'Test Plugin',
"Koha::Plugins::GetPlugins functions correctly" );

 SKIP: {
     my $plugins_dir = C4::Context->config("pluginsdir");


and I'm getting
not ok 18 - Koha::Plugins::GetPlugins functions correctly
#   Failed test 'Koha::Plugins::GetPlugins functions correctly'
#   at t/db_dependent/Plugins.t line 46.
#          got: 'Example Kitchen-Sink Plugin'
#     expected: 'Test Plugin'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 04:40:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 02:40:13 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-jkCnWUHICG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 04:40:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 02:40:16 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-9LJb7lN8lJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51702&action=edit
Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for
TZ America/Santiago

Using a DateTime object with a timezone of America/Santiago
was causing fatal errors for Koha::Calendar->is_holiday
and Koha::Calendar->exception_holidays, when the objects
were truncated to an invalid local time.

Using a floating zone allows us to use the same day, month, year
for comparison purposes without running into the possibility of
creating an invalid local time and thus a fatal software error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 04:52:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 02:52:34 +0000
Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe
In-Reply-To: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16441-70-trEGDVxDax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 04:52:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 02:52:36 +0000
Subject: [Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe
In-Reply-To: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16441-70-4qfCFuD5pG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51218|0                           |1
        is obsolete|                            |

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51703&action=edit
[SIGNED-OFF] Bug 16441: Do not use a package variable to cache
C4::Letters::getletter

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.

No test plan here, just confirm that the changes make sense.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 05:00:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 03:00:46 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-LGrlftIIs7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 05:00:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 03:00:49 +0000
Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch
 requires 'routing' permission
In-Reply-To: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16459-70-g9XbCqKkyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51295|0                           |1
        is obsolete|                            |

--- Comment #6 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51704&action=edit
[SIGNED-OFF] Bug 16459: Add patron to a patron card requires catalogue
permission

Currently, serials => 'routing' is required, which does not make any
sense.
It's a copy/paste error when this file has been created (you can blame
me).

Note that I am not sure catalogue is the correct permission, but it's
the one used almost everywhere in this module

Test plan:
Confirm that catalogue is enough to search for patrons to add to a
patron card.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 05:01:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 03:01:03 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-hDR51QrxLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 05:01:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 03:01:07 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-TejVEXcUnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51565|0                           |1
        is obsolete|                            |

--- Comment #91 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51705&action=edit
Bug 10662 - Icarus job server and Koha UI for it

NOTE: You cannot use koha-gitify to test changes to koha-conf.xml
NOTE: Check koha_perl_deps.pl; you may need to install POE.pm

<To be updated>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 06:07:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 04:07:02 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-2XlRKShyCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #11)
> [1] Although your changes in SimpleSearch are very small, it would probably
> help if you would add a test case in t/db_dependent/Search.t. (It seems to
> fail some tests currently, separate from your patch.)

When I run "prove t/db_dependent/Search.t", it says that all tests are
successful, although there are lots of warnings generated.

I'll review the test code to see if I can add a test...

> [2] The source_normalizer or norms just lead me to two FIXMEs:
> # FIXME normalize, substr
> # FIXME - default normalizer

These FIXME messages pre-date my patch. 

> You introduce none and raw in the regex while this field actually does
> nothing (and should not have been there in this stage). 

I don't understand this sentence.

> Your patch starts
> using this field, while the only thing you want is not running _normalize
> for (mainly?) URLs. 

URLs are certainly the main thing I want to not normalize, but honestly nothing
should be normalized during the matching, as Zebra already handles
normalization for search queries.

> If we do not really solve the problem of this unused
> field, I think we should not touch it. BTW What would be the difference
> between raw and none? The regex suggests more than what we offer.

There is no difference between raw and none. They're just synonyms. 

I'm open to removing _normalize() from the matching completely. Honestly, I
figured that the community would be against it, so I created a way of opting
out of the default _normalize(). That way default system behaviour doesn't
change, while some people will know how to deactivate it.

> [3] I have some doubts about this new condition:
>     if ($QParser && $matchpoint->{'index'} !~ m/\w,\w/) {
> Somehow you managed to bump in another unfinished area here too :) 
> I would rather leave the condition as it was. In the QParser branch you
> could choose to ignore/remove the second specifier word with a similar regex.
> 

It's not really a new condition. If you look at C4::Search::SimpleSearch,
you'll see that it's already there:

$QParser = C4::Context->queryparser if
(C4::Context->preference('UseQueryParser') && ! ($query =~ m/\w,\w|\w=\w/));

Also, you can't remove the second specifier word, because it's essential to the
query. You also can't ignore it, because the QParser can't handle it. That's
why I added the same condition that's found in C4::Search::SimpleSearch. You
need to catch this condition before going into the QParser code block.


--

Can the QA team indicate how to proceed? 

I'll look at adding a unit test. However, the QParser condition or one similar
to it needs to stay. As for _normalize(), I'll remove it completely, if that's
a change which will be accepted by the QA team and the RM.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 06:21:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 04:21:44 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-lb1dkJIqVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #11)
> [1] Although your changes in SimpleSearch are very small, it would probably
> help if you would add a test case in t/db_dependent/Search.t. (It seems to
> fail some tests currently, separate from your patch.)

I've reviewed Matcher.pm and Search.pm, an I don't think it would be possible
to add a test case. The functions aren't atomic enough. The altered behaviour
is internal to the functions and thus I don't see any way to automatically test
it.

Changing status back to Signed Off. 

Happy to discuss further or implement changes where necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 06:58:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 04:58:30 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
	page
In-Reply-To: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10756-70-bR8f2NCgrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #22 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #21)
> (In reply to Mason James from comment #20)
> > (In reply to Jonathan Druart from comment #17)
> > > (In reply to Marcel de Rooy from comment #13)
> > > > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> > > > If there is no further development(?), this might be a risk.
> > > 
> > > I can see that as blocker, Mason, would it be easy to update the plugin you
> > > used?
> > 
> > Jonathan, can you please suggest a replacement for ContentFlow, so I may
> > proceed
> 
> I have no idea, but reading the previous comment it seems that jcarousel or
> jquery-flipster could be good candidates.
> Kyle, any ideas?

my humble opinion is that aesthetically flipster is a better choice for the
style of this feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:10:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:10:29 +0000
Subject: [Koha-bugs] [Bug 16564] New Patron Category cannot be created.
 Bounces with error: 'The Category might already exist'.
In-Reply-To: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16564-70-lNaDGuM5jj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

--- Comment #1 from Gopalakrishna <gk.bmsit at gmail.com> ---
There is a need to check the kohastructure.sql thoroughly to comply with MySql
5.7

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:36:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:36:34 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-1boYHLIORC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #20 from Marc V?ron <veron at veron.ch> ---
Reproduced on current master.
Testing...
All patches applied.
Error is gone.

Test t/db_dependent/Circulation.t pass (with empty tables reserves,
old_reserves, old_issues)

Reset, apply patches for t/db_dependent/Circulation.t only
Test t/db_dependent/Circulation.t do not pass (as expected)

Going to sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:38:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:38:41 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-mK77kh2cnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51697|0                           |1
        is obsolete|                            |

--- Comment #21 from Marc V?ron <veron at veron.ch> ---
Created attachment 51706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51706&action=edit
Bug 16534: Add tests for CanBookBeIssued & AllowReturnToBranch

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:39:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:39:58 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-B0gQh8Dwej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51698|0                           |1
        is obsolete|                            |

--- Comment #22 from Marc V?ron <veron at veron.ch> ---
Created attachment 51707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51707&action=edit
Bug 16534: Make CanBookBeIssued test if the issue can be returned

If an issue is already checked out, CanBookBeIssued must check if the
issue can be checked in before processing the return.
In such cases (depending of the AllowReturnToBranch pref), the issue
should not be allowed.

Prior to this patch, the checkin was not done and the checkout failed
with "Duplicate entry '1204321' for key 'itemnumber'". Indeed since bug
14978, there is an uniq key on issues.itemnumber. Before bug 14978 the
issue existed but was hidden (and some weird behaviors certainly
happened!).

To avoid Koha to crash, a check is added to CanBookBeIssued (call to
CanBookBeReturned) and the librarian is not able to process the
checkout.

Test plan:

- Set AllowReturnToBranch to anywhere
- Check an item (homebranch Library 1, holding branch Library 1) out from
Library 1
- Check the item out from Library 2
=> Confirm the checkout (should work with and without this patch)

- Set AllowReturnToBranch to holdinbranch ("only the library the item
  was checked out from").
- Check an item (homebranch Library 1, holding branch Library 1) out from
Library 1
- Check the item out from Library 2
=> Without this patch, Koha crashed
=> With this patch, you will be warned that the checkin is not possible.

Try other combinations of the AllowReturnToBranch syspref

Followed test plan, works as expected
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:40:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:40:59 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-tDS3eVj6aQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51699|0                           |1
        is obsolete|                            |

--- Comment #23 from Marc V?ron <veron at veron.ch> ---
Created attachment 51708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51708&action=edit
Bug 16534: Add tests for AddIssue

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:42:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:42:13 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-a1ydrTu7jb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51700|0                           |1
        is obsolete|                            |

--- Comment #24 from Marc V?ron <veron at veron.ch> ---
Created attachment 51709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51709&action=edit
Bug 16534: Block AddIssue from issuing if the return is not possible

To make sure the return can be done, AddIssue must not trust callers (they
should have done their job, but we are not sure) and check that the issue can
be returned before issuing to the patron.

There is no test plan here, this should not be possible from the Koha
interface.
However, looking at the code, it may be possible using SIP.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:52:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:52:29 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-1mvARWfWkh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #25 from Marc V?ron <veron at veron.ch> ---
Created attachment 51710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51710&action=edit
Bug 16534: (followup) Correct tiny typo

This patch corrects "...must be return..." to "must be returned..."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 07:52:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 05:52:59 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-ijhWTAot6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 08:24:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 06:24:28 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-F9iqjarLfR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51416|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51711&action=edit
[SIGNED-OFF] Bug 16465: discharge - Add a title tag at the OPAC

Test plan:
Confirm that the opac-discharge.pl has now a title

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 08:25:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 06:25:23 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-uQzbKxtZek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 08:25:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 06:25:26 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-QQt6HjdRyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51417|0                           |1
        is obsolete|                            |

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51712&action=edit
[SIGNED-OFF] Bug 16465: Fix typo issues vs checkouts

Test plan:
Confirm the wording is correct

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 08:53:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 06:53:34 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-KAv3Hc16Gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Srdjan Jankovic from comment #3)
> There's something odd with that t/db_dependent/Plugins.t. 
...
> and I'm getting
> not ok 18 - Koha::Plugins::GetPlugins functions correctly
> #   Failed test 'Koha::Plugins::GetPlugins functions correctly'
> #   at t/db_dependent/Plugins.t line 46.
> #          got: 'Example Kitchen-Sink Plugin'
> #     expected: 'Test Plugin'

Srdjan,
I made the same change and it seems to work with me.
But actually this test is based on the assumption that GetPlugins always finds
the Test Plugin first. Which could very well not be the case.
Since there can be a lot of plugins present, the test should only verify if the
Test Plugin is in the array.
Also note that the array is not sorted by the routine, so this should have been
taken in account too.
Adding a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 09:09:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 07:09:48 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-IcuxCJyajO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51713&action=edit
Bug 16502: Adjust test for GetPlugins

The current test assumes that GetPlugins will return the test plugin
as the first one in the array. This is not correct.
This patch adjusts the test to a grep.

Test plan:
Run the test.
Bonus: Add additional plugins. Run the test again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 09:09:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 07:09:51 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-iwQ1o2gweb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51714&action=edit
Bug 16502: Replace a few other ok-calls by is-calls

Trivial changes that speak for themselves..

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 09:38:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 07:38:47 +0000
Subject: [Koha-bugs] [Bug 16564] New Patron Category cannot be created.
 Bounces with error: 'The Category might already exist'.
In-Reply-To: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16564-70-Y9lJIgEKpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Could this be a duplicate of bug 16402?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 10:34:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 08:34:20 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-1Xpe3rSkMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #16)
> When I run "prove t/db_dependent/Search.t", it says that all tests are
> successful, although there are lots of warnings generated.
Between April 15 and May 23 some things may have changed :)

> > [2] The source_normalizer or norms just lead me to two FIXMEs:
> > # FIXME normalize, substr
> > # FIXME - default normalizer
> These FIXME messages pre-date my patch. 
True. But that is obviously not my point. Although Matcher.pm has some code
around norms and normalizer, actually it is just uncompleted functionality. The
code just calls a simple _normalized routine. The "references to normalization
subroutines (under C4::Normalize) to be applied to the source string" are not
used and do not exist.

> I'm open to removing _normalize() from the matching completely. Honestly, I
> figured that the community would be against it, so I created a way of opting
> out of the default _normalize(). That way default system behaviour doesn't
> change, while some people will know how to deactivate it.
I am not suggesting to remove it.
As noted above, I would be hesitant to make certain changes in uncompleted
functionality. 

> > [3] I have some doubts about this new condition:
> >     if ($QParser && $matchpoint->{'index'} !~ m/\w,\w/) {
> > Somehow you managed to bump in another unfinished area here too :) 
> > I would rather leave the condition as it was. In the QParser branch you
> > could choose to ignore/remove the second specifier word with a similar regex.
> It's not really a new condition. If you look at C4::Search::SimpleSearch,
> you'll see that it's already there:
Good point. Leave it there.

> Can the QA team indicate how to proceed? 
Could you (slightly) adjust the way to skip the normalize call for the URLs,
that does not suggest that the norms functionality is present while we do not
even have C4::Normalizer?
Maybe Jonathan wants to jump in too and add comments?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 11:28:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 09:28:23 +0000
Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt
 (sentence splitting)
In-Reply-To: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16563-70-ppkIGzw7Yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51715&action=edit
Bug 16563: Translatability: Issues in opac-account.tt (sentence splitting)

This patch removes splitting by <i>-tags from 2 sentences.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 11:28:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 09:28:40 +0000
Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt
 (sentence splitting)
In-Reply-To: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16563-70-QueFhbU0a5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 11:29:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 09:29:34 +0000
Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt
 (sentence splitting)
In-Reply-To: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16563-70-hG4wiCud9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 11:49:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 09:49:17 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-nIZPYo5Xpn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51716&action=edit
Bug 16562: Translatability: Issue in opac-user.tt (separated word 'item')

This patch fixes translatoion difficulties (syntax) with a tag-separated word
'item'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 11:49:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 09:49:53 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-ki4JJupg7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:17:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:17:49 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-fuqtCciE5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bernardo Gonzalez Kriegel from comment #49)
> Errors are not in the procedeure, I tested extensively but on msyql < 5.6,
> so this is specific to ver 5.6+ treatment of SQL, or 5.7 more specifically
> 
> 1) table: auth_subfield_structure
> 
> line:  72   `defaultvalue` TEXT DEFAULT '',
> error: (BLOB, TEXT, GEOMETRY or JSON column 'defaultvalue' can't have a
> default value): CREATE TABLE `auth_subfield_structure`
> 
> Seems that we can't have default values here.
> 
> Ref: http://dev.mysql.com/doc/refman/5.7/en/blob.html
> ->" BLOB and TEXT columns cannot have DEFAULT values."

I get this one using --show-warnings on MariaDB 10.0.24
Fixed with 
diff --git a/installer/data/mysql/kohastructure.sql
b/installer/data/mysql/kohastructure.sql
index 42bff46..ea220bb 100644
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -69,7 +69,7 @@ CREATE TABLE `auth_subfield_structure` (
   `linkid` tinyint(1) NOT NULL default 0,
   `kohafield` varchar(45) NULL default '',
   `frameworkcode` varchar(10) NOT NULL default '',
-  `defaultvalue` TEXT DEFAULT '',
+  `defaultvalue` TEXT,

But I don't get the others

> MySQL 5.7 does not like things like that.
> Perhaps we can change the sql_mode for Koha globally, 
> or fix all the sample data (not difficult) in all languages, 
> and test/sign/QA everything... before release?

Yes, on another bug report.
Now you have Ubuntu 16.04, could you please submit a patch? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:19:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:19:27 +0000
Subject: [Koha-bugs] [Bug 16565] New: additional_fields and
 additional_field_values are not dropped in kohastructure.sql
Message-ID: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

            Bug ID: 16565
           Summary: additional_fields and additional_field_values are not
                    dropped in kohastructure.sql
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:19:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:19:37 +0000
Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions
In-Reply-To: <bug-10855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-kqXLLEh4oO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16565


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565
[Bug 16565] additional_fields and additional_field_values are not dropped in
kohastructure.sql
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:19:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:19:37 +0000
Subject: [Koha-bugs] [Bug 16565] additional_fields and
 additional_field_values are not dropped in kohastructure.sql
In-Reply-To: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16565-70-DzkQ9ZNsQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |10855
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855
[Bug 10855] Custom fields for subscriptions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:21:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:21:53 +0000
Subject: [Koha-bugs] [Bug 16565] additional_fields and
 additional_field_values are not dropped in kohastructure.sql
In-Reply-To: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16565-70-XqaXP8yJn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:21:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:21:56 +0000
Subject: [Koha-bugs] [Bug 16565] additional_fields and
 additional_field_values are not dropped in kohastructure.sql
In-Reply-To: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16565-70-7bsqG5KQVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51717&action=edit
Bug 16565: Drop additional_fields and additional_field_values before creating
them

These 2 tables should be dropped before trying to create them

Test plan:
>From the SQL CLI, source the kohastructure.sql file
source it again
=> Without this patch you get 2 warnings
ERROR 1050 (42S01) at line 3580 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_fields' already exi
sts
ERROR 1050 (42S01) at line 3596 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_field_values' alrea
dy exists

=> With this patch, you won't get them

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:25:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:25:39 +0000
Subject: [Koha-bugs] [Bug 16534] Error when checking out already checked out
 item (depending on AllowReturnToBranch)
In-Reply-To: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16534-70-8N29fGQTGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #26 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Thank you all for your interest and almost instant response to the bug!
It seemed critical (especially if one doesn't have patch for 14978), but it's
normal that it wasn't spotted before as it appears only under certain
circumstances.

I have not yet tried the patch, but seeing the code and your description, I am
certain that it will solve the problem that we faced!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 13:47:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 11:47:53 +0000
Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
In-Reply-To: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15342-70-tdhZYjNdsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From the mailing list:

Bug 16041 is in 3.22.7 and could help for search results.
Bug 15263 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:22:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:22:05 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
	order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-F0CCijt9im@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:23:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:23:17 +0000
Subject: [Koha-bugs] [Bug 15330] Allow to search for late orders by budget
	and fund
In-Reply-To: <bug-15330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15330-70-GmATjQBeJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15330

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:27:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:27:51 +0000
Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in
	opac-memberentry.tt
In-Reply-To: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16560-70-D90NXHvzvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51718&action=edit
Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt

This patch fixes two splitted sentences to avoid translation issues:

The entered <a href="#borrower_cardnumber">card number</a> is the wrong length.
The entered <a href="#borrower_cardnumber">card number</a> is already in use.

To test:
Apply patch and verify that html in the 2 that are changed is correct and that
they are not splitted by a-tags.

Note: I could not figure out under which conditions this code displays in
      the OPAC self registration form.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:28:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:28:48 +0000
Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in
	opac-memberentry.tt
In-Reply-To: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16560-70-LnKsU6SxZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:29:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:29:20 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-77XNl4NYHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:29:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:29:48 +0000
Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt
 (sentence splitting)
In-Reply-To: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16563-70-KQWLc20ULb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 14:47:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 12:47:44 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14797-70-s0wKc1s2MS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 15:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 13:24:54 +0000
Subject: [Koha-bugs] [Bug 16566] New: 'Print slip' button formatting
	inconsistent
Message-ID: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

            Bug ID: 16566
           Summary: 'Print slip' button formatting inconsistent
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

At item checkin the transfer item to' and 'return item to'prompts have
different formatting for printing a slip.  

https://snag.gy/YOlr50.jpg

Holds use a button+icon for print and confirm:

https://snag.gy/HRqNrL.jpg

It would be nice to be consistent among these links

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 15:40:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 13:40:55 +0000
Subject: [Koha-bugs] [Bug 16567] New: RSS feeds show issues in W3C validator
 and can't be read by some aggregators (Chimpfeedr, feedbucket)
Message-ID: <bug-16567-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567

            Bug ID: 16567
           Summary: RSS feeds show issues in W3C validator and can't be
                    read by some aggregators (Chimpfeedr, feedbucket)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We are seeing issues with some RSS aggregators refusing to load koha rss links,
there are errors when checked in the W3C validator:

https://validator.w3.org/feed/check.cgi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 15:47:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 13:47:21 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-tMsXzoQEeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 15:53:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 13:53:49 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-LasKpUAquT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Nick Clemens from comment #0)
>
> https://snag.gy/YOlr50.jpg

We obviously have another problem here too: Two transfer messages? Shouldn't
the rotating collection transfer message supersede the "normal" one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:05:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:05:42 +0000
Subject: [Koha-bugs] [Bug 16568] New: Talking Tech generates phone
 notifications for all overdue actions
Message-ID: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

            Bug ID: 16568
           Summary: Talking Tech generates phone notifications for all
                    overdue actions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Regardless of whether the phone transport has been selected for a given overdue
action or not, the Talking Tech outbound script generates and sends a line for
that action.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:05:48 +0000
Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications
 for all overdue actions
In-Reply-To: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16568-70-uUjN6SXG9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:09:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:09:47 +0000
Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications
 for all overdue actions
In-Reply-To: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16568-70-HSrM64LyHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:09:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:09:49 +0000
Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications
 for all overdue actions
In-Reply-To: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16568-70-A2W4OgW3RA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51719&action=edit
Bug 16568 - Talking Tech generates phone notifications for all overdue actions

Regardless of whether the phone transport has been selected for a given
overdue action or not, the Talking Tech outbound script generates and
sends a line for that action.

Test Plan:
1) Enable Talking Tech
2) Create one or more overdue actions without a phone transport selected
   and one or more with the phone transport selected
3) Generate the overdues csv file to send to Itive
4) Note the csv file has lines for actions that do not have the phone
   transport selected
5) Apply this patch
6) Repeat step 3
7) Note the csv file now only has lines for actions that have the phone
   transport selected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:09:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:09:57 +0000
Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications
 for all overdue actions
In-Reply-To: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16568-70-BE0tqllwMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:27:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:27:34 +0000
Subject: [Koha-bugs] [Bug 16569] New: Message box for "too many checked out"
 is empty if AllowTooManyOverride is not enabled
Message-ID: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

            Bug ID: 16569
           Summary: Message box for "too many checked out" is empty if
                    AllowTooManyOverride is not enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If the limit for number of items checked out is reached, the message box shows
up but is empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:27:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:27:42 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-J5If9VTzkH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
           Severity|enhancement                 |normal
         Depends on|                            |14045


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
[Bug 14045] Add specific quotas to on-site checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:27:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:27:42 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: <bug-14045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14045-70-ppHOdBjWN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569
[Bug 16569] Message box for "too many checked out" is empty if
AllowTooManyOverride is not enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:30:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:30:09 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-wbCkqjgPoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51720&action=edit
Bug 16569 - Message box for "too many checked out" is empty if
AllowTooManyOverride is not enabled

If the limit for number of items checked out is reached, the message box
shows up but is empty.

Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
   of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:30:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:30:06 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-hZ6Ma1lyXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:46:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:46:28 +0000
Subject: [Koha-bugs] [Bug 16493] acq matching on title and author
In-Reply-To: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16493-70-eWbXJaTbcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16493

--- Comment #12 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
I have just finished my tests. The patch works as described.
I'm a little worried because I'm afraid that some of my colleagues forget to
choose a matching rule when they add orders from a batch file. It will be a
regression for them as they have nothing to choose by now to have a
deduplicationw to have a deduplication.

So, I'm wondering if it would be possible to have a default matching rule
selected when we add a orders from a batch file. Or, perhaps it would be better
to keep a deduplication by FindDuplicate when no matching rules is chosen and
to switch to a matching rule if the user choose one.

What do you think about it ?

PS : It's not related to this patch but I have some difficulties to set the
matching rules. In the documentation, there's :
Threshold of 1000
Match Point on 020$a 1000
Match Point on 022$a 1000
In the example above, a match on either the 020$a or the 022$a will result in a
successful match.
When I test this patch, I have to put a number in the match point greater than
the threshold, if I put a number equal to the thershold, there's no
deduplication alert...
And I try to put 2 matchpoints with a result greater to the threshold and if
none of the two is greater than the threshold, there's no deduplication alert.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 16:55:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 14:55:09 +0000
Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to
 occur when record is "Saved" (avoid collisions)
In-Reply-To: <bug-6782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6782-70-7Suyy0Iq2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Seems still to be an issue.

To reproduce:
- Set syspref autoMemberNum to 'on'
- Open two browser windows/tabs and go in both to 
  Home > Patrons > Add patron
- Verify that in both entry forms the field 'Card number' is 
  populated with the same value
- Save form in browser window 1
=>OK
- Save form in browser window 2
=> Result in window 2: Message "Cardnumber already in use.",
   and the field 'Card number' is pupulated with the next higher number.
   Saving again is then OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:11:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:11:34 +0000
Subject: [Koha-bugs] [Bug 8534] Remove unused variable from memberentry
	template
In-Reply-To: <bug-8534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8534-70-DBJeWByFqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Can this Bug be marked as RESOLVED INVALID?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:14:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:14:06 +0000
Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML &
	CSS
In-Reply-To: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7669-70-wwcmAsDiGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Is this bug still valid or can it be marked as RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:16:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:16:18 +0000
Subject: [Koha-bugs] [Bug 16570] New: All checked-in items are said to be
 part of a rotating collection
Message-ID: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

            Bug ID: 16570
           Summary: All checked-in items are said to be part of a rotating
                    collection
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: alex.arnaud at biblibre.com,
                    benjamin.rokseth at kul.oslo.kommune.no,
                    claire.hernandez at biblibre.com, gmcharlt at gmail.com,
                    jonathan.druart at bugs.koha-community.org,
                    julian.maurice at biblibre.com, kyle.m.hall at gmail.com,
                    kyle at bywatersolutions.com,
                    testopia at bugs.koha-community.org, veron at veron.ch
        Depends on: 15564

I have no rotating collections defined, but every time I check something in I
get a message that the item is part of a rotating collection and needs to be
transferred.

git bisect blames commit 30dc04c74a2ef00c22667f722746c2c6be1da6b1 (Bug 15564).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564
[Bug 15564] Display "print slip" option when returning an item which is in a
rotating collection
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:16:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:16:18 +0000
Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning
 an item which is in a rotating collection
In-Reply-To: <bug-15564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15564-70-hAeXE7HsQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570
[Bug 16570] All checked-in items are said to be part of a rotating collection
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:19:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:19:38 +0000
Subject: [Koha-bugs] [Bug 6851] A utility that will search out analytics
 records and set the MARC header appropriately.
In-Reply-To: <bug-6851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6851-70-ixaMvyeI9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6851

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Would that script still be useful?
(Latest activity on this Bug 2012-03-08 )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:20:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:20:58 +0000
Subject: [Koha-bugs] [Bug 9384] With OPACPatronDetails set to 'don't allow'
	a form shows
In-Reply-To: <bug-9384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9384-70-hdpyHow5og@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|cgi-bin/koha/opac-memberent |cgi-bin/koha/opac-memberent
                   |ry.pl                       |ry.pl
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:22:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:22:56 +0000
Subject: [Koha-bugs] [Bug 9399] Accessibility - Search box options aren't
	buttons
In-Reply-To: <bug-9399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9399-70-VGfxi6Bpxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9399

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:26:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:26:10 +0000
Subject: [Koha-bugs] [Bug 9584] Remove problematic IE CSS Hacks in staff
	client
In-Reply-To: <bug-9584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9584-70-tjOX7vGJa2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:27:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:27:22 +0000
Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML &
	CSS
In-Reply-To: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7669-70-33vU4TQdgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
I think the goals of the original patch could still be seen as useful. The
display of cover images could be made more consistent. Since the original patch
author never chose to follow up I think the best thing to do is return this to
"New."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:27:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:27:30 +0000
Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML &
	CSS
In-Reply-To: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7669-70-Mz2Sr1txYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:28:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:28:02 +0000
Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML &
	CSS
In-Reply-To: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7669-70-4JXGr2BTmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14353|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:28:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:28:07 +0000
Subject: [Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron
 belonging to another branch
In-Reply-To: <bug-8839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8839-70-3xq8RhKzWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:28:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:28:52 +0000
Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML &
	CSS
In-Reply-To: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7669-70-gMwInhFO7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ssammons at npelem.com         |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:29:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:29:04 +0000
Subject: [Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML &
	CSS
In-Reply-To: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7669-70-C8BAkdZcHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha.sekjal at gmail.com       |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:29:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:29:08 +0000
Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields
	in basket.tt
In-Reply-To: <bug-9692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9692-70-nL9zavDExr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:34:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:34:18 +0000
Subject: [Koha-bugs] [Bug 9248] Add a German Zebra language definition file
In-Reply-To: <bug-9248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9248-70-C6MvJGjJ9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9248

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:37:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:37:10 +0000
Subject: [Koha-bugs] [Bug 9384] With OPACPatronDetails set to 'don't allow'
	a form shows
In-Reply-To: <bug-9384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9384-70-CEXselbxMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
As far as I can tell this is no longer valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:47:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:47:55 +0000
Subject: [Koha-bugs] [Bug 7654] Add location an callnumber at opac
	subscription view
In-Reply-To: <bug-7654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7654-70-GxhXUgaOn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #18 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:55:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:55:00 +0000
Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron
 category in patron data
In-Reply-To: <bug-9836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9836-70-1pD9KrNhPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #16 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 17:58:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 15:58:00 +0000
Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for
	loan" items
In-Reply-To: <bug-10304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10304-70-PuRD9nWLOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 18:02:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 16:02:28 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-SaGXa3trRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 18:29:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 16:29:14 +0000
Subject: [Koha-bugs] [Bug 9584] Remove problematic IE CSS Hacks in staff
	client
In-Reply-To: <bug-9584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9584-70-k5C96yoN2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marc V?ron from comment #3)
> Still valid?

No. The CSS in question has long been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 18:48:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 16:48:31 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-P7OEMgEBYY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05! Thanks Tomas, Bernardo and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 18:52:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 16:52:59 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-rGN4T1eyHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05. Thanks Nick, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 18:55:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 16:55:01 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-qEPnBpibnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 18:57:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 16:57:48 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-6RLAQshgwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #52 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #50)
> Yes, on another bug report.
> Now you have Ubuntu 16.04, could you please submit a patch? :)

Will do :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:14:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:14:40 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-YiJBluRoXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Tomas!

NOTE: Only the first patch was pushed. The second warning patch no longer
applies. An updated patch should probably be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:16:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:16:38 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-uaoJBYXPxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:17:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:17:40 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-uka68jYewa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:23:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:23:00 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-Jr6p7T7sTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Marc, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:24:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:24:49 +0000
Subject: [Koha-bugs] [Bug 16343] 7XX XSLT subfields displaying out of order
In-Reply-To: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16343-70-thFsZUwFDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Hector!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:25:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:25:52 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-GOsZUTwzZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:30:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:30:12 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-q3pwW2MoJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Second patch has now been pushed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:30:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:30:43 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-nk1tUWeEt7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05. Thanks Tomas, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:35:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:35:12 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-HcfHAjmWRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51635|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51721&action=edit
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl

If you search for a patron in the circulation module, you get:

Use of uninitialized value $barcode in string eq at
/home/koha/src/circ/circulation.pl line 84.
Use of uninitialized value $restoreduedatespec in string eq at
/home/koha/src/circ/circulation.pl line 170.

Test plan:
- Search for a patron and confirm the warnings are not displayed anymore
- Make sure this patch does not introduce regression on bug 14015

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:35:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:35:19 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-AOtwTUqWqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51722&action=edit
Bug 16499 [QA Followup] - Improve readability

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:35:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:35:48 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-Yg1NJ2dsWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:39:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:39:11 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-uh9LE1RqTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Marc, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:41:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:41:22 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-KNhvqPYUv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for Koha 16.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 19:49:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 17:49:55 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-phh23KYJCM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to master for 16.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:35:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:35:53 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-ALNWfAbXxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:46:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:46:55 +0000
Subject: [Koha-bugs] [Bug 16571] New: Reporte no jala al autor coorporativo
Message-ID: <bug-16571-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16571

            Bug ID: 16571
           Summary: Reporte no jala al autor coorporativo
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: german.uch.edu at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Buenas tardes estimados alguien me puede ayudar como generar un reporte de
cantidad de materiales bibliogr?ficos donde incluya t?tulo, autor personal y
corporativo, editorial, a?o, signatura topogr?fica, c?digo de barra colecci?n

le agradecer?a mucho sus aportes muchas gracias

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:48:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:48:10 +0000
Subject: [Koha-bugs] [Bug 15559] Software error: Wide character in
 subroutine entry at /usr/share/perl5/MARC/Charset/Table.pm line 96.
In-Reply-To: <bug-15559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15559-70-E081Qpusdg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15559

German <german.uch.edu at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |german.uch.edu at gmail.com

--- Comment #2 from German <german.uch.edu at gmail.com> ---
3.20

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:53:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:53:46 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-2iUvgT0UNB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren <eivin at sysmystic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44056|0                           |1
        is obsolete|                            |
  Attachment #44057|0                           |1
        is obsolete|                            |
  Attachment #44058|0                           |1
        is obsolete|                            |

--- Comment #6 from Eivin Giske Skaaren <eivin at sysmystic.com> ---
Created attachment 51723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51723&action=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
    1. Apply this patch
    2. Apply related database patch
    2. Apply related scripts update patch
    3. Run updatedatabase.pl
    5. Log in to staff client
    4. Enable new syspref MARCPermissions
    5. You should see a new link "MARC field permissions" in the "Catalog"
       section under "Koha administrtion".
    6. Go to the "MARC field permissions" page
    7. Next to the page heading ("Manage MARC field permissions") there is a
       button with a question mark, click this for more information about the
       rule system.
    8. Add desired rules to the rule table, press the +-button to add.
    9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
    10. Clicking the x-icon should remove corresponding rule after
confirmation.
    11. Selecting one or more rules followed by clicking the trash-icon
        should remove all selected rules after confirmation.
    12. To test your rules, import or in other way modify a record.
    13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:54:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:54:59 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-TYWbQ74lus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren <eivin at sysmystic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
           Assignee|martin at bugs.koha-community. |eivin at sysmystic.com
                   |org.xinxidi.net             |
                 CC|                            |eivin at sysmystic.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:56:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:56:09 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-wKRwFicEa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren <eivin at sysmystic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44058|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:56:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:56:33 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-ooBaXnEEjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren <eivin at sysmystic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44057|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 22:59:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 20:59:31 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-hqtPN1pXZU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #7 from Eivin Giske Skaaren <eivin at sysmystic.com> ---
Created attachment 51724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51724&action=edit
Bug 14957: Correct parameters for TransformMarcToKoha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 23 23:01:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 21:01:05 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-kjaujP3nfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #8 from Eivin Giske Skaaren <eivin at sysmystic.com> ---
I have rebased and merged this and it seems to work. I dont have any MARC
experience so please test that this works in some real use case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 00:55:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 May 2016 22:55:19 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-9PqHPWa3X1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #53 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Mmm, we have a problem :(

RunSQL prints loads of 'warnings', they are catched and treated as
errors because they go to stderr.

RunSQL have this line

261             } elsif( 0 < $sth->{NUM_OF_FIELDS} ) {

but $sth from execute can have that parameter undef for create/delete,
and that seems to be the case, not an error but a warning.

Now we can't install, even on MySQL < 5.7 !!

Can we revert (in another Bug) to something similar to my error treatment?
Displayed errors where not as fancy, but worked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 02:12:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 00:12:09 +0000
Subject: [Koha-bugs] [Bug 16572] New: Warnings on load_sql makes web
	installer fail
Message-ID: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572

            Bug ID: 16572
           Summary: Warnings on load_sql makes web installer fail
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Bug 13669 redirect warnings from load_sql use of DBIX::RunSQL to sdterr, and
makes web installer fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:24:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:24:37 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-IQmQDE4wYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:24:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:24:40 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-YS5EWFpVLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51507|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51725&action=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an existing
budget. This patch adds a cancel button to the form which adds a budget. Also
changes the wording of the save button from 'Save changes' to just 'Save' so it
makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:28:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:28:44 +0000
Subject: [Koha-bugs] [Bug 16572] Warnings on load_sql makes web installer
	fail
In-Reply-To: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16572-70-6V8OMQZCd0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51726&action=edit
Bug 16572: Warnings on load_sql makes web installer fail

Last patch on Bug 13669 redirects all strings to stderr,
warning included. That makes web installer fail.

To test:
Current master (Bug 13669 pushed)
1) Try web installer, it fails
2) Apply this patch, try again,
now succeeds*

* Unless Mysql 5.7, that needs another bug.

I'm not considering this a 'good' solution, just a quick fix.
A better approach is welcomed, just obsolete this patch
and upload a new one, I'll sign :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:34:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:34:45 +0000
Subject: [Koha-bugs] [Bug 16573] New: Web installer fails to load structure
 and sample data on MySQL 5.7
Message-ID: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

            Bug ID: 16573
           Summary: Web installer fails to load structure and sample data
                    on MySQL 5.7
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

MySQL 5.7 is more strict, structure and sample data fails to load.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:50:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:50:59 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-ikI9qraKvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51727&action=edit
Bug 16573: fix structure and sample data for MySQL 5.7

Web install on Ubuntu 16.04/Mysql 5.7 fails.

This patch makes small changes to make installation
possible to kohastructure.sql and some sample files.

Sample values for quotes table can't have '0000-00-00 ...' values
nor NULL values, now() is perhaps an option.

Depends on Bug 16572

To test:
1) System with MySQL 5.7, for example Ubuntu 16.05
2) Apply 16572
3) Try web install, it fails
4) Apply this and next patch
5) Try again, now it succeed

This is only for English install, i18n files needs revision
I can do that if this is accepted.

Perphaps a change is needed to updatedatabase.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:51:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:51:11 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-cENZUGgDUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51728&action=edit
Bug 16573: fix linkid value on marc_subfield_structure

followup to previous patch.

This patch fixes linkid value. It was set to '', but
declared as tinyint.
Mysql < 5.7 replaced this with nearest right value, i.e 0
Mysql 5.7 gives error here.

Also some normalization, all lines with data begins with two tabs

To test:
On top of Bug 16572 and previous patch

1) Run webinstaller
2) Add mandatory values
3) There must be no problems on MySQL 5.7

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:52:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:52:25 +0000
Subject: [Koha-bugs] [Bug 16572] Warnings on load_sql makes web installer
	fail
In-Reply-To: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16572-70-5ebLfcdbMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
         Depends on|                            |13669
             Blocks|                            |16573
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573
[Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:52:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:52:25 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ovodtG1TsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16572


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572
[Bug 16572] Warnings on load_sql makes web installer fail
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:52:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:52:25 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-Y6Z6ysK8ja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16572


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572
[Bug 16572] Warnings on load_sql makes web installer fail
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:53:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:53:20 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-yZwTWAHlhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:53:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:53:23 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-MrbMHpRYY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51557|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51729&action=edit
Bug 16531: Circ overdue report is showing an empty table if no overdues

EDIT: Comment 2

To test:
1) Ensure you have no items overdue
2) Go to Circ -> Circulation reports -> Overdues
3) Notice empty table, '0 items overdue' heading
4) Apply patch and refresh page
5) Notice empty table is no longer showing and page says "There are no
overdues"
6) Apply a filter to search
7) Page now says "There are no overdues matching your search" with a link to
reset filter.
8) Click Reset filter -> confirm any filters you applied are cleared.
9) Check out an item to a member, ensure due date is a date that has passed
(i.e. yesterday)
10) Refresh overdue report page
11) Confirm table now shows correctly with '1 items overdue' heading etc.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:54:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:54:07 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-QBzUHlmg9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:55:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:55:07 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-wWOIy0AI7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:56:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:56:34 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-E4IqcT2ZHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51561|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51730&action=edit
Bug 16532: Groups showing empty tables if no groups defined

EDIT: Same change for libraries

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 03:57:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 01:57:32 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-o6vBh79dqY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #54 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #52)
> (In reply to Jonathan Druart from comment #50)
> > Yes, on another bug report.
> > Now you have Ubuntu 16.04, could you please submit a patch? :)
> 
> Will do :)

Bug 16572 as POC solution to my last comment
Bug 16573 for Ubuntu 16.04 fix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:00:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:00:24 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-RMrE0uwdre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:00:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:00:27 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-oRckxczny2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51586|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51731&action=edit
[SIGNED-OFF] Bug 16336 [Revised] UX of holds patron search with long lists of
results

Bug 15793 made a change to an interface which is also found in the place
hold template. This patch creates a new include file to be used by both
circulation.tt and request.tt so that these pages do not diverge.

In the process, this patch removes some markup and JavaScript which was
made obsolete by Bug 15793 and should have been removed.

This patch also revises the sorting of the results table so that the
patron name is sortable (Bug 16334) and the default sort is on card
number (matching 3.20.x and 3.22.x).

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- The table of results which displays should look correct and work
  correctly, including DataTables sorting.
- Clicking any table row should forward you to the checkout page for
  that patron.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the table of patron results looks correct and works
  correctly.
- Clicking any table row should forward you to the place hold page for
  that patron and the title you selected.

Revision: Although the table row was clickable, you couldn't
middle-click it to open the link in a new tab. The patron name is now a
real link you can middle-click or right-click. The row is still
clickable as well.

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:13:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:13:15 +0000
Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with
 the CSV profile doesn't set the issue claimed
In-Reply-To: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12178-70-a81ZNBF2qZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

--- Comment #8 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51732&action=edit
Bug 12178: Tests for changes to claimed serial status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:13:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:13:32 +0000
Subject: [Koha-bugs] [Bug 16571] Reporte no jala al autor coorporativo
In-Reply-To: <bug-16571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16571-70-3434eh3vtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16571

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |bgkriegel at gmail.com
             Status|NEW                         |RESOLVED

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to German from comment #0)
> Buenas tardes estimados alguien me puede ayudar como generar un reporte de
> cantidad de materiales bibliogr?ficos donde incluya t?tulo, autor personal y
> corporativo, editorial, a?o, signatura topogr?fica, c?digo de barra colecci?n
> 
> le agradecer?a mucho sus aportes muchas gracias

Hola Germ?n,
este tipo de preguntas es mejor hacerlas en la lista de correo.
Tienes una en ingl?s y otra para hispano-hablantes.

Por otro lado en este sitio se reportan normalmente problemas,
y en ingl?s :)

De todas formas mira en la biblioteca de informes,
https://wiki.koha-community.org/wiki/SQL_Reports_Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:21:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:21:22 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-5IOQUxA7XI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51460|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 51733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51733&action=edit
Bug 16507: Show play media tab first if record has no holdings

EDIT: Same fix for OPAC side

To test:
1) Go to Admin -> Global sysprefs
2) Turn on HTML5MediaEnabled and HTML5MediaYouTube
3) Go to Cataloging and create a new record
4) Catalogue a YouTube link in 856$u and save record. Do not add any items
(click Normal tab)
5) Confirm that Play media tab shows first

6) Go to OPAC side and look at same record
7) Confirm that Play media tab shows first

8) Go back to staff side, add an item then go back to Normal tab
9) Confirm that Holdings tab now shows first and Play media tab is last

10) Go to OPAC side, confirm that Holdings tab now shows first and Play media
tab is last

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:21:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:21:19 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-oRNFvgf8oB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 04:29:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 02:29:27 +0000
Subject: [Koha-bugs] [Bug 16564] New Patron Category cannot be created.
 Bounces with error: 'The Category might already exist'.
In-Reply-To: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16564-70-FcrAN2aBYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
See Bug 16572 and Bug 16573

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 05:10:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 03:10:25 +0000
Subject: [Koha-bugs] [Bug 16574] New: Software error when search the catalog
Message-ID: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

            Bug ID: 16574
           Summary: Software error when search the catalog
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: janice.chow at sw-hk.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51734&action=edit
Screen Capture about software error

When I search some keywords and it shows me software error. How can I fix it?
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 05:20:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 03:20:47 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-YmI44jpvch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
hi Janice, can you give more info?

- what version of Koha?, 
- what installation type of Koha?, (eg: .deb packages?)
- what operating system version?

- what keywords are you searching on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 05:37:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 03:37:26 +0000
Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with
 the CSV profile doesn't set the issue claimed
In-Reply-To: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12178-70-wxxAgpRK5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from Florent Mara <florent.mara at gmail.com> ---
Added and attached tests for the method C4::Serial->updateClaim(). 

Serials/claims.pl now updates the serial status and claim count similarly when
exporting to csv or sending a notification - as described in the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 06:13:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 04:13:23 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-QGDBJd5Xrs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

--- Comment #2 from Janice Chow <janice.chow at sw-hk.com> ---
Koha version:   3.08.11.000
Where can I find the installation type and operating system version?
I am searching on "csj" one of the journal I catalogued to koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 07:10:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 05:10:53 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-Ye7tTRLxHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx all for working on this! I have Ubuntu 16.04 and MySQL 5.7 - so I can test
this tomorrow again at the hackfest if stil needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 07:56:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 05:56:09 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-0AE7Gu43t5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 08:05:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 06:05:00 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-dVvEyCWsmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #56 from Marc V?ron <veron at veron.ch> ---
Is the following related to this bug?

Can't locate DBIx/RunSQL.pm in @INC (@INC contains: /usr/share/kohaclone
/etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2
/usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14
/usr/local/lib/site_perl .) at /usr/share/kohaclone/C4/Installer.pm line 23.
BEGIN failed--compilation aborted at /usr/share/kohaclone/C4/Installer.pm line
23.
Compilation failed in require at /usr/share/kohaclone/about.pl line 34.
BEGIN failed--compilation aborted at /usr/share/kohaclone/about.pl line 34.

It seems that a dependency is missing in PerlDependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 08:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 06:07:10 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-ptqLAwZpVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes it is related - and I think it needs to be packaged, I couldn't find it in
latest Ubuntu and installed from CPAN for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 09:00:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 07:00:27 +0000
Subject: [Koha-bugs] [Bug 16575] New: Irregular behaviour using
 window.print() followed by window.location.href=
Message-ID: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

            Bug ID: 16575
           Summary: Irregular behaviour using window.print() followed by
                    window.location.href=
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

As we noticed in bug 11014, different browsers handle "window.print()"
differently.

In the case of window.print() followed by window.location.href=, I've found in
IE 11 on Windows 8.1 that the browser changes the window location before the
system print dialogue even opens. If I try to mitigate that using the timer
from bug 11014, it works in IE and Chrome, but it breaks in Firefox. If I try
to use the onafterprint in IE and Firefox, it works in IE but it breaks in
Firefox.

I started wondering if we even need to be using this window.print() followed by
window.location.href= and it occurred to me that we really don't. We should
just be using print.css.  

Patch to follow soon...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 09:00:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 07:00:46 +0000
Subject: [Koha-bugs] [Bug 11014] Slip Print Problem in Chrome
In-Reply-To: <bug-11014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11014-70-4VUtn10fUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11014

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
Found a similar problem with the opac cart print bug 16575

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 10:54:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 08:54:53 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-0qDYOC6fRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Translatability in          |Translatability in
                   |opac-auth.tt (tag-isolated  |opac-auth.tt (tag-splitted
                   |word 'Logout')              |sentences)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 10:58:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 08:58:43 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-lSlqsWFE4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51735&action=edit
Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences)

This patch removes tag-splitting from 2 sentences in pac-auth.tt

To test:
- Review code changes and verify that sentences ar no longer splitted

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 10:59:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 08:59:37 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-aohYy2jN3G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |
           Severity|enhancement                 |trivial
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 12:42:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 10:42:57 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-kp2RF8MRcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #57)
> Yes it is related - and I think it needs to be packaged, I couldn't find it
> in latest Ubuntu and installed from CPAN for testing.

Just to note, DBIx::RunSQL should be trivial to package. As far as I can tell,
it requires no external dependencies. At least nothing we don't already have
except for Text::Table which appears to be optional.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 12:45:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 10:45:02 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-54btY8nuW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
So, with the release so close, how should we deal with this? Revert? Push
forward with Bug 16572 and Bug 16573? Or do we have other options?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 13:15:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 11:15:49 +0000
Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open
 collection.abs error after 3.18 package update
In-Reply-To: <bug-13396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13396-70-UTs3uVzOMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396

Jatinder Kumar Samyal <jksamyal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jksamyal at gmail.com
           Hardware|All                         |PC
                 OS|All                         |Linux
            Version|3.18                        |3.22
          Component|Architecture, internals,    |Searching
                   |and plumbing                |

--- Comment #7 from Jatinder Kumar Samyal <jksamyal at gmail.com> ---
I have just upgraded koha 3.12 to 3.22 and facing problem in searching stuff in
OPAC as well as staff interface.

I just gone through various replies of the forum for same kind of problem and
found some changes to be done in koha-conf.xml file. But i am not getting out
of problem.

Kindly share complete koha-conf.xml file, if available.

rgds.

JK Samyal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 13:19:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 11:19:59 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-AXODJ7i6Wn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #60 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Kyle M Hall from comment #59)
> So, with the release so close, how should we deal with this? Revert? Push
> forward with Bug 16572 and Bug 16573? Or do we have other options?

With Bug 16572 + new perl dependency DBIx::RunSQL we can install where we used
to, not systems with MySQL 5.7. 

To add support for mysql 5.7 we need Bug 16573 + another one to fix i18n
installer files. I can write it, but we need someone to test, and that in case
this kind of fix is considered valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 15:03:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 13:03:11 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-e3Pk1TqcQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #61 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #60)
> (In reply to Kyle M Hall from comment #59)
> > So, with the release so close, how should we deal with this? Revert? Push
> > forward with Bug 16572 and Bug 16573? Or do we have other options?
> 
> With Bug 16572 + new perl dependency DBIx::RunSQL we can install where we
> used to, not systems with MySQL 5.7. 
> 
> To add support for mysql 5.7 we need Bug 16573 + another one to fix i18n
> installer files. I can write it, but we need someone to test, and that in
> case this kind of fix is considered valid.

Thanks! If you write it I'm sure we can find some testers!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 15:20:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 13:20:58 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-6UGi1JCkW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #62 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Kyle M Hall from comment #61)
> 
> Thanks! If you write it I'm sure we can find some testers!

Will do!

Do you need another bug to add DBIx::RunSQL dependency ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 15:25:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 13:25:10 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-kcmZukMcCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #63 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Just a followup!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 15:39:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 13:39:14 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-OL9e51FifN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #64 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51736&action=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 16:12:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 14:12:59 +0000
Subject: [Koha-bugs] [Bug 13699] DBD::mysql mysql_auto_reconnect attribute
 ceases to function after DBIx call[s]
In-Reply-To: <bug-13699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13699-70-9Dmoi6yMbs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13699

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51737&action=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

The module DBIx::RunSQL appears now on the 'About' page
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 16:17:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 14:17:41 +0000
Subject: [Koha-bugs] [Bug 13699] DBD::mysql mysql_auto_reconnect attribute
 ceases to function after DBIx call[s]
In-Reply-To: <bug-13699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13699-70-slYRqIuucm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13699

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #51737|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Comment on attachment 51737
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51737
Bug 13669: followup to add DBIx::RunSQL dependency

I mistaked with the bug number, sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 16:19:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 14:19:54 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-OXLsJsA0xT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51736|0                           |1
        is obsolete|                            |

--- Comment #65 from Marc V?ron <veron at veron.ch> ---
Created attachment 51738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51738&action=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

The module appears now on the About page.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 16:43:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 14:43:59 +0000
Subject: [Koha-bugs] [Bug 16576] New: Remove the use of "onclick" from label
	templates
Message-ID: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

            Bug ID: 16576
           Summary: Remove the use of "onclick" from label templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle at bywatersolutions.com,
                    testopia at bugs.koha-community.org, veron at veron.ch

There are several places in the label creator templates where where an
"onclick" attribute is used. These should be rewritten so that JS functionality
can be separate from the markup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 17:19:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 15:19:02 +0000
Subject: [Koha-bugs] [Bug 16576] Remove the use of "onclick" from label
	templates
In-Reply-To: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16576-70-R5DUf2Jis0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 17:19:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 15:19:06 +0000
Subject: [Koha-bugs] [Bug 16576] Remove the use of "onclick" from label
	templates
In-Reply-To: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16576-70-aWxairOfeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51739&action=edit
Bug 16576 - Remove the use of "onclick" from label templates

This patch updates several label creator templates to remove the use of
"onclick" in favor of defining click events in JavaScript.

Also changed:
 - Replaced the non-existant element <icon> with <i>
 - Removed the use of <center> and 'align="center"';
 - In the item search results template:
   - The pagination bars have been updated to match those in use
     elsewhere.
   - The use of the checkboxes jQuery plugin has been replaced with
     straight jQuery for simplicity's sake.
   - Output of table headers has been modified so that translatable
     strings are in the template instead of having English strings
     passed from the script.
   - Moved the 'Add checked' and 'Done' buttons into a floating toolbar.

To test, apply the patch and go to Tools -> Label creator.

- Choose New -> Label batch
  - Click 'Add items'
    - Perform a search for items.
    - Confirm that 'select all' and 'clear all' links work.
    - Confirm that clicking an individual 'Add' button works.
    - Select multiple items and click the 'Add checked' button. Confirm
      that the selected items were added to your batch.
  - Click 'Add items' again to save the selected items to your batch.
  - Test that the 'Delete' and 'Export' buttons next to any item work
    correctly.
- Choose Manage -> Label batches
  - Test that the 'Delete' button works correctly.
  - Select one or more batches and test that the 'Export selected'
    button works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 18:00:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 16:00:22 +0000
Subject: [Koha-bugs] [Bug 16577] New: Improve call number browser plugin
Message-ID: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577

            Bug ID: 16577
           Summary: Improve call number browser plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_na
                    me=cn_browser.pl&popup&q=X
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 13364 added a call number browser cataloging plugin which can be used to
check for duplicate call numbers when adding an item. I have several markup
fixes and style improvements for the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 18:35:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 16:35:18 +0000
Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin
In-Reply-To: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16577-70-jbJjU9amSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 18:35:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 16:35:20 +0000
Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin
In-Reply-To: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16577-70-leZNRoDff4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51740&action=edit
Bug 16577 - Improve call number browser plugin

This patch makes several markup and style improvements to the call
number browser plugin added by Bug 13364. Some of the changes:

- The size of the pop-up window has been increased slightly for a less
  cramped display.
- Page structure has been updated to match similar pop-up windows.
- Page structure has been improved to further accommodate the option of
  viewing the call number browser as a full page rather than a pop-up
  window (although as far as I can tell it is not linked to in this mode
  anywhere).
- Row highlighting has been updated so that page styles are not being
  passed explicitly by the script. Highlight colors have been changed to
  make things more readable.
- DataTables-related markup has been removed because it was not being
  used. It doesn't make sense to re-order table rows when the purpose of
  the table is to display call number order.

To test, apply the patch and edit a framework so that the item call
number field uses the 'cn_browser.pl' plugin.

- Create or edit an item in cataloging.
- Enter an existing call number into the call number field.
  - Click the '...' link next to the call number.
    - In the call number browser pop-up, verify that items matching your
      call number are highlighted in red.
    - Verify that the new 'Close' button at the bottom of the page works
      correctly.
- Enter a call number which doesn't exist in the call number field
  - Click the '...' link to trigger the browser.
    - Verify that there is a row highlighted in green marking the sort
      order of the call number you chose.
- Navigate directly to
  /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl
  - The page should appear like a normal full page, with header search,
    breadcrumbs, etc. Performing a search for call numbers should work
    like it did in the pop-up context.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:08:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:08:55 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-TKK64qiRJ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51727|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51741&action=edit
Bug 16573: fix structure and sample data for MySQL 5.7

Web install on Ubuntu 16.04/Mysql 5.7 fails.

This patch makes small changes to make installation
possible to kohastructure.sql and some sample files.

Sample values for quotes table can't have '0000-00-00 ...' values
nor NULL values, now() is perhaps an option.

Depends on Bug 16572

To test:
1) System with MySQL 5.7, for example Ubuntu 16.05
2) Apply 16572
3) Try web install, it fails
4) Apply this and next patch
5) Try again, now it succeed

This is only for English install, i18n files needs revision
I can do that if this is accepted.

Perphaps a change is needed to updatedatabase.pl

Ammended patch, 'created_on' field on virtualshelves
can't be timestamp default null, mysql 5.5 complains
that only one timestamp column can be defined as
default not null. Changed to 'datetime' type.

Can provide followup with updatedabase change,
but need an opinion if this type change makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:22:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:22:29 +0000
Subject: [Koha-bugs] [Bug 16578] New: Wide character warning in
 opac-export.pl when utf8 chosen
Message-ID: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

            Bug ID: 16578
           Summary: Wide character warning in opac-export.pl when utf8
                    chosen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- Have records indexed
- Open your OPAC logs:
  $ tail -f /var/log/koha/kohadev/opac-error.log
- Open the detail page in the opac for a record
- Choose Save record > MARC (Unicode/UTF-8)
=> FAIL: opac-export.pl: Wide character in print at
/home/vagrant/kohaclone/opac/opac-export.pl line 116., referer:
http://localh...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:33:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:33:29 +0000
Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from
 "Holds over" tab
In-Reply-To: <bug-15561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15561-70-bQYjrxTnfC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:33:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:33:31 +0000
Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from
 "Holds over" tab
In-Reply-To: <bug-15561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15561-70-5JmtqixUFX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50325|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51742&action=edit
[SIGNED-OFF] Bug 15561 - Add ability to charge cancelation fee from "Holds
over" tab

The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by
the automatic expiration cron script. Some libraries would prefer to
manually cancel holds via the "Holds over" tab of the "Holds awaiting
pickup" page but still be able to charge the cancellation fee.

Test Plan:
1) Apply this patch
2) Set ExpireReservesMaxPickUpDelayCharge to some number
3) Go to the Holds awaiting pickup page
4) Go to the Holds over tab
5) Note the new checkbox for charging the fee
6) Test canceling a single hold with the checkbox checked
7) Note a fee is charged
8) Test canceling a single hold with the checkbox unchecked
9) Note a fee is not charged
10) Test canceling all holds with the checkbox checked
11) Note the patrons are charged fees
12) Test canceling all holds without the checkbox checked
13) Note the patrons are not charged fees

Signed-off-by: Jason Burds <JBurds at dubuque.lib.ia.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:34:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:34:17 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-DlYwX3FAcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:34:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:34:20 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-X30r3lX8GN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51743&action=edit
Bug 16578: Fix wide character errors in opac-export.pl

This simple patch fixes wide character warning raised by opac-export.pl when
'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen
for downloading records.

To test:
- Have records indexed
- Open your OPAC logs:
  $ tail -f /var/log/koha/kohadev/opac-error.log
- Open the detail page in the opac for a record
- Choose Save record > MARC (Unicode/UTF-8)
=> FAIL: opac-export.pl: Wide character in print at
/home/vagrant/kohaclone/opac/opac-export.pl line 116., referer:
http://localh...
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> FAILE opac-export.pl: Wide character in print...
- Apply the patch
- Choose Save record > MARC (Unicode/UTF-8)
=> SUCCESS: No warnings raised.
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> SUCCESS: No warnings raised.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 19:40:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 17:40:03 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-c6z76zg9hG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:02:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:02:37 +0000
Subject: [Koha-bugs] [Bug 16579] New: Use separate memached namespace for
 caching koha-conf.xml
Message-ID: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

            Bug ID: 16579
           Summary: Use separate memached namespace for caching
                    koha-conf.xml
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The memcached configuration definitions were moved from koha-conf.xml to
environment variables to enable caching of the conf file itself.

This can cause numerous issues and difficulties making sure memcached is
enabled for all cron scripts, for plack, etc.

I propose we cache the koha conf file in a separate namespace with the caching
still defined in environment variables, but move the memcached configuration
for everything else back into the koha conf file itself.

This would allow us to continue caching everything, but even if the cache for
the koha-conf file is not configured for a given process, it would allow all
other data to still be cached and used. This would greatly improve overall
performance I think, especially for cron scripts that use the calendar for
holiday handling.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:05:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:05:21 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-LmVh3CQcnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51744&action=edit
Bug 16492 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:05:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:05:48 +0000
Subject: [Koha-bugs] [Bug 16580] New: Explain the link between the
 autoBarcode preference and the cataloging plugin
Message-ID: <bug-16580-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16580

            Bug ID: 16580
           Summary: Explain the link between the autoBarcode preference
                    and the cataloging plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If you have the 'barcode.pl' plugin enabled for the barcode field in your MARC
framework, but the 'autoBarcode' preference is turned off, the plugin will
appear to be active but won't do anything.

I think there ought to be text explaining the connection, to be shown both on
the system preference itself and when the barcode plugin is selected during
framework editing.

Or is there a time when one does something without the other?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:31:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:31:50 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-nkgU1iRZFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51391|0                           |1
        is obsolete|                            |
  Attachment #51744|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51745&action=edit
Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the
patron home branch as the logged in library

Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
non-Koha internal authentication processes would be able to function via
SIP ( LDAP et al ).

The problem is that checkpw changes the userenv to that of the patron!
This is not usually an issue in Koha because most of the time that
patron running through checkpw is the one to be logged in.

Aside from SIP2 the only other area where this may be an issue is in SCO
when using SelfCheckoutByLogin.

Test Plan:
1) On master, check out an item to a patron via SIP2
2) Note the checkout lists the item as having been checked out
   from the patron's home library not matter which library is was
   supposed to be checked out from.
3) Apply this patch
4) Re-checkout the item
5) The item should now be checked out as if it was checked out from
   the library as defined in the SIP configuration file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:32:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:32:45 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-jPHVSMg4xf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Srdjan Jankovic from comment #3)
> I think that we need a test for this one.

Unit test added!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:33:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:33:06 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-FqzIJpT5IY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Colin Campbell from comment #4)
> The call to checkpw in Patron.pm is weird and will probably make people
> think some magic is being invoked. the parameters should be more explicit
> i.e. :
> 
> checkpw($dvh, $self->{userid}, $pwd, undef, undef, 1);
> 
> with a comment to document

Fixed in new patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:42:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:42:36 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-k9bOSHMKLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51738|0                           |1
        is obsolete|                            |

--- Comment #66 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51746&action=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

The module appears now on the About page.
Signed-off-by: Marc V?ron <veron at veron.ch>

Ammended patch, only change is DBIx::RunSQL version,
now 0.14 :)

Module's author kindly accept to upgrade it, in particular
this makes Bug 16572 innecesary and is not needed to install
without problems.

Tested install on Ubuntu 14.04/Mysql 5.5.49, marc21 + all sample

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:57:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:57:21 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-nMB44rArXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16572                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572
[Bug 16572] Warnings on load_sql makes web installer fail
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:57:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:57:21 +0000
Subject: [Koha-bugs] [Bug 16572] Warnings on load_sql makes web installer
	fail
In-Reply-To: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16572-70-xAy2QdTjRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
             Blocks|16573                       |
         Resolution|---                         |INVALID
         Depends on|13669                       |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Fortunately this is not needed any more.

DBIx::RunSQL author kindly accepted to update the module, now 0.14, and sql
create statements does not rise warnings any more.

I tested a complete marc21 + sample data on Ubuntu 14.04/MySQL 5.5.49 without
incident


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573
[Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:57:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:57:21 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-Ah8rfbAlBX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16572                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572
[Bug 16572] Warnings on load_sql makes web installer fail
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:59:06 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-RFRaqLFuUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:59:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:59:09 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-0h29gvwzGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51747&action=edit
Bug 16570: Do not tell all checked-in items are part of a rotating collection

When an item is checked-in a message will tell you it's part of a
rotating collection, even if it's not true.

Test plan:
Make sure the message appears only when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 20:59:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 18:59:18 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-3RQfOxPRF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:10:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:10:47 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-S1o85jcbb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is it ready to be tested?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:23:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:23:45 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-sDWgeSZc4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The change in the kohastructure should be done for existing install (i.e.
atomic update).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:37:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:37:50 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-DmBLRPQmPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:37:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:37:54 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-fBOcMcGdma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51731|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51748&action=edit
Bug 16336 [Revised] UX of holds patron search with long lists of results

Bug 15793 made a change to an interface which is also found in the place
hold template. This patch creates a new include file to be used by both
circulation.tt and request.tt so that these pages do not diverge.

In the process, this patch removes some markup and JavaScript which was
made obsolete by Bug 15793 and should have been removed.

This patch also revises the sorting of the results table so that the
patron name is sortable (Bug 16334) and the default sort is on card
number (matching 3.20.x and 3.22.x).

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- The table of results which displays should look correct and work
  correctly, including DataTables sorting.
- Clicking any table row should forward you to the checkout page for
  that patron.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the table of patron results looks correct and works
  correctly.
- Clicking any table row should forward you to the place hold page for
  that patron and the title you selected.

Revision: Although the table row was clickable, you couldn't
middle-click it to open the link in a new tab. The patron name is now a
real link you can middle-click or right-click. The row is still
clickable as well.

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:39:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:39:10 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-jZYm5x20F6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lot of inconsistencies are fixed by this patch, well done Owen.
I am wondering why branchcode and categorycode are displayed, instead of their
description, on these 2 tables. Any valid reasons?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:41:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:41:20 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-IlSOAUmJhB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51747|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51749&action=edit
Bug 16570: Do not tell all checked-in items are part of a rotating collection

When an item is checked-in a message will tell you it's part of a
rotating collection, even if it's not true.

Test plan:
Make sure the message appears only when needed.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:41:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:41:34 +0000
Subject: [Koha-bugs] [Bug 16570] All checked-in items are said to be part of
 a rotating collection
In-Reply-To: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16570-70-CRaOdZ9CDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:46:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:46:54 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-hnHjIgsfL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51750&action=edit
Bug 15823: Force scalar context

CGI->param must not be called in list context

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 21:47:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 19:47:48 +0000
Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip
 without having the syspref on - Permissions breach
In-Reply-To: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15823-70-UW7tzADttp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
@RM & Rmaint, please push the follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 23:19:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 21:19:00 +0000
Subject: [Koha-bugs] [Bug 16426] Import borrowers tool warns for blank
 and/or existing userids
In-Reply-To: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16426-70-KRXxZOKCQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

--- Comment #17 from Craig Dean <craig at dean.net.nz> ---
(In reply to Katrin Fischer from comment #16)
> If you are importing new borrowers it will will help to add a userid column
> with some unique key to your import file - for example the cardnumber or
> something similar. That will let you import the data.

Unfortunately that did not work. It does not matter what I put in the userid
column it will not import the users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 23:25:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 21:25:40 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-3F33OFiH2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51751&action=edit
Bug 16573: change created_on type - atomic update

This patch change 'created_on' virtualshelves column to
datetime type

To test:
1) Apply the patch
2) Run updatedatabase.pl
3) Verify type of 'created_on' column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 24 23:57:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 21:57:24 +0000
Subject: [Koha-bugs] [Bug 16581] New: ICU tokenization bug in idzebra-2.0
	2.0.59-1
Message-ID: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

            Bug ID: 16581
           Summary: ICU tokenization bug in idzebra-2.0 2.0.59-1
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The version of idzebra-2.0

idzebra-2.0 2.0.59-1

which is the version in the debian-jesse repository, has a known
ICU-Tokenization bug:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777515

This has been seen to cause search errors with, for instance, the Chinese
language search for ????. Searches for the string of all four characters,
without spaces, will give hundreds of hits, whereas separating the ideograms
with spaces will limit the search to 8 search results, as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 01:32:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 23:32:05 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-z0csWtDBJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Hi Barton,

I was the one who found that bug in Zebra last year, and while I got Indexdata
to fix it in 2.0.60 (http://www.indexdata.com/zebra/doc/NEWS
https://github.com/indexdata/idzebra/commit/704fd190292cb771df94553b0ed6f9f4b71660a6),
I'm not sure that's the same issue that you're having. 

Have you tested your query with newer versions of Zebra (2.0.60+) to see if the
issue still exists in newer versions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 01:34:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 23:34:45 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-PxxLOHOWPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Robin and I mentioned this bug between Feb-May 2015 but no one really seemed to
care at the time
(http://permalink.gmane.org/gmane.education.libraries.koha.devel/11966).

I don't know if that means that people are using the Indexdata repositories or
if they're just ignoring erroneous behaviour in Zebra when using ICU...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 01:37:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 23:37:16 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-QP9gXIPKeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Sounds like badly encoded MARC data to me, but that's just a hunch/guess.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 01:38:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 May 2016 23:38:09 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-wvfRoLugRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Oh I had forgotten about this one... might have to look at this sometime...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 03:21:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 01:21:40 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-cwasKzh9Wp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51752&action=edit
Bug 16554: rewrite mandatory and sample data - de-DE

More changes to de-DE files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 03:23:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 01:23:13 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-JKsWHE9r7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51753&action=edit
Bug 16554: rewrite mandatory and sample data - es-ES

More changes to es-ES files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 03:53:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 01:53:50 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-WUtvEVF5ao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

--- Comment #4 from Janice Chow <janice.chow at sw-hk.com> ---
Something go wrong...I don't know how to fix it...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:23:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:23:27 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-ifnamfDGjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51754&action=edit
Bug 16554: rewrite mandatory and sample data - it-IT

More changes to it-IT files

Checked marc21 and unimarc files
unimarc_relatorterms.sql had bad encoding, others minor
errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:26:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:26:17 +0000
Subject: [Koha-bugs] [Bug 16582] New: t/Price.t test should pass if
 Test::DBIx::Class is not available
Message-ID: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

            Bug ID: 16582
           Summary: t/Price.t test should pass if Test::DBIx::Class is not
                    available
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mtompset at hotmail.com
        QA Contact: gmcharlt at gmail.com

I just spent hours doing  git clone to attempt the install pain under Ubuntu
16.04 LTS to see what the problem is, and the tests were still bugging me.

I'm going to attach 2 commits. The first is just to get the load test to keep
going, and should not be used. The second will fill the t/Price.t in a manner
similar to t/Members_AttributeTypes.t in bug 15150 was fixed.

TEST PLAN
---------
1) try prove t
   -- load will bomb
2) apply first patch
   -- prices will fail
3) apply second patch
   -- prices will "succeed"
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:26:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:26:37 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-VI4yg1Nexj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15150
           Assignee|chris at bigballofwax.co.nz    |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:26:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:26:37 +0000
Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class
 is not available
In-Reply-To: <bug-15150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15150-70-OeuTxJ6R6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16582

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:28:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:28:30 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-GeWUCeoqbH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51754|0                           |1
        is obsolete|                            |

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51755&action=edit
Bug 16554: rewrite mandatory and sample data - it-IT

More changes to it-IT files

Checked marc21 and unimarc files
unimarc_relatorterms.sql had bad encoding, others minor
errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:31:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:31:02 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-07lqyB7O7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51756&action=edit
Bug 16554: rewrite mandatory and sample data - nb-NO

More changes to nb-NO files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:32:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:32:33 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-qaXAqYmUjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51757&action=edit
Bug 16554: rewrite mandatory and sample data - pl-PL

More changes to pl-PL files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:36:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:36:36 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-kBTA9206Nt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51759&action=edit
Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available

TEST PLAN
---------
1) prove t/Prices.t
   -- failure
2) apply patch
3) prove t/Prices.t
   -- nicely skipped when Test::DBIx::Class is not available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:36:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:36:32 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-rKuJbFUQ2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51758&action=edit
Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available

This patch makes it so 00-load.t doesn't cause 'prove t' to
prematurely die before reaching other tests.

TEST PLAN
---------
1) prove t
   -- dies on 00-load.t
2) apply patch
3) prove t
   -- now t/Prices.t should be the failure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:37:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:37:22 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-GpFEMlplBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:40:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:40:18 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-NIWBWfBzFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16554                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554
[Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:40:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:40:18 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-jBS4mey7zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16554


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554
[Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 04:40:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 02:40:18 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-E1deeMEWFA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|13669                       |16573
             Status|ASSIGNED                    |Needs Signoff

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #4)
> Is it ready to be tested?

Yep, it's ready.

ru-RU and uk-UA not fixed, yet.
Perhaps on other bug after release.

I think we need this ASAP.

TEST PLAN
---------

ON TOP OF: Bug 16573

1) Apply ALL patches
2) Use MySQL 5.7
3) Then test web installer for all langs
 marc21: de-DE, es-ES, fr-CA, pl-PL
 unimarc: fr-FR (complete), it-IT
 normarc: nb-NO

 There must be no errors

4) Enjoy !!!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573
[Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 05:36:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 03:36:14 +0000
Subject: [Koha-bugs] [Bug 16583] New: Strangeness in the staff client on
 ubuntu 16.04 and MySQL 5.7
Message-ID: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

            Bug ID: 16583
           Summary: Strangeness in the staff client on ubuntu 16.04 and
                    MySQL 5.7
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P2
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Have noticed some strangeness with a clean install of Koha on MySQL 5.7:

When adding a rule at /cgi-bin/koha/admin/smart-rules.pl, if any box is left
empty the first empty field pops an error similar to this:

DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for
column 'chargeperiod' at row 1 at
/usr/share/koha/intranet/cgi-bin/admin/smart-rules.pl line 170

When attempting to add a borrower category, it thinks a duplicate has been
added with the resultant error message

"An error occurred when inserting this patron category. The patron category
might already exist."

The code for the category did not already exist.

I am reporting this bug on behalf of Son Nguyen - he may choose to add any
other information he has to this report.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 05:48:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 03:48:38 +0000
Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu
 16.04 and MySQL 5.7
In-Reply-To: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16583-70-4Np3sB5SqD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

Son Nguyen <ngson2000 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ngson2000 at yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 05:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 03:59:06 +0000
Subject: [Koha-bugs] [Bug 16584] New: All SQL queries should be compatible
 to 'ONLY_FULL_GROUP_BY'.
Message-ID: <bug-16584-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16584

            Bug ID: 16584
           Summary: All SQL queries should be compatible to
                    'ONLY_FULL_GROUP_BY'.
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: ngson2000 at yahoo.com
        QA Contact: testopia at bugs.koha-community.org

As the mode 'ONLY_FULL_GROUP_BY' is ON by default on MySQL 5.7, non
ONLY_FULL_GROUP_BY queries in Koha will be rejected.

This caused several issue including the error when adding a new patron even the
patron categories exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 07:04:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 05:04:04 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-Me6kUXnjS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51728|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51760&action=edit
Bug 16573: fix linkid value on marc_subfield_structure

followup to previous patch.

This patch fixes linkid value. It was set to '', but
declared as tinyint.
Mysql < 5.7 replaced this with nearest right value, i.e 0
Mysql 5.7 gives error here.

Also some normalization, all lines with data begins with two tabs

To test:
On top of Bug 16572 and previous patch

1) Run webinstaller
2) Add mandatory values
3) There must be no problems on MySQL 5.7

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 07:04:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 05:04:11 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-HrKqZfs2Jv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51741|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51761&action=edit
Bug 16573: fix structure and sample data for MySQL 5.7

Web install on Ubuntu 16.04/Mysql 5.7 fails.

This patch makes small changes to make installation
possible to kohastructure.sql and some sample files.

Sample values for quotes table can't have '0000-00-00 ...' values
nor NULL values, now() is perhaps an option.

Depends on Bug 16572

To test:
1) System with MySQL 5.7, for example Ubuntu 16.05
2) Apply 16572
3) Try web install, it fails
4) Apply this and next patch
5) Try again, now it succeed

This is only for English install, i18n files needs revision
I can do that if this is accepted.

Perphaps a change is needed to updatedatabase.pl

Ammended patch, 'created_on' field on virtualshelves
can't be timestamp default null, mysql 5.5 complains
that only one timestamp column can be defined as
default not null. Changed to 'datetime' type.

Can provide followup with updatedabase change,
but need an opinion if this type change makes sense.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 07:04:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 05:04:18 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-hsDHjlQIn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51751|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51762&action=edit
Bug 16573: change created_on type - atomic update

This patch change 'created_on' virtualshelves column to
datetime type

To test:
1) Apply the patch
2) Run updatedatabase.pl
3) Verify type of 'created_on' column

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 07:12:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 05:12:25 +0000
Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and
 sample data on MySQL 5.7
In-Reply-To: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16573-70-xGqLgSVhKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
I did a fresh, full git install under Ubuntu 16.04 LTS.
Attempting to install gave a nasty Step 3 problem.
Applying these patches made it go away.
I transplanted an older DB dump and ran an upgrade. It ran.
Though, my upgrade from 3.15.x seems to be missing a created_on. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 09:10:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 07:10:10 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-5jbroyWqq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:21:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:21:28 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-akRNmNBpwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #67 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:23:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:23:18 +0000
Subject: [Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single
	holidays
In-Reply-To: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16539-70-YxqdiGpzYB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:35:26 +0000
Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate
 db_max for 'annual' barcodes
In-Reply-To: <bug-15877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15877-70-4R7MQCAh2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
           Severity|enhancement                 |normal
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:35:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:35:38 +0000
Subject: [Koha-bugs] [Bug 16561] Regression caused by 15877 -
 t/db_dependent/Barcodes.t deletes all items from a DB
In-Reply-To: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16561-70-h2tso49RGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16561

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:51:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:51:31 +0000
Subject: [Koha-bugs] [Bug 16585] New: Update Italian installer sample files
	for 16.05
Message-ID: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

            Bug ID: 16585
           Summary: Update Italian installer sample files for 16.05
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: z.tajoli at cineca.it
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Update and translate sample SQL file of the Italinan installer.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:52:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:52:58 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-qLTYDFjSST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |z.tajoli at cineca.it
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:53:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:53:00 +0000
Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with
	Plack
In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16520-70-UXySBT5h4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #18 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #15)
> I have to admit I am a bit lost with all the apache config files, but should
> not we move the RequestHeader add X-Koha-SetEnv lines to
> apache-shared-[intranet|opac]-plack.conf files?

I'm inclined to agree; at first I was thinking to have an example of the new
syntax in the configuration files, but given that this should be wrapped in an
<IfModule>, it should be moved there.

(In reply to Jonathan Druart from comment #16)
> In C4::Context->preference, the lc $var has been moved after the
> OVERRIDE_SYSPREF_* check, I don't think it's expected.

This is in tune with the documentation and how this feature has been
historically used; see
http://manual.koha-community.org/3.22/en/administration.html#globalsysprefs .

(In reply to Jonathan Druart from comment #17)
> 108     # We also add the MEMCACHED_ settings to the actual environment, to
> make sure any early
> 109     # initialization of Koha::Cache correctly sets up a memcached
> connection.
> 110     foreach my $special_var ( qw( MEMCACHED_SERVERS MEMCACHED_NAMESPACE
> ) ) {
> 111         $ENV{$special_var} = $setenvs{$special_var} if defined
> $setenvs{$special_var};
> 112     }
> 
> Jesse, could you explain in which cases this is useful?

C4::Auth, in my testing, loads up some system preferences early on that cause
Koha::Cache to be initialized before the Plack environment is copied to %ENV
(presumably by the Plack CGI wrapper?).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:54:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:54:59 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-K3vA4AJkfH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
This is weird, bug 16506 depends on the first patch of this bug, but the 2nd
patch of this bug depends on bug 16506. They have been pushed to master in this
order: 16505 (1st) -> 16506 (all) -> 16505 (2nd).
I think the 2nd patch here belongs to bug 16506.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:55:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:55:59 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-lct1Ws6zk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
First patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:57:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:57:14 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-yJP27EMQwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |With this patch all
      release notes|                            |sample/defintions .sql
                   |                            |files are translated into
                   |                            |Italina (if you select
                   |                            |italian during web
                   |                            |installation).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 10:58:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 08:58:23 +0000
Subject: [Koha-bugs] [Bug 16517] A server error is raised when creating a
 new list with an existing name
In-Reply-To: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16517-70-tzcxmrPps1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:01:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:01:04 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-H2s5JCjl5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16382

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:01:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:01:04 +0000
Subject: [Koha-bugs] [Bug 16382] Update German web installer sample files
	for 16.05
In-Reply-To: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16382-70-KosdPho5KY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16382

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16585

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:05:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:05:01 +0000
Subject: [Koha-bugs] [Bug 16553] Incorrect path to jQueryUI file in help
	template
In-Reply-To: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16553-70-VHiXay8BhR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Not needed in stable versions, status changed to RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:05:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:05:01 +0000
Subject: [Koha-bugs] [Bug 16557] Remove the use of "onclick" from several
	include files
In-Reply-To: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16557-70-h0WG2bDete@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557
Bug 16557 depends on bug 16553, which changed state.

Bug 16553 Summary: Incorrect path to jQueryUI file in help template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:07:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:07:27 +0000
Subject: [Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly
 calculates max and should warn when no branchcode present
In-Reply-To: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15878-70-zaAyxvJi1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:19:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:19:31 +0000
Subject: [Koha-bugs] [Bug 16478] Translation breaks display of Checkout
 history in tab Checkouts / On-site-checkouts
In-Reply-To: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16478-70-jQ2C3uR3Ql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:20:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:20:46 +0000
Subject: [Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay
 breaks content display in intranet (titles not showing in lists)
In-Reply-To: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16484-70-WzP72UhI8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:25:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:25:00 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-CdwGGMr9V8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
It doesn't look like a bugfix (severity = normal), can someone confirm this is
an enhancement ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:26:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:26:14 +0000
Subject: [Koha-bugs] [Bug 16516] showListsUpdate JS function is not defined
	at the OPAC
In-Reply-To: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16516-70-yATQgHS6oy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16516

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:30:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:30:52 +0000
Subject: [Koha-bugs] [Bug 16550] Can't set opac news expiration date to NULL,
 it reverts to today
In-Reply-To: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16550-70-a47Z9FoCWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |julian.maurice at biblibre.com

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:34:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:34:51 +0000
Subject: [Koha-bugs] [Bug 16499] circulation.pl logs warnings about Use of
 uninitialized value
In-Reply-To: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16499-70-7uvErzxeYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:44:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:44:35 +0000
Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety
In-Reply-To: <bug-16166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16166-70-Ps3WkgCqSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50708|0                           |1
        is obsolete|                            |

--- Comment #16 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 51763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51763&action=edit
Bug 16166: Improve L1 cache performance and safety

Bug 16044 introduced two-level caching mechanism to Koha::Cache. By
default, get_from_cache() returns a deep copy of the data structures
stored in L1 cache (aka "safe mode"). For extremely big and/or complex
data structures (like MARC framework hash-of-hashes-of-hashes returned
by GetMarcStructure() ), deep-cloning is currently sub-optimal;
this patch addresses that particular issue. It also provides an
ability to intermix "safe" and "unsafe" cache feches, in such
way that they don't interfere with each other (i.e., eliminating
the risk involved with "unsafe" calls possibly compromising
further "safe" calls).

Test plan:

1) apply patch
2) flush L2 cache if necessary (restart memcached daemon)
3) profile GetMarcStructure() calls before / after patch, e.g. by
running some script which calls it often (like catalogue search
w/ XSLT processing turned on, etc.) - GetMarcStructure() should be
faster than before, in all possible circumstances (eg. 18 msec
per call -> 10 msec p/call)
5) prove -v t/Cache.t - all 39 tests should pass; if you see something
like 'ok 39 # skip Cache not enabled', it means that cache is not
active and you need to manually revert Bug 16104 first
6) after testing, before returning to the master branch, flush L2 cache
again (restart memcached daemon) - otherwise all system preferences
returned from L2 cache would be suffixed with '-CF0'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:44:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:44:42 +0000
Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety
In-Reply-To: <bug-16166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16166-70-dYvd3F1ysZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50709|0                           |1
        is obsolete|                            |

--- Comment #17 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 51764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51764&action=edit
Bug 16166: Fix t/Cache.t tests

Thou shalt not forget to include changes made in the t/Cache.t
in the patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 11:44:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 09:44:47 +0000
Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety
In-Reply-To: <bug-16166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16166-70-O5eAFisJAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166

--- Comment #18 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 51765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51765&action=edit
Bug 16166: Update number of tests to run in t/Cache.t

Update number of tests to run + number of tests to skip in case when
cache is not active.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 12:07:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 10:07:19 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-gJdzkJm9O4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #68 from Kyle M Hall <kyle at bywatersolutions.com> ---
Excellent! Followup pushed to master! Thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 13:39:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 11:39:51 +0000
Subject: [Koha-bugs] [Bug 16586] New: Koha Plugins: Limit results of
 GetPlugins by metadata
Message-ID: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

            Bug ID: 16586
           Summary: Koha Plugins: Limit results of GetPlugins by metadata
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 13:40:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 11:40:07 +0000
Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins
	by metadata
In-Reply-To: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16586-70-XizTqzLJvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 13:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 11:46:51 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-xNkpbsgryR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586
[Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 13:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 11:46:51 +0000
Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins
	by metadata
In-Reply-To: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16586-70-RLyjSqQ3mL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16502


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502
[Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not
always dropped after running Plugin.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 13:55:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 11:55:30 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-X8qiFr5FA8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 13:55:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 11:55:32 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-p761sYpFQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51733|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51766&action=edit
[SIGNED-OFF] Bug 16507: Show play media tab first if record has no holdings

EDIT: Same fix for OPAC side

To test:
1) Go to Admin -> Global sysprefs
2) Turn on HTML5MediaEnabled and HTML5MediaYouTube
3) Go to Cataloging and create a new record
4) Catalogue a YouTube link in 856$u and save record. Do not add any
   items (click Normal tab)
5) Confirm that Play media tab shows first

6) Go to OPAC side and look at same record
7) Confirm that Play media tab shows first

8) Go back to staff side, add an item then go back to Normal tab
9) Confirm that Holdings tab now shows first and Play media tab is last

10) Go to OPAC side, confirm that Holdings tab now shows first and Play
    media tab is last

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:06:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:06:11 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-4rSfLp9NZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:06:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:06:13 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-9sJBockz8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51730|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51767&action=edit
[SIGNED-OFF] Bug 16532: Groups showing empty tables if no groups defined

EDIT: Same change for libraries

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:10:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:10:41 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-6RvWvPNft9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:10:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:10:43 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-DSnxqqZHIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51745|0                           |1
        is obsolete|                            |

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51768&action=edit
Bug 16492 - Checkouts ( and possibly checkins and other actions ) will use the
patron home branch as the logged in library

Bug 14507 introduced the use of checkpw in C4::SIP::ILS::Patron so that
non-Koha internal authentication processes would be able to function via
SIP ( LDAP et al ).

The problem is that checkpw changes the userenv to that of the patron!
This is not usually an issue in Koha because most of the time that
patron running through checkpw is the one to be logged in.

Aside from SIP2 the only other area where this may be an issue is in SCO
when using SelfCheckoutByLogin.

Test Plan:
1) On master, check out an item to a patron via SIP2
2) Note the checkout lists the item as having been checked out
   from the patron's home library not matter which library is was
   supposed to be checked out from.
3) Apply this patch
4) Re-checkout the item
5) The item should now be checked out as if it was checked out from
   the library as defined in the SIP configuration file.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:16:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:16:23 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-zNtU6W7YqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:16:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:16:25 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-WjPB1XcB3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51729|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51769&action=edit
[SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no
overdues

EDIT: Comment 2

To test:
1) Ensure you have no items overdue
2) Go to Circ -> Circulation reports -> Overdues
3) Notice empty table, '0 items overdue' heading
4) Apply patch and refresh page
5) Notice empty table is no longer showing and page says "There are no
overdues"
6) Apply a filter to search
7) Page now says "There are no overdues matching your search" with a link to
reset filter.
8) Click Reset filter -> confirm any filters you applied are cleared.
9) Check out an item to a member, ensure due date is a date that has passed
(i.e. yesterday)
10) Refresh overdue report page
11) Confirm table now shows correctly with '1 items overdue' heading etc.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:26:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:26:48 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-Sw80V3YvcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Back to Assigned: Making some changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:33:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:33:18 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-1s8m2EQQFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:33:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:33:21 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-hMxjHaKXAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51437|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51770&action=edit
Bug 16500: Catch two warns in TestBuilder.t with warning_like

When testing a wrong case in TestBuilder.t, two warns show up.
We can catch them with warning_like.

Test plan:
Run t/db_dependent/TestBuilder.t

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:35:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:35:05 +0000
Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins
	by metadata
In-Reply-To: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16586-70-OtIvHyhouX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:35:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:35:07 +0000
Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins
	by metadata
In-Reply-To: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16586-70-OY51zaNmuj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51771&action=edit
Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata

It would be helpful if we could find a plugin based on some metadata
tag as returned by the plugin. This extends the use of GetPlugins that
already supports searching on method.

GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and
tools/stage-marc-import.pl. The changes in these three scripts are
minimal and just related to parameter passing.

Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this
regard a metadata tag has been added to t/Koha/Plugins/Test.pm.

NOTE: This adjustment will also be used in a redesign for bug 15545.

Test plan:
Run t/db_dependent/Plugins.t.
Enable pref UseKohaPlugins and config var enable_plugins.
Go to plugins-home.pl. Verify that it still lists your plugins.
Bonus: Check edi_accounts or stage-marc-import.pl if you have a working
plugin for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:39:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:39:09 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-um2zNg6QGB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586
[Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:39:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:39:09 +0000
Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins
	by metadata
In-Reply-To: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16586-70-mxgLnHnbLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545
[Bug 15545] Optionally require notes when placing a hold
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:42:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:42:06 +0000
Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different
 library doesn't re-route item to correct library
In-Reply-To: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13153-70-ZCUwveCHn3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:43:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:43:10 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-WNzQIXUXn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:43:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:43:12 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-E7ZQS8vMpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51725|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51772&action=edit
[SIGNED-OFF] Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 14:51:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 12:51:52 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-MVzvPptx2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
To test:
- Start with an empty database
- Install it-IT
- Run the web installer in it-IT/Italian
- Verify all files, especially sample notices, sample_frequencies,
sample_numberpatterns load without any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:08:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:08:48 +0000
Subject: [Koha-bugs] [Bug 16442] C4::Ris is not plack safe
In-Reply-To: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16442-70-tgskr5afiF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:08:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:08:51 +0000
Subject: [Koha-bugs] [Bug 16442] C4::Ris is not plack safe
In-Reply-To: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16442-70-zfwELRKOJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51221|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51773&action=edit
Bug 16442: Make C4::Ris plack safe

C4::Ris incorrectly uses 4 package variables:
- $utf: not used, can be removed
- $intype: set to marcflavour once, but later it assumes that it is
  usmarc if not defined
- $marcprint: always 0, so set it to 0
- $protoyear: only used in 1 subroutine, let's define it at this
  level

Test plan:
Just make sure the RIS export works as before this patch

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:17:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:17:22 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-1C1V8nRm3k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51743|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51774&action=edit
Bug 16578: Fix wide character errors in opac-export.pl

This simple patch fixes wide character warning raised by opac-export.pl when
'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen
for downloading records.

To test:
- Have records indexed
- Open your OPAC logs:
  $ tail -f /var/log/koha/kohadev/opac-error.log
- Open the detail page in the opac for a record
- Choose Save record > MARC (Unicode/UTF-8)
=> FAIL: opac-export.pl: Wide character in print at
/home/vagrant/kohaclone/opac/opac-export.pl line 116., referer:
http://localh...
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> FAILE opac-export.pl: Wide character in print...
- Apply the patch
- Choose Save record > MARC (Unicode/UTF-8)
=> SUCCESS: No warnings raised.
- Choose Save record > MARC (Unicode/UTF-8, Standard)
=> SUCCESS: No warnings raised.
- Sign off :-D

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:17:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:17:40 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-1KoVHXxVPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:39:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:39:14 +0000
Subject: [Koha-bugs] [Bug 16323] Make dropdowns in header open on hover
In-Reply-To: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16323-70-DLMLIGV0ms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at ptfs-europe.com
             Status|Needs Signoff               |Signed Off

--- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Patch tested with a sandbox, by Sinziana Paltineanu
<s.paltineanu at berlin.bard.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:39:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:39:26 +0000
Subject: [Koha-bugs] [Bug 16323] Make dropdowns in header open on hover
In-Reply-To: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16323-70-CCXTbmqmVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50546|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:39:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:39:34 +0000
Subject: [Koha-bugs] [Bug 16323] Make dropdowns in header open on hover
In-Reply-To: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16323-70-UmjLdyr4uF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

--- Comment #6 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 51775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51775&action=edit
Bug 16323: Make dropdowns in header open in hover

To test:
1) Go to staff client
2) Hover over 'More' menu and confirm that menu opens
3) Hover over the user dropdown on the right ("username | branch") and confirm
that menu opens

Sponsored-by: Catalyst IT

Signed-off-by: Sinziana Paltineanu <s.paltineanu at berlin.bard.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:41:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:41:19 +0000
Subject: [Koha-bugs] [Bug 16505] rebuild_zebra.pl skips updates if -x is
	passed
In-Reply-To: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16505-70-VL4NuUbFql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16505

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Julian Maurice from comment #11)
> This is weird, bug 16506 depends on the first patch of this bug, but the 2nd
> patch of this bug depends on bug 16506. They have been pushed to master in
> this order: 16505 (1st) -> 16506 (all) -> 16505 (2nd).
> I think the 2nd patch here belongs to bug 16506.

I take the blame for the circular bug dependency :-D
And you are right about Jonathan's followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:48:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:48:09 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-qoWN9BSPbS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51735|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51776&action=edit
Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences)

This patch removes tag-splitting from 2 sentences in pac-auth.tt

To test:
- Review code changes and verify that following sentences
  are no longer splitted by <a>-tags:
  "Logout and try again with a different user"
  "Try to log in using a different Google account"

UPDATE: Amended to fix a tiny typo

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:50:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:50:14 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-rWKnHaPkqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at ptfs-europe.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Patch tested with a sandbox, by Jan Kissig <jkissig at th-wildau.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:50:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:50:27 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-UdjGGU20o6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51555|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:50:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:50:36 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-QMOAuDKTV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

--- Comment #3 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 51777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51777&action=edit
Bug 16530: Adding a circ sidebar navigation menu

This adds a sidebar to
circ/branchoverdues.tt
circ/circulation.tt (I also fixed up some of the indentation in this file to
make it easier to see where the divs started and ended)
circ/renew.tt
circ/returns.tt
circ/selectbranchprinter.tt
circ/transferstoreceive.tt
circ/view_holdsqueue.tt
circ/waitingreserves.tt
offline_circ/list.tt
offline_circ/process_koc.tt

To test:
1) Go to all of the above pages and confirm the sidebar menu shows up.
2) Trigger any error messages you can possibly think of (i.e. on renew.pl:
barcode does not exist). Confirm that this does not mess up the layout of the
page
3) Go to a user account page, Check out tab. (Since this is a
circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm
it looks as it usually does)
4) Decide if you like how things look or not!

Sponsored-by: Catalyst IT

Signed-off-by: Jan Kissig <jkissig at th-wildau.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:51:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:51:24 +0000
Subject: [Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as
	default
In-Reply-To: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16506-70-maab3nlL4a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Julian Maurice from comment #12)
> It doesn't look like a bugfix (severity = normal), can someone confirm this
> is an enhancement ?

Well, it might be. Because bug 11096 introduced XML as exchange format for DOM
setups, to allow bigger records to get indexed, and we then deprecated GRS-1.
To me this is something we just forgot to tweak after 11096. But it is really
up to you to include it in 3.22 as it supposes a behaviour change for people
using the cronjob to update their indexes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:10 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-T8UqLO5C8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51527|0                           |1
        is obsolete|                            |
  Attachment #51528|0                           |1
        is obsolete|                            |
  Attachment #51529|0                           |1
        is obsolete|                            |
  Attachment #51530|0                           |1
        is obsolete|                            |
  Attachment #51531|0                           |1
        is obsolete|                            |
  Attachment #51532|0                           |1
        is obsolete|                            |
  Attachment #51533|0                           |1
        is obsolete|                            |
  Attachment #51534|0                           |1
        is obsolete|                            |

--- Comment #178 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51778&action=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
    ArticleRequestsMandatoryFields
    ArticleRequestsMandatoryFieldsItemsOnly
    ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:21 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-j5AoBl0vcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #179 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51779&action=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:25 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-mU7JpjKg9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #180 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51780&action=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:30 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-sZ6DXMqDGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #181 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51781&action=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:38 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-UeZizWgobo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #183 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51783&action=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:34 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
	Koha
In-Reply-To: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14610-70-TZhYcQoKBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #182 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51782&action=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:53:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:53:41 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-2JIFBa9bbK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Jan Kissig <jan.kissig at th-wildau.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kissig at th-wildau.de

--- Comment #4 from Jan Kissig <jan.kissig at th-wildau.de> ---
tested in sandbox. layout was okay and not messed up while showing error
messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:55:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:55:20 +0000
Subject: [Koha-bugs] [Bug 16588] New: libreadonly-perl (and
 libreadonly-xs-perl) need to be added as dependencies
Message-ID: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

            Bug ID: 16588
           Summary: libreadonly-perl (and libreadonly-xs-perl) need to be
                    added as dependencies
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: robin at kallisti.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Doing a build in a clean environment:

#   Failed test 'use C4::Overdues;'
#   at t/00-load.t line 47.
#     Tried to use 'C4::Overdues'.
#     Error:  Can't locate Readonly.pm in @INC (you may need to install the
Readonly module) (@INC contains:
/build/koha-3.23~git+20160525154303.188b3b5b/blib/PERL_MODULE_DIR
/build/koha-3.23~git+20160525154303.188b3b5b/blib/arch /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1
/usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at
/build/koha-3.23~git+20160525154303.188b3b5b/blib/PERL_MODULE_DIR/Koha/SearchEngine.pm
line 22.

It should have been added in bug 7893, but apparently went missing some time
later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:58:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:58:19 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-ZzghdbEf9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Sabine Liebmann <Liebmann at dipf.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:58:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:58:33 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-GRI91HTFXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51772|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 15:58:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 13:58:40 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-iyeEY0kPaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 51784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51784&action=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Sabine Liebmann <Liebmann at dipf.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:05:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:05:45 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-elXLFGwf1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #24 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
New module to handle management of circulation to Housebound readers.

- Ability to record users as housebound (HB category), volunteers
  (combined deliverers and choosers, VOL category), deliverers (DELIV
  category) choosers (CHO category).
- Ability to link users to individual delivery runs.
- Ability to check on issuing to housebound users flagging
  if title has previously been issued to this user, to aid choosers.
- 'Delivery Days' and 'Delivery Frequencies' are customizable through
  authorised values ('Day' and 'Frequency' categories respectively.

Sponsored by Halton Borough Council

* C4/Auth.pm: Add check: useHouseboundModule.
* C4/Circulation.pm: use Housebound to check for previous issue.
* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: add
  'previous checkout' warning.
* C4/Housebound.pm: new.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: new.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundedit.tt: new.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundinstances.tt: new.
* members/housebound.pl: new.
* members/houseboundedit.pl: new.
* members/houseboundinstances.pl: new.
* installer/data/mysql/atomicupdate/housebound_tables.sql: new.
  - create 'housebound', 'housebound_instance' tables,
  - create 'HB', 'VOL', 'DELIV', 'CHO' borrower categories,
  - create sample 'Day', 'Frequency' authorised values,
  - add 'useHouseboundModule', 'useHouseboundCheckPrevious' syspref.
* t/Housebound.t: new.

Test plan:
- Apply patch.
- Run atomic update script.
- Optionally, run Unit Tests (t/Housebound.t)
- Create at least 1 of each: 'HB', 'VOL', 'DELIV', 'CHO' borrower.
- Optionally, add additional authorised values of 'Day' and
  'Frequency' categories.
- Verify 'useHouseboundModule' & 'useHouseboundCheckPrevious' sysprefs
  are on.
- On the page of the 'HB' borrower, open the new 'Housebound' menu.
  - create housebound profile
    + ensure Day and Frequency values are from correct authorised
      values
  - create 'housebound instances' (deliveries)
    + ensure chooser/deliverer lists are populated with VOL, DELIV,
      CHO borrowers
  - edit the profile/instances.
  - delete the profile/instances.
- For a borrower with a housebound profile, issue an item, then
  - return that item
  - attempt to re-issue that item (you should get a warning)
- Switch off 'useHouseboundCheckPrevious', repeat last test
  - the warning should not appear
- Switch off 'useHouseboundModule'
  - the Housebound menu should disappear
  - the issue warnings should no longer appear.

Largely based on prior work from Mark Gavillet and Colin Campbell.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:06:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:06:14 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-bcNjDqelUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at ptfs-europe.com

--- Comment #7 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Patch tested with a sandbox, by Sabine Liebmann <Liebmann at dipf.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:06:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:06:27 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-p4OqRahwm8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51784|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:06:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:06:35 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-2xcONvIRx5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

--- Comment #8 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 51786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51786&action=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Sabine Liebmann <Liebmann at dipf.de>

Signed-off-by: Sabine Liebmann <Liebmann at dipf.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:08:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:08:42 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-ylcizH8tFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Sorry, QA tools complain:
 FAIL   opac/opac-addbybiblionumber.pl
   FAIL   valid
                Global symbol "$bib" requires explicit package name 
                opac/opac-addbybiblionumber.pl had compilation errors.
                Found = in conditional, should be == 
                Can't modify scalar in scalar assignment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:35:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:35:30 +0000
Subject: [Koha-bugs] [Bug 16589] New: Quote of the day: Can not upload csv
	file
Message-ID: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

            Bug ID: 16589
           Summary: Quote of the day: Can not upload csv file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

Upload a valid CSV file to QOD results in error message.

Uploads limited to csv. Incorrect filetype: application/vnd.sun.xml.calc

Tested with a valid sample file from Bug 15684 - Fix encoding issues with quote
upload
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47405

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:36:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:36:02 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-2SDOAxra0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16589

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:36:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:36:02 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Can not upload csv file
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-SfdrD1IHa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16513

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:36:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:36:32 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-N3f4NjaPuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #25 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---

New module to handle management of circulation to Housebound readers.

- Ability to create housebound profiles & scheduled visits for patrons.
- Ability to record users as Deliverers or Choosers (or both), using
  extended patron attributes.
- Ability to link choosers and deliverers to individual delivery runs.
- 'Delivery Frequencies' are customizable through authorised
  values ('Frequency' category respectively).

* C4/Auth.pm: Add check: useHouseboundModule.
* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* Koha/Patron.pm (housebound_profile): New method.
* Koha/Patron.pm (housebound_choosers, housebound_deliverers): New
  methods.
* Koha/Patron/Housebound.pm: New File.
* Koha/Patron/HouseboundProfile.pm: New File.
* Koha/Patron/HouseboundProfiles.pm: New File.
* Koha/Patron/HouseboundVisits.pm: New File.
* Koha/Patron/HouseboundVisit.pm: New File.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file.
* members/housebound.pl: New file.
* installer/data/mysql/kohastructure.sql: Add housebound_* tables.
* installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add HouseboundModule syspref.
* installer/data/mysql/atomicupdate/housebound_tables.sql: New file.
* t/db_dependent/Patron/Housebound.t: New file.
* t/db_dependent/Patron/HouseboundProfiles.t: New file.
* t/db_dependent/Patron/HouseboundVisits.t: New file.

Test plan:
- Apply patch.
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values of 'Frequency'
  categories.
- Verify 'HouseboundModule', and 'ExtendedPatronAttributes sysprefs are
  on.
- Ona patron page, the Housebound menu should have been added.
  - create housebound profile
    + ensure Frequency values are from correct authorised values.
  - create 'housebound visits' (deliveries)
    + ensure chooser/deliverer lists are populated with patrons that
    have the Chooser or Deliverer Attribute type (none by default: you
    will have to grant some users those attributes).
  - edit the profile/instances.
  - delete the instances.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:36:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:36:44 +0000
Subject: [Koha-bugs] [Bug 16590] New: error log recording
Message-ID: <bug-16590-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16590

            Bug ID: 16590
           Summary: error log recording
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mjoao at reitoria.ulisboa.pt
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi!

I needed to know what kind of error is this:

"
Software error:

Can't call method "fields" on an undefined value at
/usr/share/koha/lib/C4/Biblio.pm line 2438.

For help, please send mail to the webmaster (
<mailto:Bibliotecas at Reitoria.UTL.PT> Bibliotecas at Reitoria.UTL.PT), giving this
error message and the time and date of the error. 

T?tulo da disserta??o: Efeito da administra??o da hormona PGF2? nos problemas
p?s-parto, mais concretamente na reten??o placent?ria em bovinos leiteiros

Autor: Francisco Maria Pereira Leit?o de Freitas Formigal

2 - The record you requested does not exist (503962).
"

I'm working with an old version of Koha, from 2012 the 3.08.05.000 version.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:37:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:37:17 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching
 koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-O0C1LxqbrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jweaver at bywatersolutions.co
                   |                            |m

--- Comment #1 from Jesse Weaver <jweaver at bywatersolutions.com> ---
I'd like to suggest that we either:

 a) drop the caching for the koha-conf.xml entirely (in my testing, this adds
about .14 seconds to an average CGI load) or
 b) just hardcode the server/namespace for caching the koha-conf.xml and use
the filename of the .xml as the cache key
(kohaconf-/etc/koha/sites/SITE/koha-conf.xml). Using localhost:11211 will work
for 99.9% of setups, and if memcached isn't running there, Koha will still work
(just a tiny bit slower under CGI).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:37:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:37:56 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching
 koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-UmumtKLRYN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:40:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:40:27 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-3RspxYEnrg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Can not test upload (with and without patch), see Bug 16589

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:52:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:52:25 +0000
Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons
 in patron attribute types administration
In-Reply-To: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16543-70-gUAgqJHySK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51789&action=edit
Bug 16543 - Make edit and delete links styled buttons in patron attribute types
administration

This patch modifies the Patron attribute types page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.

To test, apply the patch and go to Administration -> Patron attribute
types. The 'Edit' and 'Delete' buttons should look correct and work
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:52:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:52:23 +0000
Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons
 in patron attribute types administration
In-Reply-To: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16543-70-jIMG4JXHxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:55:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:55:37 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-JpVD6nhNSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

s.paltineanu at berlin.bard.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s.paltineanu at berlin.bard.ed
                   |                            |u

--- Comment #26 from s.paltineanu at berlin.bard.edu ---
DBIx::Class::Schema::source(): Can't find source for HouseboundProfile at
/home/sandbox1/src/Koha/Objects.pm line 253

I got this error when clicking on the "Housebound" tab, in a new patron's
profile. (testing in a sandbox)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:55:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:55:40 +0000
Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons
 in cities administration
In-Reply-To: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16541-70-8aPIoRRbEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:56:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:56:08 +0000
Subject: [Koha-bugs] [Bug 16579] Use separate memached namespace for caching
 koha-conf.xml
In-Reply-To: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16579-70-jqt28qSVBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:57:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:57:48 +0000
Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons
 in cities administration
In-Reply-To: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16541-70-w8giXgHSib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 16:57:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 14:57:50 +0000
Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons
 in cities administration
In-Reply-To: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16541-70-NamSlMcxhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51790&action=edit
Bug 16541 - Make edit and delete links styled buttons in cities administration

This patch modifies the cities administration page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.

To test, apply the patch and go to Administration -> Cities and towns.
The 'Edit' and 'Delete' buttons should look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:06:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:06:57 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Can not upload csv file
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-ZRUtu7FV1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I've tried my own CSV file and those on Bug 15684 and I get no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:32:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:32:21 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-J1xRphCvVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:32:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:32:23 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-Yt8MwHExCB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51791&action=edit
Bug 16566 - 'Print slip' button formatting inconsistent

This patch modifies the style of some "print slip" links on the checkin
page to make them consistent with other buttons shown in dialogs.

This patch also removes the use of "onclick" in some places in favor of
defining events in the JavaScript.

To test apply the patch and go to Circulation -> Check in.

- Check in an item which belongs at another branch. You should see a
  dialog which asks the user to transfer the item. Confirm that the
  "Print slip" button looks correct and works correctly.

- Check in the same item again. You should see a different dialog which
  has both a "Print transfer slip" and "Cancel transfer" button. The
  "Print transfer slip" button should look correct and work correctly.

- Check in an item which is part of a rotating collection. (Or, if Bug
  16570 is still open, check in any item) You should see a dialog which
  notifies you that the item is part of a rotating collection. The
  "Print slip" button in this dialog should look correct and work
  correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:37:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:37:01 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-hPZYSEaRz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #5)

> I am wondering why branchcode and categorycode are displayed, instead of
> their description, on these 2 tables. Any valid reasons?

It is probably simply a remnant of the old version which displayed the list in
a <select> and required a more compact display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:41:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:41:38 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-egLNS2L6GP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:51:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:51:01 +0000
Subject: [Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and
 can't be read by some aggregators (Chimpfeedr, feedbucket)
In-Reply-To: <bug-16567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16567-70-e6xzJGego0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This may be fixed by Bug 16111.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 17:53:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 15:53:53 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-5bblJg3Ter@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:01:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:01:00 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-X9JkHq5gkC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51792&action=edit
Bug 16462 - Change default sorting of circulation patron search results to
patron name

This patch changes the default sort of patron quick search results from
the circulation header search or when searching for a patron during the
hold process.

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- Confirm that the results are sorted by patron name.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the results are sorted by patron name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:00:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:00:58 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-kczVD5Nr4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:10:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:10:52 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-Z9WchiLiJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:10:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:10:55 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-5XhJUsOgGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51484|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51796&action=edit
Bug 16519: Replace 'our' with 'my' in [opac-]addbybiblionumbers.pl

To avoid bug like bug 16518 and to ease the readability/maintainability
of these scripts, this patch replaces the use of 'our' with 'my' to
avoid the use of global variables.

Basically the code has been moved from subroutines to the appropriate places.

Test plan:
At the intranet and OPAC sides
1/ Add items to a list
2/ Add items to a list using an existing name
3/ Add items to a list you don't have right on it (by modifying the
biblionumber in the url)
4/ At the OPAC, use the opac-addbybiblionumber.pl without being logged
in to add items to a list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:11:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:11:48 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-giNnon8WmQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Shame on me, sorry about that.
I have decided to rename the $bib var after my tests, but I have missed one!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:15:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:15:51 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-asOZlPbkrV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:16:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:16:48 +0000
Subject: [Koha-bugs] [Bug 16592] New: Use Bootstrap modal for MARC and Card
 preview on acquisitions receipt summary page
Message-ID: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

            Bug ID: 16592
           Summary: Use Bootstrap modal for MARC and Card preview on
                    acquisitions receipt summary page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=x
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 8290

On the acquisitions receipt summary page the "MARC" and "Card" links should
trigger a preview in a Bootstrap modal instead of a Greybox modal.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:16:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:16:48 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
	Bootstrap modals
In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8290-70-YjmM64GnUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16592


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592
[Bug 16592] Use Bootstrap modal for MARC and Card preview on acquisitions
receipt summary page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:16:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:16:56 +0000
Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card
 preview on acquisitions receipt summary page
In-Reply-To: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16592-70-idBxZTfyRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:37:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:37:27 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-KJcZJPM1Bl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51797&action=edit
Bug 16492: Test that no_set_userenv will not set userenv if not exist yet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:39:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:39:16 +0000
Subject: [Koha-bugs] [Bug 16492] Checkouts ( and possibly checkins and other
 actions ) will use the patron home branch as the logged in library
In-Reply-To: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16492-70-JFCurkP2ec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16492

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not we just set a correct userenv instead of not creating at all?
There are several places where an error could occur if not set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:48:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:48:03 +0000
Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty
 table if no overdues
In-Reply-To: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16531-70-04QEHpSJEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
With this patch, the noreport variable becomes useless.
However it seems that it's useful in case of FilterBeforeOverdueReport is set.
Please double check.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 18:57:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 16:57:51 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-jS9OMAoHcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I get 3 without the patch and 1 remains with the patch applied, is it expected?

t/db_dependent/TestBuilder.t .. 1/9 Violation of unique constraint in Branch at
t/lib/TestBuilder.pm line 201.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:09:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:09:42 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-rKPZM7CrPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51798&action=edit
Bug 16578: Same fix for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:09:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:09:55 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-WnmKoecP5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:29:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:29:25 +0000
Subject: [Koha-bugs] [Bug 16594] New: Orders by fund has wrong link to css
 and other issues
Message-ID: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

            Bug ID: 16594
           Summary: Orders by fund has wrong link to css and other issues
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: hector.hecaxmmx at gmail.com
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Orders by fund has wrong link to css and other issues

-> The example in the wiki is wrong:
<https://wiki.koha-community.org/wiki/DataTables_HowTo>

<link rel="stylesheet" type="text/css" href="[% themelang
%]/css/datatables.css" />
  [% INCLUDE 'datatables.inc' %]

-> Must be:
<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme
%]/css/datatables.css" />

NOTE: Wiki needs to be updated

-> Missing <th></th> in <tfoot> tag

-> Wrong word used "Date deceived" should be "Date received"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:31:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:31:00 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-y3J5tWBi00@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Orders by fund has wrong    |Orders by fund report has
                   |link to css and other       |wrong link to css and other
                   |issues                      |issues
         Depends on|                            |11371


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371
[Bug 11371] Add a new report : Orders by budget
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:31:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:31:00 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-An3OqkXhv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594
[Bug 16594] Orders by fund report has wrong link to css and other issues
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:43:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:43:39 +0000
Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because
 missing perl module WWW::YouTube::Download
In-Reply-To: <bug-15964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15964-70-VHrh3KHr0l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---


*** This bug has been marked as a duplicate of bug 14168 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 19:43:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 17:43:39 +0000
Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include
	youtube
In-Reply-To: <bug-14168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14168-70-7MagmCipXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #31 from Mirko Tietgen <mirko at abunchofthings.net> ---
*** Bug 15964 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:14:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:14:59 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-LZOZcTTwxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:15:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:15:03 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-1SSa6hrjGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51786|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51802&action=edit
Bug 16525: Have cancel button when adding new aq budget

At the moment you only see the cancel button on the form if editing an
existing budget. This patch adds a cancel button to the form which adds
a budget. Also changes the wording of the save button from 'Save
changes' to just 'Save' so it makes more sense when adding a new budget

To test:
1) Go to Admin -> Budgets -> New budget
2) Notice 'Save changes' button and no cancel
3) Apply patch and refresh page
4) Notice 'Save' button and 'cancel' link
5) Click 'cancel' - should be taken to Budgets administration page
6) Edit an existing budget
7) Click 'cancel' - should be taken to the funds page for that budget

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Sabine Liebmann <Liebmann at dipf.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Still an issue: If edit a budget fron aqbudgets.pl, then cancel, you get
aqbudgets.pl?budget_period_id=XX. But existed before this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:15:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:15:48 +0000
Subject: [Koha-bugs] [Bug 16465] OPAC discharge page has no title tag
In-Reply-To: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16465-70-JV9bqTfX5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16465

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:26:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:26:37 +0000
Subject: [Koha-bugs] [Bug 16507] show play media tab first
In-Reply-To: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16507-70-kXqpVRVB95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It seems weird to me to change the order of the tabs depending on the existence
of items. Would not it better to select the tab by default?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:33:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:33:40 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-whoJJ94U4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:33:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:33:44 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-aRKg6VrWvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51767|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51803&action=edit
Bug 16532: Groups showing empty tables if no groups defined

EDIT: Same change for libraries

To test:
1) Go to Admin -> Libraries and Groups
2) Notice empty tables if nothing defined
3) Apply patch and refresh page
4) Empty tables should not show
5) Add a new group
6) Confirm table shows correctly

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:33:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:33:56 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-LuQqaKytBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:41:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:41:05 +0000
Subject: [Koha-bugs] [Bug 16323] Make dropdowns in header open on hover
In-Reply-To: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16323-70-wkKmEC7Rdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16323

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha,
I think these 2 links are good candidates for using an id (instead of a class).
We could have elements with a class named "more" or "branch", the selector is
not enough specific. (Note that I have not found any in current code)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed May 25 21:47:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 19:47:12 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-dnVK5xyPU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 00:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 22:19:03 +0000
Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays
In-Reply-To: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15333-70-X2UHe9N20W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #8 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 00:51:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 22:51:34 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-1TRdqCO8Xd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #38 from Joy Nelson <joy at bywatersolutions.com> ---
I appreciate the discussion on this issue to standardize the naming.  Is this
ticket now about renaming all timestamps or still adding a timestamp on the
borrower table?  Do we need to split this ticket into two issues?

Having a date (of any name) in the borrowers table will be game changing for
those of us who troubleshoot patron data day in and day out.   I'd love to see
this move forward with a resolution.

I vote for created_on/updated_on as a good path unless the majority wants
timestamp. Then I vote for timestamp.   I just want the field added.  :-)

I will be at the Hackfest in Greece and happy to help write a patch,
test...whatever it takes to get this in!

Cheers,
Joy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 01:52:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 May 2016 23:52:09 +0000
Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client
In-Reply-To: <bug-11606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11606-70-nHqYX96ebk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |nick at bywatersolutions.com
                 CC|                            |nick at bywatersolutions.com

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Work to be done:
1) Add new system preferences:
a) NovelistSelectStaffEnabled
b) NovelistSelectStaffProfile
c) NovelistSelectStaffPassword
2) Modify catalogue/detail.pl ( when NovelistSelectStaffEnabled is enabled ) to
a) Include https://imageserver.ebscohost.com/novelistselect/ns2init.js
b) Create a new tab titled "Novelist Select" in the list of tabs
c) Populate the div connected to this tab with the html needed for ns2init.js
to function correctly
d) Call novSelect.loadContentForQuery using the jQuery method $().ready to
trigger the call as soon as that part of the DOM is loaded.
3) Update the Koha OPAC code to use loadContentForQuery rather than the
deprecated loadContentForISBN

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 02:02:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 00:02:08 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-L6Xi57mwEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51545|0                           |1
        is obsolete|                            |

--- Comment #7 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51804&action=edit
[SIGNED-OFF] Bug 16502: Add additional test to Plugins.t

In order to verify if the delete now really works, we add one test
in Plugins.t.

Test plan:
[1] Run the test.
[2] Bonus: Comment line 63 in Plugins.t where delete is called.
    Run the test again. It should fail now.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 02:02:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 00:02:25 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-3juw6GmsKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51713|0                           |1
        is obsolete|                            |

--- Comment #8 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51805&action=edit
[SIGNED-OFF] Bug 16502: Adjust test for GetPlugins

The current test assumes that GetPlugins will return the test plugin
as the first one in the array. This is not correct.
This patch adjusts the test to a grep.

Test plan:
Run the test.
Bonus: Add additional plugins. Run the test again.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 02:03:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 00:03:52 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-pLTLGpSb2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 02:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 00:03:55 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-X6HLStefCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51714|0                           |1
        is obsolete|                            |

--- Comment #9 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51806&action=edit
[SIGNED-OFF] Bug 16502: Replace a few other ok-calls by is-calls

Trivial changes that speak for themselves..

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 03:05:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 01:05:39 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-fUc9ThjHUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #39 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Joy Nelson from comment #38)
> I appreciate the discussion on this issue to standardize the naming.  Is
> this ticket now about renaming all timestamps or still adding a timestamp on
> the borrower table?  Do we need to split this ticket into two issues?

Yes, it can be split into two issues. The current two patches should be
standardized to created_on instead of timestamp with a third patch.


> I will be at the Hackfest in Greece and happy to help write a patch,
> test...whatever it takes to get this in!

Give me a bit... I'll add a third commit to meet standard.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 03:58:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 01:58:21 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-PKCOhf2PcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #40 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51807&action=edit
Bug 10459 renamed timestamp to updated_on

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:02:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:02:52 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-kJtdNwJ8kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50480|0                           |1
        is obsolete|                            |

--- Comment #41 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51808&action=edit
Bug 10459: Borrowers should have a timestamp

This patch adds a timestamp column to the borrowers table in kohastructure
and updatedatabase. (And also to the deletedborrowers table.)
A timestamp may be useful in synchronizing with external systems (among other
reasons).

Test plan:
Run updatestructure on an existing database, or install a new one.
Verify that the borrowers table has a timestamp now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested updatestructure and running kohastructure.sql.
Passed t/db_dependent/Members.t.

updatedatabase.pl did not apply. I edited and then run it. Columns were added
as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:02:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:02:59 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-kjj05xs5KW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50481|0                           |1
        is obsolete|                            |

--- Comment #42 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51809&action=edit
Bug 10459: Follow up to update to atomic update methodology

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
New column created, no errors.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:03:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:03:05 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-FGjtSP9y0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51807|0                           |1
        is obsolete|                            |

--- Comment #43 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51810&action=edit
Bug 10459 renamed timestamp to updated_on

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:03:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:03:50 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-Y19YwCfKhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #44 from M. Tompsett <mtompset at hotmail.com> ---
Okay, Joy, go sign off crazy. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:19:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:19:17 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-Kvm9vI8pS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #7)
> If you write a patch, I write regression tests for it :-)

There's a patch. Where are the regression tests, Tom?s? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:32:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:32:09 +0000
Subject: [Koha-bugs] [Bug 16565] additional_fields and
 additional_field_values are not dropped in kohastructure.sql
In-Reply-To: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16565-70-qvMKQUxOC1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:32:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:32:11 +0000
Subject: [Koha-bugs] [Bug 16565] additional_fields and
 additional_field_values are not dropped in kohastructure.sql
In-Reply-To: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16565-70-CynequDzIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51717|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51811&action=edit
Bug 16565: Drop additional_fields and additional_field_values before creating
them

These 2 tables should be dropped before trying to create them

Test plan:
>From the SQL CLI, source the kohastructure.sql file
source it again
=> Without this patch you get 2 warnings
ERROR 1050 (42S01) at line 3580 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_fields' already exi
sts
ERROR 1050 (42S01) at line 3596 in file:
'installer/data/mysql/kohastructure.sql': Table
'additional_field_values' alrea
dy exists

=> With this patch, you won't get them

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:42:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:42:55 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-IB94XbLuN6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45899|0                           |1
        is obsolete|                            |

--- Comment #18 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 51812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51812&action=edit
Bug 14407 - rebased to latest git

Realised that this had bitrotted a bit. New patch that applies to the latest
git

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 04:43:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 02:43:08 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-88SGyCMGzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 07:10:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 05:10:57 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-xNLLXDgff4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51812|0                           |1
        is obsolete|                            |

--- Comment #19 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 51813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51813&action=edit
New patch, with silly typo fixed


Test plan:
0) Back up your databse
1) Apply this patch
2) In your mysql client use your Koha database and execute:
    > DELETE FROM systempreferences;
    > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
    -- Should be no errors.
    > SELECT * FROM systempreferences WHERE
variable='SelfCheckAllowByIPRanges';
    -- Should see 1 entry
    > QUIT;
3) Restore your database
4) Run installer/data/mysql/atomicupdate/selfcheckallowbyiprange.sql
5) In your mysql client, using your Koha database, execute:
    > SELECT * FROM systempreferences WHERE
variable='SelfCheckAllowByIPRanges';
    -- should see the same entry as above
6) Try access the Self-checkout, self-checkout help, and self-checkout patron
images. It should work.
7) Log into the staff client
8) Home -> Koha administration -> Global system preferences
9) -> CIRCULATION
        Make sure that SelfCheckAllowByIPRanges is set to a computer you can
test on
10) Try access the Self-checkout, self-checkout help, and self-checkout patron
images from a computer with an IP in the range above. It should work.
11) Try access the Self-checkout, self-checkout help, and self-checkout patron
images from a computer with an IP outside of the range above. It should *not*
work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 08:06:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 06:06:27 +0000
Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password
	comparison
In-Reply-To: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6979-70-594TqoMyGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
In general,  my feeling more and more is that we should be looking to deprecate
password comparison forms of ldap in the long term and we should plan for this. 

I'd like to see a bug adding warnings and possibly reports to the community hea
app for the various ldap configuration combinations.

I fear those users who ate using password comparisons still may not be aware of
the intrinsic security concerns with such an approach. We should encourage a
move forward to more secure methods.

Having said all this, we 'could' retain the password comparison and hash before
compare at our end.. But this would entail either some complex configuration to
add various hashing algorithms or some ldap queries to ascertain the
configuration to use. Along with this, extracting the salt for more complex
hashing methods would need work too.

There are pretty good cpan modules for this.. So it's all possible.. 

My two pence

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 08:40:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 06:40:58 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-F5Z0LnmCni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks Srdjan for signing off.
I notice that the first patch did not get your signoff line.
Was that intentional or just forgotten?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 10:27:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 08:27:33 +0000
Subject: [Koha-bugs] [Bug 16595] New: Concurrent search between ISBN-10 and
 ISBN-13 in staff client and OPAC
Message-ID: <bug-16595-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16595

            Bug ID: 16595
           Summary: Concurrent search between ISBN-10 and ISBN-13 in staff
                    client and OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: imingchan at yahoo.com.au
        QA Contact: testopia at bugs.koha-community.org

Ability to concurrent search between ISBN-10 and ISBN-13.  This will eliminate
the need to conduct separate searches between ISBN-10 and ISBN-13.

When a catalogue record only has ISBN-10, it can be found using an ISBN-13
search.  On the other hand, a catalogue record only has ISBN-13 can be found
using an ISBN-10 search.

For example: ISBN 174336704X stored in the catalogue record can be found by
using ISBN search of 9781743367049, or vice versa.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 10:30:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 08:30:34 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Can not upload csv file
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-mebwJTx3GU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
(In reply to Owen Leonard from comment #1)
> I've tried my own CSV file and those on Bug 15684 and I get no errors.

I think the issue is related to the fact that on my computer .csv files are
associated with LibreOffice (Calc): application/vnd.sun.xml.calc

See koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt line 241:

if (!fileType.match(/comma-separated-values|csv|excel/i)) {
    alert(_("Uploads limited to csv. Incorrect filetype:
%s").format(fileType));

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:36:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:36:28 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-ucygzjfNWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Cook from comment #9)
> Using a floating zone allows us to use the same day, month, year
> for comparison purposes without running into the possibility of
> creating an invalid local time and thus a fatal software error.

Ok you will remove the software error, but I am not sure it's the way to go.

Currently the dates are stored in local time (so with the tz), if we want to
switch to floating time zones (what we should do at some point!) I think we
should recalculate all dates present in DB.
An easy workaround would be to use Koha::DateUtils, which deals (at least try
to) with invalid dates due du DST.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:36:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:36:45 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-nnmBjQGd6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.20                        |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:39:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:39:12 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-ejaNBFAHjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Moreover `grep time_zone Koha/Calendar.pm` will return another occurrence where
the fix should be applied too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:51:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:51:56 +0000
Subject: [Koha-bugs] [Bug 16596] New: branchcode and categorycode are
 displayed instead of their description on patron search result
Message-ID: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

            Bug ID: 16596
           Summary: branchcode and categorycode are displayed instead of
                    their description on patron search result
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:52:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:52:16 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-866Xmj4UnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:52:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:52:18 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-ocLB8tQNAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51720|0                           |1
        is obsolete|                            |

--- Comment #2 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 51816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51816&action=edit
Bug 16569 - Message box for "too many checked out" is empty if
AllowTooManyOverride is not enabled

If the limit for number of items checked out is reached, the message box
shows up but is empty.

Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
   of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:52:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:52:47 +0000
Subject: [Koha-bugs] [Bug 16336] UX of holds patron search with long lists
	of results
In-Reply-To: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16336-70-cNX9chTqHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16596

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #6)
> (In reply to Jonathan Druart from comment #5)
> 
> > I am wondering why branchcode and categorycode are displayed, instead of
> > their description, on these 2 tables. Any valid reasons?
> 
> It is probably simply a remnant of the old version which displayed the list
> in a <select> and required a more compact display.

A patch is going to be submitted on bug 16336.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596
[Bug 16596] branchcode and categorycode are displayed instead of their
description on patron search result
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:52:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:52:47 +0000
Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed
 instead of their description on patron search result
In-Reply-To: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16596-70-S9XybcHkW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336
[Bug 16336] UX of holds patron search with long lists of results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:57:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:57:00 +0000
Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed
 instead of their description on patron search result
In-Reply-To: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16596-70-KuAFYk90CS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 11:57:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 09:57:04 +0000
Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed
 instead of their description on patron search result
In-Reply-To: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16596-70-pGnWGaqg9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51817&action=edit
Bug 16596: Display library and patron category descriptions instead of their
code

Test plan:
On circ/circulation-home.pl and reserve/request.pl, search for patrons
The descriptions for the libraries and patron categories should be
displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 12:13:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 10:13:28 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-JvJVj3ad7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 12:13:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 10:13:31 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-XMgKKBuBVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51816|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51821&action=edit
Bug 16569 - Message box for "too many checked out" is empty if
AllowTooManyOverride is not enabled

If the limit for number of items checked out is reached, the message box
shows up but is empty.

Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
   of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 12:43:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 10:43:04 +0000
Subject: [Koha-bugs] [Bug 16564] New Patron Category cannot be created.
 Bounces with error: 'The Category might already exist'.
In-Reply-To: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16564-70-lnTcTa3Gbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16564

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Cannot recreate on master and 3.22.06 (I do not have MySql 5.7)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 12:58:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 10:58:12 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-vTg0NUthJ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16593

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 13:34:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 11:34:01 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-plWMqbNIra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51651|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51829&action=edit
Bug 16548 - All libraries selected on Tools -> Export Data screen

This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.

Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.

To test, apply the patch and go to Tools -> Export data.

- Test the select all/select none links and confirm that they work as
  expected.
- Confirm that the structural changes to the form look okay.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Post sign-off revision: Use the standard "Clear all" instead of "Select
none."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 13:55:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 11:55:23 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-x5D8L3HXX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 13:55:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 11:55:26 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-wnx6fSDt1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51829|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51830&action=edit
Bug 16548 - All libraries selected on Tools -> Export Data screen

This patch adds "select all" and "select none" links to the display of
libraries in the export bibliographic records form.

Also modified: call number range and accession date fields have been
grouped in their own fieldsets in the hopes that this is more readable.
Page title and breadcrumbs have been corrected to read "Export data"
instead of "MARC export," matching menu items.

To test, apply the patch and go to Tools -> Export data.

- Test the select all/select none links and confirm that they work as
  expected.
- Confirm that the structural changes to the form look okay.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Post sign-off revision: Use the standard "Clear all" instead of "Select
none."

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:13:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:13:39 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-sgK7uTHmW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:13:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:13:41 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-dmlAFkWtPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49084|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:13:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:13:44 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-mEsAsNg1zm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49086|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:13:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:13:43 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-6g3iqt3NcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49085|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:24:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:24:54 +0000
Subject: [Koha-bugs] [Bug 16590] error log recording
In-Reply-To: <bug-16590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16590-70-RsBb3qLxf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
           Severity|critical                    |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Maria, this error is raised when the Zebra index is not up-to-date, try to
reindex your records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:27:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:27:29 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-7bOWIYkcSq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51832&action=edit
Koha Plugin: Rijks_HoldNoteRequired_Extent and _Leader

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:32:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:32:17 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-TKs7vTUErr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51833&action=edit
Bug 15545: Add routine IsHoldNoteRequired to Reserves module

This routine will be used to determine if a hold note is required.
In the current approach this is implemented by use of Koha plugins.
A former approach included a syspref. This is no longer needed. This
approach is even more flexible.

The routine will use all plugins it finds with metadata tag
'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a
check method that returns true, the hold note should be regarded as
required.

The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an
implementation where the value of the leader or MARC21 300$a determines
if the hold note is required. Similarly, any other field of the
bibliographic record could be used in a new plugin.

Test plan:
Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 14:32:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 12:32:21 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-q1V1Jbjy4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51834&action=edit
Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl

This patch implements use of the new Reserves routine IsHoldNoteRequired,
making it possible to require a note when placing a hold.
Only a very small change in opac-reserve.pl is needed. As well as
corresponding changes in the template. I am removing some unused template
code related to a former approach.

Test plan:
[1] Disable UseKohaPlugins, enable OpacHoldNotes.
[2] Place a hold on a serial record (leader pos 7 == s). Verify that
    the hold note is not required.
[3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins.
    (Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz.
    This file can be found as an attachment to this BZ report.)
[4] Again place a hold on a serial record. The hold note should be required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:04:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:04:05 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold (via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-F3oqYWSZPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Optionally require notes    |Optionally make hold notes
                   |when placing a hold         |required when placing a
                   |                            |hold (via Koha::Plugin)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:04:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:04:26 +0000
Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when
 placing a hold (via Koha::Plugin)
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-QDyxb1L9yb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:15:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:15:49 +0000
Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card
 preview on acquisitions receipt summary page
In-Reply-To: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16592-70-BUe3CLpnAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:15:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:15:52 +0000
Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card
 preview on acquisitions receipt summary page
In-Reply-To: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16592-70-60DCltvwuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51835&action=edit
Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions
receipt summary page

This patch replaces Greybox modals on the acquisitions receipt summary
page with Bootstrap modals.

To test, apply the patch and go to Acquisitions -> Invoices -> View an
invoice ->  Go to receipt page.

- In the list of pending orders, test the "MARC" and "Card" links for
  various titles. Each should trigger a Bootstrap modal with the correct
  content.
- Repeat the same tests in the list of already received orders.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:18:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:18:20 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-pISKFzce5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> ---
Created attachment 51836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51836&action=edit
Update Italian installer sample files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:18:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:18:47 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-xbQKTG0tOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

--- Comment #3 from Zeno Tajoli <z.tajoli at cineca.it> ---
Created attachment 51837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51837&action=edit
Followup of the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:19:03 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-92vBHumB4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:19:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:19:51 +0000
Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for
	16.05
In-Reply-To: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16585-70-hOKIzxEt8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|With this patch all         |With this patch all
      release notes|sample/defintions .sql      |sample/defintions .sql
                   |files are translated into   |files are translated into
                   |Italina (if you select      |Italian (if you select
                   |italian during web          |italian during web
                   |installation).              |installation).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:32:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:32:40 +0000
Subject: [Koha-bugs] [Bug 16600] New: Remove some obsolete references to
 Greybox in some templates
Message-ID: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

            Bug ID: 16600
           Summary: Remove some obsolete references to Greybox in some
                    templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

In identifying what templates still use Greybox for Bug 8290 I found two
templates which contain obsolete references to Greybox code:

authorities/merge.tt
cataloguing/z3950_auth_search.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:34:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:34:00 +0000
Subject: [Koha-bugs] [Bug 16601] New: Update MARC21 it-IT frameworks to
 Update 22 (April 2016)
Message-ID: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

            Bug ID: 16601
           Summary: Update MARC21 it-IT frameworks to Update 22 (April
                    2016)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: z.tajoli at cineca.it
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

The updte of marc21 .sql files based on
http://translate.koha-community.org/files/it/mandatory/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:34:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:34:25 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-qKymymlmXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Small patch
           Assignee|koha-bugs at lists.koha-commun |z.tajoli at cineca.it
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:34:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:34:55 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-txrDsWghCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:41:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:41:48 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-WsFBEZnmkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
Created attachment 51838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51838&action=edit
Update Italian MARC21

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:42:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:42:05 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-sLyWiOdtHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:43:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:43:06 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-pYkXoE207I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

--- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> ---
To test:
1) Start with a fresh database
2) Check mandatory bibliographic and authority files
   load without problem using the German web installer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:46:53 +0000
Subject: [Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox
 in some templates
In-Reply-To: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16600-70-6OZ1yO7UAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:46:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:46:56 +0000
Subject: [Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox
 in some templates
In-Reply-To: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16600-70-OJCTyw7yi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51839&action=edit
Bug 16600 - Remove some obsolete references to Greybox in some templates

This patch removes unused Greybox markup from two templates.

To test, apply the patch and go to Authorities.

- Perform an authority search which will return multiple results.
- Select two records to merge.
- On the "merging records" page, an earlier version used Greybox to show
  a preview of the selected authority records. Confirm that authority
  number link for the two records triggers a pop-up window instead.

- From the authorities home page, choose 'New from Z39.50'
- Perform a search which will return multiple results.
- Confirm that there is only a 'MARC' preview link. A
  forever-commented-out 'Card' link has been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:47:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:47:17 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
	Bootstrap modals
In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8290-70-d7KTReJINl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600
[Bug 16600] Remove some obsolete references to Greybox in some templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:47:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:47:17 +0000
Subject: [Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox
 in some templates
In-Reply-To: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16600-70-g7ocxvB23T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8290


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 15:51:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 13:51:07 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
	Bootstrap modals
In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8290-70-WnZL6mB7y6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
The simplest Greybox uses have been taken care of. The remaining cases will all
require more complex AJAX handling because of the kind of in-modal operations
used:

Localization:

admin/itemtypes.tt
admin/localization.tt

Label and card export:

labels/label-edit-batch.tt
labels/label-manage.tt
patron_lists/lists.tt
patroncards/edit-batch.tt
patroncards/manage.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:18:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:18:37 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-Fj65wibRTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51840&action=edit
Bug 16554: DO NOT PUSH - test for all sample files

You will need to create a koha_test_installer DB before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:20:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:20:42 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-9wVruZuK0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #12)
> Created attachment 51840 [details] [review]
> Bug 16554: DO NOT PUSH - test for all sample files
> 
> You will need to create a koha_test_installer DB before

I did not finish the execution of this script but it should permit to test all
sample files without inserting it manually.
Could someone test it on MySQL 5.7 and all patches from this bug report (and
from bug 16573 as well).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:21:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:21:04 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-uVefqdmjQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #13)
> Could someone test it on MySQL 5.7 and all patches from this bug report (and
> from bug 16573 as well).

And make sure it raises warnings/errors without!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:28:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:28:44 +0000
Subject: [Koha-bugs] [Bug 16602] New: Remove the use of "onclick" from
	several templates
Message-ID: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

            Bug ID: 16602
           Summary: Remove the use of "onclick" from several templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I am working on a patch which will remove the use of "onclick" from the
following templates:

offline_circ/process_koc.tt
patron_lists/lists.tt
tools/batchMod-edit.tt
tools/batchMod-del.tt
tools/holidays.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:43:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:43:05 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-4s2ST0RVFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:43:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:43:08 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-GkboAoe8tS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 51841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51841&action=edit
Bug 16594: Orders by fund report has wrong link to css and other issues

Orders by fund has wrong link to css and other issues
-> The example in the wiki is wrong:
<https://wiki.koha-community.org/wiki/DataTables_HowTo>
<link rel="stylesheet" type="text/css" href="[% themelang
%]/css/datatables.css" />
  [% INCLUDE 'datatables.inc' %]
-> Must be:
<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme
%]/css/datatables.css" />
-> Missing <th></th> in <tfoot> tag
-> Wrong word used "Date deceived" should be "Date received"

NOTE: Wiki needs to be updated

To test:
-Look the code and notice about if else cluase without curly brackets
-Go to Reports > Orders by fund
-Play with: in filters 'All fund' Output: 'to screen into the browser'
-You will see a DataTable displayed in screen clutter
-Notice about 'Date deceived' and the foot of table
-Apply patch
-Refresh or execute again the report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 16:45:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 14:45:26 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-DCWbIQe5XF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |oleonard at myacpl.org,
                   |                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:01:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:01:27 +0000
Subject: [Koha-bugs] [Bug 16603] New: When processing uploaded offline
 circulation file, "apply directly" option fails
Message-ID: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

            Bug ID: 16603
           Summary: When processing uploaded offline circulation file,
                    "apply directly" option fails
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/offline_circ/process_koc.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I have an offline circulation file which was generated by the Windows offline
circulation program. If I upload this file and choose "Add to offline
circulation queue" it works as expected.

If I upload the same file and choose "Apply directly," the process never
completes. Firebug shows a seemingly never-ending series of calls to
/cgi-bin/koha/tools/background-job-progress.pl?jobID=8c20822320e5fbd7579aa1f61411ba00
but nothing happens.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:10:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:10:18 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-9N8HaBtpb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:10:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:10:21 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-X4oSVIL6o4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51808|0                           |1
        is obsolete|                            |

--- Comment #45 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 51842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51842&action=edit
Bug 10459: Borrowers should have a timestamp

This patch adds a timestamp column to the borrowers table in kohastructure
and updatedatabase. (And also to the deletedborrowers table.)
A timestamp may be useful in synchronizing with external systems (among other
reasons).

Test plan:
Run updatestructure on an existing database, or install a new one.
Verify that the borrowers table has a timestamp now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested updatestructure and running kohastructure.sql.
Passed t/db_dependent/Members.t.

updatedatabase.pl did not apply. I edited and then run it. Columns were added
as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:10:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:10:49 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-qGXmWN2vUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51809|0                           |1
        is obsolete|                            |

--- Comment #46 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 51843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51843&action=edit
Bug 10459: Follow up to update to atomic update methodology

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
New column created, no errors.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:11:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:11:03 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-1MfmTODTh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51810|0                           |1
        is obsolete|                            |

--- Comment #47 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 51844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51844&action=edit
Bug 10459 renamed timestamp to updated_on

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:12:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:12:27 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-JBqw530Leq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #48 from Joy Nelson <joy at bywatersolutions.com> ---
Signed off!  Thanks!!!
joy

(In reply to M. Tompsett from comment #44)
> Okay, Joy, go sign off crazy. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:21:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:21:01 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-NPL9998FYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51845&action=edit
Bug 16602 - Remove the use of "onclick" from several templates

This patch removes the use of "onclick" from several templates, instead
defining click events in JavaScript.

Also changed: Some markup corrections.

To test, apply the patch and:

- Go to Circulation -> Upload offline circulation file
  - Browse for an offline circulation file.
  - Clicking the 'Upload file' button should work correctly.
    - After uploading a file, both the 'Add to offline circulation
      queue' and 'Apply directly' buttons should work to trigger their
      corresponding processes (keeping Bug 16603 in mind).

- Go to Patrons -> Patron lists.
  - For any patron list containing patrons, click the 'Print patron
    cards' menu item. This should trigger a modal window which exports
    the correct list.

- Go to Tools -> Batch item modification.
  - Submit a batch of items for modification.
  - Clicking the 'Save' button should trigger the background job and the
    items should be successfully modified.

- Go to Tools -> Batch item deletion.
  - Submit a batch of items for deletion.
  - Clicking the 'Delete' button should trigger the background job and
    the items should be successfully deleted.

- Go to Tools -> Calendar.
  - Trigger the 'Add new holiday' panel by clicking a day on the
    calendar which has no holiday defined.
  - Clicking the 'Cancel' link should hide the panel.
  - Trigger the 'Edit this holiday' panel by clicking a day which has a
    holiday defined.
  - Clicking the 'Cancel' link should hide the panel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:20:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:20:59 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-n4KK1dkjqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:29:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:29:09 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-bcbQRmkbWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to H?ctor Eduardo Castro Avalos from comment #1)

> NOTE: Wiki needs to be updated

I have updated the wiki.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:33:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:33:54 +0000
Subject: [Koha-bugs] [Bug 16555] Managing patron self edits -- non
 superlibrarians can see patrons for other branches
In-Reply-To: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16555-70-OMncSdMfaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16555

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |cbrannon at cdalibrary.org
         Resolution|---                         |FIXED

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I have confirmed that this setting was the culprit.  I believe Barton submitted
this ticket on our behalf.  We did not know about the setting.  I am going to
go ahead and mark this as resolved.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:51:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:51:37 +0000
Subject: [Koha-bugs] [Bug 16604] New: Break down patron modification
 requests for approval/give reasons for denials/allow corrections
Message-ID: <bug-16604-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16604

            Bug ID: 16604
           Summary: Break down patron modification requests for
                    approval/give reasons for denials/allow corrections
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It would be helpful to have the ability to select what changes to approve, and
give reasons for denial that would show up somewhere on the patron account or
in an e-mail to the patron.  It would also be helpful if the changes were
editable if mistakes are found (misspellings, no caps, hyphenations, etc.)

I would imagine check boxes next to each line of change, and a text box next to
each line for "Reason".  The reason "could" be saved for both approvals and
denials.  However, if a reason is given, it would be appropriate to send the
reason to the patron.  Perhaps the information is incorrect.  The patron should
be notified.  The changes should also be editable.  I would imagine an edit
button next to the change, which would simply change the text from a label to a
text box, with a save and cancel button.  I don't think it would be good to
have it always editable without a button or link, in case someone accidently
changes something.

Whether or not staff provide reasons, the approval or denial should be shown to
the patron either in their account, or in an e-mail, if they have one, and show
any modifications (i.e. Approved or denied, what was on the account before,
what the patron requested, what it was actually changed to, reasons if they
exist.)

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 17:56:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 15:56:20 +0000
Subject: [Koha-bugs] [Bug 16605] New: All notices should give the ability to
 unsubscribe or flag account
Message-ID: <bug-16605-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605

            Bug ID: 16605
           Summary: All notices should give the ability to unsubscribe or
                    flag account
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

There should be a way to unsubscribe to notifications within the e-mail.  This
could be a link to the patron's notification settings, or simply turn the
switch off for that notification.

There should also be a way to indicate that the e-mail has gone to the wrong
person.  A link that says "Not my account", or something to that effect.  It
could either put a restriction on the account indicating the e-mail address has
been flagged as wrong, or just be a note on the account that it is wrong.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 18:12:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 16:12:20 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-lPIvPrkdBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #49 from M. Tompsett <mtompset at hotmail.com> ---
I went with an updated_on, as created_on is static, and the point was for
diagnosis to know when something was last done with the borrower record. And I
couldn't figure out how to get two time stamps using MySQL to auto-fill (a
created_on and an updated_on) in the same table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 18:13:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 16:13:30 +0000
Subject: [Koha-bugs] [Bug 16606] New: Checkout settings dropdown should have
 a preference to stay open all the time
Message-ID: <bug-16606-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606

            Bug ID: 16606
           Summary: Checkout settings dropdown should have a preference to
                    stay open all the time
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Not everyone is concerned with the additional space taken up with the new
Checkout settings.  It would be helpful if these options could be set to always
show.

For now I will use a jQuery to force it open, but a preference would be
preferable.  No pun intended.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 18:21:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 16:21:19 +0000
Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation
 actions are not translatable
In-Reply-To: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15676-70-3FhoDcA6bf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 18:37:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 16:37:19 +0000
Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation
 actions are not translatable
In-Reply-To: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15676-70-8UbPizQUYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 18:37:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 16:37:21 +0000
Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation
 actions are not translatable
In-Reply-To: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15676-70-dH7oWyIoqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51846&action=edit
Bug 15676 - Actions in pending offline circulation actions are not translatable

This patch modifies the offline circulation transaction processing page
so that English strings describing actions are processed in the template
rather than being output directly from the script.

To test, apply the patch and create an offline circulation file
containing at least one checkout, one check-in, and one payment.

- Upload the file and choose 'Add to offline circulation queue.'
- View pending offline circulation actions
- In the list of pending actions, the actions column should show "Check
  out" instead of "issue," "Check in" instead of "return," and "Payment"
  instead of "payment."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 18:49:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 16:49:52 +0000
Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by
	overdues process"
In-Reply-To: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12509-70-B4Gas3yAvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Would it be correct to say that the problem is not necessarily the comment in
the database but the output of that comment in the interface?

That is, the goal should be to put a check in the templates which would display
a translatable string?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 20:29:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 18:29:42 +0000
Subject: [Koha-bugs] [Bug 11375] Patron permission names are untranslatable
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-xoZHw18gHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51847&action=edit
Idea for a patron permissions interface redesign

I wonder if we should deemphasize the permission code? As a developer I look
for the code because I usually know what I'm looking for. Perhaps it would be
friendlier to put the focus on the translatable text?

(also I want to get rid of jstree)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 20:55:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 18:55:34 +0000
Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed
 instead of their description on patron search result
In-Reply-To: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16596-70-qAVsjULuF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 20:55:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 18:55:37 +0000
Subject: [Koha-bugs] [Bug 16596] branchcode and categorycode are displayed
 instead of their description on patron search result
In-Reply-To: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16596-70-9ysSFcUXuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16596

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51817|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51848&action=edit
[SIGNED-OFF] Bug 16596: Display library and patron category descriptions
instead of their code

Test plan:
On circ/circulation-home.pl and reserve/request.pl, search for patrons
The descriptions for the libraries and patron categories should be
displayed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

On top of Bug 13336
Works as described, now descriptions instead of codes.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 21:08:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 19:08:46 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-zfszrbwh0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> I get 3 without the patch and 1 remains with the patch applied, is it
> expected?
> 
> t/db_dependent/TestBuilder.t .. 1/9 Violation of unique constraint in Branch
> at t/lib/TestBuilder.pm line 201.

Thanks.

$ prove t/db_dependent/TestBuilder.t
t/db_dependent/TestBuilder.t .. ok
All tests successful.
Files=1, Tests=9,  7 wallclock secs ( 0.06 usr  0.00 sys +  6.48 cusr  0.13
csys =  6.67 CPU)
Result: PASS

I had no warnings, because I had no MPL branch. And the patch only catches the
second build on line 57. If you do have one, the warning comes from line 56.
Will send a small follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 21:43:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 19:43:13 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-slUBm5YwqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 21:43:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 19:43:16 +0000
Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt
 (separated word 'item')
In-Reply-To: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16562-70-NP213RMS8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51716|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51849&action=edit
[SIGNED-OFF] Bug 16562: Translatability: Issue in opac-user.tt (separated word
'item')

This patch fixes translatoion difficulties (syntax) with a tag-separated word
'item'

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 21:51:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 19:51:36 +0000
Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt
 (sentence splitting)
In-Reply-To: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16563-70-EbmDh6xuqB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 21:51:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 19:51:39 +0000
Subject: [Koha-bugs] [Bug 16563] Translatability: Issues in opac-account.tt
 (sentence splitting)
In-Reply-To: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16563-70-7Hd2NdaNVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51715|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51850&action=edit
[SIGNED-OFF] Bug 16563: Translatability: Issues in opac-account.tt (sentence
splitting)

This patch removes splitting by <i>-tags from 2 sentences.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:03:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:03:49 +0000
Subject: [Koha-bugs] [Bug 16607] New: Add verbose flag to builder sub in
	TestBuilder
Message-ID: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

            Bug ID: 16607
           Summary: Add verbose flag to builder sub in TestBuilder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:07:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:07:51 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-mMrrsiq4xg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51851&action=edit
Bug 16500: [QA Follow-up] Catch warning if branch MPL already exists

The current test had no warnings, when you have no MPL branch, and only
catches the warn from the second build on line 57. If you do have MPL,
a warning comes from line 56.

This patch quickly fixes it. Report 16607 will propose a general
solution.

Test plan:
Do not yet apply the patch.
Add MPL branch.
Run the test. Notice the warning about Branch.
Apply the patch.
Run the test. Warning gone?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:08:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:08:29 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-k2nkCbY3Ms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16607

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:08:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:08:29 +0000
Subject: [Koha-bugs] [Bug 16607] Add verbose flag to builder sub in
	TestBuilder
In-Reply-To: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16607-70-8HhoTmONUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16500

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:10:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:10:15 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-SXleqyolgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:10:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:10:18 +0000
Subject: [Koha-bugs] [Bug 16601] Update MARC21 it-IT frameworks to Update 22
	(April 2016)
In-Reply-To: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16601-70-PBP6To7dMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16601

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51838|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51852&action=edit
[SIGNED-OFF] Bug 16601: Update of italian MARC21 files

This is the update for April 2016 changes of Library of Congress
The basic creation of the files is done in
http://translate.koha-community.org/files/it/mandatory/

https://bugs.koha-community.org/show_bug.cgi?id=16601
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Both files load without problems.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:31:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:31:12 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-tsfh0TSyXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:33:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:33:47 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-EdsiwPDqrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Would it be reasonable to fix the RSS here and then move the atom
discussion/fix/removal to another bug report so this one can get through?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 22:53:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 20:53:35 +0000
Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon
	submission
In-Reply-To: <bug-15702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15702-70-PothcrQgF2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
+1. No reason not to

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 23:02:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 21:02:48 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-5aPdMUp5iB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #14 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Nick Clemens from comment #13)
> Would it be reasonable to fix the RSS here and then move the atom
> discussion/fix/removal to another bug report so this one can get through?

Yes!  Sounds like the Atom feed is something that should be addressed in
another bug.  I'm all for moving this along.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 23:06:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 21:06:37 +0000
Subject: [Koha-bugs] [Bug 12682] Shibboleth attribute manipulation
In-Reply-To: <bug-12682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12682-70-z6Lf2d5zwn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm afraid I never got to this one,  I had too many other outstanding
shibboleth via awaiting signoff and qa to devote time to this.

In another ago I wrote shibboleth interactions for however,  we use perl config
files.  It was very easy there to just replace the simple mapping with more
complex control statements anonymous subroutine references..  That's likely how
I would attempt to impliment such a piece these days

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 23:21:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 21:21:04 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-zvsmAePZKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #79 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I'm not finding any reference to this feature in the manual.  Is it there?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu May 26 23:46:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 21:46:40 +0000
Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance
	Improvement
In-Reply-To: <bug-15107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15107-70-WiWFLhJlIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Shame, this one seems to have lost its head of steam :-(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 01:26:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 May 2016 23:26:38 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-GGOx8hFAUz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #11 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Apologies, my mistake, did not adjust for the additional patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 02:51:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 00:51:10 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-Oq3RWFAryW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #27 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 51377
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51377
Rebase on master

Review of attachment 51377:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5670&attachment=51377)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +435,4 @@
>      );
>      if ( $in->{'type'} eq "intranet" ) {
>          $template->param(
> +            useHouseboundModule                                                        => C4::Context->preference("useHouseboundModule"),

There is no need to do this. The preferences are accessible in the template,
see other templates which grab preferences already.

::: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
@@ +105,4 @@
>      [% IF CAN_user_borrowers && useDischarge %]
>          [% IF dischargeview %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/discharge.pl?borrowernumber=[% borrowernumber %]">Discharge</a></li>
>      [% END %]
> +    [% IF Koha.Preference('HouseboundModule') %]

See, like here.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
@@ +110,5 @@
> +                          <option value="friday">Friday</option>
> +                          <option value="saturday">Saturday</option>
> +                          <option value="sunday">Sunday</option>
> +                        [% END %]
> +                      </select>

Couldn't all this select logic be simplified with a loop?

@@ +122,5 @@
> +                            <option value="[% frequency.value %]" selected="selected">[% frequency.label %]</option>
> +                          [% ELSE %]
> +                            <option value="[% frequency.value %]">[% frequency.label %]</option>
> +                          [% END %]
> +                        [% END %]

Like this.

@@ +335,5 @@
> +                    [% ELSIF hpd == 'saturday' %]
> +                      Saturday
> +                    [% ELSIF hpd == 'sunday' %]
> +                      Sunday
> +                    [% END %]

http://template-toolkit.org/docs/manual/VMethods.html#section_ucfirst

::: members/housebound.pl
@@ +82,5 @@
> +        fav_itemtypes  => $input->param('fav_itemtypes'),
> +        fav_subjects   => $input->param('fav_subjects'),
> +        fav_authors    => $input->param('fav_authors'),
> +        referral       => $input->param('referral'),
> +        notes          => $input->param('notes'),

Perhaps // q{} or something similar might be nice, just in case there's
undefined parameters.

::: t/db_dependent/Patron/Housebound.t
@@ +64,5 @@
> +foreach my $cho ( @{$found_choosers} ) {
> +    $cho_counter ++
> +        if ( $cho->borrowernumber eq $patron_chooser->{borrowernumber} );
> +};
> +is(1, 1, "Return our patron_chooser!");

What is the point of this test?

@@ +73,5 @@
> +foreach my $del ( @{$found_deliverers} ) {
> +    $del_counter ++
> +        if ( $del->borrowernumber eq $patron_deliverer->{borrowernumber} );
> +};
> +is(1,1,"Return our patron_deliverer!");

What is the point of this test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 03:14:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 01:14:32 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-ON9WCH2nRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 51290
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51290
bug 5620 - Capture Mode of payment, receipt number and notes in pay fines.

Review of attachment 51290:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5620&attachment=51290)
-----------------------------------------------------------------

::: C4/Accounts.pm
@@ +89,4 @@
>  sub recordpayment {
>  
>      #here we update the account lines
> +    my ( $borrowernumber, $data, $sip_paytype, $payment_note, $paymentmode ) = @_;

"PERL16: Hashrefs should be used as arguments"
Perhaps refactor is in order? There are already too many parameters.

::: installer/data/mysql/atomicupdate/bug5620_Add_Mode_Of_Payment.perl
@@ +10,5 @@
> +$dbh->do("alter table accountlines add column paymentmode text not null");
> +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','CASH','Cash', 'Cash')");
> +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','CC','Credit Card', 'Credit Card')");
> +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','DEBIG','Debit', 'Debit')");
> +print "bug5620 - add mode of payment";

Why not do this as a sql file?
Also, missing kohastructure.sql patch.

::: members/paycollect.pl
@@ +50,5 @@
> +my $sth = $dbh->prepare('SELECT * FROM authorised_values WHERE category = "PAYMODE"');
> +$sth->execute();
> +while ( my $row = $sth->fetchrow_hashref() ) {
> +    push @paymentmodes, $row;
> +}

This should probably be some nice function in some authorised value library
somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:19:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:19:35 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-353tKsVaMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51544|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51853&action=edit
Bug 16502: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not
always dropped after running Plugin.t

If you run Plugin.t, the above table will still be present (when you
did not enable UseKohaPlugins). This would trigger a warning when
running the test a second time.

Why? The uninstall call does its work not completely due to a small
inconsistency in Koha::Plugins::Handler::delete when calling run
without the enable_plugins parameter.

This patch resolves that inconsistency and also removes an unneeded skip
in Plugin.t in case the KitchenSink module already exists.
Note: This is a small fix. But I wonder if the Handler routines run and
delete should not have been implemented in Koha::Plugins::Base.
Also note that plugins/plugins-uninstall.pl will not be affacted by this
change, since it checks whether the pref is enabled before calling the
delete method.

Test plan:
[1] Do not yet install this patch.
[2] Verify that plugins are enabled in koha-conf.xml.
[3] Disable UseKohaPlugins in System Preferences!
[4] Run t/db_dependent/Plugins.t.
[5] Verify that table koha_plugin_com_bywatersolutions_kitchensink_mytable
    still exists. (It should have been deleted.) Remove it manually.
[6] Apply this patch.
[7] Run the test again.
[8] Verify that the table does not exist.
[9] Run the test again (without warnings).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:19:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:19:39 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-LDK3nO7zQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51854&action=edit
Bug 16502: Add additional test to Plugins.t

In order to verify if the delete now really works, we add one test
in Plugins.t.

Test plan:
[1] Run the test.
[2] Bonus: Comment line 63 in Plugins.t where delete is called.
    Run the test again. It should fail now.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:19:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:19:42 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-TTzIpi66bu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51855&action=edit
Bug 16502: Adjust test for GetPlugins

The current test assumes that GetPlugins will return the test plugin
as the first one in the array. This is not correct.
This patch adjusts the test to a grep.

Test plan:
Run the test.
Bonus: Add additional plugins. Run the test again.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:19:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:19:46 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-LQWO7s42X3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51856&action=edit
Bug 16502: Replace a few other ok-calls by is-calls

Trivial changes that speak for themselves..

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:20:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:20:20 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-3rUXrTEfEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:20:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:20:22 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-p7eV35OzMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51804|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:20:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:20:24 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-cgr39PJpr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51805|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:20:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:20:26 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-mYhSrPyq5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51806|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:21:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:21:25 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-Vj2H7755Ft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Srdjan Jankovic from comment #11)
> Apologies, my mistake, did not adjust for the additional patch.

OK I added your signoff line. Thx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 08:31:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 06:31:41 +0000
Subject: [Koha-bugs] [Bug 16502] Table
 koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped
 after running Plugin.t
In-Reply-To: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16502-70-udI2vRiVZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #17 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I meant to do it sometimes today, after settling current affairs. But this is
ok too. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 09:15:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 07:15:11 +0000
Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder
In-Reply-To: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16607-70-UBaqum8uay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add verbose flag to builder |Add quiet flag to builder
                   |sub in TestBuilder          |sub in TestBuilder
             Status|NEW                         |ASSIGNED
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 09:15:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 07:15:45 +0000
Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder
In-Reply-To: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16607-70-2ZgIHNJiof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16500


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500
[Bug 16500] Catch two warns in TestBuilder.t with warning_like
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 09:15:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 07:15:45 +0000
Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with
	warning_like
In-Reply-To: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16500-70-g16WwkkGY7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607
[Bug 16607] Add quiet flag to builder sub in TestBuilder
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 09:16:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 07:16:16 +0000
Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder
In-Reply-To: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16607-70-tzjIoRdqdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 09:16:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 07:16:19 +0000
Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder
In-Reply-To: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16607-70-bGfdYHlwYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51857&action=edit
Bug 16607: Add quiet flag to builder sub in TestBuilder

If you know what you are doing, you sometimes do not like to see the
warnings raised by TestBuilder.
This patch allows you to add a quiet flag to an individual build call.

Test plan:
[1] Add a CPL and a MPL branch (if not present).
[2] Run t/db_dependent/TestBuilder.t.
    You should see no difference. The fix from bug 16500 (suppressing the
    warn already) has been replaced by using the quiet flag.
[3] Run t/db_dependent/Accounts.t too.
    Before this patch, an existing MPL branch also raised a warn.
[4] Run t/db_dependent/Items/AutomaticItemModificationByAge.t too.
    This test included a check for the existence of a CPL branch.
    The check has been removed. You should see no warning.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:03:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:03:05 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-JlXPVdTqCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #28 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Hello,

Thank you for the review.  A few comments and questions from my side, but will
be implementing the rest of your suggestions.

> ::: C4/Auth.pm
> @@ +435,4 @@
>>      );
>>      if ( $in->{'type'} eq "intranet" ) {
>>          $template->param(
>> +            useHouseboundModule                                                        => C4::Context->preference("useHouseboundModule"),

> There is no need to do this. The preferences are accessible in the template, see other templates which grab preferences already.

Good point, will remove this.

> ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
> @@ +110,5 @@
>> +                          <option value="friday">Friday</option>
>> +                          <option value="saturday">Saturday</option>
>> +                          <option value="sunday">Sunday</option>
>> +                        [% END %]
>> +                      </select>

> Couldn't all this select logic be simplified with a loop?

I'd be worried about translation ? I'm not 100% sure how it works, but
aren't simple strings in the UI the way to go for translation?

> @@ +122,5 @@
>> +                            <option value="[% frequency.value %]" selected="selected">[% frequency.label %]</option>
>> +                          [% ELSE %]
>> +                            <option value="[% frequency.value %]">[% frequency.label %]</option>
>> +                          [% END %]
>> +                        [% END %]

> Like this.
I'm not concerned about translation here, as Frequencies are directly
editables as authorized values by end users.

> @@ +335,5 @@
>> +                    [% ELSIF hpd == 'saturday' %]
>> +                      Saturday
>> +                    [% ELSIF hpd == 'sunday' %]
>> +                      Sunday
>> +                    [% END %]

> http://template-toolkit.org/docs/manual/VMethods.html#section_ucfirst

Again, I would have concerns about translation here ? but if this is not
a concern for translation, then I'd be happy to implement that.

> ::: members/housebound.pl
> @@ +82,5 @@
>> +        fav_itemtypes  => $input->param('fav_itemtypes'),
>> +        fav_subjects   => $input->param('fav_subjects'),
>> +        fav_authors    => $input->param('fav_authors'),
>> +        referral       => $input->param('referral'),
>> +        notes          => $input->param('notes'),

> Perhaps // q{} or something similar might be nice, just in case there's undefined parameters.

Fair point, will implement :-)

> ::: t/db_dependent/Patron/Housebound.t
> @@ +64,5 @@
>> +foreach my $cho ( @{$found_choosers} ) {
>> +    $cho_counter ++
>> +        if ( $cho->borrowernumber eq $patron_chooser->{borrowernumber} );
>> +};
>> +is(1, 1, "Return our patron_chooser!");

> What is the point of this test?

This is testing that the Extended Borrower Atrributes work as expected
in this context:
- that our `housebound_choosers` method works as expected
- that we, in this controlled environment, only return one chooser
  patron
- and that chooser is the one that we expect it to be.

> @@ +73,5 @@
>> +foreach my $del ( @{$found_deliverers} ) {
>> +    $del_counter ++
>> +        if ( $del->borrowernumber eq $patron_deliverer->{borrowernumber} );
>> +};
>> +is(1,1,"Return our patron_deliverer!");

> What is the point of this test?

Same as above, but for deliverers.

WDYT?

Alex

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:33:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:33:55 +0000
Subject: [Koha-bugs] [Bug 16608] New: Missing entity nbsp in some XML files
Message-ID: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

            Bug ID: 16608
           Summary: Missing entity nbsp in some XML files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

The special character "non breaking space" &nbsp; is not contained in XML
syntax by default.
So we add it in the file header : 
<!DOCTYPE stylesheet [<!ENTITY nbsp "&#160;" >]>

Even if the source code files do no contain this character, it can be that
translated files contain it.
French for example "Titre&nbsp;:".

This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/
and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:34:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:34:22 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-7g1rTg8Haf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:40:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:40:51 +0000
Subject: [Koha-bugs] [Bug 7141] The biblio details page in the intranet
 doesn't work if XSLT is activated and the xsl file contains "&nbsp; "
In-Reply-To: <bug-7141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7141-70-ff2C5PXD3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608
[Bug 16608] Missing entity nbsp in some XML files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:40:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:40:51 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-zhPGT0ng2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7141
             Status|NEW                         |ASSIGNED

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Same issue as Bug 7141


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141
[Bug 7141] The biblio details page in the intranet doesn't work if XSLT is
activated and the xsl file contains "&nbsp;"
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:57:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:57:27 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-LXZEO7P4Yg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:57:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:57:29 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-jstvjd1Eoq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 51862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51862&action=edit
Bug 16608 - Add xsld extension to t/00-valid-xml.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:58:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:58:44 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-pqKkeYIdBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 51863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51863&action=edit
Bug 16608 - Add xsd extension to t/00-valid-xml.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 10:59:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 08:59:11 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-q2b4PX6VBy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 51864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51864&action=edit
Bug 16608 - Missing entity nbsp in some XML files

The special character "non breaking space" &nbsp; is not contained in XML
syntax by default.
So we add it in the file header :
<!DOCTYPE stylesheet [<!ENTITY nbsp "&#160;" >]>

Even if the source code files do no contain this character, it can be that
translated files contain it.
French for example "Titre&nbsp;:".

This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/
and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt.

Test plan :
  - generate French templates:
    cd misc/translator
    ./translate install fr-FR
    cd ../..
  - run test:
    prove -v t/00-valid-xml.t
    you get failing error message
  - apply this patch
  - translate again
  - run test again: it passes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 11:04:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 09:04:30 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-0IS004LvzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51862|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 11:18:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 09:18:27 +0000
Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo"
 should be removed
In-Reply-To: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16104-70-ve25LnFuJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
If you compile (perl -cw) a script or module now that contains a use
C4::Context, you have the following warnings:

Name "Tie::Hash::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at
/usr/share/perl/5.22/fields.pm line 135.
Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo 
at /usr/share/perl/5.22/fields.pm line 135.

[ PS koha-qa does the same. ]

Are these warnings somehow related to perl's Cache module containing things
like below?

use base qw(Tie::Hash);

my $strategy = $args->{removal_strategy} || 'Cache::RemovalStrategy::LRU';

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 11:59:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 09:59:01 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-9eN1HCzVkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51843|0                           |1
        is obsolete|                            |

--- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51867&action=edit
Bug 10459: Follow up to update to atomic update methodology

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
New column created, no errors.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 11:59:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 09:59:06 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-9jVGbsORVQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51844|0                           |1
        is obsolete|                            |

--- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51868&action=edit
Bug 10459 renamed timestamp to updated_on

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 12:07:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 10:07:11 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-Ss0Dawl27P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #52 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #49)
> I went with an updated_on, as created_on is static, and the point was for
> diagnosis to know when something was last done with the borrower record. And
> I couldn't figure out how to get two time stamps using MySQL to auto-fill (a
> created_on and an updated_on) in the same table.

What about filling created_on once in AddMember ?
Mysql accepts: 
  `stamp1` timestamp NULL DEFAULT NULL,
  `stamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
CURRENT_TIMESTAMP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 12:51:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 10:51:09 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-IQK77UrCNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
And another question:
We may expect some libraries to have inserted a custom timestamp column already
in the borrowers table. They will run into the same problem as Mark described
above here. Would it make sense to check in the database revision if that is
the case and skip the dbrev with a warning? (They could rename the field
manually?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 13:20:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 11:20:42 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-rwM0tMjclE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #54 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Marcel de Rooy from comment #52)
> What about filling created_on once in AddMember ?
> Mysql accepts: 
>   `stamp1` timestamp NULL DEFAULT NULL,
>   `stamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
> CURRENT_TIMESTAMP

Which MySQL version?
For example this two columns in virtualshelves give problems on 5.7:

  `lastmodified` timestamp NOT NULL default CURRENT_TIMESTAMP on update
CURRENT_TIMESTAMP, -- date and time the list was last modified
  `created_on` TIMESTAMP NOT NULL, -- creation time

loading kohastructure fails with 
line:  2212   `created_on` TIMESTAMP NOT NULL, -- creation time
error: (Invalid default value for 'created_on'): CREATE TABLE `virtualshelves`

It seems that we will find some problems because of the new version default
sql_mode. It's something that we need to address. 

ATM neither 16.05 nor 3.22 run on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 13:58:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 11:58:32 +0000
Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons
 in patron attribute types administration
In-Reply-To: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16543-70-1TfxLuqFIH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Jan Kissig <jan.kissig at th-wildau.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51789|0                           |1
        is obsolete|                            |

--- Comment #2 from Jan Kissig <jan.kissig at th-wildau.de> ---
Created attachment 51872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51872&action=edit
Bug 16543 - Make edit and delete links styled buttons in patron attribute types
administration

This patch modifies the Patron attribute types page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.

To test, apply the patch and go to Administration -> Patron attribute
types. The 'Edit' and 'Delete' buttons should look correct and work
correctly.

Signed-off-by: Jan Kissig <jkissig at th-wildau.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 13:59:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 11:59:25 +0000
Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons
 in patron attribute types administration
In-Reply-To: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16543-70-B4SjQ7dbQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Jan Kissig <jan.kissig at th-wildau.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |jan.kissig at th-wildau.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 13:59:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 11:59:25 +0000
Subject: [Koha-bugs] [Bug 16607] Add quiet flag to builder sub in TestBuilder
In-Reply-To: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16607-70-R4mykPfrM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51873&action=edit
Bug 16607: Follow-up for Holds.t

This test adds a patron category and should raise no warning if it
already exists.
The new quiet parameter is your friend.

Test plan:
Add patron category S.
Run t/db_dependent/Holds.t and see no warnings.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:07:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:07:11 +0000
Subject: [Koha-bugs] [Bug 16609] New: Catch warning from Koha::Hold in Hold.t
Message-ID: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

            Bug ID: 16609
           Summary: Catch warning from Koha::Hold in Hold.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:08:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:08:44 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-5Wf9M2AnrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:08:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:08:47 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-9ksMLm3tVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51874&action=edit
Bug 16609: Catch warning from Koha::Hold in Hold.t

Before this patch, the suspend step triggers a warn from Koha::Hold.
Now we catch it.

Test plan:
Run the test. Do not see the warning about unable to suspend.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:09:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:09:36 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-SpGnqBiMRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:10:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:10:22 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-n97Ow1akRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #29 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 51875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51875&action=edit
Housebound Schema Updates

Apply this patch to no longer have to manually regenerate the Schema files.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:15:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:15:56 +0000
Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug
	10480)
In-Reply-To: <bug-16203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16203-70-jrmTR8uBJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49913|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:35:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:35:43 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-SDe5rPAIQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:36:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:36:23 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-5oCv4sbhlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Pushed for QA

--- Comment #62 from Mirko Tietgen <mirko at abunchofthings.net> ---
sorry, changed by accident. can somebody set it back to pushed to master? i'm
not allowed to

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:36:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:36:38 +0000
Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package
	installations
In-Reply-To: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15303-70-yQdj22bLm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed for QA               |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:38:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:38:27 +0000
Subject: [Koha-bugs] [Bug 16610] New: Regression in SIP2 user password
	handling
Message-ID: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

            Bug ID: 16610
           Summary: Regression in SIP2 user password handling
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Previous to bug 14507, SIP2 only did internal authentication. A change to the
way we check empty passwords has caused any empty password to send back a CQ of
Y. Previous to that patch set, a CQ of Y would only be sent back of the patron
password column was NULL. Now, an empty AD field *always* returns a CQ of Y.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:38:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:38:44 +0000
Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
In-Reply-To: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16610-70-SDORyQMaO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
         Depends on|                            |14507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507
[Bug 14507] SIP Authentication broken when LDAP Auth Enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:38:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:38:44 +0000
Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth
	Enabled
In-Reply-To: <bug-14507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14507-70-3pJOYRwu1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610
[Bug 16610] Regression in SIP2 user password handling
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:44:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:44:33 +0000
Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
In-Reply-To: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16610-70-O4CGzuQyzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:44:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:44:35 +0000
Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
In-Reply-To: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16610-70-ZiGoY4Pakk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51879&action=edit
Bug 16610 - Regression in SIP2 user password handling

Previous to bug 14507, SIP2 only did internal authentication. A change
to the way we check empty passwords has caused any empty password to
send back a CQ of Y. Previous to that patch set, a CQ of Y would only be
sent back of the patron password column was NULL. Now, an empty AD field
*always* returns a CQ of Y.

Test Plan:
1) Send a patron information request with an empty AD field
   Note: You must send the AD field or you won't get back a CQ field
2) Note you get back a CQ of Y
3) Apply this patch
4) Repeat step 1
5) Note you now get back a CQ of N

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 14:55:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 12:55:09 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-OYZfbFSWaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #55 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marcel de Rooy from comment #52)
> What about filling created_on once in AddMember ?
> Mysql accepts: 
>   `stamp1` timestamp NULL DEFAULT NULL,
>   `stamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
> CURRENT_TIMESTAMP

That's a possibility, but the idea was just a structural change.
The updated_on is sufficient for the bug's original intention.


(In reply to Bernardo Gonzalez Kriegel from comment #54)
> Which MySQL version?

Whatever is current with Debian 8, I believe.


(In reply to Bernardo Gonzalez Kriegel from comment #54)
> For example this two columns in virtualshelves give problems on 5.7:
> 
>   `lastmodified` timestamp NOT NULL default CURRENT_TIMESTAMP on update
> CURRENT_TIMESTAMP, -- date and time the list was last modified
>   `created_on` TIMESTAMP NOT NULL, -- creation time

Well, obviously, because NOT NULL means you need a default value. MySQL is
trying to avoid the NULL vs. 0000-00-00 issue.

That's why Marcel was suggesting NULL default NULL above.

My comment was aimed at the disappointment that the following:
`updated_on` timestamp NOT NULL default CURRENT_TIMESTAMP on update
CURRENT_TIMESTAMP, -- date and time the list was last modified
`created_on` TIMESTAMP NOT NULL default CURRENT_TIMESTAMP, -- creation time

Which probably is the equivalent to the less explicit version BKG gave above.
QA-wise, this should be just fine. I'd push a secondary patch to add created_on
with an update in the appropriate Koha perl code in another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 15:13:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 13:13:07 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-By2XExEuGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

s.paltineanu at berlin.bard.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 15:13:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 13:13:09 +0000
Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css
 and other issues
In-Reply-To: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16594-70-FUoUAANXDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

s.paltineanu at berlin.bard.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51841|0                           |1
        is obsolete|                            |

--- Comment #3 from s.paltineanu at berlin.bard.edu ---
Created attachment 51880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51880&action=edit
Bug 16594: Orders by fund report has wrong link to css and other issues

Orders by fund has wrong link to css and other issues
-> The example in the wiki is wrong:
<https://wiki.koha-community.org/wiki/DataTables_HowTo>
<link rel="stylesheet" type="text/css" href="[% themelang
%]/css/datatables.css" />
  [% INCLUDE 'datatables.inc' %]
-> Must be:
<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme
%]/css/datatables.css" />
-> Missing <th></th> in <tfoot> tag
-> Wrong word used "Date deceived" should be "Date received"

NOTE: Wiki needs to be updated

To test:
-Look the code and notice about if else cluase without curly brackets
-Go to Reports > Orders by fund
-Play with: in filters 'All fund' Output: 'to screen into the browser'
-You will see a DataTable displayed in screen clutter
-Notice about 'Date deceived' and the foot of table
-Apply patch
-Refresh or execute again the report

Signed-off-by: Sinziana <s.paltineanu at berlin.bard.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 15:45:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 13:45:02 +0000
Subject: [Koha-bugs] [Bug 16611] New: Item Checkout from Holdings Tab
Message-ID: <bug-16611-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16611

            Bug ID: 16611
           Summary: Item Checkout from Holdings Tab
 Change sponsored?: Seeking cosponsors
           Product: Koha
           Version: master
          Hardware: All
               URL: http://devs.bywatersolutions.com/projects/item-checkou
                    t-holdings-tab/
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Add the ability to checkout select items directly on the holdings tab. For
example, on the holdings tab on the bib detail page we can select items and
then delete or modify the selected items. Our request would be a third option:
checkout items. A pop-up or new tab that would allow us to enter a patron
number would provide an efficient means selecting a few items and to check
these out to a patron or vendor.

Work to be done:

* Add system preference to turn feature on/off
* Add a link above the holdings on staff detail pages to 'check out'
* Pop up patron search on click
* Perform batch checkout from detail page

Seeking Cosponsors:
http://devs.bywatersolutions.com/projects/item-checkout-holdings-tab/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 15:48:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 13:48:05 +0000
Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
In-Reply-To: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16610-70-X16yK5OE7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 15:48:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 13:48:07 +0000
Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
In-Reply-To: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16610-70-ECk8DEGUKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51881&action=edit
[SIGNED-OFF] Bug 16610 - Regression in SIP2 user password handling

Previous to bug 14507, SIP2 only did internal authentication. A change
to the way we check empty passwords has caused any empty password to
send back a CQ of Y. Previous to that patch set, a CQ of Y would only be
sent back of the patron password column was NULL. Now, an empty AD field
*always* returns a CQ of Y.

Test Plan:
1) Send a patron information request with an empty AD field
   Note: You must send the AD field or you won't get back a CQ field
2) Note you get back a CQ of Y
3) Apply this patch
4) Repeat step 1
5) Note you now get back a CQ of N

Signed-off-by: Trent Roby <troby at bclib.info>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:11:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:11:51 +0000
Subject: [Koha-bugs] [Bug 16612] New: Cannot set "Until date" for
 "Enrollment period" for Patron Categories
Message-ID: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

            Bug ID: 16612
           Summary: Cannot set "Until date" for "Enrollment period" for
                    Patron Categories
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Attempting to set an "Until date" date for "Enrollment period" will result in
the date being accepted but not saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:12:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:12:16 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-lpy2d79z5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:19:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:19:15 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-KUDsVIl9g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:19:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:19:18 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-XsovjsDRx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 51882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51882&action=edit
Bug 16612 - Cannot set "Until date" for "Enrollment period" for Patron
Categories

Attempting to set an "Until date" date for "Enrollment period" will
result in the date being accepted but not saved.

Test Plan:
1) Attempt to set an enrollment period until date for a new patron category
2) Note the period is not saved
3) Apply this patch
4) Attempt to set the enrollment period date again
5) This time it should save!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:22:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:22:20 +0000
Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron
 category in patron data
In-Reply-To: <bug-9836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9836-70-p9nmI2vbLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836

--- Comment #17 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
No, I gave up this patch

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:23:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:23:58 +0000
Subject: [Koha-bugs] [Bug 7654] Add location an callnumber at opac
	subscription view
In-Reply-To: <bug-7654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7654-70-JYHqLNOLku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654

--- Comment #19 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
No,it's no more valid

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:50:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:50:06 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-F0E8DePRYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 16:50:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 14:50:08 +0000
Subject: [Koha-bugs] [Bug 16612] Cannot set "Until date" for "Enrollment
 period" for Patron Categories
In-Reply-To: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16612-70-lgqsT6LHqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51882|0                           |1
        is obsolete|                            |

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 51883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51883&action=edit
Bug 16612 - Cannot set "Until date" for "Enrollment period" for Patron
Categories

Attempting to set an "Until date" date for "Enrollment period" will
result in the date being accepted but not saved.

Test Plan:
1) Attempt to set an enrollment period until date for a new patron category
2) Note the period is not saved
3) Apply this patch
4) Attempt to set the enrollment period date again
5) This time it should save!

Signed-off-by: Andrew Brenza <abrenza at audubonlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 17:40:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 15:40:50 +0000
Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons
 in cities administration
In-Reply-To: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16541-70-kL10HHhZbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

archiv <archiv at a-bibliothek.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51790|0                           |1
        is obsolete|                            |

--- Comment #2 from archiv <archiv at a-bibliothek.org> ---
Created attachment 51884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51884&action=edit
Bug 16541 - Make edit and delete links styled buttons in cities administration

This patch modifies the cities administration page, converting edit and
delete links to Bootstrap buttons with Font Awesome icons.

To test, apply the patch and go to Administration -> Cities and towns.
The 'Edit' and 'Delete' buttons should look correct and work correctly.

Signed-off-by: rainer <archiv at a-bibliothek.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 17:41:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 15:41:34 +0000
Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons
 in cities administration
In-Reply-To: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16541-70-x98SnVZw5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

archiv <archiv at a-bibliothek.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |archiv at a-bibliothek.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 19:19:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 17:19:03 +0000
Subject: [Koha-bugs] [Bug 16613] New: MARC 09X Field Help Links are Broken
Message-ID: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613

            Bug ID: 16613
           Summary: MARC 09X Field Help Links are Broken
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: ephetteplace at cca.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 51885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51885&action=edit
git-created patch, adds 2 lines of JS

The 09X MARC fields, such as 099 local call number or 090 locally-assigned
Library of Congress call number, all point to non-existent pages on the LC
website, e.g. http://www.loc.gov/marc/bibliographic/bd090.html

Steps to recreate:

- enter the advanced cataloging editor
- begin to input any MARC tag of form 09X
- click the help link at the bottom of the browser window
- taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + tag +
'.html'` which is broken because the only documentation for these tags is at
https://www.loc.gov/marc/bibliographic/bd09x.html

Since there's already an if-else clause for 9XX tag documentation, I thought
this deserved an exception too. Attached is a patch which links the 09X help
fields to the link referenced above. Let me know if I'm not following the right
guidelines, I'm not used to submitting patches like this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 19:21:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 17:21:55 +0000
Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-tnzioaXmAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 19:25:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 17:25:39 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-udI1auJ6ms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51863|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51886&action=edit
[SIGNED-OFF] Bug 16608 - Add xsd extension to t/00-valid-xml.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 19:25:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 17:25:48 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-5I3CQLulCZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51864|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51887&action=edit
[SIGNED-OFF] Bug 16608 - Missing entity nbsp in some XML files

The special character "non breaking space" &nbsp; is not contained in XML
syntax by default.
So we add it in the file header :
<!DOCTYPE stylesheet [<!ENTITY nbsp "&#160;" >]>

Even if the source code files do no contain this character, it can be that
translated files contain it.
French for example "Titre&nbsp;:".

This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/
and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt.

Test plan :
  - generate French templates:
    cd misc/translator
    ./translate install fr-FR
    cd ../..
  - run test:
    prove -v t/00-valid-xml.t
    you get failing error message
  - apply this patch
  - translate again
  - run test again: it passes

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described following test plan
Tes pass, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 19:26:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 17:26:04 +0000
Subject: [Koha-bugs] [Bug 16608] Missing entity nbsp in some XML files
In-Reply-To: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16608-70-4uUisaK5hh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 20:04:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 18:04:01 +0000
Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken
In-Reply-To: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16613-70-wg3eg8XRx5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
  Attachment #51885|application/mbox            |text/plain
          mime type|                            |
  Attachment #51885|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 20:07:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 18:07:58 +0000
Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken
In-Reply-To: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16613-70-XnQbhTbMOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |ephetteplace at cca.edu
             Status|NEW                         |Needs Signoff

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Hi Eric,

I took the liberties of:
1 - Assigning the bug to you
2 - Marking the attachment as a patch
3 - Marking the bug as 'Needs Signoff'

I can help you with how to do any/all of these things if you have any
questions. Congrats on submitting your first patch!

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 20:26:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 18:26:49 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-lrF8R2iULJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 20:26:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 18:26:52 +0000
Subject: [Koha-bugs] [Bug 16578] Wide character warning in opac-export.pl
 when utf8 chosen
In-Reply-To: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16578-70-Y4V4A9F59u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51798|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51888&action=edit
[SIGNED-OFF] Bug 16578: Same fix for the staff interface

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as first patch
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 20:39:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 18:39:38 +0000
Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken
In-Reply-To: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16613-70-CBdYvA9jpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 20:39:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 18:39:40 +0000
Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken
In-Reply-To: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16613-70-YP0Ih5KRVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 51889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51889&action=edit
fix MARC 09X help links

cataloging module UI

https://bugs.koha-community.org/show_bug.cgi?id=16613

Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri May 27 22:32:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 May 2016 20:32:31 +0000
Subject: [Koha-bugs] [Bug 16613] MARC 09X Field Help Links are Broken
In-Reply-To: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16613-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16613-70-wsrQvHAXXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16613

--- Comment #3 from Eric Phetteplace <ephetteplace at cca.edu> ---
Awesome, thanks for the quick turnaround! Really excited to start working with
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 05:11:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 03:11:16 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-R2vDeN9Lih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51890&action=edit
Bug 16554: DO NOT PUSH - (followup) - sorted filenames

Filenames must be loaded in alphabetical order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 05:18:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 03:18:57 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-WtlNgwC4jv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #13)
> 
> I did not finish the execution of this script but it should permit to test
> all sample files without inserting it manually.

I did, several times.
Great tool Jonathan, it deserves to stay... somewhere :)

> Could someone test it on MySQL 5.7 and all patches from this bug report (and
> from bug 16573 as well).

I found and fixed files for en, es-ES, fr-*, nb & pl
I'm fixing ru & uk, it's a nightmare.
I'll upload more patches soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 06:05:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 04:05:06 +0000
Subject: [Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode
In-Reply-To: <bug-12641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12641-70-2MLjMKASDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:48:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:48:36 +0000
Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation
 actions are not translatable
In-Reply-To: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15676-70-e80PzqkEc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51846|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51891&action=edit
Bug 15676 - Actions in pending offline circulation actions are not translatable

This patch modifies the offline circulation transaction processing page
so that English strings describing actions are processed in the template
rather than being output directly from the script.

To test, apply the patch and create an offline circulation file
containing at least one checkout, one check-in, and one payment.

- Upload the file and choose 'Add to offline circulation queue.'
- View pending offline circulation actions
- In the list of pending actions, the actions column should show "Check
  out" instead of "issue," "Check in" instead of "return," and "Payment"
  instead of "payment."

Strings appear as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:49:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:49:19 +0000
Subject: [Koha-bugs] [Bug 15676] Actions in pending offline circulation
 actions are not translatable
In-Reply-To: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15676-70-3GrOZFkxer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:54:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:54:37 +0000
Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module,
 use Koha::Account::pay internally for recordpayment
In-Reply-To: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15895-70-3c1bX6oymZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:56:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:56:35 +0000
Subject: [Koha-bugs] [Bug 15900] Remove use of recordpayment in
	ProcessOfflinePayment
In-Reply-To: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15900-70-o2pqzJIvUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:57:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:57:07 +0000
Subject: [Koha-bugs] [Bug 15899] Remove the use of recordpayment
In-Reply-To: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15899-70-zNWIoS97ku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:57:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:57:24 +0000
Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions
In-Reply-To: <bug-15894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15894-70-J0OfdwpdJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:57:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:57:59 +0000
Subject: [Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
In-Reply-To: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15903-70-yjSh4pi2qL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:58:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:58:26 +0000
Subject: [Koha-bugs] [Bug 15902] Remove use of recordpayment in
	process_koc.pl
In-Reply-To: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15902-70-JyWuyLJ0oj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 08:58:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 06:58:40 +0000
Subject: [Koha-bugs] [Bug 15901] Remove use of recordpayment in
 C4::SIP::ILS::Transaction::FeePayment
In-Reply-To: <bug-15901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15901-70-cRn9KsoLDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15901

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 09:10:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 07:10:44 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
 not update last seen date for check-ins
In-Reply-To: <bug-15751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15751-70-Z6gghFn2pw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 09:49:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 07:49:05 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files
 associated to LibreOffice Calc
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-XqIi8A3BxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Quote of the day: Can not   |Quote of the day: Fix
                   |upload csv file             |upload with csv files
                   |                            |associated to LibreOffice
                   |                            |Calc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 09:59:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 07:59:58 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files
 associated to LibreOffice Calc
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-EbuMdymnLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51892&action=edit
Bug 16589 - Quote of the day: Fix upload with csv files associated to
LibreOffice Calc

To reproduce:
- Install LibreOffice and make sure that csv files are associated to Calc
  (Note: tested with Firefox 46.0.1 on Windows 8)
- Go to Home > Tools > Quote editor > Quote uploader
- Try to upload a valid CSV (e.g. Example from Bug 15684)
Result: File can not be uploaded
        (Incorrect filetype: application/vnd.sun.xml.calc)
To test:
- Apply patch
- Try to upload again
Expected result: Quotes are imported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 10:00:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 08:00:32 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files
 associated to LibreOffice Calc
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-s8ZyrObghj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 10:22:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 08:22:20 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-E1pdTvu8Sh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mathsabypro at gmail.com       |katrin.fischer at bsz-bw.de

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Working on an alternative patch for implementing this feature - will upload
patches in the next few days!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 10:31:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 08:31:44 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-EtARxOwqLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 10:52:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 08:52:44 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-AWDMRcKyWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 10:53:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 08:53:20 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-cD8YhYfY2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 10:53:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 08:53:23 +0000
Subject: [Koha-bugs] [Bug 16602] Remove the use of "onclick" from several
	templates
In-Reply-To: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16602-70-2eeRXd1Leq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51845|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 51893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51893&action=edit
Bug 16602 - Remove the use of "onclick" from several templates

This patch removes the use of "onclick" from several templates, instead
defining click events in JavaScript.

Also changed: Some markup corrections.

To test, apply the patch and:

- Go to Circulation -> Upload offline circulation file
  - Browse for an offline circulation file.
  - Clicking the 'Upload file' button should work correctly.
    - After uploading a file, both the 'Add to offline circulation
      queue' and 'Apply directly' buttons should work to trigger their
      corresponding processes (keeping Bug 16603 in mind).

- Go to Patrons -> Patron lists.
  - For any patron list containing patrons, click the 'Print patron
    cards' menu item. This should trigger a modal window which exports
    the correct list.

- Go to Tools -> Batch item modification.
  - Submit a batch of items for modification.
  - Clicking the 'Save' button should trigger the background job and the
    items should be successfully modified.

- Go to Tools -> Batch item deletion.
  - Submit a batch of items for deletion.
  - Clicking the 'Delete' button should trigger the background job and
    the items should be successfully deleted.

- Go to Tools -> Calendar.
  - Trigger the 'Add new holiday' panel by clicking a day on the
    calendar which has no holiday defined.
  - Clicking the 'Cancel' link should hide the panel.
  - Trigger the 'Edit this holiday' panel by clicking a day which has a
    holiday defined.
  - Clicking the 'Cancel' link should hide the panel.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Everything works as previously.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 11:04:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 09:04:27 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files
 associated to LibreOffice Calc
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-twPv4UJf8U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 11:04:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 09:04:29 +0000
Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files
 associated to LibreOffice Calc
In-Reply-To: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16589-70-VLKH6o6tQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51892|0                           |1
        is obsolete|                            |

--- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 51894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51894&action=edit
Bug 16589 - Quote of the day: Fix upload with csv files associated to
LibreOffice Calc

To reproduce:
- Install LibreOffice and make sure that csv files are associated to Calc
  (Note: tested with Firefox 46.0.1 on Windows 8)
- Go to Home > Tools > Quote editor > Quote uploader
- Try to upload a valid CSV (e.g. Example from Bug 15684)
Result: File can not be uploaded
        (Incorrect filetype: application/vnd.sun.xml.calc)
To test:
- Apply patch
- Try to upload again
Expected result: Quotes are imported.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this
  patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 11:17:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 09:17:39 +0000
Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin
In-Reply-To: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16577-70-br43AvxTDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51740|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 51895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51895&action=edit
Bug 16577 - Improve call number browser plugin

This patch makes several markup and style improvements to the call
number browser plugin added by Bug 13364. Some of the changes:

- The size of the pop-up window has been increased slightly for a less
  cramped display.
- Page structure has been updated to match similar pop-up windows.
- Page structure has been improved to further accommodate the option of
  viewing the call number browser as a full page rather than a pop-up
  window (although as far as I can tell it is not linked to in this mode
  anywhere).
- Row highlighting has been updated so that page styles are not being
  passed explicitly by the script. Highlight colors have been changed to
  make things more readable.
- DataTables-related markup has been removed because it was not being
  used. It doesn't make sense to re-order table rows when the purpose of
  the table is to display call number order.

To test, apply the patch and edit a framework so that the item call
number field uses the 'cn_browser.pl' plugin.

- Create or edit an item in cataloging.
- Enter an existing call number into the call number field.
  - Click the '...' link next to the call number.
    - In the call number browser pop-up, verify that items matching your
      call number are highlighted in red.
    - Verify that the new 'Close' button at the bottom of the page works
      correctly.
- Enter a call number which doesn't exist in the call number field
  - Click the '...' link to trigger the browser.
    - Verify that there is a row highlighted in green marking the sort
      order of the call number you chose.
- Navigate directly to
  /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl
  - The page should appear like a normal full page, with header search,
    breadcrumbs, etc. Performing a search for call numbers should work
    like it did in the pop-up context.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
  Works as described. Pleasing to the eye

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 11:20:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 09:20:37 +0000
Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in
	opac-memberentry.tt
In-Reply-To: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16560-70-h0ez93Wqnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 11:20:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 09:20:40 +0000
Subject: [Koha-bugs] [Bug 16560] Translatability: Issues in
	opac-memberentry.tt
In-Reply-To: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16560-70-7QETICOtXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51718|0                           |1
        is obsolete|                            |

--- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 51896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51896&action=edit
Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt

This patch fixes two splitted sentences to avoid translation issues:

The entered <a href="#borrower_cardnumber">card number</a> is the wrong length.
The entered <a href="#borrower_cardnumber">card number</a> is already in use.

To test:
Apply patch and verify that html in the 2 that are changed is correct and that
they are not splitted by a-tags.

Note: I could not figure out under which conditions this code displays in
      the OPAC self registration form.

Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 11:21:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 09:21:28 +0000
Subject: [Koha-bugs] [Bug 16577] Improve call number browser plugin
In-Reply-To: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16577-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16577-70-4GAeYUVU2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 12:08:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 10:08:49 +0000
Subject: [Koha-bugs] [Bug 16614] New: Customize Mainpage.pl in koha
Message-ID: <bug-16614-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16614

            Bug ID: 16614
           Summary: Customize Mainpage.pl in koha
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dgp.atanu at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Want to Customize Mainpage.pl in koha . How it can be done. I want to add
customize menus of Koha main page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 15:24:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 13:24:07 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-J7TFTlG8i8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 16:12:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 14:12:14 +0000
Subject: [Koha-bugs] [Bug 16614] Customize Mainpage.pl in koha
In-Reply-To: <bug-16614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16614-70-Ux79TbZlED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16614

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |m.de.rooy at rijksmuseum.nl
         Resolution|---                         |FIXED

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Atanu,
Please mail your question to the Koha mailing list, or join the IRC channel.
See https://koha-community.org/support/community-support/
A bug report is meant to report specific errors in the software or to describe
enhancements or new features.
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 18:07:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 16:07:10 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-MgM3q6gIbE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51897&action=edit
Bug 16554: More i18n changes - en, es, nb and pl files

Mostly fixes bad values in auth files ( '' -> 0 )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 18:20:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 16:20:18 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-DsKkTVAwVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898&action=edit
Bug 16554: More i18n changes - fr-FR files

Mostly fixes bad values in auth files ( '' -> 0 )
Small rewrite of files.

Too big for git-bz and/or bugzilla :(
It's a compressed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 18:22:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 16:22:19 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-gADEC3ARuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899&action=edit
Bug 16554: More i18n changes - ru-RU files

Mostly fixes bad values in framework files ( '' -> 0 )
Rewriting of some files
Removing truncations

Too big for git-bz, compressed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 18:24:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 16:24:07 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-TfVdy7OxlK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

--- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 51900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900&action=edit
Bug 16554: More i18n changes - uk-UA files

Mostly fixes bad values in framework files ( '' -> 0 )
Rewriting of some files
Removing truncations

Too big for git-bz, compressed patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 18:37:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 16:37:55 +0000
Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample
 data on MySQL 5.6+
In-Reply-To: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16554-70-XTslQlnfGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Large patch

--- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
REVISED TEST PLAN
-----------------

Apply all patches from 16573, all patches from this one, 
download, gunzip and apply last three patches

On MySQL 5.7 create koha_test_installer db, then run Jonathan test file :)

Must see no warnings/errors

SAMPLE OUTPUT
-------------
$ mysql --version
mysql  Ver 14.14 Distrib 5.7.12, for Linux (x86_64) using  EditLine wrapper
$ prove -v t/db_dependent/Test_installer.t
t/db_dependent/Test_installer.t .. 
loading kohastructure for de-DE | not marc21
loading kohastructure for de-DE | not unimarc
loading kohastructure for en | not marc21
loading kohastructure for en | not unimarc
loading kohastructure for es-ES | not marc21
loading kohastructure for es-ES | not unimarc
loading kohastructure for fr-CA | not marc21
loading kohastructure for fr-CA | not unimarc
loading kohastructure for fr-FR | not marc21
loading kohastructure for fr-FR | not unimarc
loading kohastructure for it-IT | not marc21
loading kohastructure for it-IT | not unimarc
loading kohastructure for nb-NO | not marc21
loading kohastructure for nb-NO | not unimarc
loading kohastructure for pl-PL | not marc21
loading kohastructure for pl-PL | not unimarc
loading kohastructure for ru-RU | not marc21
loading kohastructure for ru-RU | not unimarc
loading kohastructure for uk-UA | not marc21
loading kohastructure for uk-UA | not unimarc
110/110
No subtests run 

Test Summary Report
-------------------
t/db_dependent/Test_installer.t (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: No plan found in TAP output
Files=1, Tests=0, 3916 wallclock secs ( 0.06 usr  0.01 sys + 10.68 cusr  1.46
csys = 12.21 CPU)
Result: FAIL

Don't worry about FAIL message, with this output all is Ok.
On my very modest system it took ~ 60 minutes.

This has become a gigantic patchset, which guarantees that Koha
installs on MySQL 5.7, any language/marcflavour, no that it runs. 
But it's a first step.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 20:44:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 18:44:10 +0000
Subject: [Koha-bugs] [Bug 16576] Remove the use of "onclick" from label
	templates
In-Reply-To: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16576-70-UDERaJ5A2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51739|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51901&action=edit
Bug 16576 - Remove the use of "onclick" from label templates

This patch updates several label creator templates to remove the use of
"onclick" in favor of defining click events in JavaScript.

Also changed:
 - Replaced the non-existant element <icon> with <i>
 - Removed the use of <center> and 'align="center"';
 - In the item search results template:
   - The pagination bars have been updated to match those in use
     elsewhere.
   - The use of the checkboxes jQuery plugin has been replaced with
     straight jQuery for simplicity's sake.
   - Output of table headers has been modified so that translatable
     strings are in the template instead of having English strings
     passed from the script.
   - Moved the 'Add checked' and 'Done' buttons into a floating toolbar.

To test, apply the patch and go to Tools -> Label creator.

- Choose New -> Label batch
  - Click 'Add items'
    - Perform a search for items.
    - Confirm that 'select all' and 'clear all' links work.
    - Confirm that clicking an individual 'Add' button works.
    - Select multiple items and click the 'Add checked' button. Confirm
      that the selected items were added to your batch.
  - Click 'Add items' again to save the selected items to your batch.
  - Test that the 'Delete' and 'Export' buttons next to any item work
    correctly.
- Choose Manage -> Label batches
  - Test that the 'Delete' button works correctly.
  - Select one or more batches and test that the 'Export selected'
    button works correctly.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 20:44:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 18:44:32 +0000
Subject: [Koha-bugs] [Bug 16576] Remove the use of "onclick" from label
	templates
In-Reply-To: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16576-70-5IJUHy11SL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 20:58:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 18:58:34 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-If4e4yz3XD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
(In reply to Owen Leonard from comment #1)
> (In reply to Nick Clemens from comment #0)
> >
> > https://snag.gy/YOlr50.jpg
> 
> We obviously have another problem here too: Two transfer messages? Shouldn't
> the rotating collection transfer message supersede the "normal" one?

Same opinion. I think this should be covered by another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 20:59:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 18:59:47 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-jdKlstmk69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51791|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 51902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51902&action=edit
Bug 16566 - 'Print slip' button formatting inconsistent

This patch modifies the style of some "print slip" links on the checkin
page to make them consistent with other buttons shown in dialogs.

This patch also removes the use of "onclick" in some places in favor of
defining events in the JavaScript.

To test apply the patch and go to Circulation -> Check in.

- Check in an item which belongs at another branch. You should see a
  dialog which asks the user to transfer the item. Confirm that the
  "Print slip" button looks correct and works correctly.

- Check in the same item again. You should see a different dialog which
  has both a "Print transfer slip" and "Cancel transfer" button. The
  "Print transfer slip" button should look correct and work correctly.

- Check in an item which is part of a rotating collection. (Or, if Bug
  16570 is still open, check in any item) You should see a dialog which
  notifies you that the item is part of a rotating collection. The
  "Print slip" button in this dialog should look correct and work
  correctly.

Followed test plan. Buttons appear as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:00:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:00:14 +0000
Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent
In-Reply-To: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16566-70-OLyKM1zWJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:12:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:12:09 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-GZd9zdxLnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51796|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 51903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51903&action=edit
Bug 16519: Replace 'our' with 'my' in [opac-]addbybiblionumbers.pl

To avoid bug like bug 16518 and to ease the readability/maintainability
of these scripts, this patch replaces the use of 'our' with 'my' to
avoid the use of global variables.

Basically the code has been moved from subroutines to the appropriate places.

Test plan:
At the intranet and OPAC sides
1/ Add items to a list
2/ Add items to a list using an existing name
3/ Add items to a list you don't have right on it (by modifying the
biblionumber in the url)
4/ At the OPAC, use the opac-addbybiblionumber.pl without being logged
in to add items to a list

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:12:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:12:27 +0000
Subject: [Koha-bugs] [Bug 16519] Do not use global variables in
 [opac-]addbybiblionumbers.pl
In-Reply-To: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16519-70-WXtQBJyqYa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:21:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:21:16 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-QxDPlVigJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51472|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51904&action=edit
Bug 16513 - Improvements and fixes for quote upload process

This patch fixes some minor bugs and adds a small enhancement to the
quotes editor and quotes upload pages.

To test, apply the patch and go to Tools -> Quote editor

- In the table of quotes, clicking the "ID" table header should trigger
  an alert, "Click on the quote's ide to select..."
- Go to "Import quotes" and select a file to upload.
- On the upload preview page you should see a new "Cancel import"
  button. Clicking it should return you to the quotes upload page after
  asking for confirmation.
- Test the upload cancel button:
  - If you have fast reflexes or are uploading a file large enough, you
    should be able to see a "Cancel upload" button during the upload
    process.
  - Clicking this button should cancel the upload and return you to the
    quote upload page.

Tested on top of Bug 16589, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:21:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:21:28 +0000
Subject: [Koha-bugs] [Bug 16513] Improvements and fixes for quote upload
	process
In-Reply-To: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16513-70-n8F5fy1UPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:26:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:26:08 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-RGOVx95Nqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51792|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51905&action=edit
Bug 16462 - Change default sorting of circulation patron search results to
patron name

This patch changes the default sort of patron quick search results from
the circulation header search or when searching for a patron during the
hold process.

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- Confirm that the results are sorted by patron name.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the results are sorted by patron name.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat May 28 21:26:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 May 2016 19:26:38 +0000
Subject: [Koha-bugs] [Bug 16462] Change default sorting of circulation
 patron search results to patron name
In-Reply-To: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16462-70-mH8YHNnXkh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 29 11:05:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 May 2016 09:05:07 +0000
Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha
In-Reply-To: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14239-70-NgKlmJdeip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun May 29 17:59:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 May 2016 15:59:30 +0000
Subject: [Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50
 import sources
In-Reply-To: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16488-70-4FM8mL0xOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

Manos PETRIDIS <egpetridis at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egpetridis at yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 01:37:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 May 2016 23:37:34 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-M7htvlq9TP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #18)
> Could you (slightly) adjust the way to skip the normalize call for the URLs,
> that does not suggest that the norms functionality is present while we do
> not even have C4::Normalizer?

I'm not sure that I understand your question...

Regardless of whether or not you provide a value for "Normalization rule" on
/cgi-bin/koha/admin/matching-rules.pl, the default _normalize() function will
run.

While the matchpoint_component_norms.norm_routine isn't currently used in the
code, I add some code that does use it for the sole purpose of detecting a
"none" or "raw" normalization (ie no normalization).

Are you saying that you don't want me to add that code because it suggests to
people that adding a value there (besides "none" or "raw") will have an effect?

I could a checkbox on the UI that says "Skip normalization rule" or something
like that, but it would fulfil the same purpose of adding a "none" norm_routine
in the database.

Sorry, but I'm still not sure what you're asking, Marcel. Honestly, there
should probably be no normalization at this step. I would remove the
"Normalization rule" from the code, but it affects too many existing systems.
The patch I have here is the lightest change while also providing the desired
functionality. I'm not sure what else a person could do to skip the
normalization in a way that is backwards compatible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 02:58:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 00:58:36 +0000
Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu
 16.04 and MySQL 5.7
In-Reply-To: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16583-70-uvn0fiBjv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Liz,
we'll have plenty of trouble with (In reply to Liz Rea from comment #0)
> Have noticed some strangeness with a clean install of Koha on MySQL 5.7:

we'll have plenty of trouble with 5.7

> 
> When adding a rule at /cgi-bin/koha/admin/smart-rules.pl, if any box is left
> empty the first empty field pops an error similar to this:
> 
> DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for
> column 'chargeperiod' at row 1 at
> /usr/share/koha/intranet/cgi-bin/admin/smart-rules.pl line 170

In this case the problem is that we depended on a type conversion done by
MySQL, empty '' string -> 0. In smart-rules.pl for example, every empty box is
sent as an empty string to the database, which used to transform that to 0.
With 5.7+ version this is not the default behavior :(

> 
> When attempting to add a borrower category, it thinks a duplicate has been
> added with the resultant error message
> 
> "An error occurred when inserting this patron category. The patron category
> might already exist."
> 

There are some cases where the strange use of 'GROUP BY' not really needed
triggers the error. This is one of them.

Thoughts: 
a) try to support the 'strict' mode of MySQL 5.7+
b) suggest that anyone interested reconfigure server to a less 'strict' mode
c) ignore the problem because is not in Debian, yet.

I've patches for these problems, and others not yet reported.
Just need to know what are we going to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 03:07:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 01:07:16 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-giYMXyrC06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #11)
> Ok you will remove the software error, but I am not sure it's the way to go.
> 

I would certainly prefer a more thorough overhaul of Koha's DateTime handling,
but I think this is good enough for now. Chile can't use the overdue
functionality in Koha at all at this stage without this fix.

> Currently the dates are stored in local time (so with the tz), if we want to
> switch to floating time zones (what we should do at some point!) I think we
> should recalculate all dates present in DB.
> An easy workaround would be to use Koha::DateUtils, which deals (at least
> try to) with invalid dates due du DST.

Well, we calculate and interpret the dates using local time, but they're stored
without timezone in the database.

So I'm not sure what you mean by "recalculate all dates present in DB". The
only difference between "local" and "floating" is the timezone. They're the
same numbers, so there would be no recalculation to do. Or do you mean we
should recalculate into UTC?

Even if it were stored in UTC, it would need to be converted to local, and then
to floating for the actual date handling, as we'd need the local numbers before
doing any datetime math/truncation for the holiday checks.

I have my reservations about Koha::DateUtils... I don't think enough thought
has been put into its implementation. Besides, it wouldn't work in this case.

Jonathan, the main problem at the moment is that Koha::DateUtils produces a
valid local time, so it uses the local timezone. During the
$calendar->days_between(), a day is added to this local datetime to produce
another valid local time. However, the act of truncating that valid local time
creates an invalid local time. So Koha::DateUtils isn't going to know there's a
problem until it's too late. You could implement your own wrapper around
DateTime, but I think that's getting excessive. We just need to be thoughtful
and careful in our handling of dates and time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 03:10:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 01:10:52 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-g9EO7giGjE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Janice, I'm guessing the problem is your data.

How many records do you have in your database? Are you using MARC21 or UNIMARC?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 03:11:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 01:11:31 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-BHXq12Xgz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
By the way, since this looks like a data issue, it would probably be more
appropriate and useful to discuss this on the listserv:
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 03:18:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 01:18:57 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-8eulZz5xy5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #12)
> Moreover `grep time_zone Koha/Calendar.pm` will return another occurrence
> where the fix should be applied too.

Interesting.

I think I avoided that the first time because $calendar->is_holiday() uses the
following:

my $ymd   = $localdt->ymd('')  ;
if ($self->single_holidays(  $ymd  ) == 1 ) {
    return 1;
}

However, you are correct. sub single_holidays is weird... but definitely prone
to this problem too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 03:24:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 01:24:44 +0000
Subject: [Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation
 creates fatal errors for TZ America/Santiago
In-Reply-To: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16376-70-Bkv394iHYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51702|0                           |1
        is obsolete|                            |

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51906&action=edit
Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for
TZ America/Santiago

Using a DateTime object with a timezone of America/Santiago
was causing fatal errors for Koha::Calendar->is_holiday
and Koha::Calendar->exception_holidays, when the objects
were truncated to an invalid local time.

Using a floating zone allows us to use the same day, month, year
for comparison purposes without running into the possibility of
creating an invalid local time and thus a fatal software error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 03:57:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 01:57:40 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-Qv5pVeFkRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

--- Comment #7 from Janice Chow <janice.chow at sw-hk.com> ---
Hi David,

I got total 649 records in my database and I using MARC21.

I through the data problem should be what I input on 23/5. Since I inputted and
I can't search the word "csj", "journal" etc... Should I delete this MARC
record?

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 04:27:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 02:27:07 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-8xDgRSHtts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 04:27:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 02:27:10 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-1edGswMNTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 51907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51907&action=edit
Bug 16575 - Irregular behaviour using window.print() followed by
window.location.href=

Use print.css for OPAC basket when printing instead of using navigation.

Currently, when you click "Print" on the OPAC basket, it'll navigate to a new
page
and initiate window.print() followed by a window.location.href change again.
Unfortunately, due to differences in IE, Chrome, and FF, it will
either show the print options, navigate away without showing them, or refuse
to navigate away after printing. By changing to using print.css, we don't
navigate away from the basket in the first place, so we prevent this
irregular behaviour.

_TEST PLAN_

1) Apply the patch
2) Create an OPAC basket by clicking "Add to cart" on multiple items
3) Using Chrome, IE, and Firefox (of any version), click the "Print" button
4) You should see the relevant print menu without the OPAC basket re-loading
in any way.
5) After printing is complete, you should still be on the OPAC basket pop-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 04:42:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 02:42:41 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-W69ZNyj4WB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
At some point, it would be prudent to strip the now unnecessary "print_basket"
stuff out of opac-basket.tt. I didn't include it here, as it wasn't necessary
for the actual bug fix.

I also didn't want to do the work of removing all that code, if QA decides that
this fix is no good, so I'm happy to add a follow-up once QA is happy with this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 06:22:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 04:22:11 +0000
Subject: [Koha-bugs] [Bug 16574] Software error when search the catalog
In-Reply-To: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16574-70-fiVEudItbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16574

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Janice Chow from comment #7)
> Hi David,
> 
> I got total 649 records in my database and I using MARC21.
> 
> I through the data problem should be what I input on 23/5. Since I inputted
> and I can't search the word "csj", "journal" etc... Should I delete this
> MARC record?
> 
> Thank you.

I'm not sure what you mean by 23/5, but if you know which record is causing the
problem, I would suggest deleting it. You'd probably want to save/export it
first so that you can re-import the record's data in again later. 

I would recommend trying this tool plugin:
https://github.com/bywatersolutions/koha-plugin-marc-checker

It might help to find problems with your records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 06:43:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 04:43:47 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-vBagG9bE8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 06:43:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 04:43:49 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-N4a5yaD00J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51907|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51908&action=edit
[SIGNED-OFF] Bug 16575 - Irregular behaviour using window.print() followed by
window.location.href=

Use print.css for OPAC basket when printing instead of using navigation.

Currently, when you click "Print" on the OPAC basket, it'll navigate to a new
page
and initiate window.print() followed by a window.location.href change again.
Unfortunately, due to differences in IE, Chrome, and FF, it will
either show the print options, navigate away without showing them, or refuse
to navigate away after printing. By changing to using print.css, we don't
navigate away from the basket in the first place, so we prevent this
irregular behaviour.

_TEST PLAN_

1) Apply the patch
2) Create an OPAC basket by clicking "Add to cart" on multiple items
3) Using Chrome, IE, and Firefox (of any version), click the "Print" button
4) You should see the relevant print menu without the OPAC basket re-loading
in any way.
5) After printing is complete, you should still be on the OPAC basket pop-up

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 06:46:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 04:46:05 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-oACmFOetyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I think you should have included js removal with the patch, not used so should
go.
What's the story with the intranet basket?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 07:00:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 05:00:28 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-Huyhk6sK1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51758|0                           |1
        is obsolete|                            |
  Attachment #51759|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51909&action=edit
[SIGNED-OFF] Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not
available

This patch makes it so 00-load.t doesn't cause 'prove t' to
prematurely die before reaching other tests.

TEST PLAN
---------
1) prove t
   -- dies on 00-load.t
2) apply patch
3) prove t
   -- now t/Prices.t should be the failure.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 07:03:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 05:03:43 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-1q8R2ktnZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 07:03:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 05:03:45 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-3xQs5ttWlp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51910&action=edit
[SIGNED-OFF] Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not
available

TEST PLAN
---------
1) prove t/Prices.t
   -- failure
2) apply patch
3) prove t/Prices.t
   -- nicely skipped when Test::DBIx::Class is not available.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 07:09:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 05:09:56 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-ofwSzG4LJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #5 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Just a couple of generic questions/musings not entirely to do with this patch:

* Wouldn't it be better to rename tests that we don't want to .t.NOT_READY_YET
or similar instead of doing those regexes in load.t?

* I don't understand why use_ok are in the BEGIN block?

* maybe (if not too much of a hassle) we could leave use_ok for
Test::DBIx::Class dependant tests, and skip the rest?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 07:29:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 05:29:48 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-7GMwTcsk5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
That test is failing for me with
DBD::mysql::st execute failed: Field 'lowestPriority' doesn't have a default
value [for Statement "INSERT INTO `reserves` ( `biblionumber`,
`borrowernumber`, `branchcode`, `itemnumber`, `suspend`, `waitingdate`) VALUES
( ?, ?, ?, ?, ?, ? )" with ParamValues: 0='6644', 1='386', 2='EP3', 3='19635',
4=0, 5='2000-01-01'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.
DBIx::Class::Storage::DBI::_dbh_execute(): Field 'lowestPriority' doesn't have
a default value at Koha/Object.pm line 109

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 08:10:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 06:10:52 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-i6hagT5Lvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 08:10:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 06:10:54 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-PIXdhIWpkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51776|0                           |1
        is obsolete|                            |

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51911&action=edit
[SIGNED-OFF] Bug 16540: Translatability in opac-auth.tt (tag-splitted
sentences)

This patch removes tag-splitting from 2 sentences in pac-auth.tt

To test:
- Review code changes and verify that following sentences
  are no longer splitted by <a>-tags:
  "Logout and try again with a different user"
  "Try to log in using a different Google account"

UPDATE: Amended to fix a tiny typo
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 08:11:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 06:11:41 +0000
Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable
In-Reply-To: <bug-15630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15630-70-yGKgn3k0JH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 49788
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788
Bug 15630 - Make Edifact module pluggable

Review of attachment 49788:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15630&attachment=49788)
-----------------------------------------------------------------

::: Koha/Plugins.pm
@@ +20,4 @@
>  use Modern::Perl;
>  
>  use Module::Load::Conditional qw(can_load);
> +use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/;

This seems suboptimal... since any plugin with additional packages would need
an exception.

Wouldn't it make more sense to use "only" to only find plugins like
^Koha::Plugin::Com::CompanyName::PluginName$.

I suppose it might be too late for that now as there's any number of plugins
that can be allowed so perhaps one does have to only use exceptions from now
on... 

I'm thinking of making a plugin, but I'll probably just use a different
namespace like Local::PluginName::Submodules...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 09:35:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 07:35:26 +0000
Subject: [Koha-bugs] [Bug 16615] New: Full-site SSL: always use SSL when
 referencing external resources
Message-ID: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

            Bug ID: 16615
           Summary: Full-site SSL: always use SSL when referencing
                    external resources
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oliver.bock at aei.mpg.de
        QA Contact: testopia at bugs.koha-community.org

Created attachment 51912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51912&action=edit
Patch: Open Library API via SSL

When running Koha in a full-site-SSL configuration accessing external resources
like Open Library cover images via HTTP doesn't work (mixed SSL/non-SSL
content). It thus breaks a core feature of Koha. Referencing such resources
always via HTTPS resolves the problem and also enhances privacy as a
side-effect.

Previous tickets took care of Amazon resources. This ticket is supposed to
address the remaining external resource providers, starting with Open Library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 09:35:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 07:35:44 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-6mW5bUqWNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Oliver Bock <oliver.bock at aei.mpg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14571

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 09:35:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 07:35:44 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-j7QTjVkJwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Oliver Bock <oliver.bock at aei.mpg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16615

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 09:46:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 07:46:58 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-yhN2PVGsUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Srdjan,
Thx for testing. Strange that it fails. You seem to fail already before
reaching my adjustment.  Should fail without my patch too?
I am not having any problem:

t/db_dependent/Hold.t .. ok
All tests successful.
Files=1, Tests=32,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.38 cusr  0.10
csys =  1.53 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 09:47:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 07:47:33 +0000
Subject: [Koha-bugs] [Bug 16595] Concurrent search between ISBN-10 and
 ISBN-13 in staff client and OPAC
In-Reply-To: <bug-16595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16595-70-tOCbl3KN5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16595

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13528

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
See bug 13528. This is possible if you
- enable SearchWithISBNVariations and
- disable UseQueryParser

Should we close this as a duplicate, or keep it open as a reminder that it
would be nice to be able to do this without disabling QueryParser?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 09:47:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 07:47:33 +0000
Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn
	variations
In-Reply-To: <bug-13528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13528-70-NQXxKo4BjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16595

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 10:28:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 08:28:49 +0000
Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable
In-Reply-To: <bug-15630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15630-70-1PTEWUtbbL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #13)

> > +use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/;
> 
> This seems suboptimal... since any plugin with additional packages would
> need an exception.

Have the same feeling when I see these lines..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 10:39:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 08:39:22 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-YhaOdZxkVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Srdjan Jankovic from comment #5)
> Just a couple of generic questions/musings not entirely to do with this
> patch:
> 
> * Wouldn't it be better to rename tests that we don't want to
> .t.NOT_READY_YET or similar instead of doing those regexes in load.t?

We should fix the tests or put some conditional skip in those tests.
I don't favor the regexs in load.t.

PS A new name for the first patch would be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 10:42:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 08:42:42 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-aJPjtiFOPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #6)
> We should fix the tests or put some conditional skip in those tests.
> I don't favor the regexs in load.t.
Well probably not possible,,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 11:00:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 09:00:12 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-uygLCxHthT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #19)
> While the matchpoint_component_norms.norm_routine isn't currently used in
> the code, I add some code that does use it for the sole purpose of detecting
> a "none" or "raw" normalization (ie no normalization).
> 
> Sorry, but I'm still not sure what you're asking, Marcel. Honestly, there
> should probably be no normalization at this step. I would remove the
> "Normalization rule" from the code, but it affects too many existing
> systems. The patch I have here is the lightest change while also providing
> the desired functionality. I'm not sure what else a person could do to skip
> the normalization in a way that is backwards compatible.

I understand your point hopefully :)
If we start using this field: Since it was meant to add a Normalize class, I
think you should create at least a rudimentary one now.
Moving the _normalize code and add your none/raw normalizations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 12:14:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 10:14:57 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-gABs35Hfa0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51909|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51913&action=edit
Bug 16582 [DO NOT PUSH] 'prove t' failure on 00-load.t

This patch makes it so 00-load.t doesn't cause 'prove t' to
prematurely die before reaching other tests.

TEST PLAN
---------
1) prove t
   -- dies on 00-load.t
2) apply patch
3) prove t
   -- now t/Prices.t should be the failure.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 12:15:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 10:15:21 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-7HhAaLivLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51910|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51914&action=edit
Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available

TEST PLAN
---------
1) prove t/Prices.t
   -- failure
2) apply patch
3) prove t/Prices.t
   -- nicely skipped when Test::DBIx::Class is not available.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 12:23:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 10:23:10 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-yNS3HRiMyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
As per comment #6's PS, first one is renamed.

As per comment #5: "I don't understand why use_ok are in the BEGIN block?"
-- I wondered the same thing.

"A BEGIN code block is executed as soon as possible, that is, the moment it is
completely defined, even before the rest of the containing file (or string) is
parsed. You may have multiple BEGIN blocks within a file (or eval'ed string);
they will execute in order of definition. Because a BEGIN code block executes
immediately, it can pull in definitions of subroutines and such from other
files in time to be visible to the rest of the compile and run time. Once a
BEGIN has run, it is immediately undefined and any code it used is returned to
Perl's memory pool."

So, perhaps a memory optimization?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 13:15:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 11:15:58 +0000
Subject: [Koha-bugs] [Bug 16569] Message box for "too many checked out" is
 empty if AllowTooManyOverride is not enabled
In-Reply-To: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16569-70-fDylkgpthp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16569

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 13:18:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 11:18:04 +0000
Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export
	Data screen
In-Reply-To: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16548-70-0f4UXEkKDe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 release.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 13:28:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 11:28:13 +0000
Subject: [Koha-bugs] [Bug 5534] Koha does not ignore punctuation when
	searching
In-Reply-To: <bug-5534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5534-70-mjWJB50arK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 13:46:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 11:46:37 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14571-70-MR8V2C4R8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #22 from Oliver Bock <oliver.bock at aei.mpg.de> ---
(In reply to Jonathan Druart from comment #21)
> Would you please open a new bug report (and link it to this one) to attach
> your patch?
> This one is marked as "pushed to master" and new patches should go on their
> own bug report.

Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 14:10:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 12:10:23 +0000
Subject: [Koha-bugs] [Bug 16617] New: debian/control is broken
Message-ID: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

            Bug ID: 16617
           Summary: debian/control is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: Sun
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: robin at kallisti.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

A blind regeneration of the debian/control file currently is unlikely to
succeed due to missing dependencies and errors in a declaration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 14:10:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 12:10:43 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-EicjtgKqlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Robin Sheat <robin at kallisti.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |robin at kallisti.net.nz
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 14:37:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 12:37:37 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-Q10M7zPqSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

--- Comment #1 from Robin Sheat <robin at kallisti.net.nz> ---
Created attachment 51915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51915&action=edit
Bug 16617 - fix issues with debian/control

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 14:39:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 12:39:29 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-Z4WhQ9uLac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Robin Sheat <robin at kallisti.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #2 from Robin Sheat <robin at kallisti.net.nz> ---
This allows the package to start building, which is progress.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 14:56:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 12:56:01 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-VJg50gfPBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 14:56:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 12:56:04 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-22hiRPRiXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51915|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 51916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51916&action=edit
Bug 16617 - fix issues with debian/control

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 15:36:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 13:36:08 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-jbcKuGMuAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 15:36:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 13:36:11 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-wgJgIS22yw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51916|0                           |1
        is obsolete|                            |

--- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 51917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51917&action=edit
Bug 16617 - fix issues with debian/control

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 15:38:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 13:38:08 +0000
Subject: [Koha-bugs] [Bug 16617] debian/control is broken
In-Reply-To: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16617-70-54YgB8ez1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16617

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 17:46:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 15:46:06 +0000
Subject: [Koha-bugs] [Bug 16618] New: 00-load.t prematurely stops all testing
Message-ID: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

            Bug ID: 16618
           Summary: 00-load.t prematurely stops all testing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mtompset at hotmail.com
        QA Contact: gmcharlt at gmail.com

Rather than add/remove regular expressions to skip modules (like bug 9054),
encapsulate the decision logic into a separate function.

Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search

This number should always be relatively small, if not 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 17:46:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 15:46:15 +0000
Subject: [Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing
In-Reply-To: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16618-70-UXrbD1NZDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 18:33:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 16:33:06 +0000
Subject: [Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing
In-Reply-To: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16618-70-MAOFfYOyb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 18:33:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 16:33:08 +0000
Subject: [Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing
In-Reply-To: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16618-70-D9zox2peKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51918&action=edit
Bug 16618: 00-load.t prematurely stops all testing

Rather than add/remove regular expressions to skip modules (like bug 9054),
encapsulate the decision logic into a separate function.

Currently there are three libraries which trigger halts:
Koha::NorwegianDB (which was already there)
Koha::ElasticSearch::Indexer
Koha::SearchEngine::Elasticsearch::Search

TEST PLAN
---------
1) prove t/00-load.t
   -- should barf horribly on Catmandu stuff
      if not: sudo apt-get remove libcatmandu-marc-perl
      then repeat step.
2) apply patch
3) prove t/00-load.t
   -- should not barf horribly
4) run koha qa test tools

NOTE: The four optional modules for Koha::NorwegianDB are
      listed in the PerlDependencies.pm, while there is
      no mention of Catmandu libraries at all there.
      This may be another bug which needs fixing.

TECH NOTES (for ideas of how to tinker around):
These three things should trigger the three module cases:
sudo apt-get remove libcatmandu-marc-perl
sudo apt-get remove libcatmandu-store-elasticsearch-perl
sudo apt-get remove libconvert-basen-perl

You probably had koha-perldeps installed before, so the following wil mostly
fix:
sudo apt-get install koha-perldeps libcatmandu-marc-perl

And in case you didn't have elastic search stuff installed:
echo deb http://packages.elastic.co/elasticsearch/1.7/debian stable main | sudo
tee /etc/apt/sources.list.d/elasticsearch.list
wget -O- https://packages.elastic.co/GPG-KEY-elasticsearch | sudo apt-key add -
sudo apt-get update

cd ~
wget
http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz
tar xvf elasticsearch_deps.tar.gz
cd es_deps
sudo dpkg i lib*
sudo apt-get install -f

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 18:33:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 16:33:47 +0000
Subject: [Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing
In-Reply-To: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16618-70-bnGL8RFnuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 18:36:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 16:36:52 +0000
Subject: [Koha-bugs] [Bug 16618] 00-load.t prematurely stops all testing
In-Reply-To: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16618-70-FrHVTbyhvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16618

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16582

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 18:36:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 16:36:52 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-pE8ZPgQWse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16618

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon May 30 18:40:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 16:40:02 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-Q3hXVCLMyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51913|0                           |1
        is obsolete|                            |

--- Comment #11 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 51913
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51913
Bug 16582 [DO NOT PUSH] 'prove t' failure on 00-load.t

While similar to bug 9054, regular expressions like this don't actually show
the real problem of missing dependencies. And if those dependencies are
completely optional, we shouldn't even test. This is handled better on bug
16618 now. No need to keep this first patch around. The second can be tested
directly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 01:20:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 23:20:03 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-ijoTytVJPc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Oh yes, definitely fails for me on the master branch, nothing to do with the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 01:21:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 23:21:25 +0000
Subject: [Koha-bugs] [Bug 16619] New: Installer stuck in infinite loop
Message-ID: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

            Bug ID: 16619
           Summary: Installer stuck in infinite loop
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

updatedatabase tries to update to 16.056xxxx when the kohaversion in koha.pm is
set to 16.06. We need to set the updatedatabase version to match.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 01:22:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 23:22:47 +0000
Subject: [Koha-bugs] [Bug 16619] Installer stuck in infinite loop
In-Reply-To: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16619-70-cs3MJDnyP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 01:22:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 23:22:50 +0000
Subject: [Koha-bugs] [Bug 16619] Installer stuck in infinite loop
In-Reply-To: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16619-70-KzhBfkDciU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 51919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51919&action=edit
Bug 16619 - installer stuck in infinite loop

To test: run the web installer on master, it should not get stuck in an
infinite loop.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 01:33:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 23:33:47 +0000
Subject: [Koha-bugs] [Bug 16619] Installer stuck in infinite loop
In-Reply-To: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16619-70-LJNUDw33q0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 01:37:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 May 2016 23:37:05 +0000
Subject: [Koha-bugs] [Bug 16619] Installer stuck in infinite loop
In-Reply-To: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16619-70-s1RS6AG9yu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Florent Mara <florent.mara at gmail.com> ---
I reset the Version value to 16.05, applied this patch to master and ran the
web installer. 

The web installer correctly updated the version number to 16.0600000 and the
web installer correctly re-directed to the Koha login page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 03:58:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 01:58:36 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-d1wOwAfmqd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 04:48:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 02:48:49 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-6dqP8BUL3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Srdjan Jankovic from comment #4)
> I think you should have included js removal with the patch, not used so
> should go.
> What's the story with the intranet basket?

Good points. It looks like the intranet has the same issue as the OPAC basket,
so I should change that...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 04:55:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 02:55:43 +0000
Subject: [Koha-bugs] [Bug 15541] Prevent normalization during
	matching/import process
In-Reply-To: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15541-70-AGRYvTYJRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #21 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #20)
> I understand your point hopefully :)
> If we start using this field: Since it was meant to add a Normalize class, I
> think you should create at least a rudimentary one now.
> Moving the _normalize code and add your none/raw normalizations.

I'm not sure that I understand your point, unfortunately :(.

I think using normalization during matching is a bad idea, as Zebra already
normalizes the query before processing it. Here's the problem:

Custom normalization: Strip hyphens
Zebra normalization: Strip colons

Data: "Mont-Royal: it's a mountain"

Zebra would index it as "Mont-Royal it's a mountain".
You'd retrieve that exact phrase with the query "Mont-Royal: it's a mountain",
which would be transformed into "Mont-Royal it's a mountain" by Zebra.

However, with the custom normalization, your query would be "MontRoyal: it's a
mountain" before going to Zebra, and then it would be "MontRoyal it's a
mountain" when processed by Zebra.

If you're doing an exact search, your search will fail, even though that same
data in the regular Koha search would work.

We need to normalize indexing/retrieval consistently, and the way to do that is
with Zebra alone.

If there needs to be extra normalization, I think it should be done before the
record even makes it to Koha...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 06:34:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 04:34:05 +0000
Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for
	makepayment
In-Reply-To: <bug-15896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15896-70-Zy5yyU44hq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

--- Comment #5 from Florent Mara <florent.mara at gmail.com> ---
Created attachment 51920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51920&action=edit
bug 15896 - A few tests for Koha::Account

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 06:38:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 04:38:07 +0000
Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for
	makepayment
In-Reply-To: <bug-15896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15896-70-vw9aymr6TI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com

--- Comment #6 from Florent Mara <florent.mara at gmail.com> ---
I have not had time to fully validate this patch but started to write some
tests for Koha::Account module. (I hope these tests won't be causing trouble) 

There would preferably be more tests but the method is ~150+ lines which makes
it difficult to get started.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:17:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:17:06 +0000
Subject: [Koha-bugs] [Bug 16620] New: Translatability: Fix problem with
 isolated word "please" in auth.tt
Message-ID: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

            Bug ID: 16620
           Summary: Translatability: Fix problem with isolated word
                    "please" in auth.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

In koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt, a tag-isolated word
"please" leads to translation problems (syntax in different languages).
Line 81: please <a href="[% casServerUrl %]">click here to login</a>.<p>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:19:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:19:27 +0000
Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated
 word "please" in auth.tt
In-Reply-To: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16620-70-WQxxvdeUIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:24:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:24:04 +0000
Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated
 word "please" in auth.tt
In-Reply-To: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16620-70-425dimK5Uh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 51921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51921&action=edit
Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt

This patch fixes a translatability problem (syntax in different languages) with
a tag-isolated word "please"
in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt

To test:
- Verify in code that in line 81 the word "please" is inside the a-tag.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:24:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:24:57 +0000
Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated
 word "please" in auth.tt
In-Reply-To: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16620-70-luC0GXB6Ho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:34:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:34:08 +0000
Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated
 word "please" in auth.tt
In-Reply-To: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16620-70-HvVO40gLqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Oh, there are more syntax problems...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:44:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:44:22 +0000
Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated
 word "please" in auth.tt
In-Reply-To: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16620-70-qqEdB3m5Qa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51921|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 51922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51922&action=edit
Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt

This patch fixes a translatability problem (syntax in different languages) with
a tag-isolated word "please"
in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt

To test:
- Verify in code that there is no sentence spliting by a-tags (lines 80/84).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 10:45:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 08:45:02 +0000
Subject: [Koha-bugs] [Bug 16620] Translatability: Fix problem with isolated
 word "please" in auth.tt
In-Reply-To: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16620-70-1t2GjOiBDM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16620

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:01:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:01:22 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-0iN6B9Vpq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #69 from Julian Maurice <julian.maurice at biblibre.com> ---
I forgot the last followup in 3.22.7, it will be in 3.22.8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:03:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:03:23 +0000
Subject: [Koha-bugs] [Bug 16619] Installer stuck in infinite loop
In-Reply-To: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16619-70-Ge4Myj3PgU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #3 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushing this past QA - thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:03:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:03:37 +0000
Subject: [Koha-bugs] [Bug 16619] Installer stuck in infinite loop
In-Reply-To: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16619-70-5UFF0dKYas@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16619

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:04:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:04:21 +0000
Subject: [Koha-bugs] [Bug 16621] New: Translatability: Issues in
 opac-user.tt (sentence splitting)
Message-ID: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621

            Bug ID: 16621
           Summary: Translatability: Issues in opac-user.tt (sentence
                    splitting)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Fix translation issues by sentence splitting in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 103:

<li id="renewal_blocked_fines"><strong>Please note: </strong> Since you have <a
href="/cgi-bin/koha/opac-account.pl">[% IF renewal_blocked_fines != "0.00" %]
more than <span id="renewal_blocked_fines_amount">[% renewal_blocked_fines
%]</span> in [% END %] fines</a>, you cannot renew your books online. Please
pay your fines if you wish to renew your books.</li>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:15:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:15:12 +0000
Subject: [Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a
	translation problem
In-Reply-To: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16200-70-bkHuoSmqX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #13 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:22:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:22:39 +0000
Subject: [Koha-bugs] [Bug 16532] Libraries and groups showing empty tables
 if nothing defined
In-Reply-To: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16532-70-BYmszGKu60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 11:36:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 09:36:37 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-k5c6BYGdgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Why not move this test to dependent btw?
Seeing several warns on Context and one on Templates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 12:33:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 10:33:37 +0000
Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on
	MySQL 5.6+
In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13669-70-WbsjUuIe7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #70 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Julian Maurice from comment #69)
> I forgot the last followup in 3.22.7, it will be in 3.22.8

Julian, have the PM add it on packaging!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 12:56:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 10:56:25 +0000
Subject: [Koha-bugs] [Bug 15939] modification logs view now silently
 defaults to only current day's actions
In-Reply-To: <bug-15939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15939-70-m0Nz440nfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 12:59:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 10:59:09 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-mAEgc28JLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a dumb question:
But don't we have other (easy) ways to achieve the same? Just hope so.
Now, we end up with large clickable texts (read: <a> tags)..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 13:40:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 11:40:43 +0000
Subject: [Koha-bugs] [Bug 16540] Translatability in opac-auth.tt
	(tag-splitted sentences)
In-Reply-To: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16540-70-azfzGnV2fx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
(In reply to Marcel de Rooy from comment #5)
> Just a dumb question:
> But don't we have other (easy) ways to achieve the same? Just hope so.
> Now, we end up with large clickable texts (read: <a> tags)..

I considered to have something like having an unlinked text as explanation
followed by a link, something like:
"Logout and try again with a different user. <a..>Click here</>"
... but I do not think that that would be nicer.

Anyway, I agree with every solution that does not lead to messy / incorrect
translations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 13:45:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 11:45:33 +0000
Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are
 no cities to list
In-Reply-To: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16001-70-LR2S5NmeBr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 13:47:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 11:47:30 +0000
Subject: [Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget
In-Reply-To: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16525-70-vKJOLCdHkB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 13:49:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 11:49:53 +0000
Subject: [Koha-bugs] [Bug 16524] Use floating toolbar on item search
In-Reply-To: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16524-70-aSsXAhdzLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 13:52:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 11:52:34 +0000
Subject: [Koha-bugs] [Bug 16511] Making contracts actions buttons
In-Reply-To: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16511-70-hNLmN9ue4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16511

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 13:53:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 11:53:47 +0000
Subject: [Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor
 search template
In-Reply-To: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16450-70-LK6V2EiUgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:24:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:24:48 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-AuJ92ew5SN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:24:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:24:50 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-LjZGjxSW7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51923&action=edit
Bug 16504: Add regression tests

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:24:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:24:56 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-dfisCMPHLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51924&action=edit
Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons

Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that
attributes
for every patrons will be deleted.

Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:25:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:25:00 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-oRKjjbXhMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 51925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51925&action=edit
Bug 16504: [QA Follow-up] Make koha-qa happy with two newlines

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:25:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:25:39 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-kAxxLehD7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:25:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:25:41 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-LNrefsOBDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51508|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:25:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:25:43 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-msbSTlRO5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51509|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:27:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:27:03 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-oGZHg7mEl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks for regression test.
Could have been little more explicit but is sufficient.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 14:39:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 12:39:23 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-RqdmPrH3J4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
We should consider looking for an upgrade or replacement which would fix Bug
11827.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:06:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:06:19 +0000
Subject: [Koha-bugs] [Bug 8023] Facebook share link not used current
	localization
In-Reply-To: <bug-8023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8023-70-cRVDuW75g6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I'm not sure there is a good solution for this. Here is what the share link
looks like:

http://www.facebook.com/sharer.php?u=[ OPAC url ]&t=[ Title ]

Nothing about the language of the OPAC page is being passed with the Facebook
link, and as far as I can tell there are no options to do so:

https://developers.facebook.com/x/bugs/357750474364812/

The share link seems to work just the same as when you paste a link into a new
post: Facebook parses the page you linked to and tries to build a preview for
it. If the OPAC being linked to has more than one language available, I assume
Facebook can only see the default one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:22:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:22:28 +0000
Subject: [Koha-bugs] [Bug 16529] Clean up and improve upload template
In-Reply-To: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16529-70-BiVjdHOAqv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:28:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:28:18 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-fVokNZbEkF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marcel de Rooy from comment #12)
> Why not move this test to dependent btw?
> Seeing several warns on Context and one on Templates.

What warns? I see a bunch of mock modules and functions. If I knew what you
were refering to, then perhaps I would understand why you said this. Otherwise,
with the mocks in place, it should be where it is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:32:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:32:01 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-MbyexAFU3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #8)
> Thanks for regression test.
> Could have been little more explicit but is sufficient.

What do you mean by "more explicit"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:38:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:38:58 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-VzQqxcXoXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #13)
> (In reply to Marcel de Rooy from comment #12)
> > Why not move this test to dependent btw?
> > Seeing several warns on Context and one on Templates.
> 
> What warns? I see a bunch of mock modules and functions. If I knew what you
> were refering to, then perhaps I would understand why you said this.
> Otherwise, with the mocks in place, it should be where it is.

Run the test. I see these warnings from Context.pm (and Templates.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:41:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:41:27 +0000
Subject: [Koha-bugs] [Bug 16504] All borrower attribute values for a given
 code deleted if that attribute has branch limits
In-Reply-To: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16504-70-NCUzEWToNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Marcel de Rooy from comment #8)
> > Thanks for regression test.
> > Could have been little more explicit but is sufficient.
> 
> What do you mean by "more explicit"?

It is not directly obvious what happens here.
And that you still have one record of a limited type for the other patron, that
would be deleted without this patch.
No big problem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:54:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:54:21 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-6nwccNmNcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marcel de Rooy from comment #14)
> Run the test. I see these warnings from Context.pm (and Templates.pm)

What warnings? Perhaps I am lacking data to trigger them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:58:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:58:07 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-Ujk44zhpHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #15)
> (In reply to Marcel de Rooy from comment #14)
> > Run the test. I see these warnings from Context.pm (and Templates.pm)
> 
> What warnings? Perhaps I am lacking data to trigger them?

Remove your KOHA_CONF since you are supposed to have no database?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 15:58:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 13:58:27 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-APTr5rfG8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #16)
> (In reply to M. Tompsett from comment #15)
> > (In reply to Marcel de Rooy from comment #14)
> > > Run the test. I see these warnings from Context.pm (and Templates.pm)
> > 
> > What warnings? Perhaps I am lacking data to trigger them?
> 
> Remove your KOHA_CONF since you are supposed to have no database?

from the env :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:00:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:00:24 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-WuuglOuqv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:00:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:00:26 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-T2mgSHyfiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51874|0                           |1
        is obsolete|                            |

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 51926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51926&action=edit
Bug 16609: Catch warning from Koha::Hold in Hold.t

Before this patch, the suspend step triggers a warn from Koha::Hold.
Now we catch it.

Test plan:
Run the test. Do not see the warning about unable to suspend.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

NOTE: Nice clean up!

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:01:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:01:48 +0000
Subject: [Koha-bugs] [Bug 16609] Catch warning from Koha::Hold in Hold.t
In-Reply-To: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16609-70-jxHAl8htSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16609

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. Tompsett from comment #5)
> NOTE: Nice clean up!
> 
> Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

This was on a fresh install.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:14:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:14:57 +0000
Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar
In-Reply-To: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16127-70-aR4UE9BwDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:14:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:14:59 +0000
Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar
In-Reply-To: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16127-70-3Qh5rfe7ZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51927&action=edit
Bug 16127 - Add discharge menu item to patron toolbar

This patch changes the "Discharge" menu in the patron sidebar to read
"Discharges," and adds a "Discharge" menu item to the patron toolbar.

This adds some redunancy, but fits with the pattern of including "views"
in the sidebar and "actions" in the menu. The discharge feature can be
thought of either way.

To test you must have the 'useDischarge' system preference enabled.

- View the detail page for any patron.
- Confirm that the sidebar menu reads "Discharges."
- Confirm that the "More" menu contains a "Discharge" link which works
  correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:16:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:16:49 +0000
Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs
	prettying
In-Reply-To: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16437-70-ZkveQ2J6rc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #12 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Pushed to Master - Should be in the November 2016 Release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:29:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:29:32 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-ltwMTrChrx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marcel de Rooy from comment #16)
> (In reply to M. Tompsett from comment #15)
> > (In reply to Marcel de Rooy from comment #14)
> > > Run the test. I see these warnings from Context.pm (and Templates.pm)
> > 
> > What warnings? Perhaps I am lacking data to trigger them?
> 
> Remove your KOHA_CONF since you are supposed to have no database?

It seems that 'prove t' demonstrates this is a larger problem than just Price.t

I would recommend moving that issue to another bug report, and moving forward
with this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:31:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:31:18 +0000
Subject: [Koha-bugs] [Bug 16508] User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16508-70-o00w9p874T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51573|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51928&action=edit
Bug 16508: Updating a syspref requires parameters_remaining_permissions

And not all of parameters flags.

Test plan:
1/ Create a staff user.
2/ Go to details, select more->set permissions.
3/ Set catalogue, Manage Koha system settings (Administration panel),
manage circulation rules, and Remaining system parameters permissions.
4/ Log in as the new staff user, go to administration > system
preferences. Change a syspref and save it... it will save correctly.
5/ Log back in as superlibrarian
6/ On the 'set permissions' screen, un-check 'manage circulation rules'
and save.
7/ Log back in to the new staff user, and try to change the same
systemprefrence and save.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:31:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:31:42 +0000
Subject: [Koha-bugs] [Bug 16508] User permission
 "parameters_remaining_permissions Remaining system parameters permissions"
 does not allow saving systempreferences.
In-Reply-To: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16508-70-d2v13NAhWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:33:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:33:16 +0000
Subject: [Koha-bugs] [Bug 16622] New: some tests triggered by prove t fail
 for unset KOHA_CONF
Message-ID: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

            Bug ID: 16622
           Summary: some tests triggered by prove t fail for unset
                    KOHA_CONF
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mtompset at hotmail.com
        QA Contact: gmcharlt at gmail.com

unset'ing KOHA_CONF from your environment, and then triggering 'prove t'
results in several tests warning and complaining about C4::Context.

Make sure failing tests are in the correct location (t vs t/db_dependent),
properly mocked, or catch the warnings. The second option being the preferred
one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:33:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:33:49 +0000
Subject: [Koha-bugs] [Bug 16582] t/Price.t test should pass if
 Test::DBIx::Class is not available
In-Reply-To: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16582-70-nCbrXrgguG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16622

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:33:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:33:49 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-r5sVMBeNa0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16582

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:42:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:42:54 +0000
Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual
 fine is wrong
In-Reply-To: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14605-70-q6JVVsPoaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51168|0                           |1
        is obsolete|                            |

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Created attachment 51929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51929&action=edit
Bug 14605 - Corrects the individual fine's description

When paying a fine, the description is built out of the borrower's type and
title, instead of the actual fine's description.

STEPS:
1) in the staff, go to a user with a fine to pay.
   a) if none, go to a user and Fines>>"Create manual invoice" with a
distinctive description.
2) In Fines>>Pay fines, click the "Pay" button on the line of the fine.
3) This will take you a "Pay an individual fine" screen, where the description
will look like "Staff Mrs", for the category and title of the borrower.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:43:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:43:30 +0000
Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual
 fine is wrong
In-Reply-To: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14605-70-9pp48dVTYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:51:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:51:55 +0000
Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card
 preview on acquisitions receipt summary page
In-Reply-To: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16592-70-qNwCWSkfwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51835|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51930&action=edit
Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions
receipt summary page

This patch replaces Greybox modals on the acquisitions receipt summary
page with Bootstrap modals.

To test, apply the patch and go to Acquisitions -> Invoices -> View an
invoice ->  Go to receipt page.

- In the list of pending orders, test the "MARC" and "Card" links for
  various titles. Each should trigger a Bootstrap modal with the correct
  content.
- Repeat the same tests in the list of already received orders.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 16:52:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 14:52:21 +0000
Subject: [Koha-bugs] [Bug 16592] Use Bootstrap modal for MARC and Card
 preview on acquisitions receipt summary page
In-Reply-To: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16592-70-AqvkDf1y6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:00:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:00:01 +0000
Subject: [Koha-bugs] [Bug 14261] Discharge management issues on OPAC
In-Reply-To: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14261-70-L0KWfKsO9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Indranil Das Gupta from comment #0)
> It should clearly mention that user was 'discharged', the above message is
> confusing and ambiguous for in this case.

Having not seen this bug report, I submitted the above as a separate bug: Bug
16464.

> 3/ "ask for a discharge" should preferably read "download discharge
> certificate" or something like that.

In order for the link text to change based on whether a discharge was or wasn't
requested or approved we would have to pull discharge data on every page in the
OPAC where the user menu is displayed.

I think a more efficient solution might be to:

1. Change the text of the link to "discharge requests" or something like that.
2. Fix Bug 16464 so that it is clear from looking at the user's account page
that they have an approved discharge available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:14:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:14:38 +0000
Subject: [Koha-bugs] [Bug 16467] Discharge requests pending count should
 appear on patrons home page
In-Reply-To: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16467-70-tUYQXeu9V4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16467

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I'm working on this, but I'm not sure what the message should say. "Your
account has been discharged?" "You have been discharged?"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:15:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:15:31 +0000
Subject: [Koha-bugs] [Bug 16467] Discharge requests pending count should
 appear on patrons home page
In-Reply-To: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16467-70-ldlzsHTQtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16467

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Whoops, that last comment was meant for Bug 16464.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:16:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:16:05 +0000
Subject: [Koha-bugs] [Bug 16464] If a patron has been discharged,
 show a message in the OPAC
In-Reply-To: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16464-70-Z7sExtwCYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I'm working on this, but I'm not sure what the message should say. "Your
account has been discharged?" "You have been discharged?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:18:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:18:41 +0000
Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the
 acquisition module home page
In-Reply-To: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16126-70-DmY0SYiwZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50438|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51931&action=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:19:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:19:36 +0000
Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the
 acquisition module home page
In-Reply-To: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16126-70-icDWjwDzFX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:22:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:22:45 +0000
Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar
In-Reply-To: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16127-70-0eihK9Zjd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51927|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51932&action=edit
Bug 16127 - Add discharge menu item to patron toolbar

This patch changes the "Discharge" menu in the patron sidebar to read
"Discharges," and adds a "Discharge" menu item to the patron toolbar.

This adds some redunancy, but fits with the pattern of including "views"
in the sidebar and "actions" in the menu. The discharge feature can be
thought of either way.

To test you must have the 'useDischarge' system preference enabled.

- View the detail page for any patron.
- Confirm that the sidebar menu reads "Discharges."
- Confirm that the "More" menu contains a "Discharge" link which works
  correctly.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:23:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:23:02 +0000
Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar
In-Reply-To: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16127-70-9NvFAORV4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:27:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:27:28 +0000
Subject: [Koha-bugs] [Bug 16123] Display budget hierarchy in the budget
 dropdown menu used when placing a new orde
In-Reply-To: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16123-70-3mbFIMgIph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16123

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50436|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 51933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51933&action=edit
Bug 16123 - Display budget hierarchy in the budget dropdown menu used when
placing a new order

When placing a new order, the budget dropdown will display the budget
hierarchy.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Select a vendor and create a new basket
7. Place an order
8. Check the budget dropdown menu

BEFORE PATCH
Book
Adult fiction

AFTER PATCH
Book
   Adult fiction

Dropbown menu is hierarchical as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 17:27:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 15:27:57 +0000
Subject: [Koha-bugs] [Bug 16123] Display budget hierarchy in the budget
 dropdown menu used when placing a new orde
In-Reply-To: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16123-70-ge5l0lu6VY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16123

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 18:07:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 16:07:04 +0000
Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for
	unset KOHA_CONF
In-Reply-To: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16622-70-TzBbKHYklv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           Assignee|chris at bigballofwax.co.nz    |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 18:07:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 16:07:56 +0000
Subject: [Koha-bugs] [Bug 16615] Full-site SSL: always use SSL when
 referencing external resources
In-Reply-To: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16615-70-EvoenMtXeX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 18:29:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 16:29:08 +0000
Subject: [Koha-bugs] [Bug 16623] New: Limit patron discharge management by
	library
Message-ID: <bug-16623-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16623

            Bug ID: 16623
           Summary: Limit patron discharge management by library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Like Bug 10904 and patron modification requests, discharge requests should
probably be limited by library. In fact I think it would make sense to use the
same system preference, IndependentBranchesPatronModifications, for both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 19:15:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 17:15:12 +0000
Subject: [Koha-bugs] [Bug 16624] New: Times are formatted incorrectly in
 slips ( AM PM ) due to double processing
Message-ID: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

            Bug ID: 16624
           Summary: Times are formatted incorrectly in slips ( AM PM ) due
                    to double processing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Letters.pm reformats the time once for title, once for content, this causes
improper formatting of timestamps and makes all times appear as AM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 19:15:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 17:15:31 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-3CHjcpf7Ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 19:18:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 17:18:30 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-9bCOYCLQ6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 19:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 17:18:32 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-3TPAPiKaqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51934&action=edit
Bug 16624 - Times are formatted incorrectly in slips ( AM PM ) due to double
processing

To test:
1 - Checkout an item (with default time 11:59:00 PM)
2 - Generate a quickslip
3 - Notice the time is 'AM'
4 - Apply patch
5 - Generate quickslip
6 - Note time is correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 20:16:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 18:16:54 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-nVF2CNWywG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 20:16:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 18:16:57 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-WswfuOWECo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51935&action=edit
Bug 16421 - Move hold edit actions into dropdown menu

This patch modifies the view of existing holds in the staff client so
that holds-related actions are moved into an 'actions' menu. This
includes priority-reordering controls, suspend, and cancel.

This patch also modifies the display of details for each hold so that
its suspension or priority status is clear.

To test, apply the patch and view holds for a title with multiple holds.

- Test the priority-reordering controls and confirm that they work
  correctly.
- Test the "suspend" link and confirm that the suspension form is
  displayed correctly in a modal window.
  - Confirm that suspensions are saved correctly with and without a
    date, and that suspension information is displayed correctly after
    saving.
- Test the "Cancel hold" link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 20:41:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 18:41:35 +0000
Subject: [Koha-bugs] [Bug 16625] New: add time_added column to zebraqueue
Message-ID: <bug-16625-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16625

            Bug ID: 16625
           Summary: add time_added column to zebraqueue
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

I've run into zebra daemon performance issues. I would like to be able to run
queries that look something like this:

-- Find finished rows in zebraqueue that took more than 10 minutes to process.
select
    time_added,
    time,
    time - time_added as difference
from
    zebraqueue
where
    done = 1
    and time - time_added > 600
order by time_added

... but there's no time_added column in zebraqueue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 21:31:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 19:31:29 +0000
Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists
 when in that module
In-Reply-To: <bug-15213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15213-70-qQPHrytldX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 21:31:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 19:31:31 +0000
Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists
 when in that module
In-Reply-To: <bug-15213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15213-70-SslxHCCaTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45033|0                           |1
        is obsolete|                            |

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 51936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51936&action=edit
[SIGNED-OFF] Bug 15213 - Fix tools sidebar to highlight Patron lists when in
that module

To test:

Add some patron lists, navigate through the lists interface and make
sure that while you are in the module, that Patron lists is highlighted
on the sidebar.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 21:46:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 19:46:04 +0000
Subject: [Koha-bugs] [Bug 16626] New: downloaded files should have
 descriptive names including timestamps.
Message-ID: <bug-16626-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16626

            Bug ID: 16626
           Summary: downloaded files should have descriptive names
                    including timestamps.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When downloading exported marc records, creator card batches, creator label
batches or report results, the resulting file names are not unique, and none of
the names is terribly descriptive.

I would suggest a library function that emits a filename formatted something
like this

${description}-${date}.${extension}

Where ${description} is

exported marc => "koha_export.$START-$END"
    $START => first biblionumber in file
    $END => last biblionumber in file (range is omitted if there's only one
bib)

card batches  => "creator_batch.$batchnumber"
label batches => "label_batch.$batchnumber"
report        => "report.${report.id}.${sanitized_report_name}"
    ${sanitized_report_name} => shell friendly, i.e. s/[^A-Za-z0-9]+/_/g


${date}
    --iso-8601 formatted, shell friendly.

${extension}
    csv, pdf, marc, marcxml, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 22:08:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 20:08:19 +0000
Subject: [Koha-bugs] [Bug 16627] New: Patron Update Organization
Message-ID: <bug-16627-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16627

            Bug ID: 16627
           Summary: Patron Update Organization
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Patron updates need to be grouped by library (when you can see them all) and
should show the date the request was made (how long has it been sitting
there?).

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 22:31:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 20:31:12 +0000
Subject: [Koha-bugs] [Bug 16628] New: Patrons requesting modifications link
 behaves differently on the home page than the members-home.pl page
Message-ID: <bug-16628-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16628

            Bug ID: 16628
           Summary: Patrons requesting modifications link behaves
                    differently on the home page than the members-home.pl
                    page
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would appear that the links do not behave the same between the
members-update.pl page and mainpage.pl.  When
IndependentBranchesPatronModifications is set to Prevent, the link on
mainpage.pl shows the count for your library, and only shows when your library
has requests.  However, the link ALWAYS shows on members-update.pl, and shows
the total of all requests.

I don't believe any other feature in Koha works this way, and I don't believe
this should be the behavior of this feature.  In my opinion, the link on
mainpage.pl behaves correctly, and the link on members-update.pl should be
changed to do the same.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 22:45:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 20:45:39 +0000
Subject: [Koha-bugs] [Bug 16629] New: Fields available for printing are
 inconsistent between label layouts and SpineLablFormat system preference
Message-ID: <bug-16629-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16629

            Bug ID: 16629
           Summary: Fields available for printing are inconsistent between
                    label layouts and SpineLablFormat system preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In label layouts all marc fields are available, however, when setting quick
spine fields in the system preferences you can only use columns from the db
tables. It would be nice to have access to record fields here as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 23:01:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 21:01:06 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-EH5Y1S7npJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 23:01:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 21:01:08 +0000
Subject: [Koha-bugs] [Bug 16624] Times are formatted incorrectly in slips (
 AM PM ) due to double processing
In-Reply-To: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16624-70-KzMlKUI9BG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51934|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 51937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51937&action=edit
[SIGNED-OFF] Bug 16624 - Times are formatted incorrectly in slips ( AM PM ) due
to double processing

To test:
1 - Checkout an item (with default time 11:59:00 PM)
2 - Generate a quickslip
3 - Notice the time is 'AM'
4 - Apply patch
5 - Generate quickslip
6 - Note time is correct

Signed-off-by: Jason Burds <JBurds at dubuque.lib.ia.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 23:03:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 21:03:42 +0000
Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists
 when in that module
In-Reply-To: <bug-15213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15213-70-cwBdtzfEKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

--- Comment #10 from Liz Rea <liz at catalyst.net.nz> ---
Ha I forgot all about this patch. Thanks Owen!

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 23:20:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 21:20:28 +0000
Subject: [Koha-bugs] [Bug 16629] Fields available for printing are
 inconsistent between label layouts and SpineLablFormat system preference
In-Reply-To: <bug-16629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16629-70-11OTkTJbUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16629

--- Comment #1 from Chris Nighswonger <cnighswonger at foundations.edu> ---
IIRC, this is due to these features being written separately by separate devs.
I don't know how difficult it would be to make the quick spine code use the
label code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue May 31 23:55:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2016 21:55:37 +0000
Subject: [Koha-bugs] [Bug 16630] New: Superlibrarian should be able to
 see/use all patron categories
Message-ID: <bug-16630-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16630

            Bug ID: 16630
           Summary: Superlibrarian should be able to see/use all patron
                    categories
 Change sponsored?: ---
           Product: Koha
           Version: 3.22
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would appear that patron categories are limited, even to superlibrarians, if
there are branch limitations set.  The superlibrarian should not have such a
limitation.

To test:
1) Set a patron category to be used by only 1 branch.
2) Logged in as a superlibrarian, have your library set to that branch.
3) Create a new patron.
4) Check that the limited category shows in the Category field.
5) Still logged in as the superlibrarian, change your library to another
branch.
6) Create a new patron.
7) Confirm that you can no longer use that limited patron category in the
Category field.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.