[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #85 from Florent Mara <florent.mara at gmail.com> ---
I agree 100% Katrin. Being merge master at work, I know the pain and have
debated the options several times. It was already a bit patch when I found it,
only made it bigger ...

Overall, I doubt more than 30 lines of 'working' code has been added so far.
Most of my contributions are tests + bug fixes. ~95% of my refactoring is
taking chunks of existing code from the main script and putting it in methods.
Then adding pedantic tests to validate equivalence of output.
The other 5% are defect fixes. 

I thought of stopping last week then found a defect so kept going (I intended
to create a specific bug report for the dates defect but ran out of time
today). Then a second - minor - defect while at it today. 

Ultimately, none of my work is intended to change code behavior - unless
defect. This refactoring + tests work is in preparation for my task of
improving the importer performance which is hardly possible while working on a
300 lines untested script.

For test plan, I use the 1000 entries file from the importer performance bug,
would it be worth giving more details here? I loaded plenty of patrons today,
it would be good for someone else to give it a try and update the status.

-- 
You are receiving this mail because:
You are watching all bug changes.