[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #13)
> On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010?
> If there is no further development(?), this might be a risk.

I can see that as blocker, Mason, would it be easy to update the plugin you
used?

(In reply to Frédéric Demians from comment #14)
> I don't see the advantage of this implementation against Bywater plugin. I
> can
> rather see disadvantages, including ContentFlow.js obsolescence (not updated
> since 2010, when jQuery Flipster used by ByWater plugin is actively
> maintained). Reading the code, I don't understand how GetRecentBibs generates
> the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to
> read/re-read this table each time the OPAC main page is loaded?

Same for me, it's not conceivable to call this subroutine for each get of the
opac main page. Could you please detail what is the purpose of this subroutine?
Why do you need a new table, cache of the image url that's it?

Additional comments:
- kohastructure.sql changes are missing
- Amazon lookup should be optional
- We have several subroutines in C4::Koha to deal with ISBNs, I am sure you
could reuse
- What are the 150 and 300 hardcoded limits?
- It would be better to use Koha::Object
- It would be great to remove all the debug variables, it will ease the
readability

-- 
You are receiving this mail because:
You are watching all bug changes.