[Koha-bugs] [Bug 16448] New: Perlcritic errors introduced by 12478

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448

            Bug ID: 16448
           Summary: Perlcritic errors introduced by 12478
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/00-testcritic.t 
t/00-testcritic.t .. 113/728 
#   Failed test 'Test::Perl::Critic for "catalogue/search.pl"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "catalogue/search.pl":
# "@results" is declared but not used at line 475, column 1.  Unused variables
clutter code and make it harder to read.  (Severity: 3)
t/00-testcritic.t .. 262/728 
#   Failed test 'Test::Perl::Critic for "Koha/Authority.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "Koha/Authority.pm":
# "return" statement with explicit "undef" at line 67, column 9.  See page 199
of PBP.  (Severity: 5)
t/00-testcritic.t .. 723/728 # Looks like you failed 2 tests of 728.
t/00-testcritic.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/728 subtests 

Test Summary Report
-------------------
t/00-testcritic.t (Wstat: 512 Tests: 728 Failed: 2)
  Failed tests:  114, 265
  Non-zero exit status: 2
Files=1, Tests=728, 139 wallclock secs ( 0.20 usr  0.01 sys + 127.21 cusr 10.62
csys = 138.04 CPU)
Result: FAIL
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.