[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #9 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Trying to evaluate this patch, but I'm having trouble understanding how it
works.

$Koha::CGI::language is a package variable (persistent under plack); if some
stript calls Languages::getlanguage() without calling Koha::CGI->new()
somewhere earlier, it may pick "outdated" language code (set by some other
script which was calling getlanguage() first).

Not sure if the parameters in "use Koha::CGI qw('-no_undef_params' -utf8 )"
will get propagated from catalogue/search.pl to Koha::CGI somehow, there is no
"use CGI qw( -utf8 );" in the Koha/CGI.pm, there is only commented out "# use
base CGI;" (?).

BTW, I wonder why there is "use CGI" instead of "use CGI (-uft8)" in
C4::Languages, looks like some kind of exception or omission - is there a
correlation with Bug 13815? Can't find an explanation in Bug 13815 why exactly
plack was losing that uft8 flag in the 1st place..

-- 
You are receiving this mail because:
You are watching all bug changes.