[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue May 10 04:06:35 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426

Florent Mara <florent.mara at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.mara at gmail.com

--- Comment #14 from Florent Mara <florent.mara at gmail.com> ---
While rebasing bug 12598, I backported this patch and it broke my tests.

(unless I missed something) With this patch, either overwrite_cardnumber is set
to 0 and the duplicate borrower number will be caught as an 'already_in_db'
feedback - before reaching the new code and get to the next input line. 

OR overwrite_cardnumber is set to 1 and duplicates are overwritten anyway. 

In other words, there does not appear to be any duplicate userid check anymore
with the current code.

In bug 12598, I relocated the new code block above 'if ($borrowernumber) {' to
restore functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list